Re: [Qemu-devel] [PATCH 1/3] input: add missing JIS keys to virtio input

2017-12-23 Thread Miika S
Blake wrote: > On 12/18/2017 07:24 AM, Miika S wrote: >> >> Signed-off-by: Miika S >> --- >> hw/input/virtio-input-hid.c | 7 +++ >> qapi/ui.json| 2 +- >> ui/keycodemapdb | 2 +- >> 3 files changed, 9 insertions(+), 2 de

[Qemu-devel] [PATCH 3/3] input: virtio: don't send mouse wheel event twice

2017-12-22 Thread Miika S
On Linux, a mouse event is generated for both down and up when mouse wheel is used. This caused virtio_input_send() to be called twice each time the wheel was used. This commit adds a check for the button down state and only calls virtio_input_send() when it is true. Signed-off-by: Miika S

[Qemu-devel] [PATCH 2/3] input: add mouse side buttons to virtio input

2017-12-22 Thread Miika S
Signed-off-by: Miika S --- hw/input/virtio-input-hid.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c index 9628d289f9..2cac659469 100644 --- a/hw/input/virtio-input-hid.c +++ b/hw/input/virtio-input-hid.c @@ -154,6 +154,8

[Qemu-devel] [PATCH 0/3] input: add keys and mouse buttons to virtio input

2017-12-22 Thread Miika S
utton up and down by only forwarding the event when the button state is down. Miika S (3): input: add missing JIS keys to virtio input input: add mouse side buttons to virtio input input: virtio: don't send mouse wheel event twice hw/input/virtio-input-hid.c | 15 +-- qa

[Qemu-devel] [PATCH 1/3] input: add missing JIS keys to virtio input

2017-12-22 Thread Miika S
keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana Signed-off-by: Miika S --- hw/input/virtio-input-hid.c | 7 +++ qapi/ui.json| 5 - ui/keycodemapdb | 2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/hw/input/virtio

[Qemu-devel] [PATCH 3/3] input: virtio: don't send mouse wheel event twice

2017-12-18 Thread Miika S
On Linux, a mouse event is generated for both down and up when mouse wheel is used. This caused virtio_input_send() to be called twice each time the wheel was used. This commit adds a check for the button down state and only calls virtio_input_send() when it is true. Signed-off-by: Miika S

[Qemu-devel] [PATCH 2/3] input: add mouse side buttons to virtio input

2017-12-18 Thread Miika S
Signed-off-by: Miika S --- hw/input/virtio-input-hid.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c index 9628d289f9..2cac659469 100644 --- a/hw/input/virtio-input-hid.c +++ b/hw/input/virtio-input-hid.c @@ -154,6 +154,8

[Qemu-devel] [PATCH 1/3] input: add missing JIS keys to virtio input

2017-12-18 Thread Miika S
Signed-off-by: Miika S --- hw/input/virtio-input-hid.c | 7 +++ qapi/ui.json| 2 +- ui/keycodemapdb | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c index e78faec0b1..9628d289f9 100644

Re: [Qemu-devel] Key code conflict in keycodemapdb

2017-12-15 Thread Miika S
twice. -- >From 506f0bf52b9743e19a65be83be8adf4782edd21b Mon Sep 17 00:00:00 2001 From: Miika S Date: Fri, 15 Dec 2017 21:50:23 +0200 Subject: [PATCH 1/1] Add missing QKeyCode values for JIS keyboards The AT set1

[Qemu-devel] Key code conflict in keycodemapdb

2017-12-15 Thread Miika S
Hi I tried to add JIS keyboard support to virtio-input-hid but ran into a problem with keys that have the "Linux Name" KEY_ISO and KEY_KATAKANAHIRAGANA. The problem appears to be that they have the same "AT set1 keycode" 0x70. I worked around it by removing KEY_ISO from keycodemapdb and got the ke