Re: Add 'info pg' command to monitor

2024-04-17 Thread Nadav Amit
> On 17 Apr 2024, at 11:30, Nadav Amit wrote: > > > >> On 16 Apr 2024, at 21:11, Don Porter wrote: >> >> On 4/16/24 13:03, Peter Maydell wrote: >>> On Tue, 16 Apr 2024 at 17:53, Don Porter wrote: >>>> There is still a lot I am l

Re: Add 'info pg' command to monitor

2024-04-17 Thread Nadav Amit
> On 16 Apr 2024, at 21:11, Don Porter wrote: > > On 4/16/24 13:03, Peter Maydell wrote: >> On Tue, 16 Apr 2024 at 17:53, Don Porter wrote: >>> There is still a lot I am learning about the code base, but it seems >>> that qemu_get_guest_memory_mapping() does most of what one would need. >>> I

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Nadav Amit
> On Mar 31, 2020, at 7:09 AM, David Hildenbrand wrote: > > On 31.03.20 16:07, Michael S. Tsirkin wrote: >> On Tue, Mar 31, 2020 at 04:03:18PM +0200, David Hildenbrand wrote: >>> On 31.03.20 15:37, Michael S. Tsirkin wrote: On Tue, Mar 31, 2020 at 03:32:05PM +0200, David Hildenbrand wrote: >

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Nadav Amit
> On Mar 31, 2020, at 6:32 AM, David Hildenbrand wrote: > > On 31.03.20 15:24, Michael S. Tsirkin wrote: >> On Tue, Mar 31, 2020 at 12:35:24PM +0200, David Hildenbrand wrote: >>> On 26.03.20 10:49, Michael S. Tsirkin wrote: On Thu, Mar 26, 2020 at 08:54:04AM +0100, David Hildenbrand wrote: >

Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset

2015-09-16 Thread Nadav Amit
On Mon, 2015-04-13 at 02:32 +0300, Nadav Amit wrote: >>>> Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long >>>> gone >>>> and therefore this hack is no longer needed. Since it violates the >>>> specifications, it is re

Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset

2015-09-15 Thread Nadav Amit
I'll try to reproduce the problem today. Nadav On Sep 16, 2015 8:23 AM, "Jan Kiszka" wrote: > On 2015-09-15 23:19, Alex Williamson wrote: > > On Mon, 2015-04-13 at 02:32 +0300, Nadav Amit wrote: > >> Due to old Seabios bug, QEMU reenable LINT0 after reset.

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks

2015-04-13 Thread Nadav Amit
Paolo Bonzini wrote: > > > On 13/04/2015 01:32, Nadav Amit wrote: >> +if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) { > > The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not > KVM_CAP_ENABLE_CAP_VM. > > Paolo > >

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks

2015-04-13 Thread Nadav Amit
Paolo Bonzini wrote: > > > On 13/04/2015 16:17, Nadav Amit wrote: >> Paolo Bonzini wrote: >> >>> On 13/04/2015 01:32, Nadav Amit wrote: >>>> +if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) { >>> >>> The r

[Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset

2015-04-12 Thread Nadav Amit
Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long gone and therefore this hack is no longer needed. Since it violates the specifications, it is removed. Signed-off-by: Nadav Amit --- hw/intc/apic_common.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks

2015-04-12 Thread Nadav Amit
KVM has quirks to overcome legacy QEMU bugs that are already resolved. Using a new KVM feature for disabling these quirks. Signed-off-by: Nadav Amit --- linux-headers/asm-x86/kvm.h | 4 linux-headers/linux/kvm.h | 1 + target-i386/kvm.c | 8 3 files changed, 13

[Qemu-devel] [PATCH 0/2] target-i386: disable LINT0 after reset and init

2015-04-12 Thread Nadav Amit
NW from CR0 after reset. Thanks for reviewing these patches. Nadav Amit (2): target-i386: disable LINT0 after reset target-i386: kvm: Disable KVM quirks hw/intc/apic_common.c | 9 - linux-headers/asm-x86/kvm.h | 4 linux-headers/linux/kvm.h | 1 + target-i386/kvm.c

[Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-01 Thread Nadav Amit
BSP bit. Signed-off-by: Nadav Amit --- hw/intc/apic_common.c | 8 ++-- include/hw/i386/apic.h | 2 +- target-i386/cpu.c | 4 +--- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index 0858b45..042e960 100644 --- a/hw/intc

[Qemu-devel] [PATCH v2] Basic Intel IOMMU DMAR emulation

2010-04-14 Thread Nadav Amit
3. No protection of read-only registers in the IOMMU. 4. No protection according to protection memory ranges Signed-off-by: Nadav Amit --- Makefile.target |1 + cpu-common.h | 26 ++ dma-helpers.c| 20 +- dma.h|6 +- exec.c | 100 +++- hw/DMA

[Qemu-devel] [PATCH] Basic Intel IOMMU DMAR emulation

2010-04-07 Thread Nadav Amit
bling queued invalidation set in the command line: -intel-iommu queue -acpitable sig=DMAR,data=hw/DMAR.dat Signed-off-by: Nadav Amit --- Makefile.target |1 + cpu-common.h | 22 ++ dma-helpers.c| 20 +- dma.h|6 +- exec.c | 100 ++- hw/DMA