[Qemu-devel] [PATCH v2] ui/vnc: make sure necessary shift-states are in effect when sending keys

2015-01-25 Thread Nathan Baum
I wasn't sure whether to do this for all the modifiers - my use case doesn't call for it - so I didn't. Signed-off-by: Nathan Baum --- ui/vnc.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index a742c90..acfb24e 10064

[Qemu-devel] [PATCH] ui/vnc: make sure necessary shift-states are in effect when sending keys

2015-01-25 Thread Nathan Baum
oesn't call for it - so I didn't. Signed-off-by: Nathan Baum --- ui/vnc.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index a742c90..200cdd7 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1893,7 +1893,22 @@ static void do_key_eve

Re: [Qemu-devel] [RFC,PATCH 08/11] qdev: Add usb_bus_dev_info

2010-01-15 Thread Nathan Baum
On Fri, 2010-01-15 at 19:14 +0100, Markus Armbruster wrote: > Nathan Baum writes: > > > Returns a QObject with information about a USB device. > > > > Signed-off-by: Nathan Baum > > --- > > hw/usb-bus.c | 13 + > > 1 files changed, 13

Re: [Qemu-devel] [PATCH 04/11] qdev: pcibus_dev_info

2009-12-29 Thread Nathan Baum
On Tue, 2009-12-29 at 15:08 -0200, Luiz Capitulino wrote: > > +class = pci_get_word(d->config + PCI_CLASS_DEVICE); > > +desc = pci_class_descriptions; > > +while (desc->desc && class != desc->class) > > +desc++; > > +if (desc->desc) { > > +qdict_put(qobject_to_qdict

Re: [Qemu-devel] [PATCH 10/11] qdev: Add do_info_qbus and friends.

2009-12-29 Thread Nathan Baum
On Tue, 2009-12-29 at 15:13 -0200, Luiz Capitulino wrote: > > +qdict_put(qdict, "gpio-in", qint_from_int(dev->num_gpio_in)); > > +qdict_put(qdict, "gpio-out", qint_from_int(dev->num_gpio_out)); > > Is this a boolean? If so you should use qbool_from_int(). It isn't, but they shouldn't be

Re: [Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree.

2009-12-29 Thread Nathan Baum
On Tue, 2009-12-29 at 15:15 -0200, Luiz Capitulino wrote: > On Sat, 26 Dec 2009 21:19:22 + > Nathan Baum wrote: > > > Signed-off-by: Nathan Baum > > --- > > hw/qdev.c |9 - > > hw/qdev.h |3 ++- > > monitor.c |3 ++- > > 3

Re: [Qemu-devel] [RFC,PATCH 00/11] Half-convert info qtree to QMP.

2009-12-26 Thread Nathan Baum
Oops. Sorry for the spam. Your client isn't broken. Due to mail server misconfiguration on my part, I've managed to send this patch series twice. I thought it hadn't been sent the first time around. Guess it was hidden in a queue somewhere.

[Qemu-devel] [RFC, PATCH 07/11] qdev: Add sysbus_dev_info to system_bus_info

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/sysbus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index 2092d9f..5d2bbb4 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -23,11 +23,13 @@ #include "qjson.h" static void sysbus_dev_print(Mo

[Qemu-devel] [RFC, PATCH 01/11] Add info_dev function pointer for BusInfo.

2009-12-26 Thread Nathan Baum
This function will be called to produce bus-specific data for QMP's query-qtree command. Signed-off-by: Nathan Baum --- hw/qdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index bbcdba1..93467a5 100644 --- a/hw/qdev.h +++ b/hw/q

[Qemu-devel] [RFC,PATCH 06/11] qdev: sysbus_dev_info

2009-12-26 Thread Nathan Baum
Returns information about the system bus as a QObject. Signed-off-by: Nathan Baum --- hw/sysbus.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index 1f7f138..2092d9f 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -20,6 +20,7

[Qemu-devel] [RFC, PATCH 09/11] qdev: Add usb_bus_dev_info to usb_bus_info.

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/usb-bus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 6d02807..582924d 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -6,11 +6,13 @@ #include "qjson.h" static void usb_bus_dev_pri

[Qemu-devel] [RFC, PATCH 03/11] qdev: Add isabuf_dev_info to ISA's BusInfo struct.

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/isa-bus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index b3d599f..ed965d8 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -32,11 +32,13 @@ struct ISABus { static ISABus *isabus; static void

[Qemu-devel] [RFC, PATCH 11/11] Change the monitor to use the new do_info_qtree.

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/qdev.c |9 - hw/qdev.h |3 ++- monitor.c |3 ++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index f5d68c6..d9d3778 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -727,6 +727,12 @@ static void do_info_qbus

[Qemu-devel] [RFC,PATCH 08/11] qdev: Add usb_bus_dev_info

2009-12-26 Thread Nathan Baum
Returns a QObject with information about a USB device. Signed-off-by: Nathan Baum --- hw/usb-bus.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 54027df..6d02807 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -3,6 +3,7

[Qemu-devel] [RFC,PATCH 10/11] qdev: Add do_info_qbus and friends.

2009-12-26 Thread Nathan Baum
Places information about a bus and the devices on into a QObject. Signed-off-by: Nathan Baum --- hw/qdev.c | 73 + 1 files changed, 73 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index b6bd4ae..f5d68c6 100644

[Qemu-devel] [PATCH 09/11] qdev: Add usb_bus_dev_info to usb_bus_info.

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/usb-bus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 6d02807..582924d 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -6,11 +6,13 @@ #include "qjson.h" static void usb_bus_dev_pri

[Qemu-devel] [RFC,PATCH 04/11] qdev: pcibus_dev_info

2009-12-26 Thread Nathan Baum
This returns a QObject detailing the PCI-specific data about the device. Signed-off-by: Nathan Baum --- hw/pci.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 9722fce..8688d8a 100644 --- a/hw

[Qemu-devel] [PATCH 11/11] Change the monitor to use the new do_info_qtree.

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/qdev.c |9 - hw/qdev.h |3 ++- monitor.c |3 ++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index f5d68c6..d9d3778 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -727,6 +727,12 @@ static void do_info_qbus

[Qemu-devel] [PATCH 10/11] qdev: Add do_info_qbus and friends.

2009-12-26 Thread Nathan Baum
Places information about a bus and the devices on into a QObject. Signed-off-by: Nathan Baum --- hw/qdev.c | 73 + 1 files changed, 73 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index b6bd4ae..f5d68c6 100644

[Qemu-devel] [RFC, PATCH 05/11] qdev: Add pcibus_dev_info to pci_bus_info

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/pci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 8688d8a..36605e7 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -59,11 +59,13 @@ struct PCIBus { }; static void pcibus_dev_print(Monitor *mon, DeviceState *dev

[Qemu-devel] [PATCH 08/11] qdev: Add usb_bus_dev_info

2009-12-26 Thread Nathan Baum
Returns a QObject with information about a USB device. Signed-off-by: Nathan Baum --- hw/usb-bus.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 54027df..6d02807 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -3,6 +3,7

[Qemu-devel] [RFC,PATCH 00/11] Half-convert info qtree to QMP.

2009-12-26 Thread Nathan Baum
Hullo. This series of patches partially converts info qtree to QMP. I've gone halfway: one can use query-qtree in QMP. I haven't converted the old monitor function other than to rename it; do_info_qtree_print just ignores the QObject it is passed and prints the qtree the old-fashioned way. hw/

[Qemu-devel] [PATCH 04/11] qdev: pcibus_dev_info

2009-12-26 Thread Nathan Baum
This returns a QObject detailing the PCI-specific data about the device. Signed-off-by: Nathan Baum --- hw/pci.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 9722fce..8688d8a 100644 --- a/hw

[Qemu-devel] [PATCH 07/11] qdev: Add sysbus_dev_info to system_bus_info

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/sysbus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index 2092d9f..5d2bbb4 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -23,11 +23,13 @@ #include "qjson.h" static void sysbus_dev_print(Mo

[Qemu-devel] [RFC, PATCH 02/11] qdev: isabus_dev_info returns a QObject detailing the IRQ lines used by the device.

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/isa-bus.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 4d489d2..b3d599f 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -21,6 +21,8 @@ #include "monitor.h" #include

[Qemu-devel] [PATCH 03/11] qdev: Add isabuf_dev_info to ISA's BusInfo struct.

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/isa-bus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index b3d599f..ed965d8 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -32,11 +32,13 @@ struct ISABus { static ISABus *isabus; static void

[Qemu-devel] [PATCH 06/11] qdev: sysbus_dev_info

2009-12-26 Thread Nathan Baum
Returns information about the system bus as a QObject. Signed-off-by: Nathan Baum --- hw/sysbus.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index 1f7f138..2092d9f 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -20,6 +20,7

[Qemu-devel] [PATCH 05/11] qdev: Add pcibus_dev_info to pci_bus_info

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/pci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 8688d8a..36605e7 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -59,11 +59,13 @@ struct PCIBus { }; static void pcibus_dev_print(Monitor *mon, DeviceState *dev

[Qemu-devel] [PATCH 01/11] Add info_dev function pointer for BusInfo.

2009-12-26 Thread Nathan Baum
This function will be called to produce bus-specific data for QMP's query-qtree command. Signed-off-by: Nathan Baum --- hw/qdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index bbcdba1..93467a5 100644 --- a/hw/qdev.h +++ b/hw/q

[Qemu-devel] [RFC,PATCH 00/11] Half-convert info qtree to QMP.

2009-12-26 Thread Nathan Baum
Hullo. This series of patches partially converts info qtree to QMP. I've gone halfway: one can use query-qtree in QMP. I haven't converted the old monitor function other than to rename it; do_info_qtree_print just ignores the QObject it is passed and prints the qtree the old-fashioned way. hw/

[Qemu-devel] [PATCH 02/11] qdev: isabus_dev_info returns a QObject detailing the IRQ lines used by the device.

2009-12-26 Thread Nathan Baum
Signed-off-by: Nathan Baum --- hw/isa-bus.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 4d489d2..b3d599f 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -21,6 +21,8 @@ #include "monitor.h" #include

Re: [Qemu-devel] [PATCH 3/7] QMP: Assure that returned data is a QDict

2009-12-21 Thread Nathan Baum
On Fri, 2009-12-18 at 13:25 -0200, Luiz Capitulino wrote: > This is for debug purposes only. This breaks quite a lot of commands where the returned data is a QList, e.g. query-commands, query-mice, query-cpus. Is the assert wrong, or are such commands meant to be returning a QDict? > Signed-off-b