[Qemu-devel] Fwd: [PATCH v2 5/5] Change return type of functions that are named *_exit or *_exitfn in hw/usb from int to void

2016-04-12 Thread Nutan Shinde
This change is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/usb package. Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/usb/ccid-card-emulated.c | 3 +-- hw/usb/ccid.h | 2 +- hw/u

[Qemu-devel] Fwd: [PATCH v2 4/5] Change return type of functions that are named *_exit or *_exitfn in hw/s390x from int to void

2016-04-12 Thread Nutan Shinde
This change is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/s390x package. Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/s390x/virtio-ccw.c | 7 +++ hw/s390x/virtio-ccw.h | 2 +- 2 files chan

[Qemu-devel] Fwd: [PATCH v2 3/5] Change return type of functions that are named *_exit or *_exitfn in hw/core from int to void

2016-04-12 Thread Nutan Shinde
This change is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/core package. Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/core/qdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --gi

[Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void

2016-04-12 Thread Nutan Shinde
This change is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/char package. Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/char/sclpconsole-lm.c | 3 +-- hw/char/sclpconsole.c| 3 +-- 2 files chan

[Qemu-devel] Fwd: [PATCH v2 1/5] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void

2016-04-12 Thread Nutan Shinde
This changes is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/audio package. Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/audio/intel-hda.h

[Qemu-devel] [PATCH v2 1/5] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void

2016-04-12 Thread Nutan Shinde
This changes is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/audio package. Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/audio/intel-hda.h

Re: [Qemu-devel] [PATCH] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void

2016-04-12 Thread Nutan Shinde
Hi, Please ignore this patch, I have sent a new patch with version v2, in subject line, which has updated changes. Regards, Nutan. On Tue, Apr 12, 2016 at 11:24 PM, Nutan Shinde <nutanshinde1...@gmail.com> wrote: > This changes is required because the return type of exit(error)

[Qemu-devel] [PATCH v2 1/5] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void

2016-04-12 Thread Nutan Shinde
This changes is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/audio package. Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/audio/intel-hda.h

[Qemu-devel] [PATCH] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void

2016-04-12 Thread Nutan Shinde
This changes is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/audio package. Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/audio/intel-hda.h

Re: [Qemu-devel] [PATCH] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void.

2016-04-09 Thread Nutan Shinde
eter.mayd...@linaro.org> wrote: > On 24 March 2016 at 17:18, Nutan Shinde <nutanshinde1...@gmail.com> wrote: > > Hi; thanks for this patch; I have some comments below. > > > Functions that are named *_exit or *_exitfn in hw/, all return 0. > Changed return type of t

Re: [Qemu-devel] [PATCH] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void.

2016-03-27 Thread Nutan Shinde
ayd...@linaro.org> wrote: > On 24 March 2016 at 17:18, Nutan Shinde <nutanshinde1...@gmail.com> wrote: > > Hi; thanks for this patch; I have some comments below. > > > Functions that are named *_exit or *_exitfn in hw/, all return 0. > Changed return type of these m

Re: [Qemu-devel] [PATCH] hw/display contains files named *_template.h. These are included many times with different values of the DEPTH macro. However, only the DEPTH == 32 case is used. Removed suppo

2016-03-27 Thread Nutan Shinde
Hi, So, this patch won't be considered, because there is already a patch related to the same issue, right? On Wed, Mar 23, 2016 at 7:40 PM, John Snow <js...@redhat.com> wrote: > > > On 03/23/2016 01:30 AM, Nutan Shinde wrote: > > Hi John, > > > > My pat

[Qemu-devel] [PATCH] Change return type of functions that are named *_exit or *_exitfn in hw/ from int to void.

2016-03-24 Thread Nutan Shinde
Functions that are named *_exit or *_exitfn in hw/, all return 0. Changed return type of these methods from int to void. Also, removed check where values were returned from these methods. Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/audio/hda-codec.c | 3 +

Re: [Qemu-devel] [PATCH] hw/display contains files named *_template.h. These are included many times with different values of the DEPTH macro. However, only the DEPTH == 32 case is used. Removed suppo

2016-03-22 Thread Nutan Shinde
Hi John, My patch is same as the patch mentioned in the link. I just picked up the task from BitSizedTask page, as it was not crossed. I guess the issue is resolved then, what should I do in this case? Also, please tell me, how do I know which tasks are already taken up? Regards, Nutan Shinde.

[Qemu-devel] [PATCH] hw/display contains files named *_template.h. These are included many times with different values of the DEPTH macro. However, only the DEPTH == 32 case is used. Removed support f

2016-03-22 Thread Nutan Shinde
Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/display/blizzard.c | 8 hw/display/blizzard_template.h | 26 +- hw/display/omap_lcd_template.h | 8 +--- hw/display/omap_lcdc.c | 6 -- hw/display/sm501.c

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Nutan Shinde
> > Hi, > The change was to remove macros defined as IT_WRITE_PROTO and > IT_READ_PROTO. These macros were used for function definitions. So, I have > replaced these macros with actual function definitions. >

[Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Nutan Shinde
Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/audio/adlib.c | 9 ++--- hw/audio/es1370.c | 17 ++--- hw/audio/gus.c| 9 ++--- hw/audio/sb16.c | 15 +-- 4 files changed, 15 insertions(+), 35 deletions(-) diff --git a/hw/audio/adlib.

[Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-06 Thread Nutan Shinde
Signed-off-by: Nutan Shinde <nutanshinde1...@gmail.com> --- hw/audio/adlib.c | 28 +++ hw/audio/es1370.c | 60 +- hw/audio/gus.c| 26 +++--- hw/audio/sb16.c