On Fri, Apr 23, 2021 at 03:06:49PM +0200, Laszlo Ersek wrote:
> On 04/23/21 15:01, Pavel Hrdina wrote:
> > On Fri, Apr 23, 2021 at 02:34:02PM +0200, Laszlo Ersek wrote:
> >> On 04/23/21 12:31, Pavel Hrdina wrote:
> >>> On Fri, Apr 23, 2021 at 10:16:24AM +0200, Micha
On Fri, Apr 23, 2021 at 02:34:02PM +0200, Laszlo Ersek wrote:
> On 04/23/21 12:31, Pavel Hrdina wrote:
> > On Fri, Apr 23, 2021 at 10:16:24AM +0200, Michal Privoznik wrote:
> >> On 4/22/21 4:13 PM, Laszlo Ersek wrote:
> >>> On 04/21/21 13:51, Pavel Hrdina wrote:
>
On Fri, Apr 23, 2021 at 10:16:24AM +0200, Michal Privoznik wrote:
> On 4/22/21 4:13 PM, Laszlo Ersek wrote:
> > On 04/21/21 13:51, Pavel Hrdina wrote:
> > > On Wed, Apr 21, 2021 at 11:54:24AM +0200, Laszlo Ersek wrote:
> > > > Hi Brijesh, Tom,
> > > >
>
On Wed, Apr 21, 2021 at 11:54:24AM +0200, Laszlo Ersek wrote:
> Hi Brijesh, Tom,
>
> in QEMU's "docs/interop/firmware.json", the @FirmwareFeature enumeration
> has a constant called @amd-sev. We should introduce an @amd-sev-es
> constant as well, minimally for the following reason:
>
> AMD docume
On Thu, Apr 18, 2019 at 11:05:20AM -0300, Eduardo Habkost wrote:
> On Thu, Apr 18, 2019 at 11:59:35AM +0200, Pavel Hrdina wrote:
> > On Thu, Apr 18, 2019 at 09:48:25AM +0100, Daniel P. Berrangé wrote:
> > > On Wed, Apr 17, 2019 at 09:26:10PM +0200, Pavel Hrdina wrote:
> >
On Thu, Apr 18, 2019 at 09:48:25AM +0100, Daniel P. Berrangé wrote:
> On Wed, Apr 17, 2019 at 09:26:10PM +0200, Pavel Hrdina wrote:
> > On Wed, Apr 17, 2019 at 10:53:04PM +0800, Pu Wen wrote:
> > > On 2019/4/16 22:17, Pavel Hrdina wrote:
> > > > On Tue, Apr 16, 20
On Wed, Apr 17, 2019 at 10:53:04PM +0800, Pu Wen wrote:
> On 2019/4/16 22:17, Pavel Hrdina wrote:
> > On Tue, Apr 16, 2019 at 08:06:13PM +0800, Pu Wen wrote:
> > > Add a new base CPU model called 'Dhyana' to model processors from Hygon
> > > Dhyana(family 18h
On Tue, Apr 16, 2019 at 08:06:13PM +0800, Pu Wen wrote:
> Add a new base CPU model called 'Dhyana' to model processors from Hygon
> Dhyana(family 18h), which derived from AMD EPYC(family 17h).
>
> The following features bits have been removed compare to AMD EPYC:
> aes, pclmulqdq, sha_ni
>
> The
On Fri, Mar 29, 2019 at 11:12:55AM +0100, Markus Armbruster wrote:
> Pavel Hrdina writes:
>
> > On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote:
> >> Eric Blake writes:
> >>
> >> > On 3/28/19 3:06 PM, Eric Blake wrote:
> >
On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 3/28/19 3:06 PM, Eric Blake wrote:
> >> On 3/28/19 2:32 PM, Markus Armbruster wrote:
> >>> Markus Armbruster writes:
> >>>> Pavel Hrdina writes:
>
On Tue, Mar 12, 2019 at 08:12:40AM +0100, Gerd Hoffmann wrote:
> From: Kővágó, Zoltán
>
> Audio drivers now get an Audiodev * as config paramters, instead of the
> global audio_option structs. There is some code in audio/audio_legacy.c
> that converts the old environment variables to audiodev op
On Fri, Feb 22, 2019 at 01:40:42PM +, Daniel P. Berrangé wrote:
> On Wed, Feb 20, 2019 at 10:37:32PM +0100, Kővágó, Zoltán wrote:
> > This patch adds documentation of an -audiodev command line option, that
> > deprecates the old QEMU_* environment variables for audio backend
> > configuration.
On Wed, Jul 18, 2018 at 10:50:34AM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 18, 2018 at 12:41:48PM +0300, Hetz Ben Hamo wrote:
> > Hi,
> >
> > I've been looking at the CPU list and although I see lots of CPU's, I
> > cannot find 2 CPU families:
> >
> > * AMD Ryzen
> > * AMD Threadripper
> >
On Tue, Jun 05, 2018 at 03:07:04PM +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 05, 2018 at 11:03:46AM -0300, Eduardo Habkost wrote:
> > On Tue, Jun 05, 2018 at 03:44:39PM +0200, Pavel Hrdina wrote:
> > > On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote:
>
On Tue, Jun 05, 2018 at 11:03:46AM -0300, Eduardo Habkost wrote:
> On Tue, Jun 05, 2018 at 03:44:39PM +0200, Pavel Hrdina wrote:
> > On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote:
> > > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote:
>
On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote:
> On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote:
> > > (CCing libvir-list)
> > >
> > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berr
IOthreads were recently extended by new properties that can
enable/disable and configure aio polling. This will also allow
other tools that uses QEMU to probe for existence of those new
properties via query-qmp-schema.
Signed-off-by: Pavel Hrdina
---
The other possible way would be to
On Fri, Jul 22, 2016 at 04:11:58PM +0100, Daniel P. Berrange wrote:
> On Fri, Jul 22, 2016 at 04:55:16PM +0200, Pavel Hrdina wrote:
> > Hi,
> >
> > So there was made a decision that default ROM bars for network devices
> > shouldn't
> > be packaged for ARM
Hi,
So there was made a decision that default ROM bars for network devices shouldn't
be packaged for ARM architecture. Based on this thorough explanation [1] it
makes sense that it's useless. However it leads to a small issue with starting
a guest on ARM hosts with PCI network device, if there a
On 24.7.2014 16:09, Paolo Bonzini wrote:
> After commit f702e62 (serial: change retry logic to avoid concurrency,
> 2014-07-11), guest boot hangs if the backend is an unconnected PTY.
>
> The reason is that PTYs do not support G_IO_HUP, and serial_xmit is
> never called. To fix this, simply invok
On 14.7.2014 17:49, Paolo Bonzini wrote:
> From: Kirill Batuzov
>
> Whenever serial_xmit fails to transmit a byte it adds a watch that would
> call it again when the "line" becomes ready. This results in a retry
> chain:
> serial_xmit -> add_watch -> serial_xmit
> Each chain is able to transmit
On 22.11.2013 02:43, Wenchao Xia wrote:
于 2013/11/21 19:02, Zhanghailiang 写道:
Hi,
Now qemu ram live snapshot feature has some problems, it is based on
‘ram live migration’.
The time of snapshot depends on completion time of migration, which is
not measurable. Also It may can’t achieve migrate
This fixes the issue that block device is openned successfully with an error
as warning if password is provided but not required. Now the open fails with
the error message.
Signed-off-by: Pavel Hrdina
---
blockdev.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a
omment that the error QERR_DEVICE_NOT_ENCRYPTED is used as warning
* changes from v3:
- added more info into second commit
- added new patch to fix the issue with providing password for device not
requiring password
Luiz Capitulino (1):
block: make bdrv_dev_change_media_cb() public
From: Luiz Capitulino
Next commit wants to use it.
Signed-off-by: Luiz Capitulino
Signed-off-by: Pavel Hrdina
---
block.c | 3 +--
include/block/block.h | 1 +
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index b88ad2f..89574de 100644
--- a
eject and change
commands because these are the only commands to emit this event. We should
call that function only if that command is successful.
What this function does is that it calls the change_media_cb() and also emit
the QEVENT_DEVICE_TRAY_MOVED event.
Signed-off-by: Pavel Hrdina
---
bl
On 19.6.2013 12:16, Stefan Hajnoczi wrote:
On Mon, Jun 17, 2013 at 03:21:41PM +0200, Pavel Hrdina wrote:
The bdrv_dev_change_media_cb() should be called only for eject and change
commands. We should call that function only if that command is successful.
What this function does is that it calls
On 17.6.2013 17:16, Kevin Wolf wrote:
Am 17.06.2013 um 16:59 hat Luiz Capitulino geschrieben:
On Mon, 17 Jun 2013 16:49:11 +0200
Kevin Wolf wrote:
Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben:
On Mon, 17 Jun 2013 15:46:52 +0200
Kevin Wolf wrote:
Am 17.06.2013 um 15:38 hat Pavel
On 17.6.2013 15:32, Luiz Capitulino wrote:
On Mon, 17 Jun 2013 15:25:24 +0200
Pavel Hrdina wrote:
On 17.6.2013 15:22, Luiz Capitulino wrote:
On Mon, 17 Jun 2013 14:33:10 +0200
Stefan Hajnoczi wrote:
On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote:
On 5.6.2013 15:23, Stefan
On 17.6.2013 15:22, Luiz Capitulino wrote:
On Mon, 17 Jun 2013 14:33:10 +0200
Stefan Hajnoczi wrote:
On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote:
On 5.6.2013 15:23, Stefan Hajnoczi wrote:
On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote:
@@ -1071,14 +1072,18
From: Luiz Capitulino
Next commit wants to use it.
Signed-off-by: Luiz Capitulino
Signed-off-by: Pavel Hrdina
---
block.c | 3 +--
include/block/block.h | 1 +
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 79ad33d..9fbaf1a 100644
--- a
user provides some, the error is used as
warning.
Signed-off-by: Pavel Hrdina
---
block.c| 8
blockdev.c | 7 +++
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/block.c b/block.c
index 9fbaf1a..0411c85 100644
--- a/block.c
+++ b/block.c
@@ -1092,10 +1092,6 @@ int
d the first patch from Luiz's series
* changes from v2:
- added comment that the error QERR_DEVICE_NOT_ENCRYPTED is used as warning
Luiz Capitulino (1):
block: make bdrv_dev_change_media_cb() public
Pavel Hrdina (1):
block: move the bdrv_dev_change_media_cb()
block.c
On 5.6.2013 15:23, Stefan Hajnoczi wrote:
On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote:
@@ -1071,14 +1072,18 @@ static void qmp_bdrv_open_encrypted(BlockDriverState
*bs, const char *filename,
if (password) {
if (bdrv_set_key(bs, password) <
The bdrv_dev_change_media_cb() should be called only for eject and
change commands. We should call that function only if that command
is successful.
What this function does is that it calls the change_media_cb() and
also emit the QEVENT_DEVICE_TRAY_MOVED event.
Signed-off-by: Pavel Hrdina
From: Luiz Capitulino
Next commit wants to use it.
Signed-off-by: Luiz Capitulino
Signed-off-by: Pavel Hrdina
---
block.c | 3 +--
include/block/block.h | 1 +
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 3f87489..99bc357 100644
--- a
make bdrv_dev_change_media_cb() public
Pavel Hrdina (1):
block: move the bdrv_dev_change_media_cb()
block.c | 11 +--
blockdev.c| 5 +
include/block/block.h | 1 +
3 files changed, 7 insertions(+), 10 deletions(-)
--
1.8.1.4
This patch adds a new SCSI_DISK_F_NO_REMOVABLE_DEVOPS feature. By this
feature we can set that the scsi-block (scsi pass-through) device will still
be removable from the guest side, but from monitor it cannot be removed.
Signed-off-by: Pavel Hrdina
---
changes from v1:
- renamed the
On 29.5.2013 15:30, Paolo Bonzini wrote:
Il 29/05/2013 14:12, Pavel Hrdina ha scritto:
This patch adds a new SCSI_DISK_F_MONITOR_NOT_REMOVABLE feature. By this
feature we can set that the scsi-block (scsi pass-through) device will still
be removable from the guest side, but from monitor it
On 29.5.2013 14:24, Paolo Bonzini wrote:
Il 29/05/2013 14:12, Pavel Hrdina ha scritto:
This patch adds a new SCSI_DISK_F_MONITOR_NOT_REMOVABLE feature. By this
feature we can set that the scsi-block (scsi pass-through) device will still
be removable from the guest side, but from monitor it
This patch adds a new SCSI_DISK_F_MONITOR_NOT_REMOVABLE feature. By this
feature we can set that the scsi-block (scsi pass-through) device will still
be removable from the guest side, but from monitor it cannot be removed.
Signed-off-by: Pavel Hrdina
---
hw/scsi/scsi-disk.c | 10 +++---
1
m the guest. Probably it should be later fixed in the way that
the eject command will not remove the device from guest, but send the eject
request to the real device in case of removable device.
Pavel Hrdina (2):
scsi-generic: check the return value of bdrv_aio_ioctl in
execute_command
scsi
This fixes the bug introduced by this commit ad54ae80c73f.
The bdrv_aio_ioctl() still could return null and we should return an error
in that case.
Signed-off-by: Pavel Hrdina
---
hw/scsi/scsi-generic.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/scsi/scsi-generic.c b/hw/scsi
On 25.4.2013 20:18, Markus Armbruster wrote:
Luiz Capitulino writes:
Commit 9ca111544c64b5abed2e79cf52e19a8f227b347b moved the call to
bdrv_dev_change_media_cb() outside the media check in bdrv_close(),
this added a regression where spurious DEVICE_TRAY_MOVED events
are emitted at shutdown.
T
On 21.5.2013 14:26, Luiz Capitulino wrote:
On Fri, 17 May 2013 16:23:51 +0200
Pavel Hrdina wrote:
On 25.4.2013 16:31, Luiz Capitulino wrote:
On Thu, 25 Apr 2013 16:29:45 +0200
Stefan Hajnoczi wrote:
On Thu, Apr 25, 2013 at 09:51:47AM -0400, Luiz Capitulino wrote:
On Mon, 22 Apr 2013 15
and probably BIOS
independent.
Signed-off-by: Pavel Hrdina
---
hw/scsi/scsi-disk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index c8d2a99..02733dc 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -1984,6 +1984,9 @@ static v
On 25.4.2013 16:31, Luiz Capitulino wrote:
On Thu, 25 Apr 2013 16:29:45 +0200
Stefan Hajnoczi wrote:
On Thu, Apr 25, 2013 at 09:51:47AM -0400, Luiz Capitulino wrote:
On Mon, 22 Apr 2013 15:53:43 +0200
Stefan Hajnoczi wrote:
On Fri, Apr 19, 2013 at 01:47:17PM -0400, Luiz Capitulino wrote:
On 17.5.2013 14:15, Paolo Bonzini wrote:
Il 17/05/2013 14:11, Pavel Hrdina ha scritto:
On 17.5.2013 14:02, Paolo Bonzini wrote:
Il 17/05/2013 13:57, Pavel Hrdina ha scritto:
What happens when you suspend the QEMU machine to RAM? I believe the
tray should remain open or, if closed, should
On 17.5.2013 14:02, Paolo Bonzini wrote:
Il 17/05/2013 13:57, Pavel Hrdina ha scritto:
What happens when you suspend the QEMU machine to RAM? I believe the
tray should remain open or, if closed, should remain locked. Can you
try the same test on bare-metal (hint: boot to emergency mode to
On 16.5.2013 18:11, Paolo Bonzini wrote:
Il 16/05/2013 17:48, Pavel Hrdina ha scritto:
From what I just tested it is the OS-independent HW behavior.
Tested on desktop:
1. Turn off the computer.
2. Turn on the computer and after few second open the CD-ROM tray before
any OS system is loaded
On 16.5.2013 17:42, Eric Blake wrote:
On 05/16/2013 09:34 AM, Pavel Hrdina wrote:
Tray statuses should be also reseted. Some guests may lock the tray
s/reseted/reset/
and after reset before any kernel is loaded the tray should be unlocked.
Also if you reset the real computer the tray is
a7f3d65b65b8c86a5ff0c0abcfefb45e2ec6fe4c.
Signed-off-by: Pavel Hrdina
---
hw/scsi/scsi-disk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index c8d2a99..02733dc 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -1984,6 +1984,9 @@ static void
ff-by: Pavel Hrdina
---
block/snapshot.c | 72
+++---
include/block/snapshot.h |5 ++-
savevm.c | 35 --
3 files changed, 83 insertions(+), 29 deletions(-)
+ *
+ * Returns: true when a snapshot is foun
On 25.4.2013 08:46, Pavel Hrdina wrote:
On 24.4.2013 23:26, Eric Blake wrote:
On 04/24/2013 09:32 AM, Pavel Hrdina wrote:
Finding snapshot by a name which could also be an id isn't best way
how to do it. There will be rewrite of savevm, loadvm and delvm to
improve the behavior of
;t care
>> about any error message. If snapshot exists it returns TRUE otherwise
>> it returns FALSE.
>>
>> There is also new Error parameter which will containt error messeage if
>> something goes wrong.
>>
>> Signed-off-by: Pavel Hrdina
>> ---
>>
On 24.4.2013 23:26, Eric Blake wrote:
On 04/24/2013 09:32 AM, Pavel Hrdina wrote:
Finding snapshot by a name which could also be an id isn't best way
how to do it. There will be rewrite of savevm, loadvm and delvm to
improve the behavior of these commands. The savevm and loadvm will
have
Signed-off-by: Pavel Hrdina
---
block.c | 21 +
block/qcow2-snapshot.c| 19 +--
block/qcow2.h | 4 +++-
block/rbd.c | 10 +++---
block/sheepdog.c | 6 --
include/block/block.h | 4
Now the bdrv_snapshot_list function returns only number of snapshots. In case
that there is any error, the proper error message is set and return value is 0.
The return value is no longer for testing for errors because there should be
only
one error reporting.
Signed-off-by: Pavel Hrdina
Signed-off-by: Pavel Hrdina
---
include/sysemu/sysemu.h | 2 +-
migration.c | 11 ++---
savevm.c| 65 -
3 files changed, 40 insertions(+), 38 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu
snapshot that match the name parameter
as an id of snapshot
* HMP delvm:
- args_type = "id:-i,name:s"
- same rules as loadvm
changes from v1:
- patch for updating bdrv_snapshot_goto and bdrv_snapshot_list is split
into two patches
- fixes typos and grammar
Signed-off-by: Pavel Hrdina
---
block.c | 34 ++
block/qcow2-snapshot.c| 24 +---
block/qcow2.h | 4 +++-
block/rbd.c | 10 +++---
block/sheepdog.c | 18 --
include
Signed-off-by: Pavel Hrdina
---
savevm.c | 35 ---
1 file changed, 12 insertions(+), 23 deletions(-)
diff --git a/savevm.c b/savevm.c
index 2e849b8..45d46c6 100644
--- a/savevm.c
+++ b/savevm.c
@@ -2263,8 +2263,7 @@ out:
}
static bool bdrv_snapshot_find
pshot you want to create. This will ensure that if you want snapshot with
the name '2', it will not rewrite or fail if there is any snapshot with id '2'.
Signed-off-by: Pavel Hrdina
---
hmp-commands.hx | 18 +-
hmp.c | 49 +
QMP command vm-snapshot-load and HMP command loadvm behave similar to
vm-snapshot-delete and delvm. The only different is that they will load
the snapshot instead of deleting it.
Signed-off-by: Pavel Hrdina
---
hmp-commands.hx | 16 +
hmp.c | 33
;
internally
search at first for id but 'rbd' has only name and therefore search only for
name.
Signed-off-by: Pavel Hrdina
---
hmp-commands.hx | 14 +-
hmp.c | 33 +++
hmp.h | 1 +
include/sysemu/sysemu.h
Signed-off-by: Pavel Hrdina
---
block.c | 22 +-
block/qcow2-snapshot.c| 16 ++--
block/qcow2.h | 4 +++-
block/rbd.c | 23 +++
block/sheepdog.c | 22 +++---
include
Signed-off-by: Pavel Hrdina
---
include/sysemu/sysemu.h | 7 ---
migration.c | 6 +++---
savevm.c| 38 +++---
3 files changed, 26 insertions(+), 25 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index
thing goes wrong.
Signed-off-by: Pavel Hrdina
---
savevm.c | 93 ++--
1 file changed, 67 insertions(+), 26 deletions(-)
diff --git a/savevm.c b/savevm.c
index ba97c41..1622c55 100644
--- a/savevm.c
+++ b/savevm.c
@@ -2262,26 +2262
Later in the patch series we will use this function a few times.
This will avoid duplicating the code.
Signed-off-by: Pavel Hrdina
---
qemu-img.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index cd096a1..ab83fbe 100644
--- a
On 24.4.2013 05:51, Wenchao Xia wrote:
I think that my whole series is almost done and it would be quickly
accepted and applied upstream. I'll send today the v2 and we will see.
Pavel
OK, I'll review v2 too to make it faster.
Hi, Pavel
Sorry for query your progress, I hope to catch
On 18.4.2013 14:55, Kevin Wolf wrote:
Am 16.04.2013 um 18:05 hat Pavel Hrdina geschrieben:
/*
@@ -567,14 +573,18 @@ int qcow2_snapshot_delete(BlockDriverState *bs, const
char *snapshot_id)
ret = qcow2_update_snapshot_refcount(bs, sn.l1_table_offset
On 18.4.2013 14:59, Kevin Wolf wrote:
Am 18.04.2013 um 13:52 hat Pavel Hrdina geschrieben:
On 18.4.2013 13:44, Kevin Wolf wrote:
Am 16.04.2013 um 18:05 hat Pavel Hrdina geschrieben:
Later in the patch series we will use this function few times.
This will avoid of duplicating the code.
Signed
On 18.4.2013 13:44, Kevin Wolf wrote:
Am 16.04.2013 um 18:05 hat Pavel Hrdina geschrieben:
Later in the patch series we will use this function few times.
This will avoid of duplicating the code.
Signed-off-by: Pavel Hrdina
---
qemu-img.c | 17 +++--
1 file changed, 11
On 18.4.2013 11:23, Kevin Wolf wrote:
Trying to take an internal snapshot when an unmigratable device is in
use resuled in an 'Error -22 while writing VM' message. This patch
changes it to print the same error message as migration would print:
'State blocked by non-migratable device xyz'
Signed-
On 17.4.2013 01:43, Eric Blake wrote:
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
QMP command vm-snapshot-load and HMP command loadvm behave similar to
vm-snapshot-delete and delvm. The only different is that they will load
the snapshot instead of deleting it.
Signed-off-by: Pavel Hrdina
On 18.4.2013 06:31, Wenchao Xia wrote:
于 2013-4-18 2:14, Eric Blake 写道:
On 04/17/2013 04:51 AM, Pavel Hrdina wrote:
On 17.4.2013 12:19, Wenchao Xia wrote:
于 2013-4-17 15:52, Pavel Hrdina 写道:
Hi Wenchao,
unfortunately no. According to new design of savevm, loadvm and
delvm I
need also search
On 17.4.2013 12:19, Wenchao Xia wrote:
> 于 2013-4-17 15:52, Pavel Hrdina 写道:
>> Hi Wenchao,
>>
>> unfortunately no. According to new design of savevm, loadvm and delvm I
>> need also search for snapshots that have the specified name and id.
>>
>It seems the
y your requirement, if yes maybe
> you can directly use them.
>
>> Signed-off-by: Pavel Hrdina
>> ---
>>savevm.c | 33 +++--
>>1 file changed, 11 insertions(+), 22 deletions(-)
>>
>> diff --git a/savevm.c b/savevm.c
>
f the
snapshot you want to create. This will ensure that if you want snapshot with
the name '2', it will not rewrite or fail if there is any snapshot with id '2'.
Signed-off-by: Pavel Hrdina
---
hmp-commands.hx | 18 +--
hmp.c | 49 +++
Signed-off-by: Pavel Hrdina
---
block.c | 23 ++-
block/qcow2-snapshot.c| 18 --
block/qcow2.h | 4 +++-
block/rbd.c | 20 +++-
block/sheepdog.c | 22 +++---
include
Signed-off-by: Pavel Hrdina
---
include/sysemu/sysemu.h | 2 +-
migration.c | 9 +++
savevm.c| 64 -
3 files changed, 37 insertions(+), 38 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu
Signed-off-by: Pavel Hrdina
---
block.c | 55 ++-
block/qcow2-snapshot.c| 32 +++
block/qcow2.h | 8 +--
block/rbd.c | 19 +++-
block/sheepdog.c | 33
Signed-off-by: Pavel Hrdina
---
include/sysemu/sysemu.h | 7 ---
migration.c | 6 +++---
savevm.c| 38 +++---
3 files changed, 26 insertions(+), 25 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
Signed-off-by: Pavel Hrdina
---
savevm.c | 33 +++--
1 file changed, 11 insertions(+), 22 deletions(-)
diff --git a/savevm.c b/savevm.c
index 66753da..bc829a5 100644
--- a/savevm.c
+++ b/savevm.c
@@ -2195,7 +2195,7 @@ out:
}
static int bdrv_snapshot_find
QMP command vm-snapshot-load and HMP command loadvm behave similar to
vm-snapshot-delete and delvm. The only different is that they will load
the snapshot instead of deleting it.
Signed-off-by: Pavel Hrdina
---
hmp-commands.hx | 16 +-
hmp.c | 35
Later in the patch series we will use this function few times.
This will avoid of duplicating the code.
Signed-off-by: Pavel Hrdina
---
qemu-img.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 31627b0..dbacdb7 100644
--- a
inted.
These improves behavior of the command to be more strict on selecting snapshots
because actual behavior is wrong. Now if you want to delete snapshot with name
'2'
but there is no snapshot with that name it could delete snapshot with id '2' and
that isn't what you want
Signed-off-by: Pavel Hrdina
---
block.c | 22 ++
block/qcow2-snapshot.c| 21 +++--
block/qcow2.h | 4 +++-
block/rbd.c | 11 ---
block/sheepdog.c | 6 --
include/block/block.h | 4
nd it will be
dropped after all commands will be rewritten.
We only need to know if that snapshot exists or not. We don't care
about any error message. If snapshot exists it returns 1 otherwise
it returns 0.
Signed-off-by: Pavel Hrdina
---
sav
pe = "id:-i,name:s",
- follow the same behavior as the QMP command
- it load snapshot that match the provided name
- if an id flag is provided, it load snapshot that match the name parameter
as an id of snapshot
* HMP delvm:
- args_type = "id:-i,name:s"
On 10.4.2013 19:15, Eric Blake wrote:
On 04/10/2013 08:05 AM, Pavel Hrdina wrote:
Here is another proposal how to handle vm snapshots:
QMP vm-snapshot-save:
- { 'command': 'vm-snapshot-save',
'data': { 'name': 'str' },
&
Here is another proposal how to handle vm snapshots:
QMP vm-snapshot-save:
- { 'command': 'vm-snapshot-save',
'data': { 'name': 'str' },
'returns': 'SnapshotInfo' }
- vm-snapshot-save returns an error if there is an existing
snapshot with the same name
- you cann
On 10.4.2013 15:32, Luiz Capitulino wrote:
On Wed, 10 Apr 2013 15:22:49 +0200
Pavel Hrdina wrote:
On 10.4.2013 14:49, Eric Blake wrote:
On 04/10/2013 06:40 AM, Luiz Capitulino wrote:
On Wed, 10 Apr 2013 06:24:11 -0600
Eric Blake wrote:
- If you want to overwrite an existing snapshot
On 10.4.2013 14:49, Eric Blake wrote:
On 04/10/2013 06:40 AM, Luiz Capitulino wrote:
On Wed, 10 Apr 2013 06:24:11 -0600
Eric Blake wrote:
- If you want to overwrite an existing snapshot, you could specify
the 'id' or the 'name' argument or both of them and also you will
have to u
On 10.4.2013 10:18, Markus Armbruster wrote:
Pavel Hrdina writes:
This patch series convert the savevm command into qapi and introduce QMP
command vm-snapshot-save.
It also rewrite error report for functions used by this command.
The last patch introduce new functionality of savevm that you
On 9.4.2013 15:27, Markus Armbruster wrote:
Pavel Hrdina writes:
Signed-off-by: Pavel Hrdina
Reviewed-by: Eric Blake
---
savevm.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/savevm.c b/savevm.c
index 77c5291..dc1f4a4 100644
--- a/savevm.c
+++ b
On 9.4.2013 15:37, Markus Armbruster wrote:
Markus Armbruster writes:
Pavel Hrdina writes:
Signed-off-by: Pavel Hrdina
Reviewed-by: Eric Blake
---
include/sysemu/sysemu.h | 3 ++-
migration.c | 2 +-
savevm.c| 5 +++--
3 files changed, 6 insertions(+), 4
On 29.3.2013 17:12, Eric Blake wrote:
On 03/29/2013 08:12 AM, Pavel Hrdina wrote:
QMP command "vm-snapshot-save" has also extra optional force parameter
to specify whether replace existing snapshot or not. It also returns
information about created snapshot.
Signed-off-by: Pa
If we provide error message we don't have to also provide return
value because we could check if there is any error message or not.
Signed-off-by: Pavel Hrdina
Reviewed-by: Eric Blake
---
block.c | 24 ++--
block/qcow2-snapshot.c
Signed-off-by: Pavel Hrdina
Reviewed-by: Eric Blake
---
qemu-img.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 21d02bf..d5f81cc 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -322,6 +322,17 @@ static int
1 - 100 of 316 matches
Mail list logo
