Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

2016-01-05 Thread Peter Hornyack
n Kagan > CC: Denis V. Lunev > CC: qemu-devel@nongnu.org Reviewed-by: Peter Hornyack > > --- > arch/x86/kvm/hyperv.c| 117 > +-- > arch/x86/kvm/hyperv.h| 2 + > arch/x86/kvm/x86.c | 12 + > include/lin

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

2015-12-18 Thread Peter Hornyack
On Fri, Dec 18, 2015 at 8:01 AM, Paolo Bonzini wrote: > > > On 18/12/2015 16:19, Pavel Fedin wrote: >> As far as i understand this code, KVM_EXIT_HYPERV is called when one >> of three MSRs are accessed. But, shouldn't we have implemented >> instead something more generic, like KVM_EXIT_REG_IO, whi

Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-07-01 Thread Peter Hornyack
t; +#define HV_X64_MSR_CRASH_CTL_NOTIFY(1ULL << 63) >>> +#define HV_X64_MSR_CRASH_CTL_CONTENTS \ >>> + (HV_X64_MSR_CRASH_CTL_NOTIFY) >> >> Why is HV_X64_MSR_CRASH_CTL_CONTENTS needed? Can I just remove it? >> >> Pa

Re: [Qemu-devel] [PATCH 8/9] kvm/x86: add sending hyper-v crash notification to user space

2015-06-30 Thread Peter Hornyack
RASH > and flag KVM_SYSTEM_EVENT_FL_HV_CRASH to clarify that > crash occures inside Hyper-V based guest. > > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Gleb Natapov Reviewed-by: Peter Hornyack > --- > arch/x86/kvm/x86.c | 8 ++

Re: [Qemu-devel] [PATCH 6/9] kvm/x86: mark hyper-v crash msrs as partition wide

2015-06-30 Thread Peter Hornyack
On Tue, Jun 30, 2015 at 4:33 AM, Denis V. Lunev wrote: > From: Andrey Smetanin > > Hyper-V crash msr's are per vm, aren't per vcpu, so mark them > as partition wide. > > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini >

Re: [Qemu-devel] [PATCH 7/9] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers

2015-06-30 Thread Peter Hornyack
tingiush the moment of actual guest crash > by checking host initiated value from msr info. Also patch > prevents modification of crash ctl msr by guest. > > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Gleb Natapov Rev

Re: [Qemu-devel] [PATCH 5/9] kvm: added KVM_REQ_HV_CRASH value to notify qemu about hyper-v crash

2015-06-30 Thread Peter Hornyack
CC: Gleb Natapov Reviewed-by: Peter Hornyack > --- > include/linux/kvm_host.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 2b2edf1..a377e00 100644 > --- a/include/linux/kvm_host.h > +++ b/include/l

Re: [Qemu-devel] [PATCH 4/9] kvm/x86: added hyper-v crash msrs into kvm hyperv context

2015-06-30 Thread Peter Hornyack
On Tue, Jun 30, 2015 at 4:33 AM, Denis V. Lunev wrote: > From: Andrey Smetanin > > Added kvm Hyper-V context hv crash variables as storage > of Hyper-V crash msrs. > > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Gleb

Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-06-30 Thread Peter Hornyack
On Tue, Jun 30, 2015 at 4:33 AM, Denis V. Lunev wrote: > From: Andrey Smetanin > > Added Hyper-V crash msrs values - HV_X64_MSR_CRASH*. > > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Gleb Natapov Reviewed-by: Peter Horn

Re: [Qemu-devel] [PATCH 2/9] kvm: introduce vcpu_debug = kvm_debug + vcpu context

2015-06-30 Thread Peter Hornyack
zini > CC: Gleb Natapov Reviewed-by: Peter Hornyack > --- > include/linux/kvm_host.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 9564fd7..2b2edf1 100644 > --- a/include/linux/kvm_host.h > +++ b/in

Re: [Qemu-devel] [PATCH 1/9] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file

2015-06-30 Thread Peter Hornyack
V kvm/vcpu fields moved into appropriate hyperv context > structures. Copyrights and authors information copied from x86.c > to hyperv.c. > > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Gleb Natapov Reviewed-by: Peter Hornyac

Re: [Qemu-devel] [PATCH 09/11] kvm/x86: distingiush hyper-v guest crash notification

2015-06-22 Thread Peter Hornyack
On Mon, Jun 22, 2015 at 9:05 AM, Denis V. Lunev wrote: > From: Andrey Smetanin > > Previous patches allowes userspace to setup Hyper-V crash ctl msr. > This msr should expose HV_X64_MSR_CRASH_CTL_NOTIFY value to Hyper-V > guest to allow to send crash data. Unfortunately Hyper-V guest notifies > h

Re: [Qemu-devel] [PATCH 07/11] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers

2015-06-22 Thread Peter Hornyack
On Mon, Jun 22, 2015 at 9:05 AM, Denis V. Lunev wrote: > From: Andrey Smetanin > > Added hyper-v crash msr's(HV_X64_MSR_CRASH*) data and control > geters and setters. > > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Gleb Natapov > --- > arch/x86/kv

Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling

2015-06-13 Thread Peter Hornyack
Hi Denis, Andrey, I have a few comments and questions. (re-sending in plain-text mode, apologies for sending twice.) On Thu, Jun 11, 2015 at 6:18 AM, Denis V. Lunev wrote: > From: Andrey Smetanin > > Windows 2012 guests can notify hypervisor about occurred guest crash > (Windows bugcheck(BSOD))

Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling

2015-06-13 Thread Peter Hornyack
Hi Denis, Andrey, I have a few comments and questions. On Thu, Jun 11, 2015 at 6:18 AM, Denis V. Lunev wrote: > From: Andrey Smetanin > > Windows 2012 guests can notify hypervisor about occurred guest crash > (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does > handling