Re: [PATCH 1/1] ppc/pef.c: initialize cgs->ready in kvmppc_svm_init()

2021-05-28 Thread Ram Pai
dy' failed. > Aborted > > This is happening because we're not setting the cgs->ready flag that is > asserted in qemu_machine_creation_done() during machine start. > > cgs->ready is set in s390_pv_kvm_init() and sev_kvm_init(). Let's set it > in kvmppc_svm_init() as well. > >

Re: Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-15 Thread Ram Pai
On Wed, Jan 13, 2021 at 09:06:29AM +0100, Cornelia Huck wrote: > On Tue, 12 Jan 2021 10:55:11 -0800 > Ram Pai wrote: > > > On Tue, Jan 12, 2021 at 09:19:43AM +0100, Cornelia Huck wrote: > > > On Mon, 11 Jan 2021 11:58:30 -0800 > > > Ram Pai wrote: > > >

RE: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-15 Thread Ram Pai
On Thu, Jan 14, 2021 at 10:36:43AM +, Dr. David Alan Gilbert wrote: > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > > > > > On 13.01.21 13:42, Dr. David Alan Gilbert wrote: > > > * Cornelia Huck (coh...@redhat.com) wrote: > > >> On Tue

RE: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-12 Thread Ram Pai
On Tue, Jan 12, 2021 at 09:19:43AM +0100, Cornelia Huck wrote: > On Mon, 11 Jan 2021 11:58:30 -0800 > Ram Pai wrote: > > > On Mon, Jan 11, 2021 at 05:59:14PM +0100, Cornelia Huck wrote: > > > On Tue, 5 Jan 2021 12:41:25 -0800 > > > Ram Pai wrote: > > >

RE: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-11 Thread Ram Pai
On Mon, Jan 11, 2021 at 05:59:14PM +0100, Cornelia Huck wrote: > On Tue, 5 Jan 2021 12:41:25 -0800 > Ram Pai wrote: > > > On Tue, Jan 05, 2021 at 11:56:14AM +0100, Halil Pasic wrote: > > > On Mon, 4 Jan 2021 10:40:26 -0800 > > > Ram Pai wrote: > > > &

Re: [for-6.0 v5 10/13] spapr: Add PEF based securable guest memory

2021-01-05 Thread Ram Pai
after machine > creation time. > > To start a PEF-capable guest, use the command line options: > -object pef-guest,id=pef0 -machine securable-guest-memory=pef0 > > Signed-off-by: David Gibson > Acked-by: Ram Pai > --- > hw/ppc/meson.build | 1 + > hw/ppc/pef.c

RE: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-05 Thread Ram Pai
On Tue, Jan 05, 2021 at 11:56:14AM +0100, Halil Pasic wrote: > On Mon, 4 Jan 2021 10:40:26 -0800 > Ram Pai wrote: > > > On Mon, Jan 04, 2021 at 01:46:29PM +0100, Halil Pasic wrote: > > > On Sun, 3 Jan 2021 23:15:50 -0800 > > > Ram Pai wrote: > > >

RE: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-04 Thread Ram Pai
On Mon, Jan 04, 2021 at 01:46:29PM +0100, Halil Pasic wrote: > On Sun, 3 Jan 2021 23:15:50 -0800 > Ram Pai wrote: > > > On Fri, Dec 18, 2020 at 12:41:11PM +0100, Cornelia Huck wrote: > > > On Thu, 17 Dec 2020 15:15:30 +0100 > [..] > > > > > > >

Re: Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-03 Thread Ram Pai
On Fri, Dec 18, 2020 at 12:41:11PM +0100, Cornelia Huck wrote: > On Thu, 17 Dec 2020 15:15:30 +0100 > Greg Kurz wrote: > > > On Thu, 17 Dec 2020 12:38:42 +0100 > > Cornelia Huck wrote: > > > > > On Thu, 17 Dec 2020 16:47:36 +1100 > > > David Gibson wrote: > > > > > > > On Mon, Dec 14, 2020

Re: [RFC v2 17/18] spapr: Added PEF based guest memory protection

2020-05-29 Thread Ram Pai
tClass *oc, void *data) > +{ > +GuestMemoryProtectionClass *gmpc = GUEST_MEMORY_PROTECTION_CLASS(oc); > + > +gmpc->kvm_init = pef_kvm_init; > +} > + > +static const TypeInfo pef_guest_info = { > +.parent = TYPE_OBJECT, > + .name = TYPE_PEF_GUEST, > +.instance_size = sizeof(PefGuestSt

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-29 Thread Ram Pai
On Tue, Aug 29, 2017 at 11:40:30AM +1000, David Gibson wrote: > On Mon, Aug 28, 2017 at 10:53:56AM -0700, Ram Pai wrote: > > On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote: > > > > > > We could either have two u16 fields for the number of keys for data &

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-28 Thread Ram Pai
On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote: > > We could either have two u16 fields for the number of keys for data > and instruction, or we could have a u32 field for the number of keys > and a separate bit in the flags field to indicate that instruction > keys are supported.

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-28 Thread Ram Pai
On Fri, Aug 25, 2017 at 02:23:13PM +1000, David Gibson wrote: > On Thu, Aug 24, 2017 at 11:11:22AM -0700, Ram Pai wrote: > > On Thu, Aug 24, 2017 at 12:54:48PM +1000, Paul Mackerras wrote: > > > On Mon, Aug 21, 2017 at 05:00:36PM -0300, Thiago Jung Bauermann wrote: &

Re: [Qemu-devel] [PATCH] spapr: Add ibm, processor-storage-keys property to CPU DT node

2017-08-24 Thread Ram Pai
keys, so I think that using those > sysfs files to indicate what the guest can do is wrong. > > In fact KVM allows guests to specify storage keys in the HPTE values > that they set, except that there is a bug (for which Ram Pai has > posted a patch) that means that KVM loses the top tw

Re: [Qemu-devel] [PATCH v5 2/4] block: add the block queue support

2011-08-09 Thread Ram Pai
On Tue, Aug 09, 2011 at 12:17:50PM +0800, Zhi Yong Wu wrote: The patch introduce one block queue for QEMU block layer. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- block/blk-queue.c | 141 + block/blk-queue.h | 73

Re: [Qemu-devel] [PATCH v5 3/4] block: add block timer and block throttling algorithm

2011-08-09 Thread Ram Pai
On Tue, Aug 09, 2011 at 12:17:51PM +0800, Zhi Yong Wu wrote: Note: 1.) When bps/iops limits are specified to a small value such as 511 bytes/s, this VM will hang up. We are considering how to handle this senario. 2.) When dd command is issued in guest, if its option bs is set to a