Re: [PATCH v2 00/10] Cadence GEM Fixes

2020-05-04 Thread Ramon Fried
On Mon, May 4, 2020 at 5:14 PM Sai Pavan Boddu wrote: > > Hi, > > Following patch series fixes issues with priority queues, > Adds JUMBO Frame support, > Makes Debug statements compilable & > Fixes related to multicast frames. > > Changes for V2: > Fixed build failure on fedora docker mach

[PATCH resend v2] net: cadence_gem: clear RX control descriptor

2020-04-18 Thread Ramon Fried
Signed-off-by: Ramon Fried Reviewed-by: Philippe Mathieu-Daudé --- v2: * change function name to rx_desc_clear_control as proposed by Jason Wang * Move the function call above the comment, as proposed by Philippe Mathieu-Daudé hw/net/cadence_gem.c | 7 +++ 1 file changed, 7

[PATCH v2] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-17 Thread Ramon Fried
Wraparound of TX descriptor cyclic buffer only updated the low 32 bits of the descriptor. Fix that by checking if we're working with 64bit descriptors. Signed-off-by: Ramon Fried Reviewed-by: Edgar E. Iglesias --- v2: Fix indention problem. hw/net/cadence_gem.c | 9 - 1 file ch

Re: [PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-17 Thread Ramon Fried
On Fri, Apr 17, 2020 at 4:37 PM Peter Maydell wrote: > > On Thu, 16 Apr 2020 at 10:02, Ramon Fried wrote: > > > > Wraparound of TX descriptor cyclic buffer only updated > > the low 32 bits of the descriptor. > > Fix that by checking if we're working with 64bit

[PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-16 Thread Ramon Fried
Wraparound of TX descriptor cyclic buffer only updated the low 32 bits of the descriptor. Fix that by checking if we're working with 64bit descriptors. Signed-off-by: Ramon Fried --- hw/net/cadence_gem.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/h

Re: [Qemu-devel] [PATCH v3] net: cadence_gem: fix compilation error when debug is on

2020-04-13 Thread Ramon Fried
False alarm, exact same patch was merged by someone else. On Mon, Apr 13, 2020 at 8:55 PM Ramon Fried wrote: > > Hi. > Just noticed that this patch didn't hit master. > Got lost ? > > Thanks, > Ramon. > > On Sat, Jun 15, 2019 at 9:16 AM Ramon Fried wrote: >

Re: [PATCH v2] net: cadence_gem: clear RX control descriptor

2020-04-13 Thread Ramon Fried
Hi. Just noticed that this patch didn't hit master. Got lost ? Thanks, Ramon. On Tue, Jul 16, 2019 at 2:58 PM Jason Wang wrote: > > > On 2019/7/16 下午6:59, Ramon Fried wrote: > > The RX ring descriptors control field is used for setting > > SOF and EOF (start of frame

Re: [Qemu-devel] [PATCH v3] net: cadence_gem: fix compilation error when debug is on

2020-04-13 Thread Ramon Fried
Hi. Just noticed that this patch didn't hit master. Got lost ? Thanks, Ramon. On Sat, Jun 15, 2019 at 9:16 AM Ramon Fried wrote: > > > > On June 15, 2019 8:38:35 AM GMT+03:00, "Philippe Mathieu-Daudé" > wrote: > >Hi Ramon, > > > >On 6

Re: [Qemu-devel] [PATCH] net: cadence_gem: clear RX control descriptor

2019-07-16 Thread Ramon Fried
On Tue, Jul 16, 2019 at 11:42 AM Jason Wang wrote: > > > On 2019/6/15 下午1:17, Ramon Fried wrote: > > The RX ring descriptors control field is used for setting > > SOF and EOF (start of frame and end of frame). > > The SOF and EOF weren't cleared from the p

Re: [Qemu-devel] [PATCH] net: cadence_gem: clear RX control descriptor

2019-07-16 Thread Ramon Fried
On Tue, Jul 16, 2019 at 10:19 AM Philippe Mathieu-Daudé wrote: > > On 7/16/19 9:11 AM, Ramon Fried wrote: > > ping > > > > On Sat, Jun 15, 2019 at 8:17 AM Ramon Fried wrote: > >> > >> The RX ring descriptors control field is used for setting > &g

[Qemu-devel] [PATCH v2] net: cadence_gem: clear RX control descriptor

2019-07-16 Thread Ramon Fried
Signed-off-by: Ramon Fried Reviewed-by: Philippe Mathieu-Daudé --- v2: * change function name to rx_desc_clear_control as proposed by Jason Wang * Move the function call above the comment, as proposed by Philippe Mathieu-Daudé hw/net/cadence_gem.c | 7 +++ 1 file changed, 7

Re: [Qemu-devel] [PATCH] net: cadence_gem: clear RX control descriptor

2019-07-16 Thread Ramon Fried
ping On Sat, Jun 15, 2019 at 8:17 AM Ramon Fried wrote: > > The RX ring descriptors control field is used for setting > SOF and EOF (start of frame and end of frame). > The SOF and EOF weren't cleared from the previous descriptors, > causing inconsistencies in ring buffer. &g

Re: [Qemu-devel] [PATCH v3] net: cadence_gem: fix compilation error when debug is on

2019-06-14 Thread Ramon Fried
On June 15, 2019 8:38:35 AM GMT+03:00, "Philippe Mathieu-Daudé" wrote: >Hi Ramon, > >On 6/15/19 7:15 AM, Ramon Fried wrote: >> defining CADENCE_GEM_ERR_DEBUG causes compilation >> errors, fix that. >> >> Signed-off-by: Ramon Fried >> ---

Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-14 Thread Ramon Fried
On Wed, Jun 12, 2019 at 10:40 AM Laurent Vivier wrote: > Le 12/06/2019 à 06:27, Ramon Fried a écrit : > > > > > > On Tue, Jun 11, 2019 at 7:21 PM Laurent Vivier > <mailto:laur...@vivier.eu>> wrote: > > > > Le 11/06/2019 à 16:55, Ramon Fried a écr

[Qemu-devel] [PATCH v3] net: cadence_gem: fix compilation error when debug is on

2019-06-14 Thread Ramon Fried
defining CADENCE_GEM_ERR_DEBUG causes compilation errors, fix that. Signed-off-by: Ramon Fried --- v2: change %lx to HWADDR_PRIx and %lx to %zdx v3: change %zdx to %zx hw/net/cadence_gem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net

[Qemu-devel] [PATCH] net: cadence_gem: clear RX control descriptor

2019-06-14 Thread Ramon Fried
Signed-off-by: Ramon Fried --- hw/net/cadence_gem.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index ecee22525c..d83a82bdb0 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c @@ -406,6 +406,11 @@ static inline void rx_desc_set_so

Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-11 Thread Ramon Fried
On Tue, Jun 11, 2019 at 7:21 PM Laurent Vivier wrote: > Le 11/06/2019 à 16:55, Ramon Fried a écrit : > > defining CADENCE_GEM_ERR_DEBUG causes compilation > > errors, fix that. > > > > Signed-off-by: Ramon Fried > > --- > > v2: change %lx to HWADDR_PRIx an

[Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-11 Thread Ramon Fried
defining CADENCE_GEM_ERR_DEBUG causes compilation errors, fix that. Signed-off-by: Ramon Fried --- v2: change %lx to HWADDR_PRIx and %lx to %zdx hw/net/cadence_gem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index

Re: [Qemu-devel] [PATCH] net: cadence_gem: fix compilation error when debug is on

2019-06-11 Thread Ramon Fried
On Tue, Jun 11, 2019 at 11:34 AM Philippe Mathieu-Daudé wrote: > Hi Ramon, > > On 6/9/19 12:08 PM, Ramon Fried wrote: > > defining CADENCE_GEM_ERR_DEBUG causes compilation > > errors, fix that. > > > > Signed-off-by: Ramon Fried > > --- > > hw/net

[Qemu-devel] [PATCH] net: cadence_gem: fix compilation error when debug is on

2019-06-09 Thread Ramon Fried
defining CADENCE_GEM_ERR_DEBUG causes compilation errors, fix that. Signed-off-by: Ramon Fried --- hw/net/cadence_gem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 7f63411430..5cc5a71524 100644 --- a/hw/net