Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-27 Thread Robert Wang
I re-sent the patch and use bdrv_co_flush now, thanks. 2011/10/27 shu ming : > Looks good to me.  A nit, it seems that bdrv_flush is not supported anymore > in upstream. > bdrv_co_flush should be used instead if you update your workspace to latest > one. > On 2011-10-26 18:08, Ro

Re: [Qemu-devel] [PATCH 1/7] block: Remove dead code

2011-10-26 Thread Robert Wang
pstrcpy(filename, filename_size, ""); > -    } else { > -        pstrcpy(filename, filename_size, bs->backing_file); > -    } > +    pstrcpy(filename, filename_size, bs->backing_file); >  } > >  int bdrv_write_compressed(BlockDriverState *bs, int64_t sector_num, > -- > 1.7.6.4 > > > -- Regards Robert Wang

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-26 Thread Robert Wang
sh(state->image_hd); >> +    if (ret<  0) { >> +        return ret; >> +    } >> +    return bdrv_flush(bs->file); >> +} >> + >> +static BlockDriverAIOCB *add_cow_aio_flush(BlockDriverState *bs, >> +        BlockDriverCompletionFun

Re: [Qemu-devel] QEMU via GDB

2011-10-21 Thread Robert Wang
What is your configure parameters? I think you could try like this: ./configure --enable-debug --extra-cflags="-g3 -O0" And I did not find options like disable-gfx-check. 2011/10/21 Davide : > Dear all, > I am trying to debug QEMU via GDB. > > > I configured and compiled QEMU with debugging flags

[Qemu-devel] [PATCH] fix spelling error

2011-08-24 Thread Robert Wang
Signed-off-by: Robert Wang --- block/sheepdog.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 57b6e1a..ab04932 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -66,7 +66,7 @@ * 20 - 31 (12 bits): reserved data object

[Qemu-devel] [PATCH] fix code format

2011-08-19 Thread Robert Wang
Fix code format to make checkpatch.pl happy. Signed-off-by: Robert Wang --- block.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 26910ca..87e83bc 100644 --- a/block.c +++ b/block.c @@ -2251,9 +2251,9 @@ BlockDriverAIOCB *bdrv_aio_readv

Re: [Qemu-devel] External COW format for raw images

2011-07-20 Thread Robert Wang
On Tue, 2011-07-19 at 16:39 +0200, Frediano Ziglio wrote: > 2011/7/19 Robert Wang : > > As you known, raw image is very popular,but the raw image format does > > NOT support Copy-On-Write,a raw image file can NOT be used as a copy > > destination, then image streaming/Live Blo

[Qemu-devel] External COW format for raw images

2011-07-19 Thread Robert Wang
As you known, raw image is very popular,but the raw image format does NOT support Copy-On-Write,a raw image file can NOT be used as a copy destination, then image streaming/Live Block Copy will NOT work. To fix this, we need to add a new block driver raw-cow to QEMU. If finished, we can use qemu-i