Re: [PATCH] vfio: Implement a common device info helper

2023-06-01 Thread Robin Voetter
On 6/1/23 16:45, Alex Williamson wrote: > A common helper implementing the realloc algorithm for handling > capabilities. > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Cédric Le Goater > Signed-off-by: Alex Williamson Reviewed-by: Robin Voetter > --- >

Re: [RFC PATCH v2 0/4] vfio/pci: Atomic Ops completer support

2023-06-01 Thread Robin Voetter
On 6/1/23 00:24, Alex Williamson wrote: > On Wed, 31 May 2023 23:55:41 +0200 > Robin Voetter wrote: >> Something that I have been thinking about, are there any implications >> involved with enabling this feature automatically with no possibility of >> turning it off

Re: [RFC PATCH v2 4/4] vfio/pci: Enable AtomicOps completers on root ports

2023-05-31 Thread Robin Voetter
port device capabilities2 register are read-only, the > PCIe spec does allow RO bits to change to reflect hardware state. We > take advantage of that here around the realize and exit functions of > the vfio-pci device. > > Signed-off-by: Alex Williamson Reviewed-by: Robin Voetter Test

Re: [RFC PATCH v2 3/4] pcie: Add a PCIe capability version helper

2023-05-31 Thread Robin Voetter
On 5/27/23 01:15, Alex Williamson wrote: > Report the PCIe capability version for a device > > Signed-off-by: Alex Williamson Reviewed-by: Robin > Voetter Tested-by: Robin Voetter Kind regards, Robin Voetter

Re: [RFC PATCH v2 0/4] vfio/pci: Atomic Ops completer support

2023-05-31 Thread Robin Voetter
out the host. Thanks, Robin Voetter, Stream HPC

Re: [RFC PATCH v2 2/4] vfio: Implement a common device info helper

2023-05-31 Thread Robin Voetter
n extraneous semicolon here behind the function declaration that should be removed. Kind regards, Robin Voetter, Stream HPC

Re: [PATCH 0/1] pcie: Allow atomic completion on PCIE root port

2023-04-21 Thread Robin Voetter
On 4/21/23 10:22, Michael S. Tsirkin wrote: > On Thu, Apr 20, 2023 at 05:38:39PM +0200, ro...@streamhpc.com wrote: >> From: Robin Voetter >> >> The ROCm driver for Linux uses PCIe atomics to schedule work and >> generally communicate between the host and the device.

Re: PCIe atomics in pcie-root-port

2023-04-12 Thread Robin Voetter
On 4/6/23 20:40, Alex Williamson wrote: I think the typical approach for QEMU would be expose options in the downstream ports that would then need to be enabled by the user or management tool, but that's where the complication begins. At some point we would want management tools to "do the righ

PCIe atomics in pcie-root-port

2023-04-06 Thread Robin Voetter
host system automatically either. 2. Is anything else required to support PCIe atomics, or did I just get lucky that my programs work? Thanks, Robin Voetter, Stream HPC