Re: [PATCH v3 01/16] MAINTAINERS: Update Roman Bolshakov email address

2023-06-28 Thread Roman Bolshakov
@ F: target/arm/hvf/ > > X86 HVF CPUs > M: Cameron Esfahani > -M: Roman Bolshakov > +M: Roman Bolshakov > W: https://wiki.qemu.org/Features/HVF > S: Maintained > F: target/i386/hvf/ > > HVF > M: Cameron Esfahani > -M: Roman Bolshakov >

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-29 Thread Roman Bolshakov
On Tue, Jan 25, 2022 at 01:14:27PM +0900, Akihiko Odaki wrote: > On Tue, Jan 25, 2022 at 8:00 AM Roman Bolshakov wrote: > > > > On Mon, Jan 24, 2022 at 08:14:31PM +, Peter Maydell wrote: > > > On Mon, 24 Jan 2022 at 17:49, Roman Bolshakov wrote: > > > > I

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-24 Thread Roman Bolshakov
On Mon, Jan 24, 2022 at 08:14:31PM +, Peter Maydell wrote: > On Mon, 24 Jan 2022 at 17:49, Roman Bolshakov wrote: > > I'm not sure why blocks are Objective-C specific. All the data I have > > shows the opposite [3][4][5]. They're just extensively used in Apple APIs. &g

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-24 Thread Roman Bolshakov
On Mon, Jan 24, 2022 at 12:27:40PM +0100, Christian Schoenebeck wrote: > On Montag, 24. Januar 2022 10:56:00 CET Roman Bolshakov wrote: > > On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > > > net/vmnet-bridged.m | 25 + > > >

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-24 Thread Roman Bolshakov
On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > Create separate netdevs for each vmnet operating mode: > - vmnet-host > - vmnet-shared > - vmnet-bridged > > Signed-off-by: Vladislav Yaroshchuk > --- > net/clients.h | 11 > net/meson.build | 7 +++ >

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-20 Thread Roman Bolshakov
On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > Create separate netdevs for each vmnet operating mode: > - vmnet-host > - vmnet-shared > - vmnet-bridged > Sure I'm late to the party but what if we add only one backend - vmnet with default mode set to shared and all

Re: [PATCH v13 1/7] net/vmnet: add vmnet dependency and customizable option

2022-01-19 Thread Roman Bolshakov
ment belongs here. Perhaps you mean that bridged mode is available from 10.15: VMNET_BRIDGED_MODE API_AVAILABLE(macos(10.15)) = 1002 This means vmnet.framework is supported on all macbooks starting from 2012. With this fixed, Tested-by: Roman Bolshakov Reviewed-by: Roman Bolshakov The oth

Re: [PATCH v11 1/7] net/vmnet: add vmnet dependency and customizable option

2022-01-12 Thread Roman Bolshakov
On Wed, Jan 12, 2022 at 03:21:44PM +0300, Vladislav Yaroshchuk wrote: > vmnet.framework dependency is added with 'vmnet' option > to enable or disable it. Default value is 'auto'. > > vmnet features to be used are available since macOS 11.0, > corresponding probe is created into meson.build. > >

Re: [PATCH v10 0/7] Add vmnet.framework based network backend

2022-01-12 Thread Roman Bolshakov
On Wed, Jan 12, 2022 at 04:23:30PM +0300, Vladislav Yaroshchuk wrote: > ср, 12 янв. 2022 г. в 11:22, Roman Bolshakov : > > > On Wed, Jan 12, 2022 at 10:50:04AM +0300, Roman Bolshakov wrote: > > > On Wed, Jan 12, 2022 at 12:14:15AM +0300, Vladislav Yaroshchuk wro

Re: [PATCH v10 0/7] Add vmnet.framework based network backend

2022-01-12 Thread Roman Bolshakov
On Wed, Jan 12, 2022 at 10:50:04AM +0300, Roman Bolshakov wrote: > On Wed, Jan 12, 2022 at 12:14:15AM +0300, Vladislav Yaroshchuk wrote: > > macOS provides networking API for VMs called 'vmnet.framework': > > https://developer.apple.com/documentation/vmnet > > > >

Re: [PATCH v10 0/7] Add vmnet.framework based network backend

2022-01-11 Thread Roman Bolshakov
On Wed, Jan 12, 2022 at 12:14:15AM +0300, Vladislav Yaroshchuk wrote: > macOS provides networking API for VMs called 'vmnet.framework': > https://developer.apple.com/documentation/vmnet > > We can provide its support as the new QEMU network backends which > represent three different

Re: [PULL 00/13] Net patches

2022-01-11 Thread Roman Bolshakov
On Wed, Jan 12, 2022 at 01:39:28PM +0800, Jason Wang wrote: > > 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道: > > > > > > вт, 11 янв. 2022 г., 5:10 AM Jason Wang : > > > > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell > > wrote: > > > > > > On Mon, 10 Jan 2022 at 03:40, Jason

Re: [RFC PATCH v3 5/7] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-11 Thread Roman Bolshakov
On Mon, Jan 10, 2022 at 02:09:59PM +0100, Philippe Mathieu-Daudé wrote: > When building on macOS 12 we get: > > audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is > deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] >

Re: [RFC PATCH v3 5/7] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-11 Thread Roman Bolshakov
On Mon, Jan 10, 2022 at 02:09:59PM +0100, Philippe Mathieu-Daudé wrote: > When building on macOS 12 we get: > > audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is > deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] >

Re: [RFC PATCH v3 4/7] hvf: Remove deprecated hv_vcpu_flush() calls

2022-01-11 Thread Roman Bolshakov
deprecation doc: > https://developer.apple.com/documentation/hypervisor/1441386-hv_vcpu_flush > Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Thanks, Roman > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/hvf/vmx.h | 2 -- > target/i386/hvf/x86_ta

Re: [RFC PATCH v3 1/7] configure: Allow passing extra Objective C compiler flags

2022-01-11 Thread Roman Bolshakov
On Mon, Jan 10, 2022 at 02:09:55PM +0100, Philippe Mathieu-Daudé wrote: > We can pass C/CPP/LD flags via CFLAGS/CXXFLAGS/LDFLAGS environment > variables, or via configure --extra-cflags / --extra-cxxflags / > --extra-ldflags options. Provide similar behavior for Objective C: > use existing flags

Re: [RFC PATCH v3 3/7] hvf: Make hvf_get_segments() / hvf_put_segments() local

2022-01-11 Thread Roman Bolshakov
On Mon, Jan 10, 2022 at 02:09:57PM +0100, Philippe Mathieu-Daudé wrote: > Both hvf_get_segments/hvf_put_segments() functions are only > used within x86hvf.c: do not declare them as public API. > Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Thanks, Roman > Signed-off-

Re: [RFC PATCH v3 2/7] ui/cocoa: Remove allowedFileTypes restriction in SavePanel

2022-01-10 Thread Roman Bolshakov
sue for raw images with extensions outside of the specified list or for images without any extension. Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Regards, -Roman > [2789/6622] Compiling Objective-C object libcommon.fa.p/ui_cocoa.m.o > ui/cocoa.m:1411:16: error: 'setAll

Re: [RFC PATCH v3 0/7] host: Support macOS 12

2022-01-10 Thread Roman Bolshakov
On Mon, Jan 10, 2022 at 02:09:54PM +0100, Philippe Mathieu-Daudé wrote: > Few patches to be able to build QEMU on macOS 12 (Monterey). > > This basically consists of adapting deprecated APIs. I am not > sure about these APIs, so tagging as RFC. > > I couldn't succeed to adapt the Cocoa code. >

Re: [PATCH 0/7] Add vmnet.framework based network backend

2021-08-12 Thread Roman Bolshakov
On Thu, Jun 17, 2021 at 05:32:39PM +0300, Vladislav Yaroshchuk wrote: > macOS provides networking API for VMs called vmnet.framework. > I tried to add it as a network backend. All three modes are supported: > > -shared: > allows the guest to comminicate with other guests in shared mode and >

[Bug 1914849] Re: mprotect fails after MacOS 11.2 on arm mac

2021-04-14 Thread Roman Bolshakov
** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914849 Title: mprotect fails after MacOS 11.2 on arm mac Status in QEMU: Fix

Re: [PATCH v3 for-6.0 1/2] tcg: Do not set guard pages on the rx portion of code_gen_buffer

2021-03-22 Thread Roman Bolshakov
all platforms except darwin? (that would make it similar to what Philippe proposed in the comments to patch 2). - What does mean that rx might be covered by huge pages? (perhaps I'm missing some context) Otherwise, Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov BR, Roman

Re: [PATCH v3 for-6.0 2/2] tcg: Workaround macOS 11.2 mprotect bug

2021-03-22 Thread Roman Bolshakov
* rejects a permission change from RWX -> NONE. Guard pages are > > + * nice for bug detection but are not essential; ignore any > > failure. > > + */ > > +(void)qemu_mprotect_none(end, page_size); > > } > > > > tcg_region_trees_init(); > > > I agree with Philippe, it's worth to keep the bug detection on non-buggy platforms. Otherwise: Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Thanks, Roman

Re: [PATCH 2/2] cirrus.yml: Update the FreeBSD task to version 12.2

2021-03-17 Thread Roman Bolshakov
On Wed, Mar 17, 2021 at 01:44:05PM +0100, Thomas Huth wrote: > On 17/03/2021 12.16, Peter Maydell wrote: > > On Wed, 17 Mar 2021 at 11:09, Thomas Huth wrote: > > > > > > FreeBSD version 12.1 is out of service now, and the task in the > > > Cirrus-CI is failing. Update to 12.2 to get it working

Re: [PATCH v2 03/29] tcg: Re-order tcg_region_init vs tcg_prologue_init

2021-03-15 Thread Roman Bolshakov
On Sun, Mar 14, 2021 at 03:26:58PM -0600, Richard Henderson wrote: > Instead of delaying tcg_region_init until after tcg_prologue_init > is complete, do tcg_region_init first and let tcg_prologue_init > shrink the first region by the size of the generated prologue. > > Signed-off-by: Richard

Re: [PATCH v2 01/29] meson: Split out tcg/meson.build

2021-03-15 Thread Roman Bolshakov
On Sun, Mar 14, 2021 at 03:26:56PM -0600, Richard Henderson wrote: > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- Reviewed-by: Roman Bolshakov Thanks, Roman > meson.build | 9 ++--- > tcg/meson.build | 13 + > 2

Re: [PATCH v2 02/29] meson: Split out fpu/meson.build

2021-03-15 Thread Roman Bolshakov
On Sun, Mar 14, 2021 at 03:26:57PM -0600, Richard Henderson wrote: > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- Reviewed-by: Roman Bolshakov Thanks, Roman > meson.build | 4 +--- > fpu/meson.build | 1 + > 2 files changed, 2 insertio

Re: [PATCH v2 00/29] tcg: Workaround macOS 11.2 mprotect bug

2021-03-15 Thread Roman Bolshakov
ichard, Thanks for doing the changes! I'm not sure if I'll find enough time for thorough review but the series helps qemu on Big Sur 11.2.3, so: Tested-by: Roman Bolshakov Regards, Roman > r~ > > > Richard Henderson (29): > meson: Split out tcg/meson.build > meson: Sp

Re: [PATCH] util/osdep: Avoid mprotect() RWX->NONE on Big Sur 11.2

2021-03-09 Thread Roman Bolshakov
On Sun, Mar 07, 2021 at 10:47:06PM -0800, Joelle van Dyne wrote: > On Wed, Feb 10, 2021 at 2:55 AM Roman Bolshakov wrote: > > > > There's a change in mprotect() behaviour [1] in the latest macOS on M1 > > and it's not yet clear if it's going to be fixed by Apple. For

Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release

2021-03-08 Thread Roman Bolshakov
> 8 марта 2021 г., в 18:41, Thomas Huth написал(а): > > On 08/03/2021 16.26, Warner Losh wrote: >> On Mon, Mar 8, 2021 at 6:30 AM Thomas Huth > > wrote: >>On 07/03/2021 16.56, Warner Losh wrote: >> > FreeBSD 12.1 has reached end of life. Use 12.2 instead so

Re: [PATCH v4] net/macos: implement vmnet-based netdev

2021-02-23 Thread Roman Bolshakov
On Thu, Feb 18, 2021 at 02:49:47PM +0100, phillip.en...@gmail.com wrote: > From: Phillip Tennen > > This patch implements a new netdev device, reachable via -netdev > vmnet-macos, that’s backed by macOS’s vmnet framework. > > The vmnet framework provides native bridging support, and its usage

Re: [PATCH v16 01/23] cpu: Introduce TCGCpuOperations struct

2021-02-10 Thread Roman Bolshakov
On Wed, Feb 10, 2021 at 07:32:55AM -0500, Eduardo Habkost wrote: > On Wed, Feb 10, 2021 at 03:21:51PM +0300, Roman Bolshakov wrote: > > On Thu, Feb 04, 2021 at 05:39:09PM +0100, Claudio Fontana wrote: > > > From: Eduardo Habkost > > > > > > The TC

Re: [PATCH v16 02/23] target/riscv: remove CONFIG_TCG, as it is always TCG

2021-02-10 Thread Roman Bolshakov
On Thu, Feb 04, 2021 at 05:39:10PM +0100, Claudio Fontana wrote: > for now only TCG is allowed as an accelerator for riscv, > so remove the CONFIG_TCG use. > > Signed-off-by: Claudio Fontana > Reviewed-by: Alistair Francis > Reviewed-by: Alex Bennée > --- > target/riscv/cpu.c | 3 +-- > 1

Re: [PATCH v16 01/23] cpu: Introduce TCGCpuOperations struct

2021-02-10 Thread Roman Bolshakov
On Thu, Feb 04, 2021 at 05:39:09PM +0100, Claudio Fontana wrote: > From: Eduardo Habkost > > The TCG-specific CPU methods will be moved to a separate struct, > to make it easier to move accel-specific code outside generic CPU > code in the future. Start by moving tcg_initialize(). > > The new

[Bug 1913505] Re: Windows XP slow on Apple M1

2021-02-10 Thread Roman Bolshakov
@John please build from master and apply the patch https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03527.html ** Tags added: macos tcg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1913505

[PATCH] util/osdep: Avoid mprotect() RWX->NONE on Big Sur 11.2

2021-02-10 Thread Roman Bolshakov
: https://bugs.launchpad.net/qemu/+bug/1914849 Apple-Feedback: FB8994773 Signed-off-by: Roman Bolshakov --- util/osdep.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/util/osdep.c b/util/osdep.c index 66d01b9160..1edd7b1caf 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -111,6 +111,12

[PULL hvf 5/5] hvf: Fetch cr4 before evaluating CPUID(1)

2021-02-09 Thread Roman Bolshakov
-ag...@csgraf.de> [RB: resolved conflict with another CPUID change] Signed-off-by: Roman Bolshakov --- target/i386/hvf/hvf.c | 4 1 file changed, 4 insertions(+) diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 5a8914564b..d2fb680058 100644 --- a/target/i386/hvf/hvf.c +++ b/targe

[PULL hvf 4/5] target/i386/hvf: add rdmsr 35H MSR_CORE_THREAD_COUNT

2021-02-09 Thread Roman Bolshakov
: <20210113205323.33310-1-yaroshchuk2...@gmail.com> [RB: reordered MSR definition and dropped u suffix from shift offset] Signed-off-by: Roman Bolshakov --- target/i386/cpu.h | 1 + target/i386/hvf/x86_emu.c | 5 + 2 files changed, 6 insertions(+) diff --git a/target/i386/cpu.h b/targe

[PULL hvf 3/5] hvf: x86: Remove unused definitions

2021-02-09 Thread Roman Bolshakov
From: Alexander Graf The hvf i386 has a few struct and cpp definitions that are never used. Remove them. Suggested-by: Roman Bolshakov Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alexander Graf Message-Id: <2021012022.71840-3-ag...@csgraf.de> Signed-off-by: Roman Bol

[PULL hvf 1/5] hvf: Guard xgetbv call

2021-02-09 Thread Roman Bolshakov
From: Hill Ma This prevents illegal instruction on cpus that do not support xgetbv. Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 Reviewed-by: Cameron Esfahani Signed-off-by: Hill Ma Message-Id: Signed-off-by: Roman Bolshakov --- target/i386/hvf/x86_cpuid.c | 34

[PULL hvf 0/5] HVF updates for 2021-02-09

2021-02-09 Thread Roman Bolshakov
Hi Paolo, Please apply the PR to i386 queue (not for master). It contains bug fixes, cleanups and improvements for HVF accel: - Added support of older HW (Hill) - Fixed OSXSAVE reporting in CPUID (Alex) - Improved Darwin-XNU support (Vladislav) - dead code removed (Alex) Test results:

[PULL hvf 2/5] target/i386/hvf: add vmware-cpuid-freq cpu feature

2021-02-09 Thread Roman Bolshakov
not exposes HVF leaving hypervisor signature empty Signed-off-by: Vladislav Yaroshchuk Message-Id: <20210122150518.3551-1-yaroshchuk2...@gmail.com> Signed-off-by: Roman Bolshakov --- target/i386/hvf/hvf.c | 96 ++- 1 file changed, 95 insertions

Re: [PATCH] target/i386/hvf: add rdmsr 35H MSR_CORE_THREAD_COUNT

2021-02-09 Thread Roman Bolshakov
On Wed, Jan 13, 2021 at 11:53:23PM +0300, yaroshchuk2...@gmail.com wrote: > From: Vladislav Yaroshchuk > > Some guests (ex. Darwin-XNU) can attemp to read this MSR to retrieve and > validate CPU topology comparing it to ACPI MADT content > > MSR description from Intel Manual: > 35H:

Re: [PATCH v3] target/i386/hvf: add vmware-cpuid-freq cpu feature

2021-02-09 Thread Roman Bolshakov
On Fri, Jan 22, 2021 at 06:05:18PM +0300, yaroshchuk2...@gmail.com wrote: > From: Vladislav Yaroshchuk > > For `-accel hvf` cpu_x86_cpuid() is wrapped with hvf_cpu_x86_cpuid() to > add paravirtualization cpuid leaf 0x4010 > https://lkml.org/lkml/2008/10/1/246 > > Leaf 0x4010, Timing

Re: [PATCH] hvf: Fetch cr4 before evaluating CPUID(1)

2021-02-09 Thread Roman Bolshakov
On Sat, Jan 23, 2021 at 01:41:29AM +0100, Alexander Graf wrote: > The CPUID function 1 has a bit called OSXSAVE which tells user space the > status of the CR4.OSXSAVE bit. Our generic CPUID function injects that bit > based on the status of CR4. > > With Hypervisor.framework, we do not

Re: [PATCH v6 02/11] hvf: x86: Remove unused definitions

2021-02-09 Thread Roman Bolshakov
On Wed, Jan 20, 2021 at 11:44:35PM +0100, Alexander Graf wrote: > The hvf i386 has a few struct and cpp definitions that are never > used. Remove them. > > Suggested-by: Roman Bolshakov > Signed-off-by: Alexander Graf > Reviewed-by: Roman Bolshakov > Tested-by: Roman Bol

[Bug 1914849] Re: mprotect fails after MacOS 11.2 on arm mac

2021-02-08 Thread Roman Bolshakov
The patch can be used as a workaround for now: diff --git a/util/osdep.c b/util/osdep.c index 66d01b9160..76be8c295b 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -110,6 +110,9 @@ int qemu_mprotect_none(void *addr, size_t size) { #ifdef _WIN32 return qemu_mprotect__osdep(addr, size,

[Bug 1914849] Re: mprotect fails after MacOS 11.2 on arm mac

2021-02-06 Thread Roman Bolshakov
Thanks for submitting the ticket. I've just stumbled upon it after updating to 11.2. The question was already asked on apple developer forums: https://developer.apple.com/forums/thread/672804 And there's a thread going on with regard to broken nodejs on 11.2:

Re: [PATCH v3] target/i386/hvf: add vmware-cpuid-freq cpu feature

2021-02-04 Thread Roman Bolshakov
| 96 ++- > 1 file changed, 95 insertions(+), 1 deletion(-) > I'd prefer to have generic expose-accel option for CPU and vmware-cpuid-freq=on would depend on expose-accel=on. Regardless of that, Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Thanks, Roman

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-02-03 Thread Roman Bolshakov
On Tue, Feb 02, 2021 at 08:50:24AM -0600, Eric Blake wrote: > On 2/1/21 11:19 PM, Roman Bolshakov wrote: > > > After a session of debugging I believe there's an issue with Clang 12. > > Here's a test program (it reproduces unexpected ASN1_VALUE_NOT_VALID > > from _asn

Re: [PATCH v3] tcg: Fix execution on Apple Silicon

2021-02-02 Thread Roman Bolshakov
On Fri, Jan 29, 2021 at 07:27:57PM -1000, Richard Henderson wrote: > On 1/29/21 10:50 AM, Roman Bolshakov wrote: > > > > I thought you already added MAP_JIT in 6f70ddee19e. It's getting enabled > > on my M1 laptop. Was it intended or not? > > > > /* Applic

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-02-01 Thread Roman Bolshakov
On Fri, Jan 29, 2021 at 09:53:27AM +, Daniel P. Berrangé wrote: > On Fri, Jan 29, 2021 at 11:43:32AM +0300, Roman Bolshakov wrote: > > On Wed, Jan 27, 2021 at 06:59:17PM +, Daniel P. Berrangé wrote: > > > On Wed, Jan 27, 2021 at 07:56:16PM +0100, Stefan Weil wrote: >

Re: [PATCH v3] tcg: Fix execution on Apple Silicon

2021-01-29 Thread Roman Bolshakov
On Fri, Jan 29, 2021 at 10:18:58AM -1000, Richard Henderson wrote: > On 1/21/21 8:34 AM, Richard Henderson wrote: > > On 1/12/21 5:28 PM, Roman Bolshakov wrote: > >> @@ -1083,6 +1083,12 @@ static bool alloc_code_gen_buffer_anon(size_t size, > >> int prot,

libtasn1 test suite fails on macOS Bug Sur with Apple Silicon

2021-01-29 Thread Roman Bolshakov
Hello, I'm seeing the test failures on macOS and there's a concern that the behaviour might affect GnuTLS and ultimately QEMU test suite. Are there any ideas of what might be causing it? Any help is appreciated. Thanks, Roman === GNU Libtasn1

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-29 Thread Roman Bolshakov
On Wed, Jan 27, 2021 at 06:59:17PM +, Daniel P. Berrangé wrote: > On Wed, Jan 27, 2021 at 07:56:16PM +0100, Stefan Weil wrote: > > Am 27.01.21 um 19:17 schrieb Daniel P. Berrangé: > > > > > On Wed, Jan 27, 2021 at 06:05:08PM +0100, Stefan Weil wrote: > > > > Am 27.01.21 um 17:53 schrieb

Re: [PATCH v6 00/11] hvf: Implement Apple Silicon Support

2021-01-28 Thread Roman Bolshakov
On Thu, Jan 28, 2021 at 04:59:47PM +, Peter Maydell wrote: > On Wed, 20 Jan 2021 at 22:44, Alexander Graf wrote: > > > > Now that Apple Silicon is widely available, people are obviously excited > > to try and run virtualized workloads on them, such as Linux and Windows. > > > > This patch set

[Bug 1909256] Re: compile failure if gnutls headers not on default include path

2021-01-25 Thread Roman Bolshakov
The fix is committed in 3eacf70bb5a8. ** Changed in: qemu Status: New => Fix Committed ** Changed in: qemu Assignee: (unassigned) => Roman Bolshakov (roolebo) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PULL v2 10/10] tcg: Restart code generation when we run out of temps

2021-01-25 Thread Roman Bolshakov
AX_TEMPS); > + > +if (n >= TCG_MAX_TEMPS) { > +/* Signal overflow, starting over with fewer guest insns. */ > +siglongjmp(s->jmp_trans, -2); > +} > return memset(>temps[n], 0, sizeof(TCGTemp)); > } > > -static inline TCGTemp *t

[Bug 1912065] Re: Segfaults in tcg/optimize.c:212 after commit 7c79721606be11b5bc556449e5bcbc331ef6867d

2021-01-23 Thread Roman Bolshakov
Richard, thanks for providing the workaround. It helps. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1912065 Title: Segfaults in tcg/optimize.c:212 after commit

Re: [PATCH v4] tcg: Toggle page execution for Apple Silicon

2021-01-23 Thread Roman Bolshakov
On Sat, Jan 23, 2021 at 07:33:37PM +0100, BALATON Zoltan wrote: > On Sat, 23 Jan 2021, Roman Bolshakov wrote: > > On Sat, Jan 23, 2021 at 02:53:49PM +0300, Roman Bolshakov wrote: > > > On Thu, Jan 21, 2021 at 08:47:52AM -1000, Richard Henderson wrote: > > &

Re: [PATCH v4] tcg: Toggle page execution for Apple Silicon

2021-01-23 Thread Roman Bolshakov
On Sat, Jan 23, 2021 at 02:53:49PM +0300, Roman Bolshakov wrote: > On Thu, Jan 21, 2021 at 08:47:52AM -1000, Richard Henderson wrote: > > From: Roman Bolshakov > > > > Pages can't be both write and executable at the same time on Apple > > Silicon. macOS provides

Re: [PATCH v4] tcg: Toggle page execution for Apple Silicon

2021-01-23 Thread Roman Bolshakov
On Thu, Jan 21, 2021 at 08:47:52AM -1000, Richard Henderson wrote: > From: Roman Bolshakov > > Pages can't be both write and executable at the same time on Apple > Silicon. macOS provides public API to switch write protection [1] for > JIT applications, like TCG. &

Re: [PATCH v2] target/i386/hvf: add vmware-cpuid-freq cpu feature

2021-01-19 Thread Roman Bolshakov
On Thu, Jan 14, 2021 at 10:47:03PM +0300, yaroshchuk2...@gmail.com wrote: > From: Vladislav Yaroshchuk > > For `-accel hvf` cpu_x86_cpuid() is wrapped with hvf_cpu_x86_cpuid() to > add paravirtualization cpuid leaf 0x4010 > https://lkml.org/lkml/2008/10/1/246 > > Leaf 0x4010, Timing

Re: [PATCH v3] hvf: guard xgetbv call.

2021-01-19 Thread Roman Bolshakov
eedback. > > target/i386/hvf/x86_cpuid.c | 34 ++ > 1 file changed, 22 insertions(+), 12 deletions(-) > Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Thanks, Roman > diff --git a/target/i386/hvf/x86_cpuid.c b/target/i386/hvf/x86_cp

[PATCH v3] tcg: Fix execution on Apple Silicon

2021-01-12 Thread Roman Bolshakov
Pages can't be both write and executable at the same time on Apple Silicon. macOS provides public API to switch write protection [1] for JIT applications, like TCG. 1. https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon Signed-off-by: Roman

Re: [PATCH] hvf: guard xgetbv call.

2021-01-11 Thread Roman Bolshakov
On Mon, Jan 11, 2021 at 07:06:22AM -1000, Richard Henderson wrote: > On 1/10/21 6:31 PM, Roman Bolshakov wrote: > >> Also, if we're going to put this some place common, forcing the caller to > >> do > >> the cpuid that feeds this, then we should probably make all o

Re: [PATCH v2] hvf: guard xgetbv call.

2021-01-11 Thread Roman Bolshakov
On Mon, Jan 11, 2021 at 09:44:40PM -0800, Hill Ma wrote: > On Sun, Jan 10, 2021 at 8:38 PM Roman Bolshakov wrote: > > I'm not sure if eax should be modified with mask because the mask has no > > value per se. I.e. eax &= supp_xcr0 from below should be placed inside >

Re: [PATCH v2] hvf: guard xgetbv call.

2021-01-10 Thread Roman Bolshakov
On Sun, Jan 10, 2021 at 01:08:54PM -0800, Hill Ma wrote: > This prevents illegal instruction on cpus do not support xgetbv. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 > Signed-off-by: Hill Ma > --- > v2: xgetbv() modified based on feedback. > > target/i386/hvf/x86_cpuid.c | 28

Re: [PATCH] hvf: guard xgetbv call.

2021-01-10 Thread Roman Bolshakov
On Sun, Jan 10, 2021 at 08:38:36AM -1000, Richard Henderson wrote: > On 1/10/21 8:34 AM, Richard Henderson wrote: > > On 1/9/21 3:46 PM, Roman Bolshakov wrote: > >> +static int xgetbv(uint32_t cpuid_ecx, uint32_t idx, uint64_t *xcr) > >> { > >> -uint32

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-09 Thread Roman Bolshakov
On Sun, Jan 10, 2021 at 02:13:48AM +0100, BALATON Zoltan wrote: > On Sun, 10 Jan 2021, Roman Bolshakov wrote: > > On Sat, Jan 09, 2021 at 12:13:36AM +0100, BALATON Zoltan wrote: > > > On Sat, 9 Jan 2021, Roman Bolshakov wrote: > > > > On Fri, Jan 08, 2021 at 03:00:0

Re: [PATCH] hvf: guard xgetbv call.

2021-01-09 Thread Roman Bolshakov
On Sat, Jan 09, 2021 at 11:42:18AM +, Peter Maydell wrote: > On Sat, 9 Jan 2021 at 05:49, Roman Bolshakov wrote: > > > > On Fri, Dec 18, 2020 at 06:13:47PM -0800, Hill Ma wrote: > > > This prevents illegal instruction on cpus do not support xgetbv. &g

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-09 Thread Roman Bolshakov
On Sat, Jan 09, 2021 at 01:25:44PM +0100, Christian Schoenebeck via wrote: > On Samstag, 9. Januar 2021 00:13:36 CET BALATON Zoltan wrote: > > On Sat, 9 Jan 2021, Roman Bolshakov wrote: > > > On Fri, Jan 08, 2021 at 03:00:07PM +, Peter Maydell wrote: > > >> On F

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-09 Thread Roman Bolshakov
On Sat, Jan 09, 2021 at 12:13:36AM +0100, BALATON Zoltan wrote: > On Sat, 9 Jan 2021, Roman Bolshakov wrote: > > On Fri, Jan 08, 2021 at 03:00:07PM +, Peter Maydell wrote: > > > On Fri, 8 Jan 2021 at 13:50, Peter Maydell > > > wrote: > > > > >

Re: [PATCH] ui/cocoa: Update path to docs in build tree

2021-01-08 Thread Roman Bolshakov
On Sat, Jan 09, 2021 at 12:38:15AM +0300, Roman Bolshakov wrote: > QEMU documentation can't be opened if QEMU is run from build tree > because executables are placed in the top of build tree after conversion > to meson. > > Signed-off-by: Roman Bolshakov > --- > ui/coc

Re: [PATCH] hvf: guard xgetbv call.

2021-01-08 Thread Roman Bolshakov
On Fri, Dec 18, 2020 at 06:13:47PM -0800, Hill Ma wrote: > This prevents illegal instruction on cpus do not support xgetbv. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 > Signed-off-by: Hill Ma > --- > target/i386/hvf/x86_cpuid.c | 11 --- > 1 file changed, 8 insertions(+),

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-08 Thread Roman Bolshakov
On Fri, Jan 08, 2021 at 03:05:55PM +, Peter Maydell wrote: > On Fri, 8 Jan 2021 at 15:00, Peter Maydell wrote: > > > > On Fri, 8 Jan 2021 at 13:50, Peter Maydell wrote: > > > > > > On Sat, 2 Jan 2021 at 15:14, Roman Bolshakov > > > wrote: &

[PATCH] ui/cocoa: Update path to docs in build tree

2021-01-08 Thread Roman Bolshakov
QEMU documentation can't be opened if QEMU is run from build tree because executables are placed in the top of build tree after conversion to meson. Signed-off-by: Roman Bolshakov --- ui/cocoa.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-08 Thread Roman Bolshakov
On Fri, Jan 08, 2021 at 03:00:07PM +, Peter Maydell wrote: > On Fri, 8 Jan 2021 at 13:50, Peter Maydell wrote: > > > > On Sat, 2 Jan 2021 at 15:14, Roman Bolshakov wrote: > > > > > > ui/cocoa.m:1188:44: warning: 'openFile:' is deprecated: first depr

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-08 Thread Roman Bolshakov
On Thu, Jan 07, 2021 at 08:41:50PM +0100, Paolo Bonzini wrote: > Il gio 7 gen 2021, 20:36 Roman Bolshakov ha scritto: > > > > No I think that Meson should simply explode link_whole libraries to their > > > constituent objects. This way duplicates are avoided. >

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-07 Thread Roman Bolshakov
On Thu, Jan 07, 2021 at 07:22:06PM +0100, Paolo Bonzini wrote: > On 07/01/21 19:18, Roman Bolshakov wrote: > > > > > The real issue is that Meson's implementation of link_whole for > > > library-in-library makes sense for one use case (convenience library that > &g

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-07 Thread Roman Bolshakov
On Thu, Jan 07, 2021 at 05:23:54PM +0100, Paolo Bonzini wrote: > On 07/01/21 16:56, Roman Bolshakov wrote: > > IMO duplication of dependencies shouldn't be needed for a build system. > > Meta build system should allow private and public dependencies. Different > > rule

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-07 Thread Roman Bolshakov
On Thu, Jan 07, 2021 at 12:41:40PM +0100, Paolo Bonzini wrote: > On 05/01/21 15:37, Roman Bolshakov wrote: > > Does it work if you do: > > > > crypto_ss.add(authz, qom) > > libcrypto = static_library('crypto', crypto_ss.sources() + genh, > >

Re: [PATCH v5 00/11] hvf: Implement Apple Silicon Support

2021-01-06 Thread Roman Bolshakov
ball > going on that. With this applied, I can successfully run both Linux and > Windows as guests. I am not aware of any limitations specific to > Hypervisor.framework apart from: > > - Live migration / savevm > - gdbstub debugging (SP register) > > > Enjoy! > Hi

Re: [PATCH v2] tcg: Fix execution on Apple Silicon

2021-01-05 Thread Roman Bolshakov
iltin_available(macOS 11, *)) { > pthread_jit_write_protect_np(); > } > > You still need a compile time check like MAC_OS_VERSION_11_0 to > support linking with older SDKs. > I'll address the issue in v3. Thanks for catching it. Regards, Roman > On Sun,

Re: [PATCH v2] tcg: Fix execution on Apple Silicon

2021-01-05 Thread Roman Bolshakov
On Mon, Jan 04, 2021 at 08:28:08PM +, Alex Bennée wrote: > > Alexander Graf writes: > > > On 04.01.21 16:23, Alex Bennée wrote: > >> Roman Bolshakov writes: > >> > >>> Pages can't be both write and executable at the same time on Apple >

Re: [PATCH v2] tcg: Fix execution on Apple Silicon

2021-01-05 Thread Roman Bolshakov
On Mon, Jan 04, 2021 at 07:39:13PM +0100, Alexander Graf wrote: > > On 04.01.21 16:23, Alex Bennée wrote: > > Roman Bolshakov writes: > > > > > Pages can't be both write and executable at the same time on Apple > > > Silicon. macOS provides publ

Re: [PATCH v2] tcg: Fix execution on Apple Silicon

2021-01-05 Thread Roman Bolshakov
On Mon, Jan 04, 2021 at 03:23:07PM +, Alex Bennée wrote: > > Roman Bolshakov writes: > > > Pages can't be both write and executable at the same time on Apple > > Silicon. macOS provides public API to switch write protection [1] for > > JIT applications, like

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-05 Thread Roman Bolshakov
On Mon, Jan 04, 2021 at 09:50:32PM +0100, Paolo Bonzini wrote: > On 04/01/21 18:24, Roman Bolshakov wrote: > > Hi Paolo, > > > > I'm sorry I didn't reply earlier. As I showed in an example to Peter > > (https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg00085.ht

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-04 Thread Roman Bolshakov
On Sat, Jan 02, 2021 at 08:43:51PM +0100, Paolo Bonzini wrote: > On 02/01/21 14:25, Peter Maydell wrote: > > Question to Paolo -- it seems pretty fragile to have to explicitly > > list "these source files need these extra CFLAGS" in half a dozen > > meson.build files, because it's pretty

Re: [PATCH] tcg: Fix execution on Apple Silicon

2021-01-03 Thread Roman Bolshakov
nge of permissions to rw inside do_tb_phys_invalidate() just before TB spin lock is acquired. Regards, Roman > -j > > On Sun, Jan 3, 2021 at 6:20 AM Roman Bolshakov wrote: > > > > On Sat, Jan 02, 2021 at 11:55:29AM -0800, Joelle van Dyne wrote: > > > I see you didn't touch cpu_loop_

Re: [PATCH v2] tcg: Fix execution on Apple Silicon

2021-01-03 Thread Roman Bolshakov
On Sun, Jan 03, 2021 at 08:52:52AM -0800, Joelle van Dyne wrote: > MAC_OS_VERSION_11_0 is always defined. You can see in > usr/include/AvailabilityVersions.h > It's not defined on my old MPB that has Catalina (10.15.7). The last entries are: #define MAC_OS_X_VERSION_10_15 101500 #define

[PATCH v2] tcg: Fix execution on Apple Silicon

2021-01-03 Thread Roman Bolshakov
Pages can't be both write and executable at the same time on Apple Silicon. macOS provides public API to switch write protection [1] for JIT applications, like TCG. 1. https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon Signed-off-by: Roman

Re: [PATCH] tcg: Fix execution on Apple Silicon

2021-01-03 Thread Roman Bolshakov
ission back and force unless it's needed to avoid EXC_BAD_ACCESS. Regards, Roman > -j > > On Sat, Jan 2, 2021 at 8:13 AM Roman Bolshakov wrote: > > > > On Sat, Jan 02, 2021 at 03:21:02PM +0300, Roman Bolshakov wrote: > > > Pages can't be both write and executable at t

Re: [PATCH] tcg: Fix execution on Apple Silicon

2021-01-02 Thread Roman Bolshakov
On Sat, Jan 02, 2021 at 03:21:02PM +0300, Roman Bolshakov wrote: > Pages can't be both write and executable at the same time on Apple > Silicon. macOS provides public API to switch write protection [1] for > JIT applications, like TCG. > > 1. > https://developer.apple

[PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-02 Thread Roman Bolshakov
10.0, 11.0)); ^ Signed-off-by: Roman Bolshakov --- Changes since v1: - Changed URLWithString: to fileURLWithPath:isDirectory: (Peter) ui/cocoa.m | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index f32adc3074..ea3b845b53 100644 --- a/ui/cocoa.m +++ b/

Re: [PATCH] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-02 Thread Roman Bolshakov
On Sat, Jan 02, 2021 at 01:16:48PM +, Peter Maydell wrote: > On Sat, 2 Jan 2021 at 12:52, Roman Bolshakov wrote: > > > > ui/cocoa.m:1188:44: warning: 'openFile:' is deprecated: first deprecated in > > macOS 11.0 - Use -[NSWorkspace openURL:] instead. > >

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-02 Thread Roman Bolshakov
On Sat, Jan 02, 2021 at 01:25:07PM +, Peter Maydell wrote: > On Sat, 2 Jan 2021 at 12:54, Roman Bolshakov wrote: > > > > crypto/tlscreds.h includes GnuTLS headers if CONFIG_GNUTLS is set, but > > GNUTLS_CFLAGS, that describe include path, are not propagated > >

[PATCH] meson: Propagate gnutls dependency

2021-01-02 Thread Roman Bolshakov
-by: Roman Bolshakov --- block/meson.build | 2 +- io/meson.build | 2 +- meson.build| 5 +++-- storage-daemon/meson.build | 2 +- tests/meson.build | 6 +++--- ui/meson.build | 2 +- 6 files changed, 10 insertions(+), 9 deletions(-) diff

[PATCH] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-02 Thread Roman Bolshakov
10.0, 11.0)); ^ Signed-off-by: Roman Bolshakov --- ui/cocoa.m | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index f32adc3074..5909758a09 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1178,6 +1178,7 @@ QemuCocoaView *cocoaView; /* Where to look for l

[PATCH RESEND] configure: Don't warn about lack of PIE on macOS

2021-01-02 Thread Roman Bolshakov
ld64 is making PIE executables for 10.7 and above by default, as documented in ld(1). Reviewed-by: Cameron Esfahani Signed-off-by: Roman Bolshakov --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 881af4b6be..942e20dfe7 100755 --- a/configure +++ b

  1   2   3   4   >