Re: [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT

2015-12-29 Thread Roman Kagan
On Tue, Dec 29, 2015 at 03:09:36PM +0100, Igor Mammedov wrote: > On Fri, 25 Dec 2015 18:04:08 +0300 > Roman Kagan wrote: > > > Windows on UEFI systems is only capable of detecting the presence and > > the type of floppy drives via corresponding ACPI objects. > > >

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-25 Thread Roman Kagan
On Thu, Dec 24, 2015 at 08:17:45AM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 23, 2015 at 08:51:45PM +0300, Roman Kagan wrote: > > On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote: > > > On Wed, 23 Dec 2015 20:20:54 +0300 > > > Roman Kagan wrote: >

[Qemu-devel] [PATCH v4 4/4] i386: populate floppy drive information in SSDT

2015-12-25 Thread Roman Kagan
adds those objects to the floppy controller in SSDT, populating them with the information from the respective QEMU objects. Signed-off-by: Roman Kagan Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Igor Mammedov Cc: John Snow Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Richard Henders

[Qemu-devel] [PATCH v4 3/4] expose floppy drive geometry and CMOS type

2015-12-25 Thread Roman Kagan
access the floppy drives. Signed-off-by: Roman Kagan Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Igor Mammedov Cc: John Snow Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Richard Henderson Cc: qemu-bl...@nongnu.org Cc: qemu-sta...@nongnu.org --- changes since v3: - split out into a sepa

[Qemu-devel] [PATCH v4 1/4] i386/pc: expose identifying the floppy controller

2015-12-25 Thread Roman Kagan
Factor out and expose the function to locate the floppy controller in the system. It will be useful when dynamically populating the relevant objects in the ACPI tables. Signed-off-by: Roman Kagan Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Igor Mammedov Cc: John Snow Cc: Kevi

[Qemu-devel] [PATCH v4 2/4] i386/acpi: make floppy controller object dynamic

2015-12-25 Thread Roman Kagan
the declarations of the fields indicating whether the contoller is enabled. Signed-off-by: Roman Kagan Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Igor Mammedov Cc: John Snow Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Richard Henderson Cc: qemu-bl...@nongnu.org Cc: qemu-sta...@

[Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT

2015-12-25 Thread Roman Kagan
drive controller description into runtime-generated SSDT. Note that the series conflicts with Igor's patchset for dynamic DSDT, in particular, with "[PATCH 50/74] pc: acpi: move FDC0 device from DSDT to SSDT"; I haven't managed to avoid that while trying to meet maintainer'

Re: [Qemu-devel] [PATCH v2] kvm: Make vcpu->requests as 64 bit bitmap

2015-12-24 Thread Roman Kagan
: James Hogan > CC: Paolo Bonzini > CC: Gleb Natapov > CC: James Hogan > CC: Paul Burton > CC: Ralf Baechle > CC: Alexander Graf > CC: Christian Borntraeger > CC: Cornelia Huck > CC: linux-m...@linux-mips.org > CC: kvm-...@vger.kernel.org > CC: linux-

Re: [Qemu-devel] [PATCH v1 1/2] kvm/x86: Hyper-V SynIC tracepoints

2015-12-24 Thread Roman Kagan
On Wed, Dec 23, 2015 at 04:53:59PM +0300, Andrey Smetanin wrote: > Trace the following Hyper SynIC events: > * set msr > * set sint irq > * ack sint > * sint irq eoi > > Signed-off-by: Andrey Smetanin > CC: Gleb Natapov > CC: Paolo Bonzini > CC: Roman Kagan &g

Re: [Qemu-devel] [PATCH v1 2/2] kvm/x86: Hyper-V SynIC timers tracepoints

2015-12-24 Thread Roman Kagan
tup > * timer cleanup > > Signed-off-by: Andrey Smetanin > CC: Gleb Natapov > CC: Paolo Bonzini > CC: Roman Kagan > CC: Denis V. Lunev > CC: qemu-devel@nongnu.org > --- > arch/x86/kvm/hyperv.c | 27 +++- > arch/x86/kvm/trace.h | 170 > +

Re: [Qemu-devel] [PATCH v1] kvm: Make vcpu->requests as 64 bit bitmap

2015-12-24 Thread Roman Kagan
On Thu, Dec 24, 2015 at 12:30:26PM +0300, Andrey Smetanin wrote: > Currently on x86 arch we has already 32 requests defined > so the newer request bits can't be placed inside > vcpu->requests(unsigned long) inside x86 32 bit system. > But we are going to add a new request in x86 arch > for Hyper-V

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Roman Kagan
On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote: > On Wed, 23 Dec 2015 20:20:54 +0300 > Roman Kagan wrote: > > > ... two 1.44M drives with bogus geometry for q35. > > > > This one is a bug in my patch, indeed: I was tricked by FDRIVE_DRV_NONE > &

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Roman Kagan
On Wed, Dec 23, 2015 at 06:06:31PM +0300, Roman Kagan wrote: > On Wed, Dec 23, 2015 at 03:45:29PM +0200, Michael S. Tsirkin wrote: > > This is the actual vs expected diff with both patches applied. > > Interesting... The diff suggests that qemu running in your test > environ

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Roman Kagan
On Wed, Dec 23, 2015 at 03:45:29PM +0200, Michael S. Tsirkin wrote: > This is the actual vs expected diff with both patches applied. Interesting... The diff suggests that qemu running in your test environment has no floppy drives, while in mine ... > +Scope (\_SB.PCI0.ISA.FDC0) > +{ > +

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Roman Kagan
On Tue, Dec 22, 2015 at 06:41:47PM +0200, Michael S. Tsirkin wrote: > On Fri, Dec 18, 2015 at 10:32:30PM +0300, Roman Kagan wrote: > > Update the expected SSDTs to reflect the changes introduced in the > > previous patch. > > > > Signed-off-by: Roman Kagan > &

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Roman Kagan
On Wed, Dec 23, 2015 at 10:47:22AM +, Daniel P. Berrange wrote: > On Wed, Dec 23, 2015 at 11:14:12AM +0800, Fam Zheng wrote: > > As an alternative, can we introduce .bdrv_flock() in protocol drivers, with > > similar semantics to flock(2) or lockf(3)? That way all formats can benefit, > > and a

Re: [Qemu-devel] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT

2015-12-22 Thread Roman Kagan
On Tue, Dec 22, 2015 at 05:07:16PM +0200, Michael S. Tsirkin wrote: > On Fri, Dec 18, 2015 at 10:32:29PM +0300, Roman Kagan wrote: > > On x86-based systems Linux determines the presence and the type of > > floppy drives via a query of a CMOS field. So does SeaBIOS when > >

[Qemu-devel] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT

2015-12-18 Thread Roman Kagan
SSDT, populating them via AML API. For that, a couple of functions are extern-ified to facilitate populating those objects in acpi-build.c. Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin CC: Igor Mammedov CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkos

[Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-18 Thread Roman Kagan
Update the expected SSDTs to reflect the changes introduced in the previous patch. Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin CC: Igor Mammedov CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost CC: John Snow CC: Kevin Wolf --- changes since

[Qemu-devel] [PATCH v3 0/2] i386: expose floppy-related objects in SSDT

2015-12-18 Thread Roman Kagan
Roman Kagan (2): i386: expose floppy-related objects in SSDT tests: update expected SSDT for floppy changes Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin CC: Igor Mammedov CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost CC: John Snow CC

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

2015-12-18 Thread Roman Kagan
On Fri, Dec 18, 2015 at 10:10:11AM -0800, Peter Hornyack wrote: > On Fri, Dec 18, 2015 at 8:01 AM, Paolo Bonzini wrote: > > On 18/12/2015 16:19, Pavel Fedin wrote: > >> As far as i understand this code, KVM_EXIT_HYPERV is called when one > >> of three MSRs are accessed. But, shouldn't we have impl

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

2015-12-18 Thread 'Roman Kagan'
On Fri, Dec 18, 2015 at 05:01:59PM +0100, Paolo Bonzini wrote: > On 18/12/2015 16:19, Pavel Fedin wrote: > > As far as i understand this code, KVM_EXIT_HYPERV is called when one > > of three MSRs are accessed. But, shouldn't we have implemented > > instead something more generic, like KVM_EXIT_REG

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

2015-12-18 Thread 'Roman Kagan'
On Fri, Dec 18, 2015 at 06:19:25PM +0300, Pavel Fedin wrote: > I dislike implementing architecture-dependent exit code where we could > implement an architecture-independent one. > > As far as i understand this code, KVM_EXIT_HYPERV is called when one of > three MSRs are accessed. But, shouldn

Re: [Qemu-devel] [PATCH v2 1/1] i386: expose floppy-related objects in SSDT

2015-12-17 Thread Roman Kagan
On Wed, Dec 16, 2015 at 11:15:55PM +0100, Igor Mammedov wrote: > On Wed, 16 Dec 2015 20:34:55 +0300 > Roman Kagan wrote: > > > On Wed, Dec 16, 2015 at 05:46:57PM +0100, Igor Mammedov wrote: > > > On Wed, 16 Dec 2015 10:45:09 +0300 "Denis V. Lunev" > &

Re: [Qemu-devel] [PATCH v2 1/1] i386: expose floppy-related objects in SSDT

2015-12-16 Thread Roman Kagan
On Wed, Dec 16, 2015 at 05:46:57PM +0100, Igor Mammedov wrote: > On Wed, 16 Dec 2015 10:45:09 +0300 "Denis V. Lunev" > wrote: > > @@ -1125,6 +1183,26 @@ build_ssdt(GArray *table_data, GArray *linker, > > aml_append(ssdt, scope); > > } > > > > +{ > add this block only if floppy

Re: [Qemu-devel] [PATCH for 2.5? 1/1] DSDT: add floppy-related objects

2015-12-14 Thread Roman Kagan
On Mon, Dec 14, 2015 at 04:05:03PM +0100, Igor Mammedov wrote: > On Mon, 14 Dec 2015 11:22:39 +0300 > "Denis V. Lunev" wrote: > > > From: Roman Kagan > > > > On x86-based systems Linux determines the presence and the type of > > floppy drives via a q

Re: [Qemu-devel] [PATCH v1 7/7] kvm/x86: Hyper-V SynIC timers

2015-11-30 Thread Roman Kagan
On Fri, Nov 27, 2015 at 11:49:40AM +0100, Paolo Bonzini wrote: [ sorry missed your message on Friday, replying now ] > On 27/11/2015 09:12, Roman Kagan wrote: > >> > +n = div64_u64(time_now - stimer->exp_time, stimer->count) + 1; > >> > +stim

Re: [Qemu-devel] [PATCH v1 6/7] kvm/x86: Hyper-V SynIC message slot pending clearing at SINT ack

2015-11-27 Thread Roman Kagan
and let the message sources compete for the slot again. > > Signed-off-by: Andrey Smetanin > CC: Gleb Natapov > CC: Paolo Bonzini > CC: "K. Y. Srinivasan" > CC: Haiyang Zhang > CC: Vitaly Kuznetsov > CC: Roman Kagan > CC: Denis V. Lunev > CC: qemu-devel@nongnu.org Reviewed-by: Roman Kagan Roman.

Re: [Qemu-devel] [PATCH v1 7/7] kvm/x86: Hyper-V SynIC timers

2015-11-27 Thread Roman Kagan
s of the corresponding configuration > MSR. If deemed necessary, the "catch up" mode (the timer period is > shortened until the timer catches up) will be implemented later. > > Signed-off-by: Andrey Smetanin > CC: Gleb Natapov > CC: Paolo Bonzini > CC: "K.

Re: [Qemu-devel] [PATCH v3 9/9] kvm/x86: Hyper-V kvm exit

2015-11-03 Thread Roman Kagan
On Tue, Nov 03, 2015 at 03:51:16PM +0100, Paolo Bonzini wrote: > > > On 03/11/2015 15:36, Andrey Smetanin wrote: > >> > >> > >> if I run a patched QEMU but I *do not* enable the synthetic interrupt > >> controller. I can fix it by wrapping the calls to synic_exit with "if > >> (!host)", but I ha

Re: [Qemu-devel] [kvm-unit-tests PATCH] x86: hyperv_synic: Hyper-V SynIC test

2015-11-02 Thread Roman Kagan
r-V SynIC MSR's > > * setup Hyper-V SynIC evt/msg pages > > * setup SINT's routing > > * inject SINT's into destination vCPU by 'hyperv-synic-test-device' > > * wait for SINT's isr's completion > > * clear Hyper-V SynIC evt/msg pages and

Re: [Qemu-devel] [PATCH v3 8/9] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-29 Thread Roman Kagan
On Wed, Oct 28, 2015 at 06:41:45PM +0100, Paolo Bonzini wrote: > Hi Andrey, > > just one question. Is kvm_arch_set_irq actually needed? I think > everything should work fine without it. Can you check? If so, I can > remove it myself and revert the patch that introduced the hook. While Andrey

Re: [Qemu-devel] [PATCH 9/9] kvm/x86: Hyper-V kvm exit

2015-10-16 Thread Roman Kagan
On Fri, Oct 16, 2015 at 09:51:58AM +0200, Paolo Bonzini wrote: > The documentation should include the definition of the struct and the > definition of the subtypes (currently KVM_EXIT_HYPERV_SYNIC only). > > Documentation for KVM_CAP_HYPERV_SINIC and KVM_IRQ_ROUTING_HV_SINT is > missing, too. > >

Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-12 Thread Roman Kagan
On Mon, Oct 12, 2015 at 07:42:42AM -0600, Eric Blake wrote: > On 10/09/2015 07:39 AM, Denis V. Lunev wrote: > > From: Andrey Smetanin > > > > A new vcpu exit is introduced to notify the userspace of the > > changes in Hyper-V synic configuraion triggered by guest writing to the > Again, is 'synic

Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-12 Thread Roman Kagan
On Mon, Oct 12, 2015 at 10:58:36AM +0200, Paolo Bonzini wrote: > On 12/10/2015 10:48, Cornelia Huck wrote: > > Going back to Paolo's original question, I think changing the check > > to !KVM_IRQ_ROUTING_IRQCHIP makes sense, if I understand the code > > correctly. They seem to be the only special on

Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-09 Thread Roman Kagan
On Fri, Oct 09, 2015 at 04:41:15PM +0200, Paolo Bonzini wrote: > On 09/10/2015 15:39, Denis V. Lunev wrote: > > A new vcpu exit is introduced to notify the userspace of the > > changes in Hyper-V synic configuraion triggered by guest writing to the > > corresponding MSRs. > > Why is this exit nece

Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-09 Thread Roman Kagan
On Fri, Oct 09, 2015 at 04:42:33PM +0200, Paolo Bonzini wrote: > You need to add SYNIC vectors to the EOI exit bitmap, so that APICv > (Xeon E5 or higher, Ivy Bridge or newer) is handled correctly. You also > need to check the auto EOI exit bitmap in __apic_accept_irq, and avoid > going through kv

Re: [Qemu-devel] [PATCH 25/27] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-04-29 Thread Roman Kagan
On Tue, Apr 28, 2015 at 01:59:56PM +0300, Roman Kagan wrote: > On Tue, Apr 28, 2015 at 10:46:58AM +0300, Denis V. Lunev wrote: > > This is preparational commit for tweaks in Parallels image expansion. > > The idea is that enlarge via truncate by one data block is slow. It > >

Re: [Qemu-devel] [PATCH 25/27] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-04-28 Thread Roman Kagan
or the image expansion > - tail writes are ordered, i.e. the guest IO queue could not be sent > immediately to the host introducing additional IO delays > > This patch just adds proper parameters into BDRVParallelsState and > performs options parsing in parallels_open. > >

Re: [Qemu-devel] [PATCH 09/27] block/parallels: _co_writev callback for Parallels format

2015-04-28 Thread Roman Kagan
On Tue, Apr 28, 2015 at 10:46:42AM +0300, Denis V. Lunev wrote: > Support write on Parallels images. The code is almost the same as one > in the previous patch implemented scatter-gather IO for read. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf >

Re: [Qemu-devel] [PATCH 26/27] block/parallels: optimize linear image expansion

2015-04-28 Thread Roman Kagan
On Tue, Apr 28, 2015 at 10:46:59AM +0300, Denis V. Lunev wrote: > Plain image expansion spends a lot of time to update image file size. > This seriously affects the performance. The following simple test > qemu_img create -f parallels -o cluster_size=64k ./1.hds 64G > qemu_io -n -c "write -P 0x

Re: [Qemu-devel] [PATCH 08/27] block/parallels: mark parallels format driver as zero inited

2015-04-28 Thread Roman Kagan
On Tue, Apr 28, 2015 at 10:46:41AM +0300, Denis V. Lunev wrote: > From the guest point of view unallocated blocks are zeroed. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 1 + > 1 file change

Re: [Qemu-devel] [PATCH 06/27] block/parallels: provide _co_readv routine for parallels format driver

2015-04-28 Thread Roman Kagan
ment about locking considerations in the driver. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 54 +- > 1 file changed, 33 insertions(+), 21 deletions(-) Reviewed-by: Roman Kagan

Re: [Qemu-devel] [PATCH 18/27] block/parallels: implement parallels_check method of block driver

2015-03-11 Thread Roman Kagan
mage are zeroed. Nothing else could be done here > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 85 > +++ > 1 file changed, 85 insertions(+) Reviewed-by: Roman Kagan Roman.

Re: [Qemu-devel] [PATCH 27/27] block/parallels: improve image writing performance further

2015-03-11 Thread Roman Kagan
ential write is increased from 200 Gb/sec to > 235 Gb/sec on my SSD HDD. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 44 > 1 file changed, 24 insertions(+),

Re: [Qemu-devel] [PATCH 22/27] block/parallels: improve image reading performance

2015-03-10 Thread Roman Kagan
On Tue, Mar 10, 2015 at 11:51:16AM +0300, Denis V. Lunev wrote: > Try to perform IO for the biggest continuous block possible. > The performance for sequential read is increased from 220 Gb/sec to > 360 Gb/sec for continous image on my SSD HDD. > > Signed-off-by: Denis V. Lunev &g

Re: [Qemu-devel] [PATCH 19/27] block/parallels: implement incorrect close detection

2015-03-10 Thread Roman Kagan
On Tue, Mar 10, 2015 at 05:44:19PM +0300, Denis V. Lunev wrote: > On 10/03/15 17:38, Roman Kagan wrote: > >On Tue, Mar 10, 2015 at 11:51:13AM +0300, Denis V. Lunev wrote: > >>The software driver must set inuse field in Parallels header to > >>0x746F6E59 when the image i

Re: [Qemu-devel] [PATCH 17/27] block/parallels: move parallels_open/probe to the very end of the file

2015-03-10 Thread Roman Kagan
On Tue, Mar 10, 2015 at 11:51:11AM +0300, Denis V. Lunev wrote: > This will help to avoid forward declarations for upcoming parallels_check > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- >

Re: [Qemu-devel] [PATCH 23/27] block/parallels: create bat_entry_off helper

2015-03-10 Thread Roman Kagan
On Tue, Mar 10, 2015 at 11:51:17AM +0300, Denis V. Lunev wrote: > calculate offset of the BAT entry in the image file. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 15 +-- > 1

Re: [Qemu-devel] [PATCH 16/27] block/parallels: read parallels image header and BAT into single buffer

2015-03-10 Thread Roman Kagan
V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 24 +--- > 1 file changed, 17 insertions(+), 7 deletions(-) Reviewed-by: Roman Kagan Roman.

Re: [Qemu-devel] [PATCH 18/27] block/parallels: implement parallels_check method of block driver

2015-03-10 Thread Roman Kagan
mage are zeroed. Nothing else could be done here > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 82 > +++ > 1 file changed, 82 insertions(+) &

Re: [Qemu-devel] [PATCH 25/27] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-03-10 Thread Roman Kagan
pand by some significant amount at once. > > This patch just adds proper parameters into BDRVParallelsState and > performs options parsing in parallels_open. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajno

Re: [Qemu-devel] [PATCH 20/27] iotests, parallels: check for incorrectly closed image in tests

2015-03-10 Thread Roman Kagan
On Tue, Mar 10, 2015 at 11:51:14AM +0300, Denis V. Lunev wrote: > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > tests/qemu-iotests/115 | 9 + > tests/qemu-iotests/115.out | 19 ++- > 2 file

Re: [Qemu-devel] [PATCH 19/27] block/parallels: implement incorrect close detection

2015-03-10 Thread Roman Kagan
BDRVParallelsState for this. > > On the other hand, nothing should be done to clear inuse in > parallels_check. Generic close will do the job right. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 5

Re: [Qemu-devel] [PATCH 24/27] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-03-10 Thread Roman Kagan
64k ./1.hds 64G > qemu-io -f parallels -c "write -P 0x11 0 1024k" 1.hds > writing from 50-60 Mb/sec to 80-90 Mb/sec on rotational media and > from 160 Mb/sec to 190 Mb/sec on SSD disk. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin

Re: [Qemu-devel] [PATCH 21/27] block/parallels: no need to flush on each block allocation table update

2015-03-10 Thread Roman Kagan
1.hds > from 45 Mb/sec to 160 Mb/sec on my SSD disk. The gain on rotational media > is much more sufficient, from 800 Kb/sec to 45 Mb/sec. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 2 +-

Re: [Qemu-devel] [PATCH 15/27] block/parallels: keep BAT bitmap data in little endian in memory

2015-03-10 Thread Roman Kagan
On Tue, Mar 10, 2015 at 11:51:09AM +0300, Denis V. Lunev wrote: > This will allow to use this data as buffer to BAT update directly > without any intermediate buffers. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- &

Re: [Qemu-devel] [PATCH 14/27] block/parallels: create bat2sect helper

2015-03-10 Thread Roman Kagan
On Tue, Mar 10, 2015 at 11:51:08AM +0300, Denis V. Lunev wrote: > deduplicate copy/paste arithmetcs > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Kevin Wolf > CC: Stefan Hajnoczi > --- > block/parallels.c | 12 +--- > 1 file changed, 9

Re: [Qemu-devel] [PATCH v3] qga: add guest-set-user-password command

2015-02-12 Thread Roman Kagan
On Wed, Feb 11, 2015 at 11:26:12AM +, Daniel P. Berrange wrote: > Add a new 'guest-set-user-password' command for changing the password > of guest OS user accounts. This command is needed to enable OpenStack > to support its API for changing the admin password of guests running > on KVM/QEMU. I

Re: [Qemu-devel] [PATCH v2] qga: add guest-set-admin-password command

2015-02-04 Thread Roman Kagan
On Mon, Jan 12, 2015 at 03:58:14PM +, Daniel P. Berrange wrote: > Add a new 'guest-set-admin-password' command for changing the > root/administrator password. This command is needed to allow > OpenStack to support its API for changing the admin password > on a running guest. > > Accepts either

Re: [Qemu-devel] [PATCH 19/19] block/parallels: optimize linear image expansion

2015-01-14 Thread Roman Kagan
On Tue, Dec 30, 2014 at 01:07:12PM +0300, Denis V. Lunev wrote: > Plain image expansion spends a lot of time to update image file size. > This seriously affects the performance. The following simple test > qemu_img create -f parallels -o cluster_size=64k ./1.hds 64G > qemu_io -n -c "write -P 0x

Re: [Qemu-devel] [PATCH 18/19] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-01-14 Thread Roman Kagan
On Wed, Jan 14, 2015 at 05:31:20PM +0300, Denis V. Lunev wrote: > On 14/01/15 17:26, Roman Kagan wrote: > >On Tue, Dec 30, 2014 at 01:07:11PM +0300, Denis V. Lunev wrote: > >>This is preparational commit for tweaks in Parallels image expansion. > >>The idea is that enlar

Re: [Qemu-devel] [PATCH 18/19] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-01-14 Thread Roman Kagan
On Tue, Dec 30, 2014 at 01:07:11PM +0300, Denis V. Lunev wrote: > This is preparational commit for tweaks in Parallels image expansion. > The idea is that enlarge via truncate by one data block is slow. It > would be much better to use fallocate via bdrv_write_zeroes and > expand by some significan

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Roman Kagan
On Wed, Jan 14, 2015 at 04:08:50PM +0300, Denis V. Lunev wrote: > On 14/01/15 16:03, Roman Kagan wrote: > >On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: > >>+static int cache_bat(BlockDriverState *bs, uint32_t idx, uint32_t > >>new_data_off) >

Re: [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os

2015-01-14 Thread Roman Kagan
On Tue, Dec 30, 2014 at 01:07:10PM +0300, Denis V. Lunev wrote: > The idea is that we do not need to immediately sync BAT to the image as > from the guest point of view there is a possibility that IO is lost > even in the physical controller until flush command was finished. > bdrv_co_flush_to_os i

Re: [Qemu-devel] [PATCH 16/19] block/parallels: no need to flush on each block allocation table update

2015-01-14 Thread Roman Kagan
On Tue, Jan 13, 2015 at 11:16:04PM +0300, Denis V. Lunev wrote: > On 13/01/15 18:17, Denis V. Lunev wrote: > >On 13/01/15 17:50, Roman Kagan wrote: > >>On Tue, Dec 30, 2014 at 01:07:09PM +0300, Denis V. Lunev wrote: > >>>--- a/block/parallels.c > >>>+++

Re: [Qemu-devel] [PATCH 16/19] block/parallels: no need to flush on each block allocation table update

2015-01-13 Thread Roman Kagan
On Tue, Dec 30, 2014 at 01:07:09PM +0300, Denis V. Lunev wrote: > From the point of guest each write to real disk prior to disk barrier > operation could be lost. Therefore there is no problem that "not synced" > new block is lost due to not updated allocation table if QEMU is crashed. > > This pa

Re: [Qemu-devel] [PATCH 13/19] block/parallels: store ParallelsHeader to the BDRVParallelsState

2015-01-13 Thread Roman Kagan
tefan Hajnoczi > --- > block/parallels.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) Acked-by: Roman Kagan Roman.

Re: [Qemu-devel] [PATCH 15/19] block/parallels: rename catalog_ names to bat_

2015-01-13 Thread Roman Kagan
; --- > block/parallels.c | 48 > 1 file changed, 24 insertions(+), 24 deletions(-) Acked-by: Roman Kagan Roman.

Re: [Qemu-devel] [PATCH 14/19] block/parallels: create catalog_offset helper

2015-01-13 Thread Roman Kagan
c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) Acked-by: Roman Kagan Roman.

Re: [Qemu-devel] [PATCH 2/2] block: use fallocate(FALLOC_FL_PUNCH_HOLE) & fallocate(0) to write zeroes

2014-12-26 Thread Roman Kagan
On Thu, Dec 25, 2014 at 08:37:30AM +0300, Denis V. Lunev wrote: > This sequence works efficiently if FALLOC_FL_ZERO_RANGE is not supported. > The idea is that FALLOC_FL_PUNCH_HOLE could not increase file size > but it cleans already allocated blocks inside the file. If we have to > create something

Re: [Qemu-devel] [PATCH 1/2] block: use fallocate(FALLOC_FL_ZERO_RANGE) in handle_aiocb_write_zeroes

2014-12-26 Thread Roman Kagan
On Thu, Dec 25, 2014 at 08:37:29AM +0300, Denis V. Lunev wrote: > +#ifdef CONFIG_FALLOCATE_ZERO_RANGE > +do { > +if (fallocate(s->fd, CONFIG_FALLOCATE_ZERO_RANGE, Must be a typo, FALLOC_FL_ZERO_RANGE is what you mean. Roman.

Re: [Qemu-devel] [PATCH 11/16] block/parallels: add support for backing files

2014-12-15 Thread Roman Kagan
On Mon, Dec 15, 2014 at 01:30:03PM +0100, Kevin Wolf wrote: > Am 15.12.2014 um 09:27 hat Denis V. Lunev geschrieben: > > From: Roman Kagan > > > > Add backing file support to Parallels format driver. > > > > That said, I think backing file operations should end

<    2   3   4   5   6   7