Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Samuel Thibault
Vasiliy Tolstov, on Thu 31 Mar 2016 14:49:35 +0300, wrote: > Yes, i'm using older version of this patch and without working ipv6 on > host my vm tries to access network via ipv6 (prefered) and not able to > connect. I'm surprised that the vm tries to access the network via ipv6 by default. Which

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Samuel Thibault
Peter Maydell, on Thu 31 Mar 2016 12:30:24 +0100, wrote: > On 31 March 2016 at 10:20, Samuel Thibault > wrote: > > http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-2 > > > > for you to fetch changes up to c99751f2a711e9eecf60901520c6d4197bdaf9b4: &g

Re: [Qemu-devel] [PATCHv2 3/5] slirp: Add dns6 resolution

2016-03-31 Thread Samuel Thibault
Hello, Thanks for the reviews! Samuel

[Qemu-devel] [PULL 2/5] slirp: Split get_dns_addr

2016-03-31 Thread Samuel Thibault
Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/slirp.c | 53 ++--- 1 file changed, 34 insertions(+), 19 deletions

[Qemu-devel] [PULL 5/5] slirp: Add RDNSS advertisement

2016-03-31 Thread Samuel Thibault
This adds the RDNSS option to IPv6 router advertisements, so that the guest can autoconfigure the DNS server address. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6_icmp.c | 19 --- slirp/ip6_icmp.h | 12 ++-- 2 files changed, 26 insertions(+), 5

[Qemu-devel] [PULL 4/5] slirp: Support link-local DNS addresses

2016-03-31 Thread Samuel Thibault
They look like fe80::%eth0 Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index

[Qemu-devel] [PULL 3/5] slirp: Add dns6 resolution

2016-03-31 Thread Samuel Thibault
This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6.h | 9 +++ slirp/libslirp.h | 1 + slirp/slirp.c| 79 slirp

[Qemu-devel] [PULL 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-31 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- net/slirp.c | 36 ++-- qapi-schema.json | 8 qemu-options.hx | 8

[Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

2016-03-31 Thread Samuel Thibault
Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-2 for you to fetch changes up to c99751f2a711e9eecf60901520c6d4197bdaf9b4: slirp: Add RDNSS advertisement (2016-03

[Qemu-devel] [PULL] Fix ipv6 options according to documentation

2016-03-31 Thread Samuel Thibault
The options names were fixed in the qapi layer, but not in the command-line options. Signed-off-by: Samuel Thibault Reviewed-by: Eric Blake --- net/net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/net/net.c b/net/net.c index 3b5a142..594c3b8 100644 --- a

[Qemu-devel] [PULL] Fix ipv6 options according to documentation

2016-03-31 Thread Samuel Thibault
The following changes since commit 9370a3bbc478f623dd21d783560629ea2064625b: Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to

[Qemu-devel] [PULL] Fix ipv6 options according to documentation

2016-03-30 Thread Samuel Thibault
The options names were fixed in the qapi layer, but not in the command-line options. Signed-off-by: Samuel Thibault Reviewed-by: Eric Blake --- net/net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/net/net.c b/net/net.c index 3b5a142..594c3b8 100644 --- a

[Qemu-devel] [PATCHv2 3/5] slirp: Add dns6 resolution

2016-03-30 Thread Samuel Thibault
This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault --- Changes since v1: - code layout - cope with inet_ntop returning NULL - move static variables to function using them. --- slirp/ip6.h | 9 +++ slirp/libslirp.h | 1

[Qemu-devel] [PATCHv2 4/5] slirp: Support link-local DNS addresses

2016-03-30 Thread Samuel Thibault
They look like fe80::%eth0 Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index

[Qemu-devel] [PATCHv2 5/5] slirp: Add RDNSS advertisement

2016-03-30 Thread Samuel Thibault
This adds the RDNSS option to IPv6 router advertisements, so that the guest can autoconfigure the DNS server address. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6_icmp.c | 19 --- slirp/ip6_icmp.h | 12 ++-- 2 files changed, 26 insertions(+), 5

[Qemu-devel] [PATCHv2 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- Changes since previous versions: - fix coding style - explicit that qemu options can take ipv[46]=on|off --- net/slirp.c | 36

[Qemu-devel] [PATCHv2 2/5] slirp: Split get_dns_addr

2016-03-30 Thread Samuel Thibault
Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- Change since v1: remove superfluous parenthesis. --- slirp/slirp.c | 53

[Qemu-devel] [PATCHv2 0/5] ipv4-only and ipv6-only support

2016-03-30 Thread Samuel Thibault
static variables to function using them. - remove superfluous parenthesis. - fix coding style - explicit that qemu options can take ipv[46]=on|off Samuel Thibault (5): slirp: Allow disabling IPv4 or IPv6 slirp: Split get_dns_addr slirp: Add dns6 resolution slirp: Support link-local DNS addresses

[Qemu-devel] [PATCH] Fix ipv6 options according to documentation

2016-03-30 Thread Samuel Thibault
The options names were fixed in the qapi layer, but not in the command-line options. Signed-off-by: Samuel Thibault --- net/net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/net/net.c b/net/net.c index 3b5a142..594c3b8 100644 --- a/net/net.c +++ b/net

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Samuel Thibault
Thomas Huth, on Wed 30 Mar 2016 17:29:12 +0200, wrote: > On 30.03.2016 17:13, Samuel Thibault wrote: > > Thomas Huth, on Wed 30 Mar 2016 17:06:51 +0200, wrote: > >> The "restrict" option is listed with "=on|off" here, that's why I > >> thought

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Samuel Thibault
Thomas Huth, on Wed 30 Mar 2016 17:06:51 +0200, wrote: > The "restrict" option is listed with "=on|off" here, that's why I > thought it should be there for "ipv4" and "ipv6", too. Which boolean > options are missing the "=on|off" ? All the ipv4 and ipv6 options in the same file. Samuel

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Samuel Thibault
Hello, Thomas Huth, on Wed 30 Mar 2016 10:38:46 +0200, wrote: > > -"-netdev > > user,id=str[,net=addr[/mask]][,host=addr][,ipv6-net=addr[/int]]\n" > > -" > > [,ipv6-host=addr][,restrict=on|off][,hostname=host][,dhcpstart=addr]\n" > > +"-netdev user,id=str[,ipv4][,net=addr[/ma

Re: [Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-28 Thread Samuel Thibault
Eric Blake, on Mon 28 Mar 2016 09:12:04 -0600, wrote: > > +if ((user->has_ipv6 && user->ipv6 && !user->has_ipv4) > > +|| (user->has_ipv4 && !user->ipv4)) > > +ipv4 = 0; > > Inconsistent with current qemu style. Should be: > > if ((user->has_ipv6 && user->ipv6 && !user

[Qemu-devel] [PATCH 4/5] slirp: Support link-local DNS addresses

2016-03-28 Thread Samuel Thibault
They look like fe80::%eth0 Signed-off-by: Samuel Thibault --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index b0cfbc5..81bd139 100644

[Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-28 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- Changes since previous versions: - fix coding style --- net/slirp.c | 36 ++-- qapi-schema.json | 8 qemu

[Qemu-devel] [PATCH 3/5] slirp: Add dns6 resolution

2016-03-28 Thread Samuel Thibault
This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault --- slirp/ip6.h | 9 +++ slirp/libslirp.h | 1 + slirp/slirp.c| 72 slirp/socket.c | 4 ++-- 4 files

[Qemu-devel] [PATCH 0/5] ipv4-only and ipv6-only support

2016-03-28 Thread Samuel Thibault
Hello, This series gathers the patches to enable ipv4-only and ipv6-only support: it adds the discussed ipv4 and ipv6 options to select which is enabled, and adds support for ipv6 dns translation. Samuel Thibault (5): slirp: Allow disabling IPv4 or IPv6 slirp: Split get_dns_addr slirp: Add

[Qemu-devel] [PATCH 5/5] slirp: Add RDNSS advertisement

2016-03-28 Thread Samuel Thibault
This adds the RDNSS option to IPv6 router advertisements, so that the guest can autoconfigure the DNS server address. Signed-off-by: Samuel Thibault --- slirp/ip6_icmp.c | 19 --- slirp/ip6_icmp.h | 12 ++-- 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] [PATCH 2/5] slirp: Split get_dns_addr

2016-03-28 Thread Samuel Thibault
Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault --- slirp/slirp.c | 53 ++--- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/slirp

[Qemu-devel] [PULL 3/5] Avoid embedding struct mbuf in other structures

2016-03-28 Thread Samuel Thibault
appropriate. Signed-off-by: Samuel Thibault Reviewed-by: Peter Maydell --- slirp/if.c| 27 ++- slirp/mbuf.c | 19 ++- slirp/misc.c | 5 - slirp/misc.h | 5 + slirp/slirp.h | 8 +--- 5 files changed, 34 insertions(+), 30 deletions(-) diff

[Qemu-devel] [PULL 2/5] slirp: send icmp6 errors when UDP send failed

2016-03-28 Thread Samuel Thibault
Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/udp6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/slirp/udp6.c b/slirp/udp6.c index 60a91c9..a23026f 100644 --- a/slirp/udp6.c +++ b/slirp/udp6.c @@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m

[Qemu-devel] [PULL 0/5] slirp updates

2016-03-28 Thread Samuel Thibault
Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2016-03-21-tag' into staging (2016-03-22 17:39:48 +) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch cha

[Qemu-devel] [PULL 1/5] slirp: Fix memory leak on small incoming ipv4 packet

2016-03-28 Thread Samuel Thibault
Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 12f173d..b464f6b 100644 --- a/slirp/ip_input.c +++ b/slirp/ip_input.c @@ -85,7 +85,7 @@ ip_input(struct mbuf

[Qemu-devel] [PULL 4/5] Use C99 flexible array instead of 1-byte trailing array

2016-03-28 Thread Samuel Thibault
From: Peter Maydell Signed-off-by: Peter Maydell Signed-off-by: Samuel Thibault --- slirp/mbuf.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/slirp/mbuf.h b/slirp/mbuf.h index 38fedf4..36fb814 100644 --- a/slirp/mbuf.h +++ b/slirp/mbuf.h @@ -81,11 +81,9 @@ struct

[Qemu-devel] [PULL 5/5] Rework ipv6 options

2016-03-28 Thread Samuel Thibault
Rename the recently-added ip6-foo options into ipv6-foo options, to make them coherent with other ipv6 options. Also rework the documentation. Signed-off-by: Samuel Thibault Reviewed-by: Eric Blake --- net/net.c| 16 net/slirp.c | 6 +++--- qapi-schema.json | 25

[Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- Changes since previous versions: - Introduce boolean options ipv4 and ipv6 instead of net=none and ip6-net=none. - Reject incoherent configuration (e.g

[Qemu-devel] [PATCHv4 1/2] Rework ipv6 options

2016-03-24 Thread Samuel Thibault
Rename the recently-added ip6-foo options into ipv6-foo options, to make them coherent with other ipv6 options. Also rework the documentation. Signed-off-by: Samuel Thibault --- net/slirp.c | 6 +++--- qapi-schema.json | 25 - qemu-options.hx | 18

[Qemu-devel] [PATCHv4 0/2] Rework ipv6 options, add ipv4/ipv6 enabling/disabling options

2016-03-24 Thread Samuel Thibault
This is a split of the previously-sent "Allow disabling IPv4 or IPv6" patch, to separate reworking the existing newly-added options and the new ipv4/ipv6 options. Samuel Thibault (2): Rework ipv6 options slirp: Allow disabling IPv4 or IPv6 net/slirp.c

Re: [Qemu-devel] [PATCHv3 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Samuel Thibault, on Fri 25 Mar 2016 00:25:55 +0100, wrote: > Also rename recently-added options to make the whole coherent before 2.6 > gets released. GRaaAH I'm so motivated by such bike-shedding changes that I forgot to rework the changelog. Let me do that yet again. Samuel

[Qemu-devel] [PATCHv3 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Also rename recently-added options to make the whole coherent before 2.6 gets released. Signed-off-by: Samuel Thibault --- Changes since previous versions: - Introduce boolean options ipv4

[Qemu-devel] [PATCHv3 1/2] Rework ipv6 options

2016-03-24 Thread Samuel Thibault
Rename ip6-foo options into ipv6-foo options, to make them coherent with other ipv6 options. Also rework the documentation. --- net/slirp.c | 6 +++--- qapi-schema.json | 25 - qemu-options.hx | 18 ++ 3 files changed, 29 insertions(+), 20 deletions(

[Qemu-devel] [PATCHv3 0/2] Rework ipv6 options, add ipv4/ipv6 enabling/disabling options

2016-03-24 Thread Samuel Thibault
This is a split of the previously-sent "Allow disabling IPv4 or IPv6" patch, to separate reworking the existing newly-added options and the new ipv4/ipv6 options. Samuel Thibault (2): Rework ipv6 options slirp: Allow disabling IPv4 or IPv6 net/slirp.c

[Qemu-devel] [PATCHv2] slirp: Allow disabling IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- Changes since previous versions: - Introduce boolean options ipv4 and ipv6 instead of net=none and ip6-net=none. - Rename ipv6 options to ipv6-foo

Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Hello, Eric Blake, on Thu 24 Mar 2016 15:36:19 -0600, wrote: > What happens if 'net' is provided but 'ip4' is false? Is that a user error? We could do that, yes. > The existing 'InetSocketAddress' QAPI type spells these as 'ipv4' and > ipv6'; should we use the same spelling for consistency? Th

Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Eric Blake, on Thu 24 Mar 2016 15:36:19 -0600, wrote: > > Make net=none disable IPv4 and ip6-net=none disable IPv6, so the user can > > setup IPv4-only and IPv6-only network environments. > > This mentions 'net=none', but I don't see that in the patch below; > instead I see a new boolean. Eeergl,

Re: [Qemu-devel] [PATCH 0/4] slirp: Add dns6 support

2016-03-24 Thread Samuel Thibault
Hello, Could somebody review this? This will be needed for ipv6-only setups. Samuel Samuel Thibault, on Sun 20 Mar 2016 16:26:24 +0100, wrote: > This adds support for DNS over IPv6 in slirp, which is notably useful when the > host has only an IPv6 DNS server. > > This series depen

[Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Make net=none disable IPv4 and ip6-net=none disable IPv6, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- net/slirp.c | 19 +-- qapi-schema.json | 15 +-- qemu-options.hx | 19 --- slirp

Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe

2016-03-23 Thread Samuel Thibault
Peter Maydell, on Wed 23 Mar 2016 12:43:44 +, wrote: > On 23 March 2016 at 00:05, Samuel Thibault wrote: > > Peter Maydell, on Fri 19 Feb 2016 12:09:17 +, wrote: > >> diff --git a/slirp/mbuf.h b/slirp/mbuf.h > >> index 38fedf4..ef5a4f7 100644 > >>

Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe

2016-03-22 Thread Samuel Thibault
Hello Peter, Peter Maydell, on Fri 19 Feb 2016 12:09:17 +, wrote: > diff --git a/slirp/mbuf.h b/slirp/mbuf.h > index 38fedf4..ef5a4f7 100644 > --- a/slirp/mbuf.h > +++ b/slirp/mbuf.h > @@ -81,11 +81,9 @@ struct mbuf { > Slirp *slirp; > boolresolution_requested; > ui

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-22 Thread Samuel Thibault
Hello, Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > > -# @net: #optional IP address and optional netmask > > +# @net: #optional IP address and optional netmask. Set to 0.0.0.0 to > > disable IPv4 completely > > Long line. > > Syntax? Default value? Something like this? # @n

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-21 Thread Samuel Thibault
Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > Samuel Thibault writes: > > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can > > setup IPv4-only and IPv6-only network environments. > > Do "net=" and "ip6-net=" mea

Re: [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

2016-03-21 Thread Samuel Thibault
Hello, Peter Maydell, on Mon 21 Mar 2016 09:48:48 +, wrote: > Generally the > process for QEMU is that first patches are sent as normal [PATCH] mails, > for code review. Patches should only be put into pull requests once > they've been through the review process. (And then you can batch them >

[Qemu-devel] [PATCH] slirp: send icmp6 errors when UDP send failed

2016-03-21 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/udp6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/slirp/udp6.c b/slirp/udp6.c index 60a91c9..a23026f 100644 --- a/slirp/udp6.c +++ b/slirp/udp6.c @@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m) m->m_data -= iph

[Qemu-devel] [PATCH] slirp: Fix memory leak on small incoming ipv4 packet

2016-03-21 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 12f173d..b464f6b 100644 --- a/slirp/ip_input.c +++ b/slirp/ip_input.c @@ -85,7 +85,7 @@ ip_input(struct mbuf *m) DEBUG_ARG

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-21 Thread Samuel Thibault
Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > > +either in the form a.b.c.d or as number of valid top-most bits. Set to > > 0.0.0.0 > > +to disable IPv4 completely. Default is 10.0.2.0/24. > > Long line. How long is too long? This is 78 characters, and I see plenty of lines beyo

[Qemu-devel] [PATCH 2/4] slirp: Add dns6 resolution

2016-03-20 Thread Samuel Thibault
This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault --- slirp/libslirp.h | 1 + slirp/slirp.c| 72 slirp/socket.c | 4 ++-- 3 files changed, 55 insertions(+), 22

[Qemu-devel] [PATCH 1/4] slirp: Split get_dns_addr

2016-03-20 Thread Samuel Thibault
Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault --- slirp/slirp.c | 53 ++--- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/slirp

[Qemu-devel] [PATCH 4/4] slirp: Add RDNSS advertisement

2016-03-20 Thread Samuel Thibault
This adds the RDNSS option to IPv6 router advertisements, so that the guest can autoconfigure the DNS server address. Signed-off-by: Samuel Thibault --- slirp/ip6_icmp.c | 19 --- slirp/ip6_icmp.h | 12 ++-- 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] [PATCH 3/4] slirp: Support link-local DNS addresses

2016-03-20 Thread Samuel Thibault
They look like fe80::%eth0 Signed-off-by: Samuel Thibault --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index eea9be4..bf3a420 100644

[Qemu-devel] [PATCH 0/4] slirp: Add dns6 support

2016-03-20 Thread Samuel Thibault
This adds support for DNS over IPv6 in slirp, which is notably useful when the host has only an IPv6 DNS server. This series depends on "slirp: Allow to disable IPv4 or IPv6" which defines in6_zero. Samuel Thibault (4): slirp: Split get_dns_addr slirp: Add dns6 resolution slir

Re: [Qemu-devel] [PATCH 2/3] slirp: Add dns6 resolution

2016-03-20 Thread Samuel Thibault
Samuel Thibault, on Sun 20 Mar 2016 15:45:25 +0100, wrote: > -*pdns_addr = dns_addr; > +memcpy(pdns_addr, &cached_addr, addrlen); Oops, sorry, it should have been > +memcpy(pdns_addr, cached_addr, addrlen); In my tests I had forgotten to try resolving m

[Qemu-devel] [PATCH 2/3] slirp: Add dns6 resolution

2016-03-20 Thread Samuel Thibault
This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault --- slirp/libslirp.h | 1 + slirp/slirp.c| 72 slirp/socket.c | 4 ++-- 3 files changed, 55 insertions(+), 22

[Qemu-devel] [PATCH 0/3] Add dns6 support

2016-03-20 Thread Samuel Thibault
This adds support for DNS over IPv6 in slirp, which is notably useful when the host has only an IPv6 DNS server. Samuel Thibault (3): slirp: Split get_dns_addr slirp: Add dns6 resolution slirp: Support link-local DNS addresses slirp/libslirp.h | 1 + slirp/slirp.c| 117

[Qemu-devel] [PATCH 1/3] slirp: Split get_dns_addr

2016-03-20 Thread Samuel Thibault
Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault --- slirp/slirp.c | 53 ++--- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/slirp

[Qemu-devel] [PATCH 3/3] slirp: Support link-local DNS addresses

2016-03-20 Thread Samuel Thibault
They look like fe80::%eth0 Signed-off-by: Samuel Thibault --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index eea9be4..bf3a420 100644

[Qemu-devel] [PULL] slirp: send icmp6 errors when UDP send failed

2016-03-20 Thread Samuel Thibault
end failed -------- Samuel Thibault (1): slirp: send icmp6 errors when UDP send failed slirp/udp6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[Qemu-devel] [PULL] slirp: send icmp6 errors when UDP send failed

2016-03-20 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/udp6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/slirp/udp6.c b/slirp/udp6.c index 60a91c9..a23026f 100644 --- a/slirp/udp6.c +++ b/slirp/udp6.c @@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m) m->m_data -= iph

[Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

2016-03-20 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 12f173d..b464f6b 100644 --- a/slirp/ip_input.c +++ b/slirp/ip_input.c @@ -85,7 +85,7 @@ ip_input(struct mbuf *m) DEBUG_ARG

Re: [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

2016-03-20 Thread Samuel Thibault
Ah, sorry, that didn't include the cover letter with the branch to pull from. I have resent the pull request. Samuel

[Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

2016-03-20 Thread Samuel Thibault
pv4 packet -------- Samuel Thibault (1): slirp: Fix memory leak on small incoming ipv4 packet slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-20 Thread Samuel Thibault
Samuel Thibault, on Sun 20 Mar 2016 12:39:14 +0100, wrote: > void icmp6_init(Slirp *slirp) > { > +if (in6_zero(&slirp->vprefix_addr6)) { > +/* IPv6 is disabled */ > +return; > +} > + (Note: vprefix_addr6 is not actually initialized yet at tha

[Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-20 Thread Samuel Thibault
Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- net/slirp.c | 8 +--- qapi-schema.json | 4 ++-- qemu-options.hx | 7 --- slirp/ip6.h | 9 + slirp

[Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

2016-03-20 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 12f173d..b464f6b 100644 --- a/slirp/ip_input.c +++ b/slirp/ip_input.c @@ -85,7 +85,7 @@ ip_input(struct mbuf *m) DEBUG_ARG

[Qemu-devel] [PULL 06/11] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2016-03-15 Thread Samuel Thibault
h does not include the entailed reindentation, to make proofread easier. Reindentation is adressed in the following no-op patch. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip_input.c | 2 +- slirp/slirp.c | 6 +++-- slirp/slirp.h

[Qemu-devel] [PULL 03/11] slirp: Adding ICMPv6 error sending

2016-03-15 Thread Samuel Thibault
: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6_icmp.c | 66 +++ slirp/ip6_icmp.h | 10 + slirp/ip6_input.c | 11 +++--- 3 files changed, 84 insertions(+), 3 deletions(-) diff --git a/slirp/ip6_icmp.c b/slirp/ip6_icmp.c index

[Qemu-devel] [PULL 05/11] slirp: Factorizing tcpiphdr structure with an union

2016-03-15 Thread Samuel Thibault
functions, and makes them compatible with the new tcpiphdr structure, whose size will be bigger than sizeof(struct tcphdr) + sizeof(struct ip) Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/if.h | 4 ++-- slirp/mbuf.c | 4

[Qemu-devel] [PULL 01/11] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2016-03-15 Thread Samuel Thibault
refresh its route. This also adds ip6_cksum() to compute ICMPv6 checksums using IPv6 pseudo-header. Some #define ETH_* are moved upper in slirp.h to make them accessible to other slirp/*.h Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp

[Qemu-devel] [PULL 04/11] slirp: Adding IPv6 UDP support

2016-03-15 Thread Samuel Thibault
From: Guillaume Subiron This adds the sin6 case in the fhost and lhost unions and related macros. It adds udp6_input() and udp6_output(). It adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault

[Qemu-devel] [PULL 02/11] slirp: Fix ICMP error sending

2016-03-15 Thread Samuel Thibault
From: Yann Bordenave Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Signed-off-by: Yann Bordenave Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6_input.c | 2 +- slirp/ip_icmp.c

[Qemu-devel] [PULL 07/11] slirp: Reindent after refactoring

2016-03-15 Thread Samuel Thibault
From: Guillaume Subiron No code change. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/tcp_input.c | 104 ++--- slirp/tcp_output.c | 29 --- slirp/tcp_subr.c | 50

[Qemu-devel] [PULL 09/11] slirp: Adding IPv6 address for DNS relay

2016-03-15 Thread Samuel Thibault
points to localhost. Further development will be needed to automatically fetch the IPv6 address from resolv.conf, and announce this via RDNSS. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6.h| 6 +- slirp/slirp.c | 3 +++ slirp

[Qemu-devel] [PULL 11/11] slirp: Add IPv6 support to the TFTP code

2016-03-15 Thread Samuel Thibault
From: Thomas Huth Add the handler code for incoming TFTP packets to udp6_input(), and make sure that the TFTP code can send packets with both, udp_output() and udp6_output() by introducing a wrapper function called tftp_udp_output(). Signed-off-by: Thomas Huth Signed-off-by: Samuel Thibault

[Qemu-devel] [PULL 10/11] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-03-15 Thread Samuel Thibault
Bordenave Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- net/net.c| 31 ++ net/slirp.c | 81 +++- qapi-schema.json | 12 + qemu-options.hx | 18 +++-- slirp/libslirp.h | 8

[Qemu-devel] [PULL 08/11] slirp: Handle IPv6 in TCP functions

2016-03-15 Thread Samuel Thibault
From: Guillaume Subiron This patch adds IPv6 case in TCP functions refactored by the last patches. This also adds IPv6 pseudo-header in tcpiphdr structure. Finally, tcp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth

[Qemu-devel] [PULL 00/11] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-15 Thread Samuel Thibault
The following changes since commit 618a5a8bc52ba0f2ecbb3dffd01e657f4d841f75: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2016-03-14 16:22:17 +) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git t

Re: [Qemu-devel] [PATCHv10 0/11] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-15 Thread Samuel Thibault
Jason Wang, on Tue 15 Mar 2016 11:28:55 +0800, wrote: > Looks good to me. Since you are the maintainer, do you want to merge and > send pull request yourself? I have done so, thanks. Samuel

[Qemu-devel] [PULL 01/11] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2016-03-15 Thread Samuel Thibault
refresh its route. This also adds ip6_cksum() to compute ICMPv6 checksums using IPv6 pseudo-header. Some #define ETH_* are moved upper in slirp.h to make them accessible to other slirp/*.h Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp

[Qemu-devel] [PULL 03/11] slirp: Adding ICMPv6 error sending

2016-03-15 Thread Samuel Thibault
: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6_icmp.c | 66 +++ slirp/ip6_icmp.h | 10 + slirp/ip6_input.c | 11 +++--- 3 files changed, 84 insertions(+), 3 deletions(-) diff --git a/slirp/ip6_icmp.c b/slirp/ip6_icmp.c index

[Qemu-devel] [PULL 10/11] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-03-15 Thread Samuel Thibault
Bordenave Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- net/net.c| 31 ++ net/slirp.c | 81 +++- qapi-schema.json | 12 + qemu-options.hx | 18 +++-- slirp/libslirp.h | 8

[Qemu-devel] [PULL 08/11] slirp: Handle IPv6 in TCP functions

2016-03-15 Thread Samuel Thibault
From: Guillaume Subiron This patch adds IPv6 case in TCP functions refactored by the last patches. This also adds IPv6 pseudo-header in tcpiphdr structure. Finally, tcp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth

[Qemu-devel] [PULL 06/11] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2016-03-15 Thread Samuel Thibault
h does not include the entailed reindentation, to make proofread easier. Reindentation is adressed in the following no-op patch. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip_input.c | 2 +- slirp/slirp.c | 6 +++-- slirp/slirp.h

[Qemu-devel] [PULL 04/11] slirp: Adding IPv6 UDP support

2016-03-15 Thread Samuel Thibault
From: Guillaume Subiron This adds the sin6 case in the fhost and lhost unions and related macros. It adds udp6_input() and udp6_output(). It adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault

[Qemu-devel] [PULL 05/11] slirp: Factorizing tcpiphdr structure with an union

2016-03-15 Thread Samuel Thibault
functions, and makes them compatible with the new tcpiphdr structure, whose size will be bigger than sizeof(struct tcphdr) + sizeof(struct ip) Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/if.h | 4 ++-- slirp/mbuf.c | 4

[Qemu-devel] [PULL 07/11] slirp: Reindent after refactoring

2016-03-15 Thread Samuel Thibault
From: Guillaume Subiron No code change. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/tcp_input.c | 104 ++--- slirp/tcp_output.c | 29 --- slirp/tcp_subr.c | 50

[Qemu-devel] [PULL 11/11] slirp: Add IPv6 support to the TFTP code

2016-03-15 Thread Samuel Thibault
From: Thomas Huth Add the handler code for incoming TFTP packets to udp6_input(), and make sure that the TFTP code can send packets with both, udp_output() and udp6_output() by introducing a wrapper function called tftp_udp_output(). Signed-off-by: Thomas Huth Reviewed-by: Samuel Thibault

[Qemu-devel] [PULL 00/11] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-15 Thread Samuel Thibault
ags/samuel-thibault for you to fetch changes up to 79740b2b3ec4ce07c91c0f3349b1cc28eba5cd08: slirp: Add IPv6 support to the TFTP code (2016-03-15 10:35:28 +0100) ---- Add Samuel Thibault as slirp

[Qemu-devel] [PULL 02/11] slirp: Fix ICMP error sending

2016-03-15 Thread Samuel Thibault
From: Yann Bordenave Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Signed-off-by: Yann Bordenave Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6_input.c | 2 +- slirp/ip_icmp.c

[Qemu-devel] [PULL 09/11] slirp: Adding IPv6 address for DNS relay

2016-03-15 Thread Samuel Thibault
points to localhost. Further development will be needed to automatically fetch the IPv6 address from resolv.conf, and announce this via RDNSS. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6.h| 6 +- slirp/slirp.c | 3 +++ slirp

[Qemu-devel] [PULL] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2016-03-08 Thread Samuel Thibault
ags/samuel-thibault for you to fetch changes up to eda509fa0ac7d4870b7ff206fd6c33cdd06c2d55: MAINTAINERS: Add Samuel Thibault as slirp maintainer (2016-03-08 21:39:04 +0100) ---- Add Samuel Thibault as slirp

Re: [Qemu-devel] [PULL] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2016-03-08 Thread Samuel Thibault
Peter Maydell, on Wed 09 Mar 2016 07:20:44 +0700, wrote: > Shouldn't there be some Acked-by: lines on this? Right, sent again. Samuel

<    7   8   9   10   11   12   13   14   15   16   >