Re: [Qemu-devel] [PATCH] sam460ex: Fix PCI interrupts with multiple devices

2018-07-31 Thread Sebastian Bauer
c0ec0, uic[1][0]); pci_bus = (PCIBus *)qdev_get_child_bus(dev, "pci.0"); if (!pci_bus) { error_report("couldn't create PCI controller!"); I'm fine with that change. I tested it with an additional OHCI controller on an emulated SAM machine under guest Amig

Re: [Qemu-devel] [PATCH] sam460ex: Fix PCI interrupt connections

2018-07-31 Thread Sebastian Bauer
Hi, Am 2018-07-31 11:50, schrieb BALATON Zoltan: On Tue, 31 Jul 2018, Sebastian Bauer wrote: There is also the possibility to make the special (num-irqs == 1) the common case, as the Sam460ex platform is the only user of this bus so far (and probably stays the only one). I'm not sure

Re: [Qemu-devel] [PATCH] sam460ex: Fix PCI interrupt connections

2018-07-30 Thread Sebastian Bauer
Am 2018-07-31 01:15, schrieb Peter Maydell: It would work. But creating an OR gate is half a dozen lines or so of code, so it's not much more work than changing the PCI controller. So we should prefer whichever is closest to what the real hardware does, assuming we can determine that. The real

Re: [Qemu-devel] [PATCH] sam460ex: Fix PCI interrupt connections

2018-07-30 Thread Sebastian Bauer
Am 2018-07-31 02:18, schrieb David Gibson: David, can you please drop this patch, we'll come up with a different fix. Done. Should have looked at that patch a bit closer. I created a follow up patch, unfortunately, based on the previous patch, as I did not spot your mail earlier than now.

[Qemu-devel] [PATCH 2/2] sam460ex: Create the PCI-X bus with only one interrupt

2018-07-30 Thread Sebastian Bauer
, in particular that the logical level of the destination pin is an combined or of all the individual interrupt levels. Signed-off-by: Sebastian Bauer --- hw/ppc/sam460ex.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c index

[Qemu-devel] [PATCH 1/2] ppc: Allow clients of the 440 pcix bus to specify the number of interrupts

2018-07-30 Thread Sebastian Bauer
the special case was actually created). Signed-off-by: Sebastian Bauer --- hw/ppc/ppc440_pcix.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c index d8af04b70f..cb7d7cfd2b 100644 --- a/hw/ppc

[Qemu-devel] [PATCH 0/2] sam460ex: Improve logicial or'ed PCI-X interrupts

2018-07-30 Thread Sebastian Bauer
property. Tested on the SAM460ex machine (which admittely is the only user so far). Sebastian Bauer (2): ppc: Allow clients of the 440 pcix bus to specify the number of interrupts sam460ex: Create the PCI-X bus with only one interrupt hw/ppc/ppc440_pcix.c | 28

Re: [Qemu-devel] [PATCH] sam460ex: Fix PCI interrupt connections

2018-07-30 Thread Sebastian Bauer
Am 2018-07-30 13:06, schrieb BALATON Zoltan: On Mon, 30 Jul 2018, Sebastian Bauer wrote: The four interrupts of the PCI bus are connected to the same UIC pin on the real Sam460ex. Evidence for this can be found in the UBoot source for the Sam460ex in the Sam460ex.c file where

[Qemu-devel] [PATCH] sam460ex: Fix PCI interrupt connections

2018-07-29 Thread Sebastian Bauer
that can be observed when adding further PCI cards that get their interrupt rotated to other interrupts than PCI INT A. In particular, the bug was observed and verified to be fixed (after this change) with an additional OHCI PCI card. Signed-off-by: Sebastian Bauer --- hw/ppc/sam460ex.c | 4 ++-- 1

[Qemu-devel] [PATCH] ohci: Clear the interrupt counter for erroneous transfers

2018-07-29 Thread Sebastian Bauer
would be useless. Note that Linux drivers that I looked at don't seem to be affected as they set six as the interrupt delay presumably for the reason that they won't get notified otherwise. Signed-off-by: Sebastian Bauer --- hw/usb/hcd-ohci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Qemu-devel] hw/display/sm501* status

2018-07-18 Thread Sebastian Bauer
Hi, Am 2018-07-18 04:30, schrieb David Gibson: On Mon, Jul 16, 2018 at 09:43:05PM +0100, Peter Maydell wrote: On 16 July 2018 at 21:26, BALATON Zoltan wrote: > I could list sm501 in the sam460ex section thus formally taking > sub-maintainership but this would only go as far that I'll get cc-d

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-12 Thread Sebastian Bauer
Hi, Am 2018-07-12 06:57, schrieb Thomas Huth: This is doable too, if we have a clear consensus on what would be a reasonable default on TYPE_MACHINE. Personally I prefer the default on TYPE_MACHINE to be "none". Yes, please, no magic default hardware for all machines. That will only cause

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-11 Thread Sebastian Bauer
Am 2018-07-11 17:48, schrieb Eduardo Habkost: "none" looked like a false positive when I first looked, but now I think it's not. Shouldn't it set default_display="none"? I think that there is some other logic burried that these machine doesn't get a graphics display. But overall it is indeed

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-09 Thread Sebastian Bauer
Hi, Am 2018-07-09 23:23, schrieb Eduardo Habkost: List of machines with default_display==NULL on those architectures: alpha: none empty machine mips: mipssim MIPS MIPSsim platform none empty machine ppc*: bamboo bamboo mpc8544ds

Re: [Qemu-devel] [PATCH] vga: make stdvga the global default

2018-07-04 Thread Sebastian Bauer
Am 2018-07-04 23:04, schrieb Eduardo Habkost: On Wed, Jul 04, 2018 at 05:52:06PM -0300, Eduardo Habkost wrote: On Wed, Jul 04, 2018 at 10:21:19PM +0200, Sebastian Bauer wrote: > Am 2018-07-04 20:53, schrieb Eduardo Habkost: > > > mc->kvm_type =

Re: [Qemu-devel] [PATCH] vga: make stdvga the global default

2018-07-04 Thread Sebastian Bauer
Am 2018-07-04 20:53, schrieb Eduardo Habkost: mc->kvm_type = spapr_kvm_type; machine_class_allow_dynamic_sysbus_dev(mc, TYPE_SPAPR_PCI_HOST_BRIDGE); mc->pci_allow_0_address = true; diff --git a/vl.c b/vl.c index 16b913f9d5..e60bf2d6cd 100644 --- a/vl.c +++ b/vl.c @@ -4475,10

Re: [Qemu-devel] [PATCH] vga: make stdvga the global default

2018-07-04 Thread Sebastian Bauer
913f9d5..e60bf2d6cd 100644 --- a/vl.c +++ b/vl.c @@ -4475,10 +4475,10 @@ int main(int argc, char **argv, char **envp) if (default_vga) { if (machine_class->default_display) { vga_model = machine_class->default_display; - } else if (vga_interface_available(VGA_CIRRUS)) { -

[Qemu-devel] [PATCH v3 5/7] sm501: Log unimplemented raster operation modes

2018-07-04 Thread Sebastian Bauer
The sm501 currently implements only a very limited set of raster operation modes. After this change, unknown raster operation modes are logged so these can be easily spotted. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 23 +++ 1 file changed, 23 insertions(+)

[Qemu-devel] [PATCH v3 3/7] sm501: Use values from the pitch register for 2D operations

2018-07-04 Thread Sebastian Bauer
Before, crt_h_total was used for src_width and dst_width. This is a property of the current display setting and not relevant for the 2D operation that also can be done off-screen. The pitch register's purpose is to describe line pitch relevant of the 2D operation. Signed-off-by: Sebastian Bauer

[Qemu-devel] [PATCH v3 4/7] sm501: Implement negated destination raster operation mode

2018-07-04 Thread Sebastian Bauer
Add support for the negated destination operation mode. This is used e.g. by AmigaOS for the INVERSEVID drawing mode. With this change, the cursor in the shell and non-immediate window adjustment are working now. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 12 +++- 1 file

[Qemu-devel] [PATCH v3 2/7] sm501: Perform a full update after palette change

2018-07-04 Thread Sebastian Bauer
From: Sebastian Bauer Changing the palette of a color index has as an immediate effect on all pixels with the corresponding index on real hardware. Performing a full update after a palette change is a simple way to emulate this effect. Signed-off-by: Sebastian Bauer Signed-off-by: BALATON

Re: [Qemu-devel] [PULL 35/35] ppc: Include vga cirrus card into the compiling process

2018-07-04 Thread Sebastian Bauer
Hi, Am 2018-07-04 07:56, schrieb Mark Cave-Ayland: Right, but as the patch submitter it's your responsibility to ensure that your patch doesn't break other people's machines and/or follow up with the appropriate patches. If you're not willing to do that then we should revert the patch in its

Re: [Qemu-devel] [PULL 35/35] ppc: Include vga cirrus card into the compiling process

2018-07-03 Thread Sebastian Bauer
Am 2018-07-04 06:50, schrieb Mark Cave-Ayland: Either to give up the vga cirrus preference or to apply the same as was done with the spapr machine. I would prefer the first variant but it would also cause some differences on other machines. I understand that the decision was taken to add VGA

Re: [Qemu-devel] [PULL 35/35] ppc: Include vga cirrus card into the compiling process

2018-07-03 Thread Sebastian Bauer
Am 2018-07-03 21:00, schrieb Mark Cave-Ayland: On 03/07/18 06:58, David Gibson wrote: From: Sebastian Bauer Drivers for this card exists on PPC-based AmigaOS guests so it is useful to allow users to emulate the graphics card for PPC machines. As cirrus vga is currently preferred over std

[Qemu-devel] [PATCH v2] ppc: Include vga cirrus card into the compiling process

2018-07-02 Thread Sebastian Bauer
qemu refuses to start these machines. Not specifying an explicit graphics mode is for instance done by 'make check'. Signed-off-by: Sebastian Bauer --- v2 Adds std as default display for spapr machines Notes This change will make all other ppc machines to use cirrusgd as default display because

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-07-02 Thread Sebastian Bauer
Am 2018-07-02 07:22, schrieb David Gibson: And now unapplied, since it breaks make check all over the place for ppc64-softmmu. Please folks, running an all-targets make check is really the *minimum* bar for testing before posting a patch for inclusion. Okay, will do next time. Sorry for the

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-29 Thread Sebastian Bauer
Hi, Am 2018-06-19 06:36, schrieb David Gibson: Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. It looks like you've made it against a tree including some of BALATON Zoltan's proposed but not yet merged patches. Please make sure your patches are against the current

[Qemu-devel] [RFC] ppc/tcg: send cpu to sleep for simple endless guest loops

2018-06-28 Thread Sebastian Bauer
this endless loop (e.g., AmigaOS) is that they no longer hog the cpu of the host if they are idle. Signed-off-by: Sebastian Bauer --- This is a RFC because I'm not really familiar with the internals of QEMU. There are probably other (better) ways to achive a similar behaviour. For that reason I haven't

[Qemu-devel] [PATCH] ehci: Don't fetch a NULL current qtd but advance the queue instead.

2018-06-25 Thread Sebastian Bauer
PCI cards but e.g., not with the Freescale USB controller's found on the P5040. On the emulated EHCI controller of QEMU the consequence is that some garbage was read in, which resulted in a reset of the controller. This change fixes the problem. Signed-off-by: Sebastian Bauer --- The fix i

Re: [Qemu-devel] [PATCH 2/5] sm501: Perform a full update after palette change

2018-06-22 Thread Sebastian Bauer
Am 2018-06-22 03:34, schrieb Philippe Mathieu-Daudé: On 06/21/2018 05:08 AM, BALATON Zoltan wrote: From: Sebastian Bauer Changing the palette of a color index has as an immediate effect on all pixels with the corresponding index on real hardware. Performing a full update after a palette

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-19 Thread Sebastian Bauer
Hello David, Am 2018-06-19 06:36, schrieb David Gibson: Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. It looks like you've made it against a tree including some of BALATON Zoltan's proposed but not yet merged patches. Please make sure your patches are against the current

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-19 Thread Sebastian Bauer
Am 2018-06-19 12:23, schrieb BALATON Zoltan: On Tue, 19 Jun 2018, David Gibson wrote: Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. It looks like you've made it against a tree including some of BALATON Zoltan's proposed but not yet merged patches. I've sent those patches

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-18 Thread Sebastian Bauer
Am 2018-06-19 01:55, schrieb David Gibson: Have you checked the Cirrus VGA actually works on a ppc machine? Yes, it works for AmigaOS guests. Better than the sm501 for instance. Bye Sebastian

[Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-18 Thread Sebastian Bauer
Drivers for this card exists on PPC-based AmigaOS guests so it is useful to allow users to emulate the graphics card for PPC machines. Signed-off-by: Sebastian Bauer --- default-configs/ppc-softmmu.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/default-configs/ppc-softmmu.mak b/default

[Qemu-devel] [PATCH] sm501: Fix hardware cursor color conversion

2018-06-18 Thread Sebastian Bauer
. This change fixes this issue by replacing the existing naive bgr565 => rgb888 conversion with a standard rgb565 => rgb888 one that also scales the color component values properly. Signed-off-by: Sebastian Bauer --- hw/display/sm501.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 2/2] Respond a set address command with CC_PARAMETER_ERROR, if the speed field of the input context is not valid.

2012-10-26 Thread Sebastian Bauer
--- hw/usb/hcd-xhci.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 4c81dcc..b556b6e 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1841,6 +1841,7 @@ static TRBCCode xhci_address_slot(XHCIState *xhci, unsigned int

[Qemu-devel] [PATCH 0/2] xhci: Better spec conforming behaviour

2012-10-26 Thread Sebastian Bauer
context associated to a set address command. See 6.2.2.1 of the xhci spec. Sebastian Bauer (2): When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached. Respond a set address command with CC_PARAMETER_ERROR, if the speed

[Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached.

2012-10-26 Thread Sebastian Bauer
--- hw/usb/hcd-xhci.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 37b3dbb..4c81dcc 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -990,10 +990,29 @@ static void xhci_er_reset(XHCIState

Re: [Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached.

2012-10-26 Thread Sebastian Bauer
Hi! Am 26.10.2012 14:00, schrieb Gerd Hoffmann: Wrong fix I think. Just moving port-portsc |= PORTSC_CSC out of the if (running) should do. usb-next already has a patch which fixes this: I'm not sure about that. According to the spec, when the hc is set to running mode (p.70) At this

[Qemu-devel] [PATCH v2] xhci: check speed field of the input context of a set address command.

2012-10-26 Thread Sebastian Bauer
If the supplied speed data doesn't match the device speed, return CC_PARAMETER_ERROR. See 6.2.2.1 of the xhci spec. Signed-off-by: Sebastian Bauer m...@sebastianbauer.info --- Changes v1-v2: Added description to the patch hw/usb/hcd-xhci.c | 10 ++ 1 file changed, 10 insertions

Re: [Qemu-devel] [PATCH] PPC: Fix for the gdb single step problem on an rfi instruction

2011-09-14 Thread Sebastian Bauer
, Sebastian Bauer wrote: When using gdb to single step a ppc interrupt routine, the execution flow passes the rfi instruction without actually returning from the interrupt. The patch fixes this by avoiding to update the nip when the debug exception is raised and a previous POWERPC_EXCP_SYNC was set

[Qemu-devel] [PATCH] PPC: Fix for the gdb single step problem on an rfi instruction

2011-08-10 Thread Sebastian Bauer
is the case only, if code for rfi or a related instruction was generated. Signed-off-by: Sebastian Bauer m...@sebastianbauer.info --- diff --git a/target-ppc/translate.c b/target-ppc/translate.c index fd7c208..42b91fd 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -287,7 +287,7