Re: [Qemu-devel] [PATCH 1/2 v4] Support for multiple keyboard devices

2011-04-29 Thread Shahar Havivi
Fine with me On Apr 29, 2011, at 19:24, Dmitry Zhurikhin z...@ispras.ru wrote: On 05/11/2010 12:18 AM, Anthony Liguori wrote: On 04/18/2010 02:21 PM, Shahar Havivi wrote: Patch add QEMUPutKbdEntry structure - handling each keyboard entry, the structure handled by qemu tail queue. Adding

[Qemu-devel] [PATCH] Close socket file descriptor when qemu_accept fails

2010-07-24 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- migration-tcp.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index 78b56dc..b55f419 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@ -151,7 +151,7 @@ static void

[Qemu-devel] [PATCH] Block migration fail, ignore error from bdrv_getlength

2010-07-10 Thread Shahar Havivi
When there is no block driver associate with BlockDriverState bdrv_getlength returns -ENOMEDIUM that cause block migration to fail. Signed-off-by: Shahar Havivi shah...@redhat.com --- block-migration.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block-migration.c b

[Qemu-devel] [PATCH v2] Block migration fail, ignore error from bdrv_getlength

2010-07-10 Thread Shahar Havivi
When there is no block driver associate with BlockDriverState bdrv_getlength returns -ENOMEDIUM that cause block migration to fail v2: fix sectors0 to sectors=0 Signed-off-by: Shahar Havivi shah...@redhat.com --- block-migration.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[Qemu-devel] [PATCH 0/2 v5] Qemu support for multiple keyboard devices

2010-06-19 Thread Shahar Havivi
selected. Patch #2 adding 2 new monitor command to handle keyboard list: 'info keyboard' - show all keyboards and mark the current one 'keyboard_set' - set active keyboard by index as display in 'info keyboard' Shahar Havivi (2): Support for multiple

[Qemu-devel] [PATCH 1/2] Support for multiple keyboard devices

2010-06-19 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- console.h| 15 +++- hw/adb.c |2 +- hw/escc.c|3 +- hw/musicpal.c|2 +- hw/nseries.c |4 +- hw/palm.c|2 +- hw/ps2.c |2 +- hw

[Qemu-devel] [PATCH 2/2] Two new monitor commands: 'info keyboard', 'keyboard_set'

2010-06-19 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- console.h |5 ++ hw/usb-hid.c|6 +++ input.c | 111 +++ monitor.c |8 qemu-monitor.hx | 18 + 5 files changed, 148 insertions(+), 0

Re: [Qemu-devel] [PATCH 2/2] Return usb device to host on exit

2010-06-16 Thread Shahar Havivi
On Wed, Jun 16, 2010 at 10:48:23AM +0200, Gerd Hoffmann wrote: Date: Wed, 16 Jun 2010 10:48:23 +0200 From: Gerd Hoffmann kra...@redhat.com To: Shahar Havivi shah...@redhat.com Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH 2/2] Return usb device to host on exit +static void

[Qemu-devel] [PATCH 0/2 v5] Release usb devices on shutdown and usb_del

2010-06-16 Thread Shahar Havivi
v5: Fix to Gerd Hoffmann comments on v4. Shahar Havivi (2): Return usb device to host on usb_del command Return usb device to host on exit usb-linux.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 2/2] Return usb device to host on exit

2010-06-16 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- usb-linux.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 22a85e3..c3c38ec 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -33,6 +33,7 @@ #include qemu-common.h #include

[Qemu-devel] [PATCH 2/2] Return usb device to host on exit

2010-06-15 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- usb-linux.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 22a85e3..4b5aeb6 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -33,6 +33,7 @@ #include qemu-common.h

[Qemu-devel] [PATCH 0/2 v4] Release usb devices on shutdown and usb_del

2010-06-15 Thread Shahar Havivi
v4: use exit notifier instead of atexit() Shahar Havivi (2): Return usb device to host on usb_del command Return usb device to host on exit usb-linux.c | 20 1 files changed, 20 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 1/2] Return usb device to host on usb_del command

2010-06-15 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- usb-linux.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 88273ff..22a85e3 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -991,6 +991,7 @@ static int usb_host_close(USBHostDevice *dev

[Qemu-devel] [PATCH 0/2 v3] Release usb devices on shutdown and usb_del command

2010-06-12 Thread Shahar Havivi
v3: separate usb hot-unplug and host terminate handling remove empty methods from bsd and stub added usb-linux atexit method to reset usb devices on termination Shahar Havivi (2): Return usb device to host on usb_del command Return usb device to host on exit usb-linux.c | 13

[Qemu-devel] [PATCH 2/2] Return usb device to host on exit

2010-06-12 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- usb-linux.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 22a85e3..2a595f0 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -286,6 +286,17 @@ static void async_cancel(USBPacket

[Qemu-devel] Re: [PATCH] un-register kbd driver for USB kbd unplug

2010-06-08 Thread Shahar Havivi
On Tue, Jun 08, 2010 at 12:43:50PM +0200, jes.soren...@redhat.com wrote: Date: Tue, 8 Jun 2010 12:43:50 +0200 From: jes.soren...@redhat.com To: anth...@codemonkey.ws Cc: qemu-devel@nongnu.org, shav...@redhat.com, Jes Sorensen jes.soren...@redhat.com Subject: [PATCH] un-register kbd

[Qemu-devel] Re: [PATCH] Release usb devices on shutdown and usb_del command

2010-05-26 Thread Shahar Havivi
On Tue, May 25, 2010 at 10:58:50AM +0200, Gerd Hoffmann wrote: Date: Tue, 25 May 2010 10:58:50 +0200 From: Gerd Hoffmann kra...@redhat.com To: Shahar Havivi shah...@redhat.com CC: David S. Ahern daah...@cisco.com, Markus Armbruster arm...@redhat.com, qemu-devel@nongnu.org Subject: Re

Re: [Qemu-devel] [PATCH 1/2 v4] Support for multiple keyboard devices

2010-05-26 Thread Shahar Havivi
On Mon, May 10, 2010 at 03:18:29PM -0500, Anthony Liguori wrote: Date: Mon, 10 May 2010 15:18:29 -0500 From: Anthony Liguori anth...@codemonkey.ws To: Shahar Havivi shah...@redhat.com CC: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH 1/2 v4] Support for multiple keyboard devices

[Qemu-devel] Re: [PATCH] Release usb devices on shutdown and usb_del command

2010-05-21 Thread Shahar Havivi
Remove usb_host_device_release and using usb_host_close to handle usb_del command. Gerd, What do you think about the usb_cleanup()? If it will be in usb-linux.c we will have to ad atexit to each device, if we usb-bus.c we will have to implement in bsd and stub... Signed-off-by: Shahar Havivi

[Qemu-devel] [PATCH v2] Release usb devices on shutdown and usb_del command

2010-05-19 Thread Shahar Havivi
-by: Shahar Havivi shah...@redhat.com --- hw/usb-bus.c |4 hw/usb.h |2 ++ usb-bsd.c| 10 ++ usb-linux.c | 21 + usb-stub.c | 10 ++ vl.c |1 + 6 files changed, 48 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb

Re: [Qemu-devel] [PATCH] Fix qemu mouse Set_Protocol behavior

2010-05-02 Thread Shahar Havivi
On Sat, May 01, 2010 at 10:38:51PM -0400, Kevin O'Connor wrote: Date: Sat, 1 May 2010 22:38:51 -0400 From: Kevin O'Connor ke...@koconnor.net To: qemu-devel@nongnu.org, seab...@seabios.org Cc: Subject: [Qemu-devel] [PATCH] Fix qemu mouse Set_Protocol behavior The QEMU USB mouse claims to

[Qemu-devel] [PATCH] Return contorl to host on usb_del monitor command

2010-04-19 Thread Shahar Havivi
When removing usb on guest via usb_del monitor command, qemu does not return the control to the host, the only solution user have is to unplug/plug the device again in order to get the device back to the host Signed-off-by: Shahar Havivi shah...@redhat.com --- hw/usb-bus.c |4 hw/usb.h

[Qemu-devel] [PATCH 0/2 v4] Qemu support for multiple keyboard devices

2010-04-18 Thread Shahar Havivi
one 'keyboard_set' - set active keyboard by index as display in 'info keyboard' Shahar Havivi (2): Support for multiple keyboard devices Two new monitor commands: 'info keyboard', 'keyboard_set' console.h| 19 ++- hw/adb.c

[Qemu-devel] [PATCH 1/2 v4] Support for multiple keyboard devices

2010-04-18 Thread Shahar Havivi
Patch add QEMUPutKbdEntry structure - handling each keyboard entry, the structure handled by qemu tail queue. Adding a new keyboard add to the list and select it, removing keyboard select the previous keyboard in list. Signed-off-by: Shahar Havivi shah...@redhat.com --- console.h

[Qemu-devel] [PATCH 2/2 v4] Two new monitor commands: 'info keyboard', 'keyboard_set'

2010-04-18 Thread Shahar Havivi
Adding ability to handle which keyboard qemu will use and to see which keyboard are currently available. $ info keyboard $ keyboard_set index Signed-off-by: Shahar Havivi shah...@redhat.com --- console.h |5 ++ hw/usb-hid.c|6 +++ input.c | 111

[Qemu-devel] [PATCH 0/2 v3] Qemu support for multiple keyboard devices

2010-03-31 Thread Shahar Havivi
in 'info keyboard' Shahar Havivi (2): Support for multiple keyboard devices Added monitor commands: 'keyboard_set' and 'info keybaord' console.h| 18 ++- hw/adb.c |2 +- hw/escc.c|3 +- hw/musicpal.c|2 +- hw

[Qemu-devel] [PATCH 1/2] Support for multiple keyboard devices

2010-03-31 Thread Shahar Havivi
-off-by: Shahar Havivi shah...@redhat.com --- console.h| 14 - hw/adb.c |2 +- hw/escc.c|3 +- hw/musicpal.c|2 +- hw/nseries.c |4 +- hw/palm.c|2 +- hw/ps2.c |2 +- hw/pxa2xx_keypad.c

[Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-31 Thread Shahar Havivi
Two new monitor commands: adding ability to handle which keyboard qemu will use and to see which keyboard are currently available. $ info keyboard $ keyboard_set index Signed-off-by: Shahar Havivi shah...@redhat.com --- console.h |4 ++ input.c | 101

[Qemu-devel] Re: [PATCH 1/2] Support for multiple keyboard devices

2010-03-31 Thread Shahar Havivi
On Wed, Mar 31, 2010 at 12:12:15PM +0200, Juan Quintela wrote: Date: Wed, 31 Mar 2010 12:12:15 +0200 From: Juan Quintela quint...@redhat.com To: Shahar Havivi shah...@redhat.com Cc: qemu-devel@nongnu.org Subject: Re: [PATCH 1/2] Support for multiple keyboard devices Shahar Havivi shah

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-31 Thread Shahar Havivi
On Wed, Mar 31, 2010 at 05:10:22PM +0200, Markus Armbruster wrote: Date: Wed, 31 Mar 2010 17:10:22 +0200 From: Markus Armbruster arm...@redhat.com To: Shahar Havivi shah...@redhat.com Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set

Re: [Qemu-devel] [PATCH 1/2] Support for multiple keyboard devices

2010-03-31 Thread Shahar Havivi
On Wed, Mar 31, 2010 at 05:23:46PM +0200, Markus Armbruster wrote: Date: Wed, 31 Mar 2010 17:23:46 +0200 From: Markus Armbruster arm...@redhat.com To: Shahar Havivi shah...@redhat.com Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH 1/2] Support for multiple keyboard devices

Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-31 Thread Shahar Havivi
On Wed, Mar 31, 2010 at 05:31:49PM +0200, Markus Armbruster wrote: Date: Wed, 31 Mar 2010 17:31:49 +0200 From: Markus Armbruster arm...@redhat.com To: Juan Quintela quint...@redhat.com Cc: Shahar Havivi shah...@redhat.com, qemu-devel@nongnu.org Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Added

Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-31 Thread Shahar Havivi
On Wed, Mar 31, 2010 at 06:58:14PM +0200, Juan Quintela wrote: Date: Wed, 31 Mar 2010 18:58:14 +0200 From: Juan Quintela quint...@redhat.com To: Markus Armbruster arm...@redhat.com Cc: Shahar Havivi shah...@redhat.com, qemu-devel@nongnu.org Subject: [Qemu-devel] Re: [PATCH 2/2] Added monitor

Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-31 Thread Shahar Havivi
driver works. Regards, Anthony Liguori Anthony, Added qemu_activate_keyboard_event_handler, and use it with usb_keyboard_poll. I test it with two usb keyboard devices, the last connected one is active. Shahar. Signed-off-by: Shahar Havivi shah...@redhat.com --- console.h |5

Re: [Qemu-devel] [PATCH 1/2] Support for multiple keyboard devices

2010-03-27 Thread Shahar Havivi
On Fri, Mar 26, 2010 at 10:46:14AM +0100, Markus Armbruster wrote: +QEMUPutKbdEntry *qemu_add_kbd_event_handler(QEMUPutKBDEvent *func, +void *opaque, +const char *name) +{ +QEMUPutKbdEntry *s,

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-27 Thread Shahar Havivi
Fix to Markus comments. --- console.h |6 +++ input.c | 119 ++ monitor.c |8 qemu-monitor.hx | 17 4 files changed, 141 insertions(+), 9 deletions(-) diff --git a/console.h b/console.h index

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-26 Thread Shahar Havivi
On Fri, Mar 26, 2010 at 10:57:58AM +0100, Markus Armbruster wrote: Date: Fri, 26 Mar 2010 10:57:58 +0100 From: Markus Armbruster arm...@redhat.com To: Shahar Havivi shah...@redhat.com Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set

[Qemu-devel] [PATCH 0/2] Qemu support for multiple keyboard devices - v2

2010-03-23 Thread Shahar Havivi
keyboard list: 'info keyboard' - show all keyboards and mark the current one 'keyboard_set' - set active keyboard by index as display in 'info keyboard' Shahar Havivi (2): Support for multiple keyboard devices Added monitor commands

[Qemu-devel] [PATCH 1/2] Support for multiple keyboard devices

2010-03-23 Thread Shahar Havivi
-off-by: Shahar Havivi shah...@redhat.com --- console.h| 12 ++- hw/adb.c |2 +- hw/escc.c|3 +- hw/musicpal.c|2 +- hw/nseries.c |4 +- hw/palm.c|2 +- hw/ps2.c |2 +- hw/pxa2xx_keypad.c

[Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-23 Thread Shahar Havivi
Two new monitor commands: adding ability to handle which keyboard qemu will use and to see which keyboard are currently available. $ info keyboard $ keyboard_set index Signed-off-by: Shahar Havivi shah...@redhat.com --- console.h |4 ++ input.c | 104

[Qemu-devel] [PATCH 1/2] Support for multiple keyboard devices

2010-03-19 Thread Shahar Havivi
. Signed-off-by: Shahar Havivi shah...@redhat.com --- console.h| 16 +- hw/adb.c |2 +- hw/escc.c|3 +- hw/musicpal.c|2 +- hw/nseries.c |4 +- hw/palm.c|2 +- hw/ps2.c |2 +- hw

[Qemu-devel] [PATCH 0/2] Qemu support for multiple keyboard devices

2010-03-19 Thread Shahar Havivi
' - show all keyboards and mark the current one 'keyboard_set' - set active keyboard by index as display in 'info keyboard' Shahar Havivi (2): Support for multiple keyboard devices Added monitor commands: 'keyboard_set' and 'info keybaord' console.h

[Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-19 Thread Shahar Havivi
This new monitor command adding ability to handle which keyboard qemu will use and to see which keyboard are currently available. Signed-off-by: Shahar Havivi shah...@redhat.com --- input.c | 73 +++ monitor.c |8

[Qemu-devel] [PATCH] Fix gcc warning 'format not a string literal and no format arguments'

2010-03-19 Thread Shahar Havivi
gcc 4.4.1 produce a warning 'format not a string literal and no format arguments' Signed-off-by: Shahar Havivi shah...@redhat.com --- qemu-error.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-error.c b/qemu-error.c index 5d5fe37..14ec14f 100644 --- a/qemu

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-19 Thread Shahar Havivi
On Fri, Mar 19, 2010 at 05:22:05PM -0300, Luiz Capitulino wrote: Date: Fri, 19 Mar 2010 17:22:05 -0300 From: Luiz Capitulino lcapitul...@redhat.com To: Shahar Havivi shah...@redhat.com Cc: Dor Laor dl...@redhat.com, qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH 2/2] Added monitor

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-19 Thread Shahar Havivi
Fix to Luiz comments. Signed-off-by: Shahar Havivi shah...@redhat.com --- console.h |4 ++ input.c | 104 +++ monitor.c |8 qemu-monitor.hx | 17 + qerror.c|8 qerror.h|6

[Qemu-devel] [PATCH] Restore terminal monitor attributes - addition

2010-03-14 Thread Shahar Havivi
any serial device). Signed-off-by: Shahar Havivi shah...@redhat.com --- qemu-char.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 0e25ef3..4bf1e82 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1002,7 +1002,9 @@ static void

[Qemu-devel] [PATCH] Support for multiple keyboard device

2010-03-11 Thread Shahar Havivi
, segfault This patch fix the segfault and add list of all the keyboard handle much like the mouse device does. Signed-off-by: Shahar Havivi shah...@redhat.com --- console.h|9 +- hw/usb-hid.c |9 -- input.c | 81

[Qemu-devel] [PATCH] Wrong error message in block_passwd command

2010-03-05 Thread Shahar Havivi
Monitor command 'block_passwd' reports a wrong error message when drive is not encrypted Signed-off-by: Shahar Havivi shah...@redhat.com --- block.c |9 ++--- monitor.c |7 ++- qerror.c |4 qerror.h |3 +++ 4 files changed, 19 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH 0/2] Fix block_passwd monitor command error

2010-03-05 Thread Shahar Havivi
The next two patches fix the wrong error message in block_passwd monitor command: when trying to decrypt un-encrypted drive, user get error wrong password. 1 add error message to qerror.h and qerror.c 2 patch the monitor command error handling Shahar Havivi (2): QError: New

[Qemu-devel] [PATCH 1/2] QError: New QERR_DEVICE_NOT_ENCRYPTED

2010-03-05 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 2f657f4..4e63a54 100644 --- a/qerror.c +++ b/qerror.c @@ -49,6 +49,10 @@ static const QErrorStringTable

[Qemu-devel] [PATCH 2/2] Wrong error message in block_passwd command

2010-03-05 Thread Shahar Havivi
Signed-off-by: Shahar Havivi shah...@redhat.com --- block.c |7 +-- monitor.c |7 ++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 31d1ba4..e891544 100644 --- a/block.c +++ b/block.c @@ -1134,8 +1134,11 @@ int bdrv_set_key

Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-03-01 Thread Shahar Havivi
On Sat, Feb 27, 2010 at 09:20:28AM -0700, David S. Ahern wrote: Date: Sat, 27 Feb 2010 09:20:28 -0700 From: David S. Ahern daah...@cisco.com To: Shahar Havivi shah...@redhat.com CC: qemu-devel@nongnu.org, Dor Laor dl...@redhat.com Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes

Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-02-27 Thread Shahar Havivi
On Fri, Feb 26, 2010 at 03:19:19PM -0700, David S. Ahern wrote: Date: Fri, 26 Feb 2010 15:19:19 -0700 From: David S. Ahern daah...@cisco.com To: Shahar Havivi shah...@redhat.com CC: qemu-devel@nongnu.org, Dor Laor dl...@redhat.com Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes

[Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-02-26 Thread Shahar Havivi
Patch http://permalink.gmane.org/gmane.comp.emulators.qemu/63472 handle close when using tty devices (like /dev/ttyS0), yet tty based monitor are not restoring terminal attributes (as done with stdio based monitor), when closing qemu after that command: $ qemu -monitor /dev/tty the terminal is

Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-02-26 Thread Shahar Havivi
Fix codding style --- qemu-char.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 4169492..4533887 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed, speed,

Re: [Qemu-devel] [PATCH] terminal attributes is not restored when using /dev/tty monitor

2010-02-21 Thread Shahar Havivi
On Sun, Feb 21, 2010 at 07:32:41AM -0700, David S. Ahern wrote: Date: Sun, 21 Feb 2010 07:32:41 -0700 From: David S. Ahern daah...@cisco.com To: Shahar Havivi shah...@redhat.com CC: Anthony Liguori anth...@codemonkey.ws, Dor Laor dl...@redhat.com, qemu-devel@nongnu.org Subject: Re

[Qemu-devel] [PATCH] terminal attributes is not restored when using /dev/tty monitor

2010-02-20 Thread Shahar Havivi
when exiting qemu that run with -monitor /dev/tty, the launching terminal get weird behaviour because no restore terminals action has taken. added chr_close and register atexit() code for tty devices (like stdio does) Signed-off-by: Shahar Havivi shah...@redhat.com --- qemu-char.c | 14

Re: [Qemu-devel] [PATCH] terminal attributes is not restored when using /dev/tty monitor

2010-02-20 Thread Shahar Havivi
On Sat, Feb 20, 2010 at 08:18:54AM -0700, David S. Ahern wrote: Date: Sat, 20 Feb 2010 08:18:54 -0700 From: David S. Ahern daah...@cisco.com To: Shahar Havivi shah...@redhat.com CC: qemu-devel@nongnu.org, Dor Laor dl...@redhat.com Subject: Re: [Qemu-devel] [PATCH] terminal attributes

Re: [Qemu-devel] [PATCH] terminal attributes is not restored when using /dev/tty monitor

2010-02-20 Thread Shahar Havivi
On Sat, Feb 20, 2010 at 11:03:41AM -0600, Anthony Liguori wrote: Date: Sat, 20 Feb 2010 11:03:41 -0600 From: Anthony Liguori anth...@codemonkey.ws To: David S. Ahern daah...@cisco.com Cc: Dor Laor dl...@redhat.com, Shahar Havivi shah...@redhat.com, qemu-devel@nongnu.org Subject: Re

[Qemu-devel] Qemu does not pass pressed caps lock to client

2010-02-11 Thread Shahar Havivi
Qemu have a hack for capslock that is not working with Ubuntu. attached patch that fix it, as describe in this bug: https://bugs.launchpad.net/qemu/+bug/427612 Signed-off-by: Shahar Havivi shah...@gmail.com --- sdl.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git