Re: [PATCH v4] ptp: Add vDSO-style vmclock support

2024-08-22 Thread Simon Horman
On Wed, Aug 21, 2024 at 10:50:47PM +0100, David Woodhouse wrote: ... > diff --git a/drivers/ptp/ptp_vmclock.c b/drivers/ptp/ptp_vmclock.c ... > +#define VMCLOCK_FIELD_PRESENT(_c, _f) \ > + (_c)->size >= (offsetof(struct vmclock_abi, _f) + \ > +si

Re: [RFC PATCH v3] ptp: Add vDSO-style vmclock support

2024-07-08 Thread Simon Horman
On Sat, Jul 06, 2024 at 04:14:39PM +0100, David Woodhouse wrote: > From: David Woodhouse > > The vmclock "device" provides a shared memory region with precision clock > information. By using shared memory, it is safe across Live Migration. > > Like the KVM PTP clock, this can convert TSC-based c

Re: [Qemu-devel] Re: [PATCH] rtl8139: fix clang reporting unused assignment of VLAN tagging data

2010-01-17 Thread Simon Horman
On Fri, Jan 15, 2010 at 08:08:53AM +0100, Paolo Bonzini wrote: > > >diff --git a/hw/rtl8139.c b/hw/rtl8139.c > >index 1f4f585..f04dd54 100644 > >--- a/hw/rtl8139.c > >+++ b/hw/rtl8139.c > >@@ -1909,6 +1909,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) > > > > cpu_physical_memory

Re: [Qemu-devel] [PATCH] raw-posix: Detect CDROM via ioctl

2010-01-11 Thread Simon Horman
On Mon, Jan 11, 2010 at 01:30:18PM -0500, Cole Robinson wrote: > Current CDROM detection is hardcoded based on source file name. > Make this smarter by attempting a CDROM specific ioctl. > > This makes '-cdrom /dev/sr0' succeed with no media present. > > Signed-off-by: Cole Robinson > --- > blo

Re: [Qemu-devel] [PATCH] Added 'access' option to -drive flag

2009-12-23 Thread Simon Horman
On Wed, Dec 23, 2009 at 02:12:23PM +0200, Naphtali Sprei wrote: > Added 'access' option to -drive flag > > The new option is: access=[rw|ro|auto] > rw: open the drive's file with Read and Write permission, don't continue if > failed > ro: open the file only with Read permission > auto: open the f