Re: [PATCH] lockable: Replace locks with lock guard macros

u/lockable.h:173:29: note: expanded from > macro 'QEMU_LOCK_GUARD' > > This patch series depends on Daniel Brodsky's "[PATCH v4 0/2] Replaced > locks with lock guard macros" patch series. I think Daniel intends to > fix the unused variable warnings. > Yes, I saw that patch series. I'll send the next version after Daniel Brodsky fixes the unused variable warnings. Thanks & Regards Simran Singhal > > Stefan >

[PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0" to fix the typo. Fixes: 8d3265b3 Reviewed-by: Eric Blake Signed-off-by: Simran Singhal --- Changes in v3: -Add "Fixes: 8d3265b3" in commit message. Changes in v2: -

[PATCH v2] qobject: json-streamer: Change bracket_count to brace_count

Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0" to fix the typo. Signed-off-by: Simran Singhal --- Changes in v2: -No need to remove the duplicate occurence of "parser->bracket_count >= 0" but actually i

Re: [PATCH] qobject: json-streamer: Remove double test

On Thu, Apr 2, 2020 at 6:42 PM Eric Blake wrote: > On 4/2/20 7:13 AM, Simran Singhal wrote: > > Remove the duplicate test "parser->bracket_count >= 0". > > > > Signed-off-by: Simran Singhal > > --- > > qobject/json-streamer.c | 2 +-

[PATCH] qobject: json-streamer: Remove double test

Remove the duplicate test "parser->bracket_count >= 0". Signed-off-by: Simran Singhal --- qobject/json-streamer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qobject/json-streamer.c b/qobject/json-streamer.c index 47dd7ea576..ef48185283 100644 --

[PATCH v2] lockable: Replace locks with lock guard macros

Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). Signed-off-by: Simran Singhal --- Changes in v2: -Drop changes in file hw/rdma/rdma_utils.c hw/hyperv/hyperv.c | 15 ++--- hw/rdma/rdma_backend.c | 50

[PATCH v2] Compress lines for immediate return

etween function name and open parenthesis '(' Done using following coccinelle script: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Simran Singhal --- Changes in v2: -Added coccinelle script wrote for changes in commit message.

Re: [PATCH] Compress lines for immediate return

On Wed, Apr 1, 2020 at 9:15 PM Eric Blake wrote: > On 4/1/20 9:49 AM, Simran Singhal wrote: > > Hello Philippe > > > > On Wed, Apr 1, 2020 at 7:26 PM Philippe Mathieu-Daudé > > > wrote: > > > >> Hi Simran, > >> > >> On 4/1/20 2:11 P

[PATCH] lockable: Replace locks with lock guard macros

Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). Signed-off-by: Simran Singhal --- hw/hyperv/hyperv.c | 15 ++--- hw/rdma/rdma_backend.c | 50 +- hw/rdma/rdma_rm.c | 3 +-- hw/rdma

Re: [PATCH] Compress lines for immediate return

Hello Philippe On Wed, Apr 1, 2020 at 7:26 PM Philippe Mathieu-Daudé wrote: > Hi Simran, > > On 4/1/20 2:11 PM, Simran Singhal wrote: > > Compress two lines into a single line if immediate return statement is > found. > > How did you find these changes? Manual audi

[PATCH] Compress lines for immediate return

etween function name and open parenthesis '(' Signed-off-by: Simran Singhal --- block/file-posix.c | 3 +-- block/nfs.c | 3 +-- block/nvme.c| 4 +--- block/vhdx.c| 3 +-- hw/audio/ac97.c | 4 +--- hw/audio/adlib.c| 5 +---