Re: [PATCH v4 0/8] vhost-user: Back-end state migration

On Wed, Oct 04, 2023 at 02:58:56PM +0200, Hanna Czenczek wrote: > RFC: > https://lists.nongnu.org/archive/html/qemu-devel/2023-03/msg04263.html > > v1: > https://lists.nongnu.org/archive/html/qemu-devel/2023-04/msg01575.html > > v2: > https://lists.nongnu.org/archive/html/qemu-devel/2023-07/msg02

Re: [PATCH v4 6/8] vhost-user: Interface for migration state transfer

On Wed, Oct 04, 2023 at 02:59:02PM +0200, Hanna Czenczek wrote: > Add the interface for transferring the back-end's state during migration > as defined previously in vhost-user.rst. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Hanna Czenczek > --- > include/hw/vi

Re: [PATCH v4 8/8] vhost-user-fs: Implement internal migration

erations to transfer migratory > state. It is its own dedicated subsection, so that for external > migration, it can be disabled. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Hanna Czenczek > --- > hw/virtio/vhost-user-fs.c | 101

Re: [PATCH v4 7/8] vhost: Add high-level state save/load functions

e size ahead of time, > vhost_save_backend_state() simply reads the data in 1 MB chunks, and > writes each chunk consecutively into the migration stream, prefixed by > its length. EOF is indicated by a 0-length chunk. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Hanna Czencz

Re: [PATCH v4 5/8] vhost-user.rst: Migrating back-end-internal state

deserialization). > > Signed-off-by: Hanna Czenczek > --- > docs/interop/vhost-user.rst | 172 ++++ > 1 file changed, 172 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH v4 4/8] vhost-user.rst: Introduce suspended state

gt; get away without SUSPEND. > > Still, we do want to clarify that if the device is completely stopped, > i.e. all vrings are stopped, the back-end should cease to modify any > state relating to the guest. Do this by calling it "suspended". > > Suggested-by: Stefan H

Re: [PATCH v4 3/8] vhost-user.rst: Clarify enabling/disabling vrings

d. > Every vring is initialized in a disabled state, and SET_FEATURES without > VHOST_USER_F_PROTOCOL_FEATURES simply becomes one way to enable all > vrings. > > Signed-off-by: Hanna Czenczek > --- > docs/interop/vhost-user.rst | 32 +++++--- > 1 file changed, 17 insertions(+), 15 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH v4 2/8] vhost-user.rst: Improve [GS]ET_VRING_BASE doc

On Wed, Oct 04, 2023 at 02:58:58PM +0200, Hanna Czenczek wrote: > GET_VRING_BASE does not mention that it stops the respective ring. Fix > that. > > Furthermore, it is not fully clear what the "base offset" these > commands' documentation refers to is; an offset could be many things. > Be more pr

Re: [PATCH v4 1/8] vhost-user.rst: Deprecate [GS]ET_STATUS

ll set, which is the only way in which > dpdk uses the status byte. > > As-is, no front-end or back-end can rely on the other side handling this > field in a useful manner, and it also provides no practical use over > other mechanisms the vhost-user protocol has, which are more clearly &

Re: [PULL v2 00/47] tcg patch queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 00/53] virtio,pci: features, cleanups

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [RFC PATCH v2 1/9] Add Rust SEV library as subproject

On Wed, Oct 04, 2023 at 04:34:10PM -0400, Tyler Fanelli wrote: > The Rust sev library provides a C API for the AMD SEV launch ioctls, as > well as the ability to build with meson. Add the Rust sev library as a > QEMU subproject with the goal of outsourcing all SEV launch ioctls to C > APIs provided

Re: [PULL 0/9] Python patches

On Thu, 5 Oct 2023 at 00:49, Philippe Mathieu-Daudé wrote: > > Hi John, > > On 4/10/23 21:46, John Snow wrote: > > The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0: > > > >Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging > > (2023-10-03 07:43

Re: [PULL 0/1] Block patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/11] Migration 20231004 patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v3 16/16] trace/control: Clean up global variable shadowing

ace/control.h | 4 ++-- > trace/control.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PULL 00/51] Bsd user mmap patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/13] Misc patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/63] virtio,pci: features, cleanups

On Wed, 4 Oct 2023 at 13:20, Michael S. Tsirkin wrote: > > On Wed, Oct 04, 2023 at 12:50:18PM -0400, Stefan Hajnoczi wrote: > > On Wed, 4 Oct 2023 at 04:43, Michael S. Tsirkin wrote: > > > > > > The following changes since commit > > > 4

Re: [PULL 00/63] virtio,pci: features, cleanups

The link to the job is https://gitlab.com/qemu-project/qemu/-/jobs/5222693360. The link to the pipeline is https://gitlab.com/qemu-project/qemu/-/pipelines/1025613961. On Wed, 4 Oct 2023 at 13:04, Michael S. Tsirkin wrote: > > On Wed, Oct 04, 2023 at 12:50:18PM -0400, Stefan Hajnoczi

Re: [PULL 00/63] virtio,pci: features, cleanups

synchronously > > Michael S. Tsirkin (1): > pci: SLT must be RO > > Philippe Mathieu-Daudé (6): > hw/virtio: Propagate page_mask to vhost_vdpa_listener_skipped_section() > hw/virtio: Propagate page_mask to vhost_vdpa_section_end() > hw/virtio/vhost-vdpa:

Re: [PULL 00/47] tcg patch queue

On Wed, 4 Oct 2023 at 12:28, Richard Henderson wrote: > > On 10/4/23 07:57, Stefan Hajnoczi wrote: > > This commit breaks the build: > > > > ../bsd-user/signal.c:479:19: error: unused variable 'env' > > [-Werror,-Wunused-variable] > > CPUArch

Re: [PULL 00/47] tcg patch queue

On Tue, 3 Oct 2023 at 13:31, Richard Henderson wrote: > > The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0: > > Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging > (2023-10-03 07:43:44 -0400) > > are available in the Git repository at: > > htt

[PULL 1/1] osdep: set _FORTIFY_SOURCE=2 when optimization is enabled

. Signed-off-by: Daniel P. Berrangé Message-id: 20231003091549.223020-1-berra...@redhat.com Signed-off-by: Stefan Hajnoczi --- meson.build | 10 -- include/qemu/osdep.h | 4 util/coroutine-sigaltstack.c | 4 ++-- util/coroutine-ucontext.c| 4 ++-- 4

[PULL 0/1] Block patches

The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-10-03 07:43:44 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to

Re: [PATCH v2 1/3] vhost-user: do not send RESET_OWNER on device reset

On Wed, 4 Oct 2023 at 06:44, Hanna Czenczek wrote: > > On 04.10.23 03:45, Stefan Hajnoczi wrote: > > The VHOST_USER_RESET_OWNER message is deprecated in the spec: > > > > This is no longer used. Used to be sent to request disabling all > > rings, but some ba

[PATCH v2 1/3] vhost-user: do not send RESET_OWNER on device reset

user protocol specific code from vhost-user-scsi.c into vhost-user.c where it belongs. Signed-off-by: Stefan Hajnoczi --- hw/scsi/vhost-user-scsi.c | 9 - hw/virtio/vhost-user.c| 13 + 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/scsi/vhost-user-scsi.

[PATCH v2 3/3] virtio: call ->vhost_reset_device() during reset

SET_STATUS 0 call is made during device reset. Signed-off-by: Stefan Hajnoczi --- meson.build | 1 + include/hw/virtio/vhost.h | 10 ++ hw/scsi/vhost-user-scsi.c | 11 --- hw/virtio/vhost.c | 9 + hw/virtio/virtio.c| 4 5 files chang

[PATCH v2 2/3] vhost-backend: remove vhost_kernel_reset_device()

of vhost_kernel_reset_device() for now. If someone needs it in the future they'll need to implement it correctly. Signed-off-by: Stefan Hajnoczi --- hw/virtio/vhost-backend.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c

[PATCH v2 0/3] vhost: clean up device reset

vhost-user-backend crate do not negotiate VHOST_USER_PROTOCOL_F_RESET_DEVICE automatically. - vhost-vdpa: an extra SET_STATUS 0 call is made during device reset. I have tested this series with vhost-net (kernel), vhost-user-blk, and vhost-user-fs (both Rust and legacy C). Stefan Hajnoczi (3):

Re: [PATCH 0/3] vhost: clean up device reset

On Tue, 3 Oct 2023 at 17:01, Michael S. Tsirkin wrote: > > On Wed, Sep 27, 2023 at 03:27:34PM -0400, Stefan Hajnoczi wrote: > > Stateful vhost devices may need to free resources or clear device state upon > > device reset. The vhost-user protocol has a VHOST_USER_RESET_DEVIC

Re: [PATCH RESEND] osdep: set _FORTIFY_SOURCE=2 when optimization is enabled

On Tue, Oct 03, 2023 at 10:15:49AM +0100, Daniel P. Berrangé wrote: > Currently we set _FORTIFY_SOURCE=2 as a compiler argument when the > meson 'optimization' setting is non-zero, the compiler is GCC and > the target is Linux. > > While the default QEMU optimization level is 2, user could overrid

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, 3 Oct 2023 at 10:41, Michael S. Tsirkin wrote: > > On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: > > (1) The virtio-1.0 specification > > writes: > > > > > 3 General Initialization And Device Operation > >

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, 3 Oct 2023 at 10:40, Michael S. Tsirkin wrote: > > On Tue, Oct 03, 2023 at 09:08:15AM -0400, Stefan Hajnoczi wrote: > > On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: > > > > > > On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wr

Re: [PULL 00/24] Audio, build system, misc fixes for 2023-10-03

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Tue, 3 Oct 2023 at 08:27, Michael S. Tsirkin wrote: > > On Mon, Oct 02, 2023 at 05:13:26PM -0400, Stefan Hajnoczi wrote: > > One more question: > > > > Why is the disabled state not needed by regular (non-vhost) virtio-net > > devices? > > Tap does the same

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, 2 Oct 2023 at 18:36, Michael S. Tsirkin wrote: > > On Mon, Oct 02, 2023 at 05:12:27PM -0400, Stefan Hajnoczi wrote: > > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > &

Re: [PULL 0/2] Firmware/seabios 20230929 patches

On Fri, 29 Sept 2023 at 07:30, Gerd Hoffmann wrote: > > The following changes since commit 36e9aab3c569d4c9ad780473596e18479838d1aa: > > migration: Move return path cleanup to main migration thread (2023-09-27 > 13:58:02 -0400) > > are available in the Git repository at: > > https://gitlab.co

Re: [PULL 00/56] -Wshadow=local patches patches for 2023-09-29

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v3 00/16] tricore queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/13] Migration 20231002 patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/6] tcg patch queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/14] Tracing patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

One more question: Why is the disabled state not needed by regular (non-vhost) virtio-net devices? On Mon, 2 Oct 2023 at 17:12, Stefan Hajnoczi wrote: > > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoc

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > > > > > On 8/30/23 14:10, Stefan Hajnoczi wrote: > > > > On Sun,

Re: [PULL v2 00/21] tricore queue

Please take a look at these CI test failures: https://gitlab.com/qemu-project/qemu/-/jobs/5185201978 https://gitlab.com/qemu-project/qemu/-/jobs/5185202098 Thanks, Stefan On Thu, 28 Sept 2023 at 04:57, Bastian Koppelmann wrote: > > The following changes since commit 36e9aab3c569d4c9ad780473596e1

[PULL 08/14] simpletrace: made Analyzer into context-manager

(not demonstrated here). Reviewed-by: Stefan Hajnoczi Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-9-m...@ynddal.dk Signed-off-by: Stefan Hajnoczi --- scripts/simpletrace.py | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/scripts

[PULL 11/14] simpletrace: move event processing to Analyzer class

performance in cases where the analyzer is branching away from the catch-all a lot. The cache has no measurable performance penalty. Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-12-m...@ynddal.dk Signed-off-by: Stefan

[PULL 14/14] scripts/analyse-locks-simpletrace.py: changed iteritems() to items()

From: Mads Ynddal Python 3 removed `dict.iteritems()` in favor of `dict.items()`. This means the script currently doesn't work on Python 3. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-15-m...@ynddal.dk S

[PULL 09/14] simpletrace: refactor to separate responsibilities

`. Special handling of dropped events removed, as they can be handled by the general code. Reviewed-by: Stefan Hajnoczi Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-10-m...@ynddal.dk Signed-off-by: Stefan Hajnoczi --- scripts/simpletrace.py | 115

[PULL 04/14] simpletrace: changed naming of edict and idtoname to improve readability

From: Mads Ynddal Readability is subjective, but I've expanded the naming of the variables and arguments, to help with understanding for new eyes on the code. Signed-off-by: Mads Ynddal Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Message-id: 20230926103436.2570

[PULL 01/14] simpletrace: add __all__ to define public interface

From: Mads Ynddal It was unclear what was the supported public interface. I.e. when refactoring the code, what functions/classes are important to retain. Reviewed-by: Stefan Hajnoczi Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-2-m...@ynddal.dk Signed-off-by: Stefan Hajnoczi

[PULL 07/14] simpletrace: define exception and add handling

From: Mads Ynddal Define `SimpleException` to differentiate our exceptions from generic exceptions (IOError, etc.). Adapted simpletrace to support this and output to stderr. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Signed-off-by: Mads Ynddal Message-id

[PULL 10/14] simpletrace: move logic of process into internal function

From: Mads Ynddal To avoid duplicate code depending on input types and to better handle open/close of log with a context-manager, we move the logic of process into _process. Reviewed-by: Stefan Hajnoczi Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-11-m...@ynddal.dk Signed-off

[PULL 12/14] simpletrace: added simplified Analyzer2 class

ments list. Added deprecation warning to Analyzer class to make users aware of the Analyzer2 class. No removal date is planned. Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-13-m...@ynddal.dk Signed-off-by: Stefan Hajnoczi --- scripts/simpletrace.py

[PULL 06/14] simpletrace: improved error handling on struct unpack

ed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-7-m...@ynddal.dk Signed-off-by: Stefan Hajnoczi --- scripts/simpletrace.py | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --

[PULL 13/14] MAINTAINERS: add maintainer of simpletrace.py

be informed of changes that might affect simpletrace.py. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-14-m...@ynddal.dk Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAI

[PULL 05/14] simpletrace: update code for Python 3.11

From: Mads Ynddal The call to `getargspec` was deprecated and in Python 3.11 it has been removed in favor of `getfullargspec`. `getfullargspec` is compatible with QEMU's requirement of at least Python version 3.6. Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Signed-o

[PULL 03/14] simpletrace: improve parsing of sys.argv; fix files never closed.

time, ownership of the file-object is moved up to `run` function. Added option to process to support file-like objects. Reviewed-by: Stefan Hajnoczi Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-4-m...@ynddal.dk Signed-off-by: Stefan Hajnoczi --- scripts/simpletrace.py

[PULL 00/14] Tracing patches

The following changes since commit 494a6a2cf7f775d2c20fd6df9601e30606cc2014: Merge tag 'pull-request-2023-09-25' of https://gitlab.com/thuth/qemu into staging (2023-09-25 10:10:30 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request

[PULL 02/14] simpletrace: annotate magic constants from QEMU code

From: Mads Ynddal It wasn't clear where the constants and structs came from, so I added comments to help. Reviewed-by: Stefan Hajnoczi Signed-off-by: Mads Ynddal Message-id: 20230926103436.25700-3-m...@ynddal.dk Signed-off-by: Stefan Hajnoczi --- scripts/simpletrace.py | 5 + 1

Re: [PATCH v4 1/4] docs/qcow2: add the zoned format feature

ned-off-by: Sam Li > --- > docs/system/qemu-block-drivers.rst.inc | 33 ++ > 1 file changed, 33 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Virtio-fs] [PATCH v3 0/5] vhost-user: Back-end state migration

On Wed, Sep 27, 2023 at 10:32:14AM +0200, Hanna Czenczek wrote: > On 26.09.23 22:10, Stefan Hajnoczi wrote: > > Hi Hanna, > > I was thinking about how this could work without SUSPEND/RESUME. What > > do you think of the following? > > > > 1. The front-end

Re: [PATCH 0/8] migration fixes

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/19] Misc patches for 2023-09-26

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH 3/3] virtio: call ->vhost_reset_device() during reset

SET_STATUS 0 call is made during device reset. Signed-off-by: Stefan Hajnoczi --- include/hw/virtio/vhost.h | 3 +++ hw/scsi/vhost-user-scsi.c | 11 --- hw/virtio/vhost.c | 9 + hw/virtio/virtio.c| 4 4 files changed, 16 insertions(+), 11 deletions(-) diff -

[PATCH 1/3] vhost-user: do not send RESET_OWNER on device reset

user protocol specific code from vhost-user-scsi.c into vhost-user.c where it belongs. Signed-off-by: Stefan Hajnoczi --- hw/scsi/vhost-user-scsi.c | 9 - hw/virtio/vhost-user.c| 13 + 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/scsi/vhost-user-scsi.

[PATCH 2/3] vhost-backend: remove vhost_kernel_reset_device()

of vhost_kernel_reset_device() for now. If someone needs it in the future they'll need to implement it correctly. Signed-off-by: Stefan Hajnoczi --- hw/virtio/vhost-backend.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c

[PATCH 0/3] vhost: clean up device reset

COL_F_RESET_DEVICE automatically. - vhost-vdpa: an extra SET_STATUS 0 call is made during device reset. I have tested this series with vhost-net (kernel), vhost-user-blk, and vhost-user-fs (both Rust and legacy C). Stefan Hajnoczi (3): vhost-user: do not send RESET_OWNER on device reset vho

Re: [PATCH 0/8] migration fixes

On Mon, Sep 18, 2023 at 02:28:14PM -0300, Fabiano Rosas wrote: > This series contains fixes for the two currently know failures that > show up in migration tests plus a set of fixes for some theoretical > race conditions around QEMUFile handling. > > Patch 1 addresses the issue found in the postco

Re: [PATCH v2 0/2] virtio: clean up of virtqueue_split_read_next_desc()

Reviewed-by: Stefan Hajnoczi On Wed, 27 Sept 2023 at 10:00, Ilya Maximets wrote: > > > Version 2: > - Converted into a patch set adding a new patch that removes the > 'next' argument. [Stefan] > - Completely removing the barrier instead of changing into comp

Re: [PATCH v2] virtio: use shadow_avail_idx while checking number of heads

er. > - Added comments about the need for a barrier. Reviewed-by: Stefan Hajnoczi > > hw/virtio/virtio.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 4577f3f5b3..8a4c3e95d2 100644

Re: [PATCH v2 6/8] block/nvme: nvme_process_completion() fix bound for cid

NVME_NUM_REQS is better here. > > block/nvme.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Virtio-fs] [PATCH v3 0/5] vhost-user: Back-end state migration

Hi Hanna, I was thinking about how this could work without SUSPEND/RESUME. What do you think of the following? 1. The front-end sends VHOST_USER_RESET_DEVICE (or VHOST_USER_RESET_OWNER, when necessary) when the guest driver resets the device but not on vhost_dev_start()/vhost_dev_stop(). 2. Suspen

Re: [PATCH v3 2/5] vhost-user.rst: Clarify enabling/disabling vrings

On Tue, 26 Sept 2023 at 09:55, Hanna Czenczek wrote: > > On 25.09.23 21:15, Stefan Hajnoczi wrote: > > On Fri, Sep 15, 2023 at 12:25:27PM +0200, Hanna Czenczek wrote: > >> Currently, the vhost-user documentation says that rings are to be > >> initia

Re: [Virtio-fs] [PATCH v3 0/5] vhost-user: Back-end state migration

On Tue, Sep 26, 2023, 09:33 Hanna Czenczek wrote: > On 25.09.23 22:48, Stefan Hajnoczi wrote: > > On Fri, Sep 15, 2023 at 12:25:25PM +0200, Hanna Czenczek wrote: > >> RFC: > >> https://lists.nongnu.org/archive/html/qemu-devel/2023-03/msg04263.html > >> &g

Re: [PATCH v5 00/14] simpletrace: refactor and general improvements

h master > v4: > * Added missing Analyzer2 to __all__ > * Rebased with master > v3: > * Added __all__ with public interface > * Added comment about magic numbers and structs from Stefan Hajnoczi > * Reintroduced old interface for process, run and Analyzer > * Added comm

Re: [PULL 0/7] NBD patches through 2023-09-25

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v4 13/14] MAINTAINERS: add maintainer of simpletrace.py

On Tue, Sep 26, 2023, 06:27 Mads Ynddal wrote: > > > You're welcome to be the maintainer. I haven't touched it in years. > > > > When you have reviewed future simpletrace.py patches you can either post > > your Reviewed-by and I'll include them in my tracing pull requests, or > > you could send p

Re: [PATCH v3 0/5] vhost-user: Back-end state migration

On Fri, Sep 15, 2023 at 12:25:25PM +0200, Hanna Czenczek wrote: > RFC: > https://lists.nongnu.org/archive/html/qemu-devel/2023-03/msg04263.html > > v1: > https://lists.nongnu.org/archive/html/qemu-devel/2023-04/msg01575.html > > v2: > https://lists.nongnu.org/archive/html/qemu-devel/2023-07/msg02

Re: [PATCH v3 5/5] vhost-user-fs: Implement internal migration

erations to transfer migratory > state. It is its own dedicated subsection, so that for external > migration, it can be disabled. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Hanna Czenczek > --- > hw/virtio/vhost-user-fs.c | 101

Re: [PATCH v3 4/5] vhost: Add high-level state save/load functions

virtio/vhost.h | 35 +++ > hw/virtio/vhost.c | 204 ++ > 2 files changed, 239 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH v3 3/5] vhost-user: Interface for migration state transfer

++ > include/hw/virtio/vhost.h | 79 > hw/virtio/vhost-user.c| 148 ++ > hw/virtio/vhost.c | 37 > 4 files changed, 288 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH v3 2/5] vhost-user.rst: Clarify enabling/disabling vrings

On Fri, Sep 15, 2023 at 12:25:27PM +0200, Hanna Czenczek wrote: > Currently, the vhost-user documentation says that rings are to be > initialized in a disabled state when VHOST_USER_F_PROTOCOL_FEATURES is > negotiated. However, by the time of feature negotiation, all rings have > already been init

Re: [PATCH v3 1/5] vhost-user.rst: Migrating back-end-internal state

deserialization). > > Signed-off-by: Hanna Czenczek > --- > docs/interop/vhost-user.rst | 170 ++++ > 1 file changed, 170 insertions(+) Great documentation! Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH] virtio: use shadow_avail_idx while checking number of heads

On Mon, 25 Sept 2023 at 11:36, Ilya Maximets wrote: > > On 9/25/23 17:12, Stefan Hajnoczi wrote: > > On Mon, 25 Sept 2023 at 11:02, Ilya Maximets wrote: > >> > >> On 9/25/23 16:23, Stefan Hajnoczi wrote: > >>> On Fri, 25 Aug 2023 at 13:04, Ilya Maximet

Re: [PULL 0/7] qtest and misc patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/30] target-arm queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 0/9] i386, audio changes for 2023-09-22

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] virtio: use shadow_avail_idx while checking number of heads

On Mon, 25 Sept 2023 at 11:02, Ilya Maximets wrote: > > On 9/25/23 16:23, Stefan Hajnoczi wrote: > > On Fri, 25 Aug 2023 at 13:04, Ilya Maximets wrote: > >> > >> We do not need the most up to date number of heads, we only want to > >> know if there is at l

Re: [PATCH] virtio: remove unnecessary thread fence while reading next descriptor

On Fri, 25 Aug 2023 at 13:02, Ilya Maximets wrote: > > It was supposed to be a compiler barrier and it was a compiler barrier > initially called 'wmb' (??) when virtio core support was introduced. > Later all the instances of 'wmb' were switched to smp_wmb to fix memory > ordering issues on non-x8

Re: [PATCH] virtio: use shadow_avail_idx while checking number of heads

On Fri, 25 Aug 2023 at 13:04, Ilya Maximets wrote: > > We do not need the most up to date number of heads, we only want to > know if there is at least one. > > Use shadow variable as long as it is not equal to the last available > index checked. This avoids expensive qatomic dereference of the >

Re: [PATCH v2] virtio: don't zero out memory region cache for indirect descriptors

On Mon, 25 Sept 2023 at 07:18, Ilya Maximets wrote: > > On 8/11/23 16:34, Ilya Maximets wrote: > > Lots of virtio functions that are on a hot path in data transmission > > are initializing indirect descriptor cache at the point of stack > > allocation. It's a 112 byte structure that is getting ze

Re: [PULL 00/17] Trivial patches for 2023-09-21

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 00/22] implement discard operation for Parallels images

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 00/28] Block layer patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v3 0/9] testing updates (back to green!)

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v2 07/10] virtiofsd: Use qemu_get_runtime_dir()

On Thu, Nov 10, 2022 at 07:06:26PM +0900, Akihiko Odaki wrote: > qemu_get_runtime_dir() is used to construct the path to a lock file. > > Signed-off-by: Akihiko Odaki > --- > tools/virtiofsd/fuse_virtio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/virti

Re: [PATCH v4 00/14] simpletrace: refactor and general improvements

if it isn't needed. > > v4: > * Added missing Analyzer2 to __all__ > * Rebased with master > v3: > * Added __all__ with public interface > * Added comment about magic numbers and structs from Stefan Hajnoczi > * Reintroduced old interface for process, run and An

Re: [PATCH v4 14/14] scripts/analyse-locks-simpletrace.py: changed iteritems() to items()

lyse-locks-simpletrace.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

<    3   4   5   6   7   8   9   10   11   12   >