On Wed, Sep 13, 2023 at 11:08:54AM -0500, Eric Blake wrote:
> On Tue, Sep 12, 2023 at 07:10:34PM -0400, Stefan Hajnoczi wrote:
> > This patch fixes a race condition in test-bdrv-drain that is difficult
> > to reproduce. test-bdrv-drain sometimes fails without an error message
> &
On Mon, Aug 28, 2023 at 11:09:54PM +0800, Sam Li wrote:
> By adding zone operations and zoned metadata, the zoned emulation
> capability enables full emulation support of zoned device using
> a qcow2 file. The zoned device metadata includes zone type,
> zoned device state and write pointer of each
On Mon, Aug 28, 2023 at 11:09:53PM +0800, Sam Li wrote:
> To configure the zoned format feature on the qcow2 driver, it
> requires following arguments: the device size, zoned profile,
> zone model, zone size, zone capacity, number of conventional
> zones, limits on zone resources (max append
-by: Philippe Mathieu-Daudé
Reviewed-by: Paul Durrant
Signed-off-by: Stefan Hajnoczi
---
include/sysemu/block-backend-io.h | 6 +-
block/blkio.c | 8 +--
block/io_uring.c | 4 +-
block/linux-aio.c | 4 +-
block/nvme.c
-playbooks/-/tree/blk_io_plug-irqfd
This duplicates the BH that virtio-blk uses for batching. The next
commit will remove it.
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
block/io_uring.c | 6 ++
block/linux-aio.c | 4
hw/virtio/virtio.c | 13
are available here:
https://gitlab.com/stefanha/virt-playbooks/-/tree/blk_io_plug-irqfd
Stefan Hajnoczi (4):
block: rename blk_io_plug_call() API to defer_call()
util/defer-call: move defer_call() to util/
virtio: use defer_call() in virtio_irqfd_notify()
virtio-blk: remove batch notification BH
. Modern drivers
enable EVENT_IDX.
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
hw/block/dataplane/virtio-blk.c | 48 +
1 file changed, 1 insertion(+), 47 deletions(-)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index
c, my_obj); <-- another
...
defer_call_end(); <-- end of section, my_func(my_obj) is called once
Suggested-by: Ilya Maximets
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Stefan Hajnoczi
---
MAINTAINERS | 3 ++-
include/qemu/defer-call.h | 16 ++
On Wed, 13 Sept 2023 at 15:44, Fabiano Rosas wrote:
>
> Stefan Hajnoczi writes:
>
> > Hi,
> > The following intermittent failure occurred in the CI and I have filed
> > an Issue for it:
> > https://gitlab.com/qemu-project/qemu/-/issues/1886
> >
> > Ou
On Fri, Aug 18, 2023 at 10:31:40AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
>
> On 17/8/23 17:58, Stefan Hajnoczi wrote:
> > The networking subsystem may wish to use defer_call(), so move the code
> > to util/ where it can be reused.
> >
> > As a r
Hi,
The following intermittent failure occurred in the CI and I have filed
an Issue for it:
https://gitlab.com/qemu-project/qemu/-/issues/1886
Output:
>>> QTEST_QEMU_IMG=./qemu-img MALLOC_PERTURB_=116
QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Oops, I forgot to CC qemu-devel.
On Wed, 13 Sept 2023 at 15:06, Stefan Hajnoczi wrote:
>
> I can't start a qemu.git build with a GTK UI but -display vnc=:0 works:
>
> $ ./configure --target-list=x86_64-softmmu
> $ build/qemu-system-x86_64
> qemu-system-x86_64: .
On Wed, 13 Sept 2023 at 04:13, Michael Tokarev wrote:
>
> [Added some more active patch reviewers to Cc]
>
> Hi!
>
> Yesterday I wrote email about picking up changes from master
> for previous stable release(s). What's interesting is that
> yesterday, basically in a single day, we've faced
On Wed, Sep 13, 2023, 03:26 Michael Tokarev wrote:
> 13.09.2023 02:07, Stefan Hajnoczi wrote:
> > Hi,
> > TL;DR Michael: Please check that the staging-7.2 branch has Dan's
> > commit e28112d00703abd136e2411d23931f4f891c9244 ("gitlab: stable
> > staging branches
its blk_aio_cancel() caller, and poll the main loop AioContext.
The purpose of this cleanup is to identify bdrv_aio_cancel() as an API
that does not work with the multi-queue block layer.
Signed-off-by: Stefan Hajnoczi
---
include/block/aio.h| 1 -
include/block/block-global
Process zoned requests in the current thread's AioContext instead of in
the BlockBackend's AioContext.
There is no need to use the BlockBackend's AioContext thanks to CoMutex
bs->wps->colock, which protects zone metadata.
Signed-off-by: Stefan Hajnoczi
---
block/block-backend.
ead in addition to the IOThread:
https://lore.kernel.org/qemu-devel/20230823234504.1387239-1-stefa...@redhat.com/T/#t
Based-on: 20230823234504.1387239-1-stefa...@redhat.com
Stefan Hajnoczi (5):
block: remove AIOCBInfo->get_aio_context()
test-bdrv-drain: avoid race with BH in IOThread drain test
drain
mechanism has failed in quiescing I/O.
Fix this by incrementing the in_flight counter so that do_drain_begin()
waits for test_iothread_main_thread_bh().
Signed-off-by: Stefan Hajnoczi
---
tests/unit/test-bdrv-drain.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/unit
is only called with the BQL held
from the main loop thread.
The output of qemu-iotests 051 is sensitive to event loop activity.
Update the output because the monitor BH runs at a different time,
causing prompts to be printed differently in the output.
Signed-off-by: Stefan Hajnoczi
---
scripts
accessed by the
completion callback.
- The remaining emulated devices and exports run with
qemu_get_aio_context() == blk_get_aio_context().
Signed-off-by: Stefan Hajnoczi
---
block/block-backend.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/block-backend.c b
Hi,
TL;DR Michael: Please check that the staging-7.2 branch has Dan's
commit e28112d00703abd136e2411d23931f4f891c9244 ("gitlab: stable
staging branches publish containers in a separate tag").
I couldn't explain a check-cfi-x86_64 failure
(https://gitlab.com/qemu-project/qemu/-/jobs/5072006964),
On Fri, Sep 01, 2023 at 07:01:37PM +0200, Kevin Wolf wrote:
> Am 24.08.2023 um 01:59 hat Stefan Hajnoczi geschrieben:
> > Use qemu_get_current_aio_context() in mixed wrappers and coroutine
> > wrappers so that code runs in the caller's AioContext instead of moving
> > to t
ing
>
> .gitlab-ci.d/cirrus.yml | 4 +++-
> .gitlab-ci.d/cirrus/build.yml | 2 ++
> tests/qtest/libqtest.c| 7 +++
> tests/qtest/microbit-test.c | 2 ++
> 4 files changed, 14 insertions(+), 1 deletion(-)
Thank you!
Reviewed-by: Stefan Hajnoczi
On Tue, 12 Sept 2023 at 14:36, Alex Bennée wrote:
>
>
> Stefan Hajnoczi writes:
>
> > On Tue, Sep 12, 2023, 12:14 Daniel P. Berrangé wrote:
> >
> > On Tue, Sep 12, 2023 at 05:01:26PM +0100, Alex Bennée wrote:
> > >
> > > Daniel P. Berrangé wr
On Tue, 12 Sept 2023 at 12:47, Kevin Wolf wrote:
>
> Am 06.09.2023 um 21:01 hat Stefan Hajnoczi geschrieben:
> > It is not safe to call drain_call_rcu() from qmp_device_add() because
> > some call stacks are not prepared for drain_call_rcu() to drop the Big
On Tue, 12 Sept 2023 at 12:37, Kevin Wolf wrote:
>
> Am 06.09.2023 um 21:01 hat Stefan Hajnoczi geschrieben:
> > call_drain_rcu() has limitations that make it unsuitable for use in
> > qmp_device_add().
>
> This sounds a bit vague with only alluding to some unnamed
23 +-
> blockjob.c | 2 +
> tests/unit/test-bdrv-drain.c| 23 +-
> tests/unit/test-bdrv-graph-mod.c| 20 ++
> tests/unit/test-block-iothread.c| 3 +
> scripts/block-coroutine-wrapper.py | 18 +-
> tests/qemu-iotests/051.pc.out | 6 +-
> 27 files changed, 591 insertions(+), 227 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Mon, Sep 11, 2023 at 11:46:17AM +0200, Kevin Wolf wrote:
> The function reads the parents list, so it needs to hold the graph lock.
>
> Signed-off-by: Kevin Wolf
> Reviewed-by: Emanuele Giuseppe Esposito
> ---
> block.c | 4
> 1 file changed, 4 insertions(+)
On Mon, Sep 11, 2023 at 11:46:16AM +0200, Kevin Wolf wrote:
> The function reads the parents list, so it needs to hold the graph lock.
>
> Signed-off-by: Kevin Wolf
> Reviewed-by: Emanuele Giuseppe Esposito
> ---
> block.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewe
> Signed-off-by: Kevin Wolf
> ---
> include/block/block-global-state.h | 1 +
> block.c| 17 +
> block/graph-lock.c | 26 +++---
> tests/qemu-iotests/051.pc.out | 6 +++---
> 4 files changed, 40 insertions(+), 10 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Tue, Sep 12, 2023, 12:14 Daniel P. Berrangé wrote:
> On Tue, Sep 12, 2023 at 05:01:26PM +0100, Alex Bennée wrote:
> >
> > Daniel P. Berrangé writes:
> >
> > > On Tue, Sep 12, 2023 at 11:06:11AM -0400, Stefan Hajnoczi wrote:
> > >> The av
as they are passing.
Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1884
Signed-off-by: Stefan Hajnoczi
---
.gitlab-ci.d/buildtest.yml | 27 ---
1 file changed, 27 deletions(-)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index aee9101507
Thank you!
Stefan
On Tue, 12 Sept 2023 at 10:15, Daniel P. Berrangé wrote:
>
> On Tue, Sep 12, 2023 at 10:02:17AM -0400, Stefan Hajnoczi wrote:
> > On Tue, 12 Sept 2023 at 09:53, Daniel P. Berrangé
> > wrote:
> > >
> > > On Tue, Sep 12, 2023 at 09:
On Tue, 12 Sept 2023 at 10:08, Laurent Vivier wrote:
>
> On 9/12/23 15:42, Daniel P. Berrangé wrote:
> > On Tue, Sep 12, 2023 at 09:33:10AM -0400, Stefan Hajnoczi wrote:
> >> The test still fails intermittently with a 60 second timeout in the
> >> GitLab CI environment. Ra
On Tue, 12 Sept 2023 at 09:53, Daniel P. Berrangé wrote:
>
> On Tue, Sep 12, 2023 at 09:38:29AM -0400, Stefan Hajnoczi wrote:
> > The 80m timeout is not enough:
> >
> > 672/832 qemu:block / io-qcow2-041 OK 39.77s 1
> > subtests pa
When I backport patches into RHEL, the general process I follow is:
1. For context conflicts, just adjust the patch to resolve them.
2. For real dependencies, backport the dependencies, if possible.
3. If backporting the dependencies is not possible, think of a
downstream-only solution. This
rease timeout to 80 minutes")
Signed-off-by: Stefan Hajnoczi
---
.gitlab-ci.d/cirrus.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml
index 41d64d6680..d19633f758 100644
--- a/.gitlab-ci.d/cirrus.yml
+++ b/.gitlab-ci.d/
tdev-socket.UW5IA2/stream_unix\r\n")
(test program exited with status code -6)
Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1881
Fixes: 417296c8d858 ("tests/qtest/netdev-socket: Raise connection timeout to 60
seconds")
Signed-off-by: Stefan Hajnoczi
---
tests/qtest/netdev-
On Tue, 12 Sept 2023 at 06:55, Gerd Hoffmann wrote:
>
> The following changes since commit c5ea91da443b458352c1b629b490ee6631775cb4:
>
> Merge tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu into
> staging (2023-09-08 10:06:25 -0400)
>
> are available in the Git repository at:
>
>
On Tue, 12 Sept 2023 at 02:19, Philippe Mathieu-Daudé wrote:
>
> On 11/9/23 23:54, Stefan Hajnoczi wrote:
> > gcc 13.2.1 emits the following warning:
> >
> >net/vhost-vdpa.c: In function ‘net_vhost_vdpa_init.constprop’:
> >net/vhost-vdpa.c:1394:25: err
ted;
| ^~
net/vhost-vdpa.c:1355:9: note: ‘cvq_isolated’ was declared here
1355 | int cvq_isolated;
| ^~~~
cc1: all warnings being treated as errors
Cc: Eugenio Pérez
Cc: Michael S. Tsirkin
Cc: Jason Wang
Signed-off-by: Stefan Hajnoczi
---
net/vhost-vdp
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Mon, 11 Sept 2023 at 09:38, Daniel Henrique Barboza
wrote:
>
> Hi Stefan,
>
> On 9/8/23 08:06, Stefan Hajnoczi wrote:
> > Hi Alistair,
> > Please take a look at the following CI failure:
> >
> > https://gitlab.com/qemu-project/qemu/-/jobs/5045998521
Or instead of using linker behavior, maybe just change the #ifdef so it
only applies when KVM is disabled. I didn't look at the code to see if this
is possible, but it would be nice to avoid the very specific #ifdef
condition in this patch.
Stefan
On Mon, Sep 11, 2023, 07:15 Stefan Hajnoczi
DMSRHandler *rdmsr,
> QEMUWRMSRHandler *wrmsr);
>
> +#elif defined(__clang__) && !defined(__OPTIMIZE__)
Another approach is a static library with a .o file containing the
stubs so the linker only includes it in the executable if the compiler
emitted the symbols. That way there is no need for defined(__clang__)
&& !defined(__OPTIMIZE__) and it will work with other
compilers/optimization levels. It's more work to set up though.
Reviewed-by: Stefan Hajnoczi
On Mon, 11 Sept 2023 at 06:10, Philippe Mathieu-Daudé wrote:
>
> On 8/9/23 17:47, Stefan Hajnoczi wrote:
> > I wonder how it passed CI?
> > https://gitlab.com/qemu-project/qemu/-/pipelines/996175923/
>
> The conditions are:
> - x86 host
> - both system / user emul
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
I wonder how it passed CI?
https://gitlab.com/qemu-project/qemu/-/pipelines/996175923/
Stefan
On Fri, 8 Sept 2023 at 11:02, Kevin Wolf wrote:
>
> Am 07.09.2023 um 17:44 hat Stefan Hajnoczi geschrieben:
> > Applied, thanks.
> >
> > Please update the changelog at https:/
On Fri, Sep 08, 2023 at 01:03:26PM +0100, Alex Bennée wrote:
>
> Stefan Hajnoczi writes:
>
> > On Fri, Sep 01, 2023 at 12:00:18PM +0100, Alex Bennée wrote:
> >> Currently QEMU has to know some details about the VirtIO device
> >> supported by a vhost-user dae
consume resources. I
don't see the need to try to add a special message to vhost-user to
try to reduce the number of virtqueues.
Stefan
On Fri, 8 Sept 2023 at 08:03, Alex Bennée wrote:
>
>
> Stefan Hajnoczi writes:
>
> > On Fri, 8 Sept 2023 at 02:43, Alex Bennée wrote:
>
Hi Ilya and Jason,
There is a CI failure related to a missing Debian libxdp-dev package:
https://gitlab.com/qemu-project/qemu/-/jobs/5046139967
I think the issue is that the debian-amd64 container image that QEMU
uses for testing is based on Debian 11 ("bullseye" aka "oldstable")
and libxdp is
Hi Alistair,
Please take a look at the following CI failure:
https://gitlab.com/qemu-project/qemu/-/jobs/5045998521
/usr/bin/ld: libqemu-riscv64-softmmu.fa.p/target_riscv_cpu.c.o: in
function `riscv_cpu_add_kvm_properties':
Please resolve the following CI failure:
https://gitlab.com/qemu-project/qemu/-/jobs/5045998355
ninja: job failed: cc -m64 -mcx16 -Iqemu-nbd.p -I. -I.. -Iqapi -Itrace
-Iui -Iui/shader -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -fdiagnostics-color=auto -Wall
On Thu, Sep 07, 2023 at 03:41:08PM -0500, Eric Blake wrote:
> On Wed, Aug 30, 2023 at 06:48:02PM -0400, Stefan Hajnoczi wrote:
> > The ongoing QEMU multi-queue block layer effort makes it possible for
> > multiple
> > threads to process I/O in parallel. The nbd block dri
virtio: Drop out of coroutine context in virtio_load()
>
> include/migration/vmstate.h | 8 ---
> hw/virtio/virtio.c | 45 -
> 2 files changed, 45 insertions(+), 8 deletions(-)
>
> --
> 2.41.0
>
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Fri, Sep 08, 2023 at 10:59:48AM +0200, Kevin Wolf wrote:
> Am 07.09.2023 um 20:40 hat Stefan Hajnoczi geschrieben:
> > On Tue, Sep 05, 2023 at 04:50:02PM +0200, Kevin Wolf wrote:
> > > virtio_load() as a whole should run in coroutine context because it
> > > read
On Fri, 8 Sept 2023 at 02:43, Alex Bennée wrote:
>
>
> Stefan Hajnoczi writes:
>
> > On Tue, Sep 05, 2023 at 10:34:11AM +0100, Alex Bennée wrote:
> >>
> >> Albert Esteve writes:
> >>
> >> > This looks great! Thanks for this proposal.
On Thu, 7 Sept 2023 at 16:53, Dr. David Alan Gilbert wrote:
>
> * Stefan Hajnoczi (stefa...@gmail.com) wrote:
> > On Thu, 7 Sept 2023 at 10:07, Dr. David Alan Gilbert
> > wrote:
> > >
> > > * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > > &
On Tue, Sep 05, 2023 at 10:34:11AM +0100, Alex Bennée wrote:
>
> Albert Esteve writes:
>
> > This looks great! Thanks for this proposal.
> >
> > On Fri, Sep 1, 2023 at 1:00 PM Alex Bennée wrote:
> >
> > Currently QEMU has to know some details about the VirtIO device
> > supported by a
On Fri, Sep 01, 2023 at 12:00:18PM +0100, Alex Bennée wrote:
> Currently QEMU has to know some details about the VirtIO device
> supported by a vhost-user daemon to be able to setup the guest. This
> makes it hard for QEMU to add support for additional vhost-user
> daemons without adding specific
On Tue, Sep 05, 2023 at 04:50:00PM +0200, Kevin Wolf wrote:
> This fixes a recently introduced assertion failure that was reported to
> happen when migrating virtio-net with a failover. The latent bug that
> we're executing code in coroutine context that was never supposed to run
> there has
_main ()
> #25 0x560aeb9d45e1 in qemu_loadvm_state ()
> #26 0x560aeb9bc32c in process_incoming_migration_co.llvm ()
> #27 0x560aebeace56 in coroutine_trampoline.llvm ()
>
> Cc: qemu-sta...@nongnu.org
> Buglink: https://issues.redhat.com/browse/RHEL-832
> Signed-off-by: Kevin Wolf
> ---
> hw/virtio/virtio.c | 45 -
> 1 file changed, 40 insertions(+), 5 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
From: Jeuk Kim
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
Message-id
From: Jeuk Kim
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
Message-id
From: Jeuk Kim
This patch includes the following tests
Test mmio read
Test ufs device initialization and ufs-lu recognition
Test I/O (Performs a write followed by a read to verify)
Signed-off-by: Jeuk Kim
Acked-by: Thomas Huth
Reviewed-by: Stefan Hajnoczi
Message-id
The following changes since commit 03a3a62fbd0aa5227e978eef3c67d3978aec9e5f:
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging
(2023-09-07 10:29:06 -0400)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to
to handle UFS logical unit and Transfer Request will follow.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
Message-id:
10232660d462ee5cd10cf673f1a9a1205fc8276c.1693980783.git.jeuk20@gmail.com
Signed-off-by: Stefan Hajnoczi
---
MAINTAINERS |6 +
docs/specs/pci-ids.rst
Signed-off-by: Stefan Hajnoczi
---
iothread.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/iothread.c b/iothread.c
index b41c305bd9..b753286414 100644
--- a/iothread.c
+++ b/iothread.c
@@ -138,12 +138,14 @@ static void iothread_instance_finalize(Object *obj
On Wed, 6 Sept 2023 at 03:45, Jeuk Kim wrote:
>
> Since v9:
> - Added the "UFS_" prefix to all define and enum defined in block/ufs.h.
> This fixes
> https://gitlab.com/qemu-project/qemu/-/jobs/4977255992
> which is a win32 build error.
>
> - Fixed not to use pointer type casting (uint32_t * ->
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Thu, 7 Sept 2023 at 10:07, Dr. David Alan Gilbert wrote:
>
> * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > On Thu, Sep 07, 2023 at 01:06:39AM +, Dr. David Alan Gilbert wrote:
> > > * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > > > Cor
On Thu, 7 Sept 2023 at 10:26, Paolo Bonzini wrote:
>
> On Thu, Sep 7, 2023 at 4:00 PM Stefan Hajnoczi wrote:
> > While I agree that the issue would not happen if monitor commands only
> > ran in the iohandler AioContext, I don't think we can change that.
> > When Kev
On Thu, Sep 07, 2023 at 01:06:39AM +, Dr. David Alan Gilbert wrote:
> * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > Coroutine HMP commands currently run to completion in a nested event
> > loop with the Big QEMU Lock (BQL) held. The call_rcu thread also uses
> > the B
On Thu, Sep 07, 2023 at 01:28:55PM +0200, Paolo Bonzini wrote:
> On 9/6/23 21:01, Stefan Hajnoczi wrote:
> > It is not safe to call drain_call_rcu() from qmp_device_add() because
> > some call stacks are not prepared for drain_call_rcu() to drop the Big
> > QEMU Lock (BQL).
On Mon, Aug 28, 2023 at 11:09:52PM +0800, Sam Li wrote:
> Add the specs for the zoned format feature of the qcow2 driver.
> The qcow2 file can be taken as zoned device and passed through by
> virtio-blk device or NVMe ZNS device to the guest given zoned
> information.
>
> Signed-off-by: Sam Li
>
to finish.
This patch refactors the HMP monitor to use the existing event loop
instead of creating a nested event loop. This will allow the next
patches to rely on draining call_rcu work.
Signed-off-by: Stefan Hajnoczi
---
monitor/hmp.c | 28 +++-
1 file changed, 15 insertions
call_drain_rcu() has limitations that make it unsuitable for use in
qmp_device_add(). Introduce a new coroutine version of drain_call_rcu()
with the same functionality but that does not drop the BQL. The next
patch will use it to fix qmp_device_add().
Signed-off-by: Stefan Hajnoczi
coroutine.
Fixes: 7bed89958bfbf40df9ca681cefbdca63abdde39d ("device_core: use
drain_call_rcu in in qmp_device_add")
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2215192
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2214985
Signed-off-by: Stefan Hajnoczi
---
qapi/qdev.json
evice_add() into a coroutine monitor command and uses
drain_call_rcu_co().
I'm sending this as an RFC because I don't have confirmation yet that the bugs
mentioned above are fixed by this patch series.
Stefan Hajnoczi (3):
hmp: avoid the nested event loop in handle_hmp_command()
rcu: add drain_call_rcu_co()
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
; qemu-img: Update documentation for compressed images
>
> Michael Tokarev (1):
> qemu-img: omit errno value in error message
>
> Peter Maydell (1):
> block/iscsi: Document why we use raw malloc()
>
> Philippe Mathieu-Daudé (1):
> block/vpc: A
On Wed, 6 Sept 2023 at 09:07, Hao Xu wrote:
> On 5/18/23 00:26, Stefan Hajnoczi wrote:
> > On Wed, 17 May 2023 at 11:54, Alex Bennée wrote:
> > Hi Alex,
> > There were two unresolved issues:
> >
> > 1. How to inject SIGBUS when the guest accesses a page that's b
On Fri, 1 Sept 2023 at 04:18, Hanna Czenczek wrote:
>
> The following changes since commit f5fe7c17ac4e309e47e78f0f9761aebc8d2f2c81:
>
> Merge tag 'pull-tcg-20230823-2' of https://gitlab.com/rth7680/qemu into
> staging (2023-08-28 16:07:04 -0400)
>
> are available in the Git repository at:
>
>
On Tue, 5 Sept 2023 at 16:57, Stefan Hajnoczi wrote:
>
> On Tue, Sep 05, 2023 at 03:03:59PM -0300, Fabiano Rosas wrote:
> > Having a name in the source helps with debugging core dumps when one
> > might not have access to TLS data to cross-reference AioContexts with
&
On Tue, Sep 05, 2023 at 03:03:59PM -0300, Fabiano Rosas wrote:
> Having a name in the source helps with debugging core dumps when one
> might not have access to TLS data to cross-reference AioContexts with
> their addresses.
>
> Signed-off-by: Fabiano Rosas
> ---
> v3:
> used const
> v2:
> used
On Tue, 5 Sept 2023 at 12:51, Philippe Mathieu-Daudé wrote:
>
> On 5/9/23 17:45, Peter Xu wrote:
> > On Mon, Sep 04, 2023 at 11:48:11AM -0300, Fabiano Rosas wrote:
> >> @@ -189,11 +193,14 @@ static void iothread_init(EventLoopBase *base, Error
> >> **errp)
> >> return;
> >> }
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
801 - 900 of 27226 matches
Mail list logo