[PULL v4 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure

2023-06-09 Thread Stefano Stabellini
From: Stefano Stabellini On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails continue to the PV backends initialization. Also, moved the IOREQ registration and mapping subroutine to new function

[PULL v4 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2023-06-09 Thread Stefano Stabellini
From: Stefano Stabellini From: Stefano Stabellini This is done to prepare for enabling xenpv support for ARM architecture. On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails, continue to the PV backends

[PULL v4 09/10] hw/arm: introduce xenpvh machine

2023-06-09 Thread Stefano Stabellini
tpm2/swtpm-sock & Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini --- docs/system/arm/xenpvh.rst| 34 +++ docs/system/target-arm.rst| 1 + hw/arm/meson.build| 2 + hw/arm/xen_arm.c

[PULL v4 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets

2023-06-09 Thread Stefano Stabellini
From: Stefano Stabellini have_xen_pci_passthrough is only used for Xen x86 VMs. Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 34306a6205..481865bfa9 100644 --- a/meson.build

[PULL v4 07/10] hw/xen/xen-hvm-common: Use g_new and error_report

2023-06-09 Thread Stefano Stabellini
From: Vikram Garhwal Replace g_malloc with g_new and perror with error_report. Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/xen/xen-hvm-common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen-hvm

[PULL v4 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-06-09 Thread Stefano Stabellini
From: Stefano Stabellini This patch does following: 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in preparation for moving most of xen-hvm code to an arch-neutral location, move the x86-specific portion of xen_set_memory to arch_xen_set_memory. Also, move

[PULL v4 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2023-06-09 Thread Stefano Stabellini
From: Vikram Garhwal xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed

[PULL v4 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

2023-06-09 Thread Stefano Stabellini
From: Stefano Stabellini In preparation to moving most of xen-hvm code to an arch-neutral location, move: - shared_vmport_page - log_for_dirtybit - dirty_bitmap - suspend - wakeup out of XenIOState struct as these are only used on x86, especially the ones related to dirty logging. Updated

[PULL v4 0/10] xenpvh4-tag

2023-06-09 Thread Stefano Stabellini
changes up to 236c27fd61dd0961631076a56286dd108fe5ef1f: meson.build: enable xenpv machine build for ARM (2023-06-08 16:54:31 -0700) Stefano Stabellini (5): hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

Re: [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE

2023-06-08 Thread Stefano Stabellini
On Thu, 8 Jun 2023, Stefano Stabellini wrote: > On Mon, 5 Jun 2023, Bernhard Beschow wrote: > > Am 22. Mai 2023 15:42:03 UTC schrieb Bernhard Beschow : > > > > > > > > >Am 15. Mai 2023 20:52:40 UTC schrieb Stefano Stabellini > > >: > > >>O

Re: [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE

2023-06-08 Thread Stefano Stabellini
On Mon, 5 Jun 2023, Bernhard Beschow wrote: > Am 22. Mai 2023 15:42:03 UTC schrieb Bernhard Beschow : > > > > > >Am 15. Mai 2023 20:52:40 UTC schrieb Stefano Stabellini > >: > >>On Sat, 13 May 2023, Bernhard Beschow wrote: > >>> Am 21. Apr

Re: [PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator

2023-05-17 Thread Stefano Stabellini
On Wed, 17 May 2023, Michael Tokarev wrote: > 17.05.2023 12:47, Chuck Zmudzinski wrote: > > On 5/17/2023 2:39 AM, Michael Tokarev wrote: > > > 08.02.2023 05:03, Chuck Zmudzinski wrote:... > > > > Fixes: 998250e97661 ("xen, gfx passthrough: register host bridge > > > > specific to passthrough") > >

Re: [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE

2023-05-15 Thread Stefano Stabellini
On Sat, 13 May 2023, Bernhard Beschow wrote: > Am 21. April 2023 07:38:10 UTC schrieb "Michael S. Tsirkin" : > >On Mon, Apr 03, 2023 at 09:41:17AM +0200, Bernhard Beschow wrote: > >> There is currently a dedicated PIIX3 device model for use under Xen. By > >> reusing > >> existing PCI API during

Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs

2023-05-12 Thread Stefano Stabellini
On Wed, 10 May 2023, Olaf Hering wrote: > Wed, 10 May 2023 00:58:27 +0200 Olaf Hering : > > > In my debugging (with v8.0.0) it turned out the three pci_set_word > > causes the domU to hang. In fact, it is just the last one: > > > >pci_set_byte(pci_conf + 0x20, 0x01); /* BMIBA: 20-23h */ > >

Re: [PATCH 0/1] Updated: Ensure PV ring is drained on disconenct

2023-05-05 Thread Stefano Stabellini
On Thu, 20 Apr 2023, Mark Syms wrote: > Updated patch to address intermittent SIGSEGV on domain disconnect/shutdown. > > Mark Syms (1): > Ensure the PV ring is drained on disconnect > > hw/block/dataplane/xen-block.c | 31 +-- > 1 file changed, 25 insertions(+), 6

Re: [PATCH] 9pfs/xen: Fix segfault on shutdown

2023-05-05 Thread Stefano Stabellini
LL) { > qemu_bh_delete(xen_9pdev->rings[i].bh); > +xen_9pdev->rings[i].bh = NULL; > } > } > > g_free(xen_9pdev->id); > +xen_9pdev->id = NULL; > g_free(xen_9pdev->tag); > +xen_9pdev->tag = NULL; &

[PULL v3 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-05-02 Thread Stefano Stabellini
From: Stefano Stabellini This patch does following: 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in preparation for moving most of xen-hvm code to an arch-neutral location, move the x86-specific portion of xen_set_memory to arch_xen_set_memory. Also, move

[PULL v3 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2023-05-02 Thread Stefano Stabellini
From: Stefano Stabellini This is done to prepare for enabling xenpv support for ARM architecture. On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails, continue to the PV backends initialization. Signed-off

[PULL v3 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

2023-05-02 Thread Stefano Stabellini
From: Stefano Stabellini In preparation to moving most of xen-hvm code to an arch-neutral location, move: - shared_vmport_page - log_for_dirtybit - dirty_bitmap - suspend - wakeup out of XenIOState struct as these are only used on x86, especially the ones related to dirty logging. Updated

[PULL v3 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets

2023-05-02 Thread Stefano Stabellini
From: Stefano Stabellini have_xen_pci_passthrough is only used for Xen x86 VMs. Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 77d42898c8..000ef06bfa 100644 --- a/meson.build

[PULL v3 09/10] hw/arm: introduce xenpvh machine

2023-05-02 Thread Stefano Stabellini
tpm2/swtpm-sock & Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini --- docs/system/arm/xenpvh.rst| 34 +++ docs/system/target-arm.rst| 1 + hw/arm/meson.build| 2 + hw/arm/xen_arm.c

[PULL v3 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure

2023-05-02 Thread Stefano Stabellini
From: Stefano Stabellini On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails continue to the PV backends initialization. Also, moved the IOREQ registration and mapping subroutine to new function

[PULL v3 10/10] meson.build: enable xenpv machine build for ARM

2023-05-02 Thread Stefano Stabellini
From: Vikram Garhwal Add CONFIG_XEN for aarch64 device to support build for ARM targets. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build

[PULL v3 07/10] hw/xen/xen-hvm-common: Use g_new and error_report

2023-05-02 Thread Stefano Stabellini
From: Vikram Garhwal Replace g_malloc with g_new and perror with error_report. Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/xen/xen-hvm-common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen-hvm

[PULL v3 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2023-05-02 Thread Stefano Stabellini
From: Vikram Garhwal xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed

[PULL v3 0/10] xenpvh3-tag

2023-05-02 Thread Stefano Stabellini
for you to fetch changes up to bc618c54318cbc2fcb9decf9d4c193cc336a0dbc: meson.build: enable xenpv machine build for ARM (2023-05-02 17:04:54 -0700) Stefano Stabellini (5): hw/i386/xen/xen-hvm: move x86-specific fields out

[PULL v3 02/10] hw/i386/xen: rearrange xen_hvm_init_pc

2023-05-02 Thread Stefano Stabellini
ioreq functions in one place which will be moved to new function in next patch in order to make it common to both x86 and aarch64 machines. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/i386/xen/xen-hvm.c | 49

Re: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes

2023-04-12 Thread Stefano Stabellini
On Wed, 11 Apr 2023, David Woodhouse wrote: > Some Coverity fixes and minor cleanups. And most notably, dropping > support for Xen libraries older than 4.7.1. I just wanted to say that I am fine with this

Re: Adding default config options to the tuxrun baseline kernels and enabling sshd

2023-03-24 Thread Stefano Stabellini
On Fri, 24 Mar 2023, David Woodhouse wrote: > On Fri, 2023-03-24 at 13:53 +0100, Remi Duraffort wrote: > > Le ven. 24 mars 2023 à 12:02, Alex Bennée a écrit : > > >   version: 1 > > >   name: Xen Guest Kernels > > >   description: Build Xen Test Kernels > > >   jobs: > > >   - builds: > > >      

Re: [RFC QEMU PATCH 13/18] hw/i386/xen/xen-hvm: Introduce xen_ram_block_check function

2023-03-17 Thread Stefano Stabellini
On Sun, 12 Mar 2023, Huang Rui wrote: > Introduce xen_ram_block_check function to check whether current ramblock > is xen ram memory. > > Signed-off-by: Huang Rui > --- > hw/i386/xen/xen-hvm.c | 15 +++ > include/hw/xen/xen.h | 1 + > 2 files changed, 16 insertions(+) > > diff

Re: [RFC QEMU PATCH 12/18] softmmu: Fix the size to map cache with xen for host virtual address

2023-03-17 Thread Stefano Stabellini
On Sun, 12 Mar 2023, Huang Rui wrote: > The xen_map_cache function wants to pass offset and size of this memory > block as the input parameters to map the host virtual address. However, > block->offset is too large as 0x1 (4G), if we assign the size as > block->max_length (0x11000),

Re: [PULL v2 0/10] xenpvh

2023-02-15 Thread Stefano Stabellini
On Wed, 15 Feb 2023, Fabiano Rosas wrote: > Peter Maydell writes: > > > On Tue, 14 Feb 2023 at 23:43, Stefano Stabellini > > wrote: > >> > >> The following changes since commit > >> 6a50f64ca01d0a7b97f14f069762bfd88160f31e: > >> > >&

Re: [PULL 00/10] xenpvh machine

2023-02-14 Thread Stefano Stabellini
On Tue, 14 Feb 2023, Peter Maydell wrote: > On Mon, 13 Feb 2023 at 22:34, Stefano Stabellini > wrote: > > > > On Mon, 13 Feb 2023, Peter Maydell wrote: > > > On Fri, 10 Feb 2023 at 22:27, Stefano Stabellini > > > wrote: > > >

[PULL v2 09/10] hw/arm: introduce xenpvh machine

2023-02-14 Thread Stefano Stabellini
tpm2/swtpm-sock & Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini --- docs/system/arm/xenpvh.rst| 34 +++ docs/system/target-arm.rst| 1 + hw/arm/meson.build| 2 + hw/arm/xen_arm.c

[PULL v2 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2023-02-14 Thread Stefano Stabellini
From: Stefano Stabellini This is done to prepare for enabling xenpv support for ARM architecture. On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails, continue to the PV backends initialization. Signed-off

[PULL v2 07/10] hw/xen/xen-hvm-common: Use g_new and error_report

2023-02-14 Thread Stefano Stabellini
From: Vikram Garhwal Replace g_malloc with g_new and perror with error_report. Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/xen/xen-hvm-common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen-hvm

[PULL v2 02/10] hw/i386/xen: rearrange xen_hvm_init_pc

2023-02-14 Thread Stefano Stabellini
ioreq functions in one place which will be moved to new function in next patch in order to make it common to both x86 and aarch64 machines. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/i386/xen/xen-hvm.c | 49

[PULL v2 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2023-02-14 Thread Stefano Stabellini
From: Vikram Garhwal xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed

[PULL v2 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-02-14 Thread Stefano Stabellini
From: Stefano Stabellini This patch does following: 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in preparation for moving most of xen-hvm code to an arch-neutral location, move the x86-specific portion of xen_set_memory to arch_xen_set_memory. Also, move

[PULL v2 10/10] meson.build: enable xenpv machine build for ARM

2023-02-14 Thread Stefano Stabellini
From: Vikram Garhwal Add CONFIG_XEN for aarch64 device to support build for ARM targets. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build

[PULL v2 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure

2023-02-14 Thread Stefano Stabellini
From: Stefano Stabellini On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails continue to the PV backends initialization. Also, moved the IOREQ registration and mapping subroutine to new function

[PULL v2 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets

2023-02-14 Thread Stefano Stabellini
From: Stefano Stabellini have_xen_pci_passthrough is only used for Xen x86 VMs. Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index a76c855312..8292cdcec5 100644 --- a/meson.build

[PULL v2 0/10] xenpvh

2023-02-14 Thread Stefano Stabellini
changes up to 86b01d58ca2840bea6e4e7260aad450a660fbd46: meson.build: enable xenpv machine build for ARM (2023-02-14 15:39:25 -0800) Stefano Stabellini (5): hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

[PULL v2 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

2023-02-14 Thread Stefano Stabellini
From: Stefano Stabellini In preparation to moving most of xen-hvm code to an arch-neutral location, move: - shared_vmport_page - log_for_dirtybit - dirty_bitmap - suspend - wakeup out of XenIOState struct as these are only used on x86, especially the ones related to dirty logging. Updated

Re: [PULL 00/10] xenpvh machine

2023-02-13 Thread Stefano Stabellini
On Mon, 13 Feb 2023, Peter Maydell wrote: > On Fri, 10 Feb 2023 at 22:27, Stefano Stabellini > wrote: > > > > The following changes since commit 90595cc9396bb910b148391fea2e78dd8c6c8b27: > > > > Merge tag 'migration-20230209-pull-request' of > > h

Re: [PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator

2023-02-10 Thread Stefano Stabellini
ice. > > Fixes: 998250e97661 ("xen, gfx passthrough: register host bridge specific to > passthrough") > Signed-off-by: Chuck Zmudzinski I think this is OK Acked-by: Stefano Stabellini > --- > This patch is intended to replace or complement a recently proposed > p

[PULL 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-02-10 Thread Stefano Stabellini
From: Stefano Stabellini This patch does following: 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in preparation for moving most of xen-hvm code to an arch-neutral location, move the x86-specific portion of xen_set_memory to arch_xen_set_memory. Also, move

[PULL 09/10] hw/arm: introduce xenpvh machine

2023-02-10 Thread Stefano Stabellini
tpm2/swtpm-sock & Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini --- docs/system/arm/xenpvh.rst| 34 +++ docs/system/target-arm.rst| 1 + hw/arm/meson.build| 2 + hw/arm/xen_arm.c

[PULL 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets

2023-02-10 Thread Stefano Stabellini
From: Stefano Stabellini have_xen_pci_passthrough is only used for Xen x86 VMs. Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index c626ccfa82..fb9fb97bb1 100644 --- a/meson.build

[PULL 07/10] hw/xen/xen-hvm-common: Use g_new and error_report

2023-02-10 Thread Stefano Stabellini
From: Vikram Garhwal Replace g_malloc with g_new and perror with error_report. Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/xen/xen-hvm-common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen-hvm

[PULL 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2023-02-10 Thread Stefano Stabellini
From: Stefano Stabellini This is done to prepare for enabling xenpv support for ARM architecture. On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails, continue to the PV backends initialization. Signed-off

[PULL 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure

2023-02-10 Thread Stefano Stabellini
From: Stefano Stabellini On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails continue to the PV backends initialization. Also, moved the IOREQ registration and mapping subroutine to new function

[PULL 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2023-02-10 Thread Stefano Stabellini
From: Vikram Garhwal xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed

[PULL 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

2023-02-10 Thread Stefano Stabellini
From: Stefano Stabellini In preparation to moving most of xen-hvm code to an arch-neutral location, move: - shared_vmport_page - log_for_dirtybit - dirty_bitmap - suspend - wakeup out of XenIOState struct as these are only used on x86, especially the ones related to dirty logging. Updated

[PULL 02/10] hw/i386/xen: rearrange xen_hvm_init_pc

2023-02-10 Thread Stefano Stabellini
ioreq functions in one place which will be moved to new function in next patch in order to make it common to both x86 and aarch64 machines. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/i386/xen/xen-hvm.c | 49

[PULL 10/10] meson.build: enable xenpv machine build for ARM

2023-02-10 Thread Stefano Stabellini
From: Vikram Garhwal Add CONFIG_XEN for aarch64 device to support build for ARM targets. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build

[PULL 00/10] xenpvh machine

2023-02-10 Thread Stefano Stabellini
for you to fetch changes up to 3f8ee848693872e3783cdcf2862be5421bb9cbcb: meson.build: enable xenpv machine build for ARM (2023-02-10 14:23:47 -0800) Stefano Stabellini (5): hw/i386/xen/xen-hvm: move x86-specific fields out

Re: [QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine

2023-02-02 Thread Stefano Stabellini
On Thu, 2 Feb 2023, Paul Durrant wrote: > On 01/02/2023 18:22, Vikram Garhwal wrote: > > Hi Paul, > > > > Thanks for reviewing this and other patches in series. > > > > Please see my reply below. > > > > On 2/1/23 12:30 AM, Paul Durrant wrote: > > > On 31/01/2023 22:51, Vikram Garhwal wrote: >

Re: [QEMU][PATCH v5 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-01-31 Thread Stefano Stabellini
On Tue, 31 Jan 2023, Vikram Garhwal wrote: > From: Stefano Stabellini > > This patch does following: > 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in > preparation for moving most of xen-hvm code to an arch-neutral location, > move the x8

Re: [QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine

2023-01-31 Thread Stefano Stabellini
> mkdir /tmp/vtpm2 > swtpm socket --tpmstate dir=/tmp/vtpm2 \ > --ctrl type=unixio,path=/tmp/vtpm2/swtpm-sock & > > Signed-off-by: Vikram Garhwal > Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini > --- > docs/system/arm/xenpvh.rst

Re: [PATCH] hw/xen/xen_pt: fix uninitialized variable

2023-01-27 Thread Stefano Stabellini
er registers higher bits of > 'val' are not initialized. Then, the function fails if any of those > higher bits are set. > > Fix this by initializing 'val' with zero. > > Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Stefano Stabellini > --- > hw/xen/x

Re: [QEMU][PATCH v4 09/10] hw/arm: introduce xenpvh machine

2023-01-26 Thread Stefano Stabellini
On Wed, 25 Jan 2023, Vikram Garhwal wrote: > Hi Stefano, > > On 1/25/23 2:20 PM, Stefano Stabellini wrote: > > On Wed, 25 Jan 2023, Vikram Garhwal wrote: > > > Add a new machine xenpvh which creates a IOREQ server to register/connect > > > with > > > X

Re: [QEMU][PATCH v4 09/10] hw/arm: introduce xenpvh machine

2023-01-25 Thread Stefano Stabellini
> mkdir /tmp/vtpm2 > swtpm socket --tpmstate dir=/tmp/vtpm2 \ > --ctrl type=unixio,path=/tmp/vtpm2/swtpm-sock & > > Signed-off-by: Vikram Garhwal > Signed-off-by: Stefano Stabellini > --- > docs/system/arm/xenpvh.rst| 34 +++ > docs/system/tar

Re: [QEMU][PATCH v4 07/10] hw/xen/xen-hvm-common: Use g_new and error_setg_errno

2023-01-25 Thread Stefano Stabellini
t; @@ -726,7 +726,7 @@ void destroy_hvm_domain(bool reboot) > return; > } > if (errno != ENOTTY /* old Xen */) { > -perror("xendevicemodel_shutdown failed"); > +error_report("xendevicemodel_shutdown failed with er

Re: [QEMU][PATCH v4 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure

2023-01-25 Thread Stefano Stabellini
On Wed, 25 Jan 2023, Vikram Garhwal wrote: > From: Stefano Stabellini > > On ARM it is possible to have a functioning xenpv machine with only the > PV backends and no IOREQ server. If the IOREQ server creation fails continue > to the PV backends initialization. > >

Re: [QEMU][PATCH v4 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2023-01-25 Thread Stefano Stabellini
On Wed, 25 Jan 2023, Vikram Garhwal wrote: > From: Stefano Stabellini > > This is done to prepare for enabling xenpv support for ARM architecture. > On ARM it is possible to have a functioning xenpv machine with only the > PV backends and no IOREQ server. If the IOREQ server

Re: [QEMU][PATCH v4 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-01-25 Thread Stefano Stabellini
On Wed, 25 Jan 2023, Vikram Garhwal wrote: > From: Stefano Stabellini > > This patch does following: > 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in > preparation for moving most of xen-hvm code to an arch-neutral location, > move the x8

Re: [PATCH v11] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-23 Thread Stefano Stabellini
g the "pc" machine type instead of the "xenfv" machine type, > which results in reduced startup performance. > > Rebase. > > Add Igor Mammedov to Cc. > > v11: I noticed a style mistake that has been present in the past few >

Re: [PATCH v9] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-20 Thread Stefano Stabellini
On Sat, 14 Jan 2023, Chuck Zmudzinski wrote: > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > as noted in docs/igd-assign.txt in the Qemu source code. > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > Intel IGD passthrough to the guest with

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-20 Thread Stefano Stabellini
On Tue, 17 Jan 2023, Chuck Zmudzinski wrote: > On 1/17/2023 6:04 AM, Igor Mammedov wrote: > > On Mon, 16 Jan 2023 13:00:53 -0500 > > Chuck Zmudzinski wrote: > > > > > On 1/16/23 10:33, Igor Mammedov wrote: > > > > On Fri, 13 Jan 2023 16:31:26 -0500 > > > > Chuck Zmudzinski wrote: > > > > > >

Re: [QEMU][PATCH v2 10/11] hw/arm: introduce xenpv machine

2022-12-02 Thread Stefano Stabellini
On Fri, 2 Dec 2022, Vikram Garhwal wrote: > On 12/2/22 6:52 AM, Alex Bennée wrote: > > Vikram Garhwal writes: > > > > > Add a new machine xenpv which creates a IOREQ server to register/connect > > > with > > > Xen Hypervisor. > > > > > > Optional: When CONFIG_TPM is enabled, it also creates a

Re: [QEMU][PATCH v2 05/11] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2022-12-02 Thread Stefano Stabellini
On Fri, 1 Dec 2022, Philippe Mathieu-Daudé wrote: > On 2/12/22 08:19, Philippe Mathieu-Daudé wrote: > > Hi Stefano and Vikram, > > > > On 2/12/22 03:59, Vikram Garhwal wrote: > > > From: Stefano Stabellini > > > > > > This is done to prepare

Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine

2022-10-18 Thread Stefano Stabellini
On Tue, 18 Oct 2022, Julien Grall wrote: > On 18/10/2022 02:26, Stefano Stabellini wrote: > > On Sun, 16 Oct 2022, Julien Grall wrote: > > > Hi, > > > > > > There seem to be some missing patches on xen-devel (including the cover > > > letter). Is th

Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine

2022-10-17 Thread Stefano Stabellini
On Sun, 16 Oct 2022, Julien Grall wrote: > Hi, > > There seem to be some missing patches on xen-devel (including the cover > letter). Is that expected? > > On 15/10/2022 06:07, Vikram Garhwal wrote: > > Add a new machine xenpv which creates a IOREQ server to register/connect > > with > > Xen

Re: Question to mem-path support at QEMU for Xen

2022-07-28 Thread Stefano Stabellini
On Thu, 28 Jul 2022, Igor Mammedov wrote: > On Thu, 28 Jul 2022 15:17:49 +0800 > Huang Rui wrote: > > > Hi Igor, > > > > Appreciate you for the reply! > > > > On Wed, Jul 27, 2022 at 04:19:30PM +0800, Igor Mammedov wrote: > > > On Tue, 26 Jul 2022 15:27:07 +0800 > > > Huang Rui wrote: > > >

Re: [PATCH 0/2] Decouple Xen-HVM from PIIX

2022-06-28 Thread Stefano Stabellini
On Tue, 28 Jun 2022, B wrote: > Am 26. Juni 2022 09:46:54 UTC schrieb Bernhard Beschow : > >hw/i386/xen/xen-hvm.c contains logic which is PIIX-specific. This makes > >xen-hvm.c depend on PIIX which can be avoided if PIIX logic was isolated in > >PIIX itself. > > > > > > > >Bernhard Beschow (2):

Re: [PATCH v2] xen-mapcache: Avoid entry->lock overflow

2022-01-24 Thread Stefano Stabellini
he entry map be remapped causing QEMU to write the wrong > data or crash (since remap is not atomic). > > Avoid this overflow by increasing the lock field to a uint32_t and also > detect it and abort rather than continuing regardless. > > Signed-off-by: Ross Lagerwall R

Re: [PATCH] xen-mapcache: Avoid entry->lock overflow

2022-01-21 Thread Stefano Stabellini
On Fri, 21 Jan 2022, Ross Lagerwall wrote: > In some cases, a particular mapcache entry may be mapped 256 times > causing the lock field to wrap to 0. For example, this may happen when > using emulated NVME and the guest submits a large scatter-gather write. > At this point, the entry map be

Re: [PATCH] 9pfs: Fully restart unreclaim loop (CVE-2021-20181)

2021-01-14 Thread Stefano Stabellini
ow let's keep it > simple and just restart the loop from the current head. > > Fixes: CVE-2021-20181 > Buglink: https://bugs.launchpad.net/qemu/+bug/1911666 > Reported-by: Zero Day Initiative > Reviewed-by: Christian Schoenebeck > Signed-off-by: Greg Kurz Reviewed-by: Stefano

Re: [PATCH v2 1/1] security-process: update process information

2020-12-10 Thread Stefano Stabellini
ned-off-by: Prasad J Pandit Acked-by: Stefano Stabellini > --- > contribute/security-process.md | 154 - > 1 file changed, 95 insertions(+), 59 deletions(-) > > Update v2: incorporate inputs from upstream reviews > -> https://lists.nongnu.o

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread Stefano Stabellini
On Wed, 2 Dec 2020, Daniel P. Berrangé wrote: > On Mon, Nov 30, 2020 at 07:19:07PM +0530, P J P wrote: > > From: Prasad J Pandit > > > > We are about to introduce a qemu-security mailing list to report > > and triage QEMU security issues. > > > > Update the QEMU security process web page with

Re: [PATCH v2 11/13] xen: remove GNUC check

2020-12-01 Thread Stefano Stabellini
On Thu, 26 Nov 2020, Peter Maydell wrote: > On Thu, 26 Nov 2020 at 11:30, wrote: > > > > From: Marc-André Lureau > > > > QEMU requires Clang or GCC, that define and support __GNUC__ extensions > > > > Signed-off-by: Marc-André Lureau > > --- > > include/hw/xen/interface/io/ring.h | 9 -

Re: [PATCH-for-6.0 v4 15/17] gitlab-ci: Add test for Xen (on CentOS 7)

2020-11-30 Thread Stefano Stabellini
On Fri, 27 Nov 2020, Anthony PERARD wrote: > On Thu, Nov 26, 2020 at 12:45:59PM -0500, Eduardo Habkost wrote: > > On Thu, Nov 26, 2020 at 05:38:24PM +, Anthony PERARD wrote: > > > Is `make check` going to do something useful with the Xen support? Or is > > > it going to need more work in order

Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config

2020-11-04 Thread Stefano Stabellini
On Wed, 4 Nov 2020, Thomas Huth wrote: > On 04/11/2020 03.27, Stefano Stabellini wrote: > [...] > > Actually I care about Xen and 9pfs support, it is one of the few > > combinations that I use regularly and it is even enabled in the Xilinx > > product I look after. But admi

Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config

2020-11-04 Thread Stefano Stabellini
On Wed, 4 Nov 2020, Paolo Bonzini wrote: > Il mer 4 nov 2020, 03:27 Stefano Stabellini ha > scritto: > FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I > get: > >   ninja: unknown tool 'query' > > Even after rebuilding n

Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config

2020-11-03 Thread Stefano Stabellini
On Tue, 3 Nov 2020, Philippe Mathieu-Daudé wrote: > I forgot to Cc the 9pfs & Xen maintainers, doing it now ;) > > On 11/3/20 6:01 PM, Philippe Mathieu-Daudé wrote: > > On 11/3/20 5:52 PM, Daniel P. Berrangé wrote: > >> On Tue, Nov 03, 2020 at 05:46:03PM +0100, Philippe Mathieu-Daudé wrote: > >>>

Re: [PATCH] meson.build: fix building of Xen support for aarch64

2020-10-29 Thread Stefano Stabellini
le CONFIG_XEN for aarch64-softmmu to > >> make it not seem weird but that will require further build surgery. > >> > >> Signed-off-by: Alex Bennée > >> Cc: Masami Hiramatsu > >> Cc: Stefano Stabellini > >> Cc: Anthony Perard >

Re: [PATCH] meson.build: fix building of Xen support for aarch64

2020-10-29 Thread Stefano Stabellini
On Thu, 29 Oct 2020, Jason Andryuk wrote: > On Thu, Oct 29, 2020 at 6:01 AM Alex Bennée wrote: > > > > > > Stefano Stabellini writes: > > > > > On Wed, 28 Oct 2020, Alex Bennée wrote: > > >> Xen is supported on aarch64 although weirdly usi

Re: [PATCH] meson.build: fix building of Xen support for aarch64

2020-10-28 Thread Stefano Stabellini
will require further build surgery. > > Signed-off-by: Alex Bennée > Cc: Masami Hiramatsu > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Paul Durrant > Fixes: 8a19980e3f ("configure: move accelerator logic to meson") > --- > meson.build | 2 ++ &

Re: [PATCH] xen: xenguest is not used so is not needed

2020-09-21 Thread Stefano Stabellini
Adding Paul On Sat, 19 Sep 2020, Philippe Mathieu-Daudé wrote: > Cc'ing qemu-trivial@ > > On 7/27/20 5:09 PM, Anthony PERARD wrote: > > On Mon, Jul 27, 2020 at 05:00:48PM +0300, Michael Tokarev wrote: > >> There's no references in only file which includes xenguest.h > >> to any xen definitions.

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Stefano Stabellini
Adding Paul On Mon, 21 Sep 2020, Dr. David Alan Gilbert wrote: > * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > > > > > On 21/09/2020 14:17, Dr. David Alan Gilbert wrote: > > > * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > > > When running the xen-save-devices-state QMP command,

[PATCH v2 1/3] Revert "9p: init_in_iov_from_pdu can truncate the size"

2020-05-21 Thread Stefano Stabellini
From: Stefano Stabellini This reverts commit 16724a173049ac29c7b5ade741da93a0f46edff7. It causes https://bugs.launchpad.net/bugs/1877688. Signed-off-by: Stefano Stabellini --- hw/9pfs/9p.c | 33 +++-- hw/9pfs/9p.h | 2 +- hw/9pfs/virtio

[PATCH v2 2/3] xen/9pfs: yield when there isn't enough room on the ring

2020-05-21 Thread Stefano Stabellini
From: Stefano Stabellini Instead of truncating replies, which is problematic, wait until the client reads more data and frees bytes on the reply ring. Do that by calling qemu_coroutine_yield(). The corresponding qemu_coroutine_enter_if_inactive() is called from xen_9pfs_bh upon receiving

[PATCH v2 0/3] revert 9pfs reply truncation, wait for free room to reply

2020-05-21 Thread Stefano Stabellini
Hi all, This short series reverts commit 16724a173049ac29c7b5ade741da93a0f46edff becauses it is the cause for https://bugs.launchpad.net/bugs/1877688. The original issue addressed by 16724a173049ac29c7b5ade741da93a0f46edff is solved differently in this series by using qemu_coroutine_yield() to

[PATCH v2 3/3] xen/9pfs: increase max ring order to 9

2020-05-21 Thread Stefano Stabellini
From: Stefano Stabellini The max order allowed by the protocol is 9. Increase the max order supported by QEMU to 9 to increase performance. Signed-off-by: Stefano Stabellini --- Changes in v2: - patch added --- hw/9pfs/xen-9p-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 2/2] xen/9pfs: yield when there isn't enough room on the ring

2020-05-20 Thread Stefano Stabellini
On Wed, 20 May 2020, Stefano Stabellini wrote: > On Wed, 20 May 2020, Christian Schoenebeck wrote: > > On Mittwoch, 20. Mai 2020 03:47:12 CEST Stefano Stabellini wrote: > > > From: Stefano Stabellini > > > > > > Instead of truncating replies, which is prob

Re: [PATCH 2/2] xen/9pfs: yield when there isn't enough room on the ring

2020-05-20 Thread Stefano Stabellini
On Wed, 20 May 2020, Christian Schoenebeck wrote: > On Mittwoch, 20. Mai 2020 03:47:12 CEST Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Instead of truncating replies, which is problematic, wait until the > > client reads more data and frees bytes on

[PATCH 1/2] Revert "9p: init_in_iov_from_pdu can truncate the size"

2020-05-19 Thread Stefano Stabellini
From: Stefano Stabellini This reverts commit 16724a173049ac29c7b5ade741da93a0f46edff7. It causes https://bugs.launchpad.net/bugs/1877688. Signed-off-by: Stefano Stabellini --- hw/9pfs/9p.c | 33 +++-- hw/9pfs/9p.h | 2 +- hw/9pfs/virtio

[PATCH 2/2] xen/9pfs: yield when there isn't enough room on the ring

2020-05-19 Thread Stefano Stabellini
From: Stefano Stabellini Instead of truncating replies, which is problematic, wait until the client reads more data and frees bytes on the reply ring. Do that by calling qemu_coroutine_yield(). The corresponding qemu_coroutine_enter_if_inactive() is called from xen_9pfs_bh upon receiving

[PATCH 0/2] revert 9pfs reply truncation, wait for free room to reply

2020-05-19 Thread Stefano Stabellini
Hi all, This short series reverts commit 16724a173049ac29c7b5ade741da93a0f46edff becauses it is the cause for https://bugs.launchpad.net/bugs/1877688. The original issue addressed by 16724a173049ac29c7b5ade741da93a0f46edff is solved differently in this series by using qemu_coroutine_yield() to

<    1   2   3   4   5   6   7   8   9   10   >