Re: [Qemu-devel] [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-28 Thread Stefano Stabellini
: > On 9/22/2015 12:03 AM, Stefano Stabellini wrote: > > It is going to be in QEMU 2.5 and qemu-xen 4.7. > > Thanks for your reply. > > Do we have any possibility of just merging this series into qemu-xen 4.6? We > really want to support IGD passthrough on xen 4.6 if possible

Re: [Qemu-devel] [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-21 Thread Stefano Stabellini
> > Thanks > Tiejun > > On 9/9/2015 1:21 AM, Stefano Stabellini wrote: > > The following changes since commit 8611280505119e296757a60711a881341603fa5a: > > > >target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +0200) > > > > are ava

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-17 Thread Stefano Stabellini
On Wed, 16 Sep 2015, Chen, Tiejun wrote: > On 9/15/2015 7:00 PM, Paolo Bonzini wrote: > > > > > > On 15/09/2015 11:55, Stefano Stabellini wrote: > > > On Mon, 14 Sep 2015, Paolo Bonzini wrote: > > > > > On 10/09/2015 12:29, Stefano Stabellini wrote

Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values.

2015-09-15 Thread Stefano Stabellini
On Tue, 15 Sep 2015, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 15, 2015 at 11:07:02AM +0100, Stefano Stabellini wrote: > > CC Konrad > > > > On Mon, 14 Sep 2015, Paolo Bonzini wrote: > > > On 10/09/2015 19:15, Stefano Stabellini wrote: > > >

Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values.

2015-09-15 Thread Stefano Stabellini
CC Konrad On Mon, 14 Sep 2015, Paolo Bonzini wrote: > On 10/09/2015 19:15, Stefano Stabellini wrote: > > + > > +switch (reg->size) { > > +case 1: rc = xen_host_pci_get_byte(&s->real_device, offset, > > (uint8_t *)&val); > > A b

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-15 Thread Stefano Stabellini
On Mon, 14 Sep 2015, Paolo Bonzini wrote: > On 10/09/2015 12:29, Stefano Stabellini wrote: > > +if (lseek(config_fd, pos, SEEK_SET) != pos) { > > +return -errno; > > +} > > do { > > -rc = pread(config_fd, (uint8_t *)&val, len, p

[Qemu-devel] [PULL 28/29] xen/pt: Check for return values for xen_host_pci_[get|set] in init

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk and if we have failures we call xen_pt_destroy introduced in 'xen/pt: Move bulk of xen_pt_unregister_device in its own routine.' and free all of the allocated structures. Acked-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-b

[Qemu-devel] [PULL 23/29] xen/pt: Remove XenPTReg->data field.

2015-09-10 Thread Stefano Stabellini
is-use: - In 'xen_pt_status_reg_init' we used u32 for the Capabilities Pointer register, but said register is an an u16. - In 'xen_pt_msgdata_reg_write' we used u32 but should have only use u16. Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabel

[Qemu-devel] [PULL 14/29] xen/pt: Update comments with proper function name.

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk It has changed but the comments still refer to the old names. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw

[Qemu-devel] [PULL 25/29] xen/pt: Log xen_host_pci_get/set errors in MSI code.

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk We seem to only use these functions when de-activating the MSI - so just log errors. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt_msi.c | 18 ++ 1 file changed, 14

[Qemu-devel] [PULL 24/29] xen/pt: Log xen_host_pci_get in two init functions

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk To help with troubleshooting in the field. Acked-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt_config_init.c |9 + 1 file changed, 9 insertions(+) diff --git a/hw/xen

[Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values.

2015-09-10 Thread Stefano Stabellini
in-case the developer sets bits past the reg->size in the ->init routines. The author tried to fiddle with QEMU_BUILD_BUG to make this work but failed. Reviewed-by: Stefano Stabellini Reported-by: Sander Eikelenboom Signed-off-by: Konrad Rzeszutek Wilk Sign

[Qemu-devel] [PULL 18/29] xen/pt/msi: Add the register value when printing logging and error messages

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk We would like to know what the MSI register value is to help in troubleshooting in the field. As such modify the logging logic to include such details in xen_pt_msgctrl_reg_write. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by

[Qemu-devel] [PULL 29/29] xen/pt: Don't slurp wholesale the PCI configuration registers

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk Instead we have the emulation registers ->init functions which consult the host values to see what the initial value should be and they are responsible for populating the dev.config. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off

[Qemu-devel] [PULL 17/29] xen: use errno instead of rc for xc_domain_add_to_physmap

2015-09-10 Thread Stefano Stabellini
parameters) so we piggyback on the fact that Xen 4.6 has a new function: commit 504ed2053362381ac01b98db9313454488b7db40 "tools/libxc: Expose new hypercall xc_reserved_device_memory_map" and check for that. Reviewed-by: Stefano Stabellini Suggested-by: Stefano Stabellini Signed-off-by: K

[Qemu-devel] [PULL 19/29] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.

2015-09-10 Thread Stefano Stabellini
se now but with the "xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config" we will hit - so this sync up the function to the rest of them. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt_config_init.c |

[Qemu-devel] [PULL 15/29] xen/pt: Make xen_pt_msi_set_enable static

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk As we do not use it outside our code. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.h |1 - hw/xen/xen_pt_msi.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff

[Qemu-devel] [PULL 27/29] xen/pt: Move bulk of xen_pt_unregister_device in its own routine.

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk This way we can call it if we fail during init. This code movement introduces no changes. Acked-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.c | 121

[Qemu-devel] [PULL 11/29] xen, gfx passthrough: add opregion mapping

2015-09-10 Thread Stefano Stabellini
iejun Chen Signed-off-by: Yang Zhang Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.h |6 +++- hw/xen/xen_pt_config_init.c | 51 +-- hw/xen/xen_pt_graphics.c| 82 +++ 3 fil

[Qemu-devel] [PULL 20/29] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config

2015-09-10 Thread Stefano Stabellini
split this as a seperate patch however we would have to use a cast to thwart compiler warnings in the meantime. We also truncated 'flags' to 'flag' to make the code fit within the 80 characters. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-

[Qemu-devel] [PULL 16/29] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk However the init routines assume that on errors the return code is -1 (as the libxc API is) - while those xen_host_* routines follow another paradigm - negative errno on return, 0 on success. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk

[Qemu-devel] [PULL 22/29] xen/pt: Check if reg->init function sets the 'data' past the reg->size

2015-09-10 Thread Stefano Stabellini
ss other ones - however to catch this sort of thing we still return an error. Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt_config_init.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen_pt_config_in

[Qemu-devel] [PULL 13/29] xen/HVM: atomically access pointers in bufioreq handling

2015-09-10 Thread Stefano Stabellini
ff-by: Stefano Stabellini --- configure | 27 +++ include/hw/xen/xen_common.h | 12 +++- xen-hvm.c | 26 ++ 3 files changed, 56 insertions(+), 9 deletions(-) diff --git a/configure b/configure index d8

[Qemu-devel] [PULL 12/29] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk .errors - as it will most likely have the proper error value. Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- xen-hvm.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen-hvm.c b

[Qemu-devel] [PULL 26/29] xen/pt: Make xen_pt_unregister_device idempotent

2015-09-10 Thread Stefano Stabellini
calling .init!). Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen-host-pci-device.c |5 + hw/xen/xen-host-pci-device.h |1 + hw/xen/xen_pt.c | 20 ++-- hw/xen/xen_pt.h |2

[Qemu-devel] [PULL 09/29] xen, gfx passthrough: register a isa bridge

2015-09-10 Thread Stefano Stabellini
From: Tiejun Chen Currently we just register this isa bridge when we use IGD passthrough in Xen side. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a

[Qemu-devel] [PULL 05/29] hw/pci-assign: split pci-assign.c

2015-09-10 Thread Stefano Stabellini
From: Tiejun Chen We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. [Fix build for Windows] Signed-off-by: Tiejun Chen Signed-off-by: Stefano Stabellini Acked-by: Michael S. Tsirkin

[Qemu-devel] [PULL 00/29] xen-2015-09-10-tag

2015-09-10 Thread Stefano Stabellini
The following changes since commit 8611280505119e296757a60711a881341603fa5a: target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +0200) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2015-09-10-tag for you to fetch changes up

[Qemu-devel] [PULL 06/29] xen, gfx passthrough: basic graphics passthrough support

2015-09-10 Thread Stefano Stabellini
From: Tiejun Chen basic gfx passthrough support: - add a vga type for gfx passthrough - register/unregister legacy VGA I/O ports and MMIOs for passthrough GFX Signed-off-by: Tiejun Chen Signed-off-by: Yang Zhang Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/core

[Qemu-devel] [PULL 03/29] pc_init1: pass parameters just with types

2015-09-10 Thread Stefano Stabellini
From: Tiejun Chen Pass types to configure pc_init1(). Signed-off-by: Tiejun Chen Signed-off-by: Stefano Stabellini Acked-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c

[Qemu-devel] [PULL 07/29] xen, gfx passthrough: retrieve VGA BIOS to work

2015-09-10 Thread Stefano Stabellini
From: Tiejun Chen Now we retrieve VGA bios like kvm stuff in qemu but we need to fix Device Identification in case if its not matched with the real IGD device since Seabios is always trying to compare this ID to work out VGA BIOS. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini Signed

[Qemu-devel] [PULL 08/29] igd gfx passthrough: create a isa bridge

2015-09-10 Thread Stefano Stabellini
ned-off-by: Tiejun Chen Signed-off-by: Stefano Stabellini Acked-by: Michael S. Tsirkin --- hw/i386/pc_piix.c| 112 ++ include/hw/i386/pc.h |1 + 2 files changed, 113 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 626a19

[Qemu-devel] [PULL 02/29] i440fx: make types configurable at run-time

2015-09-10 Thread Stefano Stabellini
From: "Michael S. Tsirkin" IGD passthrough wants to supply a different pci and host devices, inheriting i440fx devices. Make types configurable. Signed-off-by: Michael S. Tsirkin Signed-off-by: Tiejun Chen Signed-off-by: Stefano Stabellini --- hw/i386/pc_piix.c|4 +++- h

[Qemu-devel] [PULL 01/29] xen-hvm: Add trace to ioreq

2015-09-10 Thread Stefano Stabellini
From: Don Slutz Signed-off-by: Stefano Stabellini Signed-off-by: Don Slutz --- trace-events |7 +++ xen-hvm.c| 21 + 2 files changed, 28 insertions(+) diff --git a/trace-events b/trace-events index 0a82f0c..985b041 100644 --- a/trace-events +++ b/trace

[Qemu-devel] [PULL 10/29] xen, gfx passthrough: register host bridge specific to passthrough

2015-09-10 Thread Stefano Stabellini
From: Tiejun Chen Just register that pci host bridge specific to passthrough. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/i386/pc_piix.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/i386

[Qemu-devel] [PULL 04/29] piix: create host bridge to passthrough

2015-09-10 Thread Stefano Stabellini
: Stefano Stabellini Acked-by: Michael S. Tsirkin --- hw/pci-host/piix.c | 85 ++ include/hw/i386/pc.h |2 ++ 2 files changed, 87 insertions(+) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index e19badb..1fb71c8 100644 --- a/hw/pci

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > On Thu, Sep 10, 2015 at 12:26:21PM +0100, Stefano Stabellini wrote: > > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > > On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > > > > CC Michael > &

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > > CC Michael > > > > On Thu, 10 Sep 2015, Stefano Stabellini wrote: > > > On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > > &

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
CC Michael On Thu, 10 Sep 2015, Stefano Stabellini wrote: > On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH > > > was set by configure. That won't be the case on OSX or Windows, where > &g

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > As you see this short log, "hw/pci-assign: split pci-assign.c", so this > > > means I just extract something from the original hw/i386/kvm/pci-assign.c, > > > and here so I just keep those original head files residing > > > hw/i386/kvm/pci-assign.c, an

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH > > was set by configure. That won't be the case on OSX or Windows, where > > the Xen headers don't exist. > > > > Okay. This actually shouldn't be enabled on Windows so what about th

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-09 Thread Stefano Stabellini
On Wed, 9 Sep 2015, Stefano Stabellini wrote: > On Tue, 8 Sep 2015, Peter Maydell wrote: > > On 8 September 2015 at 18:21, Stefano Stabellini > > wrote: > > > The following changes since commit > > > 8611280505119e296757a60711a881341603fa5a: > > > >

Re: [Qemu-devel] [Xen-devel] [Patch V1 3/3] xen: add pvUSB backend

2015-09-09 Thread Stefano Stabellini
On Wed, 9 Sep 2015, Juergen Gross wrote: > On 09/07/2015 07:38 PM, Stefano Stabellini wrote: > > On Thu, 3 Sep 2015, Juergen Gross wrote: > > > Add a backend for para-virtualized USB devices for xen domains. > > > > > > The backend is using host-libusb to forw

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-09 Thread Stefano Stabellini
On Tue, 8 Sep 2015, Peter Maydell wrote: > On 8 September 2015 at 18:21, Stefano Stabellini > wrote: > > The following changes since commit 8611280505119e296757a60711a881341603fa5a: > > > > target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +0200) > >

[Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-08 Thread Stefano Stabellini
The following changes since commit 8611280505119e296757a60711a881341603fa5a: target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +0200) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2015-09-08-tag for you to fetch changes up

[Qemu-devel] [PULL 09/19] xen, gfx passthrough: register a isa bridge

2015-09-08 Thread Stefano Stabellini
From: Tiejun Chen Currently we just register this isa bridge when we use IGD passthrough in Xen side. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a

[Qemu-devel] [PULL 10/19] xen, gfx passthrough: register host bridge specific to passthrough

2015-09-08 Thread Stefano Stabellini
From: Tiejun Chen Just register that pci host bridge specific to passthrough. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/i386/pc_piix.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/i386

[Qemu-devel] [PULL 02/19] i440fx: make types configurable at run-time

2015-09-08 Thread Stefano Stabellini
From: "Michael S. Tsirkin" IGD passthrough wants to supply a different pci and host devices, inheriting i440fx devices. Make types configurable. Signed-off-by: Michael S. Tsirkin Signed-off-by: Tiejun Chen Signed-off-by: Stefano Stabellini --- hw/i386/pc_piix.c|4 +++- h

Re: [Qemu-devel] [PATCH v2 03/10] xen/pt: Check if reg->init function sets the 'data' past the reg->size

2015-09-08 Thread Stefano Stabellini
me danger of the register spilling > across other ones - however to catch this sort of thing > we still return an error. > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini > hw/xen/xen_pt_config_init.c | 10 -- > 1 file changed, 8 insertions(

Re: [Qemu-devel] [PATCH v2] Remove XenPTReg->data and use dev.config for guest configuration values.

2015-09-08 Thread Stefano Stabellini
Now that is fully Acked, could you please rebase on http://marc.info/?i=alpine.DEB.2.02.1509081818590.2672%40kaball.uk.xensource.com and resend? Thanks! - Stefano On Tue, 8 Sep 2015, Konrad Rzeszutek Wilk wrote: > Hey! > > Since v1: (http://lists.xen.org/archives/html/xen-devel/2015-07/msg0044

[Qemu-devel] [PULL 03/19] pc_init1: pass parameters just with types

2015-09-08 Thread Stefano Stabellini
From: Tiejun Chen Pass types to configure pc_init1(). Signed-off-by: Tiejun Chen Signed-off-by: Stefano Stabellini Acked-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c

[Qemu-devel] [PULL 16/19] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure

2015-09-08 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk However the init routines assume that on errors the return code is -1 (as the libxc API is) - while those xen_host_* routines follow another paradigm - negative errno on return, 0 on success. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk

[Qemu-devel] [PULL 18/19] xen/pt/msi: Add the register value when printing logging and error messages

2015-09-08 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk We would like to know what the MSI register value is to help in troubleshooting in the field. As such modify the logging logic to include such details in xen_pt_msgctrl_reg_write. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by

[Qemu-devel] [PULL 14/19] xen/pt: Update comments with proper function name.

2015-09-08 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk It has changed but the comments still refer to the old names. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw

[Qemu-devel] [PULL 19/19] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.

2015-09-08 Thread Stefano Stabellini
se now but with the "xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config" we will hit - so this sync up the function to the rest of them. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt_config_init.c |

[Qemu-devel] [PULL 15/19] xen/pt: Make xen_pt_msi_set_enable static

2015-09-08 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk As we do not use it outside our code. Reviewed-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.h |1 - hw/xen/xen_pt_msi.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff

[Qemu-devel] [PULL 13/19] xen/HVM: atomically access pointers in bufioreq handling

2015-09-08 Thread Stefano Stabellini
ff-by: Stefano Stabellini --- configure | 27 +++ include/hw/xen/xen_common.h | 12 +++- xen-hvm.c | 26 ++ 3 files changed, 56 insertions(+), 9 deletions(-) diff --git a/configure b/configure index d8

[Qemu-devel] [PULL 12/19] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting

2015-09-08 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk .errors - as it will most likely have the proper error value. Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- xen-hvm.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen-hvm.c b

[Qemu-devel] [PULL 11/19] xen, gfx passthrough: add opregion mapping

2015-09-08 Thread Stefano Stabellini
iejun Chen Signed-off-by: Yang Zhang Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.h |6 +++- hw/xen/xen_pt_config_init.c | 51 +-- hw/xen/xen_pt_graphics.c| 82 +++ 3 fil

[Qemu-devel] [PULL 17/19] xen: use errno instead of rc for xc_domain_add_to_physmap

2015-09-08 Thread Stefano Stabellini
parameters) so we piggyback on the fact that Xen 4.6 has a new function: commit 504ed2053362381ac01b98db9313454488b7db40 "tools/libxc: Expose new hypercall xc_reserved_device_memory_map" and check for that. Reviewed-by: Stefano Stabellini Suggested-by: Stefano Stabellini Signed-off-by: K

[Qemu-devel] [PULL 06/19] xen, gfx passthrough: basic graphics passthrough support

2015-09-08 Thread Stefano Stabellini
From: Tiejun Chen basic gfx passthrough support: - add a vga type for gfx passthrough - register/unregister legacy VGA I/O ports and MMIOs for passthrough GFX Signed-off-by: Tiejun Chen Signed-off-by: Yang Zhang Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/core

[Qemu-devel] [PULL 01/19] xen-hvm: Add trace to ioreq

2015-09-08 Thread Stefano Stabellini
From: Don Slutz Signed-off-by: Stefano Stabellini Signed-off-by: Don Slutz --- trace-events |7 +++ xen-hvm.c| 21 + 2 files changed, 28 insertions(+) diff --git a/trace-events b/trace-events index 0a82f0c..985b041 100644 --- a/trace-events +++ b/trace

[Qemu-devel] [PULL 05/19] hw/pci-assign: split pci-assign.c

2015-09-08 Thread Stefano Stabellini
From: Tiejun Chen We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen Signed-off-by: Stefano Stabellini Acked-by: Michael S. Tsirkin --- hw/i386/Makefile.objs

[Qemu-devel] [PULL 07/19] xen, gfx passthrough: retrieve VGA BIOS to work

2015-09-08 Thread Stefano Stabellini
From: Tiejun Chen Now we retrieve VGA bios like kvm stuff in qemu but we need to fix Device Identification in case if its not matched with the real IGD device since Seabios is always trying to compare this ID to work out VGA BIOS. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini Signed

[Qemu-devel] [PULL 04/19] piix: create host bridge to passthrough

2015-09-08 Thread Stefano Stabellini
From: Tiejun Chen Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. And we also just expose a minimal real host bridge pci configuration subset. Signed-off-by: Tiejun Chen Signed-off-by: Stefano Stabellini Acked-by: Michael S. Tsirkin --- hw

[Qemu-devel] [PULL 08/19] igd gfx passthrough: create a isa bridge

2015-09-08 Thread Stefano Stabellini
ned-off-by: Tiejun Chen Signed-off-by: Stefano Stabellini Acked-by: Michael S. Tsirkin --- hw/i386/pc_piix.c| 112 ++ include/hw/i386/pc.h |1 + 2 files changed, 113 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 626a19

Re: [Qemu-devel] [PATCH v2] Cleanups + various fixes due to libxl ABI + more logging on errors.

2015-09-08 Thread Stefano Stabellini
Applied On Tue, 8 Sep 2015, Konrad Rzeszutek Wilk wrote: > Hey! > > Since v2 (http://lists.xen.org/archives/html/xen-devel/2015-07/msg00431.html) > - Added Reviewed-by. > > since RFC > [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07326.html] > - Added Acks > - Followed 'xen: Pri

Re: [Qemu-devel] [PATCH v2 04/10] xen/pt: Remove XenPTReg->data field.

2015-09-08 Thread Stefano Stabellini
ld have only use u16. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Stefano Stabellini > hw/xen/xen_pt.h | 6 +++- > hw/xen/xen_pt_config_init.c | 73 > +++-- > 2 files changed, 49 insertions(+), 30 deletions(-) >

Re: [Qemu-devel] [Patch V1 3/3] xen: add pvUSB backend

2015-09-07 Thread Stefano Stabellini
On Thu, 3 Sep 2015, Juergen Gross wrote: > Add a backend for para-virtualized USB devices for xen domains. > > The backend is using host-libusb to forward USB requests from a > domain via libusb to the real device(s) passed through. > > Signed-off-by: Juergen Gross Aside from a few minor commen

Re: [Qemu-devel] [Patch V1 1/3] xen: introduce dummy system device

2015-09-07 Thread Stefano Stabellini
On Thu, 3 Sep 2015, Juergen Gross wrote: > Introduce a new dummy system device serving as parent for virtual > buses. This will enable new pv backends to introduce virtual buses > which are removable again opposed to system buses which are meant > to stay once added. > > Signed-off-by: Juergen Gro

Re: [Qemu-devel] [PATCH v1] xenpt: Properly handle 64-bit bar with more than 4G size

2015-08-06 Thread Stefano Stabellini
On Wed, 5 Aug 2015, Feng Wu wrote: > This patch corrects a logic error when handling 64-bt bar with > more than 4G size. > > With 64-bit Bar, it has two items in PCIDevice: io_regions[x] > and io_regions[x+1], io_regions[x] has all the informations for > this BAR, while io_regions[x+1] contains no

[Qemu-devel] [PULL for-2.4 2/2] migration: Fix regression for xenfv and pc, accel=xen machine.

2015-08-03 Thread Stefano Stabellini
e would break due to missing "configuration" section and section footers. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-common.c |5 + 1 file changed, 5 insertions(+) diff --git a/xen-common.c b/xen-common.c index 56359ca..0dcdbc3 100644 --- a/xen-comm

[Qemu-devel] [PULL for-2.4 1/2] migration: Fix global state with Xen.

2015-08-03 Thread Stefano Stabellini
state. Also, the toolstack expect QEMU to autostart when the migration is finished. So this patch store "running" as it's current runstate. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- include/migration/migration.h |1 + migration/migration.c

[Qemu-devel] [PULL for-2.4 0/2] Fix migration on Xen

2015-08-03 Thread Stefano Stabellini
The following changes since commit f60c87154ac722c528fd5582f7137914a93c5eec: configure: Drop vnc-ws feature from help text (2015-08-03 15:32:17 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-migration-2.4-tag for you to fetch ch

Re: [Qemu-devel] [Xen-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Amit Shah wrote: > On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote: > > Hi, > > > > We've spotted several regression which prevent migration with Xen using the > > same version of QEMU or from a previous version of QEMU (tryied with 2.2). > > > > Regression have been int

Re: [Qemu-devel] [PATCH for-2.4 v3 1/3] migration: Fix global state with Xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Anthony PERARD wrote: > When doing migration via the QMP command xen_save_devices_state, the > current runstate is not store into the global state section. Also the > current runstate is not the one we want on the receiver side. > > During migration, the Xen toolstack paused QE

Re: [Qemu-devel] [PATCH for-2.4 v3 3/3] migration: Fix regression for xenfv and pc, accel=xen machine.

2015-08-03 Thread Stefano Stabellini
27; machine, so migration from older version of QEMU used by Xen to newer > one would break due to missing "configuration" section and section footers. > > Signed-off-by: Anthony PERARD Reviewed-by: Stefano Stabellini > xen-common.c | 5 + > 1 file changed, 5 in

Re: [Qemu-devel] [PATCH for-2.4 v3 2/3] migration: Add configuration section to vmstate with xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Anthony PERARD wrote: > This adds the configuration section in the vmstate saved by > xen_save_devices_state. > > Signed-off-by: Anthony PERARD It doesn't seem to me that this patch is actually necessary to fix the issue, is that right? If that is the case, I would rather s

[Qemu-devel] [PULL for-2.4 1/1] Fix release_drive on unplugged devices (pci_piix3_xen_ide_unplug)

2015-08-03 Thread Stefano Stabellini
pci_piix3_xen_ide_unplug should completely unhook the unplugged IDEDevice from the corresponding BlockBackend, otherwise the next call to release_drive will try to detach the drive again. Suggested-by: Kevin Wolf Signed-off-by: Stefano Stabellini --- hw/ide/piix.c |7 +++ 1 file

[Qemu-devel] [PULL for-2.4 0/1] cve-2015-5166-tag

2015-08-03 Thread Stefano Stabellini
-2015-5166 -------- Stefano Stabellini (1): Fix release_drive on unplugged devices (pci_piix3_xen_ide_unplug) hw/ide/piix.c |7 +++ 1 file changed, 7 insertions(+)

Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Amit Shah wrote: > On (Fri) 31 Jul 2015 [10:59:47], Stefano Stabellini wrote: > > On Thu, 30 Jul 2015, Stefano Stabellini wrote: > > > On Thu, 30 Jul 2015, Juan Quintela wrote: > > > > Anthony PERARD wrote: > > > > > This is a cr

Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen.

2015-07-31 Thread Stefano Stabellini
On Thu, 30 Jul 2015, Stefano Stabellini wrote: > On Thu, 30 Jul 2015, Juan Quintela wrote: > > Anthony PERARD wrote: > > > This is a critical issue for Xen as migration either with the same version > > > of QEMU, or from a previous version of QEMU is broken. > >

Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen.

2015-07-30 Thread Stefano Stabellini
On Thu, 30 Jul 2015, Juan Quintela wrote: > Anthony PERARD wrote: > > This is a critical issue for Xen as migration either with the same version > > of QEMU, or from a previous version of QEMU is broken. > > > > Any suggestion on how to move forward? > > Will send a pull requset tomorrow. > > Th

Re: [Qemu-devel] [PATCH] xen: Drop net_rx_ok

2015-07-29 Thread Stefano Stabellini
On Mon, 27 Jul 2015, Stefan Hajnoczi wrote: > On Mon, Jul 20, 2015 at 06:12:09PM +0100, Stefan Hajnoczi wrote: > > On Thu, Jul 02, 2015 at 01:39:16PM +0100, Stefan Hajnoczi wrote: > > > On Tue, Jun 30, 2015 at 10:42:37AM +0800, Fam Zheng wrote: > > > > This is necessary because once we return false

Re: [Qemu-devel] [PATCH v3] xen/HVM: atomically access pointers in bufioreq handling

2015-07-24 Thread Stefano Stabellini
On Fri, 24 Jul 2015, Jan Beulich wrote: > The number of slots per page being 511 (i.e. not a power of two) means > that the (32-bit) read and write indexes going beyond 2^32 will likely > disturb operation. The hypervisor side gets I/O req server creation > extended so we can indicate that we're us

Re: [Qemu-devel] [PATCH v2] xen/HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Stefano Stabellini
On Thu, 23 Jul 2015, Jan Beulich wrote: > The number of slots per page being 511 (i.e. not a power of two) means > that the (32-bit) read and write indexes going beyond 2^32 will likely > disturb operation. The hypervisor side gets I/O req server creation > extended so we can indicate that we're us

Re: [Qemu-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Stefano Stabellini
On Thu, 23 Jul 2015, Stefano Stabellini wrote: > On Thu, 23 Jul 2015, Jan Beulich wrote: > > >>> On 22.07.15 at 19:24, wrote: > > > I'll queue this change up for the next QEMU release cycle. > > > > Thanks - v2 (with the adjusted description) just sen

Re: [Qemu-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-23 Thread Stefano Stabellini
On Thu, 23 Jul 2015, Jan Beulich wrote: > >>> On 22.07.15 at 19:24, wrote: > > I'll queue this change up for the next QEMU release cycle. > > Thanks - v2 (with the adjusted description) just sent. > > It would however be nice for our variant in 4.6 to also gain this, > perhaps independent of ups

Re: [Qemu-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-22 Thread Stefano Stabellini
On Wed, 22 Jul 2015, Stefano Stabellini wrote: > On Wed, 22 Jul 2015, Jan Beulich wrote: > > >>> On 22.07.15 at 16:50, wrote: > > > On Wed, 22 Jul 2015, Jan Beulich wrote: > > >> >> --- a/xen-hvm.c > > >> >> +++ b/xen-hvm.c > >

Re: [Qemu-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-22 Thread Stefano Stabellini
On Wed, 22 Jul 2015, Jan Beulich wrote: > >>> On 22.07.15 at 16:50, wrote: > > On Wed, 22 Jul 2015, Jan Beulich wrote: > >> >> --- a/xen-hvm.c > >> >> +++ b/xen-hvm.c > >> >> @@ -981,19 +981,30 @@ static void handle_ioreq(XenIOState *sta > >> >> > >> >> static int handle_buffered_iopage(XenIOSt

Re: [Qemu-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-22 Thread Stefano Stabellini
On Wed, 22 Jul 2015, Jan Beulich wrote: > >> The number of slots per page being 511 (i.e. not a power of two) means > >> that the (32-bit) read and write indexes going beyond 2^32 will likely > >> disturb operation. The hypervisor side gets I/O req server creation > >> extended so we can indicate t

Re: [Qemu-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-21 Thread Stefano Stabellini
On Thu, 18 Jun 2015, Jan Beulich wrote: > The number of slots per page being 511 (i.e. not a power of two) means > that the (32-bit) read and write indexes going beyond 2^32 will likely > disturb operation. The hypervisor side gets I/O req server creation > extended so we can indicate that we're us

Re: [Qemu-devel] [PATCH] xen/pt: Don't slurp wholesale the PCI configuration registers

2015-07-17 Thread Stefano Stabellini
Wilk Reviewed-by: Stefano Stabellini > hw/xen/xen_pt.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 05828e0..cd69cb4 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -780,12 +780,

Re: [Qemu-devel] [PATCH v1 05/10] xen/pt: Remove XenPTReg->data field.

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > We do not want to have two entries to cache the guest configuration > registers: XenPTReg->data and dev.config. Instead we want to use > only the dev.config. > > To do without much complications we rip out the ->data field > and replace it with an

Re: [Qemu-devel] [PATCH v1 08/10] xen/pt: Make xen_pt_unregister_device idempotent

2015-07-17 Thread Stefano Stabellini
int8_t intx; > int rc; > > -if (machine_irq) { > + /* Note that if xen_host_pci_device_put had closed config_fd, then > + * intx value becomes 0xff. */ > +intx = xen_pt_pci_intx(s); Wouldn't it make sense to move this assignment inside the if below? As

Re: [Qemu-devel] [PATCH v1 03/10] xen/pt: Check if reg->init function sets the 'data' past the reg->size

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > It should never happen, but in case it does (an developer adds > a new register and the 'init_val' expands past the register > size) we want to report. The code will only write up to > reg->size so there is no runtime danger of the register spillin

Re: [Qemu-devel] [PATCH v1 04/10] xen/pt: Use xen_host_pci_get_[byte, word, long] instead of xen_host_pci_get_long

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > Otherwise we get: > > xen_pt_config_reg_init: Offset 0x0004 mismatch! Emulated=0x, > host=0x2300017, syncing to 0x2300014. > xen_pt_config_reg_init: Error: Offset 0x0004:0x2300014 expands past register > size(2)! > > which is not surprising

Re: [Qemu-devel] [PATCH v1 02/10] xen/pt: Sync up the dev.config and data values.

2015-07-17 Thread Stefano Stabellini
type:4 > (XEN) p2m.c:920:d0v0 gfn_to_mfn failed! gfn=1 type:4 > .. > (XEN) memory_map: error -22 removing dom2 access to [fbce0,fbcff] > (DEBUG) 222 pci dev 04:0 BAR16 read upper 0x0. > (XEN) memory_map:remove: dom2 gfn=0 mfn=fbce0 nr=20 > (XEN)

Re: [Qemu-devel] [PATCH v1 01/10] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config

2015-07-17 Thread Stefano Stabellini
8_t - since the access is only > for one byte not four bytes. We can split this as a seperate > patch however we would have to use a cast to thwart compiler > warnings in the meantime. > > We also truncated 'flags' to 'flag' to make the code fit within >

Re: [Qemu-devel] [PATCH v1 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.

2015-07-17 Thread Stefano Stabellini
ompiler warnings. This is not the case now > but with the "xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config" > we will hit - so this sync up the function to the rest of them. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Stefano Stabellini > hw/xe

<    6   7   8   9   10   11   12   13   14   15   >