Re: [Qemu-devel] -device xen-platform crashes

2015-02-04 Thread Stefano Stabellini
On Mon, 2 Feb 2015, Markus Armbruster wrote: Stefano Stabellini stefano.stabell...@eu.citrix.com writes: On Fri, 30 Jan 2015, Markus Armbruster wrote: Stefano Stabellini stefano.stabell...@eu.citrix.com writes: On Thu, 29 Jan 2015, Markus Armbruster wrote: Stefano Stabellini

Re: [Qemu-devel] -device xen-platform crashes

2015-01-30 Thread Stefano Stabellini
On Fri, 30 Jan 2015, Markus Armbruster wrote: Stefano Stabellini stefano.stabell...@eu.citrix.com writes: On Thu, 29 Jan 2015, Markus Armbruster wrote: Stefano Stabellini stefano.stabell...@eu.citrix.com writes: On Thu, 29 Jan 2015, Markus Armbruster wrote: Reproducer: qemu

Re: [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastructure

2015-01-29 Thread Stefano Stabellini
On Thu, 29 Jan 2015, Xu, Quan wrote: -Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: Tuesday, January 20, 2015 1:15 AM To: Xu, Quan Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; stefano.stabell...@eu.citrix.com Subject: Re

Re: [Qemu-devel] -device xen-platform crashes

2015-01-29 Thread Stefano Stabellini
On Thu, 29 Jan 2015, Markus Armbruster wrote: Stefano Stabellini stefano.stabell...@eu.citrix.com writes: On Thu, 29 Jan 2015, Markus Armbruster wrote: Reproducer: qemu -nodefaults -S -display none -device xen-platform Yes, xen-platform makes no sense without Xen, but it shouldn't

Re: [Qemu-devel] -device xen-platform crashes

2015-01-29 Thread Stefano Stabellini
On Thu, 29 Jan 2015, Markus Armbruster wrote: Reproducer: qemu -nodefaults -S -display none -device xen-platform Yes, xen-platform makes no sense without Xen, but it shouldn't crash. Is it just a matter of doing the following? diff --git a/hw/i386/xen/xen_platform.c

Re: [Qemu-devel] [PATCH v2 00/14] block: Remove growable, add blk_new_open()

2015-01-26 Thread Stefano Stabellini
On Thu, 22 Jan 2015, Max Reitz wrote: This series removes the growable field from the BlockDriverState object. Its use was to clamp guest requests against the limits of the BDS; however, this can now be done more easily by moving those checks into the BlockBackend functions. In a future

Re: [Qemu-devel] [PATCH v3 00/14] block: Remove growable, add blk_new_open()

2015-01-26 Thread Stefano Stabellini
On Mon, 26 Jan 2015, Max Reitz wrote: This series removes the growable field from the BlockDriverState object. Its use was to clamp guest requests against the limits of the BDS; however, this can now be done more easily by moving those checks into the BlockBackend functions. In a future

[Qemu-devel] [PULL 0/1] Xen tree 2015-01-26

2015-01-26 Thread Stefano Stabellini
-2015-01-26 for you to fetch changes up to d01a5a3fe19645f3cdea1566f0e518ea2152a029: fix QEMU build on Xen/ARM (2015-01-26 11:56:33 +) Stefano Stabellini (1): fix QEMU build on Xen/ARM include/hw/xen/xen_common.h | 13

[Qemu-devel] [PULL 1/1] fix QEMU build on Xen/ARM

2015-01-26 Thread Stefano Stabellini
xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an unsigned long argument (in fact xen_pfn_t is defined as uint64_t on ARM). Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Reviewed-by: Don

Re: [Qemu-devel] [PATCH] fix QEMU build on Xen/ARM

2015-01-23 Thread Stefano Stabellini
On Thu, 22 Jan 2015, Don Slutz wrote: On 01/22/15 13:46, Stefano Stabellini wrote: xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an unsigned long argument (in fact xen_pfn_t is defined as uint64_t on ARM). Also use xc_hvm_param_get instead of the deprecated

[Qemu-devel] [PATCH v2] fix QEMU build on Xen/ARM

2015-01-23 Thread Stefano Stabellini
xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an unsigned long argument (in fact xen_pfn_t is defined as uint64_t on ARM). Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- Changes in v2

[Qemu-devel] [PATCH] fix QEMU build on Xen/ARM

2015-01-22 Thread Stefano Stabellini
xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an unsigned long argument (in fact xen_pfn_t is defined as uint64_t on ARM). Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com diff --git

[Qemu-devel] [PULL 0/4] Xen tree 2015-01-20

2015-01-20 Thread Stefano Stabellini
The following changes since commit 74acb99737dbedd86654d660c0c20815139a873c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20150119-1' into staging (2015-01-19 13:37:05 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

[Qemu-devel] [PULL 2/4] Xen: Use the ioreq-server API when available

2015-01-20 Thread Stefano Stabellini
if it is. Signed-off-by: Paul Durrant paul.durr...@citrix.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- configure | 29 ++ include/hw/xen/xen_common.h | 223 +++ trace-events|9 ++ xen-hvm.c

[Qemu-devel] [PULL 1/4] Add device listener interface

2015-01-20 Thread Stefano Stabellini
for arrival and departure of PCI devices. Signed-off-by: Paul Durrant paul.durr...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev.c | 53 +++ include/hw/qdev

Re: [Qemu-devel] [v3 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2015-01-20 Thread Stefano Stabellini
On Tue, 20 Jan 2015, Xu, Quan wrote: -Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: Tuesday, January 20, 2015 1:15 AM To: Xu, Quan Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; stefano.stabell...@eu.citrix.com Subject: Re

[Qemu-devel] [PULL 4/4] xen: add a lock for the mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini pbonz...@redhat.com Extend the existing dummy mapcache_lock/unlock macros to cover all of xen-mapcache.c. This prepares for unlocked memory access, when parts of exec.c will not be protected by the BQL. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- xen-mapcache.c |

Re: [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastructure

2015-01-20 Thread Stefano Stabellini
On Tue, 20 Jan 2015, Xu, Quan wrote: -Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: Tuesday, January 20, 2015 1:15 AM To: Xu, Quan Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; stefano.stabell...@eu.citrix.com Subject: Re

[Qemu-devel] [PULL 3/4] xen: do not use __-named variables in mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini pbonz...@redhat.com Keep the namespace clean. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- xen-mapcache.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/xen-mapcache.c b/xen-mapcache.c index

[Qemu-devel] [PULL v2 2/4] Xen: Use the ioreq-server API when available

2015-01-20 Thread Stefano Stabellini
if it is. Signed-off-by: Paul Durrant paul.durr...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- configure | 29 ++ include/hw/xen/xen_common.h | 223

[Qemu-devel] [PULL v2 3/4] xen: do not use __-named variables in mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini pbonz...@redhat.com Keep the namespace clean. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- xen-mapcache.c | 40 1 file changed, 20 insertions(+), 20

Re: [Qemu-devel] [PULL 0/4] Xen tree 2015-01-20

2015-01-20 Thread Stefano Stabellini
On Tue, 20 Jan 2015, Peter Maydell wrote: On 20 January 2015 at 11:19, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: The following changes since commit 74acb99737dbedd86654d660c0c20815139a873c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20150119-1

[Qemu-devel] [PULL v2 0/4] Xen tree 2015-01-20 v2

2015-01-20 Thread Stefano Stabellini
The following changes since commit 74acb99737dbedd86654d660c0c20815139a873c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-20150119-1' into staging (2015-01-19 13:37:05 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

[Qemu-devel] [PULL v2 4/4] xen: add a lock for the mapcache

2015-01-20 Thread Stefano Stabellini
From: Paolo Bonzini pbonz...@redhat.com Extend the existing dummy mapcache_lock/unlock macros to cover all of xen-mapcache.c. This prepares for unlocked memory access, when parts of exec.c will not be protected by the BQL. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Stefano

[Qemu-devel] [PULL v2 1/4] Add device listener interface

2015-01-20 Thread Stefano Stabellini
for arrival and departure of PCI devices. Signed-off-by: Paul Durrant paul.durr...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev.c | 53 +++ include/hw/qdev

Re: [Qemu-devel] [v3 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2015-01-19 Thread Stefano Stabellini
On Tue, 30 Dec 2014, Quan Xu wrote: This drvier transfers any request/repond between TPM xenstubdoms driver and Xen vTPM stubdom, and facilitates communications between Xen vTPM stubdom domain and vTPM xenstubdoms driver. It is a glue for the TPM xenstubdoms driver and Xen stubdom vTPM domain

Re: [Qemu-devel] [v3 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2015-01-19 Thread Stefano Stabellini
On Tue, 30 Dec 2014, Quan Xu wrote: +int vtpm_recv(struct XenDevice *xendev, uint8_t* buf, size_t *count) +{ +struct xen_vtpm_dev *vtpmdev = container_of(xendev, struct xen_vtpm_dev, +xendev); +struct tpmif_shared_page *shr =

Re: [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastructure

2015-01-19 Thread Stefano Stabellini
On Tue, 30 Dec 2014, Quan Xu wrote: This patch adds infrastructure for xen front drivers living in qemu, so drivers don't need to implement common stuff on their own. It's mostly xenbus management stuff: some functions to access XenStore, setting up XenStore watches, callbacks on device

Re: [Qemu-devel] [PATCH v3 0/5] QEMU:Xen stubdom vTPM for HVM virtual machine

2015-01-19 Thread Stefano Stabellini
Hi Quan, thanks for the update: this version is much much better than the previous one. I am not familiar enough with QAPI, HMP and TPM to review the first and the last patches though. Cheers, Stefano On Tue, 30 Dec 2014, Quan Xu wrote: *INTRODUCTION* The goal of virtual Trusted Platform

Re: [Qemu-devel] [PATCH v3 0/5] QEMU:Xen stubdom vTPM for HVM virtual machine

2015-01-19 Thread Stefano Stabellini
On Mon, 19 Jan 2015, Stefano Stabellini wrote: Hi Quan, thanks for the update: this version is much much better than the previous one. I am not familiar enough with QAPI, HMP and TPM to review the first and the last patches though. I meant the first and the fourth. The last one is fine

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-14 Thread Stefano Stabellini
On Tue, 13 Jan 2015, Don Slutz wrote: On 01/13/15 13:07, Stefano Stabellini wrote: On Mon, 12 Jan 2015, Stefano Stabellini wrote: On Wed, 3 Dec 2014, Don Slutz wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com Increase maxmem before calling

Re: [Qemu-devel] [RFH PATCH 1/2] xen: do not use __-named variables in mapcache

2015-01-14 Thread Stefano Stabellini
On Wed, 14 Jan 2015, Paolo Bonzini wrote: Keep the namespace clean. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com xen-mapcache.c | 40 1 file changed, 20 insertions(+), 20 deletions

Re: [Qemu-devel] [RFH PATCH 2/2] xen: add a lock for the mapcache

2015-01-14 Thread Stefano Stabellini
-by: Stefano Stabellini stefano.stabell...@eu.citrix.com xen-mapcache.c | 54 +++--- 1 file changed, 43 insertions(+), 11 deletions(-) diff --git a/xen-mapcache.c b/xen-mapcache.c index 458069b..8cefd0c 100644 --- a/xen-mapcache.c +++ b/xen-mapcache.c

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-13 Thread Stefano Stabellini
On Mon, 12 Jan 2015, Stefano Stabellini wrote: On Wed, 3 Dec 2014, Don Slutz wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com Increase maxmem before calling xc_domain_populate_physmap_exact to avoid the risk of running out of guest memory. This way we can also avoid

[Qemu-devel] [PULL 0/2] Xen tree 2015-01-13

2015-01-13 Thread Stefano Stabellini
failed Stefano Stabellini (1): xen-hvm: increase maxmem before calling xc_domain_populate_physmap hw/xen/xen_pt.c |2 +- xen-hvm.c | 24 2 files changed, 25 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 1/2] xen-pt: Fix PCI devices re-attach failed

2015-01-13 Thread Stefano Stabellini
From: Liang Li liang.z...@intel.com Use the 'xl pci-attach $DomU $BDF' command to attach more than one PCI devices to the guest, then detach the devices with 'xl pci-detach $DomU $BDF', after that, re-attach these PCI devices again, an error message will be reported like following: libxl:

[Qemu-devel] [PULL 2/2] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-13 Thread Stefano Stabellini
-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Don Slutz dsl...@verizon.com --- xen-hvm.c | 24 1 file changed, 24 insertions(+) diff --git a/xen-hvm.c b/xen-hvm.c index 7548794..e2e575b 100644 --- a/xen-hvm.c +++ b/xen-hvm.c @@ -90,6 +90,12 @@ static

Re: [Qemu-devel] [v2] xen-pt: Fix PCI devices re-attach failed

2015-01-13 Thread Stefano Stabellini
On Tue, 13 Jan 2015, Liang Li wrote: Use the 'xl pci-attach $DomU $BDF' command to attach more than one PCI devices to the guest, then detach the devices with 'xl pci-detach $DomU $BDF', after that, re-attach these PCI devices again, an error message will be reported like following:

Re: [Qemu-devel] [PATCH] xen-pt: Fix PCI devices re-attach failed

2015-01-12 Thread Stefano Stabellini
On Wed, 24 Dec 2014, Liang Li wrote: Use the 'xl pci-attach $DomU $BDF' command to attach more then one PCI devices to the guest, then detach the devices with 'xl pci-detach $DomU $BDF', after that, re-attach these PCI devices again, an error message will be reported like following: libxl:

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-12 Thread Stefano Stabellini
On Wed, 3 Dec 2014, Don Slutz wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com Increase maxmem before calling xc_domain_populate_physmap_exact to avoid the risk of running out of guest memory. This way we can also avoid complex memory calculations in libxl at domain

Re: [Qemu-devel] [Xen-devel] [PATCH] xen-pt: Fix PCI devices re-attach failed

2015-01-12 Thread Stefano Stabellini
On Mon, 12 Jan 2015, Paolo Bonzini wrote: On 12/01/2015 14:35, Li, Liang Z wrote: diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index c1bf357..f2893b2 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -736,7 +736,7 @@ static int xen_pt_initfn(PCIDevice *d) } out: -

Re: [Qemu-devel] bind interdomain ioctl error xen-kvm.c

2015-01-05 Thread Stefano Stabellini
On Tue, 30 Dec 2014, Rishi Ranjan wrote: I am trying to use Xen as accelerator for my Qemu machine. I have created a guest domain with following xl config:  builder = hvm name = qemu-hvm memory = 512 vcpus = 1 vif = [''] vnc = 1 boot=c When I try to run with following parameters: 

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-03 Thread Stefano Stabellini
On Wed, 3 Dec 2014, Wei Liu wrote: On Tue, Dec 02, 2014 at 03:23:29PM -0500, Don Slutz wrote: [...] hw_error(xc_domain_getinfo failed); } -if (xc_domain_setmaxmem(xen_xc, xen_domid, info.max_memkb + -(nr_pfn * XC_PAGE_SIZE / 1024)) 0) {

Re: [Qemu-devel] [PATCH v4 REPOST 1/2] Add device listener interface

2014-12-03 Thread Stefano Stabellini
The second patch is already Acked. You just need a review on this one to move forward, right? Andreas, Michael? On Wed, 3 Dec 2014, Paul Durrant wrote: The Xen ioreq-server API, introduced in Xen 4.5, requires that PCI device models explicitly register with Xen for config space accesses. This

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-03 Thread Stefano Stabellini
On Wed, 3 Dec 2014, Don Slutz wrote: On 12/03/14 07:20, Stefano Stabellini wrote: On Wed, 3 Dec 2014, Wei Liu wrote: On Tue, Dec 02, 2014 at 03:23:29PM -0500, Don Slutz wrote: [...] hw_error(xc_domain_getinfo failed

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-02 Thread Stefano Stabellini
On Mon, 1 Dec 2014, Don Slutz wrote: On 12/01/14 10:37, Stefano Stabellini wrote: On Mon, 1 Dec 2014, Don Slutz wrote: On 11/27/14 05:48, Stefano Stabellini wrote: [...] Works fine in both claim modes and with PoD used (maxmem memory). Do not know how to test with tmem. I

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-01 Thread Stefano Stabellini
On Mon, 1 Dec 2014, Don Slutz wrote: On 11/27/14 05:48, Stefano Stabellini wrote: On Wed, 26 Nov 2014, Don Slutz wrote: On 11/26/14 13:17, Stefano Stabellini wrote: On Tue, 25 Nov 2014, Andrew Cooper wrote: On 25/11/14 17:45, Stefano Stabellini wrote: Increase maxmem before

Re: [Qemu-devel] [2.2 PATCH V2] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
a temp variable in those functions. Cc: Wen Congyang we...@cn.fujitsu.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang jasow...@redhat.com Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Changes from V1: - Use

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-11-27 Thread Stefano Stabellini
On Wed, 26 Nov 2014, Don Slutz wrote: On 11/26/14 13:17, Stefano Stabellini wrote: On Tue, 25 Nov 2014, Andrew Cooper wrote: On 25/11/14 17:45, Stefano Stabellini wrote: Increase maxmem before calling xc_domain_populate_physmap_exact to avoid the risk of running out of guest memory

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
we...@cn.fujitsu.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang jasow...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Peter, can you pick this up or do you want a pull request? I can pick it up. I

Re: [Qemu-devel] [2.2 PATCH V2] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang jasow...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Peter, can you pick this up or do you want a pull request? I can pick it up. I was waiting a bit to check

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: On Nov 27, 2014 7:46 AM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: Konrad, I think we should have this fix in 4.5: without it vif=[ 'model=virtio-net' ] crashes QEMU. Is it an regression? Good question: I

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: On Nov 27, 2014 9:58 AM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: On Nov 27, 2014 7:46 AM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: On Nov 27, 2014 10:26 AM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: On Nov 27, 2014 9:58 AM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote

[Qemu-devel] [for 4.5] missing chunk in 11dffa2359e8a2629490c14c029c7c7c777b3e47

2014-11-27 Thread Stefano Stabellini
On Mon, 7 Jul 2014, Chunyan Liu wrote: diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index addacdb..4f1cbd2 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -479,6 +485,15 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, if

Re: [Qemu-devel] [Xen-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-26 Thread Stefano Stabellini
On Wed, 26 Nov 2014, Jason Wang wrote: On 11/25/2014 09:53 PM, Stefano Stabellini wrote: On Tue, 25 Nov 2014, Jason Wang wrote: On 11/25/2014 02:44 AM, Stefano Stabellini wrote: On Mon, 24 Nov 2014, Stefano Stabellini wrote: On Mon, 24 Nov 2014, Stefano Stabellini wrote: CC'ing Paolo

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-11-26 Thread Stefano Stabellini
On Tue, 25 Nov 2014, Andrew Cooper wrote: On 25/11/14 17:45, Stefano Stabellini wrote: Increase maxmem before calling xc_domain_populate_physmap_exact to avoid the risk of running out of guest memory. This way we can also avoid complex memory calculations in libxl at domain construction

Re: [Qemu-devel] [Xen-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-25 Thread Stefano Stabellini
On Tue, 25 Nov 2014, Jason Wang wrote: On 11/25/2014 02:44 AM, Stefano Stabellini wrote: On Mon, 24 Nov 2014, Stefano Stabellini wrote: On Mon, 24 Nov 2014, Stefano Stabellini wrote: CC'ing Paolo. Wen, thanks for the logs. I investigated a little bit and it seems to me

[Qemu-devel] [PATCH 4/4] virtio-net: do not leak cpu mappings

2014-11-25 Thread Stefano Stabellini
In virtio_net_handle_ctrl unmap the previously mapped out_sg, not a subset of it. This patch fixes an abort() when running on Xen. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com CC: jasow...@redhat.com CC: we...@cn.fujitsu.com CC: m...@redhat.com CC: pbonz...@redhat.com

[Qemu-devel] [PATCH 1/4] introduce virtqueue_unmap_sg

2014-11-25 Thread Stefano Stabellini
Introduce a function to unmap an sg previously mapped with virtqueue_map_sg. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com CC: jasow...@redhat.com CC: we...@cn.fujitsu.com CC: m...@redhat.com CC: pbonz...@redhat.com --- hw/virtio/virtio.c | 22

[Qemu-devel] [PATCH 0/4] virtio-net: do not leak cpu mappings

2014-11-25 Thread Stefano Stabellini
, but the behaviour is obviously incorrect without Xen too. The patch series fixes the issue by allowing virtio_net_handle_ctrl to unmap the original out_sg iov but still call virtqueue_fill and virtqueue_flush on the modified iov. The first three patches do not introduce any functional changes. Stefano

[Qemu-devel] [PATCH 2/4] use virtqueue_unmap_sg in virtqueue_fill

2014-11-25 Thread Stefano Stabellini
Use virtqueue_unmap_sg to unmap in_sg and out_sg in virtqueue_fill. No functional changes. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com CC: jasow...@redhat.com CC: we...@cn.fujitsu.com CC: m...@redhat.com CC: pbonz...@redhat.com --- hw/virtio/virtio.c | 20

[Qemu-devel] [PATCH 3/4] move virtqueue_unmap_sg calls from virtqueue_fill to virtqueue_push

2014-11-25 Thread Stefano Stabellini
from virtio_net_handle_ctrl with an open coded version it in place. No functional changes. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com CC: jasow...@redhat.com CC: we...@cn.fujitsu.com CC: m...@redhat.com CC: pbonz...@redhat.com --- hw/net/virtio-net.c |7 ++- hw

Re: [Qemu-devel] [PATCH 1/4] introduce virtqueue_unmap_sg

2014-11-25 Thread Stefano Stabellini
On Tue, 25 Nov 2014, Peter Maydell wrote: On 25 November 2014 at 14:43, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: Introduce a function to unmap an sg previously mapped with virtqueue_map_sg. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com CC: jasow

[Qemu-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-11-25 Thread Stefano Stabellini
-by: Stefano Stabellini stefano.stabell...@eu.citrix.com diff --git a/xen-hvm.c b/xen-hvm.c index 5c69a8d..38e08c3 100644 --- a/xen-hvm.c +++ b/xen-hvm.c @@ -218,6 +218,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr) unsigned long nr_pfn; xen_pfn_t *pfn_list

Re: [Qemu-devel] qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
CC'ing Paolo. Wen, thanks for the logs. I investigated a little bit and it seems to me that the bug occurs when QEMU tries to unmap only a portion of a memory region previously mapped. That doesn't work with xen-mapcache. See these logs for example: DEBUG address_space_map phys_addr=78ed8b44

Re: [Qemu-devel] [v2 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-24 Thread Stefano Stabellini
On Sun, 23 Nov 2014, Quan Xu wrote: This drvier transfers any request/repond between TPM xenstubdoms driver and Xen vTPM stubdom, and facilitates communications between Xen vTPM stubdom domain and vTPM xenstubdoms driver Signed-off-by: Quan Xu quan...@intel.com This patch needs a better

Re: [Qemu-devel] [v2 3/4] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms driver.

2014-11-24 Thread Stefano Stabellini
On Sun, 23 Nov 2014, Quan Xu wrote: This driver provides vTPM initialization and sending data and TPM commends to a Xen stubdom vTPM domain. Signed-off-by: Quan Xu quan...@intel.com We need a better, more detailed, patch description here. hw/tpm/Makefile.objs | 1 +

Re: [Qemu-devel] [v2 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Stefano Stabellini wrote: On Sun, 23 Nov 2014, Quan Xu wrote: +static void vtpm_backend_changed(struct XenDevice *xendev, const char *node) +{ +struct XenVtpmDev *vtpmdev = container_of(xendev, struct XenVtpmDev

Re: [Qemu-devel] [Xen-devel] qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Stefano Stabellini wrote: CC'ing Paolo. Wen, thanks for the logs. I investigated a little bit and it seems to me that the bug occurs when QEMU tries to unmap only a portion of a memory region previously mapped. That doesn't work with xen-mapcache. See these logs

Re: [Qemu-devel] [Xen-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Konrad Rzeszutek Wilk wrote: On Mon, Nov 24, 2014 at 06:44:45PM +, Stefano Stabellini wrote: On Mon, 24 Nov 2014, Stefano Stabellini wrote: On Mon, 24 Nov 2014, Stefano Stabellini wrote: CC'ing Paolo. Wen, thanks for the logs. I

[Qemu-devel] virtio leaks cpu mappings, was: qemu crash with virtio on Xen domUs (backtrace included)

2014-11-24 Thread Stefano Stabellini
On Mon, 24 Nov 2014, Stefano Stabellini wrote: On Mon, 24 Nov 2014, Stefano Stabellini wrote: CC'ing Paolo. Wen, thanks for the logs. I investigated a little bit and it seems to me that the bug occurs when QEMU tries to unmap only a portion of a memory region previously mapped

Re: [Qemu-devel] qemu 2.2 crash on linux hvm domU (full backtrace included)

2014-11-19 Thread Stefano Stabellini
On Wed, 19 Nov 2014, Fabio Fantoni wrote: Il 19/11/2014 15:56, Don Slutz ha scritto: I think I know what is happening here. But you are pointing at the wrong change. commit 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4 Is what I am guessing at this time is the issue. I think that

Re: [Qemu-devel] qemu 2.2 crash on linux hvm domU (full backtrace included)

2014-11-19 Thread Stefano Stabellini
On 11/19/14 10:52, Stefano Stabellini wrote: On Wed, 19 Nov 2014, Fabio Fantoni wrote: Il 19/11/2014 15:56, Don Slutz ha scritto: I think I know what is happening here. But you are pointing at the wrong change. commit 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Stefano Stabellini
Konrad, I think we should have this fix in Xen 4.5. Should I go ahead and backport it? On Mon, 17 Nov 2014, Don Slutz wrote: The other callers to blk_set_enable_write_cache() in this file already check for s-blk == NULL. Signed-off-by: Don Slutz dsl...@verizon.com --- I think this is a

Re: [Qemu-devel] [PATCH v3 for-xen-4.5] xen_disk: fix unmapping of persistent grants

2014-11-14 Thread Stefano Stabellini
. Signed-off-by: Roger Pau Monné roger@citrix.com Reported-by: George Dunlap george.dun...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: George Dunlap george.dun...@eu.citrix.com Cc: Konrad

[Qemu-devel] [PULL for-2.2 0/2] Xen tree 2014-11-14

2014-11-14 Thread Stefano Stabellini
The following changes since commit c52e67924fbdadfa00668248f5c075542943c54c: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-11-13 15:44:16 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

[Qemu-devel] [PULL for-2.2 1/2] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-14 Thread Stefano Stabellini
-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Paolo Bonzini pbonz...@redhat.com --- hw/acpi/piix4.c |4 hw/i386/pc_piix.c | 11 --- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 78c0a6d..481a16c

[Qemu-devel] [PULL for-2.2 2/2] xen_disk: fix unmapping of persistent grants

2014-11-14 Thread Stefano Stabellini
-by: Roger Pau Monné roger@citrix.com Reported-by: George Dunlap george.dun...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: George Dunlap george.dun...@eu.citrix.com Cc: Konrad Rzeszutek Wilk

Re: [Qemu-devel] [PATCH v2 for-xen-4.5] xen_disk: fix unmapping of persistent grants

2014-11-13 Thread Stefano Stabellini
if it has been batch-mapped. - Unmap persistent grants before switching to the closed state, so the frontend can also free them. Signed-off-by: Roger Pau Monné roger@citrix.com Reported-by: George Dunlap george.dun...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell

Re: [Qemu-devel] [PATCH] xen_disk: fix unmapping of persistent grants

2014-11-12 Thread Stefano Stabellini
before switching to the closed state, so the frontend can also free them. Signed-off-by: Roger Pau Monné roger@citrix.com Reported-and-Tested-by: George Dunlap george.dun...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Kevin Wolf kw...@redhat.com Cc: Stefan

Re: [Qemu-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

2014-11-11 Thread Stefano Stabellini
On Tue, 11 Nov 2014, Chen Gang wrote: In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to xen_main_loop_prepare() directly, need not use additional variable for it. Signed-off-by: Chen Gang gang.chen.5...@gmail.com Acked-by: Stefano Stabellini stefano.stabell

Re: [Qemu-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-10 Thread Stefano Stabellini
On Mon, 10 Nov 2014, Zhang, Yang Z wrote: Igor Mammedov wrote on 2014-05-23: if user starts QEMU with -machine pc,accel=xen, then compat property in xenfv won't work and it would cause error: Unsupported bus. Bus doesn't have property 'acpi-pcihp-bsel' set when PCI device is added with

Re: [Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-05 Thread Stefano Stabellini
On Tue, 4 Nov 2014, Xu, Quan wrote: -Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: Monday, November 03, 2014 7:54 PM To: Xu, Quan Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; stefano.stabell...@eu.citrix.com Subject: Re

Re: [Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-05 Thread Stefano Stabellini
On Wed, 5 Nov 2014, Xu, Quan wrote: -Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: Wednesday, November 05, 2014 7:01 PM To: Xu, Quan Cc: Stefano Stabellini; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: RE: [PATCH 2/4] Qemu

Re: [Qemu-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-04 Thread Stefano Stabellini
Feng, thanks for the email. I was assuming that one of the other maintainers would take care of the patch, but I am happy to submit a pull request for it too. Paolo, Michael? On Tue, 4 Nov 2014, Wu, Feng wrote: I still see this error in the latest QEMU. I find that this patch is not merged

Re: [Qemu-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-04 Thread Stefano Stabellini
On Tue, 4 Nov 2014, Paolo Bonzini wrote: On 04/11/2014 11:36, Stefano Stabellini wrote: Feng, thanks for the email. I was assuming that one of the other maintainers would take care of the patch, but I am happy to submit a pull request for it too. Paolo, Michael? I think

Re: [Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-03 Thread Stefano Stabellini
On Sun, 2 Nov 2014, Quan Xu wrote: This drvier transfers any request/repond between TPM xenstubdoms driver and Xen vTPM stubdom, and facilitates communications between Xen vTPM stubdom domain and vTPM xenstubdoms driver Signed-off-by: Quan Xu quan...@intel.com Please describe what changes

Re: [Qemu-devel] [PATCH 3/4] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms driver.

2014-11-03 Thread Stefano Stabellini
On Sun, 2 Nov 2014, Quan Xu wrote: This driver provides vTPM initialization and sending data and TPM commends to a Xen stubdom vTPM domain. ^ commands Driver for what? QEMU usually doesn't have drivers, QEMU has emulated devices. Is this an emulated device? Is it supposed to be run inside

[Qemu-devel] [PULL 0/2] Xen tree 2014-10-30

2014-10-31 Thread Stefano Stabellini
The following changes since commit cbd5ac699173b684e678d66df3aea33df81fd89f: virtio: link the rng backend through an alias property (2014-10-30 12:59:27 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2014-10-30 for you to fetch

[Qemu-devel] [PULL 1/2] xen-hvm.c: Add support for Xen access to vmport

2014-10-31 Thread Stefano Stabellini
Slutz dsl...@verizon.com Reviewed-by: Paul Durrant paul.durr...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- include/hw/xen/xen_common.h | 15 ++ xen-hvm.c | 108 +-- 2 files changed, 118

[Qemu-devel] [PULL 2/2] fix off-by-one error in pci_piix3_xen_ide_unplug

2014-10-31 Thread Stefano Stabellini
From: James Harper ja...@ejbdigital.com.au Fix off-by-one error when unplugging disks, which would otherwise leave the last ATA disk plugged, with obvious consequences. Also rewrite loop to be more readable. Signed-off-by: James Harper james.har...@ejbdigital.com.au Signed-off-by: Stefano

Re: [Qemu-devel] [Xen-devel] [PULL 0/2] Xen tree 2014-10-30

2014-10-31 Thread Stefano Stabellini
-devel-boun...@lists.xen.org [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Stefano Stabellini Sent: Thursday, October 30, 2014 10:21 PM To: qemu-devel@nongnu.org Cc: peter.mayd...@linaro.org; xen-de...@lists.xensource.com; Stefano Stabellini Subject: [Xen-devel] [PULL 0/2] Xen tree

Re: [Qemu-devel] [PATCH v7 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-21 Thread Stefano Stabellini
(). Signed-off-by: Don Slutz dsl...@verizon.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com I'll add it to my queue. Reviewed-by: Paul Durrant paul.durr...@citrix.com v7: Use QEMU_BUILD_BUG_ON, please do not define your own. Switched to QEMU_BUILD_BUG_ON

Re: [Qemu-devel] [PATCH v6 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-20 Thread Stefano Stabellini
On Mon, 20 Oct 2014, Don Slutz wrote: This adds synchronisation of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU. This is to avoid a 2nd and 3rd exchange between QEMU and Xen to fetch and put these 6 vcpu registers used by the code in vmport.c and

Re: [Qemu-devel] [PATCH v4 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-17 Thread Stefano Stabellini
On Fri, 17 Oct 2014, Don Slutz wrote: This adds synchronisation of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU. This is to avoid a 2nd and 3rd exchange between QEMU and Xen to fetch and put these 6 vcpu registers used by the code in vmport.c and

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Stefano Stabellini
On Thu, 16 Oct 2014, Paul Durrant wrote: -Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: 15 October 2014 15:38 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano Stabellini; Peter Maydell; Paolo

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Stefano Stabellini
On Wed, 15 Oct 2014, Peter Maydell wrote: On 15 October 2014 11:16, Paul Durrant paul.durr...@citrix.com wrote: The ioreq-server API added to Xen 4.5 offers better security than the existing Xen/QEMU interface because the shared pages that are used to pass emulation request/results back and

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Stefano Stabellini
On Thu, 16 Oct 2014, Peter Maydell wrote: On 16 October 2014 13:29, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: Unfortunately even though it is pretty x86 specific, it is still compiled on ARM, even though it is never actually used (it is used in i386 emulation with Xen

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-15 Thread Stefano Stabellini
if it is. Signed-off-by: Paul Durrant paul.durr...@citrix.com The patch is OK, so you can add my Acked-by. I have a couple of minor comments below. If you need to repost it then would be nice if you could address them. Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Peter Maydell

<    8   9   10   11   12   13   14   15   16   17   >