Re: [Qemu-devel] [PATCH v2 1/4] xen: move physmap saving into a separate function

2017-07-05 Thread Stefano Stabellini
On Tue, 4 Jul 2017, Igor Druzhinin wrote: > Non-functional change. > > Signed-off-by: Igor Druzhinin Unless you change something from a previous version, please retain the acked-by and reviewed-by that were given (see alpine.DEB.2.10.1706301629170.2919@sstabellini-ThinkPad-X260). > --- > hw/i

Re: [Qemu-devel] [PATCH 2/4] xen/mapcache: add an ability to create dummy mappings

2017-07-03 Thread Stefano Stabellini
On Mon, 3 Jul 2017, Igor Druzhinin wrote: > On 01/07/17 01:06, Stefano Stabellini wrote: > > On Fri, 30 Jun 2017, Igor Druzhinin wrote: > >> Dummys are simple anonymous mappings that are placed instead > >> of regular foreign mappings in certain situations when we need

Re: [Qemu-devel] [PATCH 4/4] xen: don't use xenstore to save/restore physmap anymore

2017-06-30 Thread Stefano Stabellini
On Fri, 30 Jun 2017, Igor Druzhinin wrote: > If we have a system with xenforeignmemory_map2() implemented > we don't need to save/restore physmap on suspend/restore > anymore. In case we resume a VM without physmap - try to > recreate the physmap during memory region restore phase and > remap map c

Re: [Qemu-devel] [PATCH 3/4] xen/mapcache: introduce xen_remap_cache_entry()

2017-06-30 Thread Stefano Stabellini
On Fri, 30 Jun 2017, Igor Druzhinin wrote: > This new call is trying to update a requested map cache entry > according to the changes in the physmap. The call is searching > for the entry, unmaps it, tries to translate the address and > maps again at the same place. If the mapping is dummy this cal

Re: [Qemu-devel] [PATCH 2/4] xen/mapcache: add an ability to create dummy mappings

2017-06-30 Thread Stefano Stabellini
On Fri, 30 Jun 2017, Igor Druzhinin wrote: > Dummys are simple anonymous mappings that are placed instead > of regular foreign mappings in certain situations when we need > to postpone the actual mapping but still have to give a > memory region to QEMU to play with. > > This is planned to be used

Re: [Qemu-devel] [PATCH 1/4] xen: move physmap saving into a separate function

2017-06-30 Thread Stefano Stabellini
On Fri, 30 Jun 2017, Igor Druzhinin wrote: > Non-functional change. > > Signed-off-by: Igor Druzhinin Reviewed-by: Stefano Stabellini > --- > hw/i386/xen/xen-hvm.c | 57 > --- > 1 file changed, 31 insertions(+), 26 d

Re: [Qemu-devel] [PATCH v5 5/5] 9pfs: handle transport errors in pdu_complete()

2017-06-28 Thread Stefano Stabellini
). > > This fixes Coverity issue CID1348518. > > Signed-off-by: Greg Kurz Reviewed-by: Stefano Stabellini > --- > hw/9pfs/9p.c | 23 +++ > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c &g

Re: [Qemu-devel] [PATCH v5 2/5] virtio-9p: message header is 7-byte long

2017-06-28 Thread Stefano Stabellini
pretty much everywhere. This patch > does the following: > - makes the assumption explicit in the common 9p.h header, since it isn't > related to the transport > - open codes the header size in handle_9p_output() and hardens the sanity > check on the space needed for the reply me

Re: [Qemu-devel] [PATCH v4 3/4] virtio-9p: break device if buffers are misconfigured

2017-06-28 Thread Stefano Stabellini
On Wed, 28 Jun 2017, Greg Kurz wrote: > On Wed, 28 Jun 2017 11:54:28 -0700 (PDT) > Stefano Stabellini wrote: > [...] > > > > @@ -125,10 +127,19 @@ static ssize_t xen_9pfs_pdu_vmarshal(V9fsPDU *pdu, > > > > Xen9pfsDev *xen_9pfs = container_of(pdu->s, Xen

Re: [Qemu-devel] [PATCH v4 3/4] virtio-9p: break device if buffers are misconfigured

2017-06-28 Thread Stefano Stabellini
On Wed, 28 Jun 2017, Greg Kurz wrote: > On Tue, 27 Jun 2017 16:34:51 -0700 (PDT) > Stefano Stabellini wrote: > > > On Tue, 27 Jun 2017, Greg Kurz wrote: > > > On Mon, 26 Jun 2017 16:22:23 -0700 (PDT) > > > Stefano Stabellini wrote: > > > &g

[Qemu-devel] [PATCH v2] xenfb: remove xen_init_display "temporary" hack

2017-06-28 Thread Stefano Stabellini
Initialize xenfb properly, as all other backends, from its own "initialise" function. Signed-off-by: Stefano Stabellini --- Changes in v2: - remove xen_init_display from xen_backend.h - handle cases where vkbd is missing diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c ind

Re: [Qemu-devel] Getting rid of xen_init_display() (and its dubious call into main_loop_wait())

2017-06-28 Thread Stefano Stabellini
On Wed, 28 Jun 2017, Peter Maydell wrote: > On 28 June 2017 at 01:06, Stefano Stabellini wrote: > > On Tue, 27 Jun 2017, Peter Maydell wrote: > >> So, there is exactly one caller of main_loop_wait() in the tree that > >> passes it 'true' as an argumen

Re: [Qemu-devel] Getting rid of xen_init_display() (and its dubious call into main_loop_wait())

2017-06-27 Thread Stefano Stabellini
unction with a busy loop > and a call into main_loop_wait()... LOL, you gotta love "temporary fixes". I am happy to see it wasn't me that added it ;-) I think the following should do the trick. --- xenfb: remove xen_init_display "temporary" hack Initialize xenfb properl

Re: [Qemu-devel] [PATCH v4 3/4] virtio-9p: break device if buffers are misconfigured

2017-06-27 Thread Stefano Stabellini
On Tue, 27 Jun 2017, Greg Kurz wrote: > On Mon, 26 Jun 2017 16:22:23 -0700 (PDT) > Stefano Stabellini wrote: > > > On Fri, 23 Jun 2017, Greg Kurz wrote: > > > The 9P protocol is transport agnostic: if the guest misconfigured the > > > buffers, the best we can do

[Qemu-devel] [PULL 3/3] xen-disk: add support for multi-page shared rings

2017-06-27 Thread Stefano Stabellini
-off-by: Paul Durrant Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini --- hw/block/xen_disk.c | 144 +--- 1 file changed, 113 insertions(+), 31 deletions(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 8218741

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/3] xen-disk: performance improvements

2017-06-27 Thread Stefano Stabellini
On Wed, 21 Jun 2017, Paul Durrant wrote: > Paul Durrant (3): > xen-disk: only advertize feature-persistent if grant copy is not > available > xen-disk: add support for multi-page shared rings > xen-disk: use an IOThread per instance > > hw/block/trace-events | 7 ++ > hw/block/xen_dis

[Qemu-devel] [PULL 2/3] xen-disk: only advertize feature-persistent if grant copy is not available

2017-06-27 Thread Stefano Stabellini
-by: Stefano Stabellini Reviewed-by: Stefano Stabellini --- hw/block/xen_disk.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 9200511..8218741 100644 --- a/hw/block/xen_disk.c +++ b/hw/block/xen_disk.c

[Qemu-devel] [PATCH 0/3] please pull xen-20170627-tag

2017-06-27 Thread Stefano Stabellini
2017/06/27 Paul Durrant (2): xen-disk: only advertize feature-persistent if grant copy is not available xen-disk: add support for multi-page shared rings Stefano Stabellini (1): xen/disk: don't leak stack data via response ring hw/block/x

[Qemu-devel] [PULL 1/3] xen/disk: don't leak stack data via response ring

2017-06-27 Thread Stefano Stabellini
. Reported by: Anthony Perard Signed-off-by: Jan Beulich Signed-off-by: Stefano Stabellini Acked-by: Anthony PERARD --- hw/block/xen_disk.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 3a22805..9200511

Re: [Qemu-devel] [PATCH v4 3/4] virtio-9p: break device if buffers are misconfigured

2017-06-26 Thread Stefano Stabellini
On Fri, 23 Jun 2017, Greg Kurz wrote: > The 9P protocol is transport agnostic: if the guest misconfigured the > buffers, the best we can do is to set the broken flag on the device. > > Since virtio_pdu_vmarshal() may be called by several active PDUs, we > check if the transport isn't broken alread

Re: [Qemu-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-26 Thread Stefano Stabellini
On Mon, 26 Jun 2017, Jan Beulich wrote: > >>> Stefano Stabellini 06/23/17 8:43 PM >>> > >On Fri, 23 Jun 2017, Jan Beulich wrote: > >> >>> On 22.06.17 at 20:52, wrote: > >> > I am happy to write the code and/or the commit message. Would

Re: [Qemu-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-23 Thread Stefano Stabellini
On Fri, 23 Jun 2017, Jan Beulich wrote: > >>> On 22.06.17 at 20:52, wrote: > > On Thu, 22 Jun 2017, Jan Beulich wrote: > >> >>> On 21.06.17 at 20:46, wrote: > >> > On Wed, 21 Jun 2017, Jan Beulich wrote: > >> >> >>> On 20.06.17 at 23:48, wrote: > >> >> > On Tue, 20 Jun 2017, Jan Beulich wrote: >

Re: [Qemu-devel] [PATCH v2 3/3] xen-disk: use an IOThread per instance

2017-06-22 Thread Stefano Stabellini
xen_disk instance and > sets the AIO context appropriately on connect. This allows processing > of I/O to proceed in parallel. > > The patch also adds tracepoints into xen_disk to make it possible to > follow the state transtions of an instance in the log. > > Signed-off-by: Paul

Re: [Qemu-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-22 Thread Stefano Stabellini
On Thu, 22 Jun 2017, Jan Beulich wrote: > >>> On 21.06.17 at 20:46, wrote: > > On Wed, 21 Jun 2017, Jan Beulich wrote: > >> >>> On 20.06.17 at 23:48, wrote: > >> > On Tue, 20 Jun 2017, Jan Beulich wrote: > >> >> @@ -36,13 +33,7 @@ struct blkif_x86_32_request_discard { > >> >> blkif_sector_t

Re: [Qemu-devel] [PATCH v2 1/3] xen-disk: only advertize feature-persistent if grant copy is not available

2017-06-21 Thread Stefano Stabellini
> > Signed-off-by: Paul Durrant Reviewed-by: Stefano Stabellini > --- > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Kevin Wolf > Cc: Max Reitz > --- > hw/block/xen_disk.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) >

Re: [Qemu-devel] [PATCH v2 2/3] xen-disk: add support for multi-page shared rings

2017-06-21 Thread Stefano Stabellini
ed > ring up to order 4 (i.e. 16 pages). > > Signed-off-by: Paul Durrant Reviewed-by: Stefano Stabellini > --- > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Kevin Wolf > Cc: Max Reitz > > v2: > - Fix memory leak in error path > - Print warning

Re: [Qemu-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-21 Thread Stefano Stabellini
On Wed, 21 Jun 2017, Jan Beulich wrote: > >>> On 20.06.17 at 23:48, wrote: > > On Tue, 20 Jun 2017, Jan Beulich wrote: > >> @@ -36,13 +33,7 @@ struct blkif_x86_32_request_discard { > >> blkif_sector_t sector_number;/* start sector idx on disk (r/w > >> only) */ > >> uint64_t

Re: [Qemu-devel] [PATCH 2/3] xen-disk: add support for multi-page shared rings

2017-06-20 Thread Stefano Stabellini
ed > ring up to order 4 (i.e. 16 pages). > > Signed-off-by: Paul Durrant Thanks for the patch! > --- > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Kevin Wolf > Cc: Max Reitz > --- > hw/block/xen_disk.c | 141 > -

Re: [Qemu-devel] [PATCH 1/3] xen-disk: only advertize feature-persistent if grant copy is not available

2017-06-20 Thread Stefano Stabellini
e that it should be the case. Why is feature_grant_copy (without feature-persistent) better than feature-persistent (without feature_grant_copy)? Shouldn't we simply avoid grant copies to copy data to persistent grants? > --- > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc:

Re: [Qemu-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-20 Thread Stefano Stabellini
On Tue, 20 Jun 2017, Jan Beulich wrote: > Rather than constructing a local structure instance on the stack, fill > the fields directly on the shared ring, just like other (Linux) > backends do. Build on the fact that all response structure flavors are > actually identical (the old code did make thi

Re: [Qemu-devel] [PATCH 2/4] xenfb: Activate mouse handler

2017-06-08 Thread Stefano Stabellini
On Thu, 8 Jun 2017, Owen Smith wrote: > Mouse events are only delivered to the first handler in the chain. > Activating the xenfb mouse event handler so that mouse events can > be passed over the shared ring protocol. > Note: The keyboard handler is activated internally by the add > call. I am not

Re: [Qemu-devel] [PATCH 1/4] xenfb: Add feature-vkbd-standalone

2017-06-08 Thread Stefano Stabellini
-return -1; > +if (xenstore_read_fe_int(xendev, "request-vkbd-standalone", > + &in->vkbd_standalone) == -1) { > +in->vkbd_standalone = 0; > +} > +if (in->vkbd_standalone ==

Re: [Qemu-devel] [PATCH 0/4] xenfb: Add vkbd-only option

2017-06-08 Thread Stefano Stabellini
On Thu, 8 Jun 2017, Owen Smith wrote: > Adds the ability for a vkbd device to connect without the > QemuConsole, in order to support a standalone PV mouse and > keyboard frontend. > This series adds a new feature flag, which will need adding > to the xen's include/public/io/kbdif.h Please do so, I

[Qemu-devel] [PULL 4/4] xen: call qemu_set_cloexec instead of fcntl

2017-05-16 Thread Stefano Stabellini
Use the common utility function, which contains checks on return values and first calls F_GETFD as recommended by POSIX.1-2001, instead of manually calling fcntl. CID: 1374831 Signed-off-by: Stefano Stabellini Reviewed-by: Eric Blake Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com CC: gr

[Qemu-devel] [PULL 3/4] xen/9pfs: fix two resource leaks on error paths, discovered by Coverity

2017-05-16 Thread Stefano Stabellini
CID: 1374836 Signed-off-by: Stefano Stabellini Reviewed-by: Eric Blake Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com CC: gr...@kaod.org CC: aneesh.ku...@linux.vnet.ibm.com --- hw/9pfs/xen-9p-backend.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/9pfs/xen-9p-backend.c b/hw

[Qemu-devel] [PULL 2/4] configure: Remove -lxencall for Xen detection

2017-05-16 Thread Stefano Stabellini
From: Anthony PERARD QEMU does not depends on libxencall, it was added because it was a missing link dependency of libxendevicemodel, but now the later should be built properly. Signed-off-by: Anthony PERARD Reviewed-by: Stefano Stabellini --- configure | 2 +- 1 file changed, 1 insertion

[Qemu-devel] [PULL 1/4] xen/mapcache: store dma information in revmapcache entries for debugging

2017-05-16 Thread Stefano Stabellini
ed, we print a warning if any [b] mappings exist. We ignore [a] mappings. Mappings created by qemu_map_ram_ptr are assumed to be [a], while mappings created by address_space_map->qemu_ram_ptr_length are assumed to be [b]. The goal of the patch is to make debugging and system understanding easi

[Qemu-devel] [PULL 0/4] please pull xen-20170516-tag

2017-05-16 Thread Stefano Stabellini
PERARD (1): configure: Remove -lxencall for Xen detection Stefano Stabellini (3): xen/mapcache: store dma information in revmapcache entries for debugging xen/9pfs: fix two resource leaks on error paths, discovered by Coverity xen: call qemu_set_cloexec instead of fcntl

Re: [Qemu-devel] [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec

2017-05-16 Thread Stefano Stabellini
On Thu, 11 May 2017, Paolo Bonzini wrote: > On 09/05/2017 21:04, Stefano Stabellini wrote: > > Assert that the return value is not an error. This issue was found by > > Coverity. > > > > CID: 1374831 > > > > Signed-off-by: Stefano Stabellini > > C

Re: [Qemu-devel] [PATCH] configure: Remove -lxencall for Xen detection

2017-05-15 Thread Stefano Stabellini
On Thu, 11 May 2017, Anthony PERARD wrote: > QEMU does not depends on libxencall, it was added because it was a > missing link dependency of libxendevicemodel, but now the later should > be built properly. > > Signed-off-by: Anthony PERARD Reviewed-by: Stefano Stabellini >

Re: [Qemu-devel] [PATCH v2 1/3] xen/9pfs: fix two resource leaks on error paths, discovered by Coverity

2017-05-09 Thread Stefano Stabellini
On Tue, 9 May 2017, Eric Blake wrote: > On 05/09/2017 02:20 PM, Eric Blake wrote: > > On 05/09/2017 02:04 PM, Stefano Stabellini wrote: > >> CID: 1374836 > >> > >> Signed-off-by: Stefano Stabellini > >> CC: anthony.per...@citrix.com > >> CC: g

[Qemu-devel] [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec

2017-05-09 Thread Stefano Stabellini
Assert that the return value is not an error. This issue was found by Coverity. CID: 1374831 Signed-off-by: Stefano Stabellini CC: gr...@kaod.org CC: pbonz...@redhat.com CC: Eric Blake --- util/oslib-posix.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/oslib

[Qemu-devel] [PATCH v2 3/3] xen: call qemu_set_cloexec instead of fcntl

2017-05-09 Thread Stefano Stabellini
Use the common utility function, which contains checks on return values, instead of manually calling fcntl. CID: 1374831 Signed-off-by: Stefano Stabellini CC: anthony.per...@citrix.com CC: gr...@kaod.org CC: aneesh.ku...@linux.vnet.ibm.com CC: Eric Blake --- hw/9pfs/xen-9p-backend.c | 2

[Qemu-devel] [PATCH v2 1/3] xen/9pfs: fix two resource leaks on error paths, discovered by Coverity

2017-05-09 Thread Stefano Stabellini
CID: 1374836 Signed-off-by: Stefano Stabellini CC: anthony.per...@citrix.com CC: gr...@kaod.org CC: aneesh.ku...@linux.vnet.ibm.com --- hw/9pfs/xen-9p-backend.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index 9c7f41a..a1fdede

Re: [Qemu-devel] [PATCH] Fix issues affecting Xen 9pfs discovered by Coverity

2017-05-08 Thread Stefano Stabellini
On Mon, 8 May 2017, Stefano Stabellini wrote: > On Mon, 8 May 2017, Eric Blake wrote: > > On 05/08/2017 03:45 PM, Stefano Stabellini wrote: > > > Fix two resource leaks on error paths, discovered by Coverity. > > > Check for errors returned by fcntl, also found by

Re: [Qemu-devel] [PATCH] Fix issues affecting Xen 9pfs discovered by Coverity

2017-05-08 Thread Stefano Stabellini
On Mon, 8 May 2017, Eric Blake wrote: > On 05/08/2017 03:45 PM, Stefano Stabellini wrote: > > Fix two resource leaks on error paths, discovered by Coverity. > > Check for errors returned by fcntl, also found by Coverity. > > > > CID:1374836 > > CID:1374831 > &

[Qemu-devel] [PATCH] Fix issues affecting Xen 9pfs discovered by Coverity

2017-05-08 Thread Stefano Stabellini
Fix two resource leaks on error paths, discovered by Coverity. Check for errors returned by fcntl, also found by Coverity. CID:1374836 CID:1374831 Signed-off-by: Stefano Stabellini diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index 9c7f41a..f75e728 100644 --- a/hw/9pfs/xen

[Qemu-devel] [PATCH v2] xen/mapcache: store dma information in revmapcache entries for debugging

2017-05-03 Thread Stefano Stabellini
he is called, we print a warning if any [b] mappings exist. We ignore [a] mappings. Mappings created by qemu_map_ram_ptr are assumed to be [a], while mappings created by address_space_map->qemu_ram_ptr_length are assumed to be [b]. The goal of the patch is to make debugging and system understanding easi

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

2017-05-03 Thread Stefano Stabellini
On Wed, 3 May 2017, Stefano Stabellini wrote: > On Wed, 3 May 2017, Anthony PERARD wrote: > > On Wed, May 03, 2017 at 10:20:59AM -0700, Stefano Stabellini wrote: > > > On Wed, 3 May 2017, Anthony PERARD wrote: > > > > On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

2017-05-03 Thread Stefano Stabellini
On Wed, 3 May 2017, Anthony PERARD wrote: > On Wed, May 03, 2017 at 10:20:59AM -0700, Stefano Stabellini wrote: > > On Wed, 3 May 2017, Anthony PERARD wrote: > > > On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > > > > On Thu, 20 Apr 2017, Paul Du

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

2017-05-03 Thread Stefano Stabellini
On Wed, 3 May 2017, Anthony PERARD wrote: > On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > > On Thu, 20 Apr 2017, Paul Durrant wrote: > > > I think xencall should be part of the base xen_stable_libs anyway. > > > > Yes, you are right. However

[Qemu-devel] [PATCH RFC] xen/mapcache: store dma information in revmapcache entries for debugging

2017-05-02 Thread Stefano Stabellini
he is called, we print a warning if any [b] mappings exist. We ignore [a] mappings. Mappings created by qemu_map_ram_ptr are assumed to be [a], while mappings created by address_space_map->qemu_ram_ptr_length are assumed to be [b]. The goal of the patch is to make debugging and system understanding easi

Re: [Qemu-devel] [RFC/BUG] xen-mapcache: buggy invalidate map cache?

2017-04-28 Thread Stefano Stabellini
On Thu, 13 Apr 2017, Herongguang (Stephen) wrote: > On 2017/4/13 7:51, Stefano Stabellini wrote: > > On Wed, 12 Apr 2017, Herongguang (Stephen) wrote: > > > On 2017/4/12 6:32, Stefano Stabellini wrote: > > > > On Tue, 11 Apr 2017, hrg wrote: > > > >

Re: [Qemu-devel] [PATCH] ACPI: don't call acpi_pcihp_device_plug_cb on xen

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Bruce Rogers wrote: > >>> On 4/27/2017 at 03:09 PM, Stefano Stabellini > >>> wrote: > > On Thu, 27 Apr 2017, Bruce Rogers wrote: > >> Commit f0c9d64a exposed the issue that with a xenfv machine using > >> pci passthrough, acp

Re: [Qemu-devel] [PATCH] ACPI: don't call acpi_pcihp_device_plug_cb on xen

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Bruce Rogers wrote: > Commit f0c9d64a exposed the issue that with a xenfv machine using > pci passthrough, acpi cpi hotplug code was being executed by mistake. > Guard calls to acpi_pcihp_device_plug_cb (and corresponding > acpi_pcihp_device_unplug_cb) with a check for xen_enab

Re: [Qemu-devel] [PATCH v2 4/4] 9pfs: handle broken transport

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Greg Kurz wrote: > The 9p protocol is transport agnostic: if an error occurs when copying data > to/from the client, this should be handled by the transport layer [1] and > the 9p server should simply stop processing requests [2]. > > [1] can be implemented in the transport ma

Re: [Qemu-devel] [PATCH v2 2/4] 9pfs: drop pdu_push_and_notify()

2017-04-27 Thread Stefano Stabellini
ld probably turn this into a static inline and keep it around as syntactic sugar. Regardless: Reviewed-by: Stefano Stabellini > -{ > -pdu->s->transport->push_and_notify(pdu); > -} > - > static int omode_to_uflags(int8_t mode) > { > int ret = 0; > @@

Re: [Qemu-devel] [PATCH v2 1/4] fsdev: don't allow unknown format in marshal/unmarshal

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Greg Kurz wrote: > The code only uses well known format strings. An unknown format token is a > bug. > > Signed-off-by: Greg Kurz Reviewed-by: Stefano Stabellini > --- > fsdev/9p-iov-marshal.c |4 ++-- > 1 file changed, 2 insertions(+), 2 d

Re: [Qemu-devel] [PATCH] virtio-9p/xen-9p: move 9p specific bits to core 9p code

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Greg Kurz wrote: > These bits aren't related to the transport so let's move them to the core > code. > > Signed-off-by: Greg Kurz Reviewed-by: Stefano Stabellini > --- > hw/9pfs/9p.c |8 +++- > hw/9pfs/9p.h

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Igor Mammedov wrote: > On Thu, 27 Apr 2017 10:51:23 -0600 > "Bruce Rogers" wrote: > > > > > > > >>> On 4/27/2017 at 10:08 AM, Igor Mammedov wrote: > > > On Thu, 27 Apr 2017 09:44:31 -0600 > > > "Bruce Rogers" wrote: > > > > > >> >>> On 4/27/2017 at 03:11 AM, Igor Mammed

[Qemu-devel] [PATCH 20/21] move xen-hvm.c to hw/i386/xen/

2017-04-25 Thread Stefano Stabellini
From: Anthony Xu move xen-hvm.c to hw/i386/xen/ Signed-off -by: Anthony Xu Reviewed-by: Stefano Stabellini --- Makefile.target |3 +- hw/i386/xen/Makefile.objs |2 +- hw/i386/xen/trace-events | 11 + hw/i386/xen/xen-hvm.c | 1429

[Qemu-devel] [PATCH 16/21] xen/9pfs: send responses back to the frontend

2017-04-25 Thread Stefano Stabellini
. Signed-off-by: Stefano Stabellini CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: Aneesh Kumar K.V CC: Greg Kurz --- hw/9pfs/xen-9p-backend.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index 9068703..9c7f41a

[Qemu-devel] [PATCH 10/21] xen: import ring.h from xen

2017-04-25 Thread Stefano Stabellini
Do not use the ring.h header installed on the system. Instead, import the header into the QEMU codebase. This avoids problems when QEMU is built against a Xen version too old to provide all the ring macros. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com

[Qemu-devel] [PATCH 21/21] move xen-mapcache.c to hw/i386/xen/

2017-04-25 Thread Stefano Stabellini
From: Anthony Xu move xen-mapcache.c to hw/i386/xen/ Signed-off -by: Anthony Xu Reviewed-by: Stefano Stabellini --- Makefile.target| 3 - default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/i386/xen/Makefile.objs | 2

[Qemu-devel] [PATCH 11/21] 9p: introduce a type for the 9p header

2017-04-25 Thread Stefano Stabellini
Use the new type in virtio-9p-device. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: Aneesh Kumar K.V CC: Greg Kurz --- hw/9pfs/9p.h | 6 ++ hw/9pfs/virtio-9p-device.c | 6

[Qemu-devel] [PATCH 19/21] move xen-common.c to hw/xen/

2017-04-25 Thread Stefano Stabellini
From: Anthony Xu move xen-common.c to hw/xen/ Signed-off -by: Anthony Xu Reviewed-by: Stefano Stabellini --- Makefile.target | 2 - hw/xen/Makefile.objs | 2 +- hw/xen/xen-common.c | 169 +++ stubs/Makefile.objs | 1 + stubs/xen

[Qemu-devel] [PATCH 08/21] xen: additionally restrict xenforeignmemory operations

2017-04-25 Thread Stefano Stabellini
a=commit;h=5823d6eb Signed-off-by: Paul Durrant Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini --- include/hw/xen/xen_common.h | 134 ++-- 1 file changed, 78 insertions(+), 56 deletions(-) diff --git a/include/hw/xen/xen_common.h b/incl

[Qemu-devel] [PATCH 17/21] xen/9pfs: build and register Xen 9pfs backend

2017-04-25 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: Aneesh Kumar K.V CC: Greg Kurz --- hw/9pfs/Makefile.objs| 1 + hw/xen/xen_backend.c | 3 +++ include/hw/xen/xen_backend.h | 3 +++ 3 files changed, 7 insertions

[Qemu-devel] [PATCH 13/21] xen/9pfs: connect to the frontend

2017-04-25 Thread Stefano Stabellini
Write the limits of the backend to xenstore. Connect to the frontend. Upon connection, allocate the rings according to the protocol specification. Initialize a QEMUBH to schedule work upon receiving an event channel notification from the frontend. Signed-off-by: Stefano Stabellini CC

[Qemu-devel] [PATCH 07/21] xen: use libxendevice model to restrict operations

2017-04-25 Thread Stefano Stabellini
Reviewed-by: Stefano Stabellini --- hw/xen/trace-events | 1 + include/hw/xen/xen.h| 1 + include/hw/xen/xen_common.h | 20 qemu-options.hx | 7 +++ vl.c| 8 xen-hvm.c | 8 6 files

[Qemu-devel] [PATCH 15/21] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal

2017-04-25 Thread Stefano Stabellini
Implement xen_9pfs_init_in/out_iov_from_pdu and xen_9pfs_pdu_vmarshal/vunmarshall by creating new sg pointing to the data on the ring. This is safe as we only handle one request per ring at any given time. Signed-off-by: Stefano Stabellini CC: anthony.per...@citrix.com CC: jgr...@suse.com CC

[Qemu-devel] [PATCH 18/21] add xen-9p-backend to MAINTAINERS under Xen

2017-04-25 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: gr...@kaod.org CC: anthony.per...@citrix.com --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 779c429..420505e 100644 --- a/MAINTAINERS +++ b

[Qemu-devel] [PATCH 09/21] configure: use pkg-config for obtaining xen version

2017-04-25 Thread Stefano Stabellini
rgen Gross Signed-off-by: Stefano Stabellini Tested-by: Paul Durrant Reviewed-by: Stefano Stabellini --- configure | 159 ++ 1 file changed, 88 insertions(+), 71 deletions(-) diff --git a/configure b/configure index 271bea8..3133

[Qemu-devel] [PATCH 05/21] xen: use libxendevicemodel when available

2017-04-25 Thread Stefano Stabellini
From: Paul Durrant This patch modifies the wrapper functions in xen_common.h to use the new xendevicemodel interface if it is available along with compatibility code to use the old libxenctrl interface if it is not. Signed-off-by: Paul Durrant Signed-off-by: Stefano Stabellini Reviewed-by

[Qemu-devel] [PATCH 14/21] xen/9pfs: receive requests from the frontend

2017-04-25 Thread Stefano Stabellini
Upon receiving an event channel notification from the frontend, schedule the bottom half. From the bottom half, read one request from the ring, create a pdu and call pdu_submit to handle it. For now, only handle one request per ring at a time. Signed-off-by: Stefano Stabellini CC: anthony.per

[Qemu-devel] [PATCH 12/21] xen/9pfs: introduce Xen 9pfs backend

2017-04-25 Thread Stefano Stabellini
Introduce the Xen 9pfs backend: add struct XenDevOps to register as a Xen backend and add struct V9fsTransport to register as v9fs transport. All functions are empty stubs for now. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com CC: jgr...@suse.com CC

[Qemu-devel] [PATCH 04/21] configure: detect presence of libxendevicemodel

2017-04-25 Thread Stefano Stabellini
From: Paul Durrant This patch adds code in configure to set CONFIG_XEN_CTRL_INTERFACE_VERSION to a new value of 490 if libxendevicemodel is present in the build environment. Signed-off-by: Paul Durrant Signed-off-by: Stefano Stabellini Reviewed-by: Anthony Perard Reviewed-by: Stefano

[Qemu-devel] [PATCH 01/21] xen: make use of xen_xc implicit in xen_common.h inlines

2017-04-25 Thread Stefano Stabellini
_fmem from xen_backend.h to xen_common.h, and the declarations from xen_backend.c to xen-common.c, which is where they belong. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Reviewed-by: Stefano Stabellini --- hw/xen/xen_backend.c | 2 - include/hw/xen/xen_backend.h | 2 - incl

[Qemu-devel] [PATCH 06/21] xen: use 5 digit xen versions

2017-04-25 Thread Stefano Stabellini
version 4.8.0). Signed-off-by: Juergen Gross Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini --- configure | 16 hw/block/xen_disk.c | 2 +- include/hw/xen/xen_common.h | 22 +++--- 3 files changed, 20 insertions(+), 20 delet

[Qemu-devel] [PATCH 03/21] xen: create wrappers for all other uses of xc_hvm_XXX() functions

2017-04-25 Thread Stefano Stabellini
Reviewed-by: Anthony Perard Reviewed-by: Stefano Stabellini --- hw/i386/xen/xen_platform.c | 2 +- include/hw/xen/xen_common.h | 44 xen-hvm.c | 27 +-- 3 files changed, 58 insertions(+), 15 deletions

[Qemu-devel] [PATCH 02/21] xen: rename xen_modified_memory() to xen_hvm_modified_memory()

2017-04-25 Thread Stefano Stabellini
From: Paul Durrant This patch is a purely cosmetic change that avoids a name collision in a subsequent patch. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Reviewed-by: Stefano Stabellini --- include/exec/ram_addr.h | 4 ++-- include/hw/xen/xen.h| 2 +- xen-hvm-stub.c

[Qemu-devel] [PULL 0/21] Please pull xen-20170421-v2-tag for 2.10

2017-04-25 Thread Stefano Stabellini
libxendevicemodel when available xen: use libxendevice model to restrict operations xen: additionally restrict xenforeignmemory operations Stefano Stabellini (9): xen: import ring.h from xen 9p: introduce a type for the 9p header xen/9pfs: introduce Xen 9pfs backend

Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10

2017-04-25 Thread Stefano Stabellini
On Tue, 25 Apr 2017, Markus Armbruster wrote: > Stefano Stabellini writes: > > > On Mon, 24 Apr 2017, Peter Maydell wrote: > >> On 24 April 2017 at 22:25, Stefano Stabellini > >> wrote: > >> > diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h > &

Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10

2017-04-24 Thread Stefano Stabellini
On Mon, 24 Apr 2017, Peter Maydell wrote: > On 24 April 2017 at 22:25, Stefano Stabellini wrote: > > diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h > > new file mode 100644 > > index 000..18f0ec0 > > --- /dev/null > > +++ b/hw/9pfs/xen-9pfs.h > >

Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10

2017-04-24 Thread Stefano Stabellini
On Mon, 24 Apr 2017, Peter Maydell wrote: > On 21 April 2017 at 21:14, Stefano Stabellini wrote: > > The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: > > > > Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) > > > > ar

Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

2017-04-24 Thread Stefano Stabellini
tor.c gdbstub.c balloon.c > > ioport.c bootdevice.c memory.c cputlb.c memory_mapping.c dump.c. > > > > Maybe a sysemu/ subdir? In that case, should we still create an > > accel/ subdir, or move xen-*, kvm-* and friends to sysemu/ too? > > > > Cc: Paolo Bonzini &

[Qemu-devel] [PULL 21/21] move xen-mapcache.c to hw/i386/xen/

2017-04-21 Thread Stefano Stabellini
From: Anthony Xu move xen-mapcache.c to hw/i386/xen/ Signed-off -by: Anthony Xu Reviewed-by: Stefano Stabellini --- Makefile.target| 3 - default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/i386/xen/Makefile.objs | 2

[Qemu-devel] [PULL 18/21] add xen-9p-backend to MAINTAINERS under Xen

2017-04-21 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: gr...@kaod.org CC: anthony.per...@citrix.com --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 779c429..420505e 100644 --- a/MAINTAINERS +++ b

[Qemu-devel] [PULL 16/21] xen/9pfs: send responses back to the frontend

2017-04-21 Thread Stefano Stabellini
. Signed-off-by: Stefano Stabellini CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: Aneesh Kumar K.V CC: Greg Kurz --- hw/9pfs/xen-9p-backend.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index 0c1dd5e..7e962aa

[Qemu-devel] [PULL 20/21] move xen-hvm.c to hw/i386/xen/

2017-04-21 Thread Stefano Stabellini
From: Anthony Xu move xen-hvm.c to hw/i386/xen/ Signed-off -by: Anthony Xu Reviewed-by: Stefano Stabellini --- Makefile.target |3 +- hw/i386/xen/Makefile.objs |2 +- hw/i386/xen/trace-events | 11 + hw/i386/xen/xen-hvm.c | 1429

[Qemu-devel] [PULL 13/21] xen/9pfs: connect to the frontend

2017-04-21 Thread Stefano Stabellini
Write the limits of the backend to xenstore. Connect to the frontend. Upon connection, allocate the rings according to the protocol specification. Initialize a QEMUBH to schedule work upon receiving an event channel notification from the frontend. Signed-off-by: Stefano Stabellini CC

[Qemu-devel] [PULL 19/21] move xen-common.c to hw/xen/

2017-04-21 Thread Stefano Stabellini
From: Anthony Xu move xen-common.c to hw/xen/ Signed-off -by: Anthony Xu Reviewed-by: Stefano Stabellini --- Makefile.target | 2 - hw/xen/Makefile.objs | 2 +- hw/xen/xen-common.c | 169 +++ stubs/Makefile.objs | 1 + stubs/xen

[Qemu-devel] [PULL 15/21] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal

2017-04-21 Thread Stefano Stabellini
Implement xen_9pfs_init_in/out_iov_from_pdu and xen_9pfs_pdu_vmarshal/vunmarshall by creating new sg pointing to the data on the ring. This is safe as we only handle one request per ring at any given time. Signed-off-by: Stefano Stabellini CC: anthony.per...@citrix.com CC: jgr...@suse.com CC

[Qemu-devel] [PULL 10/21] xen: import ring.h from xen

2017-04-21 Thread Stefano Stabellini
Do not use the ring.h header installed on the system. Instead, import the header into the QEMU codebase. This avoids problems when QEMU is built against a Xen version too old to provide all the ring macros. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com

[Qemu-devel] [PULL 17/21] xen/9pfs: build and register Xen 9pfs backend

2017-04-21 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: Aneesh Kumar K.V CC: Greg Kurz --- hw/9pfs/Makefile.objs| 1 + hw/xen/xen_backend.c | 3 +++ include/hw/xen/xen_backend.h | 3 +++ 3 files changed, 7 insertions

[Qemu-devel] [PULL 14/21] xen/9pfs: receive requests from the frontend

2017-04-21 Thread Stefano Stabellini
Upon receiving an event channel notification from the frontend, schedule the bottom half. From the bottom half, read one request from the ring, create a pdu and call pdu_submit to handle it. For now, only handle one request per ring at a time. Signed-off-by: Stefano Stabellini CC: anthony.per

[Qemu-devel] [PULL 09/21] configure: use pkg-config for obtaining xen version

2017-04-21 Thread Stefano Stabellini
rgen Gross Signed-off-by: Stefano Stabellini Tested-by: Paul Durrant Reviewed-by: Stefano Stabellini --- configure | 159 ++ 1 file changed, 88 insertions(+), 71 deletions(-) diff --git a/configure b/configure index 271bea8..3133

[Qemu-devel] [PULL 11/21] 9p: introduce a type for the 9p header

2017-04-21 Thread Stefano Stabellini
Use the new type in virtio-9p-device. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: Aneesh Kumar K.V CC: Greg Kurz --- hw/9pfs/9p.h | 6 ++ hw/9pfs/virtio-9p-device.c | 6

[Qemu-devel] [PULL 12/21] xen/9pfs: introduce Xen 9pfs backend

2017-04-21 Thread Stefano Stabellini
Introduce the Xen 9pfs backend: add struct XenDevOps to register as a Xen backend and add struct V9fsTransport to register as v9fs transport. All functions are empty stubs for now. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com CC: jgr...@suse.com CC

[Qemu-devel] [PULL 07/21] xen: use libxendevice model to restrict operations

2017-04-21 Thread Stefano Stabellini
Reviewed-by: Stefano Stabellini --- hw/xen/trace-events | 1 + include/hw/xen/xen.h| 1 + include/hw/xen/xen_common.h | 20 qemu-options.hx | 7 +++ vl.c| 8 xen-hvm.c | 8 6 files

<    1   2   3   4   5   6   7   8   9   10   >