Re: [PATCH V1 17/26] machine: memfd-alloc option

2024-06-03 Thread Steven Sistare via
On 6/3/2024 6:17 AM, Daniel P. Berrangé wrote: On Wed, May 29, 2024 at 01:31:38PM -0400, Steven Sistare wrote: On 5/28/2024 5:12 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:26AM -0700, Steve Sistare wrote: Allocate anonymous memory using memfd_create if the memfd-alloc machine option is

Re: [PATCH V1 19/26] physmem: preserve ram blocks for cpr

2024-05-31 Thread Steven Sistare via
On 5/30/2024 2:39 PM, Peter Xu wrote: On Thu, May 30, 2024 at 01:12:40PM -0400, Steven Sistare wrote: On 5/29/2024 3:25 PM, Peter Xu wrote: On Wed, May 29, 2024 at 01:31:53PM -0400, Steven Sistare wrote: On 5/28/2024 5:44 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:28AM -0700, Steve

Re: [PATCH V1 17/26] machine: memfd-alloc option

2024-05-31 Thread Steven Sistare via
On 5/30/2024 2:14 PM, Peter Xu wrote: On Thu, May 30, 2024 at 01:11:09PM -0400, Steven Sistare wrote: On 5/29/2024 3:14 PM, Peter Xu wrote: On Wed, May 29, 2024 at 01:31:38PM -0400, Steven Sistare wrote: diff --git a/system/memory.c b/system/memory.c index 49f1cb2..ca04a0e 100644 ---

Re: [PATCH V1 00/26] Live update: cpr-exec

2024-05-30 Thread Steven Sistare via
On 5/28/2024 12:42 PM, Peter Xu wrote: On Tue, May 28, 2024 at 11:10:27AM -0400, Steven Sistare wrote: On 5/27/2024 1:45 PM, Peter Xu wrote: On Tue, May 21, 2024 at 07:46:12AM -0400, Steven Sistare wrote: I understand, thanks. If I can help with any of your todo list, just ask - steve

Re: [PATCH V1 19/26] physmem: preserve ram blocks for cpr

2024-05-30 Thread Steven Sistare via
On 5/29/2024 3:25 PM, Peter Xu wrote: On Wed, May 29, 2024 at 01:31:53PM -0400, Steven Sistare wrote: On 5/28/2024 5:44 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:28AM -0700, Steve Sistare wrote: Preserve fields of RAMBlocks that allocate their host memory during CPR so the RAM

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-30 Thread Steven Sistare via
On 5/29/2024 2:53 PM, Peter Xu wrote: On Wed, May 29, 2024 at 01:30:18PM -0400, Steven Sistare wrote: How about a more general name for the type: migration/misc.h typedef char (MigrationId)[256]; How about qemu/typedefs.h? Not sure whether it's applicable. Markus (in the loop) may have

Re: [PATCH V1 17/26] machine: memfd-alloc option

2024-05-30 Thread Steven Sistare via
On 5/29/2024 3:14 PM, Peter Xu wrote: On Wed, May 29, 2024 at 01:31:38PM -0400, Steven Sistare wrote: diff --git a/system/memory.c b/system/memory.c index 49f1cb2..ca04a0e 100644 --- a/system/memory.c +++ b/system/memory.c @@ -1552,8 +1552,9 @@ bool memory_region_init_ram_nomigrate(MemoryRegion

Re: [PATCH V1 05/26] migration: precreate vmstate

2024-05-30 Thread Steven Sistare via
On 5/29/2024 2:39 PM, Peter Xu wrote: On Tue, May 28, 2024 at 11:09:49AM -0400, Steven Sistare wrote: On 5/27/2024 2:16 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:14AM -0700, Steve Sistare wrote: Provide the VMStateDescription precreate field to mark objects that must be loaded on the

Re: [PATCH V1 17/26] machine: memfd-alloc option

2024-05-29 Thread Steven Sistare via
On 5/28/2024 5:12 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:26AM -0700, Steve Sistare wrote: Allocate anonymous memory using memfd_create if the memfd-alloc machine option is set. Signed-off-by: Steve Sistare --- hw/core/machine.c | 22 ++ include/hw/boards.h

Re: [PATCH V1 19/26] physmem: preserve ram blocks for cpr

2024-05-29 Thread Steven Sistare via
On 5/28/2024 5:44 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:28AM -0700, Steve Sistare wrote: Preserve fields of RAMBlocks that allocate their host memory during CPR so the RAM allocation can be recovered. This sentence itself did not explain much, IMHO. QEMU can share memory using fd

Re: [PATCH V1 08/26] migration: vmstate_info_void_ptr

2024-05-29 Thread Steven Sistare via
On 5/28/2024 2:21 PM, Peter Xu wrote: On Tue, May 28, 2024 at 11:10:16AM -0400, Steven Sistare wrote: On 5/27/2024 2:31 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:17AM -0700, Steve Sistare wrote: Define VMSTATE_VOID_PTR so the value of a pointer (but not its target) can be saved in the

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-29 Thread Steven Sistare via
On 5/28/2024 1:44 PM, Peter Xu wrote: On Tue, May 28, 2024 at 11:10:03AM -0400, Steven Sistare via wrote: On 5/27/2024 2:20 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:16AM -0700, Steve Sistare wrote: Define a type for the 256 byte id string to guarantee the same length is used

Re: [PATCH V1 05/26] migration: precreate vmstate

2024-05-28 Thread Steven Sistare via
On 5/27/2024 2:16 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:14AM -0700, Steve Sistare wrote: Provide the VMStateDescription precreate field to mark objects that must be loaded on the incoming side before devices have been created, because they provide properties that will be needed at

Re: [PATCH V1 00/26] Live update: cpr-exec

2024-05-28 Thread Steven Sistare via
On 5/27/2024 1:45 PM, Peter Xu wrote: On Tue, May 21, 2024 at 07:46:12AM -0400, Steven Sistare wrote: I understand, thanks. If I can help with any of your todo list, just ask - steve Thanks for offering the help, Steve. Started looking at this today, then I found that I miss something

Re: [PATCH V1 07/26] migration: VMStateId

2024-05-28 Thread Steven Sistare via
On 5/27/2024 2:20 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:16AM -0700, Steve Sistare wrote: Define a type for the 256 byte id string to guarantee the same length is used and enforced everywhere. Signed-off-by: Steve Sistare --- include/exec/ramblock.h | 3 ++-

Re: [PATCH V1 08/26] migration: vmstate_info_void_ptr

2024-05-28 Thread Steven Sistare via
On 5/27/2024 2:31 PM, Peter Xu wrote: On Mon, Apr 29, 2024 at 08:55:17AM -0700, Steve Sistare wrote: Define VMSTATE_VOID_PTR so the value of a pointer (but not its target) can be saved in the migration stream. This will be needed for CPR. Signed-off-by: Steve Sistare This is really tricky.

Re: [PATCH V1 23/26] migration: misc cpr-exec blockers

2024-05-27 Thread Steven Sistare via
On 5/24/2024 8:40 AM, Fabiano Rosas wrote: Steve Sistare writes: Add blockers for cpr-exec migration mode for devices and options that do not support it. Signed-off-by: Steve Sistare --- accel/xen/xen-all.c| 5 + backends/hostmem-epc.c | 12 ++-- hw/vfio/migration.c

Re: [PATCH V1 20/26] migration: cpr-exec mode

2024-05-27 Thread Steven Sistare via
On 5/24/2024 10:58 AM, Fabiano Rosas wrote: Steve Sistare writes: Add the cpr-exec migration mode. Usage: qemu-system-$arch -machine memfd-alloc=on ... migrate_set_parameter mode cpr-exec migrate_set_parameter cpr-exec-args \ ... -incoming migrate -d The migrate command