[PULL v2 1/9] tests/functional: Convert the kvm_xen_guest avocado test

2025-01-22 Thread Thomas Huth
Use the serial console to execute the commands in the guest instead of using ssh since we don't have ssh support in the functional framework yet. Acked-by: David Woodhouse Message-ID: <20250113082516.57894-1-th...@redhat.com> Signed-off-by: Thomas Huth ---

[PULL v2 0/9] s390x and test patches 2025-01-21

2025-01-22 Thread Thomas Huth
RS: Remove myself as Avocado Framework reviewer Thomas Huth (6): tests/functional: Convert the kvm_xen_guest avocado test hw/s390x: Fix crash that occurs when inspecting older versioned machines types pc-bios/s390-ccw/virtio: Add a function to reset a virtio device pc-bio

Re: [PULL 0/9] s390x and test patches 2025-01-21

2025-01-21 Thread Thomas Huth
On 22/01/2025 01.27, Stefan Hajnoczi wrote: Hi Thomas, Please take a look at these CI failures: https://gitlab.com/qemu-project/qemu/-/jobs/8913471007 https://gitlab.com/qemu-project/qemu/-/jobs/8913471508 https://gitlab.com/qemu-project/qemu/-/jobs/8913472011 Ah, thanks, nice catch, unlike

Re: [PATCH 3/7] tests/qtest: don't step clock at start of npcm7xx periodic IRQ test

2025-01-21 Thread Thomas Huth
void test_periodic_interrupt(gconstpointer test_data) int i; tim_reset(td); -clock_step_next(); tim_write_ticr(td, count); tim_write_tcsr(td, CEN | IE | MODE_PERIODIC | PRESCALE(ps)); Reviewed-by: Thomas Huth

Re: [PATCH 0/7] testing/next (qtest timer stuff)

2025-01-21 Thread Thomas Huth
On 20/01/2025 22.02, Alex Bennée wrote: Hi, Thomas found that a number of tests fail under CFI and other exotic setups. The eventual realisation was that --enable-slirp masks a lot of timer misuse because it ensures there is always a timer and therefor things tend to move on (until the system

Re: [PATCH] mips: Mark the "mipssim" machine as deprecated

2025-01-21 Thread Thomas Huth
On 21/01/2025 13.07, Jiaxun Yang wrote: 在2025年1月21日一月 上午10:36,Thomas Huth写道: We are not aware of anybody still using this machine, support for it has been withdrawn from the Linux kernel (i.e. there also won't be any future development anymore), and we are not aware of any binaries o

[PULL 9/9] pc-bios: Update the s390 bios images with the recent changes

2025-01-21 Thread Thomas Huth
Fix the problem with the non-quiesced virtio-net device and make sure to abort the boot process if the user specified a wrong loadparm parameter. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw.img | Bin 79608 -> 96000 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-b

[PULL 2/9] MAINTAINERS: Remove myself as Avocado Framework reviewer

2025-01-21 Thread Thomas Huth
igned-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-ID: <20250106055024.70139-1-phi...@linaro.org> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 94834b7876..7be3d8f431 100644 --- a/MAINTA

[PULL 0/9] s390x and test patches 2025-01-21

2025-01-21 Thread Thomas Huth
--- Daniel P. Berrangé (1): crypto: fix bogus error benchmarking pbkdf on fast machines Jared Rossi (1): pc-bios/s390-ccw: Abort IPL on invalid loadparm Philippe Mathieu-Daudé (1): MAINTAINERS: Remove myself as Avocado Framework reviewer Thomas Huth (6): tests/fun

[PULL 6/9] pc-bios/s390-ccw: Fix boot problem with virtio-net devices

2025-01-21 Thread Thomas Huth
e-ID: <20250116115826.192047-3-th...@redhat.com> Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/virtio.h | 1 + pc-bios/s390-ccw/netmain.c| 33 +++-- pc-bios/s390-ccw/virtio-net.c | 5 + 3 files changed, 29 insertions(+), 10 deletions(-) diff --

[PULL 3/9] crypto: fix bogus error benchmarking pbkdf on fast machines

2025-01-21 Thread Thomas Huth
sage' accounting data on fast machines, we should see a non-zero value. Fixes: https://lore.kernel.org/qemu-devel/ffe542bb-310c-4616-b0ca-13182f849...@redhat.com/ Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2336437 Reported-by: Thomas Huth Reported-by: Richard W.M. Jones Tested-by: Tho

[PULL 5/9] pc-bios/s390-ccw/virtio: Add a function to reset a virtio device

2025-01-21 Thread Thomas Huth
To be able to properly silence a virtio device after using it, we need a global function to reset the device. Reviewed-by: Jared Rossi Reviewed-by: Eric Farman Tested-by: Jared Rossi Message-ID: <20250116115826.192047-2-th...@redhat.com> Signed-off-by: Thomas Huth --- pc-bios/s3

[PULL 4/9] hw/s390x: Fix crash that occurs when inspecting older versioned machines types

2025-01-21 Thread Thomas Huth
also be called while a machine (and its CPUs) is already created, which triggers the assertion in cpu_models.c. So we must not use instance_init() for setting global state, but use the machine->init() function instead, which is really only called once when the machine comes to life. Fixes:

[PULL 1/9] tests/functional: Convert the kvm_xen_guest avocado test

2025-01-21 Thread Thomas Huth
Use the serial console to execute the commands in the guest instead of using ssh since we don't have ssh support in the functional framework yet. Acked-by: David Woodhouse Message-ID: <20250113082516.57894-1-th...@redhat.com> Signed-off-by: Thomas Huth ---

[PULL 8/9] pc-bios/s390-ccw: Abort IPL on invalid loadparm

2025-01-21 Thread Thomas Huth
image. Signed-off-by: Jared Rossi Message-ID: <20250117212235.1324063-2-jro...@linux.ibm.com> Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c

[PULL 7/9] pc-bios/s390-ccw/netmain: Fix error messages with regards to the TFTP server

2025-01-21 Thread Thomas Huth
o life. Reviewed-by: Jared Rossi Reviewed-by: Eric Farman Tested-by: Jared Rossi Message-ID: <20250116115826.192047-4-th...@redhat.com> Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/pc-bios/s3

[PATCH] mips: Mark the "mipssim" machine as deprecated

2025-01-21 Thread Thomas Huth
thus let's mark it as deprecated now. Signed-off-by: Thomas Huth --- If anybody is still using this machine, please speak up now! docs/about/deprecated.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index

[PATCH] tests/functional: Fix broken decorators with lamda functions

2025-01-20 Thread Thomas Huth
ingImports also needs to exec() the import statement, otherwise we always try to import a module called "impname" which does not exist. Signed-off-by: Thomas Huth --- I've noticed the problem while trying to get the migration test through the CI: https://gitlab.com/thuth/qemu/-

Re: [PATCH 2/7] tests/qtest: don't attempt to clock_step while waiting for virtio ISR

2025-01-20 Thread Thomas Huth
rom that nit: Reviewed-by: Thomas Huth

[PATCH] hw/i386/pc: Fix crash that occurs when introspecting TYPE_PC_MACHINE machines

2025-01-17 Thread Thomas Huth
ch listener functions must never be installed from an instance_init function. Let's do it from pc_basic_device_init() instead - this function is called from the MachineClass->init() function instead, i.e. guaranteed to be only called once in the lifetime of a QEMU process. Resolves: https:

Re: [PATCH 08/21] hw/net/e1000: Remove unused E1000_FLAG_MAC flag

2025-01-17 Thread Thomas Huth
On 17/01/2025 17.41, Philippe Mathieu-Daudé wrote: On 17/1/25 09:58, Thomas Huth wrote: On 16/01/2025 00.22, Philippe Mathieu-Daudé wrote: E1000_FLAG_MAC was only used by the hw_compat_2_4[] array, via the 'extra_mac_registers=off' property. We removed all machines using that a

Re: [PATCH 10/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_DISABLE_PCIE definition

2025-01-17 Thread Thomas Huth
On 17/01/2025 17.43, Philippe Mathieu-Daudé wrote: On 17/1/25 10:08, Thomas Huth wrote: On 16/01/2025 00.22, Philippe Mathieu-Daudé wrote: VIRTIO_PCI_FLAG_DISABLE_PCIE was only used by the hw_compat_2_4[] array, via the 'x-disable-pcie=false' property. We removed all machines using

Re: [PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12

2025-01-17 Thread Thomas Huth
On 17/01/2025 12.07, Daniel P. Berrangé wrote: On Fri, Jan 17, 2025 at 11:27:35AM +0100, Thomas Huth wrote: While our new auto-disablement of old machine types will only kick in with the next (v10.1) release, the pc-i440fx-2.* machine types have been explicitly marked as deprecated via our old

[PATCH 3/3] tests/qtest/test-x86-cpuid-compat: Replaced the removed pc-i440fx-2.* machines

2025-01-17 Thread Thomas Huth
Since the pc-i440fx-2.* machine types have been removed, let's run the tests with the corresponding q35 machine types instead (until those get removed, too, then we have to remove the tests completely). Signed-off-by: Thomas Huth --- tests/qtest/test-x86-cpuid-compat.c

[PATCH 2/3] hw/i386/pc_piix: Remove pc-i440fx-2.4 up to pc-i440fx-2.12

2025-01-17 Thread Thomas Huth
These machines have explicitly been marked as deprecated in QEMU 9.1, so it should be fine to remove these antique versioned machine types two releases later in 10.0. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 7 --- docs/about/removed-features.rst | 4 +- docs/interop

[PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12

2025-01-17 Thread Thomas Huth
will still have at least a small benefit of accelerating our CI a little bit (since we don't have to run tests for these old machine types anymore). Thomas Huth (3): tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3 hw/i386/pc_piix: Remove pc-i440fx-2.4 up

[PATCH 1/3] tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3

2025-01-17 Thread Thomas Huth
The pc-i440fx-2.3 machine type has been removed in commit 46a2bd5257 ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine") already, so these tests are just dead code by now. Signed-off-by: Thomas Huth --- tests/qtest/test-x86-cpuid-compat.c | 18 -- 1 file c

Re: [PATCH 17/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_DISABLE_PCIE_BIT definition

2025-01-17 Thread Thomas Huth
ot;, PVSCSIState, compat_flags, -PVSCSI_COMPAT_DISABLE_PCIE_BIT, false), }; While you're at it, I think this was the last user of compat_flags, so you could remove that compat_flags field from the struct, too, now? Thomas

Re: [PATCH 17/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_DISABLE_PCIE_BIT definition

2025-01-17 Thread Thomas Huth
vmstate_pci_device, PCIDevice), +VMSTATE_STRUCT(parent_obj, PVSCSIState, 0, + vmstate_pci_device, PCIDevice), I think this is wrong, too. pvscsi_vmstate_test_pci_device() should return false for modern machines, so this should be removed instead? Thomas

Re: [PATCH 16/21] hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_OLD_PCI_CONFIGURATION definition

2025-01-17 Thread Thomas Huth
PROP_BIT("x-disable-pcie", PVSCSIState, compat_flags, PVSCSI_COMPAT_DISABLE_PCIE_BIT, false), }; Does this compile? I think you missed a spot that uses PVSCSI_USE_OLD_PCI_CONFIGURATION in pvscsi_realizefn() ? Thomas

Re: [PATCH 12/21] hw/i386/x86: Remove X86MachineClass::save_tsc_khz field

2025-01-17 Thread Thomas Huth
/i386/x86.c | 1 - target/i386/machine.c | 5 ++--- 3 files changed, 2 insertions(+), 9 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 10/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_DISABLE_PCIE definition

2025-01-17 Thread Thomas Huth
PER_VQ_BIT, VIRTIO_PCI_FLAG_ATS_BIT, VIRTIO_PCI_FLAG_INIT_DEVERR_BIT, I assume it's ok that the other following bits change their value here? If so: Reviewed-by: Thomas Huth

Re: [PATCH 09/21] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_MIGRATE_EXTRA definition

2025-01-17 Thread Thomas Huth
ing site: static bool virtio_extra_state_needed(void *opaque) { VirtIODevice *vdev = opaque; BusState *qbus = qdev_get_parent_bus(DEVICE(vdev)); VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus); return k->has_extra_state && k->has_extra_state(qbus->parent); } ... this will return now false instead of true, so I think your patch here is wrong? Thomas

Re: [PATCH 08/21] hw/net/e1000: Remove unused E1000_FLAG_MAC flag

2025-01-17 Thread Thomas Huth
markflag(MAC), -[PTC511] = markflag(MAC),[PTC1023] = markflag(MAC), -[PTC1522] = markflag(MAC),[MPTC]= markflag(MAC), -[BPTC]= markflag(MAC), I think this is wrong. All those registers should still be marked with MAC_ACCESS_FLAG_NEEDED, shouldn't they? Thom

Re: [PATCH 03/21] hw/i386/pc: Remove PCMachineClass::broken_reserved_end field

2025-01-17 Thread Thomas Huth
/i386/pc.c | 13 + 2 files changed, 5 insertions(+), 9 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 01/21] hw/i386/pc: Remove unused pc_compat_2_3 declarations

2025-01-17 Thread Thomas Huth
ass_init(ObjectClass *oc, void *data) \ { \ Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 00/13] hw/arm: Remove virt-2.6 up to virt-2.12 machines

2025-01-17 Thread Thomas Huth
On 17/01/2025 09.09, Daniel P. Berrangé wrote: On Fri, Jan 17, 2025 at 07:47:15AM +0100, Thomas Huth wrote: On 16/01/2025 22.13, Philippe Mathieu-Daudé wrote: Hi Peter, On 16/1/25 15:59, Philippe Mathieu-Daudé wrote: The versioned 'virt' machines up to 2.12 been marked as depr

Re: [PATCH-for-10.1 v2 00/13] hw/arm: Remove virt-2.6 up to virt-2.12 machines

2025-01-16 Thread Thomas Huth
y (via commit https://gitlab.com/qemu-project/qemu/-/commit/ce80c4fa6ff ), and thus they have been deprecated since two releases already. So it should be fine to remove them now, shouldn't it? Thomas

Re: [PATCH-for-10.1 v2 10/13] hw/arm/virt: Remove deprecated virt-2.11 machine

2025-01-16 Thread Thomas Huth
now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 10 -- 1 file changed, 10 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 12/13] hw/arm/virt: Remove deprecated virt-2.12 machine

2025-01-16 Thread Thomas Huth
now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 11 --- 1 file changed, 11 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 09/13] hw/arm/virt: Remove deprecated virt-2.10 machine

2025-01-16 Thread Thomas Huth
now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 9 - 1 file changed, 9 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 06/13] hw/arm/virt: Remove deprecated virt-2.8 machine

2025-01-16 Thread Thomas Huth
now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 13 - 1 file changed, 13 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 08/13] hw/arm/virt: Remove deprecated virt-2.9 machine

2025-01-16 Thread Thomas Huth
now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 7 --- 1 file changed, 7 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 04/13] hw/arm/virt: Remove deprecated virt-2.7 machine

2025-01-16 Thread Thomas Huth
now be removed. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 13 - 1 file changed, 13 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH-for-10.1 v2 03/13] hw/arm/virt: Remove VirtMachineClass::disallow_affinity_adjustment

2025-01-16 Thread Thomas Huth
mment. I agree that this comment needs an update, but it could also be done in a separate patch later, so from my side for this patch here: Reviewed-by: Thomas Huth

[PATCH 3/3] pc-bios/s390-ccw/netmain: Fix error messages with regards to the TFTP server

2025-01-16 Thread Thomas Huth
life. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/pc-bios/s390-ccw/netmain.c b/pc-bios/s390-ccw/netmain.c index 335ea9b63e..719a547ada 100644 --- a/pc-bios/s390-ccw/netmain.c +++ b/pc-bios/s390-ccw

[PATCH 2/3] pc-bios/s390-ccw: Fix boot problem with virtio-net devices

2025-01-16 Thread Thomas Huth
ERROR: No suitable device for IPL. Halting... We really have to shut up the virtio-net devices after we're not using it anymore. The easiest way to do this is to simply reset the device, so let's do that now. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/virtio.h | 1 + pc-b

[PATCH 1/3] pc-bios/s390-ccw/virtio: Add a function to reset a virtio device

2025-01-16 Thread Thomas Huth
To be able to properly silence a virtio device after using it, we need a global function to reset the device. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/virtio.h | 1 + pc-bios/s390-ccw/virtio.c | 7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw

[PATCH 0/3] pc-bios/s390-ccw: Fix problems related to network booting

2025-01-16 Thread Thomas Huth
unrelated, but I spotted this rather cosmetic problem while working on the code in netmain.c, so I included it here, too. Thomas Huth (3): pc-bios/s390-ccw/virtio: Add a function to reset a virtio device pc-bios/s390-ccw: Fix boot problem with virtio-net devices pc-bios/s390-ccw/netmain: Fix

Re: [PATCH 13/13] hw/arm/virt: Remove VirtMachineClass::no_highmem_ecam field

2025-01-16 Thread Thomas Huth
+- 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 11/13] hw/arm/virt: Remove VirtMachineClass::smbios_old_sys_ver field

2025-01-16 Thread Thomas Huth
| 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 07/13] hw/arm/virt: Remove VirtMachineClass::claim_edge_triggered_timers field

2025-01-15 Thread Thomas Huth
| 1 - hw/arm/virt-acpi-build.c | 5 + hw/arm/virt.c| 5 - 3 files changed, 1 insertion(+), 10 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 05/13] hw/arm/virt: Remove VirtMachineClass::no_its field

2025-01-15 Thread Thomas Huth
/virt-acpi-build.c | 5 ++--- hw/arm/virt.c| 16 ++-- 3 files changed, 8 insertions(+), 14 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 03/13] hw/arm/virt: Remove VirtMachineClass::disallow_affinity_adjustment

2025-01-15 Thread Thomas Huth
Class *vmc = VIRT_MACHINE_GET_CLASS(vms); -if (!vmc->disallow_affinity_adjustment) { I think this change is wrong - disallow_affinity_adjustment is false for newer machines, so you removed code here that is still in use on newer machines? Thomas -/* Adjust MPIDR like 64-

Re: [PATCH 01/13] hw/arm/virt: Remove deprecated virt-2.6 machine

2025-01-15 Thread Thomas Huth
eClass *mc) -{ -VirtMachineClass *vmc = VIRT_MACHINE_CLASS(OBJECT_CLASS(mc)); - -virt_machine_2_7_options(mc); -compat_props_add(mc->compat_props, hw_compat_2_6, hw_compat_2_6_len); -vmc->disallow_affinity_adjustment = true; -/* Disable PMU for 2.6 as PMU support was first introduced in 2.7 */ -vmc->no_pmu = true; -} -DEFINE_VIRT_MACHINE(2, 6) Reviewed-by: Thomas Huth

Re: [PATCH 02/13] hw/arm/virt: Remove VirtMachineClass::no_pmu field

2025-01-15 Thread Thomas Huth
changed, 5 deletions(-) Reviewed-by: Thomas Huth

[PATCH] docs/about: Change notes on x86 machine type deprecation into a general one

2025-01-15 Thread Thomas Huth
machine types in the document. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 7 --- docs/about/removed-features.rst | 11 +-- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 4a3c302962

Re: [PATCH v2] MAINTAINERS: Remove myself as Avocado Framework reviewer

2025-01-15 Thread Thomas Huth
@@ F: tests/tcg/Makefile.target   Integration Testing with the Avocado framework   W: https://trello.com/b/6Qi1pxVn/avocado-qemu   R: Cleber Rosa -R: Philippe Mathieu-Daudé   R: Wainer dos Santos Moschetta   S: Odd Fixes   F: tests/avocado/ ping? Reviewed-by: Thomas Huth I can take it with my

Re: [PATCH 0/8] s390x: Remove deprecated machine types v2.9 up to v2.12

2025-01-15 Thread Thomas Huth
On 15/01/2025 17.35, Philippe Mathieu-Daudé wrote: On 15/1/25 08:38, Thomas Huth wrote: These machine types have been marked as deprecated two releases ago, and are older than 6 years, so according to our support policy, it should be fine to remove them now. Thomas Huth (8):    hw/s390x/s390

[PATCH 3/8] hw/s390x/s390-stattrib: Remove the old migration_enabled flag

2025-01-14 Thread Thomas Huth
Now that the machine types that set the migration_enabled flag to false are gone, we can remove it and the related code. Signed-off-by: Thomas Huth --- include/hw/s390x/storage-attributes.h | 1 - hw/s390x/s390-stattrib-kvm.c | 2 +- hw/s390x/s390-stattrib.c | 7 +-- 3

[PATCH 4/8] hw/intc/s390_flic: Remove the obsolete migration_enabled flag

2025-01-14 Thread Thomas Huth
Now that the machine types that set the migration_enabled flag to false are gone, we can remove it and the related code. Signed-off-by: Thomas Huth --- include/hw/s390x/s390_flic.h | 1 - hw/intc/s390_flic.c | 14 -- 2 files changed, 15 deletions(-) diff --git a/include

[PATCH 7/8] target/s390x/gen-features: Remove the v2.11 qemu CPU model

2025-01-14 Thread Thomas Huth
Now that the v2.11 machine is gone, we don't need the v2.11 CPU feature set anymore. Signed-off-by: Thomas Huth --- target/s390x/gen-features.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 41840677ce..150e4d1843 1

[PATCH 6/8] hw/s390x/event-facility: Remove the obsolete "allow_all_mask_sizes" code

2025-01-14 Thread Thomas Huth
Now that the machine types 2.11 and older have been removed, we don't need the "allow_all_mask_sizes" compatibility handling code anymore and can remove it now. Signed-off-by: Thomas Huth --- hw/s390x/event-facility.c | 37 + 1 file chang

[PATCH 5/8] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.10 and 2.11 machine types

2025-01-14 Thread Thomas Huth
following patches. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 37 - 1 file changed, 37 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index b5635c43c4..44f8082326 100644 --- a/hw/s390x/s390-virtio-ccw.c

[PATCH 8/8] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.12 machine type

2025-01-14 Thread Thomas Huth
The s390-ccw-virtio-2.12 machine is older than 6 years, so according to our machine support policy, it can be removed now. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390

[PATCH 1/8] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.9 machine type

2025-01-14 Thread Thomas Huth
The s390-ccw-virtio-2.9 machine is older than 6 years, so according to our machine support policy, it can be removed now. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 24 1 file changed, 24 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x

[PATCH 0/8] s390x: Remove deprecated machine types v2.9 up to v2.12

2025-01-14 Thread Thomas Huth
These machine types have been marked as deprecated two releases ago, and are older than 6 years, so according to our support policy, it should be fine to remove them now. Thomas Huth (8): hw/s390x/s390-virtio-ccw: Remove the deprecated 2.9 machine type hw/s390x/css: Remove the obsolete

[PATCH 2/8] hw/s390x/css: Remove the obsolete "css_migration_enabled" variable

2025-01-14 Thread Thomas Huth
Now that the s390-ccw-virtio-2.9 machine type has been removed, we don't need the "css_migration_enabled" variable anymore and can remove the related code. Signed-off-by: Thomas Huth --- include/hw/s390x/css.h | 6 -- hw/s390x/css.c | 31 +

[PATCH] firmware: qemu_fw_cfg: constify 'struct bin_attribute'

2025-01-14 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- drivers/firmware/qemu_fw_cfg.c | 6 +++--- 1 file changed, 3 insert

Re: [PATCH v3 3/7] migration: Fix parsing of s390 stream

2025-01-13 Thread Thomas Huth
On 13/01/2025 08.51, Michael Tokarev wrote: 13.01.2025 09:39, Thomas Huth wrote: On 12/01/2025 15.29, Michael Tokarev wrote: # starting QEMU: exec ./qemu-system-s390x -qtest unix:/tmp/ qtest-1137270.sock -qtest-log /dev/null -chardev socket,path=/tmp/ qtest-1137270.qmp,id=char0 -mon chardev

[PATCH v2] tests/functional: Convert the kvm_xen_guest avocado test

2025-01-13 Thread Thomas Huth
Use the serial console to execute the commands in the guest instead of using ssh since we don't have ssh support in the functional framework yet. Acked-by: David Woodhouse Signed-off-by: Thomas Huth --- v2: Add "quiet" to KERNEL_DEFAULT to avoid races on the serial consol

Re: [PATCH v2 3/3] docs/system/arm/virt: mention specific migration information

2025-01-12 Thread Thomas Huth
ine, but an alias of the latest machine: $ ./qemu-system-aarch64 -M help | grep alias virt QEMU 10.0 ARM Virtual Machine (alias of virt-10.0) So maybe that could be mentioned here instead? Thomas

Re: [PATCH v3 3/7] migration: Fix parsing of s390 stream

2025-01-12 Thread Thomas Huth
7, in read     field['data'] = reader(field, self.file)       File "/tmp/q/scripts/analyze-migration.py", line 450, in __init__     for field in self.desc['struct']['fields']: ~~~^^ KeyError: 'fields' # Failed to analyze the migration stream I think you need to backport patch 1/7, too? Thomas

Re: [PATCH v3 7/7] s390x: Fix CSS migration

2025-01-12 Thread Thomas Huth
a55ae46683 ("s390: move css_migration_enabled from machine to css.c") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2704 Reviewed-by: Thomas Huth Signed-off-by: Fabiano Rosas Message-Id: <20241213160120.23880-3-faro...@suse.de> And this one causes s390x-migration-te

Re: download.qemu.org file list

2025-01-12 Thread Thomas Huth
? It seems to be working right now ... could you please check again? Thomas

Re: [PATCH v4 0/3] Enable clang build on Windows

2025-01-12 Thread Thomas Huth
could pull this, so we can get this merged upstream. That'd be Thomas or Alex I suppose. This touches plugins, so I think it should go through Alex' tree? Thomas

Re: [PATCH] crypto: fix bogus error benchmarking pbkdf on fast machines

2025-01-08 Thread Thomas Huth
equent updates of 'getrusage' accounting data on fast machines, we should see a non-zero value. Thanks, this seems to fix the issue for me: Tested-by: Thomas Huth

Re: [PATCH v4 29/32] tests/vm: allow interactive login as root

2025-01-08 Thread Thomas Huth
On 08/01/2025 13.10, Alex Bennée wrote: This is useful when debugging and you want to add packages to an image. Signed-off-by: Alex Bennée --- tests/vm/Makefile.include | 3 ++- tests/vm/basevm.py| 9 +++-- 2 files changed, 9 insertions(+), 3 deletions(-) Reviewed-by: Thomas

Re: [PATCH v4 28/32] tests/vm: partially un-tabify help output

2025-01-08 Thread Thomas Huth
+- 1 file changed, 13 insertions(+), 13 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v4 23/32] tests/functional: extend test_aarch64_virt with vulkan test

2025-01-08 Thread Thomas Huth
On 08/01/2025 13.10, Alex Bennée wrote: Now that we have virtio-gpu Vulkan support, let's add a test for it. Currently this is using images build by buildroot: https://lists.buildroot.org/pipermail/buildroot/2024-December/768196.html Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth

Re: [PATCH v4 22/32] tests/functional: bail aarch64_virt tests early if missing TCG

2025-01-08 Thread Thomas Huth
/test_aarch64_virt.py | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v4 21/32] tests/functional: remove unused kernel_command_line

2025-01-08 Thread Thomas Huth
.vm.set_console() -kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + - 'console=ttyAMA0') self.require_accelerator("tcg") self.vm.add_args("-accel", "tcg") Reviewed-by: Thomas Huth

Re: [PATCH v4 20/32] tests/functional: update tuxruntest to use uncompress utility

2025-01-08 Thread Thomas Huth
On 08/01/2025 13.10, Alex Bennée wrote: Use the utility functions to reduce code duplication. Signed-off-by: Alex Bennée --- tests/functional/qemu_test/tuxruntest.py | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v4 19/32] tests/functional: add zstd support to uncompress utility

2025-01-08 Thread Thomas Huth
lly handle when only minimal dependencies have been installed. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth

[PULL 10/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.8 machine type

2025-01-08 Thread Thomas Huth
The s390-ccw-virtio-2.8 machine is older than 6 years, so according to our machine support policy, it can be removed now. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-10-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-

[PULL 00/14] Fixes for tests and removal of deprecated features

2025-01-08 Thread Thomas Huth
rs for the multiarch tests Thomas Huth (13): hw/s390x/s390-virtio-ccw: Remove the deprecated 2.4 and 2.5 machine types hw/s390x/s390-skeys: Remove the "migration-enabled" property hw/s390x/s390-virtio-ccw: Remove the deprecated 2.6 machine type hw/s390x: Remove the "ri

[PULL 12/14] Remove the deprecated "-runas" command line option

2025-01-08 Thread Thomas Huth
It has been marked as deprecated two releases ago, so it should be fine now to remove this command line option. Reviewed-by: Daniel P. Berrangé Message-ID: <20250103155411.721759-1-th...@redhat.com> Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/r

[PULL 09/14] hw/s390x: Remove the cpu_model_allowed flag and related code

2025-01-08 Thread Thomas Huth
Signed-off-by: Thomas Huth --- include/hw/s390x/s390-virtio-ccw.h | 3 --- hw/s390x/s390-virtio-ccw.c | 9 + target/s390x/kvm/kvm.c | 10 ++ 3 files changed, 3 insertions(+), 19 deletions(-) diff --git a/include/hw/s390x/s390-virtio-ccw.h b/include/hw/s390

[PULL 13/14] docs/about/deprecated: Remove paragraph about initial deprecation in 2.10

2025-01-08 Thread Thomas Huth
: Daniel P. Berrangé Message-ID: <20250103145702.597139-1-th...@redhat.com> Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 63b46fd520..4a3c302962 100644 --- a/docs

[PULL 14/14] tests/functional/test_x86_64_hotplug_cpu: Fix race condition during unplug

2025-01-08 Thread Thomas Huth
efan Hajnoczi Message-ID: <20250107115245.52755-1-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/test_x86_64_hotplug_cpu.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/functional/test_x86_64_hotplug_cpu.py b/tests/functional/test_x86_64_

[PULL 01/14] tests/tcg/s390x: Use the SLOF libc headers for the multiarch tests

2025-01-08 Thread Thomas Huth
3-1-...@linux.ibm.com> Tested-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/tcg/s390x/Makefile.softmmu-target | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Makefile.softmmu-target index 969bc5728f..7adde2fa08 100644

[PULL 06/14] hw/s390x/ipl: Remove the "iplbext_migration" property

2025-01-08 Thread Thomas Huth
383-6-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/ipl.h | 1 - hw/s390x/ipl.c | 10 -- 2 files changed, 11 deletions(-) diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h index d7d0b7bfd2..8e3882d506 100644 --- a/hw/s390x/ipl.h +++ b/hw/s390x/ipl.h @@ -80,7 +80,6 @@

[PULL 05/14] hw/s390x: Remove the "ri_allowed" switch

2025-01-08 Thread Thomas Huth
Christian Borntraeger Message-ID: <20250103144232.520383-5-th...@redhat.com> Signed-off-by: Thomas Huth --- include/hw/s390x/s390-virtio-ccw.h | 3 --- hw/s390x/s390-virtio-ccw.c | 14 -- target/s390x/kvm/kvm.c | 6 ++ 3 files changed, 6 insertions(+), 17 de

[PULL 07/14] hw/s390x/css-bridge: Remove the "css_dev_path" property

2025-01-08 Thread Thomas Huth
ssues/2213 Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-7-th...@redhat.com> Signed-off-by: Thomas Huth --- include/hw/s390x/css-bridge.h | 1 - hw/s390x/css-bridg

[PULL 02/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.4 and 2.5 machine types

2025-01-08 Thread Thomas Huth
n machine types less than 5.1"). Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-2-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 37 -

[PULL 11/14] hw/s390x: Remove the "adapter_routes_max_batch" property from the flic

2025-01-08 Thread Thomas Huth
ger Message-ID: <20250103144232.520383-11-th...@redhat.com> Signed-off-by: Thomas Huth --- include/hw/s390x/s390_flic.h | 2 -- hw/intc/s390_flic.c | 9 - hw/s390x/virtio-ccw.c| 5 ++--- 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/include/hw/s390x/s390_flic

[PULL 03/14] hw/s390x/s390-skeys: Remove the "migration-enabled" property

2025-01-08 Thread Thomas Huth
m> Signed-off-by: Thomas Huth --- include/hw/s390x/storage-keys.h | 2 -- hw/s390x/s390-skeys.c | 10 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/include/hw/s390x/storage-keys.h b/include/hw/s390x/storage-keys.h index 976ffb2039..408d2815d4 100644 --- a/

[PULL 04/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.6 machine type

2025-01-08 Thread Thomas Huth
The s390-ccw-virtio-2.6 machine is older than 6 years, so according to our machine support policy, it can be removed now. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-4-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio

[PULL 08/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.7 machine type

2025-01-08 Thread Thomas Huth
The s390-ccw-virtio-2.7 machine is older than 6 years, so according to our machine support policy, it can be removed now. Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Message-ID: <20250103144232.520383-8-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio

Re: [PATCH v3 20/29] tests/functional: extend test_aarch64_virt with vulkan test

2025-01-07 Thread Thomas Huth
elif "old virglrenderer, venus unsupported" in excp.output: +self.skipTest("No venus support for virtio-gpu") +else: + self.log.info("unhandled launch failure: {excp.output}") +raise excp + +self.wait_for_console_pattern('buildroot login:') +exec_command(self, 'root') +exec_command(self, 'export XDG_RUNTIME_DIR=/tmp') +exec_command_and_wait_for_pattern(self, + "weston -B headless " + "--renderer gl " + "--shell kiosk " + "-- vkmark -b:duration=1.0", + "vkmark Score") The new test looks fine to me! Thomas

  1   2   3   4   5   6   7   8   9   10   >