Re: [PATCH 04/14] hw/ppc: convert 'spapr' machine definitions to use new macros

2024-05-02 Thread Thomas Huth
a DEFINE_SPAPR_MACHINE_TAGGED helper to allow defining of "tagged" machine types which have a string suffix. Signed-off-by: Daniel P. Berrangé --- hw/ppc/spapr.c | 93 +++--- 1 file changed, 51 insertions(+), 42 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 03/14] hw/s390x: convert 'ccw' machine definitions to use new macros

2024-05-02 Thread Thomas Huth
+- 1 file changed, 53 insertions(+), 43 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 10/14] hw: set deprecation info for all versioned machine types

2024-05-02 Thread Thomas Huth
. Signed-off-by: Daniel P. Berrangé --- hw/arm/virt.c | 1 + hw/m68k/virt.c | 1 + hw/ppc/spapr.c | 1 + hw/s390x/s390-virtio-ccw.c | 1 + include/hw/i386/pc.h | 1 + 5 files changed, 5 insertions(+) Reviewed-by: Thomas Huth

Re: [PATCH 09/14] hw: temporarily disable deletion of versioned machine types

2024-05-02 Thread Thomas Huth
On 01/05/2024 20.27, Daniel P. Berrangé wrote: The new deprecation and deletion policy for versioned machine types is being introduced in QEMU 9.1.0. Under the new policy a number of old machine types (any prior to 2.12) would be liable for immediate deletion which would be a violation of our

Re: [PATCH 08/14] include/hw: add macros for deprecation & removal of versioned machines

2024-05-02 Thread Thomas Huth
: Reviewed-by: Thomas Huth

Re: [PATCH 01/14] include/hw: add helpers for defining versioned machine types

2024-05-02 Thread Thomas Huth
ted/targeted/ according to my spell checker ? Apart from the nits: Reviewed-by: Thomas Huth Thomas

Re: [PATCH 14/14] docs: document special exception for machine type deprecation & removal

2024-05-02 Thread Thomas Huth
ecent version highly +recommended. Non-versioned machine types follow the general feature +deprecation policy. Anyway: Reviewed-by: Thomas Huth

Re: [PATCH v2] hw/s390x: Attach the sclpconsole to /machine/sclp/s390-sclp-event-facility

2024-05-02 Thread Thomas Huth
On 02/05/2024 09.57, Cédric Le Goater wrote: On 4/30/24 21:08, Thomas Huth wrote: The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. We should rather attach it to /machine/sclp/s390-sclp-event-facility

Re: QEMU headers in C++

2024-05-02 Thread Thomas Huth
On 02/05/2024 06.40, Roman Kiryanov wrote: Hi QEMU, I work in Android Studio Emulator and we would like to develop devices in C++. Unfortunately, QEMU headers cannot be used with C++ as is (e.g. they use C++ keywords as variable names or implicitly cast void* to T*). Can't you simply use

[PATCH v2] hw/s390x: Attach the sclpconsole to /machine/sclp/s390-sclp-event-facility

2024-04-30 Thread Thomas Huth
The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. We should rather attach it to /machine/sclp/s390-sclp-event-facility where the other devices of type TYPE_SCLP_EVENT already reside. Signed-off-by: Thomas

Re: [PATCH] hw/s390x: Attach the sclpconsole to the /machine/sclp node

2024-04-30 Thread Thomas Huth
On 30/04/2024 16.24, Thomas Huth wrote: On 30/04/2024 13.58, Cédric Le Goater wrote: On 4/30/24 10:04, Thomas Huth wrote: The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. Let's attach it to /machine/sclp

Re: [PATCH] hw/s390x: Attach the sclpconsole to the /machine/sclp node

2024-04-30 Thread Thomas Huth
On 30/04/2024 13.58, Cédric Le Goater wrote: On 4/30/24 10:04, Thomas Huth wrote: The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. Let's attach it to /machine/sclp instead. Signed-off-by: Thomas Huth

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Thomas Huth
On 30/04/2024 11.55, Daniel P. Berrangé wrote: On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: Old machine types often have bugs or work-arounds that affect our possibilities to move forward with the QEMU code base (see for example https://gitlab.com/qemu-project/qemu/-/issues/2213

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Thomas Huth
On 30/04/2024 11.40, Philippe Mathieu-Daudé wrote: Hi Thomas, On 30/4/24 08:45, Thomas Huth wrote: Old machine types often have bugs or work-arounds that affect our possibilities to move forward with the QEMU code base (see for example https://gitlab.com/qemu-project/qemu/-/issues/2213

Re: [PATCH] hw/s390x: Attach the sclpconsole to the /machine/sclp node

2024-04-30 Thread Thomas Huth
On 30/04/2024 10.19, David Hildenbrand wrote: On 30.04.24 10:04, Thomas Huth wrote: The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. Let's attach it to /machine/sclp instead. IIRC, this should

[PATCH] hw/s390x: Attach the sclpconsole to the /machine/sclp node

2024-04-30 Thread Thomas Huth
The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. Let's attach it to /machine/sclp instead. Signed-off-by: Thomas Huth --- include/hw/s390x/sclp.h| 2 +- hw/s390x/s390-virtio-ccw.c | 11

[PULL 19/19] .gitlab-ci.d/cirrus: Remove the netbsd and openbsd jobs

2024-04-30 Thread Thomas Huth
obs now. Message-ID: <20240426113742.654748-1-th...@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/cirrus.yml | 37 --- .gitlab-ci.d/cirrus/kvm-build.yml | 31 -- 2 files changed, 68 deletions(-) delete mode 100644 .gitlab-ci.d/

[PULL 07/19] hw: misc: edu: fix 2 off-by-one errors

2024-04-30 Thread Thomas Huth
https://gitlab.com/qemu-project/qemu/-/issues/1254 Signed-off-by: Chris Friedt [thuth: Adjust patch with regards to the "end1 <= end2" check] Message-ID: <20221018122551.94567-1-cfri...@meta.com> Signed-off-by: Thomas Huth --- hw/misc/edu.c | 17 - 1 file ch

[PULL 18/19] .gitlab-ci.d/cirrus.yml: Shorten the runtime of the macOS and FreeBSD jobs

2024-04-30 Thread Thomas Huth
there is still a similar target with the opposite endianness (like xtensa/xtensael, microblaze/microblazeel etc.). Message-ID: <20240429100113.53357-1-th...@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/cirrus.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.d/cirrus

[PULL 12/19] hw/char/stm32l4x5_usart: Fix memory corruption by adding correct class_size

2024-04-30 Thread Thomas Huth
allocated buffer when setting the subc->type field. Fixes: 4fb37aea7e ("hw/char: Implement STM32L4x5 USART skeleton") Message-ID: <20240429075908.36302-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/char/stm32l4x5_usart.c | 1 + 1 file

[PULL 14/19] gitlab: migrate the s390x custom machine to 22.04

2024-04-30 Thread Thomas Huth
From: Alex Bennée 20.04 is dead (from QEMU's point of view), long live 22.04! Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-ID: <20240426153938.1707723-3-alex.ben...@linaro.org> Signed-off-by: Thomas Huth --- .gitlab-ci.d/custom-runners.yml | 2 +- ..

[PULL 16/19] hw/ide/core.c (cmd_read_native_max): Avoid limited device parameters

2024-04-30 Thread Thomas Huth
2431276-1-lku...@mailbox.org> Signed-off-by: Thomas Huth --- hw/ide/core.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index e8cb2dac92..08d9218455 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1623,11 +1623,2

[PULL 06/19] target/s390x/cpu_models_sysemu: Drop local @err in apply_cpu_model()

2024-04-30 Thread Thomas Huth
From: Zhao Liu Use @errp to fetch error information directly and drop the local variable @err. Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Message-ID: <20240425031232.1586401-8-zhao1@intel.com> Signed-off-by: Thomas Huth --- target/s390x/cpu_models_sysemu.c | 4 +--- 1 file c

[PULL 13/19] build-environment: make some packages optional

2024-04-30 Thread Thomas Huth
From: Alex Bennée Upgrading the s390x runner exposed some packages are not available for it. Add an additional optional stage we only enable for arm64/x86_64 for now. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-ID: <20240426153938.1707723-2-alex.ben...@linaro.org> Sign

[PULL 11/19] qga: Re-enable the qga-ssh-test when running without fuzzing

2024-04-30 Thread Thomas Huth
viewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Thomas Huth --- qga/meson.build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/qga/meson.build b/qga/meson.build index 1c3d2a3d1b..46c1d83d7f 100644 --- a/qga/meson.build +++ b/qga/meson.build @@ -

[PULL 15/19] gitlab: remove stale s390x-all-linux-static conf hacks

2024-04-30 Thread Thomas Huth
From: Alex Bennée The libssh bug references 18.04 which we are no longer running. We don't need to disable glusterfs because a linux-user build shouldn't be trying to link to it anyway. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-ID: <20240426153938.1707723-4-alex.

[PULL 09/19] hw: misc: edu: use qemu_log_mask instead of hw_error

2024-04-30 Thread Thomas Huth
ed-off-by: Thomas Huth --- hw/misc/edu.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/misc/edu.c b/hw/misc/edu.c index e1cb443438..fa052c44db 100644 --- a/hw/misc/edu.c +++ b/hw/misc/edu.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#inc

[PULL 05/19] target/s390x/cpu_models: Make kvm_s390_apply_cpu_model() return boolean

2024-04-30 Thread Thomas Huth
Huth Message-ID: <20240425031232.1586401-7-zhao1@intel.com> Signed-off-by: Thomas Huth --- target/s390x/cpu_models.h| 2 +- target/s390x/cpu_models_sysemu.c | 3 +-- target/s390x/kvm/kvm.c | 15 --- 3 files changed, 10 insertions(+), 10 deletions(-) diff

[PULL 10/19] stubs: Add missing qga stubs

2024-04-30 Thread Thomas Huth
pe Mathieu-Daudé Signed-off-by: Konstantin Kostiuk Message-ID: <20240426121347.18843-2-kkost...@redhat.com> Signed-off-by: Thomas Huth --- stubs/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/stubs/meson.build b/stubs/meson.build index 8ee1fd5753..3

[PULL 03/19] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean

2024-04-30 Thread Thomas Huth
-by: Thomas Huth Message-ID: <20240425031232.1586401-5-zhao1@intel.com> Signed-off-by: Thomas Huth --- target/s390x/cpu_models.h | 2 +- target/s390x/cpu_models.c | 9 - target/s390x/kvm/kvm.c| 13 +++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/

[PULL 17/19] tests/qtest/ide-test: Verify READ NATIVE MAX ADDRESS is not limited

2024-04-30 Thread Thomas Huth
ed-off-by: Thomas Huth --- tests/qtest/ide-test.c | 47 +- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/tests/qtest/ide-test.c b/tests/qtest/ide-test.c index d6b4f6e36a..90ba6b298b 100644 --- a/tests/qtest/ide-test.c +++ b/tests/qtest/ide-

[PULL 01/19] target/s390x/cpu_model: Make check_compatibility() return boolean

2024-04-30 Thread Thomas Huth
From: Zhao Liu As error.h suggested, the best practice for callee is to return something to indicate success / failure. With returned boolean, there's no need to check @err. Suggested-by: Thomas Huth Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Message-ID: <20240425031232.158640

[PULL 00/19] Misc patches (s390x clean-ups, fixes for crashes, ...)

2024-04-30 Thread Thomas Huth
(cmd_read_native_max): Avoid limited device parameters tests/qtest/ide-test: Verify READ NATIVE MAX ADDRESS is not limited Thomas Huth (4): qga: Re-enable the qga-ssh-test when running without fuzzing hw/char/stm32l4x5_usart: Fix memory corruption by adding correct class_size .gi

[PULL 04/19] target/s390x/cpu_models: Drop local @err in get_max_cpu_model()

2024-04-30 Thread Thomas Huth
From: Zhao Liu Use @errp to fetch error information directly and drop the local variable @err. Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Message-ID: <20240425031232.1586401-6-zhao1@intel.com> Signed-off-by: Thomas Huth --- target/s390x/cpu_models.c | 4 +--- 1 file chan

[PULL 08/19] hw: misc: edu: rename local vars in edu_check_range

2024-04-30 Thread Thomas Huth
From: Chris Friedt This serves to make the local variables a bit less ambiguous. The latter two arguments are named to match DMA_START, and DMA_SIZE. Signed-off-by: Chris Friedt Message-ID: <20221018122551.94567-2-cfri...@meta.com> Signed-off-by: Thomas Huth --- hw/misc/edu.

[PULL 02/19] target/s390x/cpu_model: Drop local @err in s390_realize_cpu_model()

2024-04-30 Thread Thomas Huth
From: Zhao Liu Use @errp to fetch error information directly and drop the local variable @err. Suggested-by: Thomas Huth Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Message-ID: <20240425031232.1586401-3-zhao1@intel.com> Signed-off-by: Thomas Huth --- target/s390x/cpu_models

[PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Thomas Huth
as deprecated automatically. Six years should be sufficient to support the release cycles of most Linux distributions. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index

Re: [PULL 1/1] hw/ufs: Fix buffer overflow bug

2024-04-29 Thread Thomas Huth
On 30/04/2024 06.32, Thomas Huth wrote: On 30/04/2024 02.17, Richard Henderson wrote: On 4/28/24 20:25, Jeuk Kim wrote: From: Jeuk Kim It fixes the buffer overflow vulnerability in the ufs device. The bug was detected by sanitizers. You can reproduce it by: cat << EOF |\ qemu-system-

Re: [PULL 1/1] hw/ufs: Fix buffer overflow bug

2024-04-29 Thread Thomas Huth
On 30/04/2024 02.17, Richard Henderson wrote: On 4/28/24 20:25, Jeuk Kim wrote: From: Jeuk Kim It fixes the buffer overflow vulnerability in the ufs device. The bug was detected by sanitizers. You can reproduce it by: cat << EOF |\ qemu-system-x86_64 \ -display none -machine accel=qtest -m

Re: [PATCH v2 1/1] stubs: Add missing qga stubs

2024-04-29 Thread Thomas Huth
On 29/04/2024 12.09, Konstantin Kostiuk wrote: Hi Paolo, Are you ok if I merge this patch with other QGA patches? Or don't you agree with this version of the patch? Phil asked me in IRC to pick this patch up, so I'll include it in my next pull request. Thomas

[PATCH] .gitlab-ci.d/cirrus.yml: Shorten the runtime of the macOS and FreeBSD jobs

2024-04-29 Thread Thomas Huth
there is still a similar target with the opposite endianness (like xtensa/xtensael, microblaze/microblazeel etc.). Signed-off-by: Thomas Huth --- .gitlab-ci.d/cirrus.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml index 74de2edbb4..75df1273bc 100644

[PATCH] hw/char/stm32l4x5_usart: Fix memory corruption by adding correct class_size

2024-04-29 Thread Thomas Huth
allocated buffer when setting the subc->type field. Fixes: 4fb37aea7e ("hw/char: Implement STM32L4x5 USART skeleton") Signed-off-by: Thomas Huth --- hw/char/stm32l4x5_usart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/stm32l4x5_usart.c b/hw/char/stm32l4x5_usart.c index

[PATCH] qga: Re-enable the qga-ssh-test when running without fuzzing

2024-04-26 Thread Thomas Huth
According to the comment in qga/meson.build, the test got disabled since there were problems with the fuzzing job. But instead of disabling this test completely, we should still be fine running it when fuzzing is disabled. Signed-off-by: Thomas Huth --- qga/meson.build | 5 ++--- 1 file changed

Re: [PATCH] .gitlab-ci.d/cirrus: Remove the netbsd and openbsd jobs

2024-04-26 Thread Thomas Huth
On 26/04/2024 15.46, Eldon Stegall wrote: On Fri, Apr 26, 2024 at 02:47:20PM +0200, Thomas Huth wrote: With regards to NetBSD and OpenBSD, this is not a step backward since these gitlab jobs were never run anyway (they could only be triggered manually, but hardly anybody did that AFAIK). If we

Re: [PATCH 3/3] gitlab: remove stale s390x-all-linux-static conf hacks

2024-04-26 Thread Thomas Huth
| 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/3] gitlab: migrate the s390x custom machine to 22.04

2024-04-26 Thread Thomas Huth
ons(+), 15 deletions(-) rename .gitlab-ci.d/custom-runners/{ubuntu-20.04-s390x.yml => ubuntu-22.04-s390x.yml} (88%) Reviewed-by: Thomas Huth

Re: [PATCH 1/3] build-environment: make some packages optional

2024-04-26 Thread Thomas Huth
' or ansible_facts['architecture'] == 'x86_64' + - name: Install armhf cross-compile packages to build QEMU on AArch64 Ubuntu 22.04 package: name: Reviewed-by: Thomas Huth

Re: [PATCH] .gitlab-ci.d/cirrus: Remove the netbsd and openbsd jobs

2024-04-26 Thread Thomas Huth
On 26/04/2024 14.30, Peter Maydell wrote: On Fri, 26 Apr 2024 at 12:38, Thomas Huth wrote: During the past months, the netbsd and openbsd jobs in the Cirrus-CI were broken most of the time - the setup to run a BSD in KVM on Cirrus-CI from gitlab via the cirrus-run script was very fragile

[PATCH] .gitlab-ci.d/cirrus: Remove the netbsd and openbsd jobs

2024-04-26 Thread Thomas Huth
introduce a limit on the amount of free CI minutes that you get there, so it is not appealing at all anymore to run these BSDs in this setup - it's better to run the checks locally via "make vm-build-openbsd" and "make vm-build-netbsd" instead. Thus let's remove these CI jobs now. S

Re: [PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-25 Thread Thomas Huth
On 25/04/2024 22.56, Philippe Mathieu-Daudé wrote: Hi Thomas, On 25/4/24 20:43, Thomas Huth wrote: For downstream versions of QEMU, we'd like to be able to compile QEMU without the FDC code included (since it's not required for modern VMs anymore and the FDC code has rather a bad reputation

[PATCH 0/3] Make it possible to compile the x86 binaries without FDC

2024-04-25 Thread Thomas Huth
it is not available in the binary, so I hope this patch is fine, too. Thomas Huth (3): hw/i386/pc: Allow to compile without CONFIG_FDC_ISA hw/i386/Kconfig: Allow to compile Q35 without FDC_ISA hw/i386: Add the possibility to use i440fx and isapc without FDC hw/i386/pc.c | 13 + hw/i386

[PATCH 2/3] hw/i386/Kconfig: Allow to compile Q35 without FDC_ISA

2024-04-25 Thread Thomas Huth
d the isa-pc machine currently always instantiate the FDC, so we have to add the select statements now there instead. Signed-off-by: Thomas Huth --- hw/i386/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index a6ee052f9a..0b08580862

[PATCH 1/3] hw/i386/pc: Allow to compile without CONFIG_FDC_ISA

2024-04-25 Thread Thomas Huth
The q35 machine can work without FDC. But to be able to also link a QEMU binary that does not include the FDC code, we have to make it possible to disable the spots that call into the FDC code. Signed-off-by: Thomas Huth --- hw/i386/pc.c | 13 + 1 file changed, 9 insertions(+), 4

[RFC PATCH 3/3] hw/i386: Add the possibility to use i440fx and isapc without FDC

2024-04-25 Thread Thomas Huth
The i440fx and the isapc machines can be used in binaries without FDC, too. We just have to make sure that they don't try to instantiate the FDC when it is not available. Signed-off-by: Thomas Huth --- hw/i386/pc_piix.c | 6 -- hw/i386/Kconfig | 2 -- 2 files changed, 4 insertions(+), 4

Re: [PATCH v2 4/7] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean

2024-04-25 Thread Thomas Huth
-by: Zhao Liu --- target/s390x/cpu_models.c | 9 - target/s390x/cpu_models.h | 2 +- target/s390x/kvm/kvm.c| 13 +++-- 3 files changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Thomas Huth

Re: [PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-25 Thread Thomas Huth
On 25/04/2024 17.04, Richard Henderson wrote: On 4/24/24 22:11, Thomas Huth wrote: On 24/04/2024 18.21, Richard Henderson wrote: On 4/24/24 00:57, Thomas Huth wrote: The following changes since commit 13b1e9667737132440f4d500c31cb69320c6b15a:    Merge tag 'for-upstream' of https

Re: [PATCH] ci: move external build environment setups to CentOS Stream 9

2024-04-25 Thread Thomas Huth
On 12/04/2024 12.37, Paolo Bonzini wrote: RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus upgrade our CentOS Stream build environment playbooks to major

[PULL v2 00/16] CI job updates, header cleanups and other misc patches

2024-04-25 Thread Thomas Huth
(3): hw/s390x: Include missing 'cpu.h' header tests/unit: Remove debug statements in test-nested-aio-poll.c target/s390x: Remove KVM stubs in cpu_models.h Thomas Huth (8): Revert ".travis.yml: Cache Avocado cache" .travis.yml: Remove the unused UNRELIABLE e

Re: [PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-24 Thread Thomas Huth
On 24/04/2024 18.21, Richard Henderson wrote: On 4/24/24 00:57, Thomas Huth wrote: The following changes since commit 13b1e9667737132440f4d500c31cb69320c6b15a:    Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-04-23 17:35:57 -0700) are available in the Git

Re: [PULL 12/17] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-24 Thread Thomas Huth
On 24/04/2024 18.19, Richard Henderson wrote: On 4/24/24 00:57, Thomas Huth wrote: RHEL 9 (and thus also the derivatives) have been available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Another reason

Re: [PATCH] vfio/ccw: Use g_autofree variable

2024-04-24 Thread Thomas Huth
changed, 11 insertions(+), 14 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()

2024-04-24 Thread Thomas Huth
On 24/04/2024 12.41, Prasad Pandit wrote: On Wednesday, 24 April, 2024 at 03:36:01 pm IST, Philippe Mathieu-Daudé wrote: On 1/6/23 05:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to

Re: [PATCH 2/2] checkpatch.pl: forbid strerrorname_np()

2024-04-24 Thread Thomas Huth
=~ /\bffs\(/) { ERROR("use ctz32() instead of ffs()\n" . $herecurr); Reviewed-by: Thomas Huth

Re: [PATCH 1/2] target/riscv/kvm: remove sneaky strerrorname_np() instance

2024-04-24 Thread Thomas Huth
code: %s", - strerrorname_np(errno)); +error_report("Unable to read vlenb register, error code: %d", + errno); exit(EXIT_FAILURE); } Reviewed-by: Thomas Huth

[PULL 12/17] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-24 Thread Thomas Huth
6.302103-5-th...@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml| 16 - .gitlab-ci.d/container-core.yml | 4 +-- .../{centos8.docker => centos9.docker}| 34 +++ tests/lcitool/mappings.yml

[PULL 06/17] .travis.yml: Remove the unused UNRELIABLE environment variable

2024-04-24 Thread Thomas Huth
l had the x86 jobs here around that were our main CI jobs. Thus let's simply remove this useless variable now. Message-ID: <20240320104144.823425-6-th...@redhat.com> Signed-off-by: Thomas Huth --- .travis.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.travis.yml b/.travis.yml

[PULL 15/17] docs/devel: fix minor typo in submitting-a-patch.rst

2024-04-24 Thread Thomas Huth
From: Manos Pitsidianakis s/Resolved:/Resolves:/ Signed-off-by: Manos Pitsidianakis Message-ID: <20240422124128.4034482-1-manos.pitsidiana...@linaro.org> Reviewed-by: Peter Maydell Signed-off-by: Thomas Huth --- docs/devel/submitting-a-patch.rst | 2 +- 1 file changed, 1 insertion

[PULL 02/17] tests/qtest : Use `g_assert_cmphex` instead of `g_assert_cmpuint`

2024-04-24 Thread Thomas Huth
Ninad Palsule Message-ID: <20240414173349.31194-1-ines.var...@telecom-paris.fr> Signed-off-by: Thomas Huth --- tests/qtest/aspeed_fsi-test.c | 20 ++-- tests/qtest/cmsdk-apb-dualtimer-test.c | 2 +- tests/qtest/cmsdk-apb-watchdog-test.c | 2 +- tests/qtest/erst-test.c|

[PULL 03/17] docs: i386: pc: Update maximum CPU numbers for PC Q35

2024-04-24 Thread Thomas Huth
From: Zhao Liu Commit e4e98c7eebfa ("pc: q35: Bump max_cpus to 4096 vcpus") increases the supported CPUs for PC Q35 machine. Update maximum CPU numbers for PC Q35 in the document. Signed-off-by: Zhao Liu Message-ID: <20240412085358.731560-1-zhao1@linux.intel.com> Signe

[PULL 13/17] ci: move external build environment setups to CentOS Stream 9

2024-04-24 Thread Thomas Huth
-off-by: Paolo Bonzini Reviewed-by: Thomas Huth Message-ID: <20240412103708.27650-1-pbonz...@redhat.com> Reviewed-by: Daniel P. Berrangé Message-ID: <20240418101056.302103-7-th...@redhat.com> Signed-off-by: Thomas Huth --- .../stream/{8 => 9}/build-environme

[PULL 16/17] tests/unit: Remove debug statements in test-nested-aio-poll.c

2024-04-24 Thread Thomas Huth
246.83812-1-phi...@linaro.org> Signed-off-by: Thomas Huth --- tests/unit/test-nested-aio-poll.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/tests/unit/test-nested-aio-poll.c b/tests/unit/test-nested-aio-poll.c index db33742af3..d8fd92c43b 100644 --- a/tests/unit/test-nested-aio-

[PULL 11/17] tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update

2024-04-24 Thread Thomas Huth
Message-ID: <20240418101056.302103-4-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker| 3 ++- tests/docker/dockerfiles/centos8.docker | 1 + tests/docker/dockerfiles/debian-amd64-cross.docker| 3 ++- tests/docker/dockerfi

[PULL 14/17] hw/s390x: Include missing 'cpu.h' header

2024-04-24 Thread Thomas Huth
h:22:27: error: unknown type name 'CPUS390XState' int s390_virtio_hypercall(CPUS390XState *env); ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Acked-by: Eric Farman Message-ID: <20240322162822.7391-1-phi...@linaro.org> Signed-off-by: Thomas Hu

[PULL 05/17] Revert ".travis.yml: Cache Avocado cache"

2024-04-24 Thread Thomas Huth
4144.823425-4-th...@redhat.com> Signed-off-by: Thomas Huth --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8a3ae76a7c..8da88c4360 100644 --- a/.travis.yml +++ b/.travis.yml @@ -12,8 +12,6 @@ cache: timeout: 1200 ccache: true pip: tru

[PULL 17/17] target/s390x: Remove KVM stubs in cpu_models.h

2024-04-24 Thread Thomas Huth
From: Philippe Mathieu-Daudé Since the calls are elided when KVM is not available, we can remove the stubs (which are never compiled). Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240419090631.48055-1-phi...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu_models.

[PULL 01/17] MAINTAINERS: update email of Peter Lieven

2024-04-24 Thread Thomas Huth
From: Peter Lieven I will leave KAMP in the next days. Update email to stay reachable. Signed-off-by: Peter Lieven Message-ID: <20230105095039.182718-1...@kamp.de> Signed-off-by: Thomas Huth --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINT

[PULL 08/17] .travis.yml: Do some more testing with Clang

2024-04-24 Thread Thomas Huth
ed-off-by: Thomas Huth --- .travis.yml | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 7527f71c05..cef0308952 100644 --- a/.travis.yml +++ b/.travis.yml @@ -113,8 +113,9 @@ jobs: - CONFIG="--disable-containers --enable

[PULL 10/17] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-04-24 Thread Thomas Huth
We need the latest fixes for the lcitool to be able to properly update our CentOS docker file to CentOS Stream 9. Reviewed-by: Daniel P. Berrangé Message-ID: <20240418101056.302103-3-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/lcitool/libvirt-ci | 2 +- 1 file changed, 1 ins

[PULL 04/17] tests/vm: update openbsd image to 7.5

2024-04-24 Thread Thomas Huth
From: Brad Smith tests/vm: update openbsd to release 7.5 Signed-off-by: Brad Smith Message-ID: Signed-off-by: Thomas Huth --- tests/vm/openbsd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 85c9863633..5e646f7c51 100755

[PULL 07/17] .travis.yml: Update the jobs to Ubuntu 22.04

2024-04-24 Thread Thomas Huth
can drop the entries from the individual jobs and use the global setting again. Reviewed-by: Daniel P. Berrangé Message-ID: <20240418101056.302103-6-th...@redhat.com> Signed-off-by: Thomas Huth --- .travis.yml | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a

[PULL 09/17] tests: Remove Ubuntu 20.04 container

2024-04-24 Thread Thomas Huth
Since Ubuntu 22.04 has now been available for more than two years, we can stop actively supporting the previous LTS version of Ubuntu now. Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240418101056.302103-2-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/docker/docke

[PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-24 Thread Thomas Huth
-Daudé (3): hw/s390x: Include missing 'cpu.h' header tests/unit: Remove debug statements in test-nested-aio-poll.c target/s390x: Remove KVM stubs in cpu_models.h Thomas Huth (8): Revert ".travis.yml: Cache Avocado cache" .travis.yml: Remove the unused

[PATCH] .gitlab-ci.d/cirrus.yml: Fix the NetBSD and OpenBSD Cirrus-CI KVM jobs

2024-04-24 Thread Thomas Huth
e dormant for a year as the old ':master' tags were not removed until some weeks ago. The other Cirrus-CI jobs were already fixed in commit 1d2f2b35bc86b7a1 ("gitlab-ci/cirrus: switch from 'master' to 'latest'"), but apparently nobody noticed the KVM jobs so far that need to be triggered ma

Re: [PATCH 0/3] Remove useless architecture prefix from the CPU list

2024-04-22 Thread Thomas Huth
On 22/04/2024 10.03, Daniel P. Berrangé wrote: On Sat, Apr 20, 2024 at 07:46:03AM +0200, Thomas Huth wrote: Printing an architecture prefix in front of each CPU name is not helpful at all: It is confusing for the users since they don't know whether they have to specify these letters

[PATCH 3/3] target/ppc/cpu_init: Remove "PowerPC" prefix from the CPU list

2024-04-19 Thread Thomas Huth
Let's simply remove this now and use two spaces at the beginning of the lines for the indentation of the entries instead, and add a "Available CPUs" in the very first line, like most other target architectures are doing it for their CPU help output already. Signed-off-by: Thomas Huth

[PATCH 1/3] target/i386/cpu: Remove "x86" prefix from the CPU list

2024-04-19 Thread Thomas Huth
Let's simply remove this now and use two spaces at the beginning of the lines for the indentation of the entries instead, like most other target architectures are doing it for their CPU help output already. Signed-off-by: Thomas Huth --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 0/3] Remove useless architecture prefix from the CPU list

2024-04-19 Thread Thomas Huth
t's simply remove those now. Thomas Huth (3): target/i386/cpu: Remove "x86" prefix from the CPU list target/s390x/cpu_models: Rework the output of "-cpu help" target/ppc/cpu_init: Remove "PowerPC" prefix from the CPU list target/i386/cpu.c

[PATCH 2/3] target/s390x/cpu_models: Rework the output of "-cpu help"

2024-04-19 Thread Thomas Huth
Let's simply remove this now! While we're at it, use two spaces at the beginning of the lines for the indentation of the entries, and add a "Available CPUs" in the very first line, like most other target architectures are doing it for their "-cpu help" output already. Signe

[PATCH v2 2/4] target/sparc/cpu: Avoid spaces by default in the CPU names

2024-04-19 Thread Thomas Huth
d Henderson Reviewed-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- target/sparc/cpu.c | 56 +++--- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index 774e234e09..593c8d6867 100644 --- a/target/

[PATCH v2 0/4] Sparc CPU naming and help text improvements

2024-04-19 Thread Thomas Huth
BSD and OpenBSD in the docs since these problems are likely fixed since a long time already - Added Reviewed-bys from earlier series and updated the patch descriptions a little bit Thomas Huth (4): target/sparc/cpu: Rename the CPU models with a "+" in their names target/sparc/cpu: A

[PATCH v2 4/4] docs/about: Deprecate the old "UltraSparc" CPU names that contain a "+"

2024-04-19 Thread Thomas Huth
For consistency we should drop the names with a "+" in it in the long run. Reviewed-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index

[PATCH v2 3/4] docs/system/target-sparc: Improve the Sparc documentation

2024-04-19 Thread Thomas Huth
://gitlab.com/qemu-project/qemu/-/issues/2141 Signed-off-by: Thomas Huth --- docs/system/target-sparc.rst | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/system/target-sparc.rst b/docs/system/target-sparc.rst index 9ec8c90c14..54bd8b6ead 100644 --- a/docs/system/target

[PATCH v2 1/4] target/sparc/cpu: Rename the CPU models with a "+" in their names

2024-04-19 Thread Thomas Huth
ward compatibility for the old names via some simple checks in the sparc_cpu_class_by_name() function. Reviewed-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- qom/object.c | 8 target/sparc/cpu.c | 14 -- 2 files changed, 12 insertions(+), 10 deletions(-) d

Re: [PATCH 6/6] target/s390x/cpu_models_sysemu: Drop local @err in apply_cpu_model()

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu Use @errp to fetech error information directly and drop the local virable @err. With the typos fixed: Reviewed-by: Thomas Huth

Re: [PATCH 5/6] target/s390x/cpu_models: Make kvm_s390_apply_cpu_model() return boolean

2024-04-19 Thread Thomas Huth
-off-by: Zhao Liu --- target/s390x/cpu_models.h| 5 +++-- target/s390x/cpu_models_sysemu.c | 3 +-- target/s390x/kvm/kvm.c | 15 --- 3 files changed, 12 insertions(+), 11 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 4/6] target/s390x/cpu_models: Drop local @err in get_max_cpu_model()

2024-04-19 Thread Thomas Huth
(errp, err); +if (!kvm_s390_get_host_cpu_model(_model, errp)) { return NULL; } } else { With the typos fixed: Reviewed-by: Thomas Huth

Re: [PATCH 3/6] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu As error.h suggested, the best practice for callee is to return something to indicate success / failure. So make kvm_s390_get_host_cpu_model() return boolean and check the returned boolean in get_max_cpu_model() instead of accessing @err.

Re: [PATCH 2/6] target/s390x/cpu_model: Drop local @err in s390_realize_cpu_model()

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu Use @errp to fetech error information directly and drop the local s/fetech/fetch/ virable @err. s/virable/variable/ Suggested-by: Thomas Huth Signed-off-by: Zhao Liu --- target/s390x/cpu_models.c | 4 +--- 1 file changed, 1

Re: [PATCH 1/6] target/s390x/cpu_model: Make check_compatibility() return boolean

2024-04-19 Thread Thomas Huth
On 19/04/2024 08.57, Zhao Liu wrote: From: Zhao Liu As error.h suggested, the best practice for callee is to return something to indicate success / failure. With returned boolean, there's no need to check @err. Suggested-by: Thomas Huth Signed-off-by: Zhao Liu --- target/s390x

Re: [PATCH 4/5] docs/system/target-sparc: Improve the Sparc documentation

2024-04-18 Thread Thomas Huth
On 18/04/2024 22.27, Mark Cave-Ayland wrote: On 07/03/2024 17:43, Thomas Huth wrote: Add some words about how to enable or disable boolean features, and remove the note about a Linux kernel being available on the QEMU website (they have been removed long ago already). Signed-off-by: Thomas

<    1   2   3   4   5   6   7   8   9   10   >