Re: [PATCH 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line

2024-03-13 Thread Thomas Huth
QTestState *qts = qtest_init(cmd_line->str); Reviewed-by: Thomas Huth

Re: [PATCH 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line

2024-03-12 Thread Thomas Huth
QTestState *qts = qtest_init(cmd_line->str); Reviewed-by: Thomas Huth

Re: [PATCH 6/7] tests/unit/test-throttle: Avoid unintended integer division

2024-03-12 Thread Thomas Huth
ime. Reviewed-by: Thomas Huth

Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

2024-03-12 Thread Thomas Huth
Hi Peter, Paolo, David, this patch fixes a problem with the kvm-unit-tests ... could we get it included in QEMU 9.0 ? Thanks, Thomas On 19/02/2024 07.17, Nicholas Piggin wrote: The fastpath in cpu_physical_memory_sync_dirty_bitmap() to test large aligned ranges forgot to bring the

[PULL 39/55] target/avr: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-10-phi...@linaro.org> Signed-off-by: Thoma

[PULL 30/55] migration/option: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
uot;). Cc: Peter Xu Cc: Fabiano Rosas Signed-off-by: Zhao Liu Reviewed-by: Fabiano Rosas Acked-by: Peter Xu Message-ID: <20240311033822.3142585-28-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- migration/options.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migra

[PULL 04/55] hw/misc/xlnx-versal-trng: Check returned bool in trng_prop_fault_event_set()

2024-03-12 Thread Thomas Huth
55438-5-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- hw/misc/xlnx-versal-trng.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/misc/xlnx-versal-trng.c b/hw/misc/xlnx-versal-trng.c index b8111b8b66..6495188dc7 100644 --- a/hw/misc/xlnx-versal-trng.c +++ b/hw/

[PULL 53/55] target/tricore: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
phi...@linaro.org> Signed-off-by: Thomas Huth --- target/tricore/cpu.c | 24 +--- target/tricore/gdbstub.c | 6 ++ target/tricore/helper.c| 3 +-- target/tricore/translate.c | 3 +-- 4 files changed, 9 insertions(+), 27 deletions(-) diff --git a/target/tricore/c

[PULL 36/55] bulk: Call in place single use cpu_env()

2024-03-12 Thread Thomas Huth
+ cpu_env(cs) ... when != env } Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-ID: <20240129164514.73104-5-phi...@linaro.org> Signed-off-by: Thomas Huth --- accel/tcg/cpu-exec.c | 3 +-- linux-user/i386/cpu_loop.c | 4 ++--

[PULL 28/55] hw/virtio/vhost-vsock: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
in" Signed-off-by: Zhao Liu Message-ID: <20240311033822.3142585-26-zhao1@linux.intel.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- hw/virtio/vhost-vsock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/vhost-vsock.c b/hw/virtio/vhost-vsock.c index d5c

[PULL 09/55] block: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
("error: New macro ERRP_GUARD()"). Cc: Kevin Wolf Cc: Hanna Reitz Cc: qemu-bl...@nongnu.org Signed-off-by: Zhao Liu Reviewed-by: Eric Blake Message-ID: <20240311033822.3142585-4-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- block.c | 4 1 file chang

[PULL 47/55] target/nios2: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-20-phi...@linaro.org> Signed-off-by: Thoma

[PULL 23/55] hw/vfio/helpers: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
message of commit ae7c80a7bd73 ("error: New macro ERRP_GUARD()"). Cc: Alex Williamson Cc: Cédric Le Goater Signed-off-by: Zhao Liu Reviewed-by: Cédric Le Goater Message-ID: <20240311033822.3142585-21-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- hw/vfio/helpers.c

[PULL 10/55] block/copy-before-write: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
n Wolf Cc: Hanna Reitz Cc: qemu-bl...@nongnu.org Signed-off-by: Zhao Liu Reviewed-by: Vladimir Sementsov-Ogievskiy Message-ID: <20240311033822.3142585-5-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- block/copy-before-write.c | 1 + 1 file changed, 1 insertion(+) diff --git a/b

[PULL 07/55] error: Add error_vprepend() in comment of ERRP_GUARD() rules

2024-03-12 Thread Thomas Huth
an API provided in error.h, it is necessary to add it to the description of the rules for using ERRP_GUARD(). Cc: Markus Armbruster Cc: Michael Roth Signed-off-by: Zhao Liu Reviewed-by: Markus Armbruster Message-ID: <20240311033822.3142585-2-zhao1@linux.intel.com> Signed-off-by:

[PULL 40/55] target/cris: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-11-phi...@linaro.org> Signed-off-by: Thoma

[PULL 41/55] target/hexagon: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
org> Signed-off-by: Thomas Huth --- target/hexagon/cpu.c | 25 ++--- target/hexagon/gdbstub.c | 6 ++ 2 files changed, 8 insertions(+), 23 deletions(-) diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index d41c6452a2..3a716b9be3 100644 --- a/target/hexagon/cpu.c

[PULL 49/55] target/ppc: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-22-phi...@linaro.org> Signed-off-by: Thoma

[PULL 54/55] target/xtensa: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-29-phi...@linaro.org> Signed-off-by: Thoma

[PULL 02/55] hw/display/macfb: Fix missing ERRP_GUARD() in macfb_nubus_realize()

2024-03-12 Thread Thomas Huth
8-3-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- hw/display/macfb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/macfb.c b/hw/display/macfb.c index 418e99c8e1..1ace341a0f 100644 --- a/hw/display/macfb.c +++ b/hw/display/macfb.c @@ -714,6 +714,7 @@

[PULL 50/55] target/rx: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-ID: <20240129164514.73104-24-phi...@linaro.org> Signed-off-by: Thoma

[PULL 55/55] user: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
org> Signed-off-by: Thomas Huth --- bsd-user/signal.c | 3 +-- linux-user/signal.c | 6 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/bsd-user/signal.c b/bsd-user/signal.c index e9f80a06d3..3ac50c2d71 100644 --- a/bsd-user/signal.c +++ b/bsd-user/signal.c @@ -463,14 +

[PULL 24/55] hw/vfio/iommufd: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
GUARD()"). Cc: Alex Williamson Cc: Cédric Le Goater Signed-off-by: Zhao Liu Reviewed-by: Cédric Le Goater Message-ID: <20240311033822.3142585-22-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- hw/vfio/iommufd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/iom

[PULL 42/55] target/i386/hvf: Use CPUState typedef

2024-03-12 Thread Thomas Huth
org> [thuth: Break long lines to avoid checkpatch.pl errors] Signed-off-by: Thomas Huth --- target/i386/hvf/x86.h | 26 +- target/i386/hvf/x86_descr.h | 14 +++--- target/i386/hvf/x86_emu.h | 4 ++-- target/i386/hvf/x86_mmu.h | 6 +++--- target/i386/hvf

[PULL 51/55] target/sh4: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-26-phi...@linaro.org> Signed-off-by: Thoma

[PULL 37/55] target: Replace CPU_GET_CLASS(cpu -> obj) in cpu_reset_hold() handler

2024-03-12 Thread Thomas Huth
); Most code use the 'cs' variable name for CPUState handle. Replace few 's' -> 'cs' to unify cpu_reset_hold() style. No logical change in this patch. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson Message-ID: <20240129164514.73104-7-phi...@linaro.org> Signed-off-b

[PULL 52/55] target/sparc: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
org> Signed-off-by: Thomas Huth --- target/sparc/cpu.c | 17 + target/sparc/gdbstub.c | 3 +-- target/sparc/int32_helper.c | 3 +-- target/sparc/int64_helper.c | 3 +-- target/sparc/ldst_helper.c | 6 ++ target/sparc/mmu_helper.c | 15 +--

[PULL 45/55] target/microblaze: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-18-phi...@linaro.org> Signed-off-by: Thoma

[PULL 22/55] hw/vfio/container: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
uot;). Cc: Alex Williamson Cc: Cédric Le Goater Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Reviewed-by: Cédric Le Goater Message-ID: <20240311033822.3142585-20-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- hw/vfio/container.c | 1 + 1 file changed, 1 insertion(+) diff

[PULL 43/55] target/loongarch: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
patch for hunk that moved to cpu_helper.c] Signed-off-by: Thomas Huth --- target/loongarch/cpu.c| 39 - target/loongarch/cpu_helper.c | 3 +-- target/loongarch/gdbstub.c| 6 ++--- target/loongarch/kvm/kvm.c

[PULL 32/55] target/s390x/cpu_models: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
GUARD()"). Cc: David Hildenbrand Cc: Thomas Huth Cc: Richard Henderson Cc: Ilya Leoshkevich Cc: qemu-s3...@nongnu.org Signed-off-by: Zhao Liu Reviewed-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Message-ID: <20240311033822.3142585-30-zhao1@linux.intel.com> Signed-off

[PULL 29/55] hw/virtio/vhost: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
ae7c80a7bd73 ("error: New macro ERRP_GUARD()"). Cc: "Michael S. Tsirkin" Signed-off-by: Zhao Liu Message-ID: <20240311033822.3142585-27-zhao1@linux.intel.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- hw/virtio/vhost.c | 2 ++ 1 file changed, 2 inse

[PULL 21/55] hw/vfio/ap: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
Cc: Alex Williamson Cc: Cédric Le Goater Cc: Tony Krowiak Cc: Halil Pasic Cc: Jason Herne Cc: Thomas Huth Cc: qemu-s3...@nongnu.org Signed-off-by: Zhao Liu Reviewed-by: Cédric Le Goater Message-ID: <20240311033822.3142585-19-zhao1@linux.intel.com> Signed-off-by: Thomas Huth ---

[PULL 31/55] net/vhost-vdpa: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
of this function. [1]: Issue description in the commit message of commit ae7c80a7bd73 ("error: New macro ERRP_GUARD()"). Cc: Jason Wang Signed-off-by: Zhao Liu Reviewed-by: Thomas Huth Message-ID: <20240311033822.3142585-29-zhao1@linux.intel.com> Signed-off-by: Thomas Huth

[PULL 14/55] block/qcow2: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
("error: New macro ERRP_GUARD()"). Cc: Kevin Wolf Cc: Hanna Reitz Cc: qemu-bl...@nongnu.org Signed-off-by: Zhao Liu Reviewed-by: Eric Blake Message-ID: <20240311033822.3142585-9-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- block/qcow2.c | 2 ++ 1 file changed, 2 ins

[PULL 13/55] block/qcow2-bitmap: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
-Ogievskiy Message-ID: <20240311033822.3142585-8-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- block/qcow2-bitmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c index 0e567ed588..874ea56948 100644 --- a/block/qcow2-bitmap.c +++ b/bloc

[PULL 19/55] block/virtio-blk: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
..@nongnu.org Signed-off-by: Zhao Liu Reviewed-by: Stefan Hajnoczi Acked-by: "Michael S. Tsirkin" Message-ID: <20240311033822.3142585-14-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- hw/block/virtio-blk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/

[PULL 44/55] target/m68k: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-17-phi...@linaro.

[PULL 48/55] target/openrisc: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-21-phi...@linaro.org> Signed-off-by: Thoma

[PULL 35/55] hw/core: Declare CPUArchId::cpu as CPUState instead of Object

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Do not accept any Object for CPUArchId::cpu field, restrict it to CPUState type. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-3-phi...@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- include/hw/boards.h

[PULL 27/55] hw/vfio/platform: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
uot;). Cc: Alex Williamson Cc: Cédric Le Goater Signed-off-by: Zhao Liu Reviewed-by: Cédric Le Goater Message-ID: <20240311033822.3142585-25-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- hw/vfio/platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/plat

[PULL 38/55] target/alpha: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240129164514.73104-8-phi...@linaro.org> Signed-off-by: Thoma

[PULL 17/55] block/vdi: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
nongnu.org Signed-off-by: Zhao Liu Message-ID: <20240311033822.3142585-12-zhao1@linux.intel.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- block/vdi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/vdi.c b/block/vdi.c index 3b57becb9f..6363da08ce 100644 --- a/b

[PULL 15/55] block/qed: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
n Wolf Cc: Hanna Reitz Cc: qemu-bl...@nongnu.org Signed-off-by: Zhao Liu Reviewed-by: Stefan Hajnoczi Message-ID: <20240311033822.3142585-10-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- block/qed.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qed.c b/b

[PULL 08/55] backends/iommufd: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
m> Signed-off-by: Thomas Huth --- backends/iommufd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/backends/iommufd.c b/backends/iommufd.c index 1ef683c7b0..62a79fa6b0 100644 --- a/backends/iommufd.c +++ b/backends/iommufd.c @@ -43,6 +43,7 @@ static void iommufd_backend_finalize(Object *obj

[PULL 26/55] hw/vfio/pci: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
in the commit message of commit ae7c80a7bd73 ("error: New macro ERRP_GUARD()"). Cc: Alex Williamson Cc: Cédric Le Goater Signed-off-by: Zhao Liu Reviewed-by: Cédric Le Goater Message-ID: <20240311033822.3142585-24-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --

[PULL 11/55] block/nbd: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
c: qemu-bl...@nongnu.org Signed-off-by: Zhao Liu Reviewed-by: Vladimir Sementsov-Ogievskiy Message-ID: <20240311033822.3142585-6-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nbd.c b/block/nbd.c index b9d4f935e0..e

[PULL 25/55] hw/vfio/pci-quirks: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
message of commit ae7c80a7bd73 ("error: New macro ERRP_GUARD()"). Cc: Alex Williamson Cc: Cédric Le Goater Signed-off-by: Zhao Liu Reviewed-by: Cédric Le Goater Message-ID: <20240311033822.3142585-23-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- hw/vfio/pci-quirks.

[PULL 16/55] block/snapshot: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
uot;). Cc: Kevin Wolf Cc: Hanna Reitz Cc: qemu-bl...@nongnu.org Signed-off-by: Zhao Liu Message-ID: <20240311033822.3142585-11-zhao1@linux.intel.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- block/snapshot.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/sn

[PULL 33/55] error: Move ERRP_GUARD() to the beginning of the function

2024-03-12 Thread Thomas Huth
P_GUARD() right at the beginning of the function, because only then can it guard the whole function.", so clean up the few spots disregarding the advice. Inspired-by: Markus Armbruster Signed-off-by: Zhao Liu Reviewed-by: Markus Armbruster Message-ID: <20240312060337.3240965-1-zhao1@linux.intel.com

[PULL 05/55] hw/pci-bridge/cxl_upstream: Fix missing ERRP_GUARD() in cxl_usp_realize()

2024-03-12 Thread Thomas Huth
the bug that dereferencing the NULL @errp. To follow the requirement of @errp, add missing ERRP_GUARD() in cxl_usp_realize(). Suggested-by: Markus Armbruster Signed-off-by: Zhao Liu Reviewed-by: Markus Armbruster Reviewed-by: Thomas Huth Message-ID: <20240223085653.1255438-6-zh

[PULL 34/55] bulk: Access existing variables initialized to >F when available

2024-03-12 Thread Thomas Huth
ks that need a rebase, and fixed sizeof() in pmu_realize()] Signed-off-by: Thomas Huth --- hw/display/ati.c | 2 +- hw/misc/macio/pmu.c | 3 +-- hw/misc/pvpanic-pci.c | 2 +- hw/pci-bridge/cxl_root_port.c | 2 +- hw/ppc/pnv.c | 20 ++--

[PULL 06/55] hw/intc: Check @errp to handle the error of IOAPICCommonClass.realize()

2024-03-12 Thread Thomas Huth
: <20240223085653.1255438-8-zhao1@linux.intel.com> Signed-off-by: Thomas Huth --- hw/intc/ioapic_common.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/intc/ioapic_common.c b/hw/intc/ioapic_common.c index cb9bf62146..efbe6958c8 100644 --- a/hw/intc/ioapic_common.c +++ b/h

[PULL 46/55] target/mips: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
From: Philippe Mathieu-Daudé Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-ID: <20240129164514.73104-19-phi...@linaro.org> Signed-off-by: Thoma

[PULL 03/55] hw/mem/cxl_type3: Fix missing ERRP_GUARD() in ct3_realize()

2024-03-12 Thread Thomas Huth
the bug that dereferencing the NULL @errp. To follow the requirement of @errp, add missing ERRP_GUARD() in ct3_realize(). Suggested-by: Markus Armbruster Signed-off-by: Zhao Liu Reviewed-by: Markus Armbruster Message-ID: <20240223085653.1255438-4-zhao1@linux.intel.com> Signed-off-by:

[PULL 01/55] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config()

2024-03-12 Thread Thomas Huth
ge-ID: <20240223085653.1255438-2-zhao1....@linux.intel.com> Signed-off-by: Thomas Huth --- hw/cxl/cxl-host.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c index 2aa776c79c..c5f5fcfd64 100644 --- a/hw/cxl/cxl-host.c +++ b/hw/cxl/cx

[PULL 00/55] Misc ERRP_GUARD() and cpu_env() patches

2024-03-12 Thread Thomas Huth
The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f: Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging (2024-03-09 20:12:21 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2024-03-12 for

Re: [PATCH v3 14/29] target/i386: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
On 30/01/2024 14.01, Igor Mammedov wrote: On Mon, 29 Jan 2024 17:44:56 +0100 Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. commenting here since, I'm not expert on coccinelle scripts. On negative

Re: [PATCH v3 00/29] hw, target: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-03-12 Thread Thomas Huth
On 29/01/2024 17.44, Philippe Mathieu-Daudé wrote: Patches missing review: 1, 2, 5, 6, 8, 11, 14, 15, 29 It will be simpler if I get the whole series via my hw-cpus tree once fully reviewed. Since v2: - Rebased - bsd/linux-user - Preliminary clean cpu_reset_hold - Add R-b Since v1: - Avoid

Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
On 12/03/2024 11.26, Zhao Liu wrote: On Tue, Mar 12, 2024 at 09:50:25AM +0100, Thomas Huth wrote: Date: Tue, 12 Mar 2024 09:50:25 +0100 From: Thomas Huth Subject: Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for error_prepend() On 12/03/2024 09.43, Zhao Liu wrote: Hi Thomas

Re: [PATCH v2 5/7] hw/pci-bridge/cxl_upstream: Fix missing ERRP_GUARD() in cxl_usp_realize()

2024-03-12 Thread Thomas Huth
= PCIE_PORT(d); CXLUpstreamPort *usp = CXL_USP(d); CXLComponentState *cxl_cstate = >cxl_cstate; Reviewed-by: Thomas Huth

Re: [PATCH v2 26/29] hw/virtio/vhost: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
g_autofree void *transfer_buf = NULL; g_autoptr(GError) g_err = NULL; Reviewed-by: Thomas Huth

Re: [PATCH v2 25/29] hw/virtio/vhost-vsock: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
VHostVSock *vsock = VHOST_VSOCK(dev); Reviewed-by: Thomas Huth

Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
On 12/03/2024 09.43, Zhao Liu wrote: Hi Thomas/Markus/Michael, For the remaing patches, could you please help me merge them next? Many thanks! Yes, I'm currently reviewing the ones that don't have a Reviewed-by yet. I can pick up the remaining patches if the other maintainers won't pick

Re: [PATCH v2 11/29] block/vdi: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
H_UNLOCKED vdi_co_do_create(BlockdevCreateOptions *create_options, size_t block_size, Error **errp) { +ERRP_GUARD(); BlockdevCreateOptionsVdi *vdi_opts; int ret = 0; uint64_t bytes = 0; Reviewed-by: Thomas Huth

Re: [PATCH v2 10/29] block/snapshot: Fix missing ERRP_GUARD() for error_prepend()

2024-03-12 Thread Thomas Huth
@@ -605,6 +606,7 @@ int bdrv_all_goto_snapshot(const char *name, bool has_devices, strList *devices, Error **errp) { +ERRP_GUARD(); g_autoptr(GList) bdrvs = NULL; GList *iterbdrvs; int ret; Reviewed-by: Thomas Huth

Re: [PATCH] docs/about/deprecated.rst: Move SMP configurations item to system emulator section

2024-03-12 Thread Thomas Huth
line arguments" section, which may cause confusion about the contents of this patch. --- docs/about/deprecated.rst | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 00/13] Cleanup on SMP and its test

2024-03-12 Thread Thomas Huth
On 12/03/2024 07.46, Zhao Liu wrote: Hi Philippe, On Sat, Mar 09, 2024 at 02:49:17PM +0100, Philippe Mathieu-Daudé wrote: Date: Sat, 9 Mar 2024 14:49:17 +0100 From: Philippe Mathieu-Daudé Subject: Re: [PATCH v2 00/13] Cleanup on SMP and its test On 9/3/24 01:46, Zhao Liu wrote: Hi Philippe,

Re: [PATCH 4/4] crypto: report which ciphers are being skipped during tests

2024-03-11 Thread Thomas Huth
Algorithm_str(test_data[i].alg), + QCryptoCipherMode_str(test_data[i].mode)); } } Reviewed-by: Thomas Huth

Re: [PATCH 3/4] crypto: use error_abort for unexpected failures

2024-03-11 Thread Thomas Huth
pher != NULL); } else { error_free_or_abort(); Reviewed-by: Thomas Huth

Re: [PATCH 2/4] crypto: query gcrypt for cipher availability

2024-03-11 Thread Thomas Huth
(qcrypto_cipher_alg_to_gcry_alg(alg), + GCRYCTL_TEST_ALGO, NULL, NULL) != 0) { +return false; +} + switch (mode) { case QCRYPTO_CIPHER_MODE_ECB: case QCRYPTO_CIPHER_MODE_CBC: Reviewed-by: Thomas Huth

Re: [PATCH 1/4] crypto: factor out conversion of QAPI to gcrypt constants

2024-03-11 Thread Thomas Huth
(-) Reviewed-by: Thomas Huth

Re: [PATCH v6] crypto: Introduce SM4 symmetric cipher algorithm

2024-03-11 Thread Thomas Huth
On 11/03/2024 11.14, Daniel P. Berrangé wrote: On Mon, Mar 11, 2024 at 09:32:32AM +, Daniel P. Berrangé wrote: On Fri, Mar 08, 2024 at 09:30:52PM +0100, Thomas Huth wrote: On 07/12/2023 16.47, Hyman Huang wrote: Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). SM4 (GBT.32907

Re: [RFC PATCH] gitlab: aggressively avoid extra GIT data

2024-03-11 Thread Thomas Huth
On 08/03/2024 16.07, Alex Bennée wrote: This avoids fetching blobs and tree references for branches we are not going to worry about. Also skip tag references which are similarly not useful and keep the default --prune. This keeps the .git data to around 100M rather than the ~400M even a shallow

Re: [PULL 26/29] disas: introduce show_opcodes

2024-03-11 Thread Thomas Huth
On 06/03/2024 15.40, Alex Bennée wrote: For plugins we don't expect the raw opcodes in the disassembly. We already deal with this by hand crafting our capstone call but for other diassemblers we need a flag. Introduce show_opcodes which defaults to off. Reviewed-by: Richard Henderson

Re: [RFC PATCH v2] tests/vm: avoid re-building the VM images all the time

2024-03-11 Thread Thomas Huth
vm.add_source_dir(args.build_qemu) Reviewed-by: Thomas Huth

Re: [RFC PATCH] tests/vm: ensure we build everything by default

2024-03-11 Thread Thomas Huth
tests/vm/basevm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH v3] hw/m68k/mcf5208: add support for reset

2024-03-09 Thread Thomas Huth
Am Sat, 9 Mar 2024 10:34:59 +0100 schrieb Angelo Dureghello : > Add reset support for mcf5208. > > Signed-off-by: Angelo Dureghello > --- > hw/m68k/mcf5208.c | 44 ++-- > 1 file changed, 42 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2] hw/m68k/mcf5208: add support for reset

2024-03-09 Thread Thomas Huth
Am Fri, 8 Mar 2024 10:08:12 +0100 schrieb Angelo Dureghello : > Add reset support for mcf5208. > > Signed-off-by: Angelo Dureghello > --- > hw/m68k/mcf5208.c | 49 --- > 1 file changed, 46 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH v6] crypto: Introduce SM4 symmetric cipher algorithm

2024-03-08 Thread Thomas Huth
On 07/12/2023 16.47, Hyman Huang wrote: Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). SM4 (GBT.32907-2016) is a cryptographic standard issued by the Organization of State Commercial Administration of China (OSCCA) as an authorized cryptographic algorithms for the use within

Re: [PATCH] hw/arm: Deprecate various old Arm machine types

2024-03-08 Thread Thomas Huth
+ hw/arm/tosa.c | 1 + hw/arm/z2.c | 1 + 8 files changed, 24 insertions(+) Reviewed-by: Thomas Huth

Re: [PATCH v2 02/13] hw/core/machine-smp: Deprecate unsupported "parameter=1" SMP configurations

2024-03-08 Thread Thomas Huth
anged, 61 insertions(+), 16 deletions(-) Reviewed-by: Thomas Huth

Re: [RFC PATCH 4/5] hw/i386/q35: Wire virtual SMI# lines to ICH9 chipset

2024-03-08 Thread Thomas Huth
On 08/03/2024 09.08, Philippe Mathieu-Daudé wrote: On 7/3/24 20:43, Thomas Huth wrote: On 28/02/2024 17.43, Zhao Liu wrote: Hi Philippe, +/* + * Real ICH9 contains a single SMI output line and doesn't broadcast CPUs. + * Virtualized ICH9 allows broadcasting upon negatiation with guest, see

Re: [PATCH] docs/about: Deprecate the "mainstone", "tosa" and "z2" machines

2024-03-08 Thread Thomas Huth
On 08/03/2024 16.43, Peter Maydell wrote: On Fri, 8 Mar 2024 at 10:42, Thomas Huth wrote: Support for these boards has been removed from the Linux kernel in version 6.3 in 2023, so there are likely no users left for these boards. Time to mark them as deprecated in QEMU, too! Signed-off

Re: [PATCH v2 2/3] target/arm/tcg/m_helper.c: Include the full helpers only with CONFIG_ARM_V7M

2024-03-08 Thread Thomas Huth
On 08/03/2024 15.00, Peter Maydell wrote: On Fri, 8 Mar 2024 at 12:54, Thomas Huth wrote: I gave it a try, but then we end up again with the problem that I already mentioned in the discussion about patch 1: CONFIG_ARM_V7M is not set for the linux-user binaries, so m_helper.c would not get

[PATCH v3 2/3] target/arm/tcg/m_helper.c: Include the full helpers only with CONFIG_ARM_V7M

2024-03-08 Thread Thomas Huth
If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged helper functions that require additional functions for linking. Use some stubs functions that call g_assert_not_reached() instead. Signed-off-by: Thomas Huth --- target/arm/tcg/m_helper.c | 93

[PATCH v3 0/3] target/arm: Allow compilation without CONFIG_ARM_V7M

2024-03-08 Thread Thomas Huth
onfig file. v3: - Rebase to current master branch - Make sure that the stubs use g_assert_not_reached() in the second patch v2: - Updated a comment - Avoid #ifdef in cpu-v7m.c, handle it via meson.build instead Thomas Huth (3): target/arm: Move v7m-related code from cpu32.c into a separate fil

[PATCH v3 3/3] target/arm/Kconfig: Stop requiring CONFIG_ARM_V7M

2024-03-08 Thread Thomas Huth
Now that we made sure that ARM_V7M code only gets compiled if really needed, we can drop the hard requirement for CONFIG_ARM_V7M in the Kconfig file. Signed-off-by: Thomas Huth --- target/arm/Kconfig | 4 1 file changed, 4 deletions(-) diff --git a/target/arm/Kconfig b/target/arm/Kconfig

[PATCH v3 1/3] target/arm: Move v7m-related code from cpu32.c into a separate file

2024-03-08 Thread Thomas Huth
Move the code to a separate file so that we do not have to compile it anymore if CONFIG_ARM_V7M is not set. Signed-off-by: Thomas Huth --- target/arm/tcg/cpu-v7m.c | 290 + target/arm/tcg/cpu32.c | 261 - target/arm

Re: [PATCH 05/14] tests/unit/test-smp-parse: Drop the unsupported "dies=1" case

2024-03-08 Thread Thomas Huth
ms, , true); - -/* Unsupported parameters can be provided with their values as 1 */ -data.config.has_dies = true; -data.config.dies = 1; -smp_parse_test(ms, , true); } object_unref(obj); Reviewed-by: Thomas Huth

Re: [PATCH 03/14] hw/core/machine-smp: Simplify variables' initialization in machine_parse_smp_config()

2024-03-08 Thread Thomas Huth
On 06/03/2024 10.53, Zhao Liu wrote: From: Zhao Liu SMPConfiguration initializes its int64_t members as 0 by default. Can we always rely on that? ... or is this just by luck due to the current implementation? In the latter case, I'd maybe rather drop this patch again. Thomas

Re: [PATCH v2 2/3] target/arm/tcg/m_helper.c: Include the full helpers only with CONFIG_ARM_V7M

2024-03-08 Thread Thomas Huth
On 04/03/2024 16.22, Peter Maydell wrote: On Thu, 1 Feb 2024 at 19:12, Thomas Huth wrote: On 01/02/2024 15.19, Peter Maydell wrote: On Mon, 29 Jan 2024 at 08:18, Thomas Huth wrote: If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged helper functions that require

Re: [PATCH] configure: Fix error message when C compiler is not working

2024-03-08 Thread Thomas Huth
On 08/03/2024 12.26, Peter Maydell wrote: On Fri, 8 Mar 2024 at 06:01, Thomas Huth wrote: If you try to run the configure script on a system without a working C compiler, you get a very misleading error message: ERROR: Unrecognized host OS (uname -s reports 'Linux') We should rather tell

[PATCH] docs/about: Deprecate the "mainstone", "tosa" and "z2" machines

2024-03-08 Thread Thomas Huth
Support for these boards has been removed from the Linux kernel in version 6.3 in 2023, so there are likely no users left for these boards. Time to mark them as deprecated in QEMU, too! Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 8 hw/arm/mainstone.c| 1 + hw

Re: [PATCH 17/17] target/s390x/cpu_models: Fix missing ERRP_GUARD() for error_prepend()

2024-03-08 Thread Thomas Huth
On 08/03/2024 11.12, Zhao Liu wrote: Hi Thomas, void s390_realize_cpu_model(CPUState *cs, Error **errp) { +ERRP_GUARD(); Error *err = NULL; I think that function could use an additional clean-up now: Remove the local "err" variable and use "errp" only instead. Since many

Re: [PATCH 1/5] scripts/kernel-doc: teach kdoc about QLIST_ macros

2024-03-08 Thread Thomas Huth
On 08/03/2024 09.22, Peter Xu wrote: On Fri, Mar 08, 2024 at 08:09:15AM +, Alex Bennée wrote: Peter Xu writes: On Thu, Mar 07, 2024 at 06:11:01PM +, Alex Bennée wrote: The kernel-doc script does some pre-processing on structure definitions before parsing for names. Teach it about

Re: [PATCH v4 05/25] s390/stattrib: Add Error** argument to set_migrationmode() handler

2024-03-08 Thread Thomas Huth
: Christian Borntraeger Cc: Thomas Huth Signed-off-by: Cédric Le Goater --- Reviewed-by: Thomas Huth

[PATCH] configure: Fix error message when C compiler is not working

2024-03-07 Thread Thomas Huth
time to figure out what was going wrong. Fixes: 264b803721 ("configure: remove compiler sanity check") Signed-off-by: Thomas Huth --- configure | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 3cd736b139..a036923dee 100755 --- a

Re: [PATCH 1/5] target/sparc/cpu: Rename the CPU models with a "+" in their names

2024-03-07 Thread Thomas Huth
On 07/03/2024 22.22, Richard Henderson wrote: On 3/7/24 07:43, Thomas Huth wrote: +    /* Fix up legacy names with '+' in it */ +    if (g_str_equal(typename, SPARC_CPU_TYPE_NAME("Sun-UltraSparc-IV+"))) { +    g_free(typename); +    typename = g_strdup(SPARC_CPU_TYPE

Re: [RFC PATCH 4/5] hw/i386/q35: Wire virtual SMI# lines to ICH9 chipset

2024-03-07 Thread Thomas Huth
On 28/02/2024 17.43, Zhao Liu wrote: Hi Philippe, +/* + * Real ICH9 contains a single SMI output line and doesn't broadcast CPUs. + * Virtualized ICH9 allows broadcasting upon negatiation with guest, see + * commit 5ce45c7a2b. + */ +enum { +ICH9_VIRT_SMI_BROADCAST, +

<    2   3   4   5   6   7   8   9   10   11   >