Re: [RFC PATCH] tests/vm: update openbsd image to 7.4

/openbsd | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Thanks, this seems to work fine: Tested-by: Thomas Huth

[PATCH] tests/unit/test-util-sockets: Remove temporary file after test

test-util-sockets leaves the temporary socket files around in the temporary files folder. Let's better remove them at the end of the testing. Signed-off-by: Thomas Huth --- tests/unit/test-util-sockets.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit/test-util-sockets.c b/tests

Re: [PATCH 6/6] tests/qtest: Add ivshmem-flat test

vshmem-flat-test.c Acked-by: Thomas Huth

Re: [PATCH 5/6] tests/qtest: Reorganize common code in ivshmem-test

u", g_get_tmp_dir(), getpid(), g_test_rand_int()); Anyway: Acked-by: Thomas Huth

Re: [RFC PATCH] target/ppc/mmu: Silent maybe-uninitialized error in ppc_hash64_xlate()

On 23/02/2024 09.32, Philippe Mathieu-Daudé wrote: Initialize apshift to avoid a maybe-uninitialized error: C compiler for the host machine: cc -m64 -mbig-endian (gcc 13.2.0 "cc (Debian 13.2.0-10) 13.2.0") C linker for the host machine: cc -m64 -mbig-endian ld.bfd 2.41.90.20240115

Re: [PATCH 09/10] usb: extract sysbus-ohci to a separate file

nclude "migration/vmstate.h" +#include "hw/sysbus.h" +#include "hw/qdev-dma.h" +#include "hw/qdev-properties.h" +#include "trace.h" +#include "hcd-ohci.h" + + +static void ohci_realize_pxa(DeviceState *dev, Error **errp) Maybe this could

Re: [PATCH 04/10] mips/loongson3_virt: do not require CONFIG_USB

On 23/02/2024 13.44, Paolo Bonzini wrote: Once the Kconfig for hw/mips is cleaned up, it will be possible to build a binary that does not include any USB host controller and therefore that does not include the code guarded by CONFIG_USB. While the simpler creation functions such as

Re: [PATCH 03/10] sh4: r2d: do not use usb_bus_find()

"usb-kbd"); +usb_bus = USB_BUS(object_resolve_type_unambiguous(TYPE_USB_BUS, _abort)); +usb_create_simple(usb_bus, "usb-kbd"); /* Todo: register on board registers */ memset(_params, 0, sizeof(boot_params)); Reviewed-by: Thomas Huth

Re: [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find()

"usb-mouse"); /* PCIe buses */ dev = qdev_new(TYPE_PPC460EX_PCIE_HOST); Reviewed-by: Thomas Huth

Re: [PATCH 01/10] acpi, qom: move object_resolve_type_unambiguous to core QOM

| 13 + hw/i386/acpi-build.c | 19 --- qom/object.c | 16 3 files changed, 33 insertions(+), 15 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 05/10] hppa: do not require CONFIG_USB

On 24/02/2024 23.38, Paolo Bonzini wrote: On Fri, Feb 23, 2024 at 8:56 PM BALATON Zoltan wrote: -if (!lasi_dev && machine->enable_graphics) { +if (!lasi_dev && machine->enable_graphics && defaults_enabled()) { Do we need the defaults_enabled() here? Isn't enable_graphics already

Re: [PATCH v2 1/3] hw/arm/sbsa-ref: Do not open-code ahci_ide_create_devs()

>gic, irq)); sysahci = SYSBUS_AHCI(dev); -    ahci = >ahci; ide_drive_get(hd, ARRAY_SIZE(hd)); -    for (i = 0; i < ahci->ports; i++) { -    if (hd[i] == NULL) { -    continue; -    } -    ide_bus_create_drive(>dev[i].port, 0, hd[i]); -    } +    ahci_ide_create_devs(>ahci, hd);  } Reviewed-by: Thomas Huth

Re: [PATCH v2 4/6] hw/i386/pc: Remove unneeded class attribute "kvmclock_enabled"

overrides of this attribute. The attribute is now unneeded and can be removed. Fixes: 30d2a17b46e9 "hw/i386: Remove the deprecated machines 0.12 up to 0.15" Cc: Thomas Huth Signed-off-by: Bernhard Beschow --- include/hw/i386/pc.h | 1 - hw/i386/pc.c | 1 - hw/i386/pc_piix.c| 2 +-

Re: [PATCH 05/10] hppa: do not require CONFIG_USB

On 23/02/2024 13.44, Paolo Bonzini wrote: With --without-default-devices it is possible to build a binary that does not include any USB host controller and therefore that does not include the code guarded by CONFIG_USB. While the simpler creation functions such as usb_create_simple can be

[PULL 08/11] docs: Document that 32-bit Windows is unsupported

From: Peter Maydell Reviewed-by: Thomas Huth Reviewed-by: "Daniel P. Berrangé" Reviewed-by: Alex Bennée Signed-off-by: Peter Maydell Message-ID: <20240222130920.362517-2-peter.mayd...@linaro.org> Signed-off-by: Thomas Huth --- docs/about/build-platforms.rst | 2 ++ do

[PULL 07/11] meson: Enable -Wvla

ebased to current master branch] Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-ID: <20240221162636.173136-4-th...@redhat.com> Signed-off-by: Thomas Huth --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index c1dc83e4c0

[PULL 06/11] target/ppc/kvm: Replace variable length array in kvmppc_read_hptes()

Peter Maydell Signed-off-by: Thomas Huth --- target/ppc/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index e7e39c3091..bcf30a5400 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2770,9 +2770,9 @@ void kvmppc_read

[PULL 11/11] target/i386: do not filter processor tracing features except on KVM

Call accel-agnostic x86_cpu_get_supported_cpuid()") Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- target/i386/cpu.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index bca776e1fe..7f90823676 100644 --- a/target/

Re: [PATCH] hw/ide: Remove last two uses of ide/internal.h outside of hw/ide

t;hw/ide/internal.h" +#include "hw/ide/ide-bus.h" #include "hw/intc/heathrow_pic.h" #include "hw/misc/macio/cuda.h" #include "hw/misc/macio/gpio.h" Oh, I was sure that I got them all ... thanks for double checking! Reviewed-by: Thomas Huth

Re: [PATCH v2 02/27] tests/tcg: bump TCG test timeout to 120s

. +TIMEOUT=120 ifeq ($(filter %-softmmu, $(TARGET)),) # The order we include is important. We include multiarch first and Reviewed-by: Thomas Huth

[PULL 09/11] .gitlab-ci.d: Drop cross-win32-system job

From: Peter Maydell We don't support 32-bit Windows any more, so we don't need to defend it with this CI job. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Reviewed-by: "Daniel P. Berrangé" Reviewed-by: Alex Bennée Message-ID: <20240222130920.362517-3-peter.mayd.

[PULL 01/11] target/m68k: Fix exception frame format for 68010

ove, and then use it to control if the format and vector word are pushed/pop during exception entry/exit. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2164 Signed-off-by: Daniel Palmer Message-ID: <20240115101643.2165387-1-dan...@0x0f.com> Reviewed-by: Thomas Huth Signed-off-by: Th

[PULL 05/11] target/ppc/kvm: Replace variable length array in kvmppc_save_htab()

Signed-off-by: Thomas Huth --- target/ppc/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 26fa9d0575..e7e39c3091 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2688,7 +2688,7 @@ int kvmppc_get_htab_fd(bool write, uint64_t

[PULL 04/11] tests: skip dbus-display tests that need a console

requiring the Console interface at runtime. Reported-by: Thomas Huth Signed-off-by: Marc-André Lureau Message-ID: <20240221073759.171443-1-marcandre.lur...@redhat.com> Tested-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/dbus-display-test.c | 16 ++-- 1 file changed, 14

[PULL 00/11] Test and misc patches

): meson: Enable -Wvla docs: Document that 32-bit Windows is unsupported .gitlab-ci.d: Drop cross-win32-system job .gitlab-ci.d/windows.yml: Remove shared-msys2 abstraction Thomas Huth (3): tests/qtest: Fix boot-serial-test when using --without-default-devices target

[PULL 10/11] .gitlab-ci.d/windows.yml: Remove shared-msys2 abstraction

pe Mathieu-Daudé Message-ID: <20240222130920.362517-4-peter.mayd...@linaro.org> Signed-off-by: Thomas Huth --- .gitlab-ci.d/windows.yml | 85 +++- 1 file changed, 41 insertions(+), 44 deletions(-) diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/w

[PULL 03/11] tests/qtest: Fix boot-serial-test when using --without-default-devices

let's simply switch to the "pci-bridge" device here instead, which should always be there for PCI-based machines like the sam460ex. Message-ID: <20240219111030.384158-1-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/boot-serial-test.c | 2 +- 1 file changed, 1 ins

[PULL 02/11] tests/cdrom-test: Add cdrom test for LoongArch virt machine

100230.134042-1-maob...@loongson.cn> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/cdrom-test.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c index 0945383789..5d89e62515 100644 --- a/tests/qtest/cdrom-te

Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

On 20/02/2024 02.13, Nicholas Piggin wrote: On Tue Feb 20, 2024 at 12:10 AM AEST, Thomas Huth wrote: On 19/02/2024 07.17, Nicholas Piggin wrote: The fastpath in cpu_physical_memory_sync_dirty_bitmap() to test large aligned ranges forgot to bring the TCG TLB up to date after clearing some

Re: [PATCH] target/i386: do not filter processor tracing features except on KVM

t/i386: Call accel-agnostic x86_cpu_get_supported_cpuid()") Reviewed-by: Thomas Huth

Re: [PATCH] gitlab: force allow use of pip in Cirrus jobs

://gitlab.com/thuth/qemu/-/jobs/6233183719 Tested-by: Thomas Huth

Re: [PATCH 2/3] .gitlab-ci.d: Drop cross-win32-system job

On 22/02/2024 12.44, Peter Maydell wrote: On Tue, 20 Feb 2024 at 18:46, Philippe Mathieu-Daudé wrote: On 20/2/24 18:44, Peter Maydell wrote: We don't support 32-bit Windows any more, so we don't need to defend it with this CI job. Signed-off-by: Peter Maydell ---

Re: [PATCH v2 1/3] target/arm: Move v7m-related code from cpu32.c into a separate file

On 01/02/2024 19.52, Thomas Huth wrote: On 01/02/2024 15.17, Peter Maydell wrote: On Mon, 29 Jan 2024 at 08:18, Thomas Huth wrote: Move the code to a separate file so that we do not have to compile it anymore if CONFIG_ARM_V7M is not set. Signed-off-by: Thomas Huth ---   target/arm/tcg/cpu

Re: [PATCH] target/m68k: Fix exception frame format for 68010

all except 68000 */ CPUState *cs = env_cpu(env); switch (format) { LGTM, Reviewed-by: Thomas Huth Laurent, if you're currently too busy with other stuff, I could also add this to my next pull request? Thomas

Re: [PATCH] hw/intc/Kconfig: Fix GIC settings when using "--without-default-devices"

On 22/02/2024 08.57, Philippe Mathieu-Daudé wrote: On 21/2/24 12:00, Thomas Huth wrote: When using "--without-default-devices", the ARM_GICV3_TCG and ARM_GIC_KVM settings currently get disabled, though the arm virt machine is only of very limited use in that case. This also causes the

Re: [PATCH v2 1/2] docs/system: Update description for input grab key

("sdl: use ctrl-alt-g as grab hotkey") Reviewed-by: Thomas Huth

Re: [PATCH v2 2/2] system/vl: Update description for input grab key

"ctrl-alttoggle mouse and keyboard grab\n" + "ctrl-alt-g toggle mouse and keyboard grab\n" "\n" "When using -nographic, press 'ctrl-a h' to get some help.\n" "\n" Fixes: f8d2c9369b ("sdl: use ctrl-alt-g as grab hotkey") Reviewed-by: Thomas Huth

Re: [PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h

On 21/02/2024 19.43, Philippe Mathieu-Daudé wrote: On 20/2/24 09:55, Thomas Huth wrote: Unentangle internal.h by moving public IDE device related Disentangle ... from? Untangle? TIL Unentangle. You're right, "disentangle" seems to be the more appropriate word. I'll fix it up.

[PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

indicates, but since we use and index into the info[] array, this of course cannot work. The intention here was likely rather to use the container_of() macro instead, so switch the code accordingly. Signed-off-by: Thomas Huth --- hw/sparc/leon3.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 3/3] meson: Enable -Wvla

On 21/02/2024 17.59, Thomas Huth wrote: On 21/02/2024 17.26, Thomas Huth wrote: From: Peter Maydell QEMU has historically used variable length arrays only very rarely. Variable length arrays are a potential security issue where an on-stack dynamic allocation isn't correctly size-checked

Re: [PATCH 3/3] meson: Enable -Wvla

On 21/02/2024 17.26, Thomas Huth wrote: From: Peter Maydell QEMU has historically used variable length arrays only very rarely. Variable length arrays are a potential security issue where an on-stack dynamic allocation isn't correctly size-checked, especially when the size comes from the guest

Re: [PATCH 1/3] target/ppc/kvm: Replace variable length array in kvmppc_save_htab()

On 21/02/2024 17.29, Peter Maydell wrote: On Wed, 21 Feb 2024 at 16:26, Thomas Huth wrote: To be able to compile QEMU with -Wvla (to prevent potential security issues), we need to get rid of the variable length array in the kvmppc_save_htab() function. Replace it with a heap allocation

[PATCH 2/3] target/ppc/kvm: Replace variable length array in kvmppc_read_hptes()

HPTES_PER_GROUP is 8 and HASH_PTE_SIZE_64 is 16, so we don't waste too many bytes by always allocating the maximum amount of bytes on the stack here to get rid of the variable length array. Suggested-by: Peter Maydell Signed-off-by: Thomas Huth --- target/ppc/kvm.c | 4 ++-- 1 file changed, 2

[PATCH 0/3] Replace variable length arrays in ppc KVM code

those, we can finally enable the -Wvla compiler switch. Peter Maydell (1): meson: Enable -Wvla Thomas Huth (2): target/ppc/kvm: Replace variable length array in kvmppc_save_htab() target/ppc/kvm: Replace variable length array in kvmppc_read_hptes() meson.build | 1 + target/ppc/kvm.c

[PATCH 3/3] meson: Enable -Wvla

ebased to current master branch] Signed-off-by: Thomas Huth --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index c1dc83e4c0..0ef1654e86 100644 --- a/meson.build +++ b/meson.build @@ -592,6 +592,7 @@ warn_flags = [ '-Wstrict-prototypes', '-Wtype-

[PATCH 1/3] target/ppc/kvm: Replace variable length array in kvmppc_save_htab()

To be able to compile QEMU with -Wvla (to prevent potential security issues), we need to get rid of the variable length array in the kvmppc_save_htab() function. Replace it with a heap allocation instead. Signed-off-by: Thomas Huth --- target/ppc/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] hw/intc/Kconfig: Fix GIC settings when using "--without-default-devices"

es enabled in the --without-default-devices builds, too. Signed-off-by: Thomas Huth --- hw/intc/Kconfig | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig index 97d550b06b..2b5b2d2301 100644 --- a/hw/intc/Kconfig +++ b/hw/intc/Kconfig

[qemu-web PATCH] Replace deprecated "bundle install --path vendor"

When running "bundle install --path vendor", the command complains that the --path parameter is deprecated nowadays and that "bundle config set --local path 'vendor'" should be used instead. So let's update our README accordingly. Signed-off-by: Thomas Huth --- README | 3 ++

Re: [PATCH] tests: skip dbus-display tests that need a console

to figure this during build time, so skip the tests requiring the Console interface at runtime. Reported-by: Thomas Huth Signed-off-by: Marc-André Lureau --- tests/qtest/dbus-display-test.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) Thanks, that works fine! Tested-

Re: [PATCH 3/3] .gitlab-ci.d/windows.yml: Remove shared-msys2 abstraction

On 20/02/2024 19.06, Daniel P. Berrangé wrote: On Tue, Feb 20, 2024 at 05:44:12PM +, Peter Maydell wrote: Now we don't build msys2-32bit we don't need the abstraction out of the common msys2 handling from the 32-vs-64-bit specifics. Collapse it down into the msys2-64bit job definition.

Re: [PATCH 2/3] .gitlab-ci.d: Drop cross-win32-system job

--- .../dockerfiles/fedora-win32-cross.docker | 111 -- tests/lcitool/refresh | 5 - 4 files changed, 135 deletions(-) delete mode 100644 tests/docker/dockerfiles/fedora-win32-cross.docker Reviewed-by: Thomas Huth

Re: [PATCH 1/3] docs: Document that 32-bit Windows is unsupported

as an administrator. +Only 64-bit Windows is supported. ... Reviewed-by: Thomas Huth

Re: [PATCH 2/3] .gitlab-ci.d: Drop cross-win32-system job

On 20/02/2024 19.55, Daniel P. Berrangé wrote: On Tue, Feb 20, 2024 at 07:46:37PM +0100, Philippe Mathieu-Daudé wrote: On 20/2/24 18:44, Peter Maydell wrote: We don't support 32-bit Windows any more, so we don't need to defend it with this CI job. Signed-off-by: Peter Maydell ---

Re: [PATCH qemu-web] _download/windows.md: Drop 32-bit Windows support

On 20/02/2024 19.06, Peter Maydell wrote: 32-bit Windows is no longer a supported platform for QEMU, and both MSYS2 and Stefan Weil have stopped building 32-bit packages of it. Remove the no-longer-working i686 pacman rune, and state explicitly that 32 bit Windows isn't supported. Fix a grammar

Re: [PATCH] .gitlab-ci.d/windows.yml: Drop msys2-32bit job

or another patch, so: Reviewed-by: Thomas Huth

Re: [PATCH] tests/qtest: Don't run the dbus-display-test without CONFIG_VGA_PCI

On 19/02/2024 15.00, Marc-André Lureau wrote: Hi On Mon, Feb 19, 2024 at 4:39 PM Thomas Huth wrote: When compiling with "configure --without-default-devices", the dbus-display-test fails since it implicitly assumes that the machine comes with the standard VGA card. Thus a

Re: [PATCH 5/5] tests: Add migration test for loongarch64

insertions(+), 1 deletion(-) create mode 100644 tests/migration/loongarch64/Makefile create mode 100644 tests/migration/loongarch64/a-b-kernel.S create mode 100644 tests/migration/loongarch64/a-b-kernel.h FWIW: Acked-by: Thomas Huth

Re: [PATCH 4/5] hw/loongarch: Set minimium memory size as 256M

On 20/02/2024 13.41, Bibo Mao wrote: The minium memory size for LoongArch UEFI bios is 256M, also some test cases such as migration and qos uses parameter 256M. Here set minium memory size for Loongarch VirtMachine with 256M, also default memory size is changed with 256M. Signed-off-by: Bibo

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote: Have s390x always deliver NMI to the first CPU, remove the @cpu_index argument from handler, rename API as nmi_trigger() (not monitor specific). Could you please add some rationale here why this is needed / desired? Thanks, Thomas

Re: [PATCH 06/14] hw/pci-bridge: Extract QOM ICH definitions to 'ich_dmi_pci.h'

On 20/02/2024 13.20, BALATON Zoltan wrote: On Tue, 20 Feb 2024, Philippe Mathieu-Daudé wrote: On 19/2/24 19:24, BALATON Zoltan wrote: On Mon, 19 Feb 2024, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: Expose TYPE_ICH_DMI_PCI_BRIDGE to the new

Re: [PATCH v1 20/21] s390x: correct typos

quot;cmm", MISC, 0, "Collaborative-memory-management facility") Reviewed-by: Thomas Huth

Re: [PATCH v1 19/21] m68k: correct typos

On 20/02/2024 09.52, Manos Pitsidianakis wrote: Correct typos automatically found with the `typos` tool Signed-off-by: Manos Pitsidianakis --- target/m68k/cpu.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/m68k/cpu.h

Re: [PATCH v2 3/3] tests/qtest: Add testcase for BCM2835 BSC

On 20/02/2024 11.30, Rayhan Faizel wrote: Hi Thomas, Do you want me to add an SPDX line to the other two commits or will just this one suffice? I think it wouldn't hurt to add them to the new files there, too, but there's no rule in the QEMU development process that you have to do it, so

[PATCH v2 6/7] hw/ide: Remove the include/hw/ide.h legacy file

There was only one prototype left in this legacy file. Move it to ide-dev.h to finally get rid of it. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 1 - include/hw/ide.h | 9 - include/hw/ide/ide-dev.h | 2 ++ include/hw/ide

[PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h

Unentangle internal.h by moving public IDE device related definitions to ide-dev.h. Signed-off-by: Thomas Huth --- include/hw/ide/ide-dev.h | 143 +- include/hw/ide/internal.h | 143 +- hw/ide/ide-dev.c | 1 + 3

[PATCH v2 1/7] hw/ide: Add the possibility to disable the CompactFlash device in the build

definitions related to IDE devices. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- include/hw/ide/ide-dev.h | 41 hw/ide/cf.c | 58 hw/ide/qdev.c| 51

[PATCH v2 0/7] hw/ide: Clean up hw/ide/qdev.c and include/hw/ide/internal.h

/ide.h Thomas Huth (7): hw/ide: Add the possibility to disable the CompactFlash device in the build hw/ide: Split qdev.c into ide-bus.c and ide-dev.c hw/ide: Move IDE DMA related definitions to a separate header ide-dma.h hw/ide: Move IDE device related definitions to ide-dev.h hw

[PATCH v2 5/7] hw/ide: Move IDE bus related definitions to a new header ide-bus.h

Let's consolidate the public IDE bus related functions in a separate header. Signed-off-by: Thomas Huth --- include/hw/ide/ide-bus.h | 42 +++ include/hw/ide/internal.h | 40 + 2 files changed, 43 insertions(+), 39

[PATCH v2 7/7] hw/ide: Stop exposing internal.h to non-IDE files

-by: Thomas Huth --- include/hw/ide/pci.h | 2 +- hw/i386/pc.c | 2 +- hw/ide/cmd646.c | 1 + hw/ide/pci.c | 1 + hw/ide/piix.c| 1 + hw/ide/sii3112.c | 1 + hw/ide/via.c | 1 + 7 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/hw/ide

[PATCH v2 3/7] hw/ide: Move IDE DMA related definitions to a separate header ide-dma.h

These definitions are required outside of the hw/ide/ code, too, so lets's move them from internal.h to a new header called ide-dma.h. Signed-off-by: Thomas Huth --- include/hw/ide/ide-dma.h | 37 + include/hw/ide/internal.h | 29

[PATCH v2 2/7] hw/ide: Split qdev.c into ide-bus.c and ide-dev.c

qdev.c is a mixture between IDE bus specific functions and IDE device functions. Let's split it up to make it more obvious which part is related to bus handling and which part is related to device handling. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/ide/ide-bus.c

Re: [PATCH v2 3/3] tests/qtest: Add testcase for BCM2835 BSC

IN + * THE SOFTWARE. + */ Could you maybe also add a SPDX license line, so that it is more obvious at a quick glance what license this is? Anyway, Acked-by: Thomas Huth

Re: [PATCH 5/7] hw/ide: Move IDE DMA related definitions to a separate header ide-dma.h

On 19/02/2024 12.53, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Thomas Huth wrote: These definitions are required outside of the hw/ide/ code, too, so lets's move them from internal.h to a new header called ide-dma.h. Signed-off-by: Thomas Huth --- include/hw/ide/ide-dma.h  | 30

Re: [PATCH 3/7] hw/ide: Move IDE device related definitions to ide-dev.h

On 19/02/2024 12.32, Philippe Mathieu-Daudé wrote: On 19/2/24 11:49, Thomas Huth wrote: Let's start to unentangle internal.h by moving public IDE device related definitions to ide-dev.h. Signed-off-by: Thomas Huth ---   include/hw/ide/ide-dev.h  | 145

Re: [PATCH 2/7] hw/ide: Split qdev.c into ide-bus.c and ide-dev.c

On 19/02/2024 12.45, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Thomas Huth wrote: qdev.c is a mixture between IDE bus specific functions and IDE device functions. Let's split it up to make it more obvious which part is related to bus handling and which part is related to device handling

Re: dropping 32-bit Windows host support

On 19/02/2024 16.53, Daniel P. Berrangé wrote: On Mon, Feb 19, 2024 at 03:37:31PM +, Peter Maydell wrote: Our msys2 32-bit Windows host CI job has been failing recently because upstream MSYS2 are starting to phase out 32-bit windows host support and are steadily removing i686 versions of

Re: [PATCH v2 1/3] tests/migration-test: Stick with gicv3 in aarch64 test

On 19/02/2024 13.50, Peter Maydell wrote: On Mon, 19 Feb 2024 at 11:54, Thomas Huth wrote: On 07/02/2024 01.54, pet...@redhat.com wrote: From: Peter Xu Recently we introduced cross-binary migration test. It's always wanted that migration-test uses stable guest ABI for both QEMU binaries

Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

On 19/02/2024 07.17, Nicholas Piggin wrote: The fastpath in cpu_physical_memory_sync_dirty_bitmap() to test large aligned ranges forgot to bring the TCG TLB up to date after clearing some of the dirty memory bitmap bits. This can result in stores though the TCG TLB not setting the dirty memory

Re: [PATCH v2 6/6] tests/qtest: Add ivshmem-flat test

On 16/02/2024 15.44, Philippe Mathieu-Daudé wrote: From: Gustavo Romero Add qtest for the ivshmem-flat device. Signed-off-by: Gustavo Romero Message-ID: <20231127052024.435743-4-gustavo.rom...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/ivshmem-flat-test.c | 320

Re: [PATCH v2 5/6] tests/qtest: Reorganize common code in ivshmem-test

On 16/02/2024 15.44, Philippe Mathieu-Daudé wrote: From: Gustavo Romero This commit reorganizes the ivshmem-test qtest by moving common structs, functions, and code that can be utilized by other ivshmem qtests into two new files: ivshmem-utils.h and ivshmem-utils.c. Enum Reg, struct

Re: [PATCH 19/21] hw/s390x/zpci-bus: Add QOM parentship relation with zPCI devices

On 16/02/2024 12.03, Philippe Mathieu-Daudé wrote: QDev objects created with qdev_*new() need to manually add their parent relationship with object_property_add_child(). Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/s390-pci-bus.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] tests/qtest: Don't run the dbus-display-test without CONFIG_VGA_PCI

When compiling with "configure --without-default-devices", the dbus-display-test fails since it implicitly assumes that the machine comes with the standard VGA card. Thus add a check to meson.build to disable the test if the VGA card is not available. Signed-off-by: Thomas Huth --- t

Re: [PATCH] tests/qtest: Fix boot-serial-test when using --without-default-devices

On 19/02/2024 12.37, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Thomas Huth wrote: If "configure" has been run with "--without-default-devices", there is no e1000 device in the binaries, so the boot-serial-test currently fails in that case since it tries to use the e10

Re: [PATCH v2 1/3] tests/migration-test: Stick with gicv3 in aarch64 test

On 07/02/2024 01.54, pet...@redhat.com wrote: From: Peter Xu Recently we introduced cross-binary migration test. It's always wanted that migration-test uses stable guest ABI for both QEMU binaries in this case, so that both QEMU binaries will be compatible on the migration stream with the

[PATCH] tests/qtest: Fix boot-serial-test when using --without-default-devices

let's simply switch to the "pci-bridge" device here instead, which should always be there for PCIe-based machines like the sam460ex. Signed-off-by: Thomas Huth --- tests/qtest/boot-serial-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/boot-se

[PATCH 1/7] hw/ide: Add the possibility to disable the CompactFlash device in the build

definitions related to IDE devices. Signed-off-by: Thomas Huth --- include/hw/ide/ide-dev.h | 41 hw/ide/cf.c | 58 hw/ide/qdev.c| 51 ++- hw/ide/Kconfig | 4

[PATCH 6/7] hw/ide: Remove the include/hw/ide.h legacy file

There was only one prototype left in this legacy file. Move it to ide-dev.h to finally get rid of it. Signed-off-by: Thomas Huth --- include/hw/ide.h | 9 - include/hw/ide/ide-dev.h | 2 ++ include/hw/ide/internal.h | 1 - 3 files changed, 2 insertions(+), 10 deletions

[PATCH 7/7] hw/ide: Stop exposing internal.h to non-IDE files

include/hw/ide/internal.h is currently included by include/hw/ide/pci.h and thus exposed to a lot of files that are not part of the IDE subsystem. Stop including internal.h there and use the appropriate new headers ide-bus.h and ide-dma.h instead. Signed-off-by: Thomas Huth --- include/hw/ide

[PATCH 0/7] hw/ide: Clean up hw/ide/qdev.c and include/hw/ide/internal.h

included by files in hw/ide/ as it should be. Thomas Huth (7): hw/ide: Add the possibility to disable the CompactFlash device in the build hw/ide: Split qdev.c into ide-bus.c and ide-dev.c hw/ide: Move IDE device related definitions to ide-dev.h hw/ide: Move IDE bus related definitions

[PATCH 3/7] hw/ide: Move IDE device related definitions to ide-dev.h

Let's start to unentangle internal.h by moving public IDE device related definitions to ide-dev.h. Signed-off-by: Thomas Huth --- include/hw/ide/ide-dev.h | 145 +- include/hw/ide/internal.h | 145 +- hw/ide/ide-dev.c

[PATCH 4/7] hw/ide: Move IDE bus related definitions to a new header ide-bus.h

Let's consolidate the public IDE bus related functions in a separate header. Signed-off-by: Thomas Huth --- include/hw/ide/ide-bus.h | 41 +++ include/hw/ide/internal.h | 38 +--- 2 files changed, 42 insertions(+), 37

[PATCH 5/7] hw/ide: Move IDE DMA related definitions to a separate header ide-dma.h

These definitions are required outside of the hw/ide/ code, too, so lets's move them from internal.h to a new header called ide-dma.h. Signed-off-by: Thomas Huth --- include/hw/ide/ide-dma.h | 30 ++ include/hw/ide/internal.h | 27 +-- 2

[PATCH 2/7] hw/ide: Split qdev.c into ide-bus.c and ide-dev.c

qdev.c is a mixture between IDE bus specific functions and IDE device functions. Let's split it up to make it more obvious which part is related to bus handling and which part is related to device handling. Signed-off-by: Thomas Huth --- hw/ide/ide-bus.c | 111

Re: QEMU development setup

On 17/02/2024 19.52, Isaac David Bermudez Lara wrote: Hi, I am just starting out on QEMU development, and I would like to know which tools to use. I would really appreciate it. Hi Isaac, please see https://wiki.qemu.org/Hosts/Linux for some hints on how to get started. Additionally, how

Re: [PATCH v2] tests/cdrom-test: Add cdrom test for LoongArch virt machine

; add_cdrom_param_tests(nonemachine); base-commit: 5767815218efd3cbfd409505ed824d5f356044ae Reviewed-by: Thomas Huth

Re: [PATCH 6/6] tests/libqos: add riscv/virt machine nodes

/meson.build | 1 + tests/qtest/libqos/riscv-virt-machine.c | 137 2 files changed, 138 insertions(+) create mode 100644 tests/qtest/libqos/riscv-virt-machine.c Acked-by: Thomas Huth

Re: [PATCH 2/6] libqos/virtio.c: fix 'avail_event' offset in qvring_init()

ocator *alloc, QVirtQueue *vq, /* vq->used->idx */ qvirtio_writew(vq->vdev, qts, vq->used + 2, 0); /* vq->used->avail_event */ -qvirtio_writew(vq->vdev, qts, vq->used + 2 + +qvirtio_writew(vq->vdev, qts, vq->used + 4 + sizeof(struct vring_used_elem) * vq->size, 0); } Reviewed-by: Thomas Huth

Re: [PATCH 1/6] libqos/virtio.c: init all elems in qvring_indirect_desc_setup()

libqos/virtio.c:236:qvirtio_wait_used_elem: assertion failed: (g_get_monotonic_time() - start_time <= timeout_us) The root cause is using unintialized values from guest_alloc() in s/unintialized/uninitialized/ With the typos fixed: Reviewed-by: Thomas Huth

Re: [PATCH] docs/system/ppc: Document running Linux on AmigaNG machines

On 16/02/2024 01.10, BALATON Zoltan wrote: Documentation on how to run Linux on the amigaone, pegasos2 and sam460ex machines is currently burried in the depths of the qemu-devel s/burried/buried/ mailing list and in the source code. Let's collect the information in the QEMU handbook for a

[PATCH v2] hw/hppa/Kconfig: Fix building with "configure --without-default-devices"

d: subcommand failed. make: *** [Makefile:162: run-ninja] Error 1 And after fixing this, the qemu-system-hppa binary refuses to run due to the missing 'pci-ohci' and 'pci-serial' devices. Let's add the right config switches to fix these problems. Signed-off-by: Thomas Huth --- v2: Keep &qu

<    4   5   6   7   8   9   10   11   12   13   >