h
Message-ID: <20240206002344.12372-4-...@linux.ibm.com>
Signed-off-by: Thomas Huth
---
tests/unit/test-util-filemonitor.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/unit/test-util-filemonitor.c
b/tests/unit/test-util-filemonitor.c
index a22de27595..02e67fc96a 100644
--- a/t
S query. Disable DNS queries in the server
config.
Reviewed-by: Thomas Huth
Signed-off-by: Ilya Leoshkevich
Message-ID: <20240206002344.12372-2-...@linux.ibm.com>
Signed-off-by: Thomas Huth
---
tests/vm/basevm.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/vm/basevm.py b/tes
.
This bug was seen on HP-UX 10.20 which seems to trigger SCRIPTS
loops.
Fixes: b987718bbb ("hw/scsi/lsi53c895a: Fix reentrancy issues in the LSI
controller (CVE-2023-0330)")
Signed-off-by: Sven Schnelle
Message-ID: <20240128202214.2644768-1-sv...@stackframe.org>
Reviewed-by: Tho
On 06/02/2024 03.29, maobibo wrote:
Hi Philippe,
On 2024/2/5 下午8:58, Philippe Mathieu-Daudé wrote:
Hi Bibo,
On 5/2/24 03:13, Bibo Mao wrote:
The cdrom test skips to execute on LoongArch system with command
"make check", this patch enables cdrom test for LoongArch virt
machine platform.
With
ions(-)
Reviewed-by: Thomas Huth
/helper.h| 2 +
target/s390x/tcg/insn-data.h.inc | 4 ++
target/s390x/tcg/int_helper.c| 76
target/s390x/tcg/translate.c | 16 +++
4 files changed, 98 insertions(+)
Reviewed-by: Thomas Huth
| 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Thomas Huth
On 02/02/2024 15.11, Ilya Leoshkevich wrote:
Convert to Binary - counterparts of the already implemented Convert
to Decimal (CVD*) instructions.
Example from the Principles of Operation: 25594C becomes 63FA.
Co-developed-by: Pavel Zbitskiy
Signed-off-by: Ilya Leoshkevich
---
changed, 103 insertions(+)
create mode 100644 tests/tcg/s390x/cvb.c
Reviewed-by: Thomas Huth
Tested-by: Thomas Huth
100644 tests/tcg/s390x/cvd.c
Thanks for adding CVDY here, too!
Reviewed-by: Thomas Huth
On 05/02/2024 07.56, Thomas Huth wrote:
On 02/02/2024 16.40, Peter Maydell wrote:
On Fri, 2 Feb 2024 at 15:36, David Woodhouse wrote:
On Fri, 2024-02-02 at 15:32 +, Peter Maydell wrote:
This fails "make check' because some of the qom-test and
test-hmp checks fail when the QEMU b
garch64")) {
+const char *virtmachine[] = { "virt", NULL };
+add_cdrom_param_tests(virtmachine);
} else {
const char *nonemachine[] = { "none", NULL };
add_cdrom_param_tests(nonemachine);
Anyway, using the virt machine is certainly better than the "none" machine, so:
Acked-by: Thomas Huth
On 02/02/2024 16.40, Peter Maydell wrote:
On Fri, 2 Feb 2024 at 15:36, David Woodhouse wrote:
On Fri, 2024-02-02 at 15:32 +, Peter Maydell wrote:
This fails "make check' because some of the qom-test and
test-hmp checks fail when the QEMU binary segfaults.
On 01/02/2024 13.54, BALATON Zoltan wrote:
On Thu, 1 Feb 2024, Thomas Huth wrote:
On 01/02/2024 13.39, BALATON Zoltan wrote:
On Thu, 1 Feb 2024, Thomas Huth wrote:
For distros like downstream RHEL, it would be helpful to allow to disable
the CompactFlash device. For making this possible, we
On 01/02/2024 15.19, Peter Maydell wrote:
On Mon, 29 Jan 2024 at 08:18, Thomas Huth wrote:
If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged
helper functions that require additional functions for linking. The
reduced set of the linux-user functions works fine as stubs
On 01/02/2024 15.17, Peter Maydell wrote:
On Mon, 29 Jan 2024 at 08:18, Thomas Huth wrote:
Move the code to a separate file so that we do not have to compile
it anymore if CONFIG_ARM_V7M is not set.
Signed-off-by: Thomas Huth
---
target/arm/tcg/cpu-v7m.c | 290
-by: Alex Bennée
---
include/hw/elf_ops.h | 75 +---
1 file changed, 36 insertions(+), 39 deletions(-)
Reviewed-by: Thomas Huth
On 01/02/2024 13.39, BALATON Zoltan wrote:
On Thu, 1 Feb 2024, Thomas Huth wrote:
For distros like downstream RHEL, it would be helpful to allow to disable
the CompactFlash device. For making this possible, we need a separate
Kconfig switch for this device, and the code should reside
it harder to run the
+``check-tcg`` tests. Unless we can improve the testing situation there
+is a chance the code will bitrot without anyone noticing.
With the typos fixed:
Reviewed-by: Thomas Huth
config | 1 +
11 files changed, 6 insertions(+), 13 deletions(-)
Reviewed-by: Thomas Huth
On 31/01/2024 15.18, David Woodhouse wrote:
On Wed, 2024-01-31 at 13:18 +0100, Thomas Huth wrote:
@@ -386,14 +382,21 @@ static void q800_machine_init(MachineState
*machine)
* 08:00:07 Apple
* (Q800 use the last one)
*/
- nd_table[0].macaddr.a[0] = 0x08
On 26/01/2024 18.25, David Woodhouse wrote:
From: David Woodhouse
When converting to the shiny build-system-du-jour, a typo prevented the
last_i82596 driver from being built. Correct the config option name to
re-enable the build. And include "sysemu/sysemu.h" so it actually builds.
Fixes:
dc->realize;
-dc->realize = via_superio_realize;
+device_class_set_parent_realize(dc, via_superio_realize,
+>parent_realize);
}
static const TypeInfo via_superio_info = {
Reviewed-by: Thomas Huth
sc->parallel = (ISASuperIOFuncs){
Reviewed-by: Thomas Huth
e);
dc->vmsd = _s390_flic_vmstate;
dc->reset = kvm_s390_flic_reset;
fsc->register_io_adapter = kvm_s390_register_io_adapter;
Reviewed-by: Thomas Huth
ULL,
>parent_phases);
-c->parent_realize = dc->realize;
-dc->realize = smmu_realize;
+device_class_set_parent_realize(dc, smmu_realize,
+>parent_realize);
device_class_set_props(dc, smmuv3_properties);
}
Reviewed-by: Thomas Huth
For distros like downstream RHEL, it would be helpful to allow to disable
the CompactFlash device. For making this possible, we need a separate
Kconfig switch for this device, and the code should reside in a separate
file.
Signed-off-by: Thomas Huth
---
hw/ide/qdev-ide.h | 41
On 01/02/2024 00.07, Ilya Leoshkevich wrote:
Check the CVB's and CVBG's corner cases.
Co-developed-by: Pavel Zbitskiy
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.target | 1 +
tests/tcg/s390x/cvb.c | 47 +
2 files changed, 48
On 01/02/2024 00.07, Ilya Leoshkevich wrote:
From: Pavel Zbitskiy
Convert to Binary - counterparts of the already implemented Convert
to Decimal (CVD*) instructions.
Example from the Principles of Operation: 25594C becomes 63FA.
[iii: Use separate functions for CVB and CVBG for simplicity].
cvbg(0x1d) == -1);
+assert(cvbg(m | 0xc) == 0x7fff);
+assert(cvbg(m | 0xd) == -0x7fff);
+
+return EXIT_SUCCESS;
+}
Reviewed-by: Thomas Huth
ert(cvd(-1) == 0x1d);
+assert(cvd(0x7fff) == 0x2147483647c);
+assert(cvd(-0x7fff) == 0x2147483647d);
+
+assert(cvdg(0) == 0xc);
+assert(cvdg(1) == 0x1c);
+assert(cvdg(-1) == 0x1d);
+assert(cvdg(0x7fff) == (m | 0xc));
+assert(cvdg(-0x7fff) =
On 25/01/2024 18.32, Peter Maydell wrote:
For a while now I've had an on-and-off-again campaign to get rid of
the handful of uses of C variable-length-array syntax in our
codebase. The rationale for this is that if the array size can be
controlled by the guest and we don't get the size limit
=no in the sshd configuration
tests/vm/freebsd: Reload the sshd configuration
meson: Disable CONFIG_NOTIFY1 on FreeBSD
meson.build| 1 +
tests/vm/basevm.py | 2 ++
tests/vm/freebsd | 2 ++
3 files changed, 5 insertions(+)
Tested-by: Thomas Huth
I can take the patches through
ompt)
+self.console_send("echo 'UseDNS no' >> /etc/ssh/sshd_config\n")
for var in self.envvars:
self.console_wait(prompt)
self.console_send("echo 'AcceptEnv %s' >> /etc/ssh/sshd_config\n"
% var)
Reviewed-by: Thomas Huth
host_os != 'freebsd' and
cc.has_header_symbol('sys/inotify.h', 'inotify_init1'))
config_host_data.set('CONFIG_PRCTL_PR_SET_TIMERSLACK',
cc.has_header_symbol('sys/prctl.h', 'PR_SET_TIMERSLACK'))
Reviewed-by: Thomas Huth
On 25/01/2024 20.48, Ilya Leoshkevich wrote:
After console_sshd_config(), the SSH server needs to be nudged to pick
up the new configs. The scripts for the other BSD flavors already do
this with a reboot, but a simple reload is sufficient.
Signed-off-by: Ilya Leoshkevich
---
tests/vm/freebsd
On 26/01/2024 18.25, David Woodhouse wrote:
From: David Woodhouse
If a corresponding NIC configuration was found, it will have a MAC address
already assigned, so use that. Else, generate and assign a default one.
Using qemu_find_nic_info() is simpler than the alternative of using
p_set_macaddr(enet, "mac", mac.a);
+}
+
sysbus_realize_and_unref(SYS_BUS_DEVICE(enet), _fatal);
sysbus_mmio_map(SYS_BUS_DEVICE(enet), 0, 0x40048000);
sysbus_connect_irq(SYS_BUS_DEVICE(enet), 0, qdev_get_gpio_in(nvic,
42));
Reviewed-by: Thomas Huth
' instead.
Signed-off-by: David Woodhouse
---
include/net/net.h | 3 ---
net/net.c | 39 ++-
2 files changed, 6 insertions(+), 36 deletions(-)
Reviewed-by: Thomas Huth
machine->ram_size, _size);
-nvram_init(nvram, (uint8_t *)>macaddr, machine->kernel_cmdline,
+nvram_init(nvram, hostid.a, machine->kernel_cmdline,
machine->boot_config.order, machine->ram_size, kernel_size,
graphic_width, graphic_height, graphic_depth,
hwdef->nvram_machine_id, "Sun4m");
Reviewed-by: Thomas Huth
im_memmap[OR1KSIM_ETHOC].size,
+ smp_cpus, cpus,
+ OR1KSIM_ETHOC_IRQ);
if (smp_cpus > 1) {
openrisc_sim_ompic_init(state, or1ksim_memmap[OR1KSIM_OMPIC].base,
Reviewed-by: Thomas Huth
_LASI_82596', if_true: files('lasi_i82596.c'))
system_ss.add(when: 'CONFIG_I82596_COMMON', if_true: files('i82596.c'))
system_ss.add(when: 'CONFIG_SUNHME', if_true: files('sunhme.c'))
system_ss.add(when: 'CONFIG_FTGMAC100', if_true: files('ftgmac100.c'))
I'm surprised that it even did not bitrot much further!
Reviewed-by: Thomas Huth
On 26/01/2024 18.25, David Woodhouse wrote:
From: David Woodhouse
Signed-off-by: David Woodhouse
---
hw/mips/jazz.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
Reviewed-by: Thomas Huth
changed, 7 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
/xlnx-zynqmp.c | 8 +---
6 files changed, 10 insertions(+), 33 deletions(-)
Reviewed-by: Thomas Huth
end_printf(cmd_line, " -nic socket,fd=%d,model=emc%d ",
+ test_sockets[1], module_num);
g_test_queue_destroy(packet_test_clear, test_sockets);
return test_sockets;
I like the idea to use the alias to configure a certain on-board NIC :-)
Reviewed-by: Thomas Huth
---
hw/arm/kzm.c | 4 ++--
hw/arm/mps2.c| 2 +-
hw/arm/realview.c| 6 ++
hw/arm/vexpress.c| 4 ++--
hw/net/lan9118.c | 5 ++---
include/hw/net/lan9118.h | 2 +-
6 files changed, 10 insertions(+), 13 deletions(-)
Reviewed-by: Thomas Huth
/loongarch/virt.c| 2 +-
hw/ppc/spapr.c | 5 ++---
hw/s390x/s390-virtio-ccw.c | 2 +-
6 files changed, 8 insertions(+), 9 deletions(-)
Reviewed-by: Thomas Huth
---
tests/qtest/meson.build | 3 +-
tests/qtest/stm32l4x5_rcc-test.c | 207 +++
2 files changed, 209 insertions(+), 1 deletion(-)
create mode 100644 tests/qtest/stm32l4x5_rcc-test.c
Acked-by: Thomas Huth
g_test_init(, , NULL);
qtest_add_func("/pvpanic/panic", test_panic);
qtest_add_func("/pvpanic/panic-nopause", test_panic_nopause);
+qtest_add_func("/pvpanic/pvshutdown", test_pvshutdown);
return g_test_run();
}
With PVPANIC_SHUTDOWN instead of 4:
Reviewed-by: Thomas Huth
tops.h"
#include "qemu/error-report.h"
@@ -21,6 +22,9 @@
#include "qemu/rcu_queue.h"
#include "hw/hyperv/hyperv.h"
#include "qom/object.h"
+#include "target/i386/kvm/hyperv-proto.h"
+#include "target/i386/cpu.h"
+#include "exec/cpu-all.h"
struct SynICState {
DeviceState parent_obj;
Reviewed-by: Thomas Huth
ot;sysemu/kvm.h"
#include "sysemu/reset.h"
+#include "target/ppc/cpu.h"
void icp_pic_print_info(ICPState *icp, Monitor *mon)
{
Reviewed-by: Thomas Huth
quot;; then
- symlink "$source_path/linux-headers/asm-$linux_arch" linux-headers/asm
-fi
-
if test "$default_targets" = "yes"; then
echo "CONFIG_DEFAULT_TARGETS=y" >> $config_host_mak
fi
Reviewed-by: Thomas Huth
target | cut -d '-' -f 1)$EXESUF
-case $target in
-*-user) symlink "../qemu-$target_name" "$target_dir/qemu-$target_name"
;;
-*) symlink "../qemu-system-$target_name"
"$target_dir/qemu-system-$target_name" ;;
-esac
-done
-
Anyway,
Reviewed-by: Thomas Huth
If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged
helper functions that require additional functions for linking. The
reduced set of the linux-user functions works fine as stubs in this
case, so change the #ifdef statement accordingly.
Signed-off-by: Thomas Huth
---
target
Move the code to a separate file so that we do not have to compile
it anymore if CONFIG_ARM_V7M is not set.
Signed-off-by: Thomas Huth
---
target/arm/tcg/cpu-v7m.c | 290 +
target/arm/tcg/cpu32.c | 261 -
target/arm
onfig file.
v2:
- Updated a comment
- Avoid #ifdef in cpu-v7m.c, handle it via meson.build instead
Thomas Huth (3):
target/arm: Move v7m-related code from cpu32.c into a separate file
target/arm/tcg/m_helper.c: Include the full helpers only with
CONFIG_ARM_V7M
target/arm/Kconfig: Stop
Now that we made sure that ARM_V7M code only gets compiled if really
needed, we can drop the hard requirement for CONFIG_ARM_V7M in the
Kconfig file.
Tested-by: Fabiano Rosas
Signed-off-by: Thomas Huth
---
target/arm/Kconfig | 4
1 file changed, 4 deletions(-)
diff --git a/target/arm
++
target/s390x/helper.c | 3 +--
target/s390x/kvm/kvm.c | 6 ++
target/s390x/tcg/excp_helper.c | 11 +++
target/s390x/tcg/translate.c | 3 +--
6 files changed, 10 insertions(+), 22 deletions(-)
Reviewed-by: Thomas Huth
| 6 ++
target/m68k/helper.c| 3 +--
target/m68k/m68k-semi.c | 6 ++
target/m68k/op_helper.c | 11 +++
target/m68k/translate.c | 3 +--
6 files changed, 19 insertions(+), 40 deletions(-)
Reviewed-by: Thomas Huth
vel--;
return;
}
insn = read_dword(s, s->dsp);
Reviewed-by: Thomas Huth
On 25/01/2024 17.56, Philippe Mathieu-Daudé wrote:
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/hvf/vmx.h | 9 +++
hw/i386/vmmouse.c
On 26/01/2024 11.44, Philippe Mathieu-Daudé wrote:
Hi Thomas,
On 26/1/24 09:39, Thomas Huth wrote:
Move the code to a separate file so that we do not have to compile
it anymore if CONFIG_ARM_V7M is not set.
Signed-off-by: Thomas Huth
---
target/arm/tcg/cpu-v7m.c | 292
On 25/01/2024 01.38, Jason Wang wrote:
On Wed, Jan 24, 2024 at 9:14 PM David Woodhouse wrote:
Hi Jason,
I think this series probably lives or dies with you. I think it's a
worthwhile cleanup, but I no longer have an immediate need for it; I
shipped a slightly ugly workaround in QEMU 8.2.
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
These old functions can be removed now too. Let net_param_nic() print
the full set of network devices directly, and also make it note that a
list more specific to this platform/config will be available by using
'-nic model=help'
IVE_ENDIAN);
Reviewed-by: Thomas Huth
qdev_set_nic_properties(DEVICE(>gem), nd);
-}
+qemu_configure_nic_device(DEVICE(>gem), true, NULL);
object_property_set_int(OBJECT(>gem), "revision", GEM_REVISION,
_abort);
if (!sysbus_realize(SYS_BUS_DEVICE(>gem), errp)) {
Reviewed-by: Thomas Huth
im_memmap[OR1KSIM_ETHOC].size,
+ smp_cpus, cpus,
+ OR1KSIM_ETHOC_IRQ);
if (smp_cpus > 1) {
openrisc_sim_ompic_init(state, or1ksim_memmap[OR1KSIM_OMPIC].base,
Reviewed-by: Thomas Huth
prefix */
Reviewed-by: Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
Extract the MAC address from the NICInfo, or generate one explicitly if
there was no corresponding NIC configuration, to put it in the PROM.
Uh, I don't see any MAC handling in the patch below? Is this the right
comment for
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1225187
Title:
qemu hangs in windows 7 host with -serial pipe:windbg
Status in QEMU:
Invalid
Bug
uot;qapi/error.h"
-DeviceState *etraxfs_eth_init(NICInfo *nd, hwaddr base, int phyaddr,
+DeviceState *etraxfs_eth_init(hwaddr base, int phyaddr,
struct etraxfs_dma_client *dma_out,
struct etraxfs_dma_client *dma_in);
Reviewed-by: Thomas Huth
MIPS CPU INT0, which is interrupt 2. */
-mipsnet_init(0x4200, env->irq[2], _table[0]);
+/* MIPSnet uses the MIPS CPU INT0, which is interrupt 2. */
+mipsnet_init(0x4200, env->irq[2]);
}
static void mips_mipssim_machine_init(MachineClass *mc)
Reviewed-by: Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
Please add: "Also remove the leftover definition of host_net_devices which
has been forgotten to be removed in commit 7cc28cb061040cb089." (or so)
With that:
Reviewed-by: Thomas Huth
Signed-off-by: David
-by: Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote:
From: David Woodhouse
Please add a short patch description à la "All callers have been converted
in the previous patches, so this is not required anymore".
With that:
Reviewed-by: Thomas Huth
Signed-off-by: David Woodhouse
---
i
qdev_prop_set_uint32(dev, "tx-ping-pong", 0);
qdev_prop_set_uint32(dev, "rx-ping-pong", 0);
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), _fatal);
Reviewed-by: Thomas Huth
ort("Too many NICs");
-exit(1);
-}
I wonder whether we'd need a different mechanism to specify the maximum
amount of on-board NICs now... Anyway, we can also think of that later, so:
Reviewed-by: Thomas Huth
;);
-qdev_set_nic_properties(dev, _table[1]);
+dev = qemu_create_nic_device("xgmac", true, NULL);
+if (dev) {
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), _fatal);
sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, 0xfff51000);
sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, pic[80]);
Reviewed-by: Thomas Huth
LUE_H
#define HW_Q800_GLUE_H
-#include "qemu/osdep.h"
#include "hw/sysbus.h"
#define TYPE_GLUE "q800-glue"
Reviewed-by: Thomas Huth
ics; i++) {
-if (!enable_lasi_lan()) {
-pci_nic_init_nofail(_table[i], pci_bus, mc->default_nic, NULL);
-}
+if (!enable_lasi_lan()) {
+pci_init_nic_devices(pci_bus, mc->default_nic);
}
/* BMC board: HP Powerbar SP2 Diva (with console only) */
Reviewed-by: Thomas Huth
mc->default_nic, NULL);
-}
+pci_init_nic_devices(pci->bus, mc->default_nic);
}
nodename = vms->pciehb_nodename = g_strdup_printf("/pcie@%" PRIx64, base);
Reviewed-by: Thomas Huth
, NULL);
-}
+pci_init_nic_devices(pci_bus, mc->default_nic);
/* Super I/O */
isa_create_simple(isa_bus, TYPE_SMC37C669_SUPERIO);
Reviewed-by: Thomas Huth
es(dev, nd);
+qemu_configure_nic_device(dev, true, NULL);
Wouldn't it be possible to use qemu_create_nic_device() here, too?
Anyway:
Reviewed-by: Thomas Huth
s = SYS_BUS_DEVICE(dev);
sysbus_realize_and_unref(s, _fatal);
sysbus_mmio_map(s, 0, base);
eth[i]), "tx-ring-num",
FSL_IMX7_ETH_NUM_TX_RINGS, _abort);
-qdev_set_nic_properties(DEVICE(>eth[i]), _table[i]);
+qemu_configure_nic_device(DEVICE(>eth[i]), true, NULL);
sysbus_realize(SYS_BUS_DEVICE(>eth[i]), _abort);
_and_unref(s, _fatal);
Reviewed-by: Thomas Huth
0_GIC_SPI_GMAC));
/* EMAC */
+qemu_configure_nic_device(DEVICE(>emac), true, "emac");
sysbus_realize(SYS_BUS_DEVICE(>emac), _fatal);
sysbus_mmio_map(SYS_BUS_DEVICE(>emac), 0, s->memmap[AW_R40_DEV_EMAC]);
sysbus_connect_irq(SYS_BUS_DEVICE(>emac), 0,
Reviewed-by: Thomas Huth
lt_nic, NULL);
-}
+pci_init_nic_devices(pci->bus, mc->default_nic);
}
}
Reviewed-by: Thomas Huth
want more).
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
---
include/net/net.h | 3 +++
net/net.c | 53 +++
2 files changed, 56 insertions(+)
Reviewed-by: Thomas Huth
On 26/01/2024 15.34, David Woodhouse wrote:
On Fri, 2024-01-26 at 15:24 +0100, Thomas Huth wrote:
On 26/01/2024 15.16, David Woodhouse wrote:
On Fri, 2024-01-26 at 12:10 +0100, Thomas Huth wrote:
+/* "Please create a device, if you have a configuration for it" */
+D
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
By noting the models for which a configuration was requested, we can give
the user an accurate list of which NIC models were actually available on
the platform/configuration that was otherwise chosen.
Signed-off-by: David
On 26/01/2024 15.16, David Woodhouse wrote:
On Fri, 2024-01-26 at 12:10 +0100, Thomas Huth wrote:
+/* "Please create a device, if you have a configuration for it" */
+DeviceState *qemu_create_nic_device(const char *typename, bool match_default,
+
CAddr));
+onboard_nic = true;
}
+pci_init_nic_devices(pci_busB, mc->default_nic);
/* If we don't have an onboard NIC, grab a default MAC address so that
* we have a valid machine id */
Reviewed-by: Thomas Huth
ault_nic);
}
/* Load kernel. */
Reviewed-by: Thomas Huth
", true, "ibmveth"))) {
+spapr_vlan_create(spapr->vio_bus, nd);
}
+pci_init_nic_devices(phb->bus, NULL);
+
for (i = 0; i <= drive_get_max_bus(IF_SCSI); i++) {
spapr_vscsi_create(spapr->vio_bus);
}
Reviewed-by: Thomas Huth
ices(pci_bus, mc->default_nic);
}
/* Prepare firmware configuration for OpenBIOS */
Fine for me ... Hervé, could you maybe comment from a 40p point of view, too?
Reviewed-by: Thomas Huth
fail(_table[i], pci_bus, mc->default_nic, NULL);
-}
+pci_init_nic_devices(pci_bus, mc->default_nic);
}
static void mips_loongson3_virt_init(MachineState *machine)
Reviewed-by: Thomas Huth
nd, pci_bus, "pcnet", default_devaddr);
-}
+/* The malta board has a PCNet card using PCI SLOT 11 */
+pci_init_nic_in_slot(pci_bus, "pcnet", NULL, "0b");
+ pci_init_nic_devices(pci_bus, "pcnet");
}
Reviewed-by: Thomas Huth
Philippe, could you maybe have a look at this, too?
and the rest
will be dynamically assigned.
Sounds fine for me ... Philippe, what do you think?
Reviewed-by: Thomas Huth
Signed-off-by: David Woodhouse
---
hw/mips/fuloong2e.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/hw/mips/fuloong2e.c b/hw/mips
On 26/01/2024 12.25, David Woodhouse wrote:
On Fri, 2024-01-26 at 12:20 +0100, Thomas Huth wrote:
On 26/01/2024 12.13, David Woodhouse wrote:
On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote:
On 08/01/2024 21.26, David Woodhouse wrote:
From: David Woodhouse
Eliminate direct access
901 - 1000 of 17968 matches
Mail list logo
