Sent: wtorek, 30 maja 2023 04:49
To: Tomasz Dzieciol ; qemu-devel@nongnu.org
Cc: sriram.yagnara...@est.tech; jasow...@redhat.com; k.kwiec...@samsung.com;
m.socha...@samsung.com
Subject: Re: [PATCH v10 0/7] igb: packet-split descriptors support
On 2023/05/29 23:01, Tomasz Dzieciol wrote:
> Purposes
Purposes of this series of patches:
* introduce packet-split RX descriptors support. This feature is used by Linux
VF driver for MTU values from 2048.
* refactor RX descriptor handling for introduction of packet-split RX
descriptors support
* fix descriptors flags handling
Tomasz Dzieciol (7
TCP ACK detection is no longer present in igb.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index d00b1caa6a..e927c51061 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1327,11
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 348 ++--
hw/net/igb_regs.h | 9 ++
hw/net/trace-events | 2 +-
3 files changed, 316 insertions(+), 43 deletions
Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 34 +-
hw/net/igb_core.c| 42 +-
2 files changed, 38 insertions(+), 38 deletions
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 170 +++-
hw/net/igb_regs.h | 10 +--
hw/net/trace-events | 4 +-
3
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 18 ++--
hw/net/igb_core.c| 213 +--
tests/qtest/libqos/igb.c | 5
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 4 +++-
hw/net/igb_regs.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 8c248683c3..b54d7af8d8 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1420,7 +1420,9
Rename e1000e_ba_state according and e1000e_write_hdr_to_rx_buffers for
consistency with IGB.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 170 +++-
hw/net/igb_regs.h | 10 +--
hw/net/trace-events | 4 +-
3
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 4 +++-
hw/net/igb_regs.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 8e32f39ece..2bfae517fc 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1420,7 +1420,9
Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 34 +-
hw/net/igb_core.c| 42 +-
2 files changed, 38 insertions(+), 38 deletions
TCP ACK detection is no longer present in igb.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index d00b1caa6a..e927c51061 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1327,11
tor handling for introduction of packet-split RX
descriptors support
* fix descriptors flags handling
In addition to comments from previous review endianess issues in
igb_write_adv_ps_rx_descr were fixed.
Tomasz Dzieciol (7):
igb: remove TCP ACK detection
igb: rename E1000E_RingInfo_st
igb: RX d
Rename e1000e_ba_state according and e1000e_write_hdr_to_rx_buffers for
consistency with IGB.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 357 ++--
hw/net/igb_regs.h | 9 ++
hw/net/trace-events | 2 +-
3 files changed, 325 insertions(+), 43 deletions
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 18 ++--
hw/net/igb_core.c| 214 +--
tests/qtest/libqos/igb.c | 5
Rename e1000e_ba_state according and e1000e_write_hdr_to_rx_buffers for
consistency with IGB.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 18 ++--
hw/net/igb_core.c| 214 +--
tests/qtest/libqos/igb.c | 5
tor handling for introduction of packet-split RX
descriptors support
* fix descriptors flags handling
Tomasz Dzieciol (7):
igb: remove TCP ACK detection
igb: rename E1000E_RingInfo_st
igb: RX descriptors guest writting refactoring
igb: RX payload guest writting refactoring
igb: add IPv6 extended
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 355 ++--
hw/net/igb_regs.h | 9 ++
hw/net/trace-events | 2 +-
3 files changed, 323 insertions(+), 43 deletions
Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 34 +-
hw/net/igb_core.c| 42 +-
2 files changed, 38 insertions(+), 38 deletions
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 178 +++-
hw/net/igb_regs.h | 10 +--
hw/net/trace-events | 6 +-
3
TCP ACK detection is no longer present in igb.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 96b7335b31..012eb1e1b9 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1327,11
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 4 +++-
hw/net/igb_regs.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 7a4a01c4a1..c9aa3dcfa8 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1415,7 +1415,9
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 4 +++-
hw/net/igb_regs.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 605ea09e41..442ad55cc0 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1415,7 +1415,9
Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 34 +-
hw/net/igb_core.c| 42 +-
2 files changed, 38 insertions(+), 38 deletions
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 355 ++--
hw/net/igb_regs.h | 9 ++
hw/net/trace-events | 2 +-
3 files changed, 323 insertions(+), 43 deletions
TCP ACK detection is no longer present in igb.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 96b7335b31..012eb1e1b9 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1327,11
tor handling for introduction of packet-split RX
descriptors support
* fix descriptors flags handling
Tomasz Dzieciol (7):
igb: remove TCP ACK detection
igb: rename E1000E_RingInfo_st
igb: RX descriptors guest writting refactoring
igb: RX payload guest writting refactoring
igb: add IPv6 extended
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 18 ++--
hw/net/igb_core.c| 214 +--
tests/qtest/libqos/igb.c | 5
Rename e1000e_ba_state according and e1000e_write_hdr_to_rx_buffers for
consistency with IGB.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 176 ++--
hw/net/igb_regs.h | 10 +--
hw/net/trace-events | 6 +-
3
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 18 ++--
hw/net/igb_core.c| 216 +--
tests/qtest/libqos/igb.c | 5
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 360 ++--
hw/net/igb_regs.h | 9 ++
hw/net/trace-events | 2 +-
3 files changed, 328 insertions(+), 43 deletions
tor handling for introduction of packet-split RX
descriptors support
* fix descriptors flags handling
Tomasz Dzieciol (7):
igb: remove TCP ACK detection
igb: rename E1000E_RingInfo_st
igb: RX descriptors guest writting refactoring
igb: RX payload guest writting refactoring
igb: add IPv6 extended
Rename e1000e_ba_state according to qemu typdefs guide.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index f9ff31fd70..be0cf2f941 100644
--- a/hw/net
TCP ACK detection is no longer present in igb.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 96b7335b31..012eb1e1b9 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1327,11
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 176 ++--
hw/net/igb_regs.h | 10 +--
hw/net/trace-events | 6 +-
3
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 4 +++-
hw/net/igb_regs.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 0eabe7106e..6d95cccea3 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1415,7 +1415,9
Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 34 +-
hw/net/igb_core.c| 42 +-
2 files changed, 38 insertions(+), 38 deletions
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 176 ++--
hw/net/igb_regs.h | 10 +--
hw/net/trace-events | 6 +-
3
Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 34 +-
hw/net/igb_core.c| 42 +-
2 files changed, 38 insertions(+), 38 deletions
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 18 ++--
hw/net/igb_core.c| 216 +--
tests/qtest/libqos/igb.c | 5
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 10 +-
hw/net/igb_core.c| 403 ++-
hw/net/igb_regs.h| 7 +
hw/net/trace-events | 2 +-
4 files changed
tor handling for introduction of packet-split RX
descriptors support
* fix descriptors flags handling
Tomasz Dzieciol (6):
igb: remove TCP ACK detection
igb: rename E1000E_RingInfo_st
igb: RX descriptors guest writting refactoring
igb: RX payload guest writting refactoring
igb: add IPv6 extended
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 4 +++-
hw/net/igb_regs.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 0eabe7106e..6d95cccea3 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1415,7 +1415,9
TCP ACK detection is no longer present in igb.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 96b7335b31..012eb1e1b9 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1327,11
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index dbd09b9b46..8c0291665f 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1400,7 +1400,9 @@ igb_rx_desc_get_packet_type
Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 42 +-
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 368 ++--
hw/net/igb_regs.h | 8 +
hw/net/trace-events | 2 +-
3 files changed, 332 insertions(+), 46 deletions
TCP ACK detection is no longer present in igb.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 96b7335b31..012eb1e1b9 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1327,11
tor handling for introduction of packet-split RX
descriptors support
* fix descriptors flags handling
Tomasz Dzieciol (5):
igb: remove TCP ACK detection
igb: rename E1000E_RingInfo_st
igb: RX descriptors handling cleanup
igb: add IPv6 extended headers traffic detection
igb: packet-split descript
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 18 +-
hw/net/igb_core.c| 410 ++-
hw/net/igb_regs.h| 12
I will remove checking RXCSUM.IPPCSE flag then.
-Original Message-
From: Akihiko Odaki
Sent: środa, 3 maja 2023 17:11
To: Sriram Yagnaraman ; Tomasz Dzieciol/VIM
Integration (NC) /SRPOL/Engineer/Samsung Electronics
; qemu-devel@nongnu.org
Cc: jasow...@redhat.com; k.kwiec
Yagnaraman
Sent: niedziela, 30 kwietnia 2023 13:57
To: Tomasz Dzieciol ; qemu-devel@nongnu.org;
akihiko.od...@daynix.com
Cc: jasow...@redhat.com; k.kwiec...@samsung.com; m.socha...@samsung.com
Subject: RE: [PATCH v3 1/2] igb: RX descriptors handling cleanup
> -Original Message-
> From:
nu.org
On Behalf Of
Akihiko Odaki
Sent: piątek, 28 kwietnia 2023 12:31
To: Tomasz Dzieciol ; qemu-devel@nongnu.org
Cc: sriram.yagnara...@est.tech; jasow...@redhat.com; k.kwiec...@samsung.com;
m.socha...@samsung.com
Subject: Re: [PATCH v3 1/2] igb: RX descriptors handling cleanup
On 2023/04/2
not always use the suffixes.
> - use _.
ok, I was looking at E1000E_RingInfo_st, which was added recently with IGB code
in commit 3a977deebe6b9a10043182e922f6883924ef21f5 ("Intrdocue igb device
emulation").
-Original Message-
From: Akihiko Odaki
Sent: piątek, 28 kwi
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
---
hw/net/igb_core.c | 300 +-
hw/net/igb_regs.h | 6 +
2 files changed, 276 insertions(+), 30 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 1cb6440
set (in
addition to RXCSUM.PCSD bit cleared condition)
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 18 +-
hw/net/e1000x_regs.h | 1 +
hw/net
cleanup. Second patch introduces feature itself.
Tomasz Dzieciol (2):
igb: RX descriptors handling cleanup
igb: packet-split descriptors support
hw/net/e1000e_core.c | 18 +-
hw/net/e1000x_regs.h | 1 +
hw/net/igb_core.c| 728 ---
h
On Thu, Apr 27, 2023 at 04:24:10PM +0900, Akihiko Odaki wrote:
> On 2023/04/27 1:09, Tomasz Dzieciol wrote:
> > Format of Intel 82576 was changed in comparison to Intel 82574 extended
> > descriptors. This change updates filling of advanced descriptors fields
> > accordingly:
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
---
hw/net/igb_core.c | 236 +-
1 file changed, 231 insertions(+), 5 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 47c4a16e84..de54ddb5fe 100644
--- a/
set (in
addition to RXCSUM.PCSD bit cleared condition)
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 16 +-
hw/net/e1000x_regs.h | 1 +
hw/net
series to be merged first as it includes several bug fixes.
>
ok. I will rebase my changes.
On Thu, Apr 20, 2023 at 06:12:08PM +0900, Akihiko Odaki wrote:
> On 2023/04/17 18:51, Tomasz Dzieciol wrote:
> > Packet-split d
Packet-split descriptors are used by Linux VF driver for MTU values from 2048
upwards.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000x_regs.h | 1 +
hw/net/igb_core.c | 701 ++---
hw/net/igb_regs.h | 18 ++
hw/net/trace-events| 4
Use proper PCI device for net_tx_pkt provided to
net_tx_pkt_add_raw_fragment.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb.c | 8
hw/net/igb_core.c | 47 +--
hw/net/igb_core.h | 3 +++
3 files changed, 52 insertions(+), 6 deletions
Use TX SCTP checksumming offload as supported by IGB devices.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index e1b99f312b..8cc8682c66 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
Modern NICs are able to offload SCTP checksumming. SCTP calculates
checksums differently than TCP / UDP: no pseudo-header and CRC32C
algorithm are used.
Signed-off-by: Tomasz Dzieciol
---
hw/net/net_tx_pkt.c| 22 ++
hw/net/net_tx_pkt.h| 8
include/net
69 matches
Mail list logo