On 2022-10-11 12:34:56 +0200, Paolo Bonzini wrote:
> Queued, thanks.
Thank you!
Venu
>
> Paolo
>
On 2022-10-07 06:55:15 -0400, Paolo Bonzini wrote:
> Il gio 6 ott 2022, 15:25 Venu Busireddy ha
> scritto:
>
> > I do see that the Solaris driver does send the 0x1a command during
> > the initialization, perhaps (?) seeking the value of UA_INTLCK_CTRL.
> > Since QEMU
is depends on this sense data, and hence does not handle disk
hotplug/hotunplug events.
When the disk inventory changes, use the bus unit attention mechanism
to return a CHECK_CONDITION status with sense data of 0x06/0x3F/0x0E
(sense code REPORTED_LUNS_CHANGED).
Signed-off-by: Venu Busireddy
On 2022-10-05 23:37:33 +0200, Paolo Bonzini wrote:
> On 10/4/22 01:13, Venu Busireddy wrote:
> > > script? Something must be putting the SCSI command in the queue.
> > > Perhaps the driver is doing so when it sees an event? And if it is
> > > bypassing the normal su
On 2022-10-03 18:13:06 -0500, Venu Busireddy wrote:
> On 2022-09-30 18:25:48 +0200, Paolo Bonzini wrote:
> > On Fri, Sep 30, 2022 at 4:42 PM Venu Busireddy
> > wrote:
> > > > > Immediately after a hotunplug event, qemu (without any action from
> > > > &g
On 2022-09-30 18:25:48 +0200, Paolo Bonzini wrote:
> On Fri, Sep 30, 2022 at 4:42 PM Venu Busireddy
> wrote:
> > > > Immediately after a hotunplug event, qemu (without any action from
> > > > the guest) processes a REPORT_LUNS command on the lun 0 of the device
>
On 2022-09-30 10:41:03 +0200, Paolo Bonzini wrote:
> On Fri, Sep 30, 2022 at 12:31 AM Venu Busireddy
> wrote:
> > > >*/
> > > > !(buf[0] == REQUEST_SENSE && d->sense_is_ua))) {
> > > > ops = _unit_attention;
&
On 2022-09-29 12:49:51 +0200, Paolo Bonzini wrote:
> On Wed, Sep 28, 2022 at 8:06 PM Venu Busireddy
> wrote:
> >
> > Section 5.6.6.3 of VirtIO specification states, "Events will also
> > be reported via sense codes..." However, no sense data is sent whe
is depends on this sense data, and hence does not handle disk
hotplug/hotunplug events.
When disk inventory changes, return a CHECK_CONDITION status with sense
data of 0x06/0x3F/0x0E (sense code REPORTED_LUNS_CHANGED), as per the
specifications in Section 5.14 (h) of SAM-4.
Signed-off-by: Venu Busireddy
On 2022-09-21 16:33:35 +0200, Paolo Bonzini wrote:
> On Fri, Sep 16, 2022 at 3:44 AM Venu Busireddy
> wrote:
> > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> > index 41f2a5630173..69194c7ae23c 100644
> > --- a/hw/scsi/virtio-scsi.c
> > +++ b/hw/sc
EPORT_LUNS,
or REQUEST_SENSE is received.
Signed-off-by: Venu Busireddy
v1 -> v2:
- Send the sense data for VIRTIO_SCSI_EVT_RESET_REMOVED event too.
---
hw/scsi/virtio-scsi.c | 16 +++-
include/hw/virtio/virtio-scsi.h | 1 +
2 files changed, 16 insertions(+), 1 deletion(-)
di
Ping?
On 2022-05-31 15:22:37 -0500, Venu Busireddy wrote:
> When a disk is hotplugged, QEMU reports a VIRTIO_SCSI_EVT_RESET_RESCAN
> event, but does not send the "REPORTED LUNS CHANGED" sense data. This
> does not conform to Section 5.6.6.3 of the VirtIO specification, whi
Ping?
On 2022-05-31 15:22:37 -0500, Venu Busireddy wrote:
> When a disk is hotplugged, QEMU reports a VIRTIO_SCSI_EVT_RESET_RESCAN
> event, but does not send the "REPORTED LUNS CHANGED" sense data. This
> does not conform to Section 5.6.6.3 of the VirtIO specification, whi
r on
Solaris depends on this sense data, and hence does not recognize the
hotplugged disks (until a reboot).
As specified in SAM-4, Section 5.14, return a CHECK_CONDITION status with
a sense data of 0x06/0x3F/0x0E, whenever a command other than INQUIRY,
REPORT_LUNS, or REQUEST_SENSE is received.
On 2021-02-02 15:13:09 +1100, David Gibson wrote:
> The platform specific details of mechanisms for implementing
> confidential guest support may require setup at various points during
> initialization. Thus, it's not really feasible to have a single cgs
> initialization hook, but instead each
>
> Cc: Paolo Bonzini
> Cc: Richard Henderson
> Cc: Eduardo Habkost
> Reviewed-by: Dr. David Alan Gilbert
> Signed-off-by: Tom Lendacky
Reviewed-by: Venu Busireddy
> ---
> target/i386/sev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
initialization and
> ensuring that the guest CPU state is measured as part of the launch.
>
> Cc: Paolo Bonzini
> Cc: Richard Henderson
> Cc: Eduardo Habkost
> Reviewed-by: Dr. David Alan Gilbert
> Co-developed-by: Jiri Slaby
> Signed-off-by: Jiri Slaby
> Signed-off-by:
; Cc: David Hildenbrand
> Reviewed-by: Dr. David Alan Gilbert
> Signed-off-by: Tom Lendacky
Reviewed-by: Venu Busireddy
> ---
> accel/kvm/kvm-all.c | 5 +
> include/sysemu/cpus.h | 2 ++
> include/sysemu/hw_accel.h | 5 +
> include/sysemu/kvm.h | 1
: Paolo Bonzini
> Cc: Richard Henderson
> Cc: Eduardo Habkost
> Suggested-by: Sean Christopherson
> Signed-off-by: Tom Lendacky
Reviewed-by: Venu Busireddy
> ---
> target/i386/kvm/kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/targe
On 2021-01-26 11:36:46 -0600, Tom Lendacky wrote:
> From: Tom Lendacky
>
> When SEV-ES is enabled, it is not possible modify the guests register
> state after it has been initially created, encrypted and measured.
>
> Normally, an INIT-SIPI-SIPI request is used to boot the AP. However, the
>
bkost
> Reviewed-by: Dr. David Alan Gilbert
> Signed-off-by: Tom Lendacky
Reviewed-by: Venu Busireddy
> ---
> target/i386/sev.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index fce2128c07..ddec7ebaa7 1006
On 2019-07-10 20:23:03 +, Singh, Brijesh wrote:
> Signed-off-by: Brijesh Singh
> ---
> docs/amd-memory-encryption.txt | 42 +-
> 1 file changed, 41 insertions(+), 1 deletion(-)
>
> diff --git a/docs/amd-memory-encryption.txt b/docs/amd-memory-encryption.txt
>
to play with this with only qemu (w/o libvirt).
>
> Thank you very much!
>
> Dongli Zhang
>
> On 01/08/2019 06:29 AM, Venu Busireddy wrote:
> > From: Sridhar Samudrala
> >
> > This feature bit can be used by a hypervisor to indicate to the virtio_net
>
Add a query command to check the status of the FAILOVER_STANDBY_CHANGED
state of the virtio_net devices.
Signed-off-by: Venu Busireddy
---
hw/net/virtio-net.c| 16 +++
include/hw/virtio/virtio-net.h | 1 +
include/net/net.h | 2 ++
net/net.c
From: Si-Wei Liu
Signed-off-by: Si-Wei Liu
Signed-off-by: Venu Busireddy
---
hmp.c | 5 +
hw/pci/pci.c | 5 +
qapi/misc.json | 5 -
3 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index 7828f93..7a75c93 100644
--- a/hmp.c
+++ b/hmp.c
-by: Venu Busireddy
---
hw/vfio/pci.c | 57 +
qapi/net.json | 26 ++
2 files changed, 83 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index bd83b58..adcc95a 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
e vfio-pci devices. Only the vfio-pci devices that have this property
enabled are removed from the guest upon reboot.
Signed-off-by: Venu Busireddy
---
hw/acpi/pcihp.c | 27 +++
hw/net/virtio-net.c | 24
hw/vfio/pci.c| 3 +++
hw/
From: Sridhar Samudrala
This feature bit can be used by a hypervisor to indicate to the virtio_net
device that it can act as a standby for another device with the same MAC
address.
Signed-off-by: Sridhar Samudrala
Signed-off-by: Venu Busireddy
---
hw/net/virtio-net.c | 2 ++
1 file changed
VIRTIO_NET_F_STANDBY feature bit.
Venu Busireddy (2):
virtio_net: Add support for "Data Path Switching" during Live Migration.
virtio_net: Add a query command for FAILOVER_STANDBY_CHANGED event.
---
Changes in v3:
Fix issues with coding style in patch 3/5.
Changes in v2:
Added a que
On 2018-12-10 12:31:43 -0500, Michael S. Tsirkin wrote:
> On Mon, Dec 10, 2018 at 11:15:48AM -0500, Venu Busireddy wrote:
> > From: Si-Wei Liu
> >
> > When a VF is hotplugged into the guest, datapath switching will be
> > performed immediately, which is sub
Add a query command to check the status of the FAILOVER_STANDBY_CHANGED
state of the virtio_net devices.
Signed-off-by: Venu Busireddy
---
hw/net/virtio-net.c| 16
include/hw/virtio/virtio-net.h | 1 +
include/net/net.h | 2 ++
net/net.c
On 2018-12-10 13:28:42 -0600, Eric Blake wrote:
> On 12/10/18 10:15 AM, Venu Busireddy wrote:
> > Added two new events, FAILOVER_PLUG_PRIMARY and FAILOVER_UNPLUG_PRIMARY.
> > The first is emitted when the guest negotiates the F_STANDBY feature
> > bit. The second is emitte
From: Si-Wei Liu
Signed-off-by: Si-Wei Liu
Signed-off-by: Venu Busireddy
---
hmp.c | 5 +
hw/pci/pci.c | 5 +
qapi/misc.json | 5 -
3 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index 7828f93..7a75c93 100644
--- a/hmp.c
+++ b/hmp.c
From: Sridhar Samudrala
This feature bit can be used by a hypervisor to indicate to the virtio_net
device that it can act as a standby for another device with the same MAC
address.
Signed-off-by: Sridhar Samudrala
Signed-off-by: Venu Busireddy
---
hw/net/virtio-net.c | 2 ++
1 file changed
e vfio-pci devices. Only the vfio-pci devices that have this property
enabled are removed from the guest upon reboot.
Signed-off-by: Venu Busireddy
---
hw/acpi/pcihp.c | 27 +++
hw/net/virtio-net.c | 24
hw/vfio/pci.c| 3 +++
hw/
VIRTIO_NET_F_STANDBY feature bit.
Venu Busireddy (2):
virtio_net: Add support for "Data Path Switching" during Live Migration.
virtio_net: Add a query command for FAILOVER_STANDBY_CHANGED event.
---
Changes in v2:
Added a query command for FAILOVER_STANDBY_CHANGED event.
Added a que
-by: Venu Busireddy
---
hw/vfio/pci.c | 57 +
qapi/net.json | 26 ++
2 files changed, 83 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index bd83b58..adcc95a 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
-by: Venu Busireddy
---
hw/vfio/pci.c | 57 +
qapi/net.json | 26 ++
2 files changed, 83 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index ce1f33c..ea24ca2 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
ci devices. Only the vfio-pci devices that have this property
enabled are removed from the guest upon reboot.
Signed-off-by: Venu Busireddy
---
hw/acpi/pcihp.c| 27 ++
hw/net/virtio-net.c| 23 ++
hw/vfio/pci.c |
From: Sridhar Samudrala
This feature bit can be used by a hypervisor to indicate to the virtio_net
device that it can act as a standby for another device with the same MAC
address.
Signed-off-by: Sridhar Samudrala
Signed-off-by: Venu Busireddy
---
hw/net/virtio-net.c | 2 ++
1 file changed
but just offers simplicity of implementation.
Sridhar Samudrala (1):
virtio_net: Add VIRTIO_NET_F_STANDBY feature bit.
Venu Busireddy (1):
virtio_net: Add support for "Data Path Switching" during Live Migration.
Si-Wei Liu (1):
vfio-pci: Add FAILOVER_PRIMARY_CHANGED event
On 2018-07-07 15:14:11 +0300, Marcel Apfelbaum wrote:
> Hi Venu,
>
> On 06/30/2018 01:19 AM, Venu Busireddy wrote:
> > Add a new bridge device "pcie-downstream" with a
> > Vendor ID of PCI_VENDOR_ID_REDHAT and a Device ID of
> > PCI_DEVICE_ID_REDHAT
On 2018-07-10 05:11:18 +0300, Michael S. Tsirkin wrote:
> On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote:
> > The current patch set includes all the feedback received for proposals [3]
> > and [4]. For the sake of completeness, patch for the virtio specificat
On 2018-07-03 12:58:25 +0300, Roman Kagan wrote:
> On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote:
> > On 7/2/2018 9:14 AM, Roman Kagan wrote:
> > > On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote:
> > > > The patch set "En
io device with the passthrough device attached to
that bridge.
This capability is added to the bridge iff the "failover-group-id"
option is specified for the bridge.
Signed-off-by: Venu Busireddy
---
default-configs/arm-softmmu.mak| 1 +
default-configs/i386-softmmu.mak | 1 +
VICE_ID_REDHAT_BRIDGE_FAILOVER
to avoid confusion with bridges that don't have this capability.
This capability is added to the bridge iff the "failover-group-id"
option is specified for the bridge.
Signed-off-by: Venu Busireddy
---
hw/pci-bridge/pci_bridge_dev.c | 10 +++
Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group Identifier) capability to the
virtio PCI capabilities to allow for the grouping of devices.
Signed-off-by: Venu Busireddy
---
content.tex | 30 ++
1 file changed, 30 insertions(+)
diff --git a/content.tex b/content.tex
index
ce
named "pcie-downstream" with Red Hat Vendor ID, and include the
group identifier in this device.
- Added a new patch to enhance the "pci-bridge" device to support
the group identifier (for the i440FX model).
Venu Busireddy (3):
Add "Group Identifier" supp
lover-group-id" option is specified.
Group Identifier is used to pair a virtio device with a passthrough
device.
Signed-off-by: Venu Busireddy
---
hw/virtio/virtio-pci.c | 15 +++
hw/virtio/virtio-pci.h | 3 ++-
include/hw/pci/pci.h
On 2018-06-27 22:27:33 -0500, Venu Busireddy wrote:
> On 2018-06-28 04:54:16 +0300, Michael S. Tsirkin wrote:
> > On Wed, Jun 27, 2018 at 05:34:17PM -0500, Venu Busireddy wrote:
> > > On 2018-06-27 23:12:12 +0300, Michael S. Tsirkin wrote:
> > > > On Wed, Jun 27,
On 2018-06-28 05:14:50 +0300, Michael S. Tsirkin wrote:
> On Wed, Jun 27, 2018 at 06:07:59PM -0500, Venu Busireddy wrote:
> > On 2018-06-26 23:08:12 -0500, Venu Busireddy wrote:
> > > On 2018-06-27 07:02:36 +0300, Michael S. Tsirkin wrote:
> > > > On Tue, Jun 26,
On 2018-06-28 04:54:16 +0300, Michael S. Tsirkin wrote:
> On Wed, Jun 27, 2018 at 05:34:17PM -0500, Venu Busireddy wrote:
> > On 2018-06-27 23:12:12 +0300, Michael S. Tsirkin wrote:
> > > On Wed, Jun 27, 2018 at 02:59:01PM -0500, Venu Busireddy wrote:
> > > > On 2018
On 2018-06-26 23:08:12 -0500, Venu Busireddy wrote:
> On 2018-06-27 07:02:36 +0300, Michael S. Tsirkin wrote:
> > On Tue, Jun 26, 2018 at 10:49:33PM -0500, Venu Busireddy wrote:
> > > Add the "Vendor-Specific" capability to the Red Hat PCI bridge device
> > >
On 2018-06-27 23:12:12 +0300, Michael S. Tsirkin wrote:
> On Wed, Jun 27, 2018 at 02:59:01PM -0500, Venu Busireddy wrote:
> > On 2018-06-27 22:47:05 +0300, Michael S. Tsirkin wrote:
> > > On Wed, Jun 27, 2018 at 02:29:58PM -0500, Venu Busireddy wrote:
> > > > On 20
On 2018-06-27 22:47:05 +0300, Michael S. Tsirkin wrote:
> On Wed, Jun 27, 2018 at 02:29:58PM -0500, Venu Busireddy wrote:
> > On 2018-06-27 15:24:58 +0300, Roman Kagan wrote:
> > > On Tue, Jun 26, 2018 at 10:49:30PM -0500, Venu Busireddy wrote:
> > > > The patch
On 2018-06-27 15:24:58 +0300, Roman Kagan wrote:
> On Tue, Jun 26, 2018 at 10:49:30PM -0500, Venu Busireddy wrote:
> > The patch set "Enable virtio_net to act as a standby for a passthru
> > device" [1] deals with live migration of guests that use passthrough
> > dev
On 2018-06-27 07:06:42 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 26, 2018 at 10:49:30PM -0500, Venu Busireddy wrote:
> > The patch set "Enable virtio_net to act as a standby for a passthru
> > device" [1] deals with live migration of guests that use passthr
On 2018-06-27 07:02:36 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 26, 2018 at 10:49:33PM -0500, Venu Busireddy wrote:
> > Add the "Vendor-Specific" capability to the Red Hat PCI bridge device
> > "pci-bridge", to contain the "Group Identifier"
- As Michael Tsirkin suggested, instead of tweaking the ioh3420
device with Red Hat vendor ID, create a new PCIe bridge device
named "pcie-downstream" with Red Hat Vendor ID, and include the
group identifier in this device.
- Added a new patch to enhance the "pci-bri
io device with
the passthrough device attached to that bridge.
This capability is added to the bridge iff the "uuid" option is specified
for the bridge.
Signed-off-by: Venu Busireddy
---
default-configs/arm-softmmu.mak| 1 +
default-configs/i386-softmmu.mak | 1 +
default-configs/x
; option is specified.
Group Identifier is used to pair a virtio device with a passthrough
device.
Signed-off-by: Venu Busireddy
---
hw/virtio/virtio-pci.c | 15 +++
hw/virtio/virtio-pci.h | 3 ++-
include/hw/pci/pci.h
the "uuid" option is specified
for the bridge.
Signed-off-by: Venu Busireddy
---
hw/pci-bridge/pci_bridge_dev.c | 8
hw/pci/pci_bridge.c| 26 ++
include/hw/pci/pcie.h | 1 +
3 files changed, 35 insertions(+)
diff --git a/hw/pci
Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group Identifier) capability to the
virtio PCI capabilities to allow for the grouping of devices.
Signed-off-by: Venu Busireddy
---
content.tex | 36
1 file changed, 36 insertions(+)
diff --git a/content.tex b/content.tex
It may not always be desirable to have a random UUID stuffed into the
'_field' member. Add a new boolean option '_default' that will allow
the caller to specify if a random UUID needs be generated or not.
Also modified the instance where this macro is used.
Signed-off-by: Venu Busireddy
---
hw
On 2018-06-21 18:21:55 -0700, Siwei Liu wrote:
> On Thu, Jun 21, 2018 at 7:59 AM, Cornelia Huck wrote:
> > On Wed, 20 Jun 2018 22:48:58 +0300
> > "Michael S. Tsirkin" wrote:
> >
> >> On Wed, Jun 20, 2018 at 06:06:19PM +0200, Cornelia Huck wrote:
> >> > In any case, I'm not sure anymore why we'd
On 2018-06-19 21:53:01 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 19, 2018 at 01:36:17PM -0500, Venu Busireddy wrote:
> > On 2018-06-19 21:21:23 +0300, Michael S. Tsirkin wrote:
> > > On Tue, Jun 19, 2018 at 01:14:06PM -0500, Venu Busireddy wrote:
> > > > On 2018
On 2018-06-19 21:21:23 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 19, 2018 at 01:14:06PM -0500, Venu Busireddy wrote:
> > On 2018-06-19 20:24:12 +0300, Michael S. Tsirkin wrote:
> > > On Tue, Jun 19, 2018 at 11:32:26AM -0500, Venu Busireddy wrote:
> > > > Add
On 2018-06-19 21:12:17 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 19, 2018 at 12:54:06PM -0500, Venu Busireddy wrote:
> > On 2018-06-19 20:30:06 +0300, Michael S. Tsirkin wrote:
> > > On Tue, Jun 19, 2018 at 11:32:28AM -0500, Venu Busireddy wrote:
> > > > Add VIRT
On 2018-06-19 20:24:12 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 19, 2018 at 11:32:26AM -0500, Venu Busireddy wrote:
> > Add a "Vendor-Specific" capability to the PCIe bridge, to contain the
> > "Group Identifier" (UUID) that will be used to pair a vir
On 2018-06-19 20:30:06 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 19, 2018 at 11:32:28AM -0500, Venu Busireddy wrote:
> > Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group Identifier) capability to the
> > virtio PCI capabilities to allow for the grouping of devices.
> >
&g
It may not always be desirable to have a random UUID stuffed into the
'_field' member. Add a new option '_default' to the macro, that will
allow the caller to specify if a random UUID needs be generated or not.
Also modified the instance where this macro is used.
Signed-off-by: Venu Busireddy
; option is specified.
Group Identifier is used to pair a virtio device with a passthrough
device.
Signed-off-by: Venu Busireddy
---
hw/virtio/virtio-pci.c | 15 +++
hw/virtio/virtio-pci.h | 3 ++-
include/standard-headers/linux/virtio_
ied
for the bridge device, via the qemu command line. Also, the bridge's
Device ID is changed to PCI_VENDOR_ID_REDHAT, and Vendor ID is changed
to PCI_DEVICE_ID_REDHAT_PCIE_BRIDGE (from the default values), when the
"uuid" option is present.
Signed-off-by: Venu Busireddy
---
hw/pci-bridge
tio device's
configuration space instead of the MAC address for pairing the devices.
Thanks!
Venu
[1] https://lists.oasis-open.org/archives/virtio-dev/201805/msg00156.html
[2] https://www.spinics.net/lists/netdev/msg499011.html
[3] https://lists.oasis-open.org/archives/virtio-dev/201805/ms
Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group Identifier) capability to the
virtio PCI capabilities to allow for the grouping of devices.
Signed-off-by: Venu Busireddy
---
content.tex | 43 +++
1 file changed, 43 insertions(+)
diff --git a/content.tex b
75 matches
Mail list logo
