Re: [PATCH v4 2/3] hw/acpi/nvdimm: add a helper to augment SRAT generation

2020-06-05 Thread Verma, Vishal L
On Fri, 2020-06-05 at 10:23 +0200, Igor Mammedov wrote: > > > > The relevant command line options to exercise this are below. Nodes 0-1 > > > > contain CPUs and regular memory, and nodes 2-3 are the NVDIMM address > > > > space. > > > > > > > > -numa node,nodeid=0,mem=2048M, > > > > -numa nod

Re: [PATCH v4 2/3] hw/acpi/nvdimm: add a helper to augment SRAT generation

2020-06-04 Thread Verma, Vishal L
On Thu, 2020-06-04 at 12:33 +0200, Igor Mammedov wrote: > On Thu, 28 May 2020 16:34:36 -0600 > Vishal Verma wrote: > > > NVDIMMs can belong to their own proximity domains, as described by the > > NFIT. In such cases, the SRAT needs to have Memory Affinity structures > > in the SRAT for these NVDI

Re: [PATCH 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT

2020-05-28 Thread Verma, Vishal L
On Thu, 2020-05-28 at 12:41 +0200, Igor Mammedov wrote: > On Thu, 28 May 2020 01:24:42 + > "Verma, Vishal L" wrote: > > On Thu, 2020-05-21 at 17:16 +0200, Igor Mammedov wrote: > > [..] > > > > > > There is ARM version of build_srat(), >

Re: [PATCH v2 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT

2020-05-28 Thread Verma, Vishal L
On Thu, 2020-05-28 at 13:19 +0200, Igor Mammedov wrote: [..] > > @@ -1334,6 +1335,31 @@ static void nvdimm_build_ssdt(GArray *table_offsets, > > GArray *table_data, > > free_aml_allocator(); > > } > > > > +void *nvdimm_build_srat(GArray *table_data) > > +{ > > +AcpiSratMemoryAffinity

Re: [PATCH 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT

2020-05-27 Thread Verma, Vishal L
On Thu, 2020-05-21 at 17:16 +0200, Igor Mammedov wrote: Hi Igor, Thanks for the review. [..] > > > > @@ -2429,6 +2430,25 @@ build_srat(GArray *table_data, BIOSLinker *linker, > > MachineState *machine) > >MEM_AFFINITY_ENABLED); > > } > > } > > + >

Re: [PATCH 0/3] account for NVDIMM nodes during SRAT generation

2020-05-12 Thread Verma, Vishal L
On Mon, 2020-04-27 at 19:28 -0600, Vishal Verma wrote: > On the command line, one can specify a NUMA node for NVDIMM devices. If > we set up the topology to give NVDIMMs their own nodes, i.e. not > containing any CPUs or regular memory, qemu doesn't populate SRAT memory > affinity structures for th

Re: [PATCH 0/3] account for NVDIMM nodes during SRAT generation

2020-04-28 Thread Verma, Vishal L
On Mon, 2020-04-27 at 19:44 -0700, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200428012810.10877-1-vishal.l.ve...@intel.com/ [..] > > === OUTPUT BEGIN === > 1/3 Checking commit 08b7ee5e7ddf (diffs-allowed: add the SRAT AML to > diffs-allowed) > 2/3 Checking commit dcc