Re: [Qemu-devel] [PATCH v4 1/1] qga: Add 'guest-get-users' command

2017-04-19 Thread Vinzenz Feenstra
> On Apr 14, 2017, at 12:09 AM, Michael Roth <mdr...@linux.vnet.ibm.com> wrote: > > Quoting Vinzenz 'evilissimo' Feenstra (2017-04-13 05:41:17) >> From: Vinzenz Feenstra <vfeen...@redhat.com> >> >> A command that will list all currently logg

Re: [Qemu-devel] [PATCH] qga: improve fsfreeze documentations

2017-04-13 Thread Vinzenz Feenstra
Reviewed-by: Vinzenz Feenstra <vfeen...@redhat.com <mailto:marcandre.lur...@redhat.com>> > On Apr 3, 2017, at 11:54 AM, Marc-André Lureau <marcandre.lur...@redhat.com> > wrote: > > Some users find the fsfreeze behaviour confusing. Add some notes about > inval

Re: [Qemu-devel] [PATCH] QEMU Guest Agent: Add an interface to determine guest os type

2017-04-12 Thread Vinzenz Feenstra
'guest-set-vcpus', > 'guest-sync', > +'guest-ostype', > 'guest-sync-delimited' ] } } > > ## > @@ -1042,3 +1043,14 @@ >'data':{ 'path': 'str', '*arg': ['str'], '*env': ['str'], > '*input-data': 'str', '*capture-output': 'bool' }, >'returns': 'GuestExec' } > + > +## > +# @guest-ostype: > +# > +# Get guest os type info > +# Returns: os type, Linux/Windows > +# > +# Since: 2.5.0 > +## > +{ 'command': 'guest-ostype', > + 'returns': 'int' } > -- > 1.8.3.1 > > > > -- > Marc-André Lureau -- Vinzenz Feenstra Senior Software Developer Red Hat Czech

Re: [Qemu-devel] [PATCH v2 1/1] qga: Add 'guest-get-host-name' command

2017-04-11 Thread Vinzenz Feenstra
Ping > On Apr 4, 2017, at 8:46 AM, Vinzenz 'evilissimo' Feenstra > <vfeen...@redhat.com> wrote: > > From: Vinzenz Feenstra <vfeen...@redhat.com> > > Retrieving the guest host name is a very useful feature for virtual management > systems. This information can h

Re: [Qemu-devel] [PATCH v5] qga: Add `guest-get-timezone` command

2017-04-11 Thread Vinzenz Feenstra
ailto:sam...@daynix.com>> > > On Thu, Mar 23, 2017 at 2:39 PM, Vinzenz 'evilissimo' Feenstra > <vfeen...@redhat.com <mailto:vfeen...@redhat.com>> wrote: > From: Vinzenz Feenstra <vfeen...@redhat.com <mailto:vfeen...@redhat.com>> > > Adds a ne

Re: [Qemu-devel] [PATCH v3 1/1] qga: Add 'guest-get-users' command

2017-04-11 Thread Vinzenz Feenstra
PING > On Apr 4, 2017, at 7:51 AM, Vinzenz 'evilissimo' Feenstra > <vfeen...@redhat.com> wrote: > > From: Vinzenz Feenstra <vfeen...@redhat.com> > > A command that will list all currently logged in users, and the time > since when they are logged in. >

Re: [Qemu-devel] [PATCH v5] qga: Add `guest-get-timezone` command

2017-04-04 Thread Vinzenz Feenstra
Ping > On Mar 23, 2017, at 12:39 PM, Vinzenz 'evilissimo' Feenstra > <vfeen...@redhat.com> wrote: > > From: Vinzenz Feenstra <vfeen...@redhat.com> > > Adds a new command `guest-get-timezone` reporting the currently > configured timezone on the system.

Re: [Qemu-devel] [PATCH v3] qemu-ga: add guest-get-osrelease command

2017-04-03 Thread Vinzenz Feenstra
t.com>> wrote: > On 03/31/2017 05:19 AM, Vinzenz 'evilissimo' Feenstra wrote: > > From: Vinzenz Feenstra <vfeen...@redhat.com <mailto:vfeen...@redhat.com>> > > > > Add a new 'guest-get-osrelease' command to report OS information in the > > os-release forma

Re: [Qemu-devel] [PATCH] qga: improve fsfreeze documentations

2017-04-03 Thread Vinzenz Feenstra
LGTM > On Apr 3, 2017, at 11:54 AM, Marc-André Lureau > wrote: > > Some users find the fsfreeze behaviour confusing. Add some notes about > invalid mount points and Windows usage. > > Related to: > https://bugzilla.redhat.com/show_bug.cgi?id=1436976 > >

Re: [Qemu-devel] [PATCH v2] qemu-ga: add guest-get-osinfo command

2017-03-27 Thread Vinzenz Feenstra
> On Mar 24, 2017, at 10:48 AM, Vinzenz Feenstra <vfeen...@redhat.com> wrote: > >> >> On Mar 23, 2017, at 3:58 PM, Eric Blake <ebl...@redhat.com >> <mailto:ebl...@redhat.com>> wrote: >> >> On 03/16/2017 09:50 AM, Vinzenz 'eviliss

Re: [Qemu-devel] [PATCH v1] qga: Add 'guest-get-fqdn' command

2017-03-27 Thread Vinzenz Feenstra
> On Mar 27, 2017, at 12:44 PM, Sameeh Jubran <sam...@daynix.com> wrote: > > > > On Thu, Mar 23, 2017 at 9:51 PM, Vinzenz 'evilissimo' Feenstra > <vfeen...@redhat.com <mailto:vfeen...@redhat.com>> wrote: > From: Vinzenz Feenstra <vfeen

Re: [Qemu-devel] [PATCH v2] qemu-ga: add guest-get-osinfo command

2017-03-24 Thread Vinzenz Feenstra
> On Mar 23, 2017, at 3:58 PM, Eric Blake <ebl...@redhat.com> wrote: > > On 03/16/2017 09:50 AM, Vinzenz 'evilissimo' Feenstra wrote: >> From: Vinzenz Feenstra <vfeen...@redhat.com> >> >> Add a new 'guest-get-osinfo' command for reporting basic infor

Re: [Qemu-devel] [PATCH v2] qga: Add `guest-get-timezone` command

2017-03-23 Thread Vinzenz Feenstra
seems to be working good. > > Please see some comments inline. > > > On 3/22/2017 7:16 PM, Vinzenz 'evilissimo' Feenstra wrote: > > From: Vinzenz Feenstra <vfeen...@redhat.com <mailto:vfeen...@redhat.com>> > > > > Adds a new command `guest-get-t

Re: [Qemu-devel] [PATCH] qga: Add `guest-get-timezone` command

2017-03-22 Thread Vinzenz Feenstra
Sorry I meant to add you Michael not Paolo -_- > On Mar 22, 2017, at 4:46 PM, Vinzenz 'evilissimo' Feenstra > <vfeen...@redhat.com> wrote: > > From: Vinzenz Feenstra <vfeen...@redhat.com> > > Adds a new command `guest-get-timezone` reporting the currently >

Re: [Qemu-devel] [PATCH] qemu-ga: add guest-get-osinfo command

2017-03-21 Thread Vinzenz Feenstra
> On Mar 21, 2017, at 2:39 PM, Eric Blake <ebl...@redhat.com> wrote: > > On 03/16/2017 05:23 AM, Vinzenz 'evilissimo' Feenstra wrote: >> From: Vinzenz Feenstra <vfeen...@redhat.com> >> >> Add a new 'guest-get-osinfo' command for reporting basic infor

Re: [Qemu-devel] [PATCH] checkpatch: Supress warning in function pointer typedefs

2017-03-21 Thread Vinzenz Feenstra
> On Mar 21, 2017, at 1:37 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On 16 March 2017 at 11:14, Vinzenz 'evilissimo' Feenstra > <vfeen...@redhat.com> wrote: >> From: Vinzenz Feenstra <vfeen...@redhat.com> >> >> When importing dynam