Re: qemu-system-i386: Could not install MSR_CORE_THREAD_COUNT handler: Success

2022-12-31 Thread Vitaly Chikunov
Alexander, On Sat, Dec 31, 2022 at 12:34:45PM +0100, Alexander Graf wrote: > On 31.12.22 11:17, Vitaly Chikunov wrote: > > On Sat, Dec 31, 2022 at 10:28:21AM +0100, Alexander Graf wrote: > > > On 30.12.22 19:16, Vitaly Chikunov wrote: > > > > On Fri, Dec 30, 2022

Re: qemu-system-i386: Could not install MSR_CORE_THREAD_COUNT handler: Success

2022-12-31 Thread Vitaly Chikunov
Alexander, On Sat, Dec 31, 2022 at 10:28:21AM +0100, Alexander Graf wrote: > On 30.12.22 19:16, Vitaly Chikunov wrote: > > On Fri, Dec 30, 2022 at 06:44:14PM +0100, Alexander Graf wrote: > > > > > > This is a kvm kernel bug and should be fixed with the latest stable &

Re: qemu-system-i386: Could not install MSR_CORE_THREAD_COUNT handler: Success

2022-12-30 Thread Vitaly Chikunov
und for such situations? (Or maybe it's possible to make this error non-fatal?) We use qemu+kvm for testing and now we cannot test on x86. Thanks, > > Thanks, > > Alex > > > > Am 30.12.2022 um 15:30 schrieb Vitaly Chikunov : > > > > Hi, > > &g

qemu-system-i386: Could not install MSR_CORE_THREAD_COUNT handler: Success

2022-12-30 Thread Vitaly Chikunov
Hi, QEMU 7.2.0 when run on 32-bit x86 architecture fails with: i586$ qemu-system-i386 -enable-kvm qemu-system-i386: Could not install MSR_CORE_THREAD_COUNT handler: Success i586$ qemu-system-x86_64 -enable-kvm qemu-system-x86_64: Could not install MSR_CORE_THREAD_COUNT handler: Success M

Re: [PATCH v3] target/arm/kvm: Retry KVM_CREATE_VM call if it fails EINTR

2022-09-30 Thread Vitaly Chikunov
e. Adopt the same approach for the use of the > ioctl in the Arm-specific KVM code (where we use it to create a > scratch VM for probing for various things). > > For more information, see the mailing list thread: > https://lore.kernel.org/qemu-devel/8735e0s1zw.wl-...@kernel.org/ >

Re: [PATCH] target/arm/kvm: Retry KVM_CREATE_VM call if it fails EINTR

2022-09-26 Thread Vitaly Chikunov
code. Adopt the same approach for the use of the > ioctl in the Arm-specific KVM code (where we use it to create a > scratch VM for probing for various things). > > For more information, see the mailing list thread: > https://lore.kernel.org/qemu-devel/8735e0s1zw.wl-...@kernel.or

Re: qemu-system-aarch64: Failed to retrieve host CPU features

2022-08-13 Thread Vitaly Chikunov
Marc, On Fri, Aug 12, 2022 at 04:02:37PM +0100, Marc Zyngier wrote: > On Fri, 12 Aug 2022 10:25:55 +0100, > Peter Maydell wrote: > > > > I've added some more relevant mailing lists to the cc. > > > > On Fri, 12 Aug 2022 at 09:45, Vitaly Chikunov wrote: >

Re: [PATCH v5] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-17 Thread Vitaly Chikunov
On Thu, Feb 17, 2022 at 10:26:37AM +0100, Christian Schoenebeck wrote: > On Mittwoch, 16. Februar 2022 19:18:21 CET Vitaly Chikunov wrote: > > `struct dirent' returned from readdir(3) could be shorter (or longer) > > than `sizeof(struct dirent)', thus memcpy of sizeof leng

[PATCH v5] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-16 Thread Vitaly Chikunov
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841 Cc: qemu-sta...@nongnu.org Co-authored-by: Christian Schoenebeck Reviewed-by: Dmitry V. Levin Signed-off-by: Vitaly Chikunov --- Tested on x68-64 Linux with btrfs-progs tests and qos-test -m slow. Changes since v4: - Zero clear V9fsSynthOpenStat

Re: [PULL 0/5] 9p queue 2022-02-10

2022-02-16 Thread Vitaly Chikunov
Christian, On Wed, Feb 16, 2022 at 11:30:12AM +0100, Christian Schoenebeck wrote: > On Dienstag, 15. Februar 2022 08:01:37 CET Greg Kurz wrote: > > On Mon, 14 Feb 2022 17:43:51 +0300 > > > > Vitaly Chikunov wrote: > > > Why g_new0 and not just g_malloc0? This

Re: [PULL 0/5] 9p queue 2022-02-10

2022-02-14 Thread Vitaly Chikunov
Christian, On Mon, Feb 14, 2022 at 12:44:48PM +0100, Christian Schoenebeck wrote: > On Montag, 14. Februar 2022 11:36:53 CET Greg Kurz wrote: > > The synth backend should be fixed to honor d_reclen, or > > at least to allocate with g_new0(). > > Yes, I overlooked that this is not initialized with

[PATCH v4] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-05 Thread Vitaly Chikunov
ps://gitlab.com/qemu-project/qemu/-/issues/841 Cc: qemu-sta...@nongnu.org Co-authored-by: Christian Schoenebeck Reviewed-by: Dmitry V. Levin Signed-off-by: Vitaly Chikunov --- Tested on x68-64 Linux with btrfs-progs tests and slow qos-test. Changes since v3: - Update commentary on qemu_dirent_d

Re: [PATCH v3] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-04 Thread Vitaly Chikunov
On Fri, Feb 04, 2022 at 07:19:39PM +0300, Dmitry V. Levin wrote: > On Fri, Feb 04, 2022 at 02:55:45PM +0100, Philippe Mathieu-Daudé wrote: > > On 4/2/22 06:06, Vitaly Chikunov wrote: > > > `struct dirent' returned from readdir(3) could be shorter (or longer) > >

Re: [PATCH v3] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-04 Thread Vitaly Chikunov
Greg, On Fri, Feb 04, 2022 at 04:16:06PM +0100, Greg Kurz wrote: > On Fri, 04 Feb 2022 15:12:18 +0100 > Christian Schoenebeck wrote: > > > On Freitag, 4. Februar 2022 14:55:45 CET Philippe Mathieu-Daudé via wrote: > > > On 4/2/22 06:06, Vitaly Chikunov wrote: > >

[PATCH v3] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-03 Thread Vitaly Chikunov
ps://gitlab.com/qemu-project/qemu/-/issues/841 Cc: qemu-sta...@nongnu.org Co-authored-by: Christian Schoenebeck Signed-off-by: Vitaly Chikunov --- Tested on x86-64 Linux again. Changes from v2: - Make it work with a simulated dirent where d_reclen is 0, which was caused abort in readdir qos

Re: [PATCH v2] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-03 Thread Vitaly Chikunov
Christian, On Thu, Feb 03, 2022 at 01:42:19PM +0100, Christian Schoenebeck wrote: > On Freitag, 28. Januar 2022 23:33:26 CET Vitaly Chikunov wrote: > > `struct dirent' returned from readdir(3) could be shorter than > > `sizeof(struct dirent)', thus memcpy of sizeof leng

Re: [PATCH v2] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-02 Thread Vitaly Chikunov
On Thu, Feb 03, 2022 at 07:55:41AM +0300, Vitaly Chikunov wrote: > Christian, > > On Wed, Feb 02, 2022 at 05:55:45PM +0100, Christian Schoenebeck wrote: > > On Freitag, 28. Januar 2022 23:33:26 CET Vitaly Chikunov wrote: > > > `struct dirent' returned from rea

Re: [PATCH v2] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-02 Thread Vitaly Chikunov
Christian, On Wed, Feb 02, 2022 at 05:55:45PM +0100, Christian Schoenebeck wrote: > On Freitag, 28. Januar 2022 23:33:26 CET Vitaly Chikunov wrote: > > `struct dirent' returned from readdir(3) could be shorter than > > `sizeof(struct dirent)', thus memcpy of sizeof leng

[PATCH v2] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-01-28 Thread Vitaly Chikunov
om/qemu-project/qemu/-/issues/841 Cc: qemu-sta...@nongnu.org Co-authored-by: Christian Schoenebeck Signed-off-by: Vitaly Chikunov --- Tested on x86-64 Linux. Changes since v1: - Update commentary text. - Remove hanging of g_malloc "errors". - Simplify qemu_dirent_dup. hw/9pfs/codir

Re: [PATCH] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-01-28 Thread Vitaly Chikunov
Christian, On Fri, Jan 28, 2022 at 03:43:10PM +0100, Christian Schoenebeck wrote: > On Donnerstag, 27. Januar 2022 22:27:34 CET Vitaly Chikunov wrote: > > `struct dirent' returned from readdir(3) could be shorter than > > `sizeof(struct dirent)', thus memcpy of si

[PATCH] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-01-27 Thread Vitaly Chikunov
97eed) #1 0x559ec2e9 v9fs_readdir (/usr/bin/qemu-system-x86_64 + 0x4982e9) #2 0x55eb7983 coroutine_trampoline (/usr/bin/qemu-system-x86_64 + 0x963983) #3 0x773e0be0 n/a (n/a + 0x0) Resolves: https://gitlab.com/qemu-project/qemu/-/issues/841 Signed-off-by: Vitaly Chikunov --- Tested

[Bug 1913315] [NEW] qemu-system-x86_64 crash: in memory_region_access_valid+0x13

2021-01-26 Thread Vitaly Chikunov
Public bug reported: Recently we started to get intermittent qemu crashes. There is catchsegv report: ``` + qemu-system-x86_64 -m 77766M -smp 8 -nodefaults -nographic -no-reboot -fsdev local,id=root,path=/,security_model=none,multidevs=remap -device virtio-9p-pci,fsdev=root,mount_tag=/dev/root

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-11 Thread Vitaly Chikunov
David, On Wed, Mar 11, 2020 at 10:15:03AM +1100, David Gibson wrote: > On Mon, Mar 09, 2020 at 11:45:57PM +0300, Vitaly Chikunov wrote: > > rlwinm cannot just AND with Mask if shift value is zero on ppc64 when > > Mask Begin is greater than Mask End and high bits are set to 1. >

[PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread Vitaly Chikunov
-sta...@nongnu.org Signed-off-by: Vitaly Chikunov --- target/ppc/translate.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 36fa27367c..127c82a24e 100644 --- a/target/ppc/translate.c +++ b/target/pp