[Qemu-devel] [PATCH 11/12] tests/test-hmp: Add announce parameter tests

Add 2 new commands for announce parameters to the test. Signed-off-by: Vladislav Yasevich --- tests/test-hmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test-hmp.c b/tests/test-hmp.c index 99e35ec..f3887d1 100644 --- a/tests/test-hmp.c +++ b/tests/test-hmp.c @@ -65,6 +65,8

[Qemu-devel] [PATCH 10/12] hmp: Add hmp_announce_self

Add an HMP command to trigger self annocements. Signend-off-by: Vladislav Yasevich --- hmp-commands.hx | 14 ++ hmp.c | 5 + hmp.h | 1 + 3 files changed, 20 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index c8dd816..0efe479 100644 --- a

[Qemu-devel] [PATCH 09/12] hmp: add announce paraters info/set

Add HMP command to control and read annoucment parameters. Signed-off-by: Vladislav Yasevich --- hmp-commands-info.hx | 13 hmp-commands.hx | 14 + hmp.c| 86 hmp.h| 4 +++ monitor.c

[Qemu-devel] [PATCH 08/12] announce_timer: Add ability to reset an existing

It is now potentially possible to issue annouce-self command in a tight loop. Instead of doing nother, we can reset the timeout pararameters, especially since each instance may provide it's own values. This allows the user to extend or cut short currently runnig timer. Signed-off-by: Vlad

[Qemu-devel] [PATCH 06/12] qmp: Expose qemu_announce_self as a qmp command

Add a qmp command that can trigger guest announcements. Based on work of Germano Veit Michel Signed-off-by: Vladislav Yasevich --- migration/savevm.c | 14 ++ qapi-schema.json | 19 +++ 2 files changed, 33 insertions(+) diff --git a/migration/savevm.c b

[Qemu-devel] [PATCH 07/12] migration: Allow for a limited number of announce timers

_self mechanism. Signed-off-by: Vladislav Yasevich --- include/migration/vmstate.h | 1 + include/sysemu/sysemu.h | 9 - migration/migration.c | 2 +- migration/savevm.c | 24 +++- 4 files changed, 29 insertions(+), 7 deletions(-) diff --git a/in

[Qemu-devel] [PATCH 05/12] virtio-net: Allow qemu_announce_self to trigger virtio announcements

Expose the virtio-net self annoucement capability and allow qemu_announce_self() to call it. Signed-off-by: Vladislav Yasevich --- hw/net/virtio-net.c | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c

[Qemu-devel] [PATCH 03/12] migration: Switch to using announcement timer

Switch qemu_announce_self and virtio annoucements to use the announcement timer framework. This makes sure that both timers use the same timeouts and number of annoucement attempts Based on work by Dr. David Alan Gilbert Signed-off-by: Vladislav Yasevich --- hw/net/virtio-net.c

[Qemu-devel] [PATCH 12/12] tests: Add a test for qemu self announcments

We now expose qemu_announce_self through QMP and HMP. Add a test with some very basic packet validation (make sure we get a RARP). Signed-off-by: Vlad Yasevich --- tests/Makefile.include | 2 ++ tests/test-announce-self.c | 78 ++ 2 files changed

[Qemu-devel] [PATCH 00/12] self-announce updates

can be created through the new commands, and have the ability to reset currently runing timers. Thanks Vladislav Yasevich (12): migration: Introduce announce parameters migration: Introduce announcement timer migration: Switch to using announcement timer net: Add a network devic

[Qemu-devel] [PATCH 02/12] migration: Introduce announcement timer

Introdec an annoucement timer structure and initialization to be used by for self-annoucement. Based on the work by Germano Veit Michel Signed-off-by: Vlad Yasevich --- include/migration/vmstate.h | 13 + migration/savevm.c | 22 ++ 2 files changed, 35

[Qemu-devel] [PATCH 04/12] net: Add a network device specific self-announcement ability

Some network devices have a capability to do self annoucements (ex: virtio-new). Add infrustrcture that would allow devices to expose this ability. Signed-off-by: Vladislav Yasevich --- include/net/net.h | 2 ++ migration/savevm.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a

[Qemu-devel] [PATCH 01/12] migration: Introduce announce parameters

Add parameters that control RARP/GARP announcement timeouts. The parameters structure is added to the QAPI and a qmp command is added to set/get the parameter data. Based on work by "Dr. David Alan Gilbert" Signed-off-by: Vladislav Yasevich --- include/sysemu/sysemu.h | 7

[Qemu-devel] [PATCH] virtio-net: consolidate guest announcement with qemu_announce_self

so usefull in support of exposing qemu_announce_self through qmp/hmp. Signed-off-by: Vladislav Yasevich --- hw/net/virtio-net.c| 30 -- include/hw/virtio/virtio-net.h | 2 -- include/net/net.h | 2 ++ migration/savevm.c | 6 +

[Qemu-devel] [PATCH] net: Remove duplicate data from query-rx-filter on multiqueue net devices

data. Commit 638fb14169 (net: Make qmp_query_rx_filter() with name argument more obvious) partially addresses this issue, by limiting the output when the name is specified. However, when the name is not specified, the issue still persists. Signed-off-by: Vladislav Yasevich --- net/net.c | 6

[Qemu-devel] [PATCH v4 1/2] rtl8139: Fix receive buffer overflow check

condition. Signed-off-by: Vladislav Yasevich --- hw/net/rtl8139.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index edbb61c..8a33466 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -1148,7 +1148,9 @@ static ssize_t

[Qemu-devel] [PATCH v4 0/2] rtl8139: Fix buffer overflow in standard mode

full buffer size when the buffer full. Vladislav Yasevich (2): rtl8139: Fix receive buffer overflow check rtl8139: Do not consume the packet during overflow in standard mode. hw/net/rtl8139.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 1.9.3

[Qemu-devel] [PATCH v4 2/2] rtl8139: Do not consume the packet during overflow in standard mode.

: Vladislav Yasevich --- hw/net/rtl8139.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 8a33466..cb51613 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -1159,7 +1159,7 @@ static ssize_t rtl8139_do_receive(NetClientState *nc, const

[Qemu-devel] [PATCH v3 1/2] rtl8139: Do not consume the packet during overflow in standard mode.

: Vladislav Yasevich --- hw/net/rtl8139.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index edbb61c..359e001 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -1157,7 +1157,7 @@ static ssize_t rtl8139_do_receive(NetClientState *nc, const

[Qemu-devel] [PATCH v3 0/2] rtl8139: Fix buffer overflow in standard mode

start, adjust it on every receive from the network and read from the guest and can set the number of unread of bytes to full buffer size when the buffer full. Vladislav Yasevich (2): rtl8139: Do not consume the packet during overflow in standard mode. rtl8139: correctly track full

[Qemu-devel] [PATCH v3 2/2] rtl8139: correctly track full receive buffer in standard mode

adjsted and the special case of a full buffer is also trapped. The C+ register trick is used to simplify migration and not require a new machine type. This register is not used in regular mode and C+ mode doesn't have the same issue. Signed-off-by: Vladislav Yasevich --- hw/net/rtl8139.c

[Qemu-devel] [PATCH 2/2] rtl8139: correctly track full receive buffer in standard mode

adjsted and the special case of a full buffer is also trapped. The C+ register trick is used to simplify migration and not require a new machine type. This register is not used in regular mode and C+ mode doesn't have the same issue. Signed-off-by: Vladislav Yasevich --- hw/net/rtl8139.c

[Qemu-devel] [PATCH 1/2] rtl8139: Do not consume the packet during overflow in standard mode.

: Vladislav Yasevich --- hw/net/rtl8139.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index edbb61c..359e001 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -1157,7 +1157,7 @@ static ssize_t rtl8139_do_receive(NetClientState *nc, const

[Qemu-devel] [PATCH v2 0/2] rtl8139: Fix buffer overflow in standard mode

. Vladislav Yasevich (2): rtl8139: Do not consume the packet during overflow in standard mode. rtl8139: correctly track full receive buffer in standard mode hw/net/rtl8139.c | 44 +++- 1 file changed, 39 insertions(+), 5 deletions(-) -- 1.9.3

[Qemu-devel] [PATCH 2/2] rtl8139: correctly track full receive buffer in standard mode

on and not require a new machine type. Signed-off-by: Vladislav Yasevich --- hw/net/rtl8139.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 359e001..3d572ab 100644 --- a/hw/net/rtl8139.c +++ b/hw/net

[Qemu-devel] [PATCH 1/2] rtl8139: Do not consume the packet during overflow in standard mode.

: Vladislav Yasevich --- hw/net/rtl8139.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index edbb61c..359e001 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -1157,7 +1157,7 @@ static ssize_t rtl8139_do_receive(NetClientState *nc, const

[Qemu-devel] [PATCH 0/2] rtl8139: Fix buffer overflow in standard mode

packet fills the buffer and thus keeps overwriting the previous packet and never waking up the guest. The solution here is to trap the buffer full condition and let the guest read the data before writing more data to the rxBuffer. Vladislav Yasevich (2): rtl8139: Do not consume the

[Qemu-devel] [PATCH] net: Fix link state inter-dependencies between NIC and backend

in addition to actual link state. Thus is is possible to set link down at each end effectively emulating plugging/unplugging the wire at either end. The patch continues to preserve the old behavior where setting just nic side down does NOT impact the backend. Signed-off-by: Vladislav Yasevich