Re: [PATCH 01/15] tests/avocado: add RISC-V opensbi boot test

RISCV64_BIOS_BIN | RISCV32_BIOS_BIN firmware with minimal options. Cc: Cleber Rosa Cc: Philippe Mathieu-Daudé Cc: Wainer dos Santos Moschetta Cc: Beraldo Leal Signed-off-by: Daniel Henrique Barboza --- tests/avocado/riscv_opensbi.py | 65 ++ 1 file changed, 65

Re: [PATCH v2] Acceptance Tests: add standard clean up at test tearDown()

changed, 1 insertion(+) Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index 2c4fef3e14..d9e1b32aa1 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b/tests/acceptance/avocado_qemu/__init__.py

Re: [PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()

Hi, On 8/3/21 4:34 PM, Cleber Rosa wrote: The avocado.Test class, used as the basis of the avocado_qemu.Test class, performs a clean of temporary directories up as part of its own tearDown() implementation. But the avocado_qemu.Test class is currently missing the same clean up, as it

Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file

file changed, 3 insertions(+), 3 deletions(-) Acked-by: Wainer dos Santos Moschetta diff --git a/MAINTAINERS b/MAINTAINERS index 37b1a8e442..d35b948e8d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile F: tests/tcg/Makefile.include Acceptance

Re: [PATCH] Acceptance tests: add myself as a reviewer for the acceptance tests.

422,7 @@ W: https://trello.com/b/6Qi1pxVn/avocado-qemu R: Cleber Rosa R: Philippe Mathieu-Daudé R: Wainer dos Santos Moschetta +R: Willian Rampazzo S: Odd Fixes F: tests/acceptance/

Re: [PATCH] tests/acceptance: Allow overwrite smp and memory

that, the change looks good to me. So: Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index 2c4fef3e14..2639b89c84 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b/tests/acceptance/avocado_qemu

Re: [PATCH] tests/acceptance: Test powernv machines

and powernv9 machines with a simple PCI layout. Cc: Cleber Rosa Cc: Wainer dos Santos Moschetta Signed-off-by: Cédric Le Goater ---   tests/acceptance/boot_linux_console.py | 42 ++   1 file changed, 42 insertions(+) diff --git a/tests/acceptance/boot_linux_console.py b

Re: [PATCH v5 4/4] avocado_qemu: Add Intel iommu tests

iam) - IntelIOMMU becomes the class name (William) - Added William's Sob --- tests/acceptance/intel_iommu.py | 115 1 file changed, 115 insertions(+) create mode 100644 tests/acceptance/intel_iommu.py I successfully ran this test. Tested-by: Wainer dos San

Re: [PATCH v5 1/4] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

= {} +    info = None +    self._info = info or {} @property def checksum(self): Thanks for that fix, Cleber. Acked-by: Wainer dos Santos Moschetta I've tested it with both existing and the newly introduced tests. Cheers, - Cleber.

Re: [PATCH v2] tests/acceptance: allow control over tags during check-acceptance

ting.rst | 8 tests/Makefile.include | 12 +--- 2 files changed, 17 insertions(+), 3 deletions(-) Tested-by: Wainer dos Santos Moschetta Reviewed-by: Wainer dos Santos Moschetta diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 4e42392810..f6e4fc08a7 100644 ---

Re: [PATCH v4 2/4] avocado_qemu: Add SMMUv3 tests

On 7/5/21 5:00 AM, Eric Auger wrote: Hi Wainer, On 7/1/21 8:13 PM, Wainer dos Santos Moschetta wrote: Hi, On 6/29/21 11:36 AM, Eric Auger wrote: Add new tests checking the good behavior of the SMMUv3 protecting 2 virtio pci devices (block and net). We check the guest boots and we are able

Re: [PATCH v4 2/4] avocado_qemu: Add SMMUv3 tests

mmu.py | 132 +++ 1 file changed, 132 insertions(+) create mode 100644 tests/acceptance/smmu.py Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta I tested it in a Fedora 32 aarch64 host. The execution output: # ./tests/ve

Re: [PATCH] tests/vm: update NetBSD to 9.2

On 6/2/21 2:21 PM, Brad Smith wrote: tests/vm: update NetBSD to 9.2 Signed-off-by: Brad Smith --- tests/vm/netbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/vm/netbsd b/tests/vm/netbsd index b9efc269d2

Re: [PATCH v4 0/4] avocado-qemu: New SMMUv3 and intel IOMMU tests

o-qemu-v4 Eric Auger (3): Acceptance Tests: Add default kernel params and pxeboot url to the KNOWN_DISTROS collection avocado_qemu: Add SMMUv3 tests avocado_qemu: Add Intel iommu tests Wainer dos Santos Moschetta (1): avocado_qemu: Fix KNOWN_DISTROS map into the Linu

Re: [PATCH v7 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

Rampazzo --- .gitlab-ci.d/custom-runners.yml | 208 1 file changed, 208 insertions(+) Reviewed-by: Wainer dos Santos Moschetta diff --git a/.gitlab-ci.d/custom-runners.yml b/.gitlab-ci.d/custom-runners.yml index a07b27384c..061d3cdfed 100644 --- a/.gitlab-ci.d

Re: [PATCH v7 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

/setup/vars.yml.template | 12 + 4 files changed, 139 insertions(+), 1 deletion(-) create mode 100644 scripts/ci/setup/gitlab-runner.yml create mode 100644 scripts/ci/setup/vars.yml.template Reviewed-by: Wainer dos Santos Moschetta diff --git a/docs/devel/ci.rst b/docs/devel/ci.rst index

Re: [PATCH v7 2/4] Jobs based on custom runners: build environment docs and playbook

+ scripts/ci/setup/inventory.template| 1 + 4 files changed, 159 insertions(+) create mode 100644 scripts/ci/setup/.gitignore create mode 100644 scripts/ci/setup/build-environment.yml create mode 100644 scripts/ci/setup/inventory.template Reviewed-by: Wainer dos Santos Moschetta diff

Re: [PATCH 3/3] cirrus: delete FreeBSD and macOS jobs

-by: Wainer dos Santos Moschetta diff --git a/.cirrus.yml b/.cirrus.yml index f4bf49b704..02c43a074a 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -1,61 +1,6 @@ env: CIRRUS_CLONE_DEPTH: 1 -freebsd_12_task: - freebsd_instance: -image_family: freebsd-12-2 -cpu: 8 -memory: 8G

Re: [PATCH 2/3] gitlab: support for FreeBSD 12, 13 and macOS 11 via cirrus-run

Hi, On 6/25/21 2:22 PM, Daniel P. Berrangé wrote: This adds support for running 4 jobs via Cirrus CI runners: * FreeBSD 12 * FreeBSD 13 * macOS 11 with default XCode * macOS 11 with latest XCode The gitlab job uses a container published by the libvirt-ci project

[PATCH] python: Configure tox to skip missing interpreters

. This changed the tox setup so that missing interpreters are skipped by default. On the CI, however, we still want to enforce it tests against all supported. This way on CI the --skip-missing-interpreters=false option is passed to tox. Signed-off-by: Wainer dos Santos Moschetta --- Tested locally

Re: [PATCH v2 07/12] python: update help text for check-tox

On 6/29/21 6:27 PM, John Snow wrote: On Tue, Jun 29, 2021 at 4:25 PM Wainer dos Santos Moschetta mailto:waine...@redhat.com>> wrote: Hi John, On 6/29/21 1:42 PM, John Snow wrote: > Move it up near the check-pipenv help text, and update it to sugge

Re: [PATCH v3 15/15] python: Fix broken ReST docstrings

| 2 +- 5 files changed, 8 insertions(+), 6 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/qemu/machine/__init__.py b/python/qemu/machine/__init__.py index 728f27adbe..9ccd58ef14 100644 --- a/python/qemu/machine/__init__.py +++ b/python/qemu/machine/__init__.py @@ -

Re: [PATCH v3 11/15] python: add 'make check-dev' invocation

itignore, too. Not worth an entire respin for that. (Assuming that's gonna be A-OK with both of you.) Acked-by: Wainer dos Santos Moschetta

Re: [PATCH v3 10/15] python: only check qemu/ subdir with flake8

-- python/tests/flake8.sh | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) Tested-by: Wainer dos Santos Moschetta Reviewed-by: Wainer dos Santos Moschetta How I tested it: $ make check-dev VENV .dev-venv ACTIVATE .dev-venv INSTALL qemu[devel] .dev-venv ACTIVATE .dev-venv make[1]: Entering

Re: [PATCH v3 11/15] python: add 'make check-dev' invocation

, 33 insertions(+), 2 deletions(-) Tested-by: Wainer dos Santos Moschetta Reviewed-by: Wainer dos Santos Moschetta It was tested as I mentioned on patch 10. diff --git a/python/Makefile b/python/Makefile index d34c4e35d9..8f8e1999c0 100644 --- a/python/Makefile +++ b/python/Makefile @@ -1,3

Re: [PATCH v3 01/15] python/qom: Do not use 'err' name at module scope

that check-pipenv and check-tox both have their place :) Signed-off-by: John Snow --- python/qemu/qmp/qom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/qemu/qmp/qom.py b/python/qemu/qmp/qom.py index 7ec7843d57

Re: [PATCH v2 07/12] python: update help text for check-tox

Hi John, On 6/29/21 1:42 PM, John Snow wrote: Move it up near the check-pipenv help text, and update it to suggest parity. (At the time I first added it, I wasn't sure if I would be keeping it, but I've come to appreciate it as it has actually helped uncover bugs I would not have noticed

Re: [PATCH v2 09/12] python: add 'make check-dev' invocation

On 6/29/21 1:42 PM, John Snow wrote: This is a *third* way to run the Python tests. Unlike the first two (check-pipenv, check-tox), this version does not require any specific interpreter version -- making it a lot easier to tell people to run it as a quick smoketest prior to submission to

Re: [PATCH v2 08/12] python: Fix .PHONY Make specifiers

/Makefile | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) I didn't know .PHONY could be split. Nice! Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/Makefile b/python/Makefile index d2cfa6ad8f..d34c4e35d9 100644 --- a/python/Makefile +++ b/python/Makefile @@ -1,5 +1,4

Re: [PATCH 07/11] python: update help text for check-tox

On 6/29/21 12:40 PM, John Snow wrote: On Mon, Jun 28, 2021 at 5:16 PM Wainer dos Santos Moschetta mailto:waine...@redhat.com>> wrote: Hi, On 6/25/21 12:45 PM, John Snow wrote: > Move it up near the check-pipenv help text, and update it to sugge

Re: [PATCH v2 07/12] python: update help text for check-tox

it. It should stay.) Signed-off-by: John Snow Reviewed-by: Willian Rampazzo --- python/Makefile | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/Makefile b/python/Makefile index 07ad73ccd0..d2cfa6ad8f 100644

Re: [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

On 6/28/21 5:38 PM, John Snow wrote: On Mon, Jun 28, 2021 at 4:31 PM Wainer dos Santos Moschetta mailto:waine...@redhat.com>> wrote: On 6/25/21 12:45 PM, John Snow wrote: > tox is already testing the most recent versions. Let's use pipenv to > test the oldest versi

Re: [PATCH 11/11] python: remove auto-generated pyproject.toml file

'make clean' target, and also delete it after every pipenv invocation issued by the Makefile. Signed-off-by: John Snow --- python/Makefile | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/Makefile b/python/Makefile index 06f78f760

Re: [PATCH 10/11] python: Update help text on 'make clean', 'make distclean'

; from 'make clean'." + @echo "make distclean:" + @echo "remove pipenv/venv files, qemu package forwarder," + @echo "built distribution files, and everything from 'make clean'." + @echo "" + @echo -e "Have a nice day ^_^\n" Devs will like the last message. ;) Reviewed-by: Wainer dos Santos Moschetta pipenv: .venv .venv: Pipfile.lock

Re: [PATCH 09/11] python: Update help text on 'make check', 'make develop'

On 6/25/21 12:45 PM, John Snow wrote: Update for visual parity with the other targets. Signed-off-by: John Snow --- python/Makefile | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/Makefile b/python/Makefile

Re: [PATCH 08/11] python: add 'make check-venv' invocation

On 6/25/21 12:45 PM, John Snow wrote: This is a *third* way to run the Python tests. Unlike the first two (check-pipenv, check-tox), this version does not require any specific interpreter version -- making it a lot easier to tell people to run it as a quick smoketest prior to submission to

Re: [PATCH 07/11] python: update help text for check-tox

Hi, On 6/25/21 12:45 PM, John Snow wrote: Move it up near the check-pipenv help text, and update it to suggest parity. (At the time I first added it, I wasn't sure if I would be keeping it, but I've come to appreciate it as it has actually helped uncover bugs I would not have noticed without

Re: [PATCH 06/11] python: rename 'venv-check' target to 'check-pipenv'

insertions(+), 12 deletions(-) I also agree pipenv/check-pipenvit is a better name. Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/README.rst b/python/README.rst index d4502fdb60..9c1fceaee7 100644 --- a/python/README.rst +++ b/python/README.rst @@ -79,7 +79,7 @@ Files in this

Re: [PATCH 05/11] python: Add no-install usage instructions

On 6/25/21 12:45 PM, John Snow wrote: It's not encouraged, but it's legitimate to want to know how to do. Signed-off-by: John Snow --- python/README.rst | 28 1 file changed, 28 insertions(+) Reviewed-by: Wainer dos Santos Moschetta diff --git a/python

Re: [PATCH 04/11] python: README.rst touchups

fewer run-on sentences. Signed-off-by: John Snow --- python/README.rst | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/README.rst b/python/README.rst index dcf993819d..107786ffdc 100644 --- a/python/README.rst

Re: [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

t coverage is worthwhile.) Signed-off-by: John Snow --- python/Pipfile.lock | 113 +--- python/setup.cfg| 4 +- 2 files changed, 56 insertions(+), 61 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/Pipfile.lock b/python/Pipfile.

Re: [PATCH 02/11] python: Remove global pylint suppressions

(+), 3 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index b62435528e..e3345dfa1b 100644 --- a/python/qemu/machine/machine.py +++ b/python/qemu/machine/machine.py @@ -84,6 +84,7 @@ class QEMUMachine

Re: [PATCH 01/11] python: expose typing information via PEP 561

/py.typed Just double-checking that you did not add a single py.typed on the root "python" dir, so that all modules inherit from it, because this is a namespace package. Right? Anyway, Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/qemu/machine/py.typed b/python/qe

Re: [PATCH 5/5] tests/acceptance: Test PMON on the Fuloong 2E machine

| CANCEL 0 JOB TIME : 5.10 s Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/machine_mips_fuloong2e.py | 62 ++ 1 file changed, 62 insertions(+) Need to fix the commit message (or the code) as pointed above. With that, Reviewed-by: Wainer dos Santos

Re: [PATCH 4/5] tests/acceptance: Test Linux on the Fuloong 2E machine

insertions(+) create mode 100644 tests/acceptance/machine_mips_fuloong2e.py Reviewed-by: Wainer dos Santos Moschetta diff --git a/MAINTAINERS b/MAINTAINERS index 1a041eaf864..1c515b4ba14 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1176,6 +1176,7 @@ F: hw/isa/vt82c686.c F: hw/pci-host/bonito.c

Re: [PATCH v3 2/3] avocado_qemu: Add SMMUv3 tests

Hi, On 6/21/21 5:08 AM, Eric Auger wrote: Add new tests checking the good behavior of the SMMUv3 protecting 2 virtio pci devices (block and net). We check the guest boots and we are able to install a package. Different guest configs are tested: standard, passthrough an strict=0. This is tested

Re: [PATCH v3 1/3] Acceptance Tests: Add default kernel params and pxeboot url to the KNOWN_DISTROS collection

Hi Eric, On 6/21/21 5:08 AM, Eric Auger wrote: When running LinuxTests we may need to run the guest with custom params. It is practical to store the pxeboot URL and the default kernel params so that the tests just need to fetch those and augment the kernel params. Signed-off-by: Eric Auger

Re: [PATCH] tests/vm/freebsd: Increase code coverage

Hi, On 6/15/21 2:19 PM, Daniel P. Berrangé wrote: On Tue, Jun 15, 2021 at 06:02:02PM +0100, Daniel P. Berrangé wrote: On Mon, May 31, 2021 at 05:53:25PM -0300, Wainer dos Santos Moschetta wrote: Hi, On 5/31/21 7:03 AM, Philippe Mathieu-Daudé wrote: Install more dependencies to increase code

Re: [PATCH v3 0/7] tests/acceptance: Handle tests with "cpu" tag

Changes: - v2 -> v3: - The arg and value parameters of set_vm_arg() are now mandatories and fixed an index out of bounds bug [crosa] - Rebased. Needed to adapt the (new) boot_xen.py test (patch 03) - v1 -> v2: - Recognize the cpu value passed via test parameter [crosa] - F

Re: [PATCH 2/4] Python QEMU utils: introduce a generic feature list

Hi, On 6/8/21 8:55 PM, Cleber Rosa Junior wrote: On Tue, Jun 8, 2021 at 5:42 PM Wainer dos Santos Moschetta mailto:waine...@redhat.com>> wrote: Hi, On 6/8/21 11:09 AM, Cleber Rosa wrote: > Which can be used to check for any "feature" that is available as a

Re: [PATCH 2/4] Python QEMU utils: introduce a generic feature list

Hi, On 6/8/21 11:09 AM, Cleber Rosa wrote: Which can be used to check for any "feature" that is available as a QEMU command line option, and that will return its list of available options. This is a generalization of the list_accel() utility function, which is itself re-implemented in terms of

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

Hi, On 6/8/21 10:36 AM, Cleber Rosa Junior wrote: On Tue, Jun 8, 2021 at 2:30 AM Philippe Mathieu-Daudé > wrote: Hi Alex, Stefan, On 6/8/21 5:14 AM, Cleber Rosa wrote: > The QEMU project has two machines (aarch64 and s390x) that can be used > for

Re: [PATCH v6 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

Hi, On 6/8/21 12:14 AM, Cleber Rosa wrote: To have the jobs dispatched to custom runners, gitlab-runner must be installed, active as a service and properly configured. The variables file and playbook introduced here should help with those steps. The playbook introduced here covers the Linux

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

Hi, On 6/8/21 12:14 AM, Cleber Rosa wrote: To run basic jobs on custom runners, the environment needs to be properly set up. The most common requirement is having the right packages installed. The playbook introduced here covers the QEMU's project s390x and aarch64 machines. At the time this

Re: [PATCH v6 1/4] Jobs based on custom runners: documentation and configuration placeholder

44 insertions(+) create mode 100644 .gitlab-ci.d/custom-runners.yml create mode 100644 docs/devel/ci.rst Reviewed-by: Wainer dos Santos Moschetta diff --git a/.gitlab-ci.d/custom-runners.yml b/.gitlab-ci.d/custom-runners.yml new file mode 100644 index 00..a07b27384c --- /dev/

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

Hi, On 6/8/21 12:14 AM, Cleber Rosa wrote: The QEMU project has two machines (aarch64 and s390x) that can be used for jobs that do build and run tests. This introduces those jobs, which are a mapping of custom scripts used for the same purpose. Signed-off-by: Cleber Rosa ---

Re: [RFC PATCH] scripts/checkpatch: roll diff tweaking into checkpatch itself

--- .patchew.yml | 3 --- ah, there is the patchew configuration file. scripts/checkpatch.pl | 7 ++- 3 files changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml

Re: [RFC PATCH] gitlab: work harder to avoid false positives in checkpatch

...@redhat.com/testing.checkpatch/?type=message Assuming patchew has been doing the right thing, I think it is a good idea to configure Git alike on CI. Thus: Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Alex Bennée --- .gitlab-ci.d/static_checks.yml | 6 +- 1 file changed

Re: [PATCH] tests/vm/freebsd: Increase code coverage

Hi, On 5/31/21 7:03 AM, Philippe Mathieu-Daudé wrote: Install more dependencies to increase code coverage. Signed-off-by: Philippe Mathieu-Daudé --- tests/vm/freebsd | 5 + 1 file changed, 5 insertions(+) With or without this patch I got an error when `make vm-build-freebsd`. It

Re: [PATCH] tests: Boot and halt a Linux guest on the Raspberry Pi 2 machine

failed on the VM's shutdown (as expected, I suppose). The test code looks good to me, so: Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py index 276a53f1464..19d328203c7 100644 --- a/tests/acce

Re: [PATCH 2/2] tests/acceptance: Add tests for the Pegasos2 machine

Hi, On 5/15/21 10:45 AM, Philippe Mathieu-Daudé wrote: Add a pair of tests for the Pegasos2 machine following the steps from: https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg01553.html $ PEGASOS2_ROM_PATH=/tmp/pegasos2.rom AVOCADO_ALLOW_UNTRUSTED_CODE=1 \ avocado

Re: [PATCH 1/2] tests/acceptance: Ignore binary data sent on serial console

a (all current tests compare text string anyway). Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta diff --gi

Re: [PATCH 1/1] tests/acceptance: change armbian archive to a faster host

:44. Maybe it was a temporary issue with the old host or maybe GitLab's runner network? Anyway, Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Willian Rampazzo --- tests/acceptance/boot_linux_console.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests

Re: [PATCH v3 3/6] gitlab-ci: Run GNU make via the $MAKE variable

t;/builds/dTyar424/0/qemu/build/Makefile" line 4: Missing dependency operator Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/buildtest-template.yml | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/.gitlab-

Re: [PATCH v3 2/6] gitlab-ci: Adapt JOBS variable for FreeBSD runners

Hi, On 5/19/21 3:45 PM, Philippe Mathieu-Daudé wrote: 'nproc' is not available on FreeBSD: $ JOBS=$(expr $(nproc) + 1) bash: line 119: nproc: command not found expr: syntax error Instead, use 'sysctl -n hw.ncpu'. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v3 1/6] gitlab-ci: Extract _variables template

Hi, On 5/19/21 3:45 PM, Philippe Mathieu-Daudé wrote: To be able to set the same environment variables to multiple jobs, extract what we currently have as a template. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/buildtest-template.yml | 7 +-- 1 file changed, 5 insertions(+),

Re: [PATCH 05/10] python/machine: Disable pylint warning for open() in _pre_launch

block. E.g.:     # pylint: disable=consider-using-with     self._qemu_log_file = open(self._qemu_log_path, 'wb')     # pylint: enable=consider-using-with However I don't know if this is bad practice. :) Reviewed-by: Wainer dos Santos Moschetta _post_shutdown is called after failed launches

Re: [PATCH 03/10] python/machine: use subprocess.run instead of subprocess.Popen

Hi, On 5/12/21 6:46 PM, John Snow wrote: use run() instead of Popen() -- to assert to pylint that we are not forgetting to close a long-running program. Signed-off-by: John Snow --- python/qemu/machine.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH 6/7] tests/acceptance: Move wait_for_console_pattern to ConsoleMixIn

on the LinuxKernelTest class, and that explains the explict calls to ConsoleMixIn.wait_for_console_pattern(). Likewise in boot_xen.py file. 2) In virtiofs_submounts.py, wait_for_console_pattern() was imported but not used. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance

[PATCH 7/7] tests/acceptance: Move _console_interaction to ConsoleMixIn

This moved the last remaining _console_interaction() to ConsoleMixIn. None tests call it directly, so only the other methods in ConsoleMixIn needed to be adapted. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/avocado_qemu/__init__.py | 57 +++ 1 file

[PATCH 3/7] tests/acceptance: Move exec_command_and_wait_for_pattern to ConsoleMixIn

It was the time of exec_command_and_wait_for_pattern() to find a new home at ConsoleMixIn. This time various tests needed to be adapted. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/avocado_qemu/__init__.py | 29 +++--- tests/acceptance/boot_linux_console.py | 107

[PATCH 0/7] tests/acceptance: Introducing the ConsoleMixIn

introduced by Cleber in [1]. This series was tested on CI (https://gitlab.com/wainersm/qemu/-/pipelines/296412039) [1] http://next.patchew.org/QEMU/20210412044644.55083-1-cr...@redhat.com/ Wainer dos Santos Moschetta (7): tests/acceptance: Introduce the ConsoleMixIn class tests/accept

[PATCH 1/7] tests/acceptance: Introduce the ConsoleMixIn class

to ConsoleMixIn. This method is only used in boot_linux_console.py tests, so there was needed to adapt them. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/avocado_qemu/__init__.py | 52 +++ tests/acceptance/boot_linux_console.py| 10 ++--- 2 files changed, 31

[PATCH 5/7] tests/acceptance: replay_kernel: Remove unused wait_for_console_pattern

The ReplayKernelBase class uses the wait_for_console_pattern from its parent LinuxKernelTest class, thus it doesn't need to import that method from avocado_qemu. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/replay_kernel.py | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 2/7] tests/acceptance: Move exec_command to ConsoleMixIn

This moved exec_command() to ConsoleMixIn class. Only the multiprocess.py file were touched by that change, so its tests were adapted. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/avocado_qemu/__init__.py | 22 ++ tests/acceptance/multiprocess.py

[PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest

, and the module has a docstring now. Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/machine_sparc64_sun4u.py | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/machine_sparc64_sun4u.py b/tests/acceptance/machine_sparc64_sun4u.py index

[PATCH v3 4/7] tests/acceptance: Tagging tests with "cpu:VALUE"

The existing tests which are passing "-cpu VALUE" argument to the vm object are now properly "cpu:VALUE" tagged, so letting the avocado_qemu framework to handle that automatically. Reviewed-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santos M

[PATCH v3 0/7] tests/acceptance: Handle tests with "cpu" tag

and value parameters of set_vm_arg() are now mandatories and fixed an index out of bounds bug [crosa] - Rebased. Needed to adapt the (new) boot_xen.py test (patch 03) - v1 -> v2: - Recognize the cpu value passed via test parameter [crosa] - Fixed tags (patch 02) on preparation to

[PATCH v3 3/7] tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests

igned-off-by: Wainer dos Santos Moschetta --- tests/acceptance/boot_linux.py | 3 --- tests/acceptance/boot_xen.py | 1 - tests/acceptance/machine_mips_malta.py | 1 - tests/acceptance/replay_kernel.py | 8 +++- tests/acceptance/reverse_debugging.py | 2 +- tests/accep

[PATCH v3 7/7] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests

-off-by: Wainer dos Santos Moschetta --- tests/acceptance/x86_cpu_model_versions.py | 40 +- 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/tests/acceptance/x86_cpu_model_versions.py b/tests/acceptance/x86_cpu_model_versions.py index 77ed8597a4..0e9feda62d

[PATCH v3 5/7] python/qemu: Add args property to the QEMUMachine class

This added the args property to QEMUMachine so that users of the class can access and handle the list of arguments to be given to the QEMU binary. Reviewed-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santos Moschetta --- python/qemu/machine.py | 5 + 1 file

[PATCH v3 1/7] tests/acceptance: Automatic set -cpu to the test vm

_sock_pdgzbgd_/qemu-1135557-monitor.sock \ -mon chardev=mon,mode=control -cpu host Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santos Moschetta --- docs/devel/testing.rst| 17 + tests/acceptanc

[PATCH v3 2/7] tests/acceptance: Fix mismatch on cpu tagged tests

There are test cases on machine_mips_malta.py and tcg_plugins.py files where the cpu tag does not correspond to the value actually given to the QEMU binary. This fixed those tests tags. Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos

[PATCH v3 6/7] tests/acceptance: Add set_vm_arg() to the Test class

The set_vm_arg method is added to avocado_qemu.Test class on this change. Use that method to set (or replace) an argument to the list of arguments given to the QEMU binary. Suggested-by: Cleber Rosa Signed-off-by: Wainer dos Santos Moschetta --- tests/acceptance/avocado_qemu/__init__.py | 21

Re: [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone

Hi, On 4/29/21 5:33 AM, Philippe Mathieu-Daudé wrote: Add a job which builds virtiofsd without any emulation or tool. Signed-off-by: Philippe Mathieu-Daudé --- https://gitlab.com/philmd/qemu/-/jobs/1222007991 Duration: 7 minutes 48 seconds --- .gitlab-ci.yml | 13 + 1 file

Re: [PATCH] tests/migration: fix unix socket migration

Cleber, Maybe you could review then queue this one? - Wainer On 4/20/21 10:16 PM, Hyman Huang wrote: 在 2021/3/10 0:55, Philippe Mathieu-Daudé 写道: On 3/9/21 5:00 PM, huang...@chinatelecom.cn wrote: From: Hyman The test aborts and error message as the following be throwed: "No such file or

Re: [PATCH v2 1/7] tests/acceptance: Automatic set -cpu to the test vm

Hi, On 4/21/21 5:16 PM, Cleber Rosa wrote: On Thu, Apr 08, 2021 at 04:52:31PM -0300, Wainer dos Santos Moschetta wrote: This introduces a new feature to the functional tests: automatic setting of the '-cpu VALUE' option to the created vm if the test is tagged with 'cpu:VALUE'. The 'cpu

Re: [PATCH 2/3] Acceptance Tests: move definition of distro checksums to the framework

Hi, On 4/19/21 3:35 PM, Cleber Rosa wrote: On Mon, Apr 19, 2021 at 12:25:44PM -0300, Wainer dos Santos Moschetta wrote: Hi, On 4/14/21 7:14 PM, Cleber Rosa wrote: Instead of having, by default, the checksum in the tests, and the definition of tests in the framework, let's keep them together

Re: [PATCH 7/8] tests/acceptance/migration.py: cancel test on s390x

, 6 insertions(+) Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py index b4d46becc6..4174d55c81 100644 --- a/tests/acceptance/migration.py +++ b/tests/acceptance/migration.py @@ -48,6 +48,12 @@ def do_migrate(self, dest_uri

Re: [PATCH 4/8] tests/acceptance/migration.py: cancel test if migration is not supported

Hi, On 4/15/21 6:51 PM, Cleber Rosa wrote: FIXME: check if there's a way to query migration support before actually requesting migration. Some targets/machines contain devices that do not support migration. Let's acknowledge that and cancel the test as early as possible. Signed-off-by: Cleber

Re: [PATCH 6/8] Acceptance tests: prevent shutdown on non-specific target tests

Hi, On 4/15/21 6:51 PM, Cleber Rosa wrote: When running tests that are not target specific with various target binaries, some specific behavior appears. For s390x, when there's no guest code running, it will produce GUEST_PANICKED events as the firmware will shutdown the machine. With this

Re: [PATCH 5/8] tests/acceptance/cpu_queries.py: use the proper logging channels

two `for c in cpus` loops? :D Anyway, Reviewed-by: Wainer dos Santos Moschetta

Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

On 4/16/21 2:46 PM, Philippe Mathieu-Daudé wrote: On 4/16/21 5:43 PM, Cleber Rosa wrote: On Fri, Apr 16, 2021 at 07:26:05AM +0200, Philippe Mathieu-Daudé wrote: On 4/15/21 11:51 PM, Cleber Rosa wrote: These tests' setUp do not do anything beyong what their base class do. And while they do

Re: [PATCH 2/8] Acceptance tests: do not try to reuse packages from the system

Rosa --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/tests/Makefile.include b/tests/Makefile.include index 8f220e15d1..63477c8b4b 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include

Re: [PATCH 2/3] Acceptance Tests: move definition of distro checksums to the framework

Hi, On 4/14/21 7:14 PM, Cleber Rosa wrote: Instead of having, by default, the checksum in the tests, and the definition of tests in the framework, let's keep them together. A central definition for distributions is available, and it should allow other known distros to be added more easily. No

Re: [PATCH 1/3] Acceptance Tests: rename attribute holding the distro image checksum

parameters, attributes and tags, let's make the naming of those more uniform. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 4 ++-- tests/acceptance/boot_linux.py| 8 2 files changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Wainer dos

Re: [PATCH 08/15] gitlab-ci: Extract DCO/style check jobs to checks.yml

On 4/19/21 2:26 AM, Thomas Huth wrote: On 19/04/2021 01.34, Philippe Mathieu-Daudé wrote: Extract the DCO / checkpatch jobs to a new file (checks.yml) to be able to run them without having to run all the jobs included in the default .gitlab-ci.yml, which are mainly useful for mainstream CI.

Re: [PATCH 1/1] Acceptance Tests: bump Avocado version requirement to 87.0

+- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Wainer dos Santos Moschetta diff --git a/tests/requirements.txt b/tests/requirements.txt index 91f3a343b9..f57e895c4a 100644 --- a/tests/requirements.txt +++ b/tests/requirements.txt @@ -1,5 +1,5 @@ # Add Python module requirements

Re: [PATCH v3 11/11] tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey

On 4/12/21 1:46 AM, Cleber Rosa wrote: The public key argument should be a path to a file, and not the public key data. Reported-by: Wainer dos Santos Moschetta Signed-off-by: Cleber Rosa --- tests/acceptance/virtiofs_submounts.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 0/3] tests/acceptance: Handle tests with "cpu" tag

Hi, On 4/7/21 5:01 PM, Eduardo Habkost wrote: On Tue, Mar 23, 2021 at 05:01:09PM -0400, John Snow wrote: On 3/17/21 3:16 PM, Wainer dos Santos Moschetta wrote: Added John and Eduardo, On 3/9/21 3:52 PM, Cleber Rosa wrote: On Wed, Feb 24, 2021 at 06:26:51PM -0300, Wainer dos Santos Moschetta

  1   2   3   4   5   6   >