Re: [Qemu-devel] [PATCH 0/2] convert device initialization functions

, Wei, Jiangang wrote: > Ping again ... > May I ask for some attention for these two patches？ > > Thanks > wei > On Thu, 2016-06-30 at 03:36 +0000, Wei, Jiangang wrote: > > Ping > > These two patches seem to be forgotten ... > > > > On Tue, 201

Re: [Qemu-devel] [PATCH 0/2] convert device initialization functions

Ping again ... May I ask for some attention for these two patches？ Thanks wei On Thu, 2016-06-30 at 03:36 +, Wei, Jiangang wrote: > Ping > These two patches seem to be forgotten ... > > On Tue, 2016-05-17 at 18:18 +0800, Wei Jiangang wrote: > > The first had been reviewed.

Re: [Qemu-devel] [PATCH 0/2] convert device initialization functions

Ping These two patches seem to be forgotten ... On Tue, 2016-05-17 at 18:18 +0800, Wei Jiangang wrote: > The first had been reviewed. > The second had been posted last month, but no feedback. > They're similar, so resend them together. > > Wei Jiangang (2): > hw/pci-b

Re: [Qemu-devel] [PATCH] block/raw-posix: Fix error_report of mounting message

On Fri, 2016-06-03 at 17:00 +0800, Fam Zheng wrote: > On Thu, 06/02 10:46, Wei, Jiangang wrote: > > My intention is only to avoid the output of multiple location > > information. > > Then I think this should have gone into the commit message. OK, I'll make more detaile

Re: [Qemu-devel] [PATCH] block/raw-posix: Fix error_report of mounting message

On Thu, 2016-06-02 at 09:57 +0200, Markus Armbruster wrote: > Wei Jiangang <weijg.f...@cn.fujitsu.com> writes: > > > Use a single error_printf to replace triple error_report. > > > > Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> > > --- > >

Re: [Qemu-devel] [PATCH] block/raw-posix: Fix error_report of mounting message

On Wed, 2016-06-01 at 15:23 +0800, Fam Zheng wrote: > On Wed, 06/01 15:08, Wei Jiangang wrote: > > Use a single error_printf to replace triple error_report. > > > > Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> > > --- > > block/raw-posix.c

[Qemu-devel] [PATCH] block/raw-posix: Fix error_report of mounting message

Use a single error_printf to replace triple error_report. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- block/raw-posix.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index a4f5a1b..141b01a 100644 --- a

Re: [Qemu-devel] [PATCH 0/2] convert device initialization functions

Ping Any comments? Thanks in advance. On Tue, 2016-05-17 at 18:18 +0800, Wei Jiangang wrote: > The first had been reviewed. > The second had been posted last month, but no feedback. > They're similar, so resend them together. > > Wei Jiangang (2): > hw/pci-b

Re: [Qemu-devel] [PATCH] docs/multi-thread-compression: Fix wrong command string

Add qemu-trivial <qemu-triv...@nongnu.org> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Liang Li <liang.z...@intel.com> Thanks, wei On Mon, 2016-05-23 at 17:43 +0800, Wei Jiangang wrote: > s/info_migrate_capabilities/info migrate_capabilities > >

[Qemu-devel] RFC: do we need ordered dict?

Hi all, I found a problem about the output of 'query-version' As the qmp-command.hx said, it shoud be -> { "execute": "query-version" } <- { "return":{ "qemu":{ "major":0, "minor":11, "micro":5 }, "package":"" } }

[Qemu-devel] [PATCH] docs/multi-thread-compression: Fix wrong command string

s/info_migrate_capabilities/info migrate_capabilities Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- docs/multi-thread-compression.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/multi-thread-compression.txt b/docs/multi-thread-compression.txt

Re: [Qemu-devel] [PATCH 0/2] convert device initialization functions

received hint that Message to <*@redhat.com> was undeliverable. ping to confirm my message had been sent successfully. On Tue, 2016-05-17 at 18:18 +0800, Wei Jiangang wrote: > The first had been reviewed. > The second had been posted last month, but no feedback. > They're similar,

Re: [Qemu-devel] [PATCH] configure: fix error messages

ping ... Any comments? On Tue, 2016-05-10 at 18:13 +0800, Wei Jiangang wrote: > spice-server-devel is required, not spice-protocol-devel. > "spice-protocol(>=0.12.3) devel" maybe mislead user. > > when configure isn't able to find the required usb-redir, > It's better

[Qemu-devel] [PATCH 0/2] convert device initialization functions

The first had been reviewed. The second had been posted last month, but no feedback. They're similar, so resend them together. Wei Jiangang (2): hw/pci-bridge: Convert pxb initialization functions to Error apb: convert init to realize hw/pci-bridge/pci_expander_bridge.c | 52

[Qemu-devel] [PATCH 1/2] hw/pci-bridge: Convert pxb initialization functions to Error

-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> Reviewed-by: Marcel Apfelbaum <mar...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Michael S. Tsirkin <m...@redhat.com> --- hw/pci-bri

[Qemu-devel] [PATCH 2/2] apb: convert init to realize

Convert a device model where initialization obviously can't fail, make it implement realize() rather than init(). Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- hw/pci-host/apb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/apb.c b/hw/pc

[Qemu-devel] [PATCH] configure: fix error messages

spice-server-devel is required, not spice-protocol-devel. "spice-protocol(>=0.12.3) devel" maybe mislead user. when configure isn't able to find the required usb-redir, It's better to explicitly output version requirement. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com

Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap

On Wed, 2016-04-27 at 06:44 +0300, Max Filippov wrote: > Hi Wei, > > On Wed, Apr 27, 2016 at 03:27:47AM +0000, Wei, Jiangang wrote: > > On Wed, 2016-04-27 at 10:07 +0800, Zhou Jie wrote: > > > static void open_eth_start_xmit(OpenEthState *s, desc *tx) > > >

Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap

On Wed, 2016-04-27 at 10:07 +0800, Zhou Jie wrote: > open_eth_start_xmit has a huge stack usage of 65536 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Zhou Jie > --- > hw/net/opencores_eth.c | 11 ++- > 1 file changed,

[Qemu-devel] [PATCH] iotests: fix the redirection order in 083

It should redirect stdout to /dev/null first, then redirect stderr to whatever stdout currently points at. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- tests/qemu-iotests/083 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/083 b

[Qemu-devel] [PATCH] apb: convert init to realize

Convert a device model where initialization obviously can't fail, make it implement realize() rather than init(). Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- hw/pci-host/apb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/apb.c b/hw/pc

[Qemu-devel] [PATCH] block: Fix typo in comment

s/imlement/implement/ Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index f1f520a..f74eb43 100644 --- a/blockdev.c +++ b/blockdev.c @@ -73,7 +73,7 @@ static int if_ma

Re: [Qemu-devel] [PATCH] rng-random: rename RndRandom to RngRandom

I'm not sure... Any comments and suggestions are welcome. Thanks in advance. On Fri, 2016-04-15 at 09:36 +0800, Wei Jiangang wrote: > Usually, Random Number Generator is abbreviated to RNG/rng. > so replacing RndRandom with RngRandom seems more reasonable > and keep consistent with R

[Qemu-devel] [PATCH] rng-random: rename RndRandom to RngRandom

Usually, Random Number Generator is abbreviated to RNG/rng. so replacing RndRandom with RngRandom seems more reasonable and keep consistent with RngBackend. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- backends/rng-random.c | 18 +- include/hw/

[Qemu-devel] [PATCH v2] accel: make configure_accelerator return void

Return the negated value of accel_initialised is meaningless, and the caller vl doesn't check it. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- accel.c| 4 +--- include/sysemu/accel.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/acc

Re: [Qemu-devel] [PATCH] accel: make configure_accelerator return void

On Thu, 2016-04-14 at 11:34 +0800, Changlong Xie wrote: > On 04/14/2016 11:19 AM, Wei, Jiangang wrote: > > ping... > > Any comments? > > On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote: > >> Return the negated value of accel_initialised is meaningless, > &

Re: [Qemu-devel] [PATCH] accel: make configure_accelerator return void

ping... Any comments? On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote: > Return the negated value of accel_initialised is meaningless, > and the caller vl doesn't check it. > > Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> > --- > accel.c | 4 +--- >

Re: [Qemu-devel] [PATCH 0/3] bitsized task for glib conversion

ping... Any comments? Thanks in advance. On Thu, 2016-04-07 at 10:46 +0800, Wei Jiangang wrote: > The series used to change basename and dirname to > g_path_get_basename() and g_path_get_dirname() respectively. > > Refer to http://wiki.qemu.org/BiteSizedTasks#API_conversion > &

Re: [Qemu-devel] [PATCH v2 0/2] Convert pxb initfn to Error

> > > On 03/23/2016 01:56 PM, Markus Armbruster wrote: > > > >> Wei Jiangang <weijg.f...@cn.fujitsu.com> writes: > > > >> > > > >>> v1 -> v2: > > > >>> > > > >>> - Extract a separate

[Qemu-devel] [PATCH v3 2/2] hw/pci-bridge: Convert pxb initialization functions to Error

-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> --- hw/pci-bridge/pci_expander_bridge.c | 52 ++--- 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/h

[Qemu-devel] [PATCH 3/3] use g_path_get_basename instead of basename

Using g_strdup and g_basename to get the last component of filename is not the best solution, Only g_path_get_basename can achive the purpose we want. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- fsdev/virtfs-proxy-helper.c | 6 +- hw/9pfs/9p-local.c | 6 +++-

[Qemu-devel] [PATCH 0/3] bitsized task for glib conversion

The series used to change basename and dirname to g_path_get_basename() and g_path_get_dirname() respectively. Refer to http://wiki.qemu.org/BiteSizedTasks#API_conversion *** BLURB HERE *** Wei Jiangang (3): linux-user: complete omission of removing uses of strdup use g_path_get_dirname

[Qemu-devel] [PATCH 1/3] linux-user: complete omission of removing uses of strdup

The 900cfbc just removed two unchecked uses of strdup in fill_psinfo and missed the rest in core_dump_filename. This patch fixes it. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- linux-user/elfload.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] [PATCH 2/3] use g_path_get_dirname instead of dirname

Use g_path_get_basename to get the directory components of a file name, and free its return when no longer needed. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- os-posix.c | 3 ++- util/oslib-posix.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH] docs: fix typo in memory.txt

On Wed, 2016-04-06 at 01:02 +0200, Paolo Bonzini wrote: > > On 22/03/2016 10:45, Wei Jiangang wrote: > > The scale line should align with A line's end, > > No, A ends at 0x7fff so the line should end just before. See what > happens for B/C/D/E. Yes, you're right.

Re: [Qemu-devel] [PATCH] docs: fix typo in memory.txt

ping... Any feedback？ On Tue, 2016-03-22 at 17:45 +0800, Wei Jiangang wrote: > The scale line should align with A line's end, > and correct the range of vga-window example 0xa-0xb. > > Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> > --- > docs/memory.

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci-bridge: Convert pxb initialization functions to Error

On Wed, 2016-03-23 at 13:05 +0100, Markus Armbruster wrote: > Wei Jiangang <weijg.f...@cn.fujitsu.com> writes: > > > Firstly, convert pxb_dev_init_common() to Error and rename > > it to pxb_dev_realize_common(). > > Actually, pxb_register_bus() is converted as well.

[Qemu-devel] [PATCH v3 2/2] hw/pci-bridge: Convert pxb initialization functions to Error

Firstly, convert pxb_dev_init_common() to Error and rename it to pxb_dev_realize_common(). Actually, pxb_register_bus() is converted as well. And then, convert pxb_dev_initfn() and pxb_pcie_dev_initfn() to Error, rename them to pxb_dev_realize() and pxb_pcie_dev_realize() respectively. ---

[Qemu-devel] [PATCH v3 0/2] Convert pxb initfn to Error

pxb-pcie: convert to realize() Wei Jiangang (2): hw/pci-bridge: Add missing unref in case register-bus fails hw/pci-bridge: Convert pxb initialization functions to Error hw/pci-bridge/pci_expander_bridge.c | 60 - 1 file changed, 33 insertions(+), 27 deletions(-) -- 1.9.3

[Qemu-devel] [PATCH v3 1/2] hw/pci-bridge: Add missing unref in case register-bus fails

The error paths after a successful qdev_create/pci_bus_new should contain a object_unref/object_unparent. pxb_dev_init_common() did not yet, so add it. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> --- h

[Qemu-devel] [PATCH v2 0/2] Convert pxb initfn to Error

by Marcel Apfelbaum <mar...@redhat.com>. It conflicts with 02b0743 that had been merged, so resend a newer version, including the following, hw/pci-bridge: modify pxb_dev_init_common pxb: convert to realize() pxb-pcie: convert to realize() Wei Jiangang (2): hw/pci-bridge: Add missin

[Qemu-devel] [PATCH v2 2/2] hw/pci-bridge: Convert pxb initialization functions to Error

-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> --- hw/pci-bridge/pci_expander_bridge.c | 51 + 1 file changed, 24 insertions(+), 27 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/h

[Qemu-devel] [PATCH v2 1/2] hw/pci-bridge: Add missing unref in case register-bus fails

The error paths after a successful qdev_create/pci_bus_new should contain a object_unref/object_unparent. pxb_dev_init_common() did not yet, so add it. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> --- h

[Qemu-devel] [PATCH] docs: fix typo in memory.txt

The scale line should align with A line's end, and correct the range of vga-window example 0xa-0xb. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- docs/memory.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/memory.txt b/docs/memo

[Qemu-devel] [PATCH] vl: fix comment about when parsing cpu definitions

machine->init() was replaced with machine_class->init(). Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 7a28982..3c403d1 100644 --- a/vl.c +++ b/vl.c @@ -4079,7 +4079,7 @@ int m

[Qemu-devel] [PATCH] accel: make configure_accelerator return void

Return the negated value of accel_initialised is meaningless, and the caller vl doesn't check it. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- accel.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/accel.c b/accel.c index 0510b90..403eb5e

[Qemu-devel] [PATCH 1/3] hw/pci-bridge: modify pxb_dev_init_common

1) add Error **errp parameter for it, 2) rename pxb_dev_init_common to pxb_dev_realize_common, and prepare for pxb/pxb-pcie convert to realize. 3) modify the callers, including pxb_dev_initfn and pxb_pcie_dev_initfn. Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> Signed-off-b

[Qemu-devel] [PATCH 3/3] pxb-pcie: convert to realize()

Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> --- hw/pci-bridge/pci_expander_bridge.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/h

[Qemu-devel] [PATCH 0/3] conversion to realize for pxb/pxb-pcie

The previous patch named '[PATCH v3] PXB: convert to realize()' was raised by Cao jin <caoj.f...@cn.fujitsu.com>, and reviewed by Marcel Apfelbaum <mar...@redhat.com>. It conflicts with 02b0743 that had been merged, so resend a newer version. Wei Jiangang (3): hw/pci-br

[Qemu-devel] [PATCH 2/3] pxb: convert to realize()

Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> --- hw/pci-bridge/pci_expander_bridge.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/h

[Qemu-devel] [PATCH v1] util: fix comment typos

Signed-off-by: Wei Jiangang <weijg.f...@cn.fujitsu.com> --- util/buffer.c | 4 ++-- util/qemu-sockets.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/util/buffer.c b/util/buffer.c index a6118bf..33e94d1 100644 --- a/util/buffer.c +++ b/util/buffer.c @@ -25,7