Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
Cc: Luiz Capitulino <lcapitul...@redhat.com>
---
hmp-commands.hx | 28 ++
OK
FAIL: tests/virtio-net-test
Do I make a mistake when I do rebase?
Thanks
Wen Congyang
> Signed-off-by: Eric Blake <ebl...@redhat.com>
> ---
> hw/arm/musicpal.c| 2 +-
> hw/core/qdev-properties-system.c | 2 +-
> hw/net/allwinner_
t; (I'm still working on other improvements, and may reshuffle patches
> before actually getting to v5).
>
> git fetch git://repo.or.cz/qemu/ericb.git qapi
> http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi
>
OK, I will try it. What is difference between start_struct() and
start_implicit_struct()?
Thanks
Wen Congyang
On 09/15/2015 07:12 PM, Markus Armbruster wrote:
> Wen Congyang <we...@cn.fujitsu.com> writes:
>
>> On 09/15/2015 03:37 PM, Markus Armbruster wrote:
>>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>>
>>>> On 09/14/2015 11:47 PM, Eric Blake
On 09/15/2015 03:49 PM, Markus Armbruster wrote:
> Wen Congyang <we...@cn.fujitsu.com> writes:
>
>> On 09/14/2015 10:36 PM, Markus Armbruster wrote:
>>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>>
>>>> Signed-off-by: Wen Congyang &l
On 09/15/2015 09:11 PM, Eric Blake wrote:
> On 09/14/2015 09:58 PM, Wen Congyang wrote:
>> On 09/15/2015 11:46 AM, Eric Blake wrote:
>>> On 09/14/2015 08:27 PM, Wen Congyang wrote:
>>>>> Building fails:
>>>>> GEN qmp-commands.h
>>>&
On 09/16/2015 04:17 PM, Paolo Bonzini wrote:
>
>
> On 16/09/2015 09:16, Wen Congyang wrote:
>> If the socket fd is shutdown, there may be some data which is received before
>> shutdown. We will read the data and do read/write in nbd_trip(). But the
>> exp's
>&g
If the socket fd is shutdown, there may be some data which is received before
shutdown. We will read the data and do read/write in nbd_trip(). But the exp's
blk is NULL, and it will cause qemu crashed.
Reported-by: Li Zhijian <lizhij...@cn.fujitsu.com>
Signed-off-by: Wen Congya
If the socket fd is shutdown, there may be some data which is received before
shutdown. We will read the data and do read/write in nbd_trip(). But the exp's
blk is NULL, and it will cause qemu crashed.
Reported-by: Li Zhijian <lizhij...@cn.fujitsu.com>
Signed-off-by: Wen Congya
On 09/16/2015 04:21 PM, Markus Armbruster wrote:
> Wen Congyang <we...@cn.fujitsu.com> writes:
>
>> On 09/15/2015 07:12 PM, Markus Armbruster wrote:
>>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>>
>>>> On 09/15/2015 03:37 PM, Markus Armb
On 09/16/2015 07:18 PM, Markus Armbruster wrote:
> Wen Congyang <we...@cn.fujitsu.com> writes:
>
>> On 09/16/2015 04:21 PM, Markus Armbruster wrote:
>>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>>
>>>> On 09/15/2015 07:12 PM, Markus Armb
e the QDict-based code such as
>> nbd_config() with the QAPI interfaces.
>
> ...but DO affect the short-term, by starting the conversion over to
> using the QAPI type more fully:
> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04383.html
The problem still exists
On 09/15/2015 03:49 PM, Markus Armbruster wrote:
> Wen Congyang <we...@cn.fujitsu.com> writes:
>
>> On 09/14/2015 10:36 PM, Markus Armbruster wrote:
>>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>>
>>>> Signed-off-by: Wen Congyang &l
On 09/15/2015 03:37 PM, Markus Armbruster wrote:
> Wen Congyang <we...@cn.fujitsu.com> writes:
>
>> On 09/14/2015 11:47 PM, Eric Blake wrote:
>>> On 09/14/2015 08:27 AM, Markus Armbruster wrote:
>>>> Wen Congyang <we...@cn.fujitsu.com> writes:
&g
On 09/14/2015 11:47 PM, Eric Blake wrote:
> On 09/14/2015 08:27 AM, Markus Armbruster wrote:
>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>
>>> The NBD driver needs: filename, path or (host, port, exportname).
>>> It checks which key exists and decides
On 09/14/2015 10:36 PM, Markus Armbruster wrote:
> Wen Congyang <we...@cn.fujitsu.com> writes:
>
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
>> Signed-off-by: Gonglei <a
On 09/15/2015 10:20 AM, Wen Congyang wrote:
> On 09/14/2015 11:47 PM, Eric Blake wrote:
>> On 09/14/2015 08:27 AM, Markus Armbruster wrote:
>>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>>
>>>> The NBD driver needs: filename, path or (host, port,
On 09/14/2015 11:47 PM, Eric Blake wrote:
> On 09/14/2015 08:27 AM, Markus Armbruster wrote:
>> Wen Congyang <we...@cn.fujitsu.com> writes:
>>
>>> The NBD driver needs: filename, path or (host, port, exportname).
>>> It checks which key exists and decides
On 09/14/2015 11:37 PM, Kevin Wolf wrote:
> Am 10.09.2015 um 11:55 hat Wen Congyang geschrieben:
>> +##
>> +# @x-child-add
>> +#
>> +# Add a new child to the parent BDS. Currently only the Quorum driver
>> +# implements this feature. This is useful to fix a broken
On 09/15/2015 11:46 AM, Eric Blake wrote:
> On 09/14/2015 08:27 PM, Wen Congyang wrote:
>>> Building fails:
>>> GEN qmp-commands.h
>>> In file included from /work/src/qemu/qapi-schema.json:9:
>>> In file included from /work/src/qemu/qapi/block.json:6:
On 09/11/2015 03:09 AM, Max Reitz wrote:
> On 10.09.2015 03:12, Wen Congyang wrote:
>> On 09/09/2015 08:59 PM, Max Reitz wrote:
>>> On 09.09.2015 12:01, Wen Congyang wrote:
>>>> On 09/09/2015 05:20 AM, Max Reitz wrote:
>>>>> On 08.09.2015 11:13, Wen
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
---
blockdev.c | 47 ++
qapi/bl
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
Cc: Luiz Capitulino <lcapitul...@redhat.com>
---
hmp-commands.hx | 28 ++
The NBD driver needs: filename, path or (host, port, exportname).
It checks which key exists and decides use unix or inet socket.
It doesn't recognize the key type, so we can't use union, and
can't reuse InetSocketAddress.
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Sign
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
---
block.c
On 09/10/2015 06:04 PM, Daniel P. Berrange wrote:
> On Thu, Sep 10, 2015 at 05:55:04PM +0800, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
>> Signed-off-by:
.
2. The driver NBD can support filename, path, host:port now.
v2:
1. Use bdrv_get_device_or_node_name() instead of new function
bdrv_get_id_or_node_name()
2. Update the error message
3. Update the documents in block-core.json
Wen Congyang (5):
support nbd driver in blockdev-add
Add new
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
---
block.c | 6 ++---
block/quorum.c| 72
On 09/03/2015 04:41 AM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: Yang Hongyang <yan...@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghaili...@h
On 09/03/2015 02:50 AM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> Usage:
>> -drive file=xxx,id=Y, \
>> -drive file=,id=X,backing.backing_reference=Y
>>
>> It will create such backing chain:
>>{virt
On 09/03/2015 12:36 AM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> ---
>> qapi/block-core.json | 18 --
>> 1 file changed, 16 insertions(+), 2 deletions(-)
>>
>
On 09/08/2015 11:52 PM, Eric Blake wrote:
> On 09/08/2015 03:10 AM, Wen Congyang wrote:
>
>>> Design-wise, I think we really want to have the add-child operation be
>>> handed a pre-opened BDS, rather than the options dictionary to open the
>>> BDS itself. Th
On 09/03/2015 12:33 AM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
>> Signed-off-by: Gonglei <arei.gong...@huawei.c
On 09/03/2015 12:06 AM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
>> Signed-off-by: Gonglei <arei.gong...@huawei.com>
On 09/09/2015 05:20 AM, Max Reitz wrote:
> On 08.09.2015 11:13, Wen Congyang wrote:
>> On 07/21/2015 01:45 AM, Max Reitz wrote:
>>> And a helper function for that, which directly takes a pointer to the
>>> BDS to be inserted instead of its node-name (which will be used f
On 09/09/2015 08:59 PM, Max Reitz wrote:
> On 09.09.2015 12:01, Wen Congyang wrote:
>> On 09/09/2015 05:20 AM, Max Reitz wrote:
>>> On 08.09.2015 11:13, Wen Congyang wrote:
>>>> On 07/21/2015 01:45 AM, Max Reitz wrote:
>>>>> And a helper func
On 09/09/2015 08:59 PM, Max Reitz wrote:
> On 09.09.2015 12:01, Wen Congyang wrote:
>> On 09/09/2015 05:20 AM, Max Reitz wrote:
>>> On 08.09.2015 11:13, Wen Congyang wrote:
>>>> On 07/21/2015 01:45 AM, Max Reitz wrote:
>>>>> And a helper func
name,
> +Error **errp)
> +{
> +BlockDriverState *bs;
> +
> +bs = bdrv_find_node(node_name);
> +if (!bs) {
> +error_setg(errp, "Node '%s' not found", node_name);
> +return;
> +}
Hmm, it is OK if the bs is no
On 09/01/2015 11:30 PM, Eric Blake wrote:
> On 08/31/2015 06:44 PM, Wen Congyang wrote:
>
>>>
>>>> + * Hot add/remove a BDS's child. So the user can take a child offline when
>>>> + * it is broken and take a new child online
>>>> + */
>>>
In some cases, we need to disable copy-on-read, and just
read the data.
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
---
block/io.c| 12 +++-
include/block/block.h | 9 ++---
trace-events | 1 +
3 files changed, 18 insertions(+), 4 deletions(-)
We will copy data in before_write_notifier to do backup.
It is a nested I/O request, so we cannot do copy-on-read.
The steps to reproduce it:
1. -drive copy-on-read=on,... // qemu option
2. drive_backup -f disk0 /path_to_backup.img // monitor command
Signed-off-by: Wen Congyang <
=32605) at
coroutine-ucontext.c:80
#16 0x7f5d69218be0 in __correctly_grouped_prefixwc () from /lib64/libc.so.6
#17 0x in ?? ()
Wen Congyang (2):
block: Introduce a new API bdrv_co_no_copy_on_readv()
Backup: don't do copy-on-read in before_write_notifier
block/backup.c
On 09/08/2015 12:56 AM, Dr. David Alan Gilbert wrote:
> * Eric Blake (ebl...@redhat.com) wrote:
>> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>>> If the child is not ready, read/write/getlength/flush will
>>> return -errno. It is not critical error, and can be
?
Thanks
Wen Congyang
>
> Signed-off-by: Max Reitz <mre...@redhat.com>
> ---
> blockdev.c | 48
> qapi/block-core.json | 17 +
> qmp-commands.hx | 37 +
&
ing:
1. adding/deleting children from a quorum dynamically
2. allow references for backing files
The BDS without BB only can be created by the monitor command blockdev-add.
How to create it in the command line?
Thanks
Wen Congyang
On 09/02/2015 11:37 PM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> ---
>> block/block-backend.c | 24
>> include/sysemu/block-backend.h | 2 ++
&
On 09/02/2015 11:00 PM, Eric Blake wrote:
> On 09/01/2015 07:25 PM, Wen Congyang wrote:
>> On 09/01/2015 11:34 PM, Eric Blake wrote:
>>> On 08/31/2015 06:55 PM, Wen Congyang wrote:
>>>
>>>>>> +This command is still a work in progress. It doesn't supp
On 09/03/2015 03:01 AM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
>> Signed-off-by: Gonglei <arei.gong...@huawei.com&
On 09/03/2015 12:30 AM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> If the child is not ready, read/write/getlength/flush will
>> return -errno. It is not critical error, and can be ignored:
>> 1. read/write:
>>Just not report the error even
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
Reviewed-by: Alberto Garcia <be...@igalia.com>
---
block/quorum.c | 77 +
When opening BDS, we need to create backup jobs for
image-fleecing.
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
Cc: Jeff Cody <jc...@redhat.com>
Revi
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
---
block.c | 12
1 file changed, 12 insertions(+)
diff --git a/block.c b/block.c
index c7670
'}
| |
| |
v v
[base] <- [mid] <- ( Y ) <- ( X )
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
---
from Max Reitz and Eric Blake
Wen Congyang (16):
introduce a new API to enable/disable attach device model
introduce a new API to check if blk is attached
allow writing to the backing file
block: Allow references for backing files
introduce a new API qemu_opts_absorb_qdict_by_index
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
---
block.c | 68 +++
include/block/block.h | 4 +++
2
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
---
include/qemu/option.h | 2 ++
util/qemu-option.c| 44
2
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
---
block.c | 25 +
blockdev.c| 37 ++---
include/block/block.h | 1 +
3 files changed, 32 insertions(+), 31 deletions(-)
diff --git a/block.c b/block.c
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: Yang Hongyang <yan...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
---
docs/blo
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
Cc: Jeff Cody <jc...@redhat.com>
---
block/backup.c | 14 ++
blockjob.c |
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
---
block/Makefile.objs | 1 +
block/replication.c | 471
2
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
---
block/block-backend.c | 24
include/sysemu/block-backend.h | 2 ++
2 files changed, 26 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index aee8a12..72d8b2c 100644
--- a
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
---
block.c| 4 ++--
block/block-backend.c | 9 +
include/sysemu/block-backend.h | 1 +
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 0f9029b..aeb365b
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
---
block.c | 41 -
qapi/block-core.json | 7 ++-
2
ignore it. If all children's getlength return -errno,
and be ignored, return 0.
Usage: children.x.ignore-errors=true
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.c
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Gonglei <arei.gong...@huawei.com>
Cc: Luiz Capitulino <lcapitul...@redhat.com>
Cc: Michael Roth <mdr...@linux.vnet.ibm.com>
Rev
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
---
qapi/block-core.json | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 96f0530..86275e3 100644
--- a/qapi/block-core.json
+++ b/qapi/block-cor
On 09/01/2015 11:34 PM, Eric Blake wrote:
> On 08/31/2015 06:55 PM, Wen Congyang wrote:
>
>>>> +This command is still a work in progress. It doesn't support all
>>>> +block drivers. Stay away from it unless you want it to help with
>>>> +its development
On 09/01/2015 01:19 AM, Eric Blake wrote:
> On 08/11/2015 01:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
>> Signed-off-by: Gonglei <arei.gong...@huawei
On 09/01/2015 01:40 AM, Eric Blake wrote:
> On 08/11/2015 01:51 AM, Wen Congyang wrote:
>> In some cases, we want to take a quorum child offline, and take
>> another child online.
>>
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-
On 09/01/2015 01:40 AM, Eric Blake wrote:
> On 08/11/2015 01:51 AM, Wen Congyang wrote:
>> In some cases, we want to take a quorum child offline, and take
>> another child online.
>>
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-
On 09/01/2015 02:53 AM, Eric Blake wrote:
> On 08/11/2015 01:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
>> Signed-off-by: Gonglei <arei.gong...@huawei
On 09/01/2015 03:04 AM, Eric Blake wrote:
> On 08/11/2015 01:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
>> Signed-off-by: Gonglei <arei.gong...@huawei.com&g
On 09/01/2015 03:04 AM, Eric Blake wrote:
> On 08/11/2015 01:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
>> Signed-off-by: Gonglei <arei.gong...@huawei.com&g
Ping...
Patch 1-4 have been reviewed by Alberto Garcia
Luiz Capitulino, Markus Armbruster, do you have time to review the monitor
command implementation?
Thanks
Wen Congyang
On 08/11/2015 03:51 PM, Wen Congyang wrote:
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off
. Is this wrong?
Thanks
Wen Congyang
On 08/20/2015 01:02 AM, Jeff Cody wrote:
On Wed, Aug 19, 2015 at 01:43:41PM +0800, Wen Congyang wrote:
On 08/19/2015 01:41 PM, Paolo Bonzini wrote:
On 18/08/2015 19:54, Wen Congyang wrote:
We will copy data in before_write_notifier to do backup.
It is a nested I/O request, so we cannot do
We will copy data in before_write_notifier to do backup.
It is a nested I/O request, so we cannot do copy-on-read.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
---
block/backup.c| 19 +--
block/io.c| 11 ++-
include/block/block.h | 3 +++
trace
Ping...
On 07/17/2015 10:12 AM, Wen Congyang wrote:
We use mirror+replace to fix quorum's broken child. bs/s-common.bs
is quorum, and to_replace is the broken child. The new child is target_bs.
Without this patch, the replace node can be any node, and it can be
top BDS with BB, or another
Ping...
On 07/03/2015 02:45 PM, Wen Congyang wrote:
We need to use threshold to check if too many write operation fails.
If threshold is larger than num children, we always get write error
event even if all write operations success.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
On 08/19/2015 01:41 PM, Paolo Bonzini wrote:
On 18/08/2015 19:54, Wen Congyang wrote:
We will copy data in before_write_notifier to do backup.
It is a nested I/O request, so we cannot do copy-on-read.
Can you explain why? What is the bug that this is fixing?
(gdb) bt
#0 0x7fd53a6cdb55
+
+EQMP
+
+{
+.name = netfilter_del,
+.args_type = id:s,
+.mhandler.cmd_new = qmp_marshal_input_netfilter_del,
+},
+
+SQMP
+netfilter_del
For qmp, the command should be netfilter-add/netfilter-del.
Thanks
Wen Congyang
+--
+
+Remove
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Cc: Luiz Capitulino lcapitul...@redhat.com
---
blockdev.c| 33 +
hmp-commands.hx
message
3. Update the documents in block-core.json
Wen Congyang (6):
QAPI: move InetSocketAddress to qapi/common.json
support nbd driver in blockdev-add
Add new block driver interface to add/delete a BDS's child
quorum: implement bdrv_add_child() and bdrv_del_child()
qmp: add monitor
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
blockdev.c | 79
qapi/block-core.json | 40 ++
qmp
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Alberto Garcia be...@igalia.com
It will be used by BlockdevOptionsNBD.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Alberto Garcia be...@igalia.com
---
qapi-schema.json | 27
\,
+ \id\: \qtest-f0\,
+ \netdev\: \qtest-bn0\,
+ \chain\: \in\,
+ \interval\: \1000\
+ }});
You can use ' to instead of in the qmp command:
{'execute': 'netfilter_add', ...}
Thanks
Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Alberto Garcia be...@igalia.com
---
qapi/block-core.json | 17 +++--
1 file changed, 15 insertions(+), 2 deletions
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Alberto Garcia be...@igalia.com
---
block/quorum.c | 75 --
1 file
On 08/10/2015 04:19 PM, Alberto Garcia wrote:
On Fri 31 Jul 2015 11:19:12 AM CEST, Wen Congyang wrote:
+static const char *bdrv_get_id_or_node_name(BlockDriverState *bs)
+{
+if (bs-blk) {
+return blk_name(bs-blk);
+}
+
+return bs-node_name ? bs-node_name
On 08/07/2015 09:12 PM, Alberto Garcia wrote:
On Fri 31 Jul 2015 11:19:14 AM CEST, Wen Congyang wrote:
+##
+# @child-add
+#
+# Add a new child to quorum. This is useful to fix a broken quorum
child.
But the idea is that this can be eventually used by other drivers, isn't
it?
Yes
On 08/06/2015 10:33 PM, Alberto Garcia wrote:
On Fri 31 Jul 2015 11:19:12 AM CEST, Wen Congyang wrote:
+/*
+ * Hot add/remove a BDS's child. So the user can take a child offline when
+ * it is broken and take a new child online
+ */
+void bdrv_add_child(BlockDriverState *bs, QDict *options
On 08/05/2015 08:19 PM, Alberto Garcia wrote:
On Tue 07 Jul 2015 10:43:00 AM CEST, Wen Congyang wrote:
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Cc: Alberto Garcia
+5292,12 @@ int monitor_read_bdrv_key_start(Monitor *mon,
BlockDriverState *bs,
BlockCompletionFunc *completion_cb,
void *opaque)
{
+char enc_filename[PATH_MAX];
same too.
Thanks
Wen Congyang
int err
raw_normalize_devicepath(). Why don't we call it
here?
Thanks
Wen Congyang
if (raw_s-fd == -1) {
error_setg_errno(errp, errno, Could not reopen file);
ret = -1;
@@ -2195,7 +2195,7 @@ static int fd_open(BlockDriverState *bs)
DPRINTF(No floppy (open delayed)\n
If quorum's child is broken, we can use mirror job to replace it.
But sometimes, the user only need to remove the broken child, and
add it later when the problem is fixed.
Wen Congyang (6):
QAPI: move InetSocketAddress to qapi/common.json
support nbd driver in blockdev-add
Add new block
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Cc: Alberto Garcia be...@igalia.com
---
block/quorum.c | 74 --
1 file changed, 72
In some cases, we want to take a quorum child offline, and take
another child online.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
block.c | 52
It will be used by BlockdevOptionsNBD.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
qapi-schema.json | 27 ---
qapi/common.json | 27
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Cc: Luiz Capitulino lcapitul...@redhat.com
---
blockdev.c| 33 +
hmp-commands.hx
201 - 300 of 1184 matches
Mail list logo
