[Qemu-devel] [PATCH COLO-BLOCK v7 09/17] Backup: clear all bitmap when doing block checkpoint

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Cc: Jeff Cody jc...@redhat.com --- block/backup.c | 13 + blockjob.c | 10 ++ include/block

[Qemu-devel] [PATCH COLO-BLOCK v7 04/17] introduce a new API qemu_opts_absorb_qdict_by_index()

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- include/qemu/option.h | 2 ++ util/qemu-option.c| 44 2 files changed, 46 insertions

[Qemu-devel] [PATCH COLO-BLOCK v7 05/17] quorum: allow ignoring child errors

2015-06-29 Thread Wen Congyang
ignore it. If all children's getlength return -errno, and be ignored, return 0. Usage: children.x.ignore-errors=true Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Cc: Alberto Garcia

[Qemu-devel] [PATCH COLO-BLOCK v7 01/17] Add new block driver interface to add/delete a BDS's child

2015-06-29 Thread Wen Congyang
In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c | 39

[Qemu-devel] [PATCH COLO-BLOCK v7 00/17] Block replication for continuous checkpoints

2015-06-29 Thread Wen Congyang
the comments from Max Reitz and Eric Blake Wen Congyang (17): Add new block driver interface to add/delete a BDS's child quorum: implement block driver interfaces add/delete a BDS's child hmp: add monitor command to add/remove a child introduce a new API qemu_opts_absorb_qdict_by_index

[Qemu-devel] [PATCH COLO-BLOCK v7 17/17] Implement new driver for block replication

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/Makefile.objs | 1 + block/replication.c | 443 2 files changed, 444

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-28 Thread Wen Congyang
On 06/27/2015 03:03 AM, Dr. David Alan Gilbert wrote: * Wen Congyang (we...@cn.fujitsu.com) wrote: On 06/24/2015 10:07 PM, Dr. David Alan Gilbert wrote: * Wen Congyang (ghost...@gmail.com) wrote: At 2015/6/19 18:49, Stefan Hajnoczi Wrote: On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang

Re: [Qemu-devel] [PATCH] refresh filename after the node is replaced

2015-06-28 Thread Wen Congyang
On 06/26/2015 11:16 PM, Max Reitz wrote: On 26.06.2015 16:27, Wen Congyang wrote: At 2015/6/26 21:47, Max Reitz Wrote: On 25.06.2015 08:41, Wen Congyang wrote: We can use block job mirror to repair broken quorum files. But the command 'info block' doesn't output correct filename after block

Re: [Qemu-devel] [PATCH 0/2] avoid a hotplug operation leading migration's source side abort

2015-06-26 Thread Wen Congyang
it, and it is not a simple work. 2. For HA/FT, we will use migration to implement checkpoint. We should enable hot-plug when HA/FT is running. There are too many works to do to make it work. The first step is to fix the problem. Thanks Wen Congyang Regards, -Gonglei we can reproduced

Re: [Qemu-devel] [PATCH] refresh filename after the node is replaced

2015-06-26 Thread Wen Congyang
At 2015/6/26 21:47, Max Reitz Wrote: On 25.06.2015 08:41, Wen Congyang wrote: We can use block job mirror to repair broken quorum files. But the command 'info block' doesn't output correct filename after block job mirror finishes. Which filename? The quorum filename is broken after this patch

Re: [Qemu-devel] [PATCH 2/2] migration: extend migration_bitmap

2015-06-26 Thread Wen Congyang
will overflow and lead qemu abort unexpectedly. Signed-off-by: Li Zhijian lizhij...@cn.fujitsu.com Signed-off-by: Wen Congyang we...@cn.fujitsu.com Just curious, how are you testing this? because you need a way of doing the hot-plug kind of atomically on both source and destination

[Qemu-devel] [PATCH] more check for replaced node

2015-06-25 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- block.c | 5 +++-- block/mirror.c| 3 ++- blockdev.c| 2 +- include/block/block.h | 3 ++- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 7168575..70ee0f6 100644

[Qemu-devel] [PATCH] refresh filename after the node is replaced

2015-06-25 Thread Wen Congyang
We can use block job mirror to repair broken quorum files. But the command 'info block' doesn't output correct filename after block job mirror finishes. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- block/mirror.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/mirror.c b

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-24 Thread Wen Congyang
On 06/24/2015 10:07 PM, Dr. David Alan Gilbert wrote: * Wen Congyang (ghost...@gmail.com) wrote: At 2015/6/19 18:49, Stefan Hajnoczi Wrote: On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 10:36:39PM +0800

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-23 Thread Wen Congyang
At 2015/6/23 21:42, Stefan Hajnoczi Wrote: On Mon, Jun 22, 2015 at 09:56:24PM +0800, Wen Congyang wrote: The NBD connect should not be performed during downtime, regardless of whether a monitor command is used or not. Why? NBD connection establishment takes unbounded time. It can extend

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-23 Thread Wen Congyang
On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: At 2015/6/18 20:55, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: +void bdrv_connect(BlockDriverState *bs, Error **errp) +{ +BlockDriver

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-23 Thread Wen Congyang
On 06/19/2015 06:49 PM, Stefan Hajnoczi wrote: On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: At 2015/6/18 20:55, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49

Re: [Qemu-devel] [PATCH] iov: don't touch iov in iov_send_recv()

2015-06-22 Thread Wen Congyang
Ping again. This patch is bugfix. The old discussion is here: http://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg00245.html On 05/21/2015 09:50 AM, Wen Congyang wrote: Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- include/qemu/iov.h | 2 +- util/iov.c | 14

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-22 Thread Wen Congyang
At 2015/6/22 20:39, Stefan Hajnoczi Wrote: On Sat, Jun 20, 2015 at 11:31:52AM +0800, Wen Congyang wrote: At 2015/6/19 18:49, Stefan Hajnoczi Wrote: On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 10:36:39PM

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-19 Thread Wen Congyang
At 2015/6/19 18:49, Stefan Hajnoczi Wrote: On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: At 2015/6/18 20:55, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49:12PM

Re: [Qemu-devel] [PATCH COLO-Block v6 04/16] block: Parse backing_reference option to reference existing BDS

2015-06-18 Thread Wen Congyang
On 06/18/2015 06:50 PM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 04:49:09PM +0800, Wen Congyang wrote: Usage: -drive file=xxx,id=Y, \ -drive file=,id=X,backing_reference.drive_id=Y,backing_reference.hidden-disk.* It will create such backing chain: {virtio-blk dev

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-18 Thread Wen Congyang
At 2015/6/18 20:55, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: +void bdrv_connect(BlockDriverState *bs, Error **errp) +{ +BlockDriver *drv = bs-drv; + +if (drv drv-bdrv_connect) { +drv-bdrv_connect(bs, errp); +} else if (bs-file

Re: [Qemu-devel] [PATCH COLO-Block v6 06/16] Don't allow a disk use backing reference target

2015-06-18 Thread Wen Congyang
At 2015/6/18 20:47, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49:11PM +0800, Wen Congyang wrote: Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c | 9 + 1

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-18 Thread Wen Congyang
On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: At 2015/6/18 20:55, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: +void bdrv_connect(BlockDriverState *bs, Error **errp) +{ +BlockDriver

[Qemu-devel] [PATCH COLO-Block v6 00/16] Block replication for continuous checkpoints

2015-06-18 Thread Wen Congyang
disk and nbd target uses the same AioContext 4. Add a testcase to test new hbitmap API V2: 1. Redesign the secondary qemu(use image-fleecing) 2. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Wen Congyang (16): docs: block replication's description

[Qemu-devel] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-18 Thread Wen Congyang
In some cases, we want to connect/disconnect the remote target when we need, not in bdrv_open()/bdrv_close(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c

[Qemu-devel] [PATCH COLO-Block v6 11/16] Add new block driver interfaces to control block replication

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Cc: Luiz Capitulino lcapitul...@redhat.com Cc: Michael Roth mdr...@linux.vnet.ibm.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PATCH COLO-Block v6 02/16] allow writing to the backing file

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c

[Qemu-devel] [PATCH COLO-Block v6 03/16] Allow creating backup jobs when opening BDS

2015-06-18 Thread Wen Congyang
When opening BDS, we need to create backup jobs for image-fleecing. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Cc: Jeff Cody jc...@redhat.com --- block/Makefile.objs | 2 +- 1 file

[Qemu-devel] [PATCH COLO-Block v6 01/16] docs: block replication's description

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- docs/block-replication.txt | 179 + 1 file

[Qemu-devel] [PATCH COLO-Block v6 04/16] block: Parse backing_reference option to reference existing BDS

2015-06-18 Thread Wen Congyang
is hidden-disk, and hidden-disk's backing file is Y. Disk Y may be opened or reopened in read-write mode, so A block backup job is automatically created: source is Y and target is hidden disk. Active disk X, hidden disk, and Y are all on the same AioContext. Signed-off-by: Wen Congyang we

[Qemu-devel] [PATCH COLO-Block v6 09/16] Introduce a new -drive option to control whether to connect to remote target

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- blockdev.c| 8 include/block/block.h | 1 + qemu-options.hx | 4 3 files changed, 13 insertions(+) diff

[Qemu-devel] [PATCH COLO-Block v6 05/16] Backup: clear all bitmap when doing block checkpoint

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Cc: Jeff Cody jc...@redhat.com --- block/backup.c | 13 + blockjob.c | 10 ++ include/block

[Qemu-devel] [PATCH COLO-Block v6 15/16] quorum: allow ignoring child errors

2015-06-18 Thread Wen Congyang
ignore it. If all children's getlength return -errno, and be ignored, return 0. Usage: children.x.ignore-errors=true Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/quorum.c

[Qemu-devel] [PATCH COLO-Block v6 06/16] Don't allow a disk use backing reference target

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block.c b/block.c index d1ed227..0b41af4 100644 --- a/block.c +++ b

[Qemu-devel] [PATCH COLO-Block v6 13/16] quorum: implement block driver interfaces for block replication

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/quorum.c | 78 ++ 1 file changed, 78 insertions(+) diff --git a/block

[Qemu-devel] [PATCH COLO-Block v6 12/16] skip nbd_target when starting block replication

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c | 12 1 file changed, 12 insertions(+) diff --git a/block.c b/block.c index 06222bf..2108d02 100644 --- a/block.c

[Qemu-devel] [PATCH COLO-Block v6 16/16] Implement new driver for block replication

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/Makefile.objs | 1 + block/replication.c | 441 2 files changed, 442

[Qemu-devel] [PATCH COLO-Block v6 14/16] introduce a new API qemu_opts_absorb_qdict_by_index()

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- include/qemu/option.h | 2 ++ util/qemu-option.c| 44 2 files changed, 46 insertions

[Qemu-devel] [PATCH COLO-Block v6 08/16] NBD client: implement block driver interfaces to connect/disconnect NBD server

2015-06-18 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/nbd.c | 67 - 1 file changed, 49 insertions(+), 18 deletions(-) diff

[Qemu-devel] [PATCH COLO-Block v6 10/16] NBD client: connect to nbd server later

2015-06-18 Thread Wen Congyang
The secondary qemu starts later than the primary qemu, so we cannot connect to nbd server in bdrv_open(). Introduce a new open flags to control it. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong

Re: [Qemu-devel] [PATCH COLO-Block v6 01/16] docs: block replication's description

2015-06-18 Thread Wen Congyang
On 06/18/2015 06:34 PM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 04:49:06PM +0800, Wen Congyang wrote: +== Failure Handling == +There are 6 internal errors when block replication is running: +1. I/O error on primary disk +2. Forwarding primay write requests failed s/primay/primary

Re: [Qemu-devel] [PATCH v5] mirror: correct buf_size

2015-06-16 Thread Wen Congyang
Ping... On 05/15/2015 03:51 PM, Wen Congyang wrote: If bus_size is less than 0, the command fails. If buf_size is 0, use DEFAULT_MIRROR_BUF_SIZE. If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Reviewed

Re: [Qemu-devel] [PATCH] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size

2015-06-09 Thread Wen Congyang
it here. Thanks Wen Congyang

Re: [Qemu-devel] [PATCH] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size

2015-06-09 Thread Wen Congyang
On 06/09/2015 05:49 PM, Kevin Wolf wrote: Am 09.06.2015 um 11:47 hat Wen Congyang geschrieben: On 06/09/2015 04:55 PM, Kevin Wolf wrote: Image files with an unaligned image size have a final hole that starts at EOF, i.e. in the middle of a sector. Currently, *pnum == 0 is returned when

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Wen Congyang
-qmp.id) { qdict_put_obj(qmp, id, mon-qmp.id); mon-qmp.id = NULL; } So I think there is no problems for virt-test. Thanks Wen Congyang Paolo

Re: [Qemu-devel] [Bug 1462131] [NEW] qemu mainline regression with xen-unstable: unable to start QMP

2015-06-05 Thread Wen Congyang
/+attachment/4410103/+files/0001-monitor-Allow-Xen-s-broken-usage-of-asynchronous-com.patch Please try this patch: From 061dc4ed1012726fc0b8e1c6d0a784476f5c6d48 Mon Sep 17 00:00:00 2001 From: Wen Congyang we...@cn.fujitsu.com Date: Fri, 5 Jun 2015 16:17:18 +0800 Subject: [PATCH] monitor: Allow the id

Re: [Qemu-devel] Re-2: Strange problems with lseek in qemu-img map

2015-06-05 Thread Wen Congyang
reverted. Thanks Wen Congyang Regards, -Lukas

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-06-04 Thread Wen Congyang
On 05/13/2015 02:40 PM, Fam Zheng wrote: On Wed, 05/13 13:17, Wen Congyang wrote: On 05/13/2015 11:11 AM, Fam Zheng wrote: Before, we only yield after initializing dirty bitmap, where the QMP command would return. That may take very long, and guest IO will be blocked. Do you have such case

Re: [Qemu-devel] Strange problems with lseek in qemu-img map

2015-06-03 Thread Wen Congyang
(Stopped with ^C) Do you use the same filesystem? Thanks Wen Congyang Strace on O3-3: https://gist.github.com/anonymous/f221035e9176f7c71c74 Strace on dinah: https://gist.github.com/anonymous/40b42888a65478c90b32 A git bisect between 1.7 and master revealed

Re: [Qemu-devel] [PATCH COLO-Block v5 00/15] Block replication for continuous checkpoints

2015-06-03 Thread Wen Congyang
On 05/28/2015 12:59 PM, Wen Congyang wrote: Ping... Does anybody have time to review it. Thanks Wen Congyang On 05/21/2015 12:52 PM, Wen Congyang wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). Usage: Please refer

Re: [Qemu-devel] Strange problems with lseek in qemu-img map

2015-06-03 Thread Wen Congyang
: %ld\n, __func__, count); + + if (dataoff isize) { + pr_info(%s() returns -ENXIO\n, __func__); return -ENXIO; + } return vfs_setpos(file, dataoff, maxsize); } We will call the syscall lseek(..., SEEK_DATA) 500 times. Thanks Wen Congyang

Re: [Qemu-devel] [PATCH COLO-Frame v5 00/29] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-06-01 Thread Wen Congyang
? install; it failed the comparison every time; it took me a while to figure out why, but it generates a unique token in it's javascript each time (for a password reset link), and I guess the randomness used by that doesn't match on the two hosts. Yes. Thanks Wen Congyang

Re: [Qemu-devel] [PATCH 11/34] block: Allow references for backing files

2015-05-31 Thread Wen Congyang
On 05/27/2015 08:31 PM, Kevin Wolf wrote: Am 21.05.2015 um 07:47 hat Wen Congyang geschrieben: On 05/09/2015 01:21 AM, Kevin Wolf wrote: For bs-file, using references to existing BDSes has been possible for a while already. This patch enables the same for bs-backing_hd. 1. We reference

Re: [Qemu-devel] [PATCH COLO-Frame v5 00/29] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-05-31 Thread Wen Congyang
On 05/29/2015 04:42 PM, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/5/29 9:29, Wen Congyang wrote: On 05/29/2015 12:24 AM, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: This is the 5th version of COLO

Re: [Qemu-devel] [PATCH COLO-Frame v5 00/29] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-05-28 Thread Wen Congyang
and older e58e5152b74945871b00a88164901c0d46e6365e tags on colo-proxy. I'm not sure of the right fix; perhaps it might be possible to replace the synchronize_rcu in colo_node_release by a call_rcu that does the kfree later? I agree with it. Thanks Wen Congyang Thanks, Dave

Re: [Qemu-devel] [PATCH 07/34] block: Move flag inheritance to bdrv_open_inherited()

2015-05-28 Thread Wen Congyang
, + const BdrvChildRole *child_role, + BlockDriver *drv, Error **errp); The function name in patch title is wrong. Thanks Wen Congyang

Re: [Qemu-devel] [PATCH 11/34] block: Allow references for backing files

2015-05-28 Thread Wen Congyang
On 05/28/2015 05:48 PM, Kevin Wolf wrote: Am 28.05.2015 um 02:59 hat Wen Congyang geschrieben: On 05/27/2015 08:31 PM, Kevin Wolf wrote: Am 21.05.2015 um 07:47 hat Wen Congyang geschrieben: On 05/09/2015 01:21 AM, Kevin Wolf wrote: For bs-file, using references to existing BDSes has been

Re: [Qemu-devel] [PATCH 11/34] block: Allow references for backing files

2015-05-27 Thread Wen Congyang
On 05/27/2015 08:31 PM, Kevin Wolf wrote: Am 21.05.2015 um 07:47 hat Wen Congyang geschrieben: On 05/09/2015 01:21 AM, Kevin Wolf wrote: For bs-file, using references to existing BDSes has been possible for a while already. This patch enables the same for bs-backing_hd. 1. We reference

Re: [Qemu-devel] [PATCH COLO-Block v5 00/15] Block replication for continuous checkpoints

2015-05-27 Thread Wen Congyang
Ping... On 05/21/2015 12:52 PM, Wen Congyang wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). Usage: Please refer to docs/block-replication.txt You can get the patch here: https://github.com/wencongyang/qemu-colo/commits

Re: [Qemu-devel] [PATCH] iov: don't touch iov in iov_send_recv()

2015-05-27 Thread Wen Congyang
Ping... On 05/21/2015 09:50 AM, Wen Congyang wrote: Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- include/qemu/iov.h | 2 +- util/iov.c | 14 +- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/include/qemu/iov.h b/include/qemu/iov.h index

Re: [Qemu-devel] [PATCH v2] util/hbitmap: Add an API to reset all set bits in hbitmap

2015-05-27 Thread Wen Congyang
Hi, Paolo, Kevin Who will take this patch? Thanks Wen Congyang On 05/22/2015 09:29 AM, Wen Congyang wrote: The function bdrv_clear_dirty_bitmap() is updated to use faster hbitmap_reset_all() call. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type device IO

2015-05-22 Thread Wen Congyang
On 05/21/2015 08:44 PM, Fam Zheng wrote: On Thu, 05/21 16:00, Wen Congyang wrote: On 05/21/2015 02:42 PM, Fam Zheng wrote: It blocks device IO. Does tt only block virtio-blk/scsi? Not all block types? It's only necessary for dataplane enabled devices, which are virtio-blk and virtio-scsi

Re: [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type device IO

2015-05-21 Thread Wen Congyang
On 05/21/2015 02:42 PM, Fam Zheng wrote: It blocks device IO. Does tt only block virtio-blk/scsi? Not all block types? Thanks Wen Congyang All bdrv_op_block_all/blk_op_block_all callers are taken care of: - virtio_blk_data_plane_create - virtio_scsi_hotplug Device creation, unblock

Re: [Qemu-devel] [PATCH COLO v4 01/15] docs: block replication's description

2015-05-21 Thread Wen Congyang
On 05/21/2015 12:31 AM, Andrey Korolyov wrote: On Thu, May 14, 2015 at 6:38 PM, Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Wen Congyang (ghost...@gmail.com) wrote: At 2015/5/14 19:19, Dr. David Alan Gilbert Wrote: One thing I wanted to check I understand; how much RAM do the active

Re: [Qemu-devel] [PATCH COLO-Block v5 00/15] Block replication for continuous checkpoints

2015-05-21 Thread Wen Congyang
On 05/21/2015 12:52 PM, Wen Congyang wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). Usage: Please refer to docs/block-replication.txt You can get the patch here: https://github.com/wencongyang/qemu-colo/commits/block

Re: [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type device IO

2015-05-21 Thread Wen Congyang
is OK. - backup_start Blocking target when backup is running, unblock it. Do you forget it? - mirror_complete Blocking s-to_replace until mirror_exit, OK. - block_job_complete The block job may be long running. Unblock it. It should be block_job_create() Thanks Wen

[Qemu-devel] [PATCH v2] util/hbitmap: Add an API to reset all set bits in hbitmap

2015-05-21 Thread Wen Congyang
The function bdrv_clear_dirty_bitmap() is updated to use faster hbitmap_reset_all() call. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Acked-by: Paolo Bonzini pbonz...@redhat.com

Re: [Qemu-devel] [PATCH COLO v4 00/15] Block replication for continuous checkpoints

2015-05-20 Thread Wen Congyang
On 05/21/2015 03:18 AM, Dr. David Alan Gilbert wrote: * Wen Congyang (we...@cn.fujitsu.com) wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). Usage: Please refer to docs/block-replication.txt You can get the patch here: https

[Qemu-devel] [PATCH COLO-Block v5 02/15] allow writing to the backing file

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH COLO-Block v5 00/15] Block replication for continuous checkpoints

2015-05-20 Thread Wen Congyang
objects to return error message 3. Address the comments from Max Reitz and Eric Blake Wen Congyang (15): docs: block replication's description allow writing to the backing file Allow creating backup jobs when opening BDS block: Parse backing_reference option to reference existing BDS

[Qemu-devel] [PATCH COLO-Block v5 01/15] docs: block replication's description

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- docs/block-replication.txt | 179 + 1 file

[Qemu-devel] [PATCH COLO-Block v5 13/15] quorum: implement block driver interfaces for block replication

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/quorum.c | 78 ++ 1 file changed, 78 insertions(+) diff --git a/block

[Qemu-devel] [PATCH COLO-Block v5 05/15] Backup: clear all bitmap when doing block checkpoint

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Cc: Jeff Cody jc...@redhat.com --- block/backup.c | 13 + blockjob.c | 10 ++ include/block

[Qemu-devel] [PATCH COLO-Block v5 15/15] Implement new driver for block replication

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/Makefile.objs | 1 + block/replication.c | 441 2 files changed, 442

[Qemu-devel] [PATCH] iov: don't touch iov in iov_send_recv()

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- include/qemu/iov.h | 2 +- util/iov.c | 14 +- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/include/qemu/iov.h b/include/qemu/iov.h index 68d25f2..569b2c2 100644 --- a/include/qemu/iov.h +++ b/include

[Qemu-devel] [PATCH COLO-Block v5 14/15] quorum: allow ignoring child errors

2015-05-20 Thread Wen Congyang
ignore it. If all children's getlength return -errno, and be ignored, return 0. Usage: children.x.ignore-errors=true Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/quorum.c

[Qemu-devel] [PATCH COLO-Block v5 09/15] Introduce a new -drive option to control whether to connect to remote target

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- blockdev.c| 8 include/block/block.h | 1 + qemu-options.hx | 4 3 files changed, 13 insertions(+) diff

[Qemu-devel] [PATCH COLO-Block v5 06/15] Don't allow a disk use backing reference target

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block.c b/block.c index 220ba9a..1b362ba 100644 --- a/block.c +++ b

[Qemu-devel] [PATCH COLO-Block v5 08/15] NBD client: implement block driver interfaces to connect/disconnect NBD server

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/nbd.c | 67 - 1 file changed, 49 insertions(+), 18 deletions(-) diff

[Qemu-devel] [PATCH COLO-Block v5 10/15] NBD client: connect to nbd server later

2015-05-20 Thread Wen Congyang
The secondary qemu starts later than the primary qemu, so we cannot connect to nbd server in bdrv_open(). Introduce a new open flags to control it. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong

[Qemu-devel] [PATCH COLO-Block v5 04/15] block: Parse backing_reference option to reference existing BDS

2015-05-20 Thread Wen Congyang
is hidden-disk, and hidden-disk's backing file is Y. Disk Y may be opened or reopened in read-write mode, so A block backup job is automatically created: source is Y and target is hidden disk. Active disk X, hidden disk, and Y are all on the same AioContext. Signed-off-by: Wen Congyang we

[Qemu-devel] [PATCH COLO-Block v5 03/15] Allow creating backup jobs when opening BDS

2015-05-20 Thread Wen Congyang
When opening BDS, we need to create backup jobs for image-fleecing. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Cc: Jeff Cody jc...@redhat.com --- block/Makefile.objs | 2 +- 1 file

[Qemu-devel] [PATCH COLO-Block v5 11/15] Add new block driver interfaces to control block replication

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Cc: Luiz Capitulino lcapitul...@redhat.com Cc: Michael Roth mdr...@linux.vnet.ibm.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PATCH COLO-Block v5 07/15] Add new block driver interface to connect/disconnect the remote target

2015-05-20 Thread Wen Congyang
In some cases, we want to connect/disconnect the remote target when we need, not in bdrv_open()/bdrv_close(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c

[Qemu-devel] [PATCH COLO-Block v5 12/15] skip nbd_target when starting block replication

2015-05-20 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c | 12 1 file changed, 12 insertions(+) diff --git a/block.c b/block.c index 74fd3d6..961e395 100644 --- a/block.c

Re: [Qemu-devel] [PATCH 11/34] block: Allow references for backing files

2015-05-20 Thread Wen Congyang
be not NULL now? If we do an active commit to this backing file(use mirror job), we will call bdrv_swap() in mirror_exit(), and the function bdrv_swap() doesn't allow that new_bs-blk(here is bs-backing_hd) is not NULL. Thanks Wen Congyang Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c

Re: [Qemu-devel] [PATCH v3] mirror: correct buf_size

2015-05-15 Thread Wen Congyang
On 05/15/2015 02:45 PM, Paolo Bonzini wrote: On 15/05/2015 03:37, Wen Congyang wrote: If bus_size is less than 0, the command fails. If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- block/mirror.c | 6

Re: [Qemu-devel] [PATCH v3 01/12] block: Add op blocker type device IO

2015-05-15 Thread Wen Congyang
is scheduled? If the answer is yes, I think we should use this to block the guest's disk I/O. Thanks Wen Congyang All bdrv_op_block_all/blk_op_block_all callers are taken care of: - virtio_blk_data_plane_create - virtio_scsi_hotplug Device creation, unblock it. - bdrv_set_backing_hd

[Qemu-devel] [PATCH v5] mirror: correct buf_size

2015-05-15 Thread Wen Congyang
If bus_size is less than 0, the command fails. If buf_size is 0, use DEFAULT_MIRROR_BUF_SIZE. If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Reviewed-by: Fam Zheng f...@redhat.com --- block/mirror.c | 11

Re: [Qemu-devel] [PATCH COLO v4 01/15] docs: block replication's description

2015-05-14 Thread Wen Congyang
locations on the disk); how big are the active and hidden disks in RAM - are they 10MB or 20MB? 10MB, we will make active and hidden disks empty when doing checkpoint. Thanks Wen Congyang

[Qemu-devel] [PATCH v3] mirror: correct buf_size

2015-05-14 Thread Wen Congyang
If bus_size is less than 0, the command fails. If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- block/mirror.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block/mirror.c b/block

Re: [Qemu-devel] [PATCH COLO v4 02/15] allow writing to the backing file

2015-05-14 Thread Wen Congyang
On 05/14/2015 03:16 PM, Gonglei wrote: On 2015/5/8 17:15, Wen Congyang wrote: Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block.c | 31 ++- 1 file

Re: [Qemu-devel] [PATCH COLO v4 08/15] NBD client: implement block driver interfaces to connect/disconnect NBD server

2015-05-14 Thread Wen Congyang
On 05/14/2015 04:16 PM, Gonglei wrote: On 2015/5/8 17:16, Wen Congyang wrote: Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/nbd.c | 65

[Qemu-devel] [PATCH] mirror: correct buf_size

2015-05-14 Thread Wen Congyang
If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- block/mirror.c | 4 1 file changed, 4 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 58f391a..bb6bc27 100644 --- a/block/mirror.c +++ b

[Qemu-devel] [PATCH v2] mirror: correct buf_size

2015-05-14 Thread Wen Congyang
If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 58f391a..9521212 100644 --- a/block

[Qemu-devel] [PATCH v4] mirror: correct buf_size

2015-05-14 Thread Wen Congyang
If bus_size is less than 0, the command fails. If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Reviewed-by: Fam Zheng f...@redhat.com --- block/mirror.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion

Re: [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction

2015-05-13 Thread Wen Congyang
to read from bs to do backup!! If the mode is none, you also need to write to bs!! Thanks Wen Congyang qmp_blockdev_backup(backup-device, backup-target, backup-sync, backup-has_speed, backup-speed, @@ -1696,7 +1701,6 @@ static void

Re: [Qemu-devel] [PATCH v2 01/11] block: Add op blocker type device IO

2015-05-13 Thread Wen Congyang
)) { +return -EBUSY; +} + The guest doesn't know this status, so how do we prevent it? If it is virtio disk, you wait it, but if it is the other disks, what is the behavior? Thanks Wen Congyang return blk_check_byte_request(blk, sector_num * BDRV_SECTOR_SIZE

Re: [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction

2015-05-13 Thread Wen Congyang
On 05/13/2015 08:55 PM, Fam Zheng wrote: On Wed, 05/13 19:22, Wen Congyang wrote: On 05/14/2015 01:28 AM, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- blockdev.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index

<    1   2   3   4   5   6   7   8   9   10   >