RE: [PATCH v2 00/48] Use g_assert_not_reached instead of (g_)assert(0, false)

2024-09-18 Thread Xingtao Yao (Fujitsu)
> >> -- > >> 2.39.2 > >> > > > > Which one did you find? Using which grep command? Sorry, I made a mistake. I haven't found anything new yet.

RE: [PATCH v4] pci-bridge: avoid linking a single downstream port more than once

2024-09-11 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Michael S. Tsirkin > Sent: Tuesday, September 10, 2024 11:17 PM > To: Yao, Xingtao/姚 幸涛 > Cc: marcel.apfelb...@gmail.com; qemu-devel@nongnu.org > Subject: Re: [PATCH v4] pci-bridge: avoid linking a single downstream port > more > than once > > On Thu, Jul

RE: [PATCH 1/1] platform-bus: fix refcount leak

2024-08-30 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of Gao > Shiyuan via > Sent: Thursday, August 29, 2024 9:10 PM > To: Paolo Bonzini > Cc: qemu-devel@nongnu.org; gaoshiy...@baidu.com > Subject: [PATCH 1/1] platform-bus: fix refcount leak > >

RE: [PATCH] scripts/coccinelle: New range.cocci

2024-08-22 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Peter Maydell > Sent: Thursday, August 22, 2024 11:31 PM > To: Yao, Xingtao/姚 幸涛 > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH] scripts/coccinelle: New range.cocci > > On Wed, 21 Aug 2024 at 01:21, Xingta

RE: [PATCH] scripts/coccinelle: New range.cocci

2024-08-20 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Peter Maydell > Sent: Tuesday, August 20, 2024 4:41 PM > To: Yao, Xingtao/姚 幸涛 > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH] scripts/coccinelle: New range.cocci > > On Thu, 25 Jul 2024 at 06:55, Yao Xingtao via wrote: > > > > This is the semantic patc

RE: [PATCH v4] pci-bridge: avoid linking a single downstream port more than once

2024-08-19 Thread Xingtao Yao (Fujitsu)
ping. > -Original Message- > From: Yao Xingtao > Sent: Thursday, July 25, 2024 5:38 PM > To: m...@redhat.com; marcel.apfelb...@gmail.com > Cc: qemu-devel@nongnu.org; Yao, Xingtao/姚 幸涛 > Subject: [PATCH v4] pci-bridge: avoid linking a single downstream port more > than > once > > Since

RE: [PATCH 13/13] block/qcow2-cluster: make range overlap check more readable

2024-08-19 Thread Xingtao Yao (Fujitsu)
ping. > -Original Message- > From: Yao Xingtao > Sent: Monday, July 22, 2024 12:08 PM > To: qemu-devel@nongnu.org; Kevin Wolf ; Hanna Reitz > > Cc: Yao, Xingtao/姚 幸涛 ; qemu-bl...@nongnu.org > Subject: [PATCH 13/13] block/qcow2-cluster: make range overlap check more > readable > > use ra

RE: [PATCH] scripts/coccinelle: New range.cocci

2024-08-19 Thread Xingtao Yao (Fujitsu)
ping. > -Original Message- > From: Yao Xingtao > Sent: Thursday, July 25, 2024 1:55 PM > To: qemu-devel@nongnu.org > Cc: Yao, Xingtao/姚 幸涛 > Subject: [PATCH] scripts/coccinelle: New range.cocci > > This is the semantic patch from commit 7b3e371526 "cxl/mailbox: make > range overlap chec

RE: [PATCH 00/13] make range overlap check more readable

2024-07-25 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Peter Maydell > Sent: Thursday, July 25, 2024 11:14 PM > To: Yao, Xingtao/姚 幸涛 > Cc: Philippe Mathieu-Daudé ; qemu-devel@nongnu.org > Subject: Re: [PATCH 00/13] make range overlap check more readable > > On Mon, 22 Jul 2024 at 08:

RE: [PATCH v3] pci-bridge: avoid linking a single downstream port more than once

2024-07-25 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Igor Mammedov > Sent: Thursday, July 25, 2024 4:36 PM > To: Yao Xingtao via > Cc: Yao, Xingtao/姚 幸涛 ; m...@redhat.com; > marcel.apfelb...@gmail.com > Subject: Re: [PATCH v3] pci-bridge: avoid linking a single downstream port > more > than once > > On Wed,

RE: [PATCH 1/2] util/getauxval: Ensure setting errno if not found

2024-07-22 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Vivian Wang > Sent: Monday, July 22, 2024 4:24 PM > To: Yao, Xingtao/姚 幸涛 ; qemu-devel@nongnu.org > Cc: Richard Henderson ; Laurent Vivier > Subject: Re: [PATCH 1/2] util/getauxval: Ensure setting errno if not found > > On 7/

RE: [PATCH 00/13] make range overlap check more readable

2024-07-22 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Monday, July 22, 2024 3:37 PM > To: Yao, Xingtao/姚 幸涛 ; qemu-devel@nongnu.org > Subject: Re: [PATCH 00/13] make range overlap check more readable > > On 22/7/24 08:59, Xingtao Yao (Fujitsu) wrote: >

RE: [PATCH 00/13] make range overlap check more readable

2024-07-22 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Monday, July 22, 2024 2:43 PM > To: Yao, Xingtao/姚 幸涛 ; qemu-devel@nongnu.org > Subject: Re: [PATCH 00/13] make range overlap check more readable > > Hi Yao, > > On 22/7/24 06:07, Yao Xingtao via wrote: > > Currently, some com

RE: [PATCH 1/2] util/getauxval: Ensure setting errno if not found

2024-07-21 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of Vivian > Wang > Sent: Sunday, July 21, 2024 5:08 PM > To: qemu-devel@nongnu.org > Cc: Vivian Wang ; Richard Henderson ; > Laurent Vivier > Subject: [PATCH 1/2] util/getauxval: Ensure settin

RE: [PATCH] mem/cxl_type3: Fix overlapping region validation error

2024-07-18 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Peter Maydell > Sent: Friday, July 19, 2024 1:12 AM > To: Jonathan Cameron > Cc: Yao, Xingtao/姚 幸涛 ; fan...@samsung.com; > qemu-devel@nongnu.org > Subject: Re: [PATCH] mem/cxl_type3: Fix overlapping region validation error > > On Thu, 18 Jul 2024 at 17:37,

RE: [PATCH] mem/cxl_type3: Fix overlapping region validation error

2024-07-18 Thread Xingtao Yao (Fujitsu)
> > > As mentioned by Peter, we can use ranges_overlap() to improve the > code readability. Other than that, looks good t me. > > btw, not sure only me or not, but the message does not display > correctly in mutt, seems not a plain text message, but looks fine in > outlook. I am not sure as well

RE: [PATCH v2] pci-bridge: avoid linking a single downstream port more than once

2024-07-17 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Michael S. Tsirkin > Sent: Wednesday, July 17, 2024 8:04 PM > To: Yao, Xingtao/姚 幸涛 > Cc: marcel.apfelb...@gmail.com; qemu-devel@nongnu.org; > jonathan.came...@huawei.com > Subject: Re: [PATCH v2] pci-bridge: avoid linking a single downstream port > more >

RE: [PATCH v2] pci-bridge: avoid linking a single downstream port more than once

2024-07-17 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Wednesday, July 17, 2024 6:18 PM > To: Yao, Xingtao/姚 幸涛 ; m...@redhat.com; > marcel.apfelb...@gmail.com > Cc: qemu-devel@nongnu.org; jonathan.came...@huawei.com > Subject: Re: [PATCH v2] pci-bridge: avoid linking a single downs

RE: [PATCH v4] hw/core/loader: allow loading larger ROMs

2024-07-07 Thread Xingtao Yao (Fujitsu)
Reviewed-by: Xingtao Yao > -Original Message- > From: Gregor Haas > Sent: Saturday, June 29, 2024 2:27 AM > To: qemu-devel@nongnu.org > Cc: berra...@redhat.com; Yao, Xingtao/姚 幸涛 ; > Gregor Haas > Subject: [PATCH v4] hw/core/loader: allow loading larger ROMs > > The read() syscall is n

RE: [PATCH v5 3/7] plugins: extend API to get latest memory value accessed

2024-07-04 Thread Xingtao Yao (Fujitsu)
Reviewed-by: Xingtao Yao > -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of > Pierrick Bouvier > Sent: Friday, July 5, 2024 8:34 AM > To: qemu-devel@nongnu.org > Cc: Alexandre Iooss ; Richard Henderson > ; Marcel Apfelbaum > ; Pierrick Bouvie

RE: [PATCH v5 6/7] tests/plugin/mem: add option to print memory accesses

2024-07-04 Thread Xingtao Yao (Fujitsu)
Reviewed-by: Xingtao Yao > -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of > Pierrick Bouvier > Sent: Friday, July 5, 2024 8:34 AM > To: qemu-devel@nongnu.org > Cc: Alexandre Iooss ; Richard Henderson > ; Marcel Apfelbaum > ; Pierrick Bouvie

RE: [PATCH] hw/cxl/cxl-host: Fix guest crash when getting cxl-fmw property

2024-07-04 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of Zhao > Liu > Sent: Thursday, July 4, 2024 5:34 PM > To: Jonathan Cameron ; Fan Ni > > Cc: qemu-devel@nongnu.org; qemu-sta...@nongnu.org; Zhao Liu > > Subject: [PATCH] hw/cxl/cxl-host: Fix

RE: [PATCH v4 5/7] tests/tcg: allow to check output of plugins

2024-07-02 Thread Xingtao Yao (Fujitsu)
Tested-by: Xingtao Yao > -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of > Pierrick Bouvier > Sent: Wednesday, July 3, 2024 2:45 AM > To: qemu-devel@nongnu.org > Cc: Alex Bennée ; Mahmoud Mandour > ; Pierrick Bouvier ; > Alexandre Iooss ; Ph

RE: [PATCH v4 4/7] tests/tcg: add mechanism to run specific tests with plugins

2024-07-02 Thread Xingtao Yao (Fujitsu)
Tested-by: Xingtao Yao > -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of > Pierrick Bouvier > Sent: Wednesday, July 3, 2024 2:45 AM > To: qemu-devel@nongnu.org > Cc: Alex Bennée ; Mahmoud Mandour > ; Pierrick Bouvier ; > Alexandre Iooss ; Ph

RE: [PATCH v4 6/7] tests/plugin/mem: add option to print memory accesses

2024-07-02 Thread Xingtao Yao (Fujitsu)
Tested-by: Xingtao Yao one small suggestion: Keeping the addresses or values of fixed size in output message can improve the readability of logs. like: > +case QEMU_PLUGIN_MEM_VALUE_U8: > +g_string_append_printf(out, "0x%"PRIx8, value.data.u8); > +break; case QEMU_PLUGIN_MEM_

RE: [PATCH v4 7/7] tests/tcg/x86_64: add test for plugin memory access

2024-07-02 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of > Pierrick Bouvier > Sent: Wednesday, July 3, 2024 2:45 AM > To: qemu-devel@nongnu.org > Cc: Alex Bennée ; Mahmoud Mandour > ; Pierrick Bouvier ; > Alexandre Iooss ; Philippe Mathieu-Daudé >

RE: [PATCH] hw/nvme: Fix memory leak in nvme_dsm

2024-07-02 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of Zheyu > Ma > Sent: Wednesday, July 3, 2024 7:13 AM > To: Keith Busch ; Klaus Jensen ; Jesper > Devantier > Cc: Zheyu Ma ; qemu-bl...@nongnu.org; > qemu-devel@nongnu.org > Subject: [PATCH] h

RE: [PATCH v3 1/7] plugins: fix mem callback array size

2024-07-01 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of > Pierrick Bouvier > Sent: Tuesday, July 2, 2024 9:10 AM > To: qemu-devel@nongnu.org > Cc: Eduardo Habkost ; Alex Bennée > ; Pierrick Bouvier ; > Paolo > Bonzini ; Philippe Mathieu-Daudé ; >

[BUG REPORT] cxl process in infinity loop

2024-07-01 Thread Xingtao Yao (Fujitsu)
Hi, all When I did the cxl memory hot-plug test on QEMU, I accidentally connected two memdev to the same downstream port, the command like below: > -object memory-backend-ram,size=262144k,share=on,id=vmem0 \ > -object memory-backend-ram,size=262144k,share=on,id=vmem1 \ > -device pxb-cxl,bus_nr=1

RE: [PATCH] hw/misc/bcm2835_thermal: Handle invalid address accesses gracefully

2024-06-30 Thread Xingtao Yao (Fujitsu)
Hi, zheyu > -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of Zheyu > Ma > Sent: Sunday, June 30, 2024 11:14 PM > To: Peter Maydell ; Philippe Mathieu-Daudé > > Cc: Zheyu Ma ; qemu-...@nongnu.org; > qemu-devel@nongnu.org > Subject: [PATCH] hw/

RE: [PATCH] hw/display/tcx: Fix out-of-bounds access in tcx_blit_writel

2024-06-30 Thread Xingtao Yao (Fujitsu)
Hi, zheyu > -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of Zheyu > Ma > Sent: Sunday, June 30, 2024 9:04 PM > To: Mark Cave-Ayland > Cc: Zheyu Ma ; qemu-devel@nongnu.org > Subject: [PATCH] hw/display/tcx: Fix out-of-bounds access in tcx_bli

RE: [PATCH] hw/usb: Fix memory leak in musb_reset()

2024-06-30 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: qemu-devel-bounces+yaoxt.fnst=fujitsu@nongnu.org > On Behalf Of Zheyu > Ma > Sent: Monday, July 1, 2024 12:32 AM > Cc: Zheyu Ma ; qemu-devel@nongnu.org > Subject: [PATCH] hw/usb: Fix memory leak in musb_reset() > > The musb_reset function was causing a

RE: [PATCH v3] hw/core/loader: allow loading larger ROMs

2024-06-27 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Gregor Haas > Sent: Friday, June 28, 2024 9:51 AM > To: qemu-devel@nongnu.org > Cc: Yao, Xingtao/姚 幸涛 ; Gregor Haas > > Subject: [PATCH v3] hw/core/loader: allow loading larger ROMs > > The read() syscall is not guaranteed to return all data from a file. T

RE: [PATCH v2] hw/core/loader: allow loading larger ROMs

2024-06-27 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Gregor Haas > Sent: Friday, June 28, 2024 8:58 AM > To: qemu-devel@nongnu.org > Cc: Yao, Xingtao/姚 幸涛 ; Gregor Haas > > Subject: [PATCH v2] hw/core/loader: allow loading larger ROMs > > The read() syscall is not guaranteed to return all data from a file. T

RE: [PATCH] hw/core/loader: allow loading larger ROMs

2024-06-27 Thread Xingtao Yao (Fujitsu)
ake a minimal reproducer for this, or if you need any more information. Thanks, Gregor [1] https://github.com/buildroot/buildroot/blob/master/boot/opensbi/Config.in#L95 On Wed, Jun 26, 2024 at 11:11 PM Xingtao Yao (Fujitsu) mailto:yaoxt.f...@fujitsu.com>> wrote: Hi, Gregor >

RE: [PATCH] hw/core/loader: allow loading larger ROMs

2024-06-26 Thread Xingtao Yao (Fujitsu)
Hi, Gregor > > The read() syscall is not guaranteed to return all data from a file. The > default ROM loader implementation currently does not take this into account, > instead failing if all bytes are not read at once. This change wraps the > read() syscall in a do/while loop to ensure all bytes

RE: [PATCH v2 6/7] tests/plugin/mem: add option to print memory accesses

2024-06-26 Thread Xingtao Yao (Fujitsu)
Alex Bennée > > Subject: Re: [PATCH v2 6/7] tests/plugin/mem: add option to print memory > accesses > > Hi Xingtao, > > On 6/26/24 20:17, Xingtao Yao (Fujitsu) wrote: > > Hi, Pierrick > > > >> +static void print_access(unsigned int cpu_index, qemu_plug

RE: [PATCH v2 6/7] tests/plugin/mem: add option to print memory accesses

2024-06-26 Thread Xingtao Yao (Fujitsu)
Hi, Pierrick > +static void print_access(unsigned int cpu_index, qemu_plugin_meminfo_t > meminfo, > + uint64_t vaddr, void *udata) > +{ > +unsigned size = 8 << qemu_plugin_mem_size_shift(meminfo); > +const char *type = qemu_plugin_mem_is_store(meminfo) ? "store" : "

RE: [PATCH v3] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-06-23 Thread Xingtao Yao (Fujitsu)
Jun 2024 08:07:27 + > "Xingtao Yao (Fujitsu)" wrote: > > > ping again. > > Sorry for delay - I was waiting for some of the tree I'm carrying > to get picked up before applying anything new. > > I haven't yet tested this as fully as I'd like f

RE: [PATCH v3] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-06-06 Thread Xingtao Yao (Fujitsu)
ping again. > -Original Message- > From: Yao, Xingtao/姚 幸涛 > Sent: Friday, May 24, 2024 5:31 PM > To: Yao, Xingtao/姚 幸涛 ; > jonathan.came...@huawei.com; fan...@samsung.com > Cc: qemu-devel@nongnu.org > Subject: RE: [PATCH v3] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways > > pin

RE: [PATCH v3] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-05-24 Thread Xingtao Yao (Fujitsu)
ping. > -Original Message- > From: Yao Xingtao > Sent: Wednesday, May 8, 2024 8:53 AM > To: jonathan.came...@huawei.com; fan...@samsung.com > Cc: qemu-devel@nongnu.org; Yao, Xingtao/姚 幸涛 > Subject: [PATCH v3] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways > > Since the kernel do

RE: [PATCH v2] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-05-07 Thread Xingtao Yao (Fujitsu)
May 2024 00:22:00 + > "Xingtao Yao (Fujitsu)" wrote: > > > > -Original Message- > > > From: Jonathan Cameron > > > Sent: Tuesday, April 30, 2024 10:43 PM > > > To: Yao, Xingtao/姚 幸涛 > > > Cc: fan...@samsung.com; qemu-devel@nongn

RE: [PATCH v2] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-05-06 Thread Xingtao Yao (Fujitsu)
Apr 2024 01:36:56 + > "Xingtao Yao (Fujitsu)" wrote: > > > ping. > > > > > -Original Message- > > > From: Yao Xingtao > > > Sent: Sunday, April 7, 2024 11:07 AM > > > To: jonathan.came...@huawei.com; fan...@samsung.com >

RE: [PATCH v2] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways

2024-04-23 Thread Xingtao Yao (Fujitsu)
ping. > -Original Message- > From: Yao Xingtao > Sent: Sunday, April 7, 2024 11:07 AM > To: jonathan.came...@huawei.com; fan...@samsung.com > Cc: qemu-devel@nongnu.org; Yao, Xingtao/姚 幸涛 > Subject: [PATCH v2] mem/cxl_type3: support 3, 6, 12 and 16 interleave ways > > Since the kernel do

RE: [PATCH] mem/cxl_type3: fix hpa to dpa logic

2024-04-06 Thread Xingtao Yao (Fujitsu)
> > On Mon, 1 Apr 2024 17:00:50 +0100 > Jonathan Cameron via wrote: > > > On Thu, 28 Mar 2024 06:24:24 + > > "Xingtao Yao (Fujitsu)" wrote: > > > > > Jonathan > > > > > > thanks for your reply! > > > > > >

RE: [PATCH] mem/cxl_type3: fix hpa to dpa logic

2024-03-27 Thread Xingtao Yao (Fujitsu)
Jonathan thanks for your reply! > -Original Message- > From: Jonathan Cameron > Sent: Wednesday, March 27, 2024 9:28 PM > To: Yao, Xingtao/姚 幸涛 > Cc: fan...@samsung.com; qemu-devel@nongnu.org; Cao, Quanquan/曹 全全 > > Subject: Re: [PATCH] mem/cxl_type3: fix hpa to dpa logic > > On Tue,

RE: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Tuesday, March 26, 2024 8:04 PM > To: Peter Maydell > Cc: Pierrick Bouvier ; Yao, Xingtao/姚 幸涛 > ; qemu-devel@nongnu.org; alex.ben...@linaro.org; > erdn...@crans.org; ma.mando...@gmail.com > Subject: Re: [PATCH v3] contrib/plug

RE: [PATCH] contrib/plugins/execlog: Fix compiler warning

2024-03-24 Thread Xingtao Yao (Fujitsu)
rans.org; ma.mando...@gmail.com; > qemu-devel@nongnu.org > Subject: Re: [PATCH] contrib/plugins/execlog: Fix compiler warning > > On 3/25/24 07:00, Xingtao Yao (Fujitsu) wrote: > > Pete: > > Thanks for your comment. > > > > I also find a similar patch writt

RE: [PATCH] contrib/plugins/execlog: Fix compiler warning

2024-03-24 Thread Xingtao Yao (Fujitsu)
Pete: Thanks for your comment. I also find a similar patch written by Pierrick: https://lore.kernel.org/qemu-devel/20240118032400.3762658-15-pierrick.bouv...@linaro.org/ but for some reason, the patch was not merged yet. shall I need to continue tracking the fixes of this bug? > -Original M