Re: [Qemu-devel] [PATCH 1/2] monitor.c: make mon_get_cpu return NULL when there is no CPU

2017-02-20 Thread Yang Ziyue
Sorry for forgetting the "no irrelevant change" rule...won't do that next time! 2017-02-20 14:09 GMT+08:00 Thomas Huth : > On 19.02.2017 04:55, Philippe Mathieu-Daudé wrote: >> On 02/17/2017 05:27 AM, Ziyue Yang wrote: >>> From: Ziyue Yang >>> >>> Currently mon_get_cpu always dereferences first_c

Re: [Qemu-devel] [PATCH v2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-18 Thread Yang Ziyue
Got it. Thanks! 2017-01-18 10:13 GMT+08:00 Fam Zheng : > On Wed, 01/18 09:34, Yang Ziyue wrote: >> Oops seems I forgot to check the patch before submitting. Sorry for that. >> The new patch is tagged as v3 now, but I'm not sure whether it should >> be tagged as v2 sinc

Re: [Qemu-devel] [PATCH v4 1/2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Yang Ziyue
Got it. Thanks! 2017-01-18 15:48 GMT+08:00 Thomas Huth : > Hi, > > On 18.01.2017 08:43, Yang Ziyue wrote: >> Hi Thomas, >> >> I'm not quite sure about that, but did you mean that I should mention >> the second patch before the Sign-off line instead of in

Re: [Qemu-devel] [PATCH v4 1/2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Yang Ziyue
Hi Thomas, I'm not quite sure about that, but did you mean that I should mention the second patch before the Sign-off line instead of in the commit message? Thanks! Ziyue Yang

Re: [Qemu-devel] [PATCH v3] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Yang Ziyue
Hi Fam, I've split the patch into 2 smaller ones and submitted them tagged with "v4". Thanks! Ziyue Yang 2017-01-18 10:15 GMT+08:00 Fam Zheng : > On Wed, 01/18 09:28, Ziyue Yang wrote: >> Also some updates from fprintf(stderr, ...) to error_report. > > Looks like they belong to a separate patch.

Re: [Qemu-devel] [PATCH v2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Yang Ziyue
Oops seems I forgot to check the patch before submitting. Sorry for that. The new patch is tagged as v3 now, but I'm not sure whether it should be tagged as v2 since the origin v2 failed. Is there any specification about this? Thanks! 2017-01-18 9:19 GMT+08:00 : > Hi, > > Your series seems to hav

Re: [Qemu-devel] [PATCH] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Yang Ziyue
2017-01-18 1:27 GMT+08:00 Thomas Huth : > > On 17.01.2017 16:19, Ziyue Yang wrote: > > From: Ziyue Yang > > > > This patch is to fix the segmentation fault caused by attaching > > GDB to a QEMU instance initialized with "-M none" option. > > > > The bug can be reproduced by > > > >> ./qemu-system-