Re: [Qemu-devel] [PATCH V13 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Yi Zhang
On 2019-02-07 at 22:00:46 -0500, Michael S. Tsirkin wrote: > On Fri, Feb 08, 2019 at 06:11:23PM +0800, Zhang, Yi wrote: > > From: Zhang Yi > > > > Signed-off-by: Zhang Yi > > --- > > docs/nvdimm.txt | 25 ++--- > > qemu-options.hx | 5 + > > 2 files changed, 27

Re: [Qemu-devel] [PATCH V12 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Yi Zhang
On 2019-02-07 at 09:30:12 -0500, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2019 at 11:16:05PM +0800, Yi Zhang wrote: > > On 2019-02-06 at 13:29:37 -0500, Michael S. Tsirkin wrote: > > > On Thu, Feb 07, 2019 at 01:27:29AM +0800, Zhang, Yi wrote: > > > > From: Zhang Y

Re: [Qemu-devel] [PATCH V12 5/5] docs: Added MAP_SYNC documentation

2019-02-06 Thread Yi Zhang
On 2019-02-06 at 13:29:37 -0500, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2019 at 01:27:29AM +0800, Zhang, Yi wrote: > > From: Zhang Yi > > > > Signed-off-by: Zhang Yi > > --- > > docs/nvdimm.txt | 25 ++--- > > qemu-options.hx | 4 > > 2 files changed, 26

Re: [Qemu-devel] [PATCH v11 3/3] docs: Added MAP_SYNC documentation

2019-01-29 Thread Yi Zhang
On 2019-01-29 at 09:09:54 -0500, Michael S. Tsirkin wrote: > On Tue, Jan 29, 2019 at 10:49:18PM +0800, Zhang, Yi wrote: > > From: Zhang Yi > > > > Signed-off-by: Zhang Yi > > --- > > docs/nvdimm.txt | 29 - > > qemu-options.hx | 4 > > 2 files changed, 32

Re: [Qemu-devel] [PATCH v11 2/3] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-29 Thread Yi Zhang
On 2019-01-29 at 01:55:06 -0500, Pankaj Gupta wrote: > > > > > From: Zhang Yi > > > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > > MAP_SYNC flag in addition which can ensure file system metadata > > synced in each guest writes to the backend file, without other QEMU

Re: [Qemu-devel] [PATCH v11 2/3] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-29 Thread Yi Zhang
On 2019-01-29 at 08:50:46 -0500, Michael S. Tsirkin wrote: > On Tue, Jan 29, 2019 at 10:49:09PM +0800, Zhang, Yi wrote: > > From: Zhang Yi > > > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > > MAP_SYNC flag in addition which can ensure file system metadata > > synced in

Re: [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation

2019-01-24 Thread Yi Zhang
> > On Thu, Jan 24, 2019 at 02:59:26PM -0200, Eduardo Habkost wrote: > > > > > On Thu, Jan 24, 2019 at 07:21:03PM +0800, Yi Zhang wrote: > > > > > > On 2019-01-23 at 12:50:50 -0200, Eduardo Habkost wrote: > > > > > > > On We

Re: [Qemu-devel] [PATCH V10 2/4] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-23 Thread Yi Zhang
On 2019-01-23 at 10:04:01 -0500, Michael S. Tsirkin wrote: > On Wed, Jan 23, 2019 at 10:59:45AM +0800, Zhang, Yi wrote: > > From: Zhang Yi > > > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > > MAP_SYNC flag in addition which can ensure file system metadata > > synced in

Re: [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation

2019-01-23 Thread Yi Zhang
On 2019-01-23 at 12:50:50 -0200, Eduardo Habkost wrote: > On Wed, Jan 23, 2019 at 11:00:02AM +0800, Zhang, Yi wrote: > > From: Zhang Yi > > > > Signed-off-by: Zhang Yi > > --- > > docs/nvdimm.txt | 29 - > > qemu-options.hx | 4 > > 2 files changed, 32

Re: [Qemu-devel] [PATCH V10 0/4] support MAP_SYNC for memory-backend-file

2019-01-22 Thread Yi Zhang
On 2019-01-22 at 22:53:36 -0500, Michael S. Tsirkin wrote: > On Wed, Jan 23, 2019 at 11:10:07AM +0800, Yi Zhang wrote: > > On 2019-01-22 at 22:01:58 -0500, Michael S. Tsirkin wrote: > > > On Wed, Jan 23, 2019 at 10:59:27AM +0800, Zhang, Yi wrote: > > > > From: &quo

Re: [Qemu-devel] [PATCH V10 0/4] support MAP_SYNC for memory-backend-file

2019-01-22 Thread Yi Zhang
On 2019-01-22 at 23:02:22 -0500, Michael S. Tsirkin wrote: > On Wed, Jan 23, 2019 at 11:10:07AM +0800, Yi Zhang wrote: > > On 2019-01-22 at 22:01:58 -0500, Michael S. Tsirkin wrote: > > > On Wed, Jan 23, 2019 at 10:59:27AM +0800, Zhang, Yi wrote: > > > > From: &quo

Re: [Qemu-devel] [PATCH V10 0/4] support MAP_SYNC for memory-backend-file

2019-01-22 Thread Yi Zhang
On 2019-01-22 at 22:01:58 -0500, Michael S. Tsirkin wrote: > On Wed, Jan 23, 2019 at 10:59:27AM +0800, Zhang, Yi wrote: > > From: "Zhang,Yi" > > > > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > >

Re: [Qemu-devel] [PATCH V9 2/6] memory: use sparse feature define RAM_FLAG.

2019-01-21 Thread Yi Zhang
On 2019-01-21 at 15:24:17 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 21, 2019 at 02:35:57PM +0800, Yi Zhang wrote: > > On 2019-01-16 at 10:55:33 -0500, Michael S. Tsirkin wrote: > > > On Wed, Jan 16, 2019 at 04:10:29PM +0800, Zhang Yi wrote: > > > > Signed-off-by

Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-21 Thread Yi Zhang
On 2019-01-21 at 12:44:00 -0200, Eduardo Habkost wrote: > On Mon, Jan 21, 2019 at 01:15:36PM +0800, Yi Zhang wrote: > > On 2019-01-18 at 16:11:47 -0200, Eduardo Habkost wrote: > [...] > > > Anyway, I see a more fundamental problem in each version of this > > > patch

Re: [Qemu-devel] [PATCH V9 6/6] docs: Added MAP_SYNC documentation

2019-01-21 Thread Yi Zhang
On 2019-01-21 at 02:21:39 -0500, Pankaj Gupta wrote: > > > > > --- > > > > docs/nvdimm.txt | 21 - > > > > qemu-options.hx | 4 > > > > 2 files changed, 24 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt > > > > index

Re: [Qemu-devel] [PATCH V9 2/6] memory: use sparse feature define RAM_FLAG.

2019-01-20 Thread Yi Zhang
On 2019-01-16 at 10:55:33 -0500, Michael S. Tsirkin wrote: > On Wed, Jan 16, 2019 at 04:10:29PM +0800, Zhang Yi wrote: > > Signed-off-by: Zhang Yi > > Signed-off-by: Michael S. Tsirkin > > OK so if you apply this patch, do you get > any sparse warning at all? Didn't get any sparse warning. > >

Re: [Qemu-devel] [PATCH V9 6/6] docs: Added MAP_SYNC documentation

2019-01-20 Thread Yi Zhang
On 2019-01-16 at 10:40:23 -0500, Michael S. Tsirkin wrote: > On Wed, Jan 16, 2019 at 04:11:16PM +0800, Zhang Yi wrote: > > Signed-off-by: Zhang Yi > > --- > > docs/nvdimm.txt | 21 - > > qemu-options.hx | 4 > > 2 files changed, 24 insertions(+), 1 deletion(-) > > > >

Re: [Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-20 Thread Yi Zhang
On 2019-01-18 at 16:11:47 -0200, Eduardo Habkost wrote: > On Wed, Jan 16, 2019 at 10:58:44AM -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 16, 2019 at 04:10:58PM +0800, Zhang Yi wrote: > > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > > > MAP_SYNC flag in addition

Re: [Qemu-devel] Devdax backend for vnvdimm not working

2019-01-15 Thread Yi Zhang
On 2019-01-15 at 22:51:09 +, Kamal Kakri via Qemu-devel wrote: > My devdax device is 2MB aligned so I dont think this is alignment related.# > ndctl list -X -n namespace0.0 > [ >   { >     "dev":"namespace0.0", >     "mode":"devdax", >     "map":"dev", >     "size":16909336576, >    

Re: [Qemu-devel] Devdax backend for vnvdimm not working

2019-01-15 Thread Yi Zhang
On 2019-01-16 at 09:12:33 +0800, Wei Yang wrote: > On Tue, Jan 15, 2019 at 08:13:27PM +, Kamal Kakri via Qemu-devel wrote: > >Hi, > > > >I have a namespace (backed by real nvdimm h/w) configured in devdax mode: > ># ndctl list -N -n namespace0.0 > >[ > >  { > >    "dev":"namespace0.0", > >   

Re: [Qemu-devel] [PATCH V8 5/5] hostmem-file: add 'sync' option

2019-01-14 Thread Yi Zhang
On 2019-01-14 at 22:31:45 -0500, Michael S. Tsirkin wrote: > On Wed, Jan 02, 2019 at 01:26:34PM +0800, Zhang Yi wrote: > > This option controls will mmap the memory backend file with MAP_SYNC flag, > > which can ensure filesystem metadata consistent even after a system crash > > or power failure,

Re: [Qemu-devel] [PATCH V8 5/5] hostmem-file: add 'sync' option

2019-01-14 Thread Yi Zhang
On 2019-01-14 at 17:39:38 -0200, Eduardo Habkost wrote: > On Wed, Jan 02, 2019 at 01:26:34PM +0800, Zhang Yi wrote: > > This option controls will mmap the memory backend file with MAP_SYNC flag, > > which can ensure filesystem metadata consistent even after a system crash > > or power failure, if

Re: [Qemu-devel] [PATCH V8 3/5] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-14 Thread Yi Zhang
On 2019-01-14 at 17:07:02 -0200, Eduardo Habkost wrote: > On Wed, Jan 02, 2019 at 01:26:15PM +0800, Zhang Yi wrote: > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > > MAP_SYNC flag in addition which can ensure file system metadata > > synced in each guest writes to the

Re: [Qemu-devel] [PATCH V8 2/5] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2019-01-14 Thread Yi Zhang
On 2019-01-14 at 14:04:25 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 14, 2019 at 04:50:36PM -0200, Eduardo Habkost wrote: > > On Wed, Jan 02, 2019 at 01:26:06PM +0800, Zhang Yi wrote: > > > As more flag parameters besides the existing 'shared' are going to be > > > added to qemu_ram_mmap(),

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-24 Thread Yi Zhang
On 2018-12-21 at 11:36:07 -0500, Michael S. Tsirkin wrote: > On Fri, Dec 21, 2018 at 11:18:18AM +0800, Yi Zhang wrote: > > On 2018-12-20 at 09:06:41 -0500, Michael S. Tsirkin wrote: > > > On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi Zhang wrote: > > > > On 2018-12-1

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-20 Thread Yi Zhang
On 2018-12-20 at 09:06:41 -0500, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2018 at 01:37:40PM +0800, Yi Zhang wrote: > > On 2018-12-19 at 22:42:07 -0500, Michael S. Tsirkin wrote: > > > On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi Zhang wrote: > > > > On 2018-12-1

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Yi Zhang
On 2018-12-19 at 22:42:07 -0500, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2018 at 11:03:12AM +0800, Yi Zhang wrote: > > On 2018-12-19 at 10:59:10 -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi Zhang wrote: > > > > >

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Yi Zhang
On 2018-12-19 at 10:59:10 -0500, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2018 at 05:10:18PM +0800, Yi Zhang wrote: > > > > + > > > > + - 'sync' option of memory-backend-file is not 'off', and > > > > + > > > > + - 'share' option of memor

Re: [Qemu-devel] [PATCH V7 3/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2018-12-19 Thread Yi Zhang
On 2018-12-18 at 08:52:09 -0500, Michael S. Tsirkin wrote: > On Tue, Dec 18, 2018 at 04:17:12PM +0800, Zhang Yi wrote: > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > > MAP_SYNC flag in addition can guarantee the persistence of guest write > > to the backend file without

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Yi Zhang
On 2018-12-18 at 09:18:50 -0500, Michael S. Tsirkin wrote: > On Tue, Dec 18, 2018 at 04:17:39PM +0800, Zhang Yi wrote: > > This option controls whether QEMU mmap(2) > > will mmap > > > the memory backend file with > > MAP_SYNC flag, which could consistent filesystem metadata > > I'm not sure

Re: [Qemu-devel] [PATCH V6 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-12-17 Thread Yi Zhang
On 2018-12-17 at 10:27:50 -0500, Michael S. Tsirkin wrote: > On Mon, Dec 17, 2018 at 01:53:54PM +0800, Yi Zhang wrote: > > On 2018-12-12 at 10:06:13 -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 12, 2018 at 04:11:44PM +0800, Zhang Yi wrote: > > > > Linux 4

Re: [Qemu-devel] [PATCH V6 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-12-16 Thread Yi Zhang
On 2018-12-12 at 10:06:13 -0500, Michael S. Tsirkin wrote: > On Wed, Dec 12, 2018 at 04:11:44PM +0800, Zhang Yi wrote: > > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > > files on ext4/xfs file

Re: [Qemu-devel] [PATCH v5 0/7] nvdimm: support MAP_SYNC for memory-backend-file

2018-12-11 Thread Yi Zhang
On 2018-12-05 at 09:59:23 +, Stefan Hajnoczi wrote: > On Mon, Nov 05, 2018 at 04:07:50PM +0800, Zhang Yi wrote: > > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > > files on ext4/xfs file system

Re: [Qemu-devel] [PATCH V5_resend 7/7] hostmem-file: add 'sync' option

2018-12-03 Thread Yi Zhang
On 2018-11-26 at 03:46:50 -0500, Pankaj Gupta wrote: > > > > > This option controls whether QEMU mmap(2) the memory backend file with > > MAP_SYNC flag, which can fully guarantee the guest write persistence > > Not sure 'persistence' is the right word here. I think it should be > something like

Re: [Qemu-devel] [PATCH V5_resend 3/7] exec: switch qemu_ram_alloc_from_{file, fd} to the 'flags' parameter

2018-12-03 Thread Yi Zhang
On 2018-11-29 at 04:11:11 -0500, Pankaj Gupta wrote: > > > > > As more flag parameters besides the existing 'share' are going to be > > added to qemu_ram_alloc_from_{file,fd}(), let's swith 'share' to a > > 'flags' parameters in advance, so as to ease the further additions. > > > >

Re: [Qemu-devel] [PATCH V5_resend 0/7] nvdimm: support MAP_SYNC for memory-backend-file

2018-11-25 Thread Yi Zhang
Ping for any review/comments Thanks Yi On 2018-11-20 at 15:47:58 +0800, Zhang Yi wrote: > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > files on ext4/xfs file system mounted with '-o dax'). > > A

Re: [Qemu-devel] [PATCH 2/2] nvdimm: use IS_NVDIMM macro

2018-09-27 Thread Yi Zhang
On 2018-09-21 at 15:13:32 +0400, Marc-André Lureau wrote: Thanks for the improvemnet. Reviewed-by: Zhang Yi > Put into use the macros proposed in the previous Object documentation change. > > Signed-off-by: Marc-André Lureau > --- > include/hw/mem/nvdimm.h | 1 + > hw/acpi/ich9.c |

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-20 Thread Yi Zhang
On 2018-09-19 at 14:29:57 +0400, Marc-André Lureau wrote: > Hi > > On Tue, Sep 18, 2018 at 7:49 PM Dr. David Alan Gilbert > wrote: > > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > Hi > > > > > > On Tue, Sep 11, 2018 at 6:19 PM Laszlo Ersek wrote: > > > > > > > > +Alex, due

Re: [Qemu-devel] [PULL 4/7] hostmem-file: add the 'pmem' option

2018-08-28 Thread Yi Zhang
On 2018-08-24 at 20:14:37 +0300, Michael S. Tsirkin wrote: > On Fri, Aug 24, 2018 at 05:57:06PM +0100, Peter Maydell wrote: > > On 24 August 2018 at 17:53, Michael S. Tsirkin wrote: > > > On Fri, Aug 24, 2018 at 04:13:18PM +0100, Peter Maydell wrote: > > >> object_get_canonical_path_component()