Re: [PATCH 0/1] qemu-options.hx: Update descriptions of memory options

2023-04-13 Thread Yohei Kojima
I forgot to add v2 prefix to the subject. This is a revised patch from: https://patchew.org/QEMU/tyzpr06mb5418d6b0175a49e8e76988439d...@tyzpr06mb5418.apcprd06.prod.outlook.com/ On 2023/04/13 21:15, Yohei Kojima wrote: > This patch updates an outdated description in qemu-options.hx. > The

[PATCH 1/1] qemu-options.hx: Update descriptions of memory options for NUMA node

2023-04-13 Thread Yohei Kojima
, and it was a bit confusing. Related documantations: [1] https://wiki.qemu.org/ChangeLog/5.1#Incompatible_changes [2] https://www.qemu.org/docs/master/about/removed-features.html Signed-off-by: Yohei Kojima --- qemu-options.hx | 26 +- 1 file changed, 17 insertions(+), 9

[PATCH 0/1] qemu-options.hx: Update descriptions of memory options

2023-04-13 Thread Yohei Kojima
example Yohei Kojima (1): qemu-options.hx: Update descriptions of memory options for NUMA node qemu-options.hx | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.39.2

Re: [PATCH] qemu-options.hx: Update descriptions of memory options for NUMA node

2023-04-13 Thread Yohei Kojima
Thank you for the review. I will reflect them in the next version. On 2023/04/11 21:57, Alex Bennée wrote: > > Yohei Kojima writes: > >> This commit adds the following description: >> 1. `memdev` option is recommended over `mem` option (see [1,2]) >> 2. users must

Re: [PATCH] qemu-options.hx: Update descriptions of memory options for NUMA node

2023-04-11 Thread Yohei Kojima
/tyzpr06mb5418d6b0175a49e8e76988439d...@tyzpr06mb5418.apcprd06.prod.outlook.com/ On 2023/03/30 19:09, Yohei Kojima wrote: > This commit adds the following description: > 1. `memdev` option is recommended over `mem` option (see [1,2]) > 2. users must specify memory for all NUMA nodes (see [2]) > > T

Re: [PATCH v3 1/4] util: Add thread-safe qemu_strerror() function

2023-04-06 Thread Yohei Kojima
On 2023/04/06 17:57, Alex Bennée wrote: > > Yohei Kojima writes: > >> On 2023/03/31 4:06, Markus Armbruster wrote: >>> Yohei Kojima writes: >>> >>>> Add qemu_strerror() which follows the POSIX specification for >>>> strerro

Re: [PATCH v3 0/4] util: Add thread-safe qemu_strerror() function

2023-04-02 Thread Yohei Kojima
tch series that is hard to merge. In short, fixes line is not added to avoid closing and reopening the partially fixed issue. The patch series is incomplete because the complete patch series will be very large. On 2023/03/31 2:07, Yohei Kojima wrote: > This patch series adds qemu_strerror() function, wh

Re: [PATCH] qemu-options.hx: Update descriptions of memory options for NUMA node

2023-04-02 Thread Yohei Kojima
I add more detailed explanation for the documentation update here. On 2023/03/30 19:09, Yohei Kojima wrote: > This commit adds the following description: > 1. `memdev` option is recommended over `mem` option (see [1,2]) > 2. users must specify memory for all NUMA nodes (see [2]) > &

Re: [PATCH v3 1/4] util: Add thread-safe qemu_strerror() function

2023-03-30 Thread Yohei Kojima
On 2023/03/31 4:06, Markus Armbruster wrote: > Yohei Kojima writes: > >> Add qemu_strerror() which follows the POSIX specification for >> strerror(). While strerror() is not guaranteed to be thread-safe, this >> function is thread-safe. > > Why not g_strerror()?

[PATCH v3 4/4] target/i386: replace strerror() function to the thread safe qemu_strerror()

2023-03-30 Thread Yohei Kojima
strerror() is not guaranteed to be thread-safe as described in (https://gitlab.com/qemu-project/qemu/-/issues/416). This commit changes files under /target/i386 that call strerror() to call the safer qemu_strerror(). Signed-off-by: Yohei Kojima --- target/i386/kvm/kvm.c | 49

[PATCH v3 2/4] linux-user: replace strerror() function to the thread safe qemu_strerror()

2023-03-30 Thread Yohei Kojima
strerror() is not guaranteed to be thread-safe as described in (https://gitlab.com/qemu-project/qemu/-/issues/416). This commit changes files under /linux-user that call strerror() to call the safer qemu_strerror(). Signed-off-by: Yohei Kojima Reviewed-by: Alex Bennée --- linux-user/elfload.c

[PATCH v3 1/4] util: Add thread-safe qemu_strerror() function

2023-03-30 Thread Yohei Kojima
Add qemu_strerror() which follows the POSIX specification for strerror(). While strerror() is not guaranteed to be thread-safe, this function is thread-safe. This function is added to solve the following issue: https://gitlab.com/qemu-project/qemu/-/issues/416 Signed-off-by: Yohei Kojima

[PATCH v3 3/4] accel: replace strerror() function to the thread safe qemu_strerror()

2023-03-30 Thread Yohei Kojima
strerror() is not guaranteed to be thread-safe as described in (https://gitlab.com/qemu-project/qemu/-/issues/416). This commit changes files under /accel that call strerror() to call the safer qemu_strerror(). Signed-off-by: Yohei Kojima --- accel/kvm/kvm-all.c | 32

[PATCH v3 0/4] util: Add thread-safe qemu_strerror() function

2023-03-30 Thread Yohei Kojima
different return types between architectures because of the historical reason. qemu_strerror() handles both the newer POSIX strerror() and the older POSIX strerror(). All tests except for skipped ones are passed in my environment (x86_64 linux). Yohei Kojima (4): util: Add thread-safe qem

Re: [RFC PATCH v2 2/2] linux-user: replace strerror() function to the thread safe qemu_strerror()

2023-03-30 Thread Yohei Kojima
On 2023/03/30 23:08, Alex Bennée wrote: > > Yohei Kojima writes: > >> strerror() is not guaranteed to be thread-safe as described in >> (https://gitlab.com/qemu-project/qemu/-/issues/416). >> >> This commit changes files under /linux-user that cal

[PATCH] qemu-options.hx: Update descriptions of memory options for NUMA node

2023-03-30 Thread Yohei Kojima
, and it was a bit confusing. Related documantations: [1] https://wiki.qemu.org/ChangeLog/5.1#Incompatible_changes [2] https://www.qemu.org/docs/master/about/removed-features.html Signed-off-by: Yohei Kojima --- qemu-options.hx | 25 - 1 file changed, 16 insertions(+), 9

Re: [RFC PATCH v2 1/2] util: Add thread-safe qemu_strerror() function

2023-03-14 Thread Yohei Kojima
/qemu-devel/tyzpr06mb5418216269d0ed2eb37d6ff49d...@tyzpr06mb5418.apcprd06.prod.outlook.com/T/#u Thank you. On 2023/03/14 15:40, Yohei Kojima wrote: > Add qemu_strerror() which follows the POSIX specification for > strerror(). While strerror() is not guaranteed to be thread-safe, this >

[RFC PATCH v2 0/2] util: Add thread-safe qemu_strerror() function

2023-03-14 Thread Yohei Kojima
POSIX strerror() and the older POSIX strerror(). All tests except for skipped ones are passed in my environment (x86_64 linux). Yohei Kojima (2): util: Add thread-safe qemu_strerror() function linux-user: replace strerror() function to the thread safe qemu_strerror() include/qemu/cutils.h

[RFC PATCH v2 2/2] linux-user: replace strerror() function to the thread safe qemu_strerror()

2023-03-14 Thread Yohei Kojima
strerror() is not guaranteed to be thread-safe as described in (https://gitlab.com/qemu-project/qemu/-/issues/416). This commit changes files under /linux-user that call strerror() to call the safer qemu_strerror(). Signed-off-by: Yohei Kojima --- linux-user/elfload.c | 4 ++-- linux-user

[RFC PATCH v2 1/2] util: Add thread-safe qemu_strerror() function

2023-03-14 Thread Yohei Kojima
Add qemu_strerror() which follows the POSIX specification for strerror(). While strerror() is not guaranteed to be thread-safe, this function is thread-safe. This function is added to solve the following issue: https://gitlab.com/qemu-project/qemu/-/issues/416 Signed-off-by: Yohei Kojima

[PATCH 0/2] util: Add thread-safe qemu_strerror() function

2023-03-12 Thread Yohei Kojima
, and the strerror_r() function called by qemu_strerror() has different type signatures between architectures because of historical reason, the implementation of qemu_strerror is a bit complicated. All tests except for skipped ones are passed in my environment (x86_64 linux). Yohei Kojima (2): util: Add

[PATCH 2/2] linux-user: replace strerror() function to the thread safe qemu_strerror()

2023-03-12 Thread Yohei Kojima
strerror() is not guaranteed to be thread-safe as described in (https://gitlab.com/qemu-project/qemu/-/issues/416). This commit changes files under /linux-user that call strerror() to call the safer qemu_strerror(). Signed-off-by: Yohei Kojima --- linux-user/elfload.c | 4 ++-- linux-user

[PATCH 1/2] util: Add thread-safe qemu_strerror() function

2023-03-12 Thread Yohei Kojima
Add qemu_strerror() which follows the POSIX specification for strerror(). While strerror() is not guaranteed to be thread-safe, this function is thread-safe. This function is added to solve the following issue: https://gitlab.com/qemu-project/qemu/-/issues/416 Signed-off-by: Yohei Kojima