[PATCH 2/2] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-06 Thread Yonggang Luo
Using a prepared https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz for speed up the msys2/mingw prepare speed on the cirrus CI. This file are generated by the msys2.docker Signed-off-by: Yonggang Luo --- .cirrus.yml | 60

[PATCH 0/2] Improve cirrus msys2

2020-10-06 Thread Yonggang Luo
Fixes the broken msys2/mingw ci and speed it up. Yonggang Luo (2): docker: Add win32/msys2/mingw64 docker cirrus: Fixing and speedup the msys2/mingw CI .cirrus.yml | 60 +++ tests/docker/dockerfiles/msys2.docker | 57

[PATCH 1/2] docker: Add win32/msys2/mingw64 docker

2020-10-06 Thread Yonggang Luo
This docker is used to preparing a msys2/mingw with basic software installed. Signed-off-by: Yonggang Luo --- tests/docker/dockerfiles/msys2.docker | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 tests/docker/dockerfiles/msys2.docker diff --git a/tests

[PATCH v5 5/7] plugin: Getting qemu-plugin works under win32.

2020-10-06 Thread Yonggang Luo
and loading it in qemu_plugin_initialize, so we need a list of function pointer deceleration such as QEMU_PLUGIN_EXTERN qemu_plugin_uninstall_t qemu_plugin_uninstall; Signed-off-by: Yonggang Luo --- Makefile | 1 - configure| 71 -- include/qemu/qemu

[PATCH v5 6/7] plugin: Getting qemu-plugin.h can be included in multiple source file

2020-10-06 Thread Yonggang Luo
are user and should use extern Signed-off-by: Yonggang Luo --- contrib/plugins/hotblocks.c | 1 + contrib/plugins/hotpages.c | 1 + contrib/plugins/howvec.c| 1 + contrib/plugins/lockstep.c | 1 + include/qemu/qemu-plugin.h | 8 plugins/core.c | 1 + tests/plugin/bb.c

[PATCH v5 4/7] plugin: Fixes typo in qemu-plugin.h

2020-10-06 Thread Yonggang Luo
Getting the comment consistence with the function name Signed-off-by: Yonggang Luo --- include/qemu/qemu-plugin.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index bab8b0d4b3..daac8291b8 100644 --- a/include

[PATCH v5 7/7] cirrus: Enable plugin in cirrus for windows

2020-10-06 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 86ea33926a..5363142373 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -104,7 +104,8 @@ windows_msys2_task: - C:\tools\msys64\usr\bin\bash.exe -lc

[PATCH v5 3/7] plugin: getting qemu_plugin_get_hwaddr only expose one function prototype

2020-10-06 Thread Yonggang Luo
This is used for counting how much function are export to qemu plugin. Signed-off-by: Yonggang Luo Reviewed-by: Alex Bennée --- plugins/api.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/plugins/api.c b/plugins/api.c index bbdc5a4eb4..13177d3578 100644

[PATCH v5 1/7] plugins: Fixes a issue when dlsym failed, the handle not closed

2020-10-06 Thread Yonggang Luo
Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- plugins/loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/loader.c b/plugins/loader.c index 685d334e1a..8ac5dbc20f 100644 --- a/plugins/loader.c +++ b/plugins/loader.c @@ -235,6

[PATCH v5 2/7] plugin: Fixes compiling errors on msys2/mingw

2020-10-06 Thread Yonggang Luo
Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- contrib/plugins/hotblocks.c | 2 +- tests/plugin/bb.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index

[PATCH v5 0/7] Enable plugin support on msys2/mingw

2020-10-06 Thread Yonggang Luo
. By export function qemu_plugin_initialize in plugin, and call it in loader= , so we have no need call it in every plugin. And also provide a standard implem= entation, anyway, use can also override it. Add this feature on msys2/mingw by using glib provided cross-platform dlsym f= unctional. Yonggang

Re: [PATCH v3 6/6] plugin: Getting qemu-plugin works under win32.

2020-10-06 Thread Yonggang Luo
On Tue, Oct 6, 2020 at 7:29 PM Alex Bennée wrote: > > > Yonggang Luo writes: > > > We removed the need of .symbols file, so is the > > configure script, if we one expose a function to qemu-plugin > > just need prefix the function with QEMU_PLUGIN_EXPORT >

Re: [PATCH v5] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-06 Thread Yonggang Luo
On Tue, Oct 6, 2020 at 7:34 PM Paolo Bonzini wrote: > > On 06/10/20 13:21, Yonggang Luo wrote: > > The sh script are harder to maintain for compatible different > > xsh environment so convert it to python script > > Also incorporate the fixes in > > https://patchew.

[PATCH v5] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-06 Thread Yonggang Luo
to '' Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/qemu-version.py | 31 +++ scripts/qemu-version.sh | 25 - 3 files changed, 32 insertions(+), 26 deletions(-) create mode 100644 scripts/qemu-version.py delete mode 100755

[PATCH v4] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-06 Thread Yonggang Luo
to '' Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/qemu-version.py | 31 +++ scripts/qemu-version.sh | 25 - 3 files changed, 32 insertions(+), 26 deletions(-) create mode 100644 scripts/qemu-version.py delete mode 100755

Re: [PATCH v3] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-06 Thread Yonggang Luo
On Tue, Oct 6, 2020 at 6:33 PM Peter Maydell wrote: > > On Mon, 5 Oct 2020 at 20:51, Yonggang Luo wrote: > > > > The sh script are harder to maintain for compatible different > > xsh environment so convert it to python script > > Also incorporate the fixes i

Re: [PATCH v2] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-05 Thread Yonggang Luo
On Tue, Oct 6, 2020 at 3:23 AM Peter Maydell wrote: > > On Mon, 5 Oct 2020 at 18:24, Yonggang Luo wrote: > > > > The sh script are harder to maintain for compatible different > > xsh environment > > > > Signed-off-by: Yonggang Luo > > --- > > m

[PATCH v3] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-05 Thread Yonggang Luo
to '' Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/qemu-version.py | 37 + scripts/qemu-version.sh | 25 - 3 files changed, 38 insertions(+), 26 deletions(-) create mode 100644 scripts/qemu-version.py delete mode

Re: [PATCH v2] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-05 Thread Yonggang Luo
On Tue, Oct 6, 2020 at 2:10 AM Philippe Mathieu-Daudé wrote: > > On 10/5/20 7:21 PM, Yonggang Luo wrote: > > The sh script are harder to maintain for compatible different > > xsh environment > > > > Signed-off-by: Yonggang Luo > > --- > > What are the c

[PATCH v2] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-05 Thread Yonggang Luo
The sh script are harder to maintain for compatible different xsh environment Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/qemu-version.py | 30 ++ scripts/qemu-version.sh | 25 - 3 files changed, 31 insertions

[PATCH] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-05 Thread Yonggang Luo
The sh script are harder to maintain for compatible different xsh environment Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/qemu-version.py | 29 + scripts/qemu-version.sh | 25 - 3 files changed, 30 insertions

Re: [RFC PATCH] scripts/qemu-version.sh: Always describe tag version

2020-10-05 Thread Yonggang Luo
emu-version.sh > @@ -9,7 +9,7 @@ version="$3" > if [ -z "$pkgversion" ]; then > cd "$dir" > if [ -e .git ]; then > -pkgversion=$(git describe --match 'v*' --dirty | echo "") > +pkgversion=$(git describe --match 'v*' --dirty --always | echo "") > fi > fi > > -- > 2.26.2 > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

[PATCH v4 6/6] cirrus: Enable plugin in cirrus for windows

2020-10-05 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 86ea33926a..5363142373 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -104,7 +104,8 @@ windows_msys2_task: - C:\tools\msys64\usr\bin\bash.exe -lc

[PATCH v4 4/6] plugin: Fixes typo in qemu-plugin.h

2020-10-05 Thread Yonggang Luo
Getting the comment consistence with the function name Signed-off-by: Yonggang Luo --- include/qemu/qemu-plugin.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index bab8b0d4b3..daac8291b8 100644 --- a/include

Re: [PATCH v8 000/133] Fixes curses on msys2/mingw

2020-10-05 Thread Yonggang Luo
Err, sorry for this, don't know if this would broken the patchew On Mon, Oct 5, 2020 at 11:54 PM Yonggang Luo wrote: > > V7-V8 > Rebase to master and resolve conflict of > *configure: fixes indent of $meson setup > > V6-V7 > Update the configure script for > * curs

[PATCH v4 5/6] plugin: Getting qemu-plugin works under win32.

2020-10-05 Thread Yonggang Luo
, then we need distinguish the implementation and the deceleration. only the main .c file should define the macro QEMU_PLUGIN_IMPLEMENTATION other sources are user and should use extern Signed-off-by: Yonggang Luo --- Makefile | 1 - configure| 71

[PATCH v4 3/6] plugin: getting qemu_plugin_get_hwaddr only expose one function prototype

2020-10-05 Thread Yonggang Luo
This is used for counting how much function are export to qemu plugin. Signed-off-by: Yonggang Luo Reviewed-by: Alex Bennée --- plugins/api.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/plugins/api.c b/plugins/api.c index bbdc5a4eb4..13177d3578 100644

[PATCH v4 1/6] plugins: Fixes a issue when dlsym failed, the handle not closed

2020-10-05 Thread Yonggang Luo
Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- plugins/loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/loader.c b/plugins/loader.c index 685d334e1a..8ac5dbc20f 100644 --- a/plugins/loader.c +++ b/plugins/loader.c @@ -235,6

[PATCH v4 2/6] plugin: Fixes compiling errors on msys2/mingw

2020-10-05 Thread Yonggang Luo
Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- contrib/plugins/hotblocks.c | 2 +- tests/plugin/bb.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index

[PATCH v4 0/6] Enable plugin support on msys2/mingw

2020-10-05 Thread Yonggang Luo
. By export function qemu_plugin_initialize in plugin, and call it in loader= , so we have no need call it in every plugin. And also provide a standard implem= entation, anyway, use can also override it. Add this feature on msys2/mingw by using glib provided cross-platform dlsym f= unctional. Yonggang

[PATCH v8 4/4] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw

2020-10-05 Thread Yonggang Luo
) ? NULL : _Str; } __forceinline char *__CRTDECL asctime_r(const struct tm *_Tm, char * _Str) { return asctime_s(_Str, 0x7fff, _Tm) ? NULL : _Str; } #endif ``` Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- configure | 34 --

[PATCH v8 1/4] configure: fixes indent of $meson setup

2020-10-05 Thread Yonggang Luo
convert these line from tab to space Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 66641099fc..7d5ffee29a 100755 --- a/configure +++ b/configure

[PATCH v8 0/4] Fixes curses on msys2/mingw

2020-10-05 Thread Yonggang Luo
the= m to meson first. That need the meson 0.56 upstream to fixes the curses detection. Add * configure: fixes indent of $meson setup Yonggang Luo (4): configure: fixes indent of $meson setup curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw curses: Fixes curses

[PATCH v8 3/4] curses: Fixes curses compiling errors.

2020-10-05 Thread Yonggang Luo
as errors gcc version 10.2.0 (Rev1, Built by MSYS2 project) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 12bc682cf9..e4f9588c3e

Re: [PATCH v3 4/6] plugin: define QEMU_PLUGIN_API_IMPLEMENTATION first

2020-10-05 Thread Yonggang Luo
Hi, I split this out just for easier review, so the lines changed in api.c and core.c equales to the number of function exported, anyway On Mon, Oct 5, 2020 at 6:44 PM Alex Bennée wrote: > > > Yonggang Luo writes: > > > This is used to distinguish from the qemu and plugin

[PATCH v8 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-05 Thread Yonggang Luo
using g_get_codeset instead of nl_langinfo(CODESET) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé --- configure | 5 + ui/curses.c | 10 +- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/configure b/configure index

[PATCH v8 001/133] target/arm: Replace ARM_FEATURE_PXN with ID_MMFR0.VMSA check

2020-10-05 Thread Yonggang Luo
From: Peter Maydell The ARM_FEATURE_PXN bit indicates whether the CPU supports the PXN bit in short-descriptor translation table format descriptors. This is indicated by ID_MMFR0.VMSA being at least 0b0100. Replace the feature bit with an ID register check, in line with our preference for ID

[PATCH v8 000/133] Fixes curses on msys2/mingw

2020-10-05 Thread Yonggang Luo
d MinGW cross-compiler tests tests/docker: Remove old Debian 9 containers gitlab-ci: Increase the timeout for the cross-compiler builds configure: Bump the minimum required Python version to 3.6 tests/check-block: Do not run the iotests with old versions of bash Yonggang Luo (5): gitignore:

Re: [PATCH v3 5/6] plugin: getting qemu_plugin_get_hwaddr only expose one function prototype

2020-10-05 Thread Yonggang Luo
On Mon, Oct 5, 2020 at 6:48 PM Alex Bennée wrote: > > > Yonggang Luo writes: > > > This is used for counting how much function are export to qemu plugin. > > > > Signed-off-by: Yonggang Luo > > --- > > plugins/api.c | 8 +++- > > 1 file chang

Re: [PATCH v7 0/4] Fixes curses on msys2/mingw

2020-10-05 Thread Yonggang Luo
8:37AM +0800, Yonggang Luo wrote: > > V6-V7 > > Update the configure script for > > * curses: Fixes compiler error that complain don't have langinfo.h on msys2/m= > > ingw > > > > V5-V6 > > Dropping configure: Fixes ncursesw detection under msys2/min

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-03 Thread Yonggang Luo
On Sat, Oct 3, 2020 at 4:43 PM Paolo Bonzini wrote: > > On 03/10/20 10:29, 罗勇刚(Yonggang Luo) wrote: > > For some meson script like this: > > curses = not_found > > if iconv.found() and not get_option('curses').disabled() > > curses_libname_list = ['ncursesw', '

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-03 Thread Yonggang Luo
On Sat, Oct 3, 2020 at 3:50 PM Paolo Bonzini wrote: > > On 03/10/20 09:24, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Fri, Oct 2, 2020 at 9:11 PM Peter Maydell > <mailto:peter.mayd...@linaro.org>> wrote: > >> > >> On Fri, 2 Oct 2020 at 14:05

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-03 Thread Yonggang Luo
On Sat, Oct 3, 2020 at 3:50 PM Paolo Bonzini wrote: > > On 03/10/20 09:24, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Fri, Oct 2, 2020 at 9:11 PM Peter Maydell > <mailto:peter.mayd...@linaro.org>> wrote: > >> > >> On Fri, 2 Oct 2020 at 14:05

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-03 Thread Yonggang Luo
dency('libudev', >required: get_option('mpath').enabled(), >static: enable_static) > Hi Bonzini, This looks like a frequently used function, can we upstrem to meson? > for those dependencies that want to do the "does this compile" > check ? > > thanks > -- PMM > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

[PATCH v7 0/4] Fixes curses on msys2/mingw

2020-10-02 Thread Yonggang Luo
* configure: fixes indent of $meson setup Yonggang Luo (4): configure: fixes indent of $meson setup curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw curses: Fixes curses compiling errors. win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE

[PATCH v7 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Yonggang Luo
using g_get_codeset instead of nl_langinfo(CODESET) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann --- configure | 5 + ui/curses.c | 10 +- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 8f7bdbfdd3..fa53bd5c43 100755

Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Yonggang Luo
gotcha On Sat, Oct 3, 2020 at 1:49 AM Paolo Bonzini wrote: > > On 02/10/20 19:47, 罗勇刚(Yonggang Luo) wrote: > > Because the configure script change far more complicated than you > > imgaine. And I post that before > > Daniel is literally asking for a two-line change: >

Re: [PATCH v2 03/21] configure: Fixes ncursesw detection under msys2/mingw and enable curses

2020-10-02 Thread Yonggang Luo
You can queue this instead On Wed, Sep 9, 2020 at 5:46 PM Yonggang Luo wrote: > > The mingw pkg-config are showing following absolute path and contains : as the separator, > so we must handling : properly. > > -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L -IC:/CI-Tools/msys64/

Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Yonggang Luo
On Sat, Oct 3, 2020 at 12:42 AM Daniel P. Berrangé wrote: > > On Sat, Oct 03, 2020 at 12:38:50AM +0800, 罗勇刚(Yonggang Luo) wrote: > > On Fri, Oct 2, 2020 at 11:36 PM Daniel P. Berrangé > > wrote: > > > > > > On Fri, Oct 02, 2020 at 01:32:28AM +0800, Yonggang

Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Yonggang Luo
On Fri, Oct 2, 2020 at 11:36 PM Daniel P. Berrangé wrote: > > On Fri, Oct 02, 2020 at 01:32:28AM +0800, Yonggang Luo wrote: > > msys2/mingw lacks the POSIX-required langinfo.h. > > > > gcc test.c -DNCURSES_WIDECHAR -I/mingw64/include/ncursesw -pipe -lncursesw -lgn

Re: [PATCH] meson.build: Don't look for libudev for static builds

2020-10-02 Thread Yonggang Luo
required: get_option('mpath').enabled(), > static: enable_static) > -- > 2.20.1 > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v2 1/2] doc: Remove texi referenced in qemu-img-cmds.hx and target/i386/cpu.c

2020-10-02 Thread Yonggang Luo
OK, then skip this On Fri, Oct 2, 2020 at 1:15 PM Markus Armbruster wrote: > > Yonggang Luo writes: > > > There is no texi document anymore > > > > Signed-off-by: Yonggang Luo > > --- > > qemu-img-cmds.hx | 2 +- > > target/i386/cpu.c | 2 +- >

[PATCH v6 4/4] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw

2020-10-01 Thread Yonggang Luo
) ? NULL : _Str; } __forceinline char *__CRTDECL asctime_r(const struct tm *_Tm, char * _Str) { return asctime_s(_Str, 0x7fff, _Tm) ? NULL : _Str; } #endif ``` Signed-off-by: Yonggang Luo --- configure | 34 -- include/sysemu/os-win32.h | 4 ++

[PATCH v6 3/4] curses: Fixes curses compiling errors.

2020-10-01 Thread Yonggang Luo
as errors gcc version 10.2.0 (Rev1, Built by MSYS2 project) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 12bc682cf9..e4f9588c3e

[PATCH v6 0/4] Fixes curses on msys2/mingw

2020-10-01 Thread Yonggang Luo
And also convert related configure script to meson. V5-V6 Dropping configure: Fixes ncursesw detection under msys2/mingw by convert the= m to meson first. That need the meson 0.56 upstream to fixes the curses detection. Add * configure: fixes indent of $meson setup Yonggang Luo (4): configure

[PATCH v2 1/2] doc: Remove texi referenced in qemu-img-cmds.hx and target/i386/cpu.c

2020-10-01 Thread Yonggang Luo
There is no texi document anymore Signed-off-by: Yonggang Luo --- qemu-img-cmds.hx | 2 +- target/i386/cpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index b89c019b76..cab8234235 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img

[PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-01 Thread Yonggang Luo
using g_get_codeset instead of nl_langinfo(CODESET) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann --- ui/curses.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index a59b23a9cf..12bc682cf9 100644 --- a/ui/curses.c +++ b/ui

[PATCH v6 1/4] configure: fixes indent of $meson setup

2020-10-01 Thread Yonggang Luo
convert these line from tab to space Signed-off-by: Yonggang Luo --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index ca9b458ea0..8f7bdbfdd3 100755 --- a/configure +++ b/configure @@ -7843,10 +7843,10 @@ NINJA=${ninja:-$PWD

[PATCH v2 0/2] Texi cleanup

2020-10-01 Thread Yonggang Luo
Texi cleanup V1-V2 Fixes with doc: Remove texi referenced in qemu-img-cmds.hx and target/i386/cpu.c Yonggang Luo (2): doc: Remove texi referenced in qemu-img-cmds.hx and target/i386/cpu.c doc: remove hxtool-conv.pl qemu-img-cmds.hx | 2 +- scripts/hxtool-conv.pl | 137

[PATCH v3 6/6] plugin: Getting qemu-plugin works under win32.

2020-10-01 Thread Yonggang Luo
We removed the need of .symbols file, so is the configure script, if we one expose a function to qemu-plugin just need prefix the function with QEMU_PLUGIN_EXPORT Signed-off-by: Yonggang Luo --- Makefile | 1 - configure| 71 - contrib

[PATCH v3 5/6] plugin: getting qemu_plugin_get_hwaddr only expose one function prototype

2020-10-01 Thread Yonggang Luo
This is used for counting how much function are export to qemu plugin. Signed-off-by: Yonggang Luo --- plugins/api.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/plugins/api.c b/plugins/api.c index f16922ca8b..d325084385 100644 --- a/plugins/api.c +++ b/plugins

[PATCH v3 4/6] plugin: define QEMU_PLUGIN_API_IMPLEMENTATION first

2020-10-01 Thread Yonggang Luo
This is used to distinguish from the qemu and plugin in header qemu-plugin.h Signed-off-by: Yonggang Luo --- plugins/api.c | 1 + plugins/core.c | 1 + 2 files changed, 2 insertions(+) diff --git a/plugins/api.c b/plugins/api.c index bbdc5a4eb4..f16922ca8b 100644 --- a/plugins/api.c +++ b

[PATCH v3 3/6] cirrus: Enable plugin in cirrus for windows

2020-10-01 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 86ea33926a..5363142373 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -104,7 +104,8 @@ windows_msys2_task: - C:\tools\msys64\usr\bin\bash.exe -lc

[PATCH v3 2/6] plugin: Fixes compiling errors on msys2/mingw

2020-10-01 Thread Yonggang Luo
Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé --- contrib/plugins/hotblocks.c | 2 +- tests/plugin/bb.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 3942a2ca54..37435a3fc7

[PATCH 2/2] doc: remove hxtool-conv.pl

2020-10-01 Thread Yonggang Luo
This script doesn't need anymore as all texi are already convert to rST Signed-off-by: Yonggang Luo --- scripts/hxtool-conv.pl | 137 - 1 file changed, 137 deletions(-) delete mode 100755 scripts/hxtool-conv.pl diff --git a/scripts/hxtool-conv.pl b

[PATCH v3 1/6] plugins: Fixes a issue when dlsym failed, the handle not closed

2020-10-01 Thread Yonggang Luo
Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé --- plugins/loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/loader.c b/plugins/loader.c index 685d334e1a..8ac5dbc20f 100644 --- a/plugins/loader.c +++ b/plugins/loader.c @@ -235,6 +235,7 @@ static int

[PATCH 0/2] Texi cleanup

2020-10-01 Thread Yonggang Luo
Texi cleanup Yonggang Luo (2): doc: more texi cleanup doc: remove hxtool-conv.pl qemu-img-cmds.hx | 2 +- scripts/hxtool-conv.pl | 137 - target/i386/cpu.c | 2 +- 3 files changed, 2 insertions(+), 139 deletions(-) delete mode 100755

[PATCH v3 0/6] Enable plugin support on msys2/mingw

2020-10-01 Thread Yonggang Luo
it in every plugin. And also provide a standard implem= entation, anyway, use can also override it. Add this feature on msys2/mingw by using glib provided cross-platform dlsym f= unctional. Yonggang Luo (6): plugins: Fixes a issue when dlsym failed, the handle not closed plugin: Fixes

[PATCH 1/2] doc: more texi cleanup

2020-10-01 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- qemu-img-cmds.hx | 2 +- target/i386/cpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index b89c019b76..cab8234235 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img-cmds.hx @@ -1,5 +1,5 @@ HXCOMM Keep

Re: [PULL v8 00/86] Misc QEMU patches for 2020-09-24

2020-10-01 Thread Yonggang Luo
t (Eduardo) > > * KVM PV features cleanup (myself) > > * CAN FD (Pavel) > > > > meson: > > * fixes (Marc-André, Max, Stefan, Alexander, myself) > > * moved libmpathpersist, cocoa, malloc tests (myself) > > * support for 0.56 introspected test dependencies (myself) > > > > > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 > for any user-visible changes. > > -- PMM > Long awating, wonderfull -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

hxtool-conv.pl doesn't used anymore, may us remove it now

2020-10-01 Thread Yonggang Luo
-- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v2] build-sys: fix git version from -version

2020-09-29 Thread Yonggang Luo
On Tue, Sep 29, 2020 at 11:33 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > > > > On Tue, Sep 29, 2020 at 6:43 PM 罗勇刚(Yonggang Luo) wrote: >> >> >> >> On Tue, Sep 29, 2020 at 10:38 PM wrote: >> > >> > From:

Re: [PATCH v2] build-sys: fix git version from -version

2020-09-29 Thread Yonggang Luo
t to python? as we are converting to meson+python, for less care about different bash/zsh/xsh differences? -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: I wanna fixes plugin on windows, any suggestion

2020-09-28 Thread Yonggang Luo
On Mon, Sep 28, 2020 at 11:47 PM Alex Bennée wrote: > > > Paolo Bonzini writes: > > > On 25/09/20 21:12, 罗勇刚(Yonggang Luo) wrote: > >> currently the empty.c plugin are failed of linkage error > >> > >> The fowlloing are the failing message: >

Re: [PATCH v2 2/4] plugin: Fixes compiling errors on msys2/mingw

2020-09-27 Thread Yonggang Luo
On Sun, Sep 27, 2020 at 4:45 PM Philippe Mathieu-Daudé wrote: > > On 9/27/20 10:18 AM, Yonggang Luo wrote: > > Signed-off-by: Yonggang Luo > > Reviewed-by: Philippe Mathieu-Daudé > > --- > > contrib/plugins/hotblocks.c | 2 +- > > tests/plugin/bb.c

[PATCH v2 2/4] plugin: Fixes compiling errors on msys2/mingw

2020-09-27 Thread Yonggang Luo
Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé --- contrib/plugins/hotblocks.c | 2 +- tests/plugin/bb.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 3942a2ca54..37435a3fc7

[PATCH v2 1/4] plugins: Fixes a issue when dlsym failed, the handle not closed

2020-09-27 Thread Yonggang Luo
Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé --- plugins/loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/loader.c b/plugins/loader.c index 685d334e1a..8ac5dbc20f 100644 --- a/plugins/loader.c +++ b/plugins/loader.c @@ -235,6 +235,7 @@ static int

[PATCH v2 4/4] Getting qemu-plugin works under win32.

2020-09-27 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- Makefile | 1 - configure| 71 - contrib/plugins/hotblocks.c | 1 + contrib/plugins/hotpages.c | 1 + contrib/plugins/howvec.c | 1 + contrib/plugins/lockstep.c | 1 + include/qemu/qemu

[PATCH v2 3/4] cirrus: Enable plugin in cirrus for windows

2020-09-27 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 86ea33926a..5363142373 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -104,7 +104,8 @@ windows_msys2_task: - C:\tools\msys64\usr\bin\bash.exe -lc

[PATCH v2 0/4] Enable plugin support on msys2/mingw

2020-09-27 Thread Yonggang Luo
a standard implem= entation, anyway, use can also override it. Add this feature on msys2/mingw by using glib provided cross-platform dlsym f= unctional. Yonggang Luo (4): plugins: Fixes a issue when dlsym failed, the handle not closed plugin: Fixes compiling errors on msys2/mingw cirrus

[PATCH 3/4] Getting qemu-plugin works under win32.

2020-09-26 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- Makefile | 1 - configure| 71 -- contrib/plugins/hotblocks.c | 2 + contrib/plugins/hotpages.c | 2 + contrib/plugins/howvec.c | 2 + contrib/plugins/lockstep.c | 2 + include/qemu/qemu

[PATCH 2/4] plugin: Fixes compiling errors on msys2/mingw

2020-09-26 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- contrib/plugins/hotblocks.c | 2 +- tests/plugin/bb.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 3942a2ca54..37435a3fc7 100644 --- a/contrib/plugins/hotblocks.c

[PATCH 1/4] plugins: Fixes a issue when dlsym failed, the handle not closed.

2020-09-26 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- plugins/loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/loader.c b/plugins/loader.c index 685d334e1a..8ac5dbc20f 100644 --- a/plugins/loader.c +++ b/plugins/loader.c @@ -235,6 +235,7 @@ static int plugin_load(struct qemu_plugin_desc *desc

[PATCH 0/4] Enable plugin support on msys2/mingw

2020-09-26 Thread Yonggang Luo
Add this feature on msys2/mingw by using glib provided cross-platform dlsym f= unctional. Yonggang Luo (4): plugins: Fixes a issue when dlsym failed, the handle not closed. plugin: Fixes compiling errors on msys2/mingw Getting qemu-plugin works under win32. cirrus: Enable plugin in cirrus

[PATCH 4/4] cirrus: Enable plugin in cirrus for windows

2020-09-26 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 86ea33926a..5363142373 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -104,7 +104,8 @@ windows_msys2_task: - C:\tools\msys64\usr\bin\bash.exe -lc

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Yonggang Luo
On Sat, Sep 26, 2020 at 4:59 AM Paolo Bonzini wrote: > > On 25/09/20 22:50, Richard Henderson wrote: > > On 9/25/20 12:25 PM, Paolo Bonzini wrote: > >> On 25/09/20 21:23, 罗勇刚(Yonggang Luo) wrote: > >>> That's what I am tring to fixes? what does one import libr

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Yonggang Luo
On Sat, Sep 26, 2020 at 3:25 AM Paolo Bonzini wrote: > > On 25/09/20 21:23, 罗勇刚(Yonggang Luo) wrote: > > That's what I am tring to fixes? what does one import library per > > emulator, can we do this like NodeJS does? > > NodeJS have NAPI support across platform. They cr

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Yonggang Luo
On Sat, Sep 26, 2020 at 3:20 AM Paolo Bonzini wrote: > > On 25/09/20 21:12, 罗勇刚(Yonggang Luo) wrote: > > currently the empty.c plugin are failed of linkage error > > > > The fowlloing are the failing message: > > Compiling C object tests/plugin/libbb.dll.p/bb.c.obj &

I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Yonggang Luo
9e7600847543c3524867d85d7.dat" && if test -e block.syms; then printf '%s\n' block.syms > block.syms.stamp; fi "ar" csrD libblock.fa @libblock.fa.rsp "C:/CI-Tools/msys64/mingw64/bin/python3.exe" "C:/work/xemu/qemu/meson/meson.py" "--internal" "exe" "--unpickle" "C:/work/xemu/qemu/build/meson-private/meson_exe_python3.exe_269c5ec9ac7976b6693320b9cb25885f5b2f71c7.dat" && if test -e qemu.syms; then printf '%s\n' qemu.syms > qemu.syms.stamp; fi "c++" @qemu-system-ppc.exe.rsp -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v2 7/7] configure: Bump the minimum required Python version to 3.6

2020-09-23 Thread Yonggang Luo
m qemu.qmp import QMPMessage > > -assert sys.version_info >= (3, 6) > - > # Use this logger for logging messages directly from the iotests module > logger = logging.getLogger('qemu.iotests') > logger.addHandler(logging.NullHandler()) > -- > 2.18.2 > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Yonggang Luo
gt; + if 'CONFIG_I386_DIS' in config_all_disas > >> +capstone_data.set('CAPSTONE_HAS_X86', 1) > >> +capstone_files += files( > >> + 'capstone/arch/X86/X86Disassembler.c', > >> + 'capstone/arch/X86/X86DisassemblerDecoder.c', > >> + 'capstone/arch/X86/X86ATTInstPrinter.c', > >> + 'capstone/arch/X86/X86IntelInstPrinter.c', > >> + 'capstone/arch/X86/X86Mapping.c', > >> + 'capstone/arch/X86/X86Module.c' > >> +) > >> + endif > >> + > >> + configure_file(output: 'capstone-defs.h', configuration: capstone_data) > >> + > >> + capstone_cargs = [ > >> +# FIXME: There does not seem to be a way to completely replace the c_args > >> +# that come from add_project_arguments() -- we can only add to them. > >> +# So: disable all warnings with a big hammer. > >> +'-Wno-error', '-w', > >> + > >> +# Include all configuration defines via a header file, which will wind up > >> +# as a dependency on the object file, and thus changes here will result > >> +# in a rebuild. > >> +'-include', 'capstone-defs.h' > >> + ] > >> + > >> + libcapstone = static_library('capstone', > >> + sources: capstone_files, > >> + c_args: capstone_cargs, > >> + include_directories: 'capstone/include') > >> + capstone = declare_dependency(link_with: libcapstone, > >> +include_directories: 'capstone/include') > >> +endif > >> +config_host_data.set('CONFIG_CAPSTONE', capstone.found()) > >> + > >> +genh += configure_file(output: 'config-host.h', configuration: config_host_data) > >> + > >> # Generators > >> > >> hxtool = find_program('scripts/hxtool') > >> @@ -1512,7 +1609,7 @@ summary_info += {'vvfat support': config_host.has_key('CONFIG_VVFAT')} > >> summary_info += {'qed support': config_host.has_key('CONFIG_QED')} > >> summary_info += {'parallels support': config_host.has_key('CONFIG_PARALLELS')} > >> summary_info += {'sheepdog support': config_host.has_key('CONFIG_SHEEPDOG')} > >> -summary_info += {'capstone': config_host.has_key('CONFIG_CAPSTONE')} > >> +summary_info += {'capstone': capstone_opt} > >> summary_info += {'libpmem support': config_host.has_key('CONFIG_LIBPMEM')} > >> summary_info += {'libdaxctl support': config_host.has_key('CONFIG_LIBDAXCTL')} > >> summary_info += {'libudev': config_host.has_key('CONFIG_LIBUDEV')} > >> diff --git a/meson_options.txt b/meson_options.txt > >> index 543cf70043..e650a937e7 100644 > >> --- a/meson_options.txt > >> +++ b/meson_options.txt > >> @@ -22,3 +22,7 @@ option('vnc_sasl', type : 'feature', value : 'auto', > >> description: 'SASL authentication for VNC server') > >> option('xkbcommon', type : 'feature', value : 'auto', > >> description: 'xkbcommon support') > >> + > >> +option('capstone', type: 'combo', value: 'auto', > >> + choices: ['no', 'yes', 'auto', 'system', 'internal'], > >> + description: 'Whether and how to find the capstone library') > > > Hmm even more confusing is configure does: > > GIT submodules: ui/keycodemapdb tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 meson dtc capstone slirp > > but also: > > capstone: system > > which I can't quite help but feel is going to be confusing. maybe remove the capstone system support is a good idea after-all. > > -- > Alex Bennée > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Hi Bonzini, I've seen your 3.1 branch have conflict with qemu.org/master

2020-09-20 Thread Yonggang Luo
礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH 7/9] configure: remove target configuration

2020-09-20 Thread Yonggang Luo
Can these be generated from meson directly? as makefile finally need to be removed On Sun, Sep 20, 2020 at 9:09 PM Paolo Bonzini wrote: > > The config-target.mak files are small constant, we can therefore just > write them down explicitly. > > This removes about 10% of the configure script,

Re: [PATCH v5 0/4] Fixes curses on msys2/mingw

2020-09-19 Thread Yonggang Luo
On Sat, Sep 19, 2020 at 11:03 PM Paolo Bonzini wrote: > > On 18/09/20 18:10, 罗勇刚(Yonggang Luo) wrote: > > > >> Yonggang Luo (4): > >> curses: Fixes compiler error that complain don't have langinfo.h on > >> msys2/mingw > >> curses: Fixes

Re: [PATCH v5 0/4] Fixes curses on msys2/mingw

2020-09-18 Thread Yonggang Luo
Hi Bonzini, help to look at this, I convert curses and it's depends iconv to meson On Sat, Sep 19, 2020 at 12:03 AM Yonggang Luo wrote: > > And also convert related configure script to meson. > > Yonggang Luo (4): > curses: Fixes compiler error that complain don't

Re: [PATCH] configure: fixes indent of $meson setup

2020-09-18 Thread Yonggang Luo
Hi Bonzini, please queue this On Fri, Sep 18, 2020 at 10:45 PM Yonggang Luo wrote: > > convert these line from tab to space > > Signed-off-by: Yonggang Luo > --- > configure | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/co

[PATCH v5 4/4] configure: Fixes ncursesw detection under msys2/mingw by convert them to meson

2020-09-18 Thread Yonggang Luo
-I/usr/include/ncursesw -lcursesw Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann --- configure | 121 +++--- meson.build | 80 +- meson_options.txt | 4 ++ ui/meson.build| 2 +- 4 files changed

[PATCH v5 3/4] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw

2020-09-18 Thread Yonggang Luo
) ? NULL : _Str; } __forceinline char *__CRTDECL asctime_r(const struct tm *_Tm, char * _Str) { return asctime_s(_Str, 0x7fff, _Tm) ? NULL : _Str; } #endif ``` Signed-off-by: Yonggang Luo --- configure | 34 -- include/sysemu/os-win32.h | 4 ++

[PATCH v5 1/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-09-18 Thread Yonggang Luo
using g_get_codeset instead of nl_langinfo(CODESET) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann --- ui/curses.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index a59b23a9cf..12bc682cf9 100644 --- a/ui/curses.c +++ b/ui

[PATCH v5 2/4] curses: Fixes curses compiling errors.

2020-09-18 Thread Yonggang Luo
as errors gcc version 10.2.0 (Rev1, Built by MSYS2 project) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 12bc682cf9..e4f9588c3e

<    1   2   3   4   5   6   7   8   >