Hi Jason,
No news for a while.
Please review this series when you have time.
Thanks
Zhang Chen
> -Original Message-
> From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Zhang, Chen
> Sent: Wednesday, March 4, 2020 4:00 PM
> To: Jason Wang
> -Original Message-
> From: Laurent Vivier
> Sent: Friday, March 13, 2020 4:18 PM
> To: Zhang, Chen ; qemu-dev de...@nongnu.org>
> Cc: Zhang Chen ; Dr . David Alan Gilbert
> ; Juan Quintela
> Subject: Re: [PATCH] configure: Fix configure error.
>
> Le
From: Zhang Chen
When run the ./configure will always get this error:
Unknown option --exist
It caused by this patch:
commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d
Author: Juan Quintela
Date: Tue Dec 17 21:15:24 2019 +0100
configure: Enable test and libs for zstd
Add
On 3/4/2020 9:37 PM, Paolo Bonzini wrote:
On 04/03/20 09:06, Zhang, Chen wrote:
Hi Eric and Paolo, Can you give some comments about this series?
No news for a while...
We already have some users(Cloud Service Provider) try to use is module in
their product.
But they also need to follow
> >>> Subject: Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module
> >>>
> >>>
> >>> On 2020/1/19 下午5:10, Zhang, Chen wrote:
> >>>> Hi~
> >>>>
> >>>> Anyone have comments about this module?
>
Hi all,
Please give me some comments, this patch need by users(QNAP...).
Thanks
Zhang Chen
> -Original Message-
> From: Zhang, Chen
> Sent: Monday, February 24, 2020 4:58 AM
> To: Jason Wang ; qemu-dev de...@nongnu.org>
> Cc: Zhang Chen ; Dr . David Alan Gilbert
>
> -Original Message-
> From: Daniel Cho
> Sent: Monday, February 24, 2020 3:15 PM
> To: Zhang, Chen
> Cc: Dr. David Alan Gilbert ; Zhanghailiang
> ; qemu-devel@nongnu.org; Jason
> Wang
> Subject: Re: The issues about architecture of the COLO checkpoint
&g
From: Zhang Chen
The "expired_scan_cycle" determines colo-compare scan expired
net packet cycle.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 48 +++---
qemu-options.hx| 3 ++-
2 files changed, 47 insertions(+), 4 deletions(-)
From: Zhang Chen
Make a way to config COLO parameter detailed according to user cases
and environment.
Zhang Chen (2):
net/colo-compare.c: Expose "compare_timeout" to user
net/colo-compare.c: Expose "expired_scan_cycle" to user
net
From: Zhang Chen
The "compare_timeout" determines the max time to hold the primary net packet.
This patch expose the "compare_timeout", make user can
adjest this value according to the specific application scenario.
QMP command demo:
{ "execute": "qom-
From: Daniel Cho
Sent: Thursday, February 20, 2020 11:49 AM
To: Zhang, Chen
Cc: Dr. David Alan Gilbert ; Zhanghailiang
; qemu-devel@nongnu.org; Jason Wang
Subject: Re: The issues about architecture of the COLO checkpoint
Hi Zhang,
Thanks, I will configure on code for testing first
On 2/12/2020 10:56 AM, Jason Wang wrote:
On 2020/2/11 下午4:58, Zhang, Chen wrote:
-Original Message-
From: Jason Wang
Sent: Monday, January 20, 2020 10:57 AM
To: Zhang, Chen; Paolo Bonzini
; Philippe Mathieu-Daudé;
qemu-dev
Cc: Zhang Chen
Subject: Re: [PATCH V4 0/5] Introduce Advanced
lue by QMP and qemu monitor commands.
Thanks
Zhang Chen
Best regards,
Daniel Cho
Zhang, Chen mailto:chen.zh...@intel.com>> 於
2020年2月17日 週一 下午1:36寫道：
On 2/15/2020 11:35 AM, Daniel Cho wrote:
Hi Dave,
Yes, I agree with you, it does need a timeout.
Hi Daniel and Dave,
Hi Jason,
I noticed this series can't be merged or queued, do you met some problem
about it?
Thanks
Zhang Chen
Max Reitz ; qemu-block
Subject: Re: [PATCH v7 0/4] colo: Add support for continuous
replication
On Fri, 25 Oct 2019 19:06:31 +0200
Lukas Straub wrote:
Hello Everyone
time.
If colo-compare got a primary packet without related secondary packet in
a certain time , it will automatic trigger checkpoint.
https://github.com/qemu/qemu/blob/master/net/colo-compare.c#L847
Thanks
Zhang Chen
Hi Hailiang,
We base on qemu-4.1.0 for using COLO feature, in your
Add cc Jason Wang, he is a network expert.
In case some network things goes wrong.
Thanks
Zhang Chen
From: Zhang, Chen
Sent: Thursday, February 13, 2020 10:10 AM
To: 'Zhanghailiang' ; Daniel Cho
Cc: Dr. David Alan Gilbert ; qemu-devel@nongnu.org
Subject: RE: The issues about architecture
For the issue 2:
COLO need use the network packets to confirm PVM and SVM in the same state,
Generally speaking, we can’t send PVM packets without compared with SVM packets.
But to prevent jamming, I think COLO can do force checkpoint and send the PVM
packets in this case.
Thanks
Zhang Chen
> -Original Message-
> From: Zhanghailiang
> Sent: Wednesday, February 12, 2020 11:18 AM
> To: Dr. David Alan Gilbert ; Daniel Cho
> ; Zhang, Chen
> Cc: qemu-devel@nongnu.org
> Subject: RE: The issues about architecture of the COLO checkpoint
>
> Hi,
>
> -Original Message-
> From: Jason Wang
> Sent: Monday, January 20, 2020 10:57 AM
> To: Zhang, Chen ; Paolo Bonzini
> ; Philippe Mathieu-Daudé ;
> qemu-dev
> Cc: Zhang Chen
> Subject: Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module
>
>
> On 20
Hi~
Anyone have comments about this module?
We have some clients already try to use this module with COLO. Please review
this part.
If no one want to maintain this module, I can maintain this module myself.
Thanks
Zhang Chen
> -Original Message-
> From: Qemu-devel bounces+chen
Hi All,
No news for a while about this series.
This version already add new docs to address Paolo's comments.
Please give me more comments.
Thanks
Zhang Chen
On 12/17/2019 8:45 PM, Zhang, Chen wrote:
From: Zhang Chen
Advanced Watch Dog is an universal monitoring module on VMM side
From: Zhang Chen
This patch introduce a new module named Advanced Watch Dog,
and defined the input and output parameter. AWD use standard chardev
as the way of communicationg with the outside world.
If you want to use it, please add "--enable-awd" when configure qemu.
Demo comman
From: Zhang Chen
Add docs to introduce Advanced WatchDog detail and usage.
Signed-off-by: Zhang Chen
---
docs/awd.txt | 88
1 file changed, 88 insertions(+)
create mode 100644 docs/awd.txt
diff --git a/docs/awd.txt b/docs/awd.txt
new file
From: Zhang Chen
Advanced Watch Dog is an universal monitoring module on VMM side, it can be used
to detect network down(VMM to guest, VMM to VMM, VMM to another remote server)
and do previously set operation. Current AWD patch just accept any input as the
signal to refresh the watchdog timer
From: Zhang Chen
This patch load pulse_timer and timeout_timer in the new iothread.
The pulse timer will send pulse info to awd_node, and the timeout timer
will check the reply pulse from awd_node. If timeout occur, it will send
opt_script's data to the notification_node.
Signed-off-by: Zhang
From: Zhang Chen
Find and check the chardev awd_node and notification_node,
The awd_node used for keep connect with outside(like VM client/other
host/Remote server), and the notification_node used for do some
operation when disconnect event occur.
Signed-off-by: Zhang Chen
---
net/awd.c | 37
From: Zhang Chen
Advanced Watch Dog module needs chardev socket
to initialize properly before running.
Signed-off-by: Zhang Chen
---
vl.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/vl.c b/vl.c
index 6a65a64bfd..048fe458b9 100644
--- a/vl.c
+++ b/vl.c
@@ -2689,6 +2689,13
Reviewed-by: Zhang Chen
---
migration/ram.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 7dd7f81..8d7c015 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3891,26 +3891,27 @@ int
On 12/9/2019 5:08 PM, Paolo Bonzini wrote:
On 08/12/19 18:52, Zhang, Chen wrote:
Hi All~
No news for a long time.
Please give me more comments about this series.
Sorry, people were probably busy with the QEMU release candidates.
Even before looking at the code, the series is completely
Hi All~
No news for a long time.
Please give me more comments about this series.
Thanks
Zhang Chen
On 11/19/2019 8:30 PM, Zhang, Chen wrote:
From: Zhang Chen
Advanced Watch Dog is an universal monitoring module on VMM side, it can be
used to detect network down(VMM to guest, VMM to VMM
primary node and secondary
node boot in the same time.
I did't expect such a big difference on netfilter/chardev.
I think you can try without netfilter/chardev, after VM boot, re-build
the netfilter/chardev related work with chardev server nowait.
Thanks
Zhang Chen
Best regards,
Daniel Cho
From: Daniel Cho
Sent: Friday, November 29, 2019 10:43 AM
To: Zhang, Chen
Cc: Dr. David Alan Gilbert ; lukasstra...@web.de;
qemu-devel@nongnu.org
Subject: Re: Network connection with COLO VM
Hi David, Zhang,
Thanks for replying my question.
We know why will occur this issue.
As you said
> -Original Message-
> From: Markus Armbruster
> Sent: Wednesday, November 27, 2019 11:49 PM
> To: Zhang, Chen
> Cc: Jason Wang ; Paolo Bonzini
> ; Philippe Mathieu-Daudé ;
> qemu-dev ; Zhang Chen
> Subject: Re: [PATCH V2 0/4] Introduce Advanced Watch Dog
> -Original Message-
> From: Dr. David Alan Gilbert
> Sent: Wednesday, November 27, 2019 6:51 PM
> To: Daniel Cho ; Zhang, Chen
> ; lukasstra...@web.de
> Cc: qemu-devel@nongnu.org
> Subject: Re: Network connection with COLO VM
>
> * Daniel Cho (daniel...
Hi Lee,
Can you introduce to me the detail test step about disk performance?
I want to look into it when I have time.
Thanks
Zhang Chen
On Wed, Nov 27, 2019 at 10:50 AM lee <1754...@bugs.launchpad.net> wrote:
>
> Hi Zhang Chen ,
>
> I try colo follow https://wiki.qemu
> -Original Message-
> From: Jason Wang
> Sent: Tuesday, November 19, 2019 11:03 PM
> To: Zhang, Chen ; Lukas Straub
> ; qemu-devel
> Cc: Kevin Wolf ; qemu-block bl...@nongnu.org>; Wen Congyang ; Max
> Reitz ; Xie Changlong
> Subject: Re: [PATC
From: Zhang Chen
Advanced Watch Dog module needs chardev socket
to initialize properly before running.
Signed-off-by: Zhang Chen
---
vl.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/vl.c b/vl.c
index 6a65a64bfd..048fe458b9 100644
--- a/vl.c
+++ b/vl.c
@@ -2689,6 +2689,13
From: Zhang Chen
This patch introduce a new module named Advanced Watch Dog,
and defined the input and output parameter. AWD use standard chardev
as the way of communicationg with the outside world.
If you want to use it, please add "--enable-awd" when configure qemu.
Demo comman
From: Zhang Chen
This patch load pulse_timer and timeout_timer in the new iothread.
The pulse timer will send pulse info to awd_node, and the timeout timer
will check the reply pulse from awd_node. If timeout occur, it will send
opt_script's data to the notification_node.
Signed-off-by: Zhang
From: Zhang Chen
Advanced Watch Dog is an universal monitoring module on VMM side, it can be
used to detect network down(VMM to guest, VMM to VMM, VMM to another remote
server) and do previously set operation. Current AWD patch just accept any
input as the signal to refresh the watchdog timer
From: Zhang Chen
Find and check the chardev awd_node and notification_node,
The awd_node used for keep connect with outside(like VM client/other
host/Remote server), and the notification_node used for do some
operation when disconnect event occur.
Signed-off-by: Zhang Chen
---
net/awd.c | 37
> -Original Message-
> From: Lukas Straub
> Sent: Thursday, November 14, 2019 12:36 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; Kevin Wolf
> ; Max Reitz ; qemu-block
>
> Subject: Re: [PATCH v7 0/4] co
Hi~ All~
Ping Anyone have time to review this series? I need more comments~
Thanks
Zhang Chen
> -Original Message-
> From: Zhang, Chen
> Sent: Friday, November 1, 2019 10:49 AM
> To: Jason Wang ; Paolo Bonzini
> ; Philippe Mathieu-Daudé ;
> qemu-dev
> Cc: Zha
From: Zhang Chen
This patch load pulse_timer and timeout_timer in the new iothread.
The pulse timer will send pulse info to awd_node, and the timeout timer
will check the reply pulse from awd_node. If timeout occur, it will send
opt_script's data to the notification_node.
Signed-off-by: Zhang
From: Zhang Chen
This patch introduce a new module named Advanced Watch Dog,
and defined the input and output parameter. AWD use standard chardev
as the way of communicationg with the outside world.
If you want to use it, please add "--enable-awd" when configure qemu.
Demo comman
From: Zhang Chen
Because Advanced Watch Dog module needs chardev socket
to initialize properly before.
Signed-off-by: Zhang Chen
---
vl.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/vl.c b/vl.c
index 6a65a64bfd..048fe458b9 100644
--- a/vl.c
+++ b/vl.c
@@ -2689,6 +2689,13
From: Zhang Chen
Find and check the chardev awd_node and notification_node,
The awd_node used for keep connect with outside(like VM client/other
host/Remote server), and the notification_node used for do some
operation when disconnect event occur.
Signed-off-by: Zhang Chen
---
net/awd.c | 37
From: Zhang Chen
Advanced Watch Dog is an universal monitoring module on VMM side, it can be
used to detect network down(VMM to guest, VMM to VMM, VMM to another remote
server) and do previously set operation. Current AWD patch just accept any
input as the signal to refresh the watchdog timer
> -Original Message-
> From: Lukas Straub
> Sent: Thursday, October 24, 2019 10:26 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Wen Congyang ; Xie Changlong
> ; Kevin Wolf ; Max Reitz
> ; qemu-block
> Subject: [PATCH v7 4
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: Wednesday, October 23, 2019 7:39 PM
> To: Zhang, Chen ; Jason Wang
> ; Paolo Bonzini ; qemu-
> dev
> Cc: Zhang Chen
> Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog
> module f
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: Wednesday, October 23, 2019 7:01 PM
> To: Zhang, Chen ; Jason Wang
> ; Paolo Bonzini ; qemu-
> dev
> Cc: Zhang Chen
> Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog
> mo
> -Original Message-
> From: Lukas Straub
> Sent: Saturday, October 19, 2019 2:46 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; Kevin Wolf
> ; Max Reitz ; qemu-block
>
> Subject: Re: [PATCH v6 1/4] block/replic
> -Original Message-
> From: Paolo Bonzini
> Sent: Tuesday, October 22, 2019 1:24 AM
> To: Zhang, Chen ; Jason Wang
> ; qemu-dev
> Cc: Zhang Chen
> Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog
> module framework
>
> On 16/10/19 13:
> make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-2eq69u33/src'
> make: *** [docker-run-test-quick@centos7] Error 2
>
It looks this problem dose not caused by my patch series?
Thanks
Zhang Chen
> real0m3.762s
> user0m2.349s
>
>
> The full log is availabl
1
> make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-2eq69u33/src'
> make: *** [docker-run-test-quick@centos7] Error 2
>
>
It looks this problem dose not caused by my patch series?
Thanks
Zhang Chen
> real0m3.762s
> user0m2.349s
>
>
> The full log is avai
From: Zhang Chen
Find and check the chardev awd_node and notification_node,
The awd_node used for keep connect with outside(like VM client/other
host/Remote server), and the notification_node used for do some
operation when disconnect event occur.
Signed-off-by: Zhang Chen
---
net/awd.c | 37
From: Zhang Chen
This patch introduce a new module named Advanced Watch Dog,
and defined the input and output parameter. AWD use standard chardev
as the way of communicationg with the outside world.
Demo command:
-object
advanced-watchdog,id=heart1,server=on,awd_node=h1,notification_node
From: Zhang Chen
This patch load pulse_timer and timeout_timer in the new iothread.
The pulse timer will send pulse info to awd_node, and the timeout timer
will check the reply pulse from awd_node. If timeout occur, it will send
opt_script's data to the notification_node.
Signed-off-by: Zhang
From: Zhang Chen
Advanced Watch Dog is an universal monitoring module on VMM side, it can be
used to detect network down(VMM to guest, VMM to VMM, VMM to another remote
server) and do previously set operation.
for example: send message to admin, notify another VMM, send qmp command to
qemu do
From: Zhang Chen
Because Advanced Watch Dog module needs chardev socket
to initialize properly before.
Signed-off-by: Zhang Chen
---
vl.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/vl.c b/vl.c
index 4489cfb2bb..4094f61d28 100644
--- a/vl.c
+++ b/vl.c
@@ -2683,6 +2683,13
> -Original Message-
> From: Lukas Straub
> Sent: Saturday, October 12, 2019 12:01 AM
> To: Zhang, Chen
> Cc: qemu-devel ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; Kevin Wolf
> ; Max Reitz ; qemu-block
>
> Subject: Re: [PATCH v6 4/4] colo: Updat
> -Original Message-
> From: Lukas Straub
> Sent: Wednesday, October 9, 2019 11:17 PM
> To: Zhang, Chen
> Cc: qemu-devel ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; Kevin Wolf
> ; Max Reitz ; qemu-block
>
> Subject: Re: [PATCH v6 4/4] colo: Updat
> -Original Message-
> From: Lukas Straub
> Sent: Saturday, October 5, 2019 9:06 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; Kevin Wolf
> ; Max Reitz ; qemu-block
>
> Subject: [PATCH v6 4/4] colo: Updat
> -Original Message-
> From: Lukas Straub
> Sent: Saturday, October 5, 2019 9:06 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; Kevin Wolf
> ; Max Reitz ; qemu-block
>
> Subject: [PATCH v6 2/4] test
> -Original Message-
> From: Lukas Straub
> Sent: Saturday, September 28, 2019 6:45 PM
> To: Zhang, Chen
> Cc: qemu-devel ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; kw...@redhat.com;
> mre...@redhat.com
> Subject: Re: [PATCH v5 3/4] net/filter.c: Ad
> -Original Message-
> From: Lukas Straub
> Sent: Saturday, September 28, 2019 7:07 PM
> To: Zhang, Chen
> Cc: qemu-devel ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; kw...@redhat.com;
> mre...@redhat.com
> Subject: Re: [PATCH v5 2/4] tests/t
> -Original Message-
> From: Lukas Straub
> Sent: Saturday, September 28, 2019 9:25 PM
> To: Zhang, Chen
> Cc: qemu-devel ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; kw...@redhat.com;
> mre...@redhat.com
> Subject: Re: [PATCH v5 4/4] colo: Update D
> -Original Message-
> From: Lukas Straub
> Sent: Monday, September 16, 2019 3:20 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; kw...@redhat.com;
> mre...@redhat.com
> Subject: [PATCH v5 2/4] tests/test-replicati
> -Original Message-
> From: Lukas Straub
> Sent: Monday, September 16, 2019 3:20 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; kw...@redhat.com;
> mre...@redhat.com
> Subject: [PATCH v5 4/4] colo: Update D
> -Original Message-
> From: Lukas Straub
> Sent: Monday, September 16, 2019 3:20 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; kw...@redhat.com;
> mre...@redhat.com
> Subject: [PATCH v5 3/4] net/filter.c: Add Options
> -Original Message-
> From: Lukas Straub
> Sent: Monday, September 16, 2019 3:20 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; kw...@redhat.com;
> mre...@redhat.com
> Subject: [PATCH v5 1/4] block/replication.c: Ign
> -Original Message-
> From: Lukas Straub
> Sent: Friday, September 27, 2019 12:10 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; kw...@redhat.com;
> mre...@redhat.com
> Subject: Re: [PATCH v5 0/4] colo: Add support
> -Original Message-
> From: Lukas Straub
> Sent: Tuesday, September 10, 2019 6:15 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; kw...@redhat.com;
> mre...@redhat.com
> Subject: [PATCH v4 3/4] net/filter.c: Ad
From: Zhang Chen
People need a way to know current filter order if they
want to dynamic add/remove netfilter.
For example:
(qemu) info network
...
filters order:
m0 ---> redire0 ---> redire1 ---> End
...
Signed-off-by: Zhang Chen
---
net/net.c | 24 ---
> -Original Message-
> From: Lukas Straub
> Sent: Tuesday, September 3, 2019 2:51 AM
> To: Zhang, Chen
> Cc: qemu-devel ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong
> Subject: Re: [PATCH v2 2/3] net/filter.c: Add Options to insert filters
> anywhere in
9 2:49 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong
> Subject: [PATCH v2 3/3] Update Documentation
>
> Document the qemu command-line and qmp commands for continious
> replication
>
> Signed-off-by: Lukas
> -Original Message-
> From: Lukas Straub
> Sent: Friday, August 23, 2019 2:21 PM
> To: Zhang, Chen
> Cc: qemu-devel ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong
> Subject: Re: [PATCH v2 2/3] net/filter.c: Add Options to insert filters
> anywhere in the
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Friday, August 16, 2019 2:49 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ; Xie
> Changlong
> Subject: [PATCH v2 2/3] net/filter.c: Add Options to
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Saturday, August 17, 2019 2:20 AM
> To: Zhang, Chen
> Cc: Dr. David Alan Gilbert ; qemu-devel de...@nongnu.org>; Jason Wang ; Xie Changlong
> ; Wen Congyang
> Subject: Re: [Qemu-de
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Friday, August 16, 2019 3:48 AM
> To: Dr. David Alan Gilbert
> Cc: qemu-devel ; Zhang, Chen
> ; Jason Wang ; Xie
> Changlong ; Wen Congyang
>
> Subject: Re: [Qemu-devel] [PATC
Hi Lukas,
Please fix this issue and add more comments in the commit log.
Thanks
Zhang Chen
> -Original Message-
> From: no-re...@patchew.org [mailto:no-re...@patchew.org]
> Sent: Thursday, August 15, 2019 11:20 AM
> To: lukasstra...@web.de
> Cc: Zhang, Chen ; qemu-d
> -Original Message-
> From: Peter Maydell [mailto:peter.mayd...@linaro.org]
> Sent: Tuesday, July 23, 2019 1:25 AM
> To: Zhang, Chen
> Cc: Li Zhijian ; Jason Wang ;
> qemu-dev ; Zhang Chen
> Subject: Re: [PATCH V5] net/colo-compare.c: Fix memory leak a
From: Zhang Chen
This patch to fix the origin "char *data" memory leak, code style issue
and add necessary check here.
Reported-by: Coverity (CID 1402785)
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 27 ---
1 file changed, 20 insertions(+), 7 deletion
> -Original Message-
> From: Peter Maydell [mailto:peter.mayd...@linaro.org]
> Sent: Monday, July 22, 2019 9:19 PM
> To: Zhang, Chen
> Cc: Li Zhijian ; Jason Wang ;
> qemu-dev ; Zhang Chen
> Subject: Re: [PATCH V4] net/colo-compare.c: Fix memory leak and code style
Sorry, I re-sent the old version.
Please redirect to V4 patch.
Thanks
Zhang Chen
> -Original Message-
> From: Zhang, Chen
> Sent: Thursday, July 18, 2019 5:22 PM
> To: Li Zhijian ; Peter Maydell
> ; Jason Wang ; qemu-dev
>
> Cc: Zhang Chen ; Zhang, Chen
> Subj
From: Zhang Chen
This patch to fix the origin "char *data" memory leak, code style issue
and add necessary check here.
Reported-by: Coverity (CID 1402785)
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 28 +---
1 file changed, 21 insertions(+), 7 deletion
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Thursday, July 18, 2019 6:54 PM
> To: Peter Maydell
> Cc: Zhang, Chen ; Li Zhijian ;
> Jason Wang ; qemu-dev ;
> Zhang Chen
> Subject: Re: [Qemu-devel] [PATCH V3] net/colo-co
> -Original Message-
> From: Peter Maydell [mailto:peter.mayd...@linaro.org]
> Sent: Thursday, July 18, 2019 9:42 PM
> To: Zhang, Chen
> Cc: Li Zhijian ; Jason Wang ;
> qemu-dev ; Zhang Chen
> Subject: Re: [PATCH V3] net/colo-compare.c: Fix memory leak a
From: Zhang Chen
This patch to fix the origin "char *data" menory leak, code style issue
and add necessary check here.
Reported-by: Coverity (CID 1402785)
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 28 +---
1 file changed, 21 insertions(+), 7 deletion
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Thursday, July 11, 2019 4:18 AM
> To: Zhang, Chen ; Li Zhijian ;
> Peter Maydell ; qemu-dev de...@nongnu.org>
> Cc: Zhang Chen
> Subject: Re: [Qemu-devel] [PATCH V2] net/colo-co
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Tuesday, July 9, 2019 10:48 PM
> To: Zhang, Chen ; Li Zhijian ;
> Peter Maydell ; qemu-dev de...@nongnu.org>
> Cc: Zhang Chen
> Subject: Re: [Qemu-devel] [PATCH V2] net/colo-co
From: Zhang Chen
This patch to fix the origin "char *data" menory leak, code style issue
and add necessary check here.
Reported-by: Coverity (CID 1402785)
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 28 +---
1 file changed, 21 insertions(+), 7 deletion
> -Original Message-
> From: Peter Maydell [mailto:peter.mayd...@linaro.org]
> Sent: Wednesday, July 3, 2019 6:31 PM
> To: Zhang, Chen
> Cc: Li Zhijian ; Jason Wang ;
> qemu-dev ; Zhang Chen
> Subject: Re: [PATCH] net/colo-compare.c: Fix memory leak and code style
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Wednesday, July 3, 2019 4:56 PM
> To: Zhang, Chen ; Li Zhijian ;
> Peter Maydell ; Jason Wang
> ; qemu-dev
> Cc: Zhang Chen
> Subject: Re: [Qemu-devel] [PATCH] net/colo-co
From: Zhang Chen
Address Peter's comments in patch "COLO-compare:Add colo-compare
remote notify support".
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index
> -Original Message-
> From: Zhang, Chen
> Sent: Wednesday, July 3, 2019 9:08 AM
> To: 'Peter Maydell' ; Jason Wang
>
> Cc: QEMU Developers
> Subject: RE: [PULL 16/17] COLO-compare: Add colo-compare remote notify
> support
>
>
>
> > ---
> -Original Message-
> From: Peter Maydell [mailto:peter.mayd...@linaro.org]
> Sent: Wednesday, July 3, 2019 2:51 AM
> To: Jason Wang
> Cc: QEMU Developers ; Zhang, Chen
>
> Subject: Re: [PULL 16/17] COLO-compare: Add colo-compare remote notify
> support
>
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Thursday, June 27, 2019 9:58 AM
> To: Zhang, Chen ; Li Zhijian ;
> Dr. David Alan Gilbert ; Juan Quintela
> ; zhanghailiang ;
> qemu-dev ; Stefano Stabellini
> ; Paul Durrant
> Cc
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Friday, June 21, 2019 3:25 PM
> To: Zhang, Chen ; Li Zhijian ;
> Dr. David Alan Gilbert ; Juan Quintela
> ; zhanghailiang ;
> qemu-dev ; Stefano Stabellini
> ; Paul Durrant
> Cc
From: Zhang Chen
If we try to close replication after failover, it will crash here.
So we need check the block job on active disk before cancel the job.
Signed-off-by: Zhang Chen
---
block/replication.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/replication.c
501 - 600 of 1725 matches
Mail list logo
