Hi,
Patch 1 fixes a double free bug.
Patch 2 is an optimization for filter-rewriter.
Please review, thanks.
zhanghailiang (2):
net/colo: fix memory double free error
filter-rewriter: skip net_checksum_calculate() while offset = 0
net/colo.c| 4 ++--
net/filter-rewriter.c
While the offset of packets's sequence for primary side and
secondary side is zero, it is unnecessary to call net_checksum_calculate()
to recalculate the checksume value of packets.
Signed-off-by: zhanghailiang
---
net/filter-rewriter.c | 17 +++--
1 file changed, 11 inser
After a net connection is closed, we didn't clear its releated resources
in connection_track_table, which will lead to memory leak.
Let't track the state of net connection, if it is closed, its related
resources will be cleared up.
Signed-off-by: zhanghailiang
---
net/colo.h
: Jason Wang
zhanghailiang (15):
net/colo: Add notifier/callback related helpers for filter
colo-compare: implement the process of checkpoint
colo-compare: use notifier to notify packets comparing result
COLO: integrate colo compare with colo frame
COLO: Handle shutdown command for VM in
Hi,
Patch 1 fixes a double free bug, and patch 2 fixes a memory leak bug.
Patch 3 is an optimization for filter-rewriter.
Please review, thanks.
zhanghailiang (3):
net/colo: fix memory double free error
filter-rewriter: fix memory leak for connection in
connection_track_table
filter
While the offset of packets's sequence for primary side and
secondary side is zero, it is unnecessary to call net_checksum_calculate()
to recalculate the checksume value of packets.
Signed-off-by: zhanghailiang
---
net/filter-rewriter.c | 18 +++---
1 file changed, 11 inser
The 'primary_list' and 'secondary_list' members of struct Connection
is not allocated through dynamically g_queue_new(), but we free it by using
g_queue_free(), which will lead to a double-free bug.
Signed-off-by: zhanghailiang
---
net/colo.c | 4 ++--
1 file changed
_main() and qemu_save_device_state()
public.
Cc: Juan Quintela
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
include/sysemu/sysemu.h | 6 ++
migration/savevm.c | 55 ++---
2 files change
was used during checkpoint.
Besides, we move the colo_flush_ram_cache to the proper position after the
above change.
Cc: Juan Quintela
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 48
is still necessary to notify users that we exited COLO mode.
Cc: Markus Armbruster
Cc: Michael Roth
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Eric Blake
---
migration/colo.c | 19 +++
qapi-schema.json | 14 ++
qapi/event.json | 21 +++
While do checkpoint, we need to flush all the unhandled packets,
By using the filter notifier mechanism, we can easily to notify
every compare object to do this process, which runs inside
of compare threads as a coroutine.
Cc: Jason Wang
Signed-off-by: zhanghailiang
Signed-off-by: Zhang Chen
Don't need to flush all VM's ram from cache, only
flush the dirty pages since last checkpoint
Cc: Juan Quintela
Signed-off-by: Li Zhijian
Signed-off-by: Zhang Chen
Signed-off-by: zhanghailiang
---
migration/ram.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/migra
data
transferring in the subsequent checkpoint.
Cc: Juan Quintela
Sgned-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 52
1 file changed, 36 insertions(+), 16 deletions(-)
diff
It's a good idea to use notifier to notify COLO frame of
inconsistent packets comparing.
Cc: Jason Wang
Signed-off-by: Zhang Chen
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 32
net/colo-compare.h | 2 ++
2 files changed, 30 insertions(
ad to memory leak.
To fix it, we split the process of saving and finding section entry into two
helper functions, we will check if section info was exist in loadvm_handlers
list before save it.
This modifications have no side effect for normal migration.
Cc: Juan Quintela
Signed-off-by: zhanghai
: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
v19:
- fix title and comment
v15:
- Go on the shutdown process even some error happened
while sent 'SHUTDOWN' message to SVM.
- Add Reviewed-by tag
v14:
- Remove 'colo_shutdown' variable, use c
Make sure master start block replication after slave's block
replication started.
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Li Zhijian
Cc: Stefan Hajnoczi
Cc: Kevin Wolf
Cc: Max Reitz
Cc: Changlong Xie
---
migration/colo.c
state.
Cc: Juan Quintela
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
include/exec/ram_addr.h | 1 +
include/migration/migration.h | 4 +++
migration/colo.c | 14 +
migration
For COLO FT, both the PVM and SVM run at the same time,
only sync the state while it needs.
So here, let SVM runs while not doing checkpoint,
Besides, change DEFAULT_MIGRATE_X_CHECKPOINT_DELAY to 200*100.
Cc: Jason Wang
Signed-off-by: zhanghailiang
---
migration/colo.c | 25
We record the address of the dirty pages that received,
it will help flushing pages that cached into SVM.
We record them by re-using migration dirty bitmap.
Cc: Juan Quintela
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 30
all content of PVM's RAM cache into SVM's MEMORY,
we do this in a more efficient way:
Only flush any page that dirtied by PVM since last checkpoint.
In this way, we can ensure SVM's memory same with PVM's.
Besides, we must ensure flush RAM cache before load device state.
Cc
We will use this notifier to help COLO to notify filter object
to do something, like do checkpoint, or process failover event.
Cc: Jason Wang
Signed-off-by: zhanghailiang
---
net/colo.c | 92 ++
net/colo.h | 18
2 files
After a net connection is closed, we didn't clear its releated resources
in connection_track_table, which will lead to memory leak.
Let't track the state of net connection, if it is closed, its related
resources will be cleared up.
Signed-off-by: zhanghailiang
---
net/colo.h
The 'primary_list' and 'secondary_list' members of struct Connection
is not allocated through dynamically g_queue_new(), but we free it by using
g_queue_free(), which will lead to a double-free bug.
Signed-off-by: zhanghailiang
---
net/colo.c | 2 --
1 file changed, 2 deleti
While the offset of packets's sequence for primary side and
secondary side is zero, it is unnecessary to call net_checksum_calculate()
to recalculate the checksume value of packets.
Signed-off-by: zhanghailiang
---
net/filter-rewriter.c | 18 +++---
1 file changed, 11 inser
Hi,
Patch 1 fixes a double free bug, and patch 2 fixes a memory leak bug.
Patch 3 is an optimization for filter-rewriter.
Please review, thanks.
zhanghailiang (3):
net/colo: fix memory double free error
filter-rewriter: fix memory leak for connection in
connection_track_table
filter
h always try to find the Gsource from default context.
Fix it by passing the right context to g_main_context_find_source_by_id().
Cc: Paolo Bonzini
Cc: Marc-André Lureau
Signed-off-by: zhanghailiang
---
chardev/char-fd.c | 6 +++---
chardev/char-io.c | 8
chardev/ch
ff-by: zhanghailiang
---
net/colo-compare.c | 62 +++---
1 file changed, 22 insertions(+), 40 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 162fd6a..fdde788 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -83,9
ndr?? Lureau's suggestion)
v1->v2:
- Squash patch 3 of last version into patch 2. (ZhangChen's suggestion)
zhanghailiang (4):
colo-compare: use g_timeout_source_new() to process the stale packets
colo-compare: kick compare thread to exit after some cleanup in
finalization
by pass the worker_context parameter to qemu_chr_fe_set_handlers().
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 37ce75c..a6fc2ff 100644
--- a/net/colo-c
re compare thead exits, some cleanup works need to be
done, All unhandled packets need to be released and connection_track_table
needs to be freed, or there will be memory leak.
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 39 +--
1 file changed
h always try to find the Gsource from default context.
Fix it by passing the right context to g_main_context_find_source_by_id().
Cc: Paolo Bonzini
Cc: Marc-André Lureau
Signed-off-by: zhanghailiang
---
chardev/char-io.c | 13 +
chardev/char-io.h | 2 ++
chardev/char.c|
re compare thead exits, some cleanup works need to be
done, All unhandled packets need to be released and connection_track_table
needs to be freed, or there will be memory leak.
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 39 +--
1 file changed
by pass the worker_context parameter to qemu_chr_fe_set_handlers().
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 37ce75c..a6fc2ff 100644
--- a/net/colo-c
ff-by: zhanghailiang
---
net/colo-compare.c | 62 +++---
1 file changed, 22 insertions(+), 40 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 162fd6a..fdde788 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -83,9
This series includes two parts: codes optimization and bug fix.
patch 1 tries to move timer process into colo compare thread as
a new coroutine.
patch 2 ~ 4 fixe some bugs of colo compare.
v2:
- Squash patch 3 of last version into patch 2. (ZhangChen's suggestion)
zhanghailiang (4):
by pass the worker_context parameter to qemu_chr_fe_set_handlers().
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 809bad3..4c74b02 100644
--- a/net/colo-c
Hi,
This series fixes some bugs of colo compare.
Patch 1 is trying to move timer process into colo compare
thread as a new coroutine.
Patch 2 ~ 5 fix several bugs in colo compare, for more details,
please refer to each patch.
Please review, thanks.
zhanghailiang (5):
colo-compare: use
ff-by: zhanghailiang
---
net/colo-compare.c | 62 +++---
1 file changed, 22 insertions(+), 40 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 162fd6a..fdde788 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -83,9
We should call g_main_loop_quit() to notify colo compare thread to
exit, Or it will run in g_main_loop_run() forever.
Besides, the finalizing process can't happen in context of colo thread,
it is reasonable to remove the 'if (qemu_thread_is_self(&s->thread))'
branch.
Signed
h always try to find the Gsource from default context.
Fix it by passing the right context to g_main_context_find_source_by_id().
Cc: Paolo Bonzini
Cc: Marc-André Lureau
Signed-off-by: zhanghailiang
---
chardev/char-io.c | 13 +
chardev/char-io.h | 2 ++
chardev/char.c|
We should release all unhandled packets before finalize colo compare.
Besides, we need to free connection_track_table, or there will be
a memory leak bug.
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 20
1 file changed, 20 insertions(+)
diff --git a/net/colo
le do checkpoint, besides, we want to separate
the process of saving/loading memory and devices state.
So we add three new helper functions: qemu_loadvm_state_begin(),
qemu_load_device_state() and qemu_savevm_live_state() to achieve
different process during migration.
Signed-off-by: zhanghailiang
S
ad to memory leak.
To fix it, we split the process of saving and finding section entry into two
helper functions, we will check if section info was exist in loadvm_handlers
list before save it.
This modifications have no side effect for normal migration.
Signed-off-by: zhanghailiang
Reviewed-b
on, I fixed the titles/comments for both of them, and I kept the
reviewed-by tag. (Hi Dave, please give it a glance again, since
it has been a long time ;) ).
Please review. Thanks.
zhanghailiang (2):
savevm: split save/find loadvm_handlers entry into two helper
functions
savevm: Ad
From: Zhang Chen
While COLO does checkpoint, we need to flush all queued packets of
COLO proxy, use a new API to do these things, and export it which
will be used by COLO frame.
Signed-off-by: Zhang Chen
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 48
It's a good idea to use notifier to notify COLO frame of
inconsistent packets comparing.
Signed-off-by: Zhang Chen
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 24 ++--
net/colo-compare.h | 2 ++
2 files changed, 24 insertions(+), 2 deletions(-)
diff --git
Amit Shah
Cc: Dr. David Alan Gilbert (git)
Cc: eddie.d...@intel.com
Cc: Xu Quan
Zhang Chen (1):
colo-compare: add API to flush all queued packets while do checkpoint
zhanghailiang (2):
colo-compare: reconstruct the mutex lock usage
colo-compare: use notifier to notify inconsistent packets
check_lock' to 'conn_list_lock'
which is used to protect 'conn_list' queue, use another 'conn_lock'
to protect 'primary_list' and 'secondary_list'.
Besides, fix some missing places which need these mutex lock.
Signed-off-by: zhanghailiang
--
d, the above error reports will appear.
To prevent this, we can call bdrv_invalidate_cache_all() in qmp_migrate_cancel()
directly if we find images become inactive.
Besides, bdrv_invalidate_cache_all() in migration_completion() doesn't have the
protection of big lock, fix it by add the missing qemu_
Some code logic only be needed in non-shared disk, here
we adjust these codes to prepare for shared disk scenario.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: zhanghailiang
---
block/replication.c | 47 ---
1 file changed, 28 insertions(+), 19
d in the active disk and it
will overwrite the existing sector content in the buffer.
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Zhang Chen
---
block/replication.c | 48 ++--
1 file changed, 42 insertions(+), 6 delet
We use these two options to identify which disk is
shared
Cc: Eric Blake
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Zhang Chen
---
v3:
- Move g_free(s->shared_disk_id) to the common fail process place (Stefan)
- Fix comments for these two options
---
bl
.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Changlong Xie
Signed-off-by: zhanghailiang
---
block/replication.c | 36 +++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index b96a3e5..3a44728 100644
--- a
p the patch which add a blk_root() helper
- Fix some comments from Changlong
zhanghailiang (6):
docs/block-replication: Add description for shared-disk case
replication: add shared-disk and shared-disk-id options
replication: Split out backup_do_checkpoint() from
secondary_do_check
Introuduce the scenario of shared-disk block replication
and how to use it.
Reviewed-by: Changlong Xie
Reviewed-by: Stefan Hajnoczi
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Zhang Chen
---
docs/block-replication.txt | 139
ver, it doesn't have cluster size, so here we return
a fake value for it.
This patch should be dropped if Eric's nbd patch be merged.
https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg03567.html
Cc: Eric Blake
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
---
called, the above error reports will appear.
To prevent this, we can call bdrv_invalidate_cache_all() in qmp_migrate_cancel()
directly if we find images become inactive.
Signed-off-by: zhanghailiang
---
Hi,
I have sent another patch before to fix this problem, but didn't cover
all the
need to restart the process.
Cc: Eric Blake
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 26 ++
qapi-schema.json | 4 +++-
2 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/migration/colo.
lize checkpoint-delay.
Signed-off-by: zhanghailiang
---
include/migration/colo.h | 2 ++
include/migration/migration.h | 5 +
migration/colo.c | 33 +++--
migration/migration.c | 3 +++
4 files changed, 33 insertions(+), 10 deletions(-
avoid this situation. Besides, we should close the corresponding
file descriptors after failvoer BH shutdown them,
Or there will be an error.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
Cc: Dr. David Alan Gilbert
---
include/migration/migration.h
ago, and has been reviewed by Dave.
I'd like to pick these three patches from the later COLO series,
which will include some optimization and integrating with block
replication and COLO net proxy.
Please review, thanks.
zhanghailiang (3):
COLO: fix setting checkpoint-delay not working pro
From: Caoxinhua
QEMU will crash with the follow backtrace if the new created thread exited
before
we call qemu_thread_set_name() for it.
(gdb) bt
#0 0x7f9a68b095d7 in __GI_raise (sig=sig@entry=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1 0x7f9a68b0acc8 in __GI_abort () at
From: Caoxinhua
(gdb) bt
#0 0x7f9a68b095d7 in __GI_raise (sig=sig@entry=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1 0x7f9a68b0acc8 in __GI_abort () at abort.c:90
#2 0x7f9a69cda389 in PAT_abort () from /usr/lib64/libuvpuserhotfix.so
#3 0x7f9a69cdda0d in patchIllInsHandler
From: Caoxinhua
(gdb) bt
#0 0x7f9a68b095d7 in __GI_raise (sig=sig@entry=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1 0x7f9a68b0acc8 in __GI_abort () at abort.c:90
#2 0x7f9a69cda389 in PAT_abort () from /usr/lib64/libuvpuserhotfix.so
#3 0x7f9a69cdda0d in patchIllInsHandler
7;state': true } ] } }
{'execute': 'migrate', 'arguments': {'uri': 'tcp:9.42.3.17:' } }
3. Failover
Secondary side:
Issue qmp commands:
{ 'execute': 'nbd-server-stop' }
{ "execute": "x-colo-lost-heartb
Introuduce the scenario of shared-disk block replication
and how to use it.
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Zhang Chen
---
v2:
- fix some problems found by Changlong
---
docs/block-replication.txt | 139 +++--
1
We use these two options to identify which disk is
shared
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Zhang Chen
---
v2:
- add these two options for BlockdevOptionsReplication to support
qmp blockdev-add command.
- fix a memory leak found by Changlong
---
block
Some code logic only be needed in non-shared disk, here
we adjust these codes to prepare for shared disk scenario.
Signed-off-by: zhanghailiang
---
block/replication.c | 47 ---
1 file changed, 28 insertions(+), 19 deletions(-)
diff --git a/block
ver, it doesn't have cluster size, so here we return
a fake value for it.
This patch should be dropped if Eric's nbd patch be merged.
https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg03567.html
Cc: Eric Blake
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
---
.
Signed-off-by: zhanghailiang
---
block/replication.c | 36 +++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index e87ae87..35e9ab3 100644
--- a/block/replication.c
+++ b/block/replication.c
@@ -332,20
d in the active disk and it
will overwrite the existing sector content in the buffer.
Signed-off-by: zhanghailiang
Signed-off-by: Wen Congyang
Signed-off-by: Zhang Chen
---
block/replication.c | 48 ++--
1 file changed, 42 insertions(+), 6 delet
ol of images because we only regain it
while the migration state is "active", but here users cancelled the migration
when they found some errors happened (for example, libvirtd daemon is shutdown
in destination unexpectedly).
Signed-off-by: zhanghailiang
---
migration/migration.c | 3
VM can not get into colo state unless users enable 'x-colo'
capability for migration, Here it is necessary to clarify
this.
Suggested-by: Eric Blake
Signed-off-by: zhanghailiang
---
v2:
- Clarify colo state for RunState too as Eric suggested.
---
qapi-schema.json | 8 +---
1 fi
cified behavior by
reading x_checkpoint_delay without checking has_x_checkpoint_delay.
Signed-off-by: zhanghailiang
Reviewed-by: Eric Blake
---
v2:
- fix the commit message as Eric sugguested.
---
hmp.c | 1 +
migration/migration.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/h
migrate_parameters'.
Signed-off-by: zhanghailiang
---
hmp.c | 1 +
migration/migration.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hmp.c b/hmp.c
index b5e3f54..02103df 100644
--- a/hmp.c
+++ b/hmp.c
@@ -318,6 +318,7 @@ void hmp_info_migrate_parameters(
he data to determine
how much data should be read in the secondary side.
So here, we can get the size of the data by saving it into I/O channel
before send it to the secondary side.
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
Cc: Dr.
Introduce the design of COLO, and how to test it.
Signed-off-by: zhanghailiang
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
v21:
- Fix some minor typos and grammar from Eric
---
docs/COLO-FT.txt | 189 +++
1 file changed, 189
re load VM state,
which can ensure the data is intact.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Signed-off-by: Gonglei
Reviewed-by: Dr. David Alan Gilbert
Cc: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
v21:
- Fix building waring
v19:
- fix
For primary side, if COLO gets failover request from users.
To be exact, gets 'x_colo_lost_heartbeat' command.
COLO thread will exit the loop while the failover BH does the
cleanup work and resumes VM.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Al
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
- Fix comments
v19:
- Fix title and comment
v16:
- Fix compile broken due to missing osdep.h
v13:
- Add Reviewed-by tag
v11:
- Add more comments for x-colo
e the --enable-colo/disable-colo
on the source/destination side or not;
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Signed-off-by: Gonglei
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
v19:
- fix title and comment
v16:
- Fix compile broken d
migration thread.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Signed-off-by: Gonglei
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v23:
- Add Reviewed-by tag
v22:
- Remove unnecessary 'migrate_set_state(&s->state, MIGRATION_STATUS_COLO,
MIGRATION_
Add myself as co-maintainer of COLO framework, so that
I can get CC'ed on future patches and bugs for this feature.
Signed-off-by: zhanghailiang
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b01fec0..484e8b8 100644
--- a/MAINTA
This new communication path will be used for returning messages
from Secondary side to Primary side.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
v13:
- Remove useless error report
v12:
- Add
int, for which
the Secondary VM is not running, later we will support 'hybrid' mode.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Signed-off-by: Gonglei
Cc: Eric Blake
Cc: Markus Armbruster
Cc: Dr. David Alan Gilbert
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit
avid Alan Gilbert (git)
zhanghailiang (18):
migration: Introduce capability 'x-colo' to migration
COLO: migrate COLO related info to secondary node
migration: Enter into COLO mode after migration if COLO is enabled
migration: Switch to COLO process after finishing loadvm
COL
_incoming_co' records the
original migration incoming coroutine.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
- Use bool type 'false' instead of int '0' (Amit)
v19:
- Fix
If users require SVM to takeover work, COLO incoming thread should
exit from loop while failover BH helps backing to migration incoming
coroutine.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
Guest will enter this state when paused to save/restore VM state
under COLO checkpoint.
Cc: Eric Blake
Cc: Markus Armbruster
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Signed-off-by: Gonglei
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Eric Blake
Reviewed-by: Amit Shah
configure --enable-colo/--disable-colo to switch COLO
support on/off.
COLO feature doesn't depend on any other external libraries,
So here it is reasonable to enable COLO by default, to
avoid re-compile QEMU if users want to use this capability.
Signed-off-by: zhanghailiang
Signed-off-b
Do checkpoint periodically, the default interval is 200ms.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
v12:
- Add Reviewed-by tag
v11:
- Fix wrong sleep time for checkpoint period. (Dave&#
Add checkpoint-delay parameter for migrate-set-parameters, so that
we can control the checkpoint frequency when COLO is in periodic mode.
Cc: Luiz Capitulino
Cc: Eric Blake
Cc: Markus Armbruster
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Reviewed-by: Dr. David Alan Gilbert
and set the value.
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
v20:
- Convert 'enum COLOFailoverStatus' to qapi
v19:
- fix comments
v11:
- fix several typos found by Dave
- Add Reviewed-by tag
---
include
arn if colo is supported.
The default value for COLO (COarse-Grain LOck Stepping) is disabled.
Cc: Juan Quintela
Cc: Amit Shah
Cc: Eric Blake
Cc: Markus Armbruster
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Signed-off-by: Gonglei
Reviewed-by: Eric Blake
Reviewed-by: Amit Shah
arn if colo is supported.
The default value for COLO (COarse-Grain LOck Stepping) is disabled.
Cc: Juan Quintela
Cc: Amit Shah
Cc: Eric Blake
Cc: Markus Armbruster
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Signed-off-by: Gonglei
Reviewed-by: Eric Blake
Reviewed-by: Amit Shah
int, for which
the Secondary VM is not running, later we will support 'hybrid' mode.
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Signed-off-by: Gonglei
Cc: Eric Blake
Cc: Markus Armbruster
Cc: Dr. David Alan Gilbert
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit
and set the value.
Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
v20:
- Convert 'enum COLOFailoverStatus' to qapi
v19:
- fix comments
v11:
- fix several typos found by Dave
- Add Reviewed-by tag
---
include
: Jason Wang
Cc: Dr. David Alan Gilbert (git)
zhanghailiang (17):
migration: Introduce capability 'x-colo' to migration
COLO: migrate COLO related info to secondary node
migration: Enter into COLO mode after migration if COLO is enabled
migration: Switch to COLO process after finish
e the --enable-colo/disable-colo
on the source/destination side or not;
Signed-off-by: zhanghailiang
Signed-off-by: Li Zhijian
Signed-off-by: Gonglei
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
---
v22:
- Add Reviewed-by tag
v19:
- fix title and comment
v16:
- Fix compile broken d
101 - 200 of 1429 matches
Mail list logo
