Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-03-25 Thread Zheng Xiang
Hi Peter, Thanks for your reply! On 2019/3/25 21:11, Peter Maydell wrote: > On Mon, 25 Mar 2019 at 12:53, Xiang Zheng wrote: >> >> Currently we fill the VIRT_FLASH space with two 64MB NOR images when >> using persistent UEFI variables on QEMU. Actually we only use a very >> small part of the mem

Re: [Qemu-devel] [PATCH] scsi-cd: Fix crash after remote cdrom detached

2019-02-24 Thread Zheng Xiang
Ping? On 2019/2/15 11:17, Zheng Xiang wrote: > Hi Paolo, > > On 2019/2/15 2:07, Paolo Bonzini wrote: >> On 14/02/19 13:27, Xiang Zheng wrote: >>> There is a small window between the twice blk_is_available in >>> scsi_disk_emulate_command which would cause crash

Re: [Qemu-devel] [PATCH] scsi-cd: Fix crash after remote cdrom detached

2019-02-14 Thread Zheng Xiang
Hi Paolo, On 2019/2/15 2:07, Paolo Bonzini wrote: > On 14/02/19 13:27, Xiang Zheng wrote: >> There is a small window between the twice blk_is_available in >> scsi_disk_emulate_command which would cause crash due to the later >> assertion if the remote cdrom is detached in this window. >> >> So thi

Re: [Qemu-devel] [PATCH] pcie: set link state inactive/active after hot unplug/plug

2018-12-02 Thread Zheng Xiang
On 2018/12/3 11:38, Zheng Xiang wrote: > When VM boots from the latest version of linux kernel, after > hot-unpluging virtio-blk disks which are hotplugged into > pcie-root-port, the VM's dmesg log shows: > > [ 151.046242] pciehp :00:05.0:pcie004: pending interrupts

[Qemu-devel] [PATCH] pcie: set link state inactive/active after hot unplug/plug

2018-12-02 Thread Zheng Xiang
after hot-unplug, the virtio-blk would turn on and then back off. So this patch set the Link Status inactive after hot-unplug and active after hot-plug. Signed-off-by: Zheng Xiang Signed-off-by: Zheng Xiang Cc: Wang Haibin --- hw/pci/pcie.c | 12 1 file changed, 12 insertions(+)

[Qemu-devel] [PATCH] pcie: set link state inactive/active after hot unplug/plug

2018-12-02 Thread Zheng Xiang
after hot-unplug, the virtio-blk would turn on and then back off. So this patch set the Link Status inactive after hot-unplug and active after hot-plug. Signed-off-by: Zheng Xiang Signed-off-by: Zheng Xiang Cc: Wang Haibin --- hw/pci/pcie.c | 12 1 file changed, 12 insertions(+)

[Qemu-devel] [PATCH] target-arm: fix a segmentation fault due to illegal memory access

2018-06-19 Thread Zheng Xiang
From: Zheng Xiang The elements of kvm_devices_head list are freed in kvm_arm_machine_init_done(), but we still access these illegal memory in kvm_arm_devlistener_del(). This will cause segment fault when booting guest with MALLOC_PERTURB_=1. Signed-off-by: Zheng Xiang --- target/arm/kvm.c

[Qemu-devel] [PATCH] vhost: fix corrupting GPA 0 when using uninitialized queues

2018-01-12 Thread Zheng Xiang
using qemu with vhost-scsi, it will fail with below error: qemu-kvm: Error start vhost dev qemu-kvm: unable to start vhost-scsi: Cannot allocate memory This patch fix this issue by skipping calling vhost_virtqueue_start for uninitialized queues. Cc: Michael S. Tsirkin Signed-off-by: Zheng Xiang --