Re: [PATCH v3] migration: free 'saddr' since be no longer used

2023-11-28 Thread Zongmin Zhou
Ping? Has this been forgotten? Best regards! On 2023/11/20 22:01, Peter Xu wrote: On Mon, Nov 20, 2023 at 11:14:28AM +0800, Zongmin Zhou wrote: Since socket_parse() will allocate memory for 'saddr',and its value will pass to 'addr' that allocated by migrate_uri_parse(),

[PATCH v3] migration: free 'saddr' since be no longer used

2023-11-19 Thread Zongmin Zhou
of this union containing allocated strings,and will be used after that. So just free 'saddr' itself without doing a deep free on the contents of the SocketAddress. Fixes: 72a8192e225c ("migration: convert migration 'uri' into 'MigrateAddress'") Signed-off-

Re: [PATCH v2] migration: free 'saddr' since be no longer used

2023-11-16 Thread Zongmin Zhou
On 2023/11/16 22:19, Juan Quintela wrote: Zongmin Zhou wrote: Since socket_parse() will allocate memory for 'saddr',and its value will pass to 'addr' that allocated by migrate_uri_parse(), then 'saddr' will no longer used,need to free. But due to 'saddr->

[PATCH v2] migration: free 'saddr' since be no longer used

2023-11-15 Thread Zongmin Zhou
of this union containing allocated strings,and will be used after that. So just free 'saddr' itself without doing a deep free on the contents of the SocketAddress. Fixes: 72a8192e225c ("migration: convert migration 'uri' into 'MigrateAddress'") Signed

[PATCH] migration: free 'saddr' since be no longer used

2023-11-14 Thread Zongmin Zhou
Since socket_parse() will allocate memory for 'saddr', and its value will pass to 'addr' that allocated by migrate_uri_parse(),so free 'saddr' to avoid memory leak. Fixes: 72a8192e225c ("migration: convert migration 'uri' into 'MigrateAdd

[PATCH] dump:Add close fd on error return to avoid resource leak

2023-11-06 Thread Zongmin Zhou
Signed-off-by: Zongmin Zhou --- dump/dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dump/dump.c b/dump/dump.c index 1c304cadfd..ad5294e853 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -2160,6 +2160,7 @@ void qmp_dump_guest_memory(bool paging, const char *protocol, return

[RESEND PATCH] hw/i386/vmmouse:add relative packet flag for button status

2023-07-31 Thread Zongmin Zhou
he correct(relative) input device, result to relative mode unuseful. Signed-off-by: Zongmin Zhou --- hw/i386/vmmouse.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c index a56c185f15..6cd624bd09 100644 --- a/hw/i386/vmmo

[PATCH] hw/i386/vmmouse:add relative packet flag for button status

2023-04-13 Thread Zongmin Zhou
he correct(relative) input device, result to relative mode unuseful. Signed-off-by: Zongmin Zhou --- hw/i386/vmmouse.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c index a56c185f15..6cd624bd09 100644 --- a/hw/i386/vmmo