Re: [PATCH v5 4/9] tests/functional: Add GDB class

2025-10-02 Thread Alex Bennée
Gustavo Romero >> +# >> +# This work is licensed under the terms of the GNU GPL, version 2 or >> +# later. See the COPYING file in the top-level directory. > > Please remove these two lines - they should not be included in any > newly authored files - SPDX alone is desi

Re: [PATCH 0/7] testing and misc updates (docker, ansible, .git*, gitlab)

2025-10-01 Thread Alex Bennée
BALATON Zoltan writes: > On Wed, 1 Oct 2025, Daniel P. Berrangé wrote: >> On Wed, Oct 01, 2025 at 07:56:21PM +0200, BALATON Zoltan wrote: >>> On Wed, 1 Oct 2025, Alex Bennée wrote: >>>> My first set of patches for the development tree. Should be mostly >>&

Re: [PATCH 0/7] testing and misc updates (docker, ansible, .git*, gitlab)

2025-10-01 Thread Alex Bennée
BALATON Zoltan writes: > On Wed, 1 Oct 2025, Alex Bennée wrote: >> My first set of patches for the development tree. Should be mostly >> self-explanatory. We still need to apply the upstream COPYING patch >> the u-boot-sam460ex code but we should decide if its worth mirr

Re: [PATCH v3 0/1] Support per-head resolutions with virtio-gpu

2025-10-01 Thread Alex Bennée
iguration surface (e.g., > you have 2 heads - one with resolution 111x222 and the other with > resolution 333x444). Queued to virtio-gpu/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 6/7] gitlab: move custom runners to Ubuntu 24.04

2025-10-01 Thread Alex Bennée
Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners.yml | 6 ++-- ...4-aarch32.yml => ubuntu-24.04-aarch32.yml} | 8 ++--- ...4-aarch64.yml => ubuntu-24.04-aarch64.yml} | 32 +-- ...22.04-s390x.yml => ubuntu-24.04-s390x.yml} | 28

[PATCH 4/7] tests/lcitool: drop 64 bit guests from i686 cross build

2025-10-01 Thread Alex Bennée
With only TCG available we can't support 64 bit guests on a 32 bit host. Fixes: 5c27baf9519 (docs/about/deprecated: Deprecate 32-bit x86 hosts for system emulation) Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-i686-cross.docker | 2 +- tests/lcitool/re

[PATCH 0/7] testing and misc updates (docker, ansible, .git*, gitlab)

2025-10-01 Thread Alex Bennée
aarch64 runner online by Friday and ready for the switchover. Hopefully I'll also be able to pick up Gustavo's reverse debug test fixes by then as well. Alex. Alex Bennée (7): .gitpublish: use origin/master as default base .gitmodules: restore qemu-project mirror of u-boot

[PATCH 1/7] .gitpublish: use origin/master as default base

2025-10-01 Thread Alex Bennée
This is very much the result of my recent fat finger but I think it's safer to assume that origin/master points to a recent commit (or at least a commit a given branch is based on) than master. Signed-off-by: Alex Bennée Acked-by: Stefan Hajnoczi --- .gitpublish | 16 1

[PATCH 3/7] .gitmodules: restore qemu-project mirror of u-boot-sam460ex

2025-10-01 Thread Alex Bennée
With this change also reference the upstream repo. Signed-off-by: Alex Bennée --- .gitmodules | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitmodules b/.gitmodules index e51abe65258..c307216d173 100644 --- a/.gitmodules +++ b/.gitmodules @@ -28,7 +28,8 @@ url

Re: [PATCH v2 00/27] CI/build-sys fixes to enable Rust more widely

2025-09-30 Thread Alex Bennée
Marc-André Lureau writes: > On Sat, Sep 27, 2025 at 9:18 PM Alex Bennée wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Hi, > > > > This patch series fixes a number of issues with the build system and CI

Re: [PATCH 2/6] system/ramblock: Move ram_block_is_pmem() declaration

2025-09-29 Thread Alex Bennée
gt; > +/** > + * ramblock_is_pmem: Whether the RAM block is of persistent memory missed a rename Otherwise: Reviewed-by: Alex Bennée > + */ > +bool ram_block_is_pmem(RAMBlock *rb); > + > #endif > diff --git a/migration/ram.c b/migration/ram.c > index 7208bc114fb.

[RFC PATCH] .gitpublish: use origin/master as default base

2025-09-29 Thread Alex Bennée
This is very much the result of my recent fat finger but I think it's safer to assume that origin/master points to a recent commit (or at least a commit a given branch is based on) than master. Signed-off-by: Alex Bennée --- .gitpublish | 16 1 file changed, 8 insertions(

Re: [PATCH v2 00/27] CI/build-sys fixes to enable Rust more widely

2025-09-27 Thread Alex Bennée
tests/docker/dockerfiles/ubuntu2204.docker| 7 +- > tests/docker/test-wasm| 12 > tests/lcitool/libvirt-ci | 2 +- > tests/lcitool/projects/qemu.yml | 3 +- > tests/lcitool/refresh | 48 +- > tests/vm/freebsd | 4 +- > 48 files changed, 531 insertions(+), 183 deletions(-) > create mode 100755 scripts/rust-to-clang-target-test.sh > create mode 100644 scripts/rust-to-clang-target.sh > create mode 100755 tests/docker/test-wasm -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PULL 13/24] semihosting/arm-compat-semi: remove dependency on cpu.h

2025-09-27 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20250822150058.18692-12-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-15-alex.ben...@linaro.org> diff --git a/semihosting/arm-com

[PULL 15/24] contrib/plugins/execlog: Explicitly check for qemu_plugin_read_register() failure

2025-09-26 Thread Alex Bennée
sage-ID: <20250710144543.1187715-1-peter.mayd...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-17-alex.ben...@linaro.org> diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c index 06ec76d6e9a..811f3203199 100644 --- a/contrib/plugins/exec

[PULL 14/24] semihosting/arm-compat-semi: compile once in system and per target for user mode

2025-09-26 Thread Alex Bennée
Message-ID: <20250822150058.18692-13-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-16-alex.ben...@linaro.org> diff --git a/semihosting/meson.build b/semihosting/meson.build index bb0db323937..99f10e2e2bb 100644 --- a/semihosting/meson.b

Re: [PATCH v2 16/27] tests/lcitool: update to debian13

2025-09-26 Thread Alex Bennée
02-17) (built from a source tarball) --- --- Called: `rustc --target arm-unknown-linux-gnueabi -C linker=arm-linux-gnueabihf-gcc -o /tmp/qemu-test/build/meson-private/rusttest.exe /tmp/qemu-test/build/meson-private/sanity.rs` -> 1 stderr: error[E0463]: can't find crate for `s

[PULL 05/24] semihosting/guestfd: compile once for system/user

2025-09-26 Thread Alex Bennée
off-by: Alex Bennée Message-ID: <20250922093711.2768983-7-alex.ben...@linaro.org> diff --git a/include/semihosting/guestfd.h b/include/semihosting/guestfd.h index 3d426fedab3..a7ea1041ea0 100644 --- a/include/semihosting/guestfd.h +++ b/include/semihosting/guestfd.h @@ -35,13 +35,6 @@ ty

[PULL 10/24] semihosting/arm-compat-semi: eradicate sizeof(target_ulong)

2025-09-26 Thread Alex Bennée
From: Pierrick Bouvier No semantic change. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20250822150058.18692-9-pierrick.bouv...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-12

Re: [PATCH v2 05/27] scripts/archive-source: use a bash array

2025-09-26 Thread Alex Bennée
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] vfio: Remove workaround for kernel DMA unmap overflow bug

2025-09-26 Thread Alex Williamson
"close group->fd=%d" > vfio_device_get(const char * name, unsigned int flags, unsigned int > num_regions, unsigned int num_irqs) "Device %s flags: %u, regions: %u, irqs: > %u" > vfio_device_put(int fd) "close vdev->fd=%d" > -vfio_legacy_dma_unmap_overflow_workaround(void) "" > > # region.c > vfio_region_write(const char *name, int index, uint64_t addr, uint64_t data, > unsigned size) " (%s:region%d+0x%"PRIx64", 0x%"PRIx64 ", %d)" Reviewed-by: Alex Williamson

Re: [PATCH v2 22/27] RFC: tests/docker: add rust to debian-legacy-test-cross

2025-09-26 Thread Alex Bennée
> ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools > ENV DEF_TARGET_LIST alpha-linux-user,sh4-linux-user > ENV MAKE /usr/bin/make > +ENV PATH=$CARGO_HOME/bin:$PATH > # As a final step configure the user (if env is defined) > ARG USER > ARG UID -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 04/27] scripts/archive-source: silence subprojects downloads

2025-09-26 Thread Alex Bennée
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > It's too verbose. > > Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 03/27] scripts/archive-source: speed up downloading subprojects

2025-09-26 Thread Alex Bennée
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Running meson on each subproject is quite slow. > > According to Paolo, meson will run download tasks in parallel. > > Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 01/27] build-sys: require -lrt when no shm_open() in std libs

2025-09-26 Thread Alex Bennée
t; > Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PULL 07/24] target/riscv/common-semi-target: remove sizeof(target_ulong)

2025-09-26 Thread Alex Bennée
From: Pierrick Bouvier Only riscv64 extends SYS_EXIT, similar to aarch64. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20250822150058.18692-6-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-9-alex.ben...@l

[PULL 12/24] semihosting/arm-compat-semi: eradicate target_long

2025-09-26 Thread Alex Bennée
From: Pierrick Bouvier We use int64_t or int32_t depending on ret size. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20250822150058.18692-11-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-14-alex.ben...@l

[PULL 06/24] semihosting/arm-compat-semi: change common_semi_sys_exit_extended

2025-09-26 Thread Alex Bennée
ouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-8-alex.ben...@linaro.org> diff --git a/target/arm/common-semi-target.h b/target/arm/common-semi-target.h index da51f2d7f54..7bb442f24ca 100644 --- a/target/arm/common-semi-target.h +++ b/target/arm/common-s

[PULL 21/24] contrib/plugins/uftrace: generate additional files for uftrace

2025-09-26 Thread Alex Bennée
ned-off-by: Pierrick Bouvier Message-ID: <20250902075042.223990-7-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-23-alex.ben...@linaro.org> diff --git a/contrib/plugins/uftrace.c b/contrib/plugins/uftrace.c index 10abad0673c..2386cc723b

[PULL 19/24] contrib/plugins/uftrace: implement tracing

2025-09-26 Thread Alex Bennée
ick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-21-alex.ben...@linaro.org> diff --git a/contrib/plugins/uftrace.c b/contrib/plugins/uftrace.c index bb775916270..b9dcd531987 100644 --- a/contrib/plugins/uftrace.c +++ b/contrib/plugins/uftrace.c @@ -12,6 +1

[PULL 22/24] contrib/plugins/uftrace: implement x64 support

2025-09-26 Thread Alex Bennée
From: Pierrick Bouvier It's trivial to implement x64 support, as it's the same stack layout as aarch64. Reviewed-by: Manos Pitsidianakis Signed-off-by: Pierrick Bouvier Message-ID: <20250902075042.223990-8-pierrick.bouv...@linaro.org> Signed-off-by: Alex Be

[PULL 17/24] contrib/plugins/uftrace: define cpu operations and implement aarch64

2025-09-26 Thread Alex Bennée
Bouvier Message-ID: <20250902075042.223990-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-19-alex.ben...@linaro.org> diff --git a/contrib/plugins/uftrace.c b/contrib/plugins/uftrace.c index 4af0130b159..d060513446c 100644 --- a/con

[PULL 24/24] contrib/plugins/uftrace: add documentation

2025-09-26 Thread Alex Bennée
Message-ID: <20250902075042.223990-10-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-26-alex.ben...@linaro.org> diff --git a/docs/about/emulation.rst b/docs/about/emulation.rst index 456d01d5b08..8a5e128f677 100644 --- a/docs/about/emulati

[PULL 23/24] contrib/plugins/uftrace_symbols.py

2025-09-26 Thread Alex Bennée
generate an ordered memory map based on that. This script uses the python (native) pyelftools module. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier Acked-by: Alex Bennée Message-ID: <20250902075042.223990-9-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Mess

[PULL 01/24] scripts/ci: add gitlab-failure-analysis script

2025-09-26 Thread Alex Bennée
ot;) failed pipeline 1919542960, total jobs 127, skipped 5, failed 2, 48753 tests, 441 skipped tests, 1 failed tests Failed test qemu.qemu:unit / test-aio, msys2-64bit, 12 /aio/timer/schedule - ERROR:../tests/unit/test-aio.c:413:test_timer_schedule: assertion failed: (aio_poll(ctx, true)) Sign

[PULL 16/24] contrib/plugins/uftrace: skeleton file

2025-09-26 Thread Alex Bennée
Signed-off-by: Pierrick Bouvier Message-ID: <20250902075042.223990-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-18-alex.ben...@linaro.org> diff --git a/contrib/plugins/uftrace.c b/contrib/plugins/uftrace.c new file mode 100644 index

[PULL 20/24] contrib/plugins/uftrace: implement privilege level tracing

2025-09-26 Thread Alex Bennée
Pitsidianakis Signed-off-by: Pierrick Bouvier Message-ID: <20250902075042.223990-6-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-22-alex.ben...@linaro.org> diff --git a/contrib/plugins/uftrace.c b/contrib/plugins/uftrace.c index b9dcd531987.

[PULL 04/24] semihosting/syscalls: replace uint64_t with vaddr where appropriate

2025-09-26 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20250822150058.18692-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-6-alex.ben...@linaro.org> diff --git a/semihosting/syscalls.c b

[PULL 09/24] include/semihosting/common-semi: extract common_semi API

2025-09-26 Thread Alex Bennée
current target. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20250822150058.18692-8-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-11-alex.ben...@linaro.org> diff --git a/include/semihosting/common-semi.

[PULL 03/24] semihosting/syscalls: compile once in system and per target for user mode

2025-09-26 Thread Alex Bennée
ge-ID: <20250822150058.18692-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-5-alex.ben...@linaro.org> diff --git a/include/semihosting/syscalls.h b/include/semihosting/syscalls.h index 6627c45fb28..03aa45b7bb9 100644 --- a/include/semihosting

[PULL 00/24] maintainer updates (scripts, semihosting, plugins)

2025-09-26 Thread Alex Bennée
ab-failure-analysis script - tweak checkpath to ignore license in removed lines - refactor semihosting to build once - add explicit assert to execlog for coverity - new uftrace plugin ---- Alex Bennée (1): scripts/ci: add gitl

[PULL 08/24] target/{arm, riscv}/common-semi-target: eradicate target_ulong

2025-09-26 Thread Alex Bennée
Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-10-alex.ben...@linaro.org> diff --git a/target/arm/common-semi-target.h b/target/arm/common-semi-target.h index 7bb442f24ca..6775a270aaa 100644 --- a/target/arm/common-semi-target.h +++ b/target/arm/common-semi-target.h @@

Re: [PATCH v6 23/25] tests: add plugin asserting correctness of discon event's to_pc

2025-09-26 Thread Alex Bennée
"Julian Ganz" writes: (add Richard to Cc) > September 23, 2025 at 10:29 PM, "Julian Ganz" wrote: >> September 22, 2025 at 12:11 PM, "Julian Ganz" wrote: >> > September 21, 2025 at 6:46 PM, "Alex Bennée" wrote: >> > This is firi

Re: [PATCH] docs/specs/spdm.rst: Fix typo in x86_64 architecture name

2025-09-23 Thread Alex Bennée
Peter Maydell writes: > The spdm.rst docs call the 64-bit x86 architecture "x64-64". > This is a typo; correct it to our canonical name for the > architecture, "x86_64". > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2] tracing: deprecate "ust" tracing backend

2025-09-23 Thread Alex Bennée
"ust". > > Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PULL,2/2] .gitmodules: move u-boot mirrors to qemu-project-mirrors

2025-09-22 Thread Alex Bennée
their > submodule paths? Or is this accidental? Yes. The patch should be trivially applicable to the stable branches. https://patchew.org/QEMU/20250908141911.2546063-1-alex.ben...@linaro.org/ > > Thanks, > Paul -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 1/3] docs/code-provenance: clarify scope very early

2025-09-22 Thread Alex Bennée
iewed-by: Daniel P. Berrangé > Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] virtio: vhost-user-device: Make user creatable again

2025-09-22 Thread Alex Bennée
t; > > > both pieces. >> > > > >> > > > Maybe with the insecure tag you are working on? >> > > >> > > Sure. >> > > >> > > > And disable in the default config? >> > > >> > > Disa

[PATCH 10/25] include/semihosting/common-semi: extract common_semi API

2025-09-22 Thread Alex Bennée
current target. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20250822150058.18692-8-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- include/semihosting/common-semi.h | 6 ++ semihosting/arm-compat-semi.c | 3 +--

[PATCH 06/25] semihosting/guestfd: compile once for system/user

2025-09-22 Thread Alex Bennée
off-by: Alex Bennée --- include/semihosting/guestfd.h | 7 --- include/semihosting/semihost.h | 2 ++ semihosting/arm-compat-semi-stub.c | 19 +++ semihosting/arm-compat-semi.c | 26 ++ semihosting/guestfd.c

Re: [RFC PATCH 3/4] docs/code-provenance: clarify the scope of AI exceptions

2025-09-22 Thread Alex Bennée
icy auto-closes PRs we are already seeing a growth in submissions where the authors seem to have YOLO'd the code generator without really understanding the changes. > Examples of tools impacted by this policy includes GitHub's CoPilot, OpenAI's > ChatGPT, Anthropic's Claude, and Meta's Code Llama, and code/content > generation agents which are built on top of such tools. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 12/25] semihosting/arm-compat-semi: replace target_ulong with vaddr

2025-09-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 22/9/25 11:36, Alex Bennée wrote: >> From: Pierrick Bouvier >> Reviewed-by: Richard Henderson >> Signed-off-by: Pierrick Bouvier >> Message-ID: <20250822150058.18692-10-pierrick.bouv...@linaro.org> >> Signed-off-by: A

Re: [PATCH] virtio: vhost-user-device: Make user creatable again

2025-09-22 Thread Alex Bennée
bmission > as a mechanism by which users can experiment to finese their ideas > prior to getting to the point of needing to make a spec proposal. That's basically it. Adding the stubs is fairly trivial for vhost-user backends that implement the config space but you can't add stubs for things that are currently RFC specs. Also you are forcing a delay for the spec to be updated and then wait for the next QEMU with the stub added. > > With regards, > Daniel -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 23/25] contrib/plugins/uftrace: implement x64 support

2025-09-22 Thread Alex Bennée
From: Pierrick Bouvier It's trivial to implement x64 support, as it's the same stack layout as aarch64. Reviewed-by: Manos Pitsidianakis Signed-off-by: Pierrick Bouvier Message-ID: <20250902075042.223990-8-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- contrib/p

[PATCH 07/25] semihosting/arm-compat-semi: change common_semi_sys_exit_extended

2025-09-22 Thread Alex Bennée
ouv...@linaro.org> Signed-off-by: Alex Bennée --- target/arm/common-semi-target.h | 4 ++-- target/riscv/common-semi-target.h | 4 ++-- semihosting/arm-compat-semi.c | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/target/arm/common-semi-target.h b/target/arm/commo

Re: [PATCH 1/2] hw/pci-host/dino: Don't call pci_register_root_bus() in init

2025-09-22 Thread Alex Bennée
PCI_DEVFN(0, 0), 32, TYPE_PCI_BUS); > + > +/* Set up windows into PCI bus memory. */ > +for (int i = 1; i < 31; i++) { > +uint32_t addr = 0xf000 + i * DINO_MEM_CHUNK_SIZE; > +char *name = g_strdup_printf("PCI Outbound Window %d", i); > +memory_region_init_alias(&s->pci_mem_alias[i], OBJECT(s), > + name, &s->pci_mem, addr, > + DINO_MEM_CHUNK_SIZE); > +g_free(name); minor nit: this could be an autofree but I get you are just moving code here. Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2] virtio: Add function name to error messages

2025-09-22 Thread Alex Bennée
90-1-codeguy.mot...@gmail.com/ > > this old patch just expanded the error messages to include 'Virtio ' > in their text. I'm not going to claim this made new error messages > hugely user friendly, but I think that old patch approach was at > least conceptually better & preferrable to the function name > addition. > >> > Buglink: https://bugs.launchpad.net/qemu/+bug/1919021 >> > >> > Signed-off-by: Alessandro Ratti > > With regards, > Daniel -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 05/25] semihosting/syscalls: replace uint64_t with vaddr where appropriate

2025-09-22 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20250822150058.18692-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- semihosting/syscalls.c | 78 +- 1 file changed, 39 insertions(

[PATCH 04/25] semihosting/syscalls: compile once in system and per target for user mode

2025-09-22 Thread Alex Bennée
ge-ID: <20250822150058.18692-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- include/semihosting/syscalls.h | 30 ++-- semihosting/arm-compat-semi.c | 1 + semihosting/syscalls.c | 89 +- semihosting/meson.build| 4 +- 4 fi

[PATCH 20/25] contrib/plugins/uftrace: implement tracing

2025-09-22 Thread Alex Bennée
ick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- contrib/plugins/uftrace.c | 152 +- 1 file changed, 151 insertions(+), 1 deletion(-) diff --git a/contrib/plugins/uftrace.c b/contrib/plugins/uftrace.c index bb775916270..b9dcd531987 100644 --- a/contrib/plugin

[PATCH 18/25] contrib/plugins/uftrace: define cpu operations and implement aarch64

2025-09-22 Thread Alex Bennée
Bouvier Message-ID: <20250902075042.223990-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- contrib/plugins/uftrace.c | 114 -- 1 file changed, 110 insertions(+), 4 deletions(-) diff --git a/contrib/plugins/uftrace.c b/contrib/plugins/uft

[PATCH 24/25] contrib/plugins/uftrace_symbols.py

2025-09-22 Thread Alex Bennée
generate an ordered memory map based on that. This script uses the python (native) pyelftools module. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier Acked-by: Alex Bennée Message-ID: <20250902075042.223990-9-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- c

[PATCH 25/25] contrib/plugins/uftrace: add documentation

2025-09-22 Thread Alex Bennée
Message-ID: <20250902075042.223990-10-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- docs/about/emulation.rst | 199 +++ 1 file changed, 199 insertions(+) diff --git a/docs/about/emulation.rst b/docs/about/emulation.rst index 456d0

[PATCH 13/25] semihosting/arm-compat-semi: eradicate target_long

2025-09-22 Thread Alex Bennée
From: Pierrick Bouvier We use int64_t or int32_t depending on ret size. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20250822150058.18692-11-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- semihosting/arm-compat-semi.c | 7 +-- 1 file c

[PATCH 14/25] semihosting/arm-compat-semi: remove dependency on cpu.h

2025-09-22 Thread Alex Bennée
From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20250822150058.18692-12-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- semihosting/arm-compat-semi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/semihosting/arm-

[PATCH 00/25] September maintainer updates (docs, plugins, semihosting) pre-PR

2025-09-22 Thread Alex Bennée
once (single binary work) Misc - typo fix - tweak to checkpatch license checking - *new* gitlab-failure-analysis script The following still need review: scripts/ci: add gitlab-failure-analysis script docs/devel: fix typo in code-provenance.rst Alex. Alex Bennée (2): docs/devel: fix ty

[PATCH 03/25] checkpatch: Ignore removed lines in license check

2025-09-22 Thread Alex Bennée
start with "-" in the checkpatch script. Signed-off-by: Nabih Estefan Reviewed-by: Daniel P. Berrangé Reviewed-by: Alex Bennée Message-ID: <20250916165928.10048-1-nabiheste...@google.com> Signed-off-by: Alex Bennée --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertion

[PATCH 01/25] docs/devel: fix typo in code-provenance.rst

2025-09-22 Thread Alex Bennée
Signed-off-by: Alex Bennée --- docs/devel/code-provenance.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/code-provenance.rst b/docs/devel/code-provenance.rst index b5aae2e2532..af5d7349e12 100644 --- a/docs/devel/code-provenance.rst +++ b/docs/devel/code

Re: [PATCH 2/2] hw/pci-host/astro: Don't call pci_regsiter_root_bus() in init

2025-09-22 Thread Alex Bennée
gt; #4 0x5b2d477d29a5 in qmp_device_list_properties > /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/hppa-asan/../../qom/qom-qmp-cmds.c:206:11 > > Cc: qemu-sta...@nongnu.org > Fixes: e029bb00a79be ("hw/pci-host: Add Astro system bus adapter found on > PA-RISC machines") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3118 > Signed-off-by: Peter Maydell with the typo fix: Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 0/2] hw/pci-host: fix use-after-free in hppa pci-host devices

2025-09-22 Thread Alex Bennée
pci_register_root_bus() > in instance_init: we should only call this in realize, as all the > other callers do. > > These bugs show up if you run 'make check' with an ASAN enabled > build; they are also likely behind the intermittent segfaults > on s390 that RTH has not

Re: [PATCH v6 23/25] tests: add plugin asserting correctness of discon event's to_pc

2025-09-21 Thread Alex Bennée
fault: > +break; > +} > + > +report = g_string_new(NULL); > +g_string_append_printf(report, > + "Discon %s PC mismatch on VCPU %d\nExpected: > %" > + PRIx64"\nEncountered: %"PRIx64"\nExecuted Last: &

[PATCH v2] scripts/ci: add gitlab-failure-analysis script

2025-09-20 Thread Alex Bennée
ot;) failed pipeline 1919542960, total jobs 127, skipped 5, failed 2, 48753 tests, 441 skipped tests, 1 failed tests Failed test qemu.qemu:unit / test-aio, msys2-64bit, 12 /aio/timer/schedule - ERROR:../tests/unit/test-aio.c:413:test_timer_schedule: assertion failed: (aio_poll(ctx, true)) Signed

Re: [PATCH 1/4] gitlab: replace avocado results files with meson results files

2025-09-20 Thread Alex Bennée
rtifacts. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [Qemu-devel] [PATCH] vfio/common: Work around kernel overflow bug in DMA unmap

2025-09-19 Thread Alex Williamson
On Thu, 18 Sep 2025 22:55:47 +0200 Cédric Le Goater wrote: > Alex, Peter, > > On 1/10/19 00:10, Alex Williamson wrote: > > A kernel bug was introduced in v4.15 via commit 71a7d3d78e3c which > > adds a test for address space wrap-around in the vfio DMA unmap path. >

Re: [PATCH] plugins: Add PC diversion API function

2025-09-19 Thread Alex Bennée
n_write_register(struct > qemu_plugin_register *reg, > return gdb_write_register(current_cpu, buf->data, GPOINTER_TO_INT(reg) - > 1); > } > > +void qemu_plugin_set_pc(uint64_t vaddr) > +{ > +g_assert(current_cpu); > + > +cpu_set_pc(current_cpu, vaddr)

Re: [PATCH 2/6] tests/functional: convert reverse debug test to local gdb module

2025-09-18 Thread Alex Bennée
Daniel P. Berrangé writes: > This replaces the use of Avocado for the GDBRemote class with > our in-tree copy. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v7 0/9] contrib/plugins: uftrace

2025-09-18 Thread Alex Bennée
Pierrick Bouvier writes: > This plugin generates a binary trace compatible with the excellent uftrace: > https://github.com/namhyung/uftrace Queued to plugins/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v4 00/12] single-binary: compile once semihosting

2025-09-18 Thread Alex Bennée
Pierrick Bouvier writes: > This series compiles once semihosting files in system mode. > The most complicated file was semihosting/arm-compat-semi.c, which was > carefully > cleaned in easy to understand steps. Queued to semihosting/next, thanks. -- Alex Bennée Virtualisati

Re: [PATCH 4/4] gitlab: prevent duplicated meson log artifacts in test jobs

2025-09-17 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Sep 08, 2025 at 10:21:38PM +0100, Alex Bennée wrote: >> Daniel P. Berrangé writes: >> >> > The build jobs will populate build/meson-logs/ with various files >> > that are added as artifacts. >> > >> > The

Re: [PATCH v6 00/25] tcg-plugins: add hooks for discontinuities

2025-09-17 Thread Alex Bennée
than a few > seconds if I can find the motivation to set up everything I'd need to > compile your benchmark. In the mean-time, you are welcome to make your > own measurements if you want to. The patches are also availible at [1] > if you don't want to apply them to your local tree yourself. Balton, I don't think worries about performance impact are justified and Julian has certainly done enough due diligence here. If you can come up with a repeatable test that shows a measurable impact then please do so. > > Regards, > Julian > > [1]: > https://github.com/patchew-project/qemu/tree/patchew/cover.1757018626.git.neither@nut.email -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: Question: ThreadSanitizer support in QEMU user-mode

2025-09-17 Thread Alex Bennée
#x27;t track. > > Thanks in advance for clarification, > Arek -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 6/6] tests/functional: use self.log for all logging

2025-09-17 Thread Alex Bennée
Daniel P. Berrangé writes: > Some tests are creating their on logger category which means any > output they log is not captured in base.log. This seems unrelated to reverse debugging and perhaps should be split to each test. But otherwise LGTM: Reviewed-by: Alex Bennée -- Alex

[RFC PATCH] scripts/ci: add gitlab-failure-analysis script

2025-09-17 Thread Alex Bennée
This is a script designed to collect data from multiple pipelines and analyse the failure modes they have. Signed-off-by: Alex Bennée --- scripts/ci/gitlab-failure-analysis | 65 ++ 1 file changed, 65 insertions(+) create mode 100755 scripts/ci/gitlab-failure

Re: [PATCH] checkpatch: Ignore removed lines in license check

2025-09-17 Thread Alex Bennée
s by skipping over lines that start with "-" in the checkpatch > script. > > Signed-off-by: Nabih Estefan Queued to testing/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] checkpatch: Ignore removed lines in license check

2025-09-17 Thread Alex Bennée
s by skipping over lines that start with "-" in the checkpatch > script. > > Signed-off-by: Nabih Estefan Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] .gitlab-ci.d/buildtest.yml: Unset CI_COMMIT_DESCRIPTION for htags

2025-09-16 Thread Alex Bennée
t;.gitlab-ci.d/buildtest.yml: Work around htags bug when > environment is large") > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC 3/6] virtio-gpu-udmabuf: Create dmabuf for blobs associated with VFIO devices

2025-09-15 Thread Alex Bennée
vfio_create_dmabuf(). > > Note that we only call virtio_gpu_remap_udmabuf() if the blob is > backed by a memfd. This is because the VFIO dmabuf implementation > may not support mmap. > > Cc: Marc-André Lureau > Cc: Alex Bennée > Cc: Akihiko Odaki > Cc: Dmitry Osipenko >

Re: [RFC PATCH 0/2] tests/functional: Adapt reverse_debugging to run w/o Avocado (yet another try)

2025-09-15 Thread Alex Bennée
Thomas Huth writes: > On 15/09/2025 18.13, Alex Bennée wrote: >> Thomas Huth writes: >> >>> Here's yet another attempt to remove the avocado dependency from the >>> reverse debugging tests: I basically took Gustavo's patches to rework >>> t

Re: [RFC PATCH 2/2] tests/functional: Adapt reverse_debugging to run w/o Avocado

2025-09-15 Thread Alex Bennée
proach to importing the python modules. Caveat to proper splitting but you can at least have: Tested-by: Alex Bennée > --- > .../functional/aarch64/test_reverse_debug.py | 16 +- > tests/functional/ppc64/test_reverse_debug.py | 18 +- > tests/functional/reverse_debugging.p

Re: [RFC PATCH 0/2] tests/functional: Adapt reverse_debugging to run w/o Avocado (yet another try)

2025-09-15 Thread Alex Bennée
test.py and adding the cumbersome code > to support additional test execution logic, I kept our normal way of > running tests via pycotap. Hmm I was getting: 2025-09-15 17:10:50,798 - INFO: GDB CMD: /home/alex/src/tools/binutils-gdb.git/builds/all/install/bin/gdb -q -n -batch -ex 'set pag

Re: [RFC PATCH 1/2] tests/functional: Provide GDB to the functional tests

2025-09-15 Thread Alex Bennée
x27; / 'test_' + test + '.py') > @@ -121,6 +127,7 @@ foreach speed : ['quick', 'thorough'] > priority: time_out, > suite: suites) > endforeach > + spare newline? >endforeach > endforeach Otherwise: Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] target/mips: Fix msaregnames and mxuregnames off-by-one

2025-09-15 Thread Alex Bennée
tic const char mxuregnames[NUMBER_OF_MXU_REGISTERS][4] = { > +static const char mxuregnames[NUMBER_OF_MXU_REGISTERS][5] = { > "XR1", "XR2", "XR3", "XR4", "XR5", "XR6", "XR7", "XR8", > "XR9", "XR10", "XR11", "XR12", "XR13", "XR14", "XR15", "XCR", > }; Maybe not quite so silly question. Why are we setting 2D dimensions on the regnames anyway? Shouldn't we just use static const char * and be done with it? AFAICT all the references only care about the number anyway. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 4/6] tests/functional: drop datadrainer class in reverse debugging

2025-09-15 Thread Alex Bennée
ngs, but this test never tries to match anything. > > This isn't critical, so just drop the functionality. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] .gitmodules: move u-boot mirrors to qemu-project-mirrors

2025-09-15 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Sep 08, 2025 at 03:19:11PM +0100, Alex Bennée wrote: >> To continue our GitLab Open Source Program license we need to pass an >> automated license check for all repos under qemu-project. While U-Boot >> is clearly GPLv2 rather than fig

Re: [PATCH 4/6] tests/functional: drop datadrainer class in reverse debugging

2025-09-15 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Sep 15, 2025 at 11:18:09AM +0100, Alex Bennée wrote: >> Daniel P. Berrangé writes: >> >> > The reverse debugging test uses the avocado datadrainer class to >> > create a background thread that reads from the console so

Re: [PATCH 4/6] tests/functional: drop datadrainer class in reverse debugging

2025-09-15 Thread Alex Bennée
ngs, but this test never tries to match anything. > > This isn't critical, so just drop the functionality. We do end up with zero length logs for all console output although I don't know if we got that far before: ➜ find tests/functional/ -iwholename "*reverse_debug*log"

Re: [PATCH] virtio: Add function name to error messages

2025-09-15 Thread Alex Bennée
Device *vdev, const char *fmt, ...) > G_GNUC_PRINTF(2, 3); > > /* Set the child bus name. */ > void virtio_device_set_child_bus_name(VirtIODevice *vdev, char *bus_name); For completeness you could also fixup: virtio_error(vdev, "%s: %d reason unknown", __func__, pnd->reason); for virtio-ballon. Otherwise: Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

KVM/QEMU Community call 16/9/2025 agenda items

2025-09-15 Thread Alex Bennée
Hi, The KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 16/09/2025 13:00 UTC Are there any agenda items for the sync-up? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 0/6] tests/functional: remove last use of avocado.utils

2025-09-15 Thread Alex Bennée
de 100644 tests/functional/qemu_test/gdb.py > create mode 100644 tests/functional/qemu_test/gdbmi_parser.py > create mode 100644 tests/functional/qemu_test/spark.py -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 5/6] tests/functional: close GDB socket in reverse debugging test

2025-09-15 Thread Alex Bennée
Daniel P. Berrangé writes: > The GDB socket FD is leaked currently resulting in a warning from > python about the unclosed resource. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

  1   2   3   4   5   6   7   8   9   10   >