Re: [PATCH v3 0/5] More record/replay acceptance tests

2021-09-27 Thread dovgaluk
Dovgaluk (1): tests/acceptance: Linux boot test for record/replay Pavel Dovgalyuk (4): tests/acceptance: add replay kernel test for s390 tests/acceptance: add replay kernel test for openrisc tests/acceptance: add replay kernel test for nios2 tests/acceptance: add replay

Re: [PATCH] icount: make dma reads deterministic

2020-03-03 Thread dovgaluk
Kevin Wolf писал 2020-03-02 19:19: Am 02.03.2020 um 13:59 hat Pavel Dovgalyuk geschrieben: Windows guest sometimes makes DMA requests with overlapping target addresses. This leads to the following structure of iov for the block driver: addr size1 addr size2 addr size3 It means that three adjac

Re: Race condition in overlayed qcow2?

2020-02-24 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-25 10:27: 25.02.2020 8:58, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-21 16:23: 21.02.2020 15:35, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-21 13:09: 21.02.2020 12:49, dovgaluk wrote: Vladimir Sementsov-Ogievskiy

Re: Race condition in overlayed qcow2?

2020-02-24 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-21 16:23: 21.02.2020 15:35, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-21 13:09: 21.02.2020 12:49, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-20 12:36: 1 or 2 are ok, and 4 or 8 lead to the failures. That is strange

Re: Race condition in overlayed qcow2?

2020-02-21 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-21 13:09: 21.02.2020 12:49, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-20 12:36: 1 or 2 are ok, and 4 or 8 lead to the failures. That is strange. I could think, that it was caused by the bugs in deterministic CPU execution, but the

Re: Race condition in overlayed qcow2?

2020-02-21 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-20 12:36: 20.02.2020 12:05, Vladimir Sementsov-Ogievskiy wrote: 20.02.2020 11:31, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-19 19:07: 19.02.2020 17:32, dovgaluk wrote: I encountered a problem with record/replay of QEMU execution and

Re: Race condition in overlayed qcow2?

2020-02-20 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-19 19:07: 19.02.2020 17:32, dovgaluk wrote: I encountered a problem with record/replay of QEMU execution and figured out the following, when QEMU is started with one virtual disk connected to the qcow2 image with applied 'snapshot' option.

Race condition in overlayed qcow2?

2020-02-19 Thread dovgaluk
Hi! I encountered a problem with record/replay of QEMU execution and figured out the following, when QEMU is started with one virtual disk connected to the qcow2 image with applied 'snapshot' option. The patch d710cf575ad5fb3ab329204620de45bfe50caa53 "block/qcow2: introduce parallel subreque

Re: [RFC PATCH 06/10] hw/avr: Add ATmega microcontrollers

2019-11-28 Thread dovgaluk
Aleksandar Markovic писал 2019-11-28 13:20: On Thursday, November 28, 2019, dovgaluk wrote: Aleksandar Markovic писал 2019-11-28 12:28: On Thursday, November 28, 2019, Philippe Mathieu-Daudé wrote: Add famous ATmega MCUs: - middle range: ATmega168 and ATmega328 - high range: ATmega1280 and

Re: [RFC PATCH 06/10] hw/avr: Add ATmega microcontrollers

2019-11-28 Thread dovgaluk
Aleksandar Markovic писал 2019-11-28 12:28: On Thursday, November 28, 2019, Philippe Mathieu-Daudé wrote: Add famous ATmega MCUs: - middle range: ATmega168 and ATmega328 - high range: ATmega1280 and ATmega2560 Signed-off-by: Philippe Mathieu-Daudé --- Philippe, hi. Thank you for the impe

Re: [Qemu-devel] [PULL 15/36] memory: fix race between TCG and accesses to dirty bitmap

2019-08-26 Thread dovgaluk
This patch breaks the execution recording. While vCPU tries to lock replay mutex in main while loop, vga causes dirty memory sync and do_run_on_cpu call. This call waits for vCPU to process the work queue. Pavel Dovgalyuk Paolo Bonzini писал 2019-08-20 09:59: There is a race between TCG and acc

Re: [Qemu-devel] [PATCH for-4.1 00/24] Fix record/replay and add reverse debugging

2019-06-27 Thread dovgaluk
Paolo, what about merging reviewed and acked patches before the soft freeze? Pavel Dovgalyuk Pavel Dovgalyuk писал 2019-06-21 11:20: GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous s

Re: [Qemu-devel] [PATCH v12 00/25] Fixing record/replay and adding reverse debugging

2019-02-11 Thread dovgaluk
Markus Armbruster писал 2019-02-12 10:14: "Pavel Dovgalyuk" writes: Ping? Are you pinging for more review, or for someone to merge this? From my point of view this patch set is ready. Pavel Dovgalyuk

Re: [Qemu-devel] [PATCH v6 00/25] Fixing record/replay and adding reverse debugging

2018-10-02 Thread dovgaluk
ues I encounter. I'll try 'info monitor' command tomorrow, but no guarantees that I'll be able to reproduce issue again. Speaking about '-nographic' and SDL... I've noted that UI greatly minimizes possibility of hanging (but not avoids it completely) when using ico

Re: [Qemu-devel] [PATCH v6 00/25] Fixing record/replay and adding reverse debugging

2018-10-01 Thread dovgaluk
Artem Pisarenko писал 2018-09-30 14:01: Feature still broken :( Thanks for testing. Brief description of my tests. Guest image is Linux, which just powers off after kernel boots (instead of proceeding to user-space /init or /sbin/init). Base cmdline: qemu-system-x86_64 -nodefaults -machine

Re: [Qemu-devel] [PATCH v5 00/24] Fixing record/replay and adding reverse debugging

2018-09-12 Thread dovgaluk
Hi, Ciro! I found several issues in your command lines. Ciro Santilli писал 2018-08-08 02:13: OK, finally got some time to try it out, I'm using c42634d8e3428cfa60672c3ba89cabefc720cde9 from rr-180725. Replay works well as far as I can tell, so I moved to the reverse debugging: /home/ciro/bak

Re: [Qemu-devel] [PATCH v3 0/5] Deterministic replay extensions

2016-03-06 Thread dovgaluk
Ping? Pavel Dovgalyuk Pavel Dovgalyuk писал 2016-03-01 14:07: This set of patches is related to the reverse execution and deterministic replay of qemu execution. It includes recording and replaying of serial devices and block devices operations. With these patches one can record and determin

Re: [Qemu-devel] [PULL v3 00/18] Record/replay core for 2.5-rc1

2015-11-07 Thread dovgaluk
Paolo Bonzini писал 2015-11-06 15:59: On 06/11/2015 13:26, Peter Maydell wrote: Applied, thanks. Let's hope it doesn't break too much :-) (Seriously, it's good to see this getting into the tree finally. Do we have some documentation we can point to in the release notes about how to use it?) U

Re: [Qemu-devel] [PULL 00/18] Record/replay core for 2.5-rc1

2015-11-05 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 05/11/2015 15:00, Peter Maydell wrote: > > On 5 November 2015 at 12:13, Paolo Bonzini wrote: > >> The following changes since commit > >> 6c5f30cad290c745f910481d0e890b3f4fad1f00: > >> > >> Merge remote-tracking branch > >> 'remotes/juanq

Re: [Qemu-devel] [RFH PATCH 0/4] record/replay fixups and doubts

2015-10-23 Thread Pavel Dovgaluk
Hi, Paolo! Will you pull these patches into 2.5? Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [RFH

Re: [Qemu-devel] [RFH PATCH 0/4] record/replay fixups and doubts

2015-10-13 Thread Pavel Dovgaluk
There is one more fix. Sometimes replay cannot continue after stopping/restarting of the virtual machine. This happens because warp on stopped machine and on running machine behaves differently. Timers deadline calculation depends on enabled flag of the virtual timer. The following patch fixes th

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 07/10/2015 10:21, Pavel Dovgaluk wrote: > > There are two kinds of events: > > - read from the log and injected immediately (user input, network input) > > - read from the log and w

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 07/10/2015 12:42, Pavel Dovgaluk wrote: > >> > Ok, got it. I still want to understand exactly the need for the init > >> > and reset checkpoints, and the placement of qemu_clock_warp calls, but > >> &g

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 07/10/2015 11:50, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > >> Bonzini > >> On 07/10/2015 10:21, Pavel Dovgaluk wrote: > >>> There are t

Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Pavel Dovgaluk
I checked this patch. Let's leave it without runstate_is_running() call. If it will be needed later, we'll find it out. Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > T

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > > It is not clear what separates REPLAY_ASYNC_EVENT_BH from other async > events. It seems to be an ordering issue, but then why do input events > not have to be looked up in the queue? It would be much simple

Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [PATCH 3/4] why is runstate_is_running needed? > > It doesn't seem correct to call it for all checkp

Re: [Qemu-devel] [PATCH 2/4] more replay fixes

2015-10-07 Thread Pavel Dovgaluk
This one is ok too. Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [PATCH 2/4] more replay fixes >

Re: [Qemu-devel] [PATCH 1/4] replay: generalize ptimer event to bottom halves

2015-10-07 Thread Pavel Dovgaluk
This one is ok. Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [PATCH 1/4] replay: generalize ptimer

Re: [Qemu-devel] [PULL 50/52] typedef: add typedef for QemuOpts

2015-09-27 Thread Pavel Dovgaluk
Thank you! What about other patches from rr series? Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, September 25, 2015 7:52 PM > To: qemu-devel@nongnu.org > Cc: Pavel Dovgalyuk; Pavel Dovgalyuk > Subject: [PULL 50/52] typedef: add t

Re: [Qemu-devel] [PATCH v18 13/21] icount: improve counting for record/replay

2015-09-23 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 23/09/2015 09:22, Pavel Dovgaluk wrote: > > Sometimes tcg thread halts in qemu_tcg_wait_io_event function, > > waiting for any external event. Virtual clock does not run, because > &g

Re: [Qemu-devel] [PATCH v18 13/21] icount: improve counting for record/replay

2015-09-23 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 17/09/2015 18:24, Pavel Dovgalyuk wrote: > > #endif > > > > +/* CPU thread can infinitely wait for event after > > + missing the warp */ > > +qemu_clock_warp(QEMU_CLOCK_VIRTUAL); > > qemu_clock_run_all_timers(); > > It is

Re: [Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks

2015-09-23 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 17/09/2015 18:24, Pavel Dovgalyuk wrote: > > +if ((now < last || now > (last + get_max_clock_jump())) > > +&& replay_mode == REPLAY_MODE_NONE) { > > notifier_list_notify(&clock->reset_notifiers, &now); > > Thi

Re: [Qemu-devel] [PATCH v18 00/21] Deterministic replay core

2015-09-21 Thread Pavel Dovgaluk
Hi! Paolo, have you reviewed these patches? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Thursday, September 17, 2015 7:23 PM > To: qemu-devel@nongnu.org > Cc: edgar.igles...@xilinx.com; peter.mayd...@linaro.org; > igor.rubi...@g

Re: [Qemu-devel] [PATCH v7 04/11] target-mips: improve exception handling

2015-09-16 Thread Pavel Dovgaluk
> From: Leon Alrae [mailto:leon.al...@imgtec.com] > On 28/08/2015 10:08, Pavel Dovgaluk wrote: > >> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > >> On 2015-08-13 14:12, Leon Alrae wrote: > >>> On 10/07/2015 10:57, Pavel Dovgalyuk wrote: > &

Re: [Qemu-devel] [PATCH v17 00/21] Deterministic replay core

2015-09-10 Thread Pavel Dovgaluk
Paolo, Are these patches good enough? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Monday, September 07, 2015 11:40 AM > To: qemu-devel@nongnu.org > Cc: edgar.igles...@xilinx.com; peter.mayd...@linaro.org; > igor.rubi...@gmail.co

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread dovgaluk
Lluís Vilanova писал 2015-09-04 16:00: Mark Burton writes: [...] * What to do about icount? What is the impact of multi-thread on icount? Do we need to disable it for MTTCG or can it be correct per-cpu? Can it be updated lock-step? We need some input from the guys that use icount the most.

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread dovgaluk
Hi! Alex Bennée писал 2015-09-04 10:49: * What to do about icount? What is the impact of multi-thread on icount? Do we need to disable it for MTTCG or can it be correct per-cpu? Can it be updated lock-step? Why can't we have separate icount for each CPU? Then virtual timer will be assigned to

Re: [Qemu-devel] [PATCH v7 04/11] target-mips: improve exception handling

2015-08-28 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-08-13 14:12, Leon Alrae wrote: > > On 10/07/2015 10:57, Pavel Dovgalyuk wrote: > > > @@ -2364,14 +2363,12 @@ static void gen_st_cond (DisasContext *ctx, > > > uint32_t opc, int rt, > > > #if defined(TARGET_MIPS64) > > > case OPC_

Re: [Qemu-devel] [PATCH v16 00/21] Deterministic replay core

2015-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > unfortunately I do have some more review comments; that can happen when > going back to the code after a few months, and it's also a good thing > because it means that the code _is_ actually getting cleaner. Tha

Re: [Qemu-devel] [PATCH v6 09/10] target-i386: exception handling for other helper functions

2015-07-08 Thread Pavel Dovgaluk
> From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard > Henderson > On 07/07/2015 02:31 PM, Pavel Dovgalyuk wrote: > > diff --git a/target-i386/misc_helper.c b/target-i386/misc_helper.c > > index 52c5d65..c8e7ee9 100644 > > --- a/target-i386/misc_helper.c > > +++ b/target-i386/

Re: [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling for seg_helper functions

2015-07-07 Thread Pavel Dovgaluk
> From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard > Henderson > On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote: > > This patch fixes exception handling for seg_helper functions. > > > > Signed-off-by: Pavel Dovgalyuk > > > No, you don't want to discriminately change every

Re: [Qemu-devel] [PATCH v5 05/11] target-i386: exception handling for FPU instructions

2015-07-06 Thread Pavel Dovgaluk
> From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard > Henderson > On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote: > > @@ -1117,33 +1131,33 @@ void helper_fxsave(CPUX86State *env, target_ulong > > ptr, int data64) > > for (i = 0; i < 8; i++) { > > fptag |= (env

Re: [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling for seg_helper functions

2015-07-06 Thread Pavel Dovgaluk
> From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard > Henderson > On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote: > > This patch fixes exception handling for seg_helper functions. > > > > Signed-off-by: Pavel Dovgalyuk > > > No, you don't want to discriminately change every

Re: [Qemu-devel] [PATCH v15 00/21] Deterministic replay core

2015-07-06 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 06/07/2015 13:54, Pavel Dovgaluk wrote: > > Paolo, > > > > Are there any chances for upstreaming these patches? > > I'm sorry. It looks like no one really feels competent enough. What > about committi

Re: [Qemu-devel] [PATCH v15 00/21] Deterministic replay core

2015-07-06 Thread Pavel Dovgaluk
Paolo, Are there any chances for upstreaming these patches? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Wednesday, July 01, 2015 2:52 PM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; peter.crosthwa...@xilinx.com; >

Re: [Qemu-devel] [PATCH v4 4/5] target-i386: fix memory operations in helpers

2015-07-01 Thread Pavel Dovgaluk
> From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard > Henderson > On 06/29/2015 08:23 AM, Pavel Dovgalyuk wrote: > > This patch passes TB return address into softmmu functions that are > > invoked from target helpers. This allows correct PC and icount recovering > > while han

Re: [Qemu-devel] [PATCH v4 0/5] Fix exceptions handling for MIPS and i386

2015-06-29 Thread Pavel Dovgaluk
Forgot to fix the subject. These patches also fix exceptions handling for PowerPC. Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Monday, June 29, 2015 10:23 AM > To: qemu-devel@nongnu.org > Cc: rth7...@gmail.com; ag...@suse.de; pav

Re: [Qemu-devel] [PATCH v3 2/3] target-mips: improve exceptions handling

2015-06-28 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-18 16:28, Pavel Dovgalyuk wrote: > > This patch improves exception handling in MIPS. > > Instructions generate several types of exceptions. > > When exception is generated, it breaks the execution of the current > > translation > >

Re: [Qemu-devel] [PATCH v3 1/3] softmmu: add helper function to pass through retaddr

2015-06-25 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-18 16:28, Pavel Dovgalyuk wrote: > > This patch introduces several helpers to pass return address > > which points to the TB. Correct return address allows correct > > restoring of the guest PC and icount. These functions should be u

Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h

2015-06-24 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 24/06/2015 13:40, Pavel Dovgaluk wrote: > >>> > > +/* If not executing code then assume we are ok. */ > >>> > > +if (cpu->current_tb == NULL) { > >>> > > +ret

Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h

2015-06-24 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 31/05/2015 08:11, Peter Crosthwaite wrote: > > +/* If not executing code then assume we are ok. */ > > +if (cpu->current_tb == NULL) { > > +return true; > > +} > > +return cpu->can_do_

Re: [Qemu-devel] [PATCH v2 0/3] Fix exceptions handling for MIPS and i386

2015-06-18 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-18 12:02, Paolo Bonzini wrote: > > > > TCG can then use them to fill in an array stored inside the > > TranslationBlock, together with the host PC. Since the gen_opc_pc, > > gen_opc_instr_start, gen_opc_icount arrays are inside tcg_

Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-18 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 18/06/2015 11:24, Pavel Dovgaluk wrote: > >>> > > +uint16_t helper_call_ldw_cmmu(CPUArchState *env, target_ulong addr, > >>> > > + int mmu_idx, uintptr_t retaddr); > &

Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-18 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 17/06/2015 14:42, Pavel Dovgalyuk wrote: > > This patch introduces several helpers to pass return address > > which points to the TB. Correct return address allows correct > > restoring of the guest PC and icount. These functions should be use

Re: [Qemu-devel] [PATCH v2 0/3] Fix exceptions handling for MIPS and i386

2015-06-18 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-18 10:12, Pavel Dovgaluk wrote: > > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > > On 2015-06-17 15:41, Pavel Dovgalyuk wrote: > > > > In icount mode every translation block looks a

Re: [Qemu-devel] [PATCH v2 0/3] Fix exceptions handling for MIPS and i386

2015-06-18 Thread Pavel Dovgaluk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 18 June 2015 at 08:12, Pavel Dovgaluk wrote: > >> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > >> Looking at how icount work, I see it's basically a variable in the CPU > >> state (icount_de

Re: [Qemu-devel] [PATCH v2 0/3] Fix exceptions handling for MIPS and i386

2015-06-18 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-17 15:41, Pavel Dovgalyuk wrote: > > In icount mode every translation block looks as follows: > > > > if icount < n then exit > > icount -= n > > instr1 > > instr2 > > ... > > instrn > > exit > > > > When one of these instructions in

Re: [Qemu-devel] [PATCH v2 0/3] Fix exceptions handling for MIPS and i386

2015-06-17 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-17 15:41, Pavel Dovgalyuk wrote: > > This set of patches fixes exception handling for MIPS and i386 targets. > > These targets contain instructions that break correct execution in > > icount/TCG modes (MIPS) and in regular TCG mode (

Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-17 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 17/06/2015 14:42, Pavel Dovgalyuk wrote: > > This patch introduces several helpers to pass return address > > which points to the TB. Correct return address allows correct > > restoring of the guest PC and icount. These functions should be use

Re: [Qemu-devel] [PATCH] MIPS: exceptions handling in icount mode

2015-06-15 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-15 07:53, Pavel Dovgaluk wrote: > > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > > On 2015-06-10 11:33, Pavel Dovgalyuk wrote: > > > > This patch fixes exception handling in MIPS

Re: [Qemu-devel] [PATCH] MIPS: exceptions handling in icount mode

2015-06-15 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-15 07:53, Pavel Dovgaluk wrote: > > > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > > > On 2015-06-10 11:33, Pavel Dovgalyuk wrote: > > > > This patch fixes exception handling in MIPS

Re: [Qemu-devel] [PATCH] MIPS: exceptions handling in icount mode

2015-06-14 Thread Pavel Dovgaluk
> From: Aurelien Jarno [mailto:aurel...@aurel32.net] > On 2015-06-10 11:33, Pavel Dovgalyuk wrote: > > This patch fixes exception handling in MIPS. > > MIPS instructions generate several types of exceptions. > > When exception is generated, it breaks the execution of the current > > translation >

Re: [Qemu-devel] [PATCH v14 21/21] replay: ptimer

2015-05-25 Thread Pavel Dovgaluk
Broken description. This one is correct: replay: recording of the user input This records user input (keyboard and mouse events) in record mode and replays these input events in replay mode. Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] >

Re: [Qemu-devel] [RFC PATCH v13 00/21] Deterministic replay core

2015-05-19 Thread Pavel Dovgaluk
Ping? > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Wednesday, May 06, 2015 5:03 PM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; peter.crosthwa...@xilinx.com; ebl...@redhat.com; > mark.bur...@greensocs.com; r...@ispras.ru; batuz...@is

Re: [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ?

2015-05-12 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 12/05/2015 17:32, Peter Maydell wrote: > > In order for -icount to work, it's important for the target > > translate.c code to correctly bracket any generated code which > > can "do I/O" with gen_io_start()/ge

Re: [Qemu-devel] [RFC PATCH v13 15/21] bottom halves: introduce bh call function

2015-05-06 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 06/05/2015 16:04, Pavel Dovgalyuk wrote: > > This patch introduces aio_bh_call function. It is used to execute > > bottom halves as callbacks without adding them to the queue. > > > > Signed-off-by: Pavel Dovgalyuk > > --- > > async.c

Re: [Qemu-devel] [RFC PATCH v12 16/21]

2015-05-06 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 05/05/2015 12:22, Pavel Dovgaluk wrote: > > This patch is the reduced version of prior "bottom halves" patch. > > dma-helpers.c is also related to block devices, so it's better not to > change it now.

Re: [Qemu-devel] [RFC PATCH v12 16/21]

2015-05-05 Thread Pavel Dovgaluk
This patch is the reduced version of prior "bottom halves" patch. Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Tuesday, May 05, 2015 1:19 PM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; peter.crosthwa...@xilinx.com;

Re: [Qemu-devel] [RFC PATCH v11 00/23] Deterministic replay core

2015-05-05 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 27/04/2015 09:32, Pavel Dovgalyuk wrote: > > This set of patches is related to the reverse execution and deterministic > > replay of qemu execution. This implementation of deterministic replay can > > be used for deterministic debugging of gue

Re: [Qemu-devel] [RFC PATCH v10 18/24] replay: replay aio requests

2015-03-16 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 27/02/2015 14:11, Pavel Dovgalyuk wrote: > > This patch adds identifier to aio requests. ID is used for creating bottom > > halves and identifying them while replaying. > > The patch also introduces several functions that make possible replayi

Re: [Qemu-devel] [RFC PATCH v9 00/23] Deterministic replay core

2015-02-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 18/02/2015 12:55, Pavel Dovgalyuk wrote: > > This set of patches is related to the reverse execution and deterministic > > replay of qemu execution. This implementation of deterministic replay can > > be used

Re: [Qemu-devel] [RFC PATCH v9 22/23] replay: command line options

2015-02-20 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 18/02/2015 12:57, Pavel Dovgalyuk wrote: > > @@ -2751,6 +2757,7 @@ int main(int argc, char **argv, char **envp) > > { > > int i; > > int snapshot, linux_boot; > > +const char *icount_option = NU

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 17/02/2015 09:43, Pavel Dovgaluk wrote: > >> > int64_t deadline = qemu_clock_deadline_ns_all(QEMU_CLOCK_VIRTUAL); > >> > if (deadline == 0) { > >> > qemu_clock_notify(QEMU_CLOCK_VIR

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 16/02/2015 14:37, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > >> Bonzini > >> On 16/02/2015 14:27, Pavel Dovgal

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 16/02/2015 14:27, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > >> Bonzini > >> On 16/02/2015 13:26, Pavel Dovga

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 16/02/2015 13:26, Pavel Dovgaluk wrote: > >>> > > I think in this case there are no events at all - just reading timers > >>> > > values > >>> > &

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 02/02/2015 13:42, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> On 02/02/2015 13:28, Pavel Dovgaluk wrote: > >>>>>>>

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

2015-02-12 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 09/02/2015 13:15, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >>> break; > >>> case QEMU_OPTION_audio_help: > >>>

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-12 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > +if (replay_mode != REPLAY_MODE_PLAY) { > > +evt = qemu_input_event_new_key(key, down); > > +if (QTAILQ_EMPTY(&kbd_queue)) { > > +qe

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-11 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > +void replay_input_event(QemuConsole *src, InputEvent *evt) > > +{ > > +if (replay_mode == REPLAY_MODE_PLAY) { > > +/* Nothing */ > > +} else if (re

Re: [Qemu-devel] [RFC PATCH v8 16/21] replay: bottom halves

2015-02-11 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > This patch introduces bottom half event for replay queue. It saves the > > events > > into the queue and process them at the checkpoints and instructions > > execution. > > Which bottom halves mu

Re: [Qemu-devel] [PATCH] win64: perform correct setjmp calls

2015-02-09 Thread Pavel Dovgaluk
> From: Stefan Weil [mailto:s...@weilnetz.de] > Am 09.02.2015 um 09:07 schrieb Pavel Dovgaluk: > >> From: Stefan Weil [mailto:s...@weilnetz.de] > >> Am 09.02.2015 um 08:55 schrieb Pavel Dovgalyuk: > >>> On w64, setjmp is implemented by _setjmp which needs a se

Re: [Qemu-devel] [RFC PATCH v8 19/21] replay: initialization and deinitialization

2015-02-09 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > This patch introduces the functions for enabling the record/replay and for > > freeing the resources when simulator closes. > > > > Signed-off-by: Pavel Dovgalyuk > > > }; > > > > /* Asynchronou

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

2015-02-09 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > This patch introduces command line options for enabling recording or > > replaying > > virtual machine behavior. "-record" option starts recording of the execution > > and saves it into the log, sp

Re: [Qemu-devel] [PATCH] win64: perform correct setjmp calls

2015-02-09 Thread Pavel Dovgaluk
> From: Stefan Weil [mailto:s...@weilnetz.de] > Am 09.02.2015 um 08:55 schrieb Pavel Dovgalyuk: > > On w64, setjmp is implemented by _setjmp which needs a second parameter. > > This parameter should be NULL to allow using longjump from generated code. > > This patch replaces all usages of setjmp.h

Re: [Qemu-devel] [RFC PATCH v8 12/21] replay: recording and replaying different timers

2015-02-03 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > This patch introduces functions for recording and replaying realtime > > sources, > > that do not use qemu-clock interface. These include return value of time() > > function in time_t and struct tm

Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying clock ticks

2015-02-03 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 03/02/2015 11:51, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > >>> Clock ticks are considered as the sources of non-determin

Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying clock ticks

2015-02-03 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > Clock ticks are considered as the sources of non-deterministic data for > > virtual machine. This patch implements saving the clock values when they > > are acquired (virtual, host clock, rdtsc, and

Re: [Qemu-devel] [RFC PATCH v8 00/21] Deterministic replay core

2015-02-02 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 22/01/2015 09:51, Pavel Dovgalyuk wrote: > > These patches include only core function of the replay, > > excluding the support for replaying serial, audio, network, and USB devices' > > operations. Reverse deb

Re: [Qemu-devel] [RFC PATCH v8 09/21] replay: interrupts and exceptions

2015-02-02 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > +if (replay_mode == REPLAY_MODE_RECORD) { > > +replay_save_instructions(); > > +replay_put_event(EVENT_EXCEPTION); > > +return true; > > Missing mutex lock/unlock. I th

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-02 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 02/02/2015 13:28, Pavel Dovgaluk wrote: > >>> > > cpu->exception_index = EXCP_INTERRUPT; > >>> > > next_tb = 0; > >&g

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-02 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > This patch adds calls to replay functions into the icount setup block. > > In record mode number of executed instructions is written to the log. > > In replay mode number of istructions to execute i

Re: [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for replay log

2015-01-30 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:51, Pavel Dovgalyuk wrote: > > This patch adds functions to perform read and write operations > > with replay log. > > > > Signed-off-by: Pavel Dovgalyuk > > --- > > +void replay_check_error(void) > > Could this be static? (I h

Re: [Qemu-devel] [RFC PATCH v8 00/21] Deterministic replay core

2015-01-28 Thread Pavel Dovgaluk
Ping? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Thursday, January 22, 2015 11:52 AM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; peter.crosthwa...@xilinx.com; ebl...@redhat.com; > mark.bur...@greensocs.com; r...@i

Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-22 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 13/01/2015 10:15, Pavel Dovgaluk wrote: > > The numbers have no meaning. They just have to be distinct in different > > places. > > This is easier to achieve if you give a name to each place. > > > Sorry,

Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks

2015-01-19 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 19/01/2015 14:10, Pavel Dovgaluk wrote: > >>> > > > >>> > > Because 'A' is written only inside some of the replay_run_event > >>> > > callbacks. > >>> >

Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks

2015-01-19 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 19/01/2015 14:01, Pavel Dovgaluk wrote: > > > It would be easier if you pointed me to actual code in the series. But > > > this doesn't seem impossible to fix by atomically writing the 'E' and

Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks

2015-01-19 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 19/01/2015 13:43, Pavel Dovgaluk wrote: > > > For example, why can't replay_run_event (or something > > > that it calls) take the replay lock locally, when it writes to the log? > > > > replay_run

Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks

2015-01-19 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 19/01/2015 13:03, Pavel Dovgaluk wrote: > > It will work for protecting the events list (I've already did this). > > But that will not work for protecting the log file. > > replay_run_event can write some data to

  1   2   3   >